comparison plugin/PluginXml.cpp @ 1830:5f8fbbde08ff audio-source-refactor

Use shared_ptr for plugin instances throughout

 #include <vamp-hostsdk/PluginBase.h>
 #include "RealTimePluginInstance.h"
 
 #include <iostream>
 
-PluginXml::PluginXml(Vamp::PluginBase *plugin) :
+using std::shared_ptr;
+using std::dynamic_pointer_cast;
+
+PluginXml::PluginXml(shared_ptr<Vamp::PluginBase> plugin) :
     m_plugin(plugin)
 {
 }
 
 PluginXml::~PluginXml() { }

         stream << QString("param-%1=\"%2\" ")
             .arg(stripInvalidParameterNameCharacters(QString(i->identifier.c_str())))
             .arg(m_plugin->getParameter(i->identifier));
     }
 
-    RealTimePluginInstance *rtpi =
-        dynamic_cast<RealTimePluginInstance *>(m_plugin);
+    auto rtpi = dynamic_pointer_cast<RealTimePluginInstance>(m_plugin);
     if (rtpi) {
         std::map<std::string, std::string> configurePairs =
             rtpi->getConfigurePairs();
         QString config;
         for (std::map<std::string, std::string>::iterator i = configurePairs.begin();

     int version = attrs.value("version").trimmed().toInt(&ok);
     if (ok && version != m_plugin->getPluginVersion()) {
         cerr << "WARNING: PluginXml::setParameters: Plugin version does not match (attributes have " << version << ", my version is " << m_plugin->getPluginVersion() << ")" << endl;
     }
 
-    RealTimePluginInstance *rtpi =
-        dynamic_cast<RealTimePluginInstance *>(m_plugin);
+    auto rtpi = dynamic_pointer_cast<RealTimePluginInstance>(m_plugin);
     if (rtpi) {
         QString config = attrs.value("configuration");
         if (config != "") {
             QStringList configList = config.split(";");
             for (QStringList::iterator i = configList.begin();