comparison base/View.cpp @ 31:4afaf0df4d51

* Add TextModel and TextLayer types
* Make View refresh work better when editing a model (previously edits might
  not be refreshed if their visible changed area extended beyond the strict
  frame range that was being modified in the model)
* Add phase-adjusted instantaneous frequency display to spectrogram layer
  (still a work in progress)
* Pull maths aliases out into a separate header in dsp/maths so MathUtilities
  can be included without introducing them

     QObject *obj = sender();
 
 #ifdef DEBUG_VIEW_WIDGET_PAINT
     std::cerr << "View(" << this << ")::modelChanged()" << std::endl;
 #endif
-    delete m_cache;
-    m_cache = 0;
+    
+    // If the model that has changed is not used by any of the cached
+    // layers, we won't need to recreate the cache
+    
+    bool recreate = false;
+
+    bool discard;
+    LayerList scrollables = getScrollableBackLayers(false, discard);
+    for (LayerList::const_iterator i = scrollables.begin();
+	 i != scrollables.end(); ++i) {
+	if (*i == obj || (*i)->getModel() == obj) {
+	    recreate = true;
+	    break;
+	}
+    }
+
+    if (recreate) {
+	delete m_cache;
+	m_cache = 0;
+    }
 
     checkProgress(obj);
 
     update();
 }

     if (startFrame > myEndFrame) {
 	checkProgress(obj);
 	return;
     }
 
-    delete m_cache;
-    m_cache = 0;
+    // If the model that has changed is not used by any of the cached
+    // layers, we won't need to recreate the cache
+    
+    bool recreate = false;
+
+    bool discard;
+    LayerList scrollables = getScrollableBackLayers(false, discard);
+    for (LayerList::const_iterator i = scrollables.begin();
+	 i != scrollables.end(); ++i) {
+	if (*i == obj || (*i)->getModel() == obj) {
+	    recreate = true;
+	    break;
+	}
+    }
+
+    if (recreate) {
+	delete m_cache;
+	m_cache = 0;
+    }
 
     if (long(startFrame) < myStartFrame) startFrame = myStartFrame;
     if (endFrame > myEndFrame) endFrame = myEndFrame;
 
     int x0 = getXForFrame(startFrame);
     int x1 = getXForFrame(endFrame + 1);
     if (x1 < x0) x1 = x0;
 
     checkProgress(obj);
 
-    update(x0, 0, x1 - x0 + 1, height());
+    update();
+//!!    update(x0, 0, x1 - x0 + 1, height());
 }    
 
 void
 View::modelCompletionChanged()
 {

     }
     return true;
 }
 
 View::LayerList
-View::getScrollableBackLayers(bool &changed) const
+View::getScrollableBackLayers(bool testChanged, bool &changed) const
 {
     changed = false;
 
     LayerList scrollables;
     for (LayerList::const_iterator i = m_layers.begin(); i != m_layers.end(); ++i) {
 	if ((*i)->isLayerDormant()) continue;
 	if ((*i)->isLayerScrollable()) scrollables.push_back(*i);
 	else {
-	    if (scrollables != m_lastScrollableBackLayers) {
+	    if (testChanged && scrollables != m_lastScrollableBackLayers) {
 		m_lastScrollableBackLayers = scrollables;
 		changed = true;
 	    }
 	    return scrollables;
 	}

 	// -- it probably redraws as quickly as it refreshes from
 	// cache
 	scrollables.clear();
     }
 
-    if (scrollables != m_lastScrollableBackLayers) {
+    if (testChanged && scrollables != m_lastScrollableBackLayers) {
 	m_lastScrollableBackLayers = scrollables;
 	changed = true;
     }
     return scrollables;
 }
 
 View::LayerList
-View::getNonScrollableFrontLayers(bool &changed) const
+View::getNonScrollableFrontLayers(bool testChanged, bool &changed) const
 {
     changed = false;
-    LayerList scrollables = getScrollableBackLayers(changed);
+    LayerList scrollables = getScrollableBackLayers(testChanged, changed);
     LayerList nonScrollables;
 
     // Everything in front of the first non-scrollable from the back
     // should also be considered non-scrollable
 

 	    continue;
 	}
 	nonScrollables.push_back(*i);
     }
 
-    if (nonScrollables != m_lastNonScrollableBackLayers) {
+    if (testChanged && nonScrollables != m_lastNonScrollableBackLayers) {
 	m_lastNonScrollableBackLayers = nonScrollables;
 	changed = true;
     }
 
     return nonScrollables;

 
     // If not all layers are scrollable, but some of the back layers
     // are, we should store only those in the cache
 
     bool layersChanged = false;
-    LayerList scrollables = getScrollableBackLayers(layersChanged);
-    LayerList nonScrollables = getNonScrollableFrontLayers(layersChanged);
+    LayerList scrollables = getScrollableBackLayers(true, layersChanged);
+    LayerList nonScrollables = getNonScrollableFrontLayers(true, layersChanged);
     bool selectionCacheable = nonScrollables.empty();
     bool haveSelections = m_manager && !m_manager->getSelections().empty();
     bool selectionDrawn = false;
 
     if (!selectionCacheable) {