comparison data/fileio/MIDIFileReader.cpp @ 965:2d5a8219b4b0

Backed out changeset 6b5e1edd95fc. I had misunderstood, the container is a vector, not a map, so the fix doesn't work and the original code (although definitely flawed) actually does

 {
     bool notesOnTrack = false;
     bool noteOffFound;
 
     for (MIDITrack::iterator i = m_midiComposition[track].begin();
-	 i != m_midiComposition[track].end(); ) {
-
-        MIDITrack::iterator nexti = i;
-        ++nexti; 
+	 i != m_midiComposition[track].end(); i++) {
 
         if ((*i)->getMessageType() == MIDI_NOTE_ON && (*i)->getVelocity() > 0) {
 
 	    notesOnTrack = true;
             noteOffFound = false;

                     ((*j)->getMessageType() == MIDI_NOTE_OFF ||
                     ((*j)->getMessageType() == MIDI_NOTE_ON &&
                      (*j)->getVelocity() == 0x00))) {
 
                     (*i)->setDuration((*j)->getTime() - (*i)->getTime());
-
-                    if (nexti == j) {
-                        // we're about to erase j, invalidating nexti
-                        // as well (but as this is a map, that is the
-                        // only iterator to be invalidated)
-                        ++nexti;
-                    }
 
                     delete *j;
                     m_midiComposition[track].erase(j);
 
                     noteOffFound = true;

 		MIDITrack::iterator j = m_midiComposition[track].end();
 		--j;
                 (*i)->setDuration((*j)->getTime() - (*i)->getTime());
 	    }
         }
-
-        i = nexti;
     }
 
     return notesOnTrack;
 }