# HG changeset patch # User Chris Cannam # Date 1394549668 0 # Node ID 3144af512ea3447e6cf1775f02b5b54b5a5ddeb5 # Parent 40bcaf772d7816f5c05f44df69e50e066d4b6488 Sometimes a zero is just a zero diff -r 40bcaf772d78 -r 3144af512ea3 framework/VersionTester.cpp --- a/framework/VersionTester.cpp Thu Mar 06 15:16:43 2014 +0000 +++ b/framework/VersionTester.cpp Tue Mar 11 14:54:28 2014 +0000 @@ -60,17 +60,21 @@ int be = blist.size(); int e = std::max(ae, be); for (int i = 0; i < e; ++i) { - int an = 0, bn = 0; - if (i < ae) { - an = alist[i].toInt(); - if (an == 0) an = -1; // non-numeric field -> "-pre1" etc - } - if (i < be) { - bn = blist[i].toInt(); - if (bn == 0) bn = -1; - } - if (an < bn) return false; - if (an > bn) return true; + int an = 0, bn = 0; + if (i < ae) { + an = alist[i].toInt(); + if (an == 0 && alist[i] != "0") { + an = -1; // non-numeric field -> "-pre1" etc + } + } + if (i < be) { + bn = blist[i].toInt(); + if (bn == 0 && blist[i] != "0") { + bn = -1; + } + } + if (an < bn) return false; + if (an > bn) return true; } return false; } @@ -103,8 +107,9 @@ if (lines.empty()) return; QString latestVersion = lines[0]; - SVDEBUG << "Comparing current version \"" << m_myVersion << "\" with latest version \"" << latestVersion << "\"" << endl; + cerr << "Comparing current version \"" << m_myVersion << "\" with latest version \"" << latestVersion << "\"" << endl; if (isVersionNewerThan(latestVersion, m_myVersion)) { + cerr << "Latest version \"" << latestVersion << "\" is newer than current version \"" << m_myVersion << "\"" << endl; emit newerVersionAvailable(latestVersion); } }