comparison framework/MainWindowBase.cpp @ 390:3e5c8a03bcb7

Associate the mapper with the MainWindowBase object, and recreate it each time we scan all menus -- allowing us to call finaliseMenus more than once if menu actions have changed

     m_abandoning(false),
     m_labeller(0),
     m_lastPlayStatusSec(0),
     m_initialDarkBackground(false),
     m_defaultFfwdRwdStep(2, 0),
-    m_statusLabel(0)
+    m_statusLabel(0),
+    m_menuShortcutMapper(0)
 {
     Profiler profiler("MainWindowBase::MainWindowBase");
 
 #ifdef Q_WS_X11
     XSetErrorHandler(handle_x11_error);

 }
 
 void
 MainWindowBase::finaliseMenus()
 {
+    delete m_menuShortcutMapper;
+    m_menuShortcutMapper = 0;
+
     QMenuBar *mb = menuBar();
     QList<QMenu *> menus = mb->findChildren<QMenu *>();
     foreach (QMenu *menu, menus) {
         if (menu) finaliseMenu(menu);
     }

     // i.e. that will not otherwise work. The downside is that if this
     // bug is fixed in a future Qt release, we will start getting
     // "ambiguous shortcut" errors from the menu entry actions and
     // will need to update the code.)
 
-    QSignalMapper *mapper = new QSignalMapper(this);
-
-    connect(mapper, SIGNAL(mapped(QObject *)),
+    if (!m_menuShortcutMapper) {
+        m_menuShortcutMapper = new QSignalMapper(this);
+    }
+
+    connect(m_menuShortcutMapper, SIGNAL(mapped(QObject *)),
             this, SLOT(menuActionMapperInvoked(QObject *)));
 
     foreach (QAction *a, menu->actions()) {
         QWidgetList ww = a->associatedWidgets();
         bool hasButton = false;

         }
         if (hasButton) continue;
         QKeySequence sc = a->shortcut();
         if (sc.count() == 1 && !(sc[0] & Qt::KeyboardModifierMask)) {
             QShortcut *newSc = new QShortcut(sc, a->parentWidget());
-            QObject::connect(newSc, SIGNAL(activated()), mapper, SLOT(map()));
+            QObject::connect(newSc, SIGNAL(activated()),
+                             m_menuShortcutMapper, SLOT(map()));
             cerr << "setting mapping for action " << a << ", name " << a->text() << endl;
-            mapper->setMapping(newSc, a);
+            m_menuShortcutMapper->setMapping(newSc, a);
         }
     }
 #endif
 }