comparison framework/Document.cpp @ 693:3c5dc95bea91 by-id

Tidy

         SVDEBUG << "AdditionalModelConverter::noMoreModelsAvailable" << endl;
         m_handler->layersCreated(this, m_primary, vector<Layer *>());
         delete this;
     }
 
-    void cancel() {
-/*!!! todo: restore
-        foreach (Layer *layer, m_primary) {
-            ModelId model = layer->getModel();
-            //!!! todo: restore this behaviour
-            if (model) {
-                model->abandon();
-            }
-        }
-*/
-    }
-
 private:
     Document *m_doc;
     vector<Layer *> m_primary;
     Document::LayerCreationHandler *m_handler; //!!! how to handle destruction of this?
 };

         emit modelGenerationWarning(transforms[0].getIdentifier(), message);
         //!!! what to do with amc?
     }
 
     return amc;
-}
-
-void
-Document::cancelAsyncLayerCreation(Document::LayerCreationAsyncHandle h)
-{
-    AdditionalModelConverter *conv = static_cast<AdditionalModelConverter *>(h);
-    conv->cancel();
 }
 
 vector<Layer *>
 Document::createLayersForDerivedModels(vector<ModelId> newModels, 
                                        QStringList names)

     }
 
     return models;
 }
 
-//!!! what is this used for?
 bool
 Document::isKnownModel(const ModelId modelId) const
 {
     if (modelId == m_mainModel) return true;
     for (auto rec: m_models) {

     // as the transform element.  In order that newer code knows it's
     // dealing with a newer format, we will also write an attribute
     // 'type="transform"' in the derivation element.
 
     const Transform &transform = rec.transform;
-
-    //!!! in cases like these, where we think we have the model handle
-    //!!! and nobody else should be releasing it, we probably ought to
-    //!!! throw std::logic_error if !targetModel
     
     auto targetModel = ModelById::get(targetModelId);
     if (!targetModel) return;
     
     // Just for reference, this is what we would write if we didn't