changeset 806:a42dcc01dfee cannam

Move tag list in My Projects up to next to public/private text; move tags column in projects table to left of managed-by column and fix header colour; show My Projects toggle frame only if I have projects
author Chris Cannam <chris.cannam@soundsoftware.ac.uk>
date Wed, 23 Nov 2011 13:18:11 +0000
parents 6fa65a452888
children 42129b521bda
files vendor/plugins/redmine_tags/app/views/projects/_my_projects.rhtml vendor/plugins/redmine_tags/app/views/projects/index.rhtml vendor/plugins/redmine_tags/assets/stylesheets/redmine_tags.css vendor/plugins/redmine_tags/config/locales/en.yml vendor/plugins/redmine_tags/lib/redmine_tags/patches/projects_helper_patch.rb
diffstat 5 files changed, 26 insertions(+), 12 deletions(-) [+]
line wrap: on
line diff
--- a/vendor/plugins/redmine_tags/app/views/projects/_my_projects.rhtml	Tue Nov 22 13:37:50 2011 +0000
+++ b/vendor/plugins/redmine_tags/app/views/projects/_my_projects.rhtml	Wed Nov 23 13:18:11 2011 +0000
@@ -1,3 +1,4 @@
+<% if !@user_projects.empty? %>
 <% if @myproj_status=="true" %>
 <fieldset id="my_projects_fieldset" class="collapsible">
     <legend onclick="toggleFieldsetWithState(this);"><h2><%= l(:label_my_project_plural) %></h2></legend>
@@ -5,10 +6,9 @@
 <fieldset id="my_projects_fieldset" class="collapsible collapsed">
     <legend onclick="toggleFieldsetWithState(this);"><h2><%= l(:label_my_project_plural) %></h2></legend>
     <div style="display: none;">    
-<%  end%>
-    <% if @user_projects %>  
+<% end %>
     <div>
       <%= render_my_project_hierarchy_with_tags(@user_projects)%>
     </div>
-  <% end %>
 </fieldset>
+<% end %>
--- a/vendor/plugins/redmine_tags/app/views/projects/index.rhtml	Tue Nov 22 13:37:50 2011 +0000
+++ b/vendor/plugins/redmine_tags/app/views/projects/index.rhtml	Wed Nov 23 13:18:11 2011 +0000
@@ -1,5 +1,6 @@
 <% content_for :header_tags do %>
     <%= auto_discovery_link_tag(:atom, {:action => 'index', :format => 'atom', :key => User.current.rss_key}) %>
+    <%= stylesheet_link_tag 'redmine_tags', :plugin => 'redmine_tags' %>
 <% end %>
 <%= javascript_include_tag 'projects_index', :plugin => 'redmine_tags' %>
 
--- a/vendor/plugins/redmine_tags/assets/stylesheets/redmine_tags.css	Tue Nov 22 13:37:50 2011 +0000
+++ b/vendor/plugins/redmine_tags/assets/stylesheets/redmine_tags.css	Wed Nov 23 13:18:11 2011 +0000
@@ -33,3 +33,7 @@
 div.tags .tag-nube-8 { font-size: 1.5em; }
 
 .tag-count { font-size: .75em; margin-left: .5em; }
+
+ul.projects .tags, ul.projects .no-tags { padding-left: 0.5em; color: #3e442c; font-size: 0.95em }
+table.projects th.tags { color: #3e442c; }
+
--- a/vendor/plugins/redmine_tags/config/locales/en.yml	Tue Nov 22 13:37:50 2011 +0000
+++ b/vendor/plugins/redmine_tags/config/locales/en.yml	Wed Nov 23 13:18:11 2011 +0000
@@ -23,6 +23,7 @@
   tags: Tags
   field_tags: Tags
   field_tag_list: Tags
+  field_no_tags: "No tags"
   label_tags_search: "Tags: "
   setting_issue_tags: Issues Tags
   issues_sidebar: Display tags on sidebar as
--- a/vendor/plugins/redmine_tags/lib/redmine_tags/patches/projects_helper_patch.rb	Tue Nov 22 13:37:50 2011 +0000
+++ b/vendor/plugins/redmine_tags/lib/redmine_tags/patches/projects_helper_patch.rb	Wed Nov 23 13:18:11 2011 +0000
@@ -29,8 +29,8 @@
             s << "<thead><tr>"
         
             s << sort_header_tag('name', :caption => l("field_name"))
+            s << "<th class='tags'>" << l("tags") << "</th>"
             s << "<th class='managers'>" << l("label_managers") << "</th>"
-            s << "<th class='tags'>" << l("tags") << "</th>"
             s << sort_header_tag('created_on', :default_order => 'desc')
             s << sort_header_tag('updated_on', :default_order => 'desc')
         
@@ -65,6 +65,11 @@
           s << "'>" << link_to( highlight_tokens(project.name, tokens), {:controller => 'projects', :action => 'show', :id => project}, :class => "project #{User.current.member_of?(project) ? 'my-project' : nil}")
           s << "</div>"
           s << highlight_tokens(render_project_short_description(project), tokens)
+          s << "</td>"
+
+          # taglist
+          s << "<td class='tags' align=top>" << project.tag_counts.collect{ |t| render_project_tag_link(t) }.join(', ') << "</td>"
+
           s << "<td class='managers' align=top>"
            
           u = project.users_by_role
@@ -86,8 +91,6 @@
 
           s << "</td>"
           
-          # taglist
-          s << "<td class='tags' align=top>" << project.tag_counts.collect{ |t| render_project_tag_link(t) }.join(', ') << "</td>"
           s << "<td class='created_on' align=top>" << format_date(project.created_on) << "</td>"
           s << "<td class='updated_on' align=top>" << format_date(project.updated_on) << "</td>"
 
@@ -207,20 +210,25 @@
             s << "<li class='#{classes}'><div class='#{classes}'>" +
               link_to_project(project, {}, :class => "project my-project")
             if project.is_public?
-              s << " <span class='public'>" << l("field_is_public") << "</span>"
+              s << " <span class='public'>" << l(:field_is_public) << "</span>"
             else
-              s << " <span class='private'>" << l("field_is_private") << "</span>"
+              s << " <span class='private'>" << l(:field_is_private) << "</span>"
             end
+           
+            tc = project.tag_counts
+            if tc.empty?
+              s << " <span class='no-tags'>" << l(:field_no_tags) << "</span>"
+            else
+              s << " <span class='tags'>" << tc.collect{ |t| render_project_tag_link(t) }.join(', ') << "</span>"
+            end
+
             s << render_project_short_description(project)
 
-            s << l(:tags) << ":&nbsp"
-            s << project.tag_counts.collect{ |t| render_project_tag_link(t) }.join(', ')
-
             s << "</div>\n"
 
             cs = ''
             project.children.each do |child|
-              cs << render_my_project_in_hierarchy(child)
+              cs << render_my_project_in_hierarchy_with_tags(child)
             end
 
             if cs != ''