Chris@1494: # Redmine - project management software
Chris@1494: # Copyright (C) 2006-2014  Jean-Philippe Lang
Chris@1494: #
Chris@1494: # This program is free software; you can redistribute it and/or
Chris@1494: # modify it under the terms of the GNU General Public License
Chris@1494: # as published by the Free Software Foundation; either version 2
Chris@1494: # of the License, or (at your option) any later version.
Chris@1494: #
Chris@1494: # This program is distributed in the hope that it will be useful,
Chris@1494: # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1494: # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
Chris@1494: # GNU General Public License for more details.
Chris@1494: #
Chris@1494: # You should have received a copy of the GNU General Public License
Chris@1494: # along with this program; if not, write to the Free Software
Chris@1494: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
Chris@1494: 
Chris@1494: require File.expand_path('../../test_helper', __FILE__)
Chris@1494: 
Chris@1494: class JournalTest < ActiveSupport::TestCase
Chris@1494:   fixtures :projects, :issues, :issue_statuses, :journals, :journal_details,
Chris@1494:            :users, :members, :member_roles, :roles, :enabled_modules,
Chris@1494:            :projects_trackers, :trackers
Chris@1494: 
Chris@1494:   def setup
Chris@1494:     @journal = Journal.find 1
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_journalized_is_an_issue
Chris@1494:     issue = @journal.issue
Chris@1494:     assert_kind_of Issue, issue
Chris@1494:     assert_equal 1, issue.id
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_new_status
Chris@1494:     status = @journal.new_status
Chris@1494:     assert_not_nil status
Chris@1494:     assert_kind_of IssueStatus, status
Chris@1494:     assert_equal 2, status.id
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_create_should_send_email_notification
Chris@1494:     ActionMailer::Base.deliveries.clear
Chris@1494:     issue = Issue.first
Chris@1494:     user = User.first
Chris@1494:     journal = issue.init_journal(user, issue)
Chris@1494: 
Chris@1494:     assert journal.save
Chris@1494:     assert_equal 1, ActionMailer::Base.deliveries.size
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_should_not_save_journal_with_blank_notes_and_no_details
Chris@1494:     journal = Journal.new(:journalized => Issue.first, :user => User.first)
Chris@1494: 
Chris@1494:     assert_no_difference 'Journal.count' do
Chris@1494:       assert_equal false, journal.save
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_create_should_not_split_non_private_notes
Chris@1494:     assert_difference 'Journal.count' do
Chris@1494:       assert_no_difference 'JournalDetail.count' do
Chris@1494:         journal = Journal.generate!(:notes => 'Notes')
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     assert_difference 'Journal.count' do
Chris@1494:       assert_difference 'JournalDetail.count' do
Chris@1494:         journal = Journal.generate!(:notes => 'Notes', :details => [JournalDetail.new])
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     assert_difference 'Journal.count' do
Chris@1494:       assert_difference 'JournalDetail.count' do
Chris@1494:         journal = Journal.generate!(:notes => '', :details => [JournalDetail.new])
Chris@1494:       end
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_create_should_split_private_notes
Chris@1494:     assert_difference 'Journal.count' do
Chris@1494:       assert_no_difference 'JournalDetail.count' do
Chris@1494:         journal = Journal.generate!(:notes => 'Notes', :private_notes => true)
Chris@1494:         journal.reload
Chris@1494:         assert_equal true, journal.private_notes
Chris@1494:         assert_equal 'Notes', journal.notes
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     assert_difference 'Journal.count', 2 do
Chris@1494:       assert_difference 'JournalDetail.count' do
Chris@1494:         journal = Journal.generate!(:notes => 'Notes', :private_notes => true, :details => [JournalDetail.new])
Chris@1494:         journal.reload
Chris@1494:         assert_equal true, journal.private_notes
Chris@1494:         assert_equal 'Notes', journal.notes
Chris@1494:         assert_equal 0, journal.details.size
Chris@1494: 
Chris@1494:         journal_with_changes = Journal.order('id DESC').offset(1).first
Chris@1494:         assert_equal false, journal_with_changes.private_notes
Chris@1494:         assert_nil journal_with_changes.notes
Chris@1494:         assert_equal 1, journal_with_changes.details.size
Chris@1494:         assert_equal journal.created_on, journal_with_changes.created_on
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     assert_difference 'Journal.count' do
Chris@1494:       assert_difference 'JournalDetail.count' do
Chris@1494:         journal = Journal.generate!(:notes => '', :private_notes => true, :details => [JournalDetail.new])
Chris@1494:         journal.reload
Chris@1494:         assert_equal false, journal.private_notes
Chris@1494:         assert_equal '', journal.notes
Chris@1494:         assert_equal 1, journal.details.size
Chris@1494:       end
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_visible_scope_for_anonymous
Chris@1494:     # Anonymous user should see issues of public projects only
Chris@1494:     journals = Journal.visible(User.anonymous).all
Chris@1494:     assert journals.any?
Chris@1494:     assert_nil journals.detect {|journal| !journal.issue.project.is_public?}
Chris@1494:     # Anonymous user should not see issues without permission
Chris@1494:     Role.anonymous.remove_permission!(:view_issues)
Chris@1494:     journals = Journal.visible(User.anonymous).all
Chris@1494:     assert journals.empty?
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_visible_scope_for_user
Chris@1494:     user = User.find(9)
Chris@1494:     assert user.projects.empty?
Chris@1494:     # Non member user should see issues of public projects only
Chris@1494:     journals = Journal.visible(user).all
Chris@1494:     assert journals.any?
Chris@1494:     assert_nil journals.detect {|journal| !journal.issue.project.is_public?}
Chris@1494:     # Non member user should not see issues without permission
Chris@1494:     Role.non_member.remove_permission!(:view_issues)
Chris@1494:     user.reload
Chris@1494:     journals = Journal.visible(user).all
Chris@1494:     assert journals.empty?
Chris@1494:     # User should see issues of projects for which user has view_issues permissions only
Chris@1494:     Member.create!(:principal => user, :project_id => 1, :role_ids => [1])
Chris@1494:     user.reload
Chris@1494:     journals = Journal.visible(user).all
Chris@1494:     assert journals.any?
Chris@1494:     assert_nil journals.detect {|journal| journal.issue.project_id != 1}
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_visible_scope_for_admin
Chris@1494:     user = User.find(1)
Chris@1494:     user.members.each(&:destroy)
Chris@1494:     assert user.projects.empty?
Chris@1494:     journals = Journal.visible(user).all
Chris@1494:     assert journals.any?
Chris@1494:     # Admin should see issues on private projects that admin does not belong to
Chris@1494:     assert journals.detect {|journal| !journal.issue.project.is_public?}
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_preload_journals_details_custom_fields_should_set_custom_field_instance_variable
Chris@1494:     d = JournalDetail.new(:property => 'cf', :prop_key => '2')
Chris@1494:     journals = [Journal.new(:details => [d])]
Chris@1494: 
Chris@1494:     d.expects(:instance_variable_set).with("@custom_field", CustomField.find(2)).once
Chris@1494:     Journal.preload_journals_details_custom_fields(journals)
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_preload_journals_details_custom_fields_with_empty_set
Chris@1494:     assert_nothing_raised do
Chris@1494:       Journal.preload_journals_details_custom_fields([])
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_details_should_normalize_dates
Chris@1494:     j = JournalDetail.create!(:old_value => Date.parse('2012-11-03'), :value => Date.parse('2013-01-02'))
Chris@1494:     j.reload
Chris@1494:     assert_equal '2012-11-03', j.old_value
Chris@1494:     assert_equal '2013-01-02', j.value
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_details_should_normalize_true_values
Chris@1494:     j = JournalDetail.create!(:old_value => true, :value => true)
Chris@1494:     j.reload
Chris@1494:     assert_equal '1', j.old_value
Chris@1494:     assert_equal '1', j.value
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_details_should_normalize_false_values
Chris@1494:     j = JournalDetail.create!(:old_value => false, :value => false)
Chris@1494:     j.reload
Chris@1494:     assert_equal '0', j.old_value
Chris@1494:     assert_equal '0', j.value
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_custom_field_should_return_custom_field_for_cf_detail
Chris@1494:     d = JournalDetail.new(:property => 'cf', :prop_key => '2')
Chris@1494:     assert_equal CustomField.find(2), d.custom_field
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_custom_field_should_return_nil_for_non_cf_detail
Chris@1494:     d = JournalDetail.new(:property => 'subject')
Chris@1494:     assert_equal nil, d.custom_field
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_visible_details_should_include_relations_to_visible_issues_only
Chris@1494:     issue = Issue.generate!
Chris@1494:     visible_issue = Issue.generate!
Chris@1494:     IssueRelation.create!(:issue_from => issue, :issue_to => visible_issue, :relation_type => 'relates')
Chris@1494:     hidden_issue = Issue.generate!(:is_private => true)
Chris@1494:     IssueRelation.create!(:issue_from => issue, :issue_to => hidden_issue, :relation_type => 'relates')
Chris@1494:     issue.reload
Chris@1494:     assert_equal 1, issue.journals.size
Chris@1494:     journal = issue.journals.first
Chris@1494:     assert_equal 2, journal.details.size
Chris@1494: 
Chris@1494:     visible_details = journal.visible_details(User.anonymous)
Chris@1494:     assert_equal 1, visible_details.size
Chris@1494:     assert_equal visible_issue.id.to_s, visible_details.first.value
Chris@1494: 
Chris@1494:     visible_details = journal.visible_details(User.find(2))
Chris@1494:     assert_equal 2, visible_details.size
Chris@1494:   end
Chris@1494: end