Chris@1295: # Redmine - project management software Chris@1295: # Copyright (C) 2006-2013 Jean-Philippe Lang Chris@1295: # Chris@1295: # This program is free software; you can redistribute it and/or Chris@1295: # modify it under the terms of the GNU General Public License Chris@1295: # as published by the Free Software Foundation; either version 2 Chris@1295: # of the License, or (at your option) any later version. Chris@1295: # Chris@1295: # This program is distributed in the hope that it will be useful, Chris@1295: # but WITHOUT ANY WARRANTY; without even the implied warranty of Chris@1295: # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the Chris@1295: # GNU General Public License for more details. Chris@1295: # Chris@1295: # You should have received a copy of the GNU General Public License Chris@1295: # along with this program; if not, write to the Free Software Chris@1295: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. Chris@1295: Chris@1295: require File.expand_path('../../test_helper', __FILE__) Chris@1295: Chris@1295: class JournalTest < ActiveSupport::TestCase Chris@1295: fixtures :projects, :issues, :issue_statuses, :journals, :journal_details, Chris@1295: :users, :members, :member_roles, :roles, :enabled_modules, Chris@1295: :projects_trackers, :trackers Chris@1295: Chris@1295: def setup Chris@1295: @journal = Journal.find 1 Chris@1295: end Chris@1295: Chris@1295: def test_journalized_is_an_issue Chris@1295: issue = @journal.issue Chris@1295: assert_kind_of Issue, issue Chris@1295: assert_equal 1, issue.id Chris@1295: end Chris@1295: Chris@1295: def test_new_status Chris@1295: status = @journal.new_status Chris@1295: assert_not_nil status Chris@1295: assert_kind_of IssueStatus, status Chris@1295: assert_equal 2, status.id Chris@1295: end Chris@1295: Chris@1295: def test_create_should_send_email_notification Chris@1295: ActionMailer::Base.deliveries.clear Chris@1295: issue = Issue.first Chris@1295: user = User.first Chris@1295: journal = issue.init_journal(user, issue) Chris@1295: Chris@1295: assert journal.save Chris@1295: assert_equal 1, ActionMailer::Base.deliveries.size Chris@1295: end Chris@1295: Chris@1295: def test_should_not_save_journal_with_blank_notes_and_no_details Chris@1295: journal = Journal.new(:journalized => Issue.first, :user => User.first) Chris@1295: Chris@1295: assert_no_difference 'Journal.count' do Chris@1295: assert_equal false, journal.save Chris@1295: end Chris@1295: end Chris@1295: Chris@1295: def test_create_should_not_split_non_private_notes Chris@1295: assert_difference 'Journal.count' do Chris@1295: assert_no_difference 'JournalDetail.count' do Chris@1295: journal = Journal.generate!(:notes => 'Notes') Chris@1295: end Chris@1295: end Chris@1295: Chris@1295: assert_difference 'Journal.count' do Chris@1295: assert_difference 'JournalDetail.count' do Chris@1295: journal = Journal.generate!(:notes => 'Notes', :details => [JournalDetail.new]) Chris@1295: end Chris@1295: end Chris@1295: Chris@1295: assert_difference 'Journal.count' do Chris@1295: assert_difference 'JournalDetail.count' do Chris@1295: journal = Journal.generate!(:notes => '', :details => [JournalDetail.new]) Chris@1295: end Chris@1295: end Chris@1295: end Chris@1295: Chris@1295: def test_create_should_split_private_notes Chris@1295: assert_difference 'Journal.count' do Chris@1295: assert_no_difference 'JournalDetail.count' do Chris@1295: journal = Journal.generate!(:notes => 'Notes', :private_notes => true) Chris@1295: journal.reload Chris@1295: assert_equal true, journal.private_notes Chris@1295: assert_equal 'Notes', journal.notes Chris@1295: end Chris@1295: end Chris@1295: Chris@1295: assert_difference 'Journal.count', 2 do Chris@1295: assert_difference 'JournalDetail.count' do Chris@1295: journal = Journal.generate!(:notes => 'Notes', :private_notes => true, :details => [JournalDetail.new]) Chris@1295: journal.reload Chris@1295: assert_equal true, journal.private_notes Chris@1295: assert_equal 'Notes', journal.notes Chris@1295: assert_equal 0, journal.details.size Chris@1295: Chris@1295: journal_with_changes = Journal.order('id DESC').offset(1).first Chris@1295: assert_equal false, journal_with_changes.private_notes Chris@1295: assert_nil journal_with_changes.notes Chris@1295: assert_equal 1, journal_with_changes.details.size Chris@1295: assert_equal journal.created_on, journal_with_changes.created_on Chris@1295: end Chris@1295: end Chris@1295: Chris@1295: assert_difference 'Journal.count' do Chris@1295: assert_difference 'JournalDetail.count' do Chris@1295: journal = Journal.generate!(:notes => '', :private_notes => true, :details => [JournalDetail.new]) Chris@1295: journal.reload Chris@1295: assert_equal false, journal.private_notes Chris@1295: assert_equal '', journal.notes Chris@1295: assert_equal 1, journal.details.size Chris@1295: end Chris@1295: end Chris@1295: end Chris@1295: Chris@1295: def test_visible_scope_for_anonymous Chris@1295: # Anonymous user should see issues of public projects only Chris@1295: journals = Journal.visible(User.anonymous).all Chris@1295: assert journals.any? Chris@1295: assert_nil journals.detect {|journal| !journal.issue.project.is_public?} Chris@1295: # Anonymous user should not see issues without permission Chris@1295: Role.anonymous.remove_permission!(:view_issues) Chris@1295: journals = Journal.visible(User.anonymous).all Chris@1295: assert journals.empty? Chris@1295: end Chris@1295: Chris@1295: def test_visible_scope_for_user Chris@1295: user = User.find(9) Chris@1295: assert user.projects.empty? Chris@1295: # Non member user should see issues of public projects only Chris@1295: journals = Journal.visible(user).all Chris@1295: assert journals.any? Chris@1295: assert_nil journals.detect {|journal| !journal.issue.project.is_public?} Chris@1295: # Non member user should not see issues without permission Chris@1295: Role.non_member.remove_permission!(:view_issues) Chris@1295: user.reload Chris@1295: journals = Journal.visible(user).all Chris@1295: assert journals.empty? Chris@1295: # User should see issues of projects for which he has view_issues permissions only Chris@1295: Member.create!(:principal => user, :project_id => 1, :role_ids => [1]) Chris@1295: user.reload Chris@1295: journals = Journal.visible(user).all Chris@1295: assert journals.any? Chris@1295: assert_nil journals.detect {|journal| journal.issue.project_id != 1} Chris@1295: end Chris@1295: Chris@1295: def test_visible_scope_for_admin Chris@1295: user = User.find(1) Chris@1295: user.members.each(&:destroy) Chris@1295: assert user.projects.empty? Chris@1295: journals = Journal.visible(user).all Chris@1295: assert journals.any? Chris@1295: # Admin should see issues on private projects that he does not belong to Chris@1295: assert journals.detect {|journal| !journal.issue.project.is_public?} Chris@1295: end Chris@1295: Chris@1295: def test_details_should_normalize_dates Chris@1295: j = JournalDetail.create!(:old_value => Date.parse('2012-11-03'), :value => Date.parse('2013-01-02')) Chris@1295: j.reload Chris@1295: assert_equal '2012-11-03', j.old_value Chris@1295: assert_equal '2013-01-02', j.value Chris@1295: end Chris@1295: Chris@1295: def test_details_should_normalize_true_values Chris@1295: j = JournalDetail.create!(:old_value => true, :value => true) Chris@1295: j.reload Chris@1295: assert_equal '1', j.old_value Chris@1295: assert_equal '1', j.value Chris@1295: end Chris@1295: Chris@1295: def test_details_should_normalize_false_values Chris@1295: j = JournalDetail.create!(:old_value => false, :value => false) Chris@1295: j.reload Chris@1295: assert_equal '0', j.old_value Chris@1295: assert_equal '0', j.value Chris@1295: end Chris@1295: end