Chris@441: # Redmine - project management software Chris@1494: # Copyright (C) 2006-2014 Jean-Philippe Lang Chris@0: # Chris@0: # This program is free software; you can redistribute it and/or Chris@0: # modify it under the terms of the GNU General Public License Chris@0: # as published by the Free Software Foundation; either version 2 Chris@0: # of the License, or (at your option) any later version. Chris@441: # Chris@0: # This program is distributed in the hope that it will be useful, Chris@0: # but WITHOUT ANY WARRANTY; without even the implied warranty of Chris@0: # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the Chris@0: # GNU General Public License for more details. Chris@441: # Chris@0: # You should have received a copy of the GNU General Public License Chris@0: # along with this program; if not, write to the Free Software Chris@0: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. Chris@0: Chris@119: require File.expand_path('../../test_helper', __FILE__) Chris@0: Chris@0: class IssueNestedSetTest < ActiveSupport::TestCase Chris@1464: fixtures :projects, :users, :roles, Chris@0: :trackers, :projects_trackers, Chris@1464: :issue_statuses, :issue_categories, :issue_relations, Chris@0: :enumerations, Chris@1464: :issues Chris@0: Chris@1517: def test_new_record_is_leaf Chris@1517: i = Issue.new Chris@1517: assert i.leaf? Chris@1517: end Chris@1517: Chris@0: def test_create_root_issue Chris@1517: lft1 = new_issue_lft Chris@1115: issue1 = Issue.generate! Chris@1517: lft2 = new_issue_lft Chris@1115: issue2 = Issue.generate! Chris@0: issue1.reload Chris@0: issue2.reload Chris@1517: assert_equal [issue1.id, nil, lft1, lft1 + 1], [issue1.root_id, issue1.parent_id, issue1.lft, issue1.rgt] Chris@1517: assert_equal [issue2.id, nil, lft2, lft2 + 1], [issue2.root_id, issue2.parent_id, issue2.lft, issue2.rgt] Chris@0: end Chris@441: Chris@0: def test_create_child_issue Chris@1517: lft = new_issue_lft Chris@1115: parent = Issue.generate! Chris@1517: child = parent.generate_child! Chris@0: parent.reload Chris@0: child.reload Chris@1517: assert_equal [parent.id, nil, lft, lft + 3], [parent.root_id, parent.parent_id, parent.lft, parent.rgt] Chris@1517: assert_equal [parent.id, parent.id, lft + 1, lft + 2], [child.root_id, child.parent_id, child.lft, child.rgt] Chris@0: end Chris@441: Chris@1115: def test_creating_a_child_in_a_subproject_should_validate Chris@1115: issue = Issue.generate! Chris@1115: child = Issue.new(:project_id => 3, :tracker_id => 2, :author_id => 1, Chris@1115: :subject => 'child', :parent_issue_id => issue.id) Chris@1115: assert_save child Chris@1115: assert_equal issue, child.reload.parent Chris@1115: end Chris@1115: Chris@1115: def test_creating_a_child_in_an_invalid_project_should_not_validate Chris@1115: issue = Issue.generate! Chris@909: child = Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1, Chris@909: :subject => 'child', :parent_issue_id => issue.id) Chris@0: assert !child.save Chris@1464: assert_not_equal [], child.errors[:parent_issue_id] Chris@0: end Chris@441: Chris@0: def test_move_a_root_to_child Chris@1517: lft = new_issue_lft Chris@1115: parent1 = Issue.generate! Chris@1115: parent2 = Issue.generate! Chris@1517: child = parent1.generate_child! Chris@0: parent2.parent_issue_id = parent1.id Chris@0: parent2.save! Chris@0: child.reload Chris@0: parent1.reload Chris@0: parent2.reload Chris@1517: assert_equal [parent1.id, lft, lft + 5], [parent1.root_id, parent1.lft, parent1.rgt] Chris@1517: assert_equal [parent1.id, lft + 3, lft + 4], [parent2.root_id, parent2.lft, parent2.rgt] Chris@1517: assert_equal [parent1.id, lft + 1, lft + 2], [child.root_id, child.lft, child.rgt] Chris@0: end Chris@441: Chris@0: def test_move_a_child_to_root Chris@1517: lft1 = new_issue_lft Chris@1115: parent1 = Issue.generate! Chris@1517: lft2 = new_issue_lft Chris@1115: parent2 = Issue.generate! Chris@1517: child = parent1.generate_child! Chris@0: child.parent_issue_id = nil Chris@0: child.save! Chris@0: child.reload Chris@0: parent1.reload Chris@0: parent2.reload Chris@1517: assert_equal [parent1.id, lft1, lft1 + 1], [parent1.root_id, parent1.lft, parent1.rgt] Chris@1517: assert_equal [parent2.id, lft2, lft2 + 1], [parent2.root_id, parent2.lft, parent2.rgt] Chris@0: assert_equal [child.id, 1, 2], [child.root_id, child.lft, child.rgt] Chris@0: end Chris@441: Chris@0: def test_move_a_child_to_another_issue Chris@1517: lft1 = new_issue_lft Chris@1115: parent1 = Issue.generate! Chris@1517: lft2 = new_issue_lft Chris@1115: parent2 = Issue.generate! Chris@1517: child = parent1.generate_child! Chris@0: child.parent_issue_id = parent2.id Chris@0: child.save! Chris@0: child.reload Chris@0: parent1.reload Chris@0: parent2.reload Chris@1517: assert_equal [parent1.id, lft1, lft1 + 1], [parent1.root_id, parent1.lft, parent1.rgt] Chris@1517: assert_equal [parent2.id, lft2, lft2 + 3], [parent2.root_id, parent2.lft, parent2.rgt] Chris@1517: assert_equal [parent2.id, lft2 + 1, lft2 + 2], [child.root_id, child.lft, child.rgt] Chris@0: end Chris@441: Chris@0: def test_move_a_child_with_descendants_to_another_issue Chris@1517: lft1 = new_issue_lft Chris@1115: parent1 = Issue.generate! Chris@1517: lft2 = new_issue_lft Chris@1115: parent2 = Issue.generate! Chris@1517: child = parent1.generate_child! Chris@1517: grandchild = child.generate_child! Chris@0: parent1.reload Chris@0: parent2.reload Chris@0: child.reload Chris@0: grandchild.reload Chris@1517: assert_equal [parent1.id, lft1, lft1 + 5], [parent1.root_id, parent1.lft, parent1.rgt] Chris@1517: assert_equal [parent2.id, lft2, lft2 + 1], [parent2.root_id, parent2.lft, parent2.rgt] Chris@1517: assert_equal [parent1.id, lft1 + 1, lft1 + 4], [child.root_id, child.lft, child.rgt] Chris@1517: assert_equal [parent1.id, lft1 + 2, lft1 + 3], [grandchild.root_id, grandchild.lft, grandchild.rgt] Chris@0: child.reload.parent_issue_id = parent2.id Chris@0: child.save! Chris@0: child.reload Chris@0: grandchild.reload Chris@0: parent1.reload Chris@0: parent2.reload Chris@1517: assert_equal [parent1.id, lft1, lft1 + 1], [parent1.root_id, parent1.lft, parent1.rgt] Chris@1517: assert_equal [parent2.id, lft2, lft2 + 5], [parent2.root_id, parent2.lft, parent2.rgt] Chris@1517: assert_equal [parent2.id, lft2 + 1, lft2 + 4], [child.root_id, child.lft, child.rgt] Chris@1517: assert_equal [parent2.id, lft2 + 2, lft2 + 3], [grandchild.root_id, grandchild.lft, grandchild.rgt] Chris@0: end Chris@441: Chris@0: def test_move_a_child_with_descendants_to_another_project Chris@1517: lft1 = new_issue_lft Chris@1115: parent1 = Issue.generate! Chris@1517: child = parent1.generate_child! Chris@1517: grandchild = child.generate_child! Chris@1115: child.reload Chris@1115: child.project = Project.find(2) Chris@1115: assert child.save Chris@0: child.reload Chris@0: grandchild.reload Chris@0: parent1.reload Chris@1517: assert_equal [1, parent1.id, lft1, lft1 + 1], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt] Chris@0: assert_equal [2, child.id, 1, 4], [child.project_id, child.root_id, child.lft, child.rgt] Chris@0: assert_equal [2, child.id, 2, 3], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt] Chris@0: end Chris@441: Chris@0: def test_moving_an_issue_to_a_descendant_should_not_validate Chris@1115: parent1 = Issue.generate! Chris@1115: parent2 = Issue.generate! Chris@1517: child = parent1.generate_child! Chris@1517: grandchild = child.generate_child! Chris@441: Chris@0: child.reload Chris@0: child.parent_issue_id = grandchild.id Chris@0: assert !child.save Chris@1464: assert_not_equal [], child.errors[:parent_issue_id] Chris@0: end Chris@441: Chris@1464: def test_updating_a_root_issue_should_not_trigger_update_nested_set_attributes_on_parent_change Chris@1464: issue = Issue.find(Issue.generate!.id) Chris@1464: issue.parent_issue_id = "" Chris@1464: issue.expects(:update_nested_set_attributes_on_parent_change).never Chris@1464: issue.save! Chris@1464: end Chris@1464: Chris@1464: def test_updating_a_child_issue_should_not_trigger_update_nested_set_attributes_on_parent_change Chris@1464: issue = Issue.find(Issue.generate!(:parent_issue_id => 1).id) Chris@1464: issue.parent_issue_id = "1" Chris@1464: issue.expects(:update_nested_set_attributes_on_parent_change).never Chris@1464: issue.save! Chris@1464: end Chris@1464: Chris@1464: def test_moving_a_root_issue_should_trigger_update_nested_set_attributes_on_parent_change Chris@1464: issue = Issue.find(Issue.generate!.id) Chris@1464: issue.parent_issue_id = "1" Chris@1464: issue.expects(:update_nested_set_attributes_on_parent_change).once Chris@1464: issue.save! Chris@1464: end Chris@1464: Chris@1464: def test_moving_a_child_issue_to_another_parent_should_trigger_update_nested_set_attributes_on_parent_change Chris@1464: issue = Issue.find(Issue.generate!(:parent_issue_id => 1).id) Chris@1464: issue.parent_issue_id = "2" Chris@1464: issue.expects(:update_nested_set_attributes_on_parent_change).once Chris@1464: issue.save! Chris@1464: end Chris@1464: Chris@1464: def test_moving_a_child_issue_to_root_should_trigger_update_nested_set_attributes_on_parent_change Chris@1464: issue = Issue.find(Issue.generate!(:parent_issue_id => 1).id) Chris@1464: issue.parent_issue_id = "" Chris@1464: issue.expects(:update_nested_set_attributes_on_parent_change).once Chris@1464: issue.save! Chris@0: end Chris@441: Chris@0: def test_destroy_should_destroy_children Chris@1517: lft1 = new_issue_lft Chris@1115: issue1 = Issue.generate! Chris@1115: issue2 = Issue.generate! Chris@1517: issue3 = issue2.generate_child! Chris@1517: issue4 = issue1.generate_child! Chris@210: issue3.init_journal(User.find(2)) Chris@210: issue3.subject = 'child with journal' Chris@210: issue3.save! Chris@210: assert_difference 'Issue.count', -2 do Chris@210: assert_difference 'Journal.count', -1 do Chris@210: assert_difference 'JournalDetail.count', -1 do Chris@210: Issue.find(issue2.id).destroy Chris@210: end Chris@210: end Chris@210: end Chris@0: issue1.reload Chris@0: issue4.reload Chris@0: assert !Issue.exists?(issue2.id) Chris@0: assert !Issue.exists?(issue3.id) Chris@1517: assert_equal [issue1.id, lft1, lft1 + 3], [issue1.root_id, issue1.lft, issue1.rgt] Chris@1517: assert_equal [issue1.id, lft1 + 1, lft1 + 2], [issue4.root_id, issue4.lft, issue4.rgt] Chris@0: end Chris@1517: Chris@909: def test_destroy_child_should_update_parent Chris@1517: lft1 = new_issue_lft Chris@1115: issue = Issue.generate! Chris@1517: child1 = issue.generate_child! Chris@1517: child2 = issue.generate_child! Chris@909: issue.reload Chris@1517: assert_equal [issue.id, lft1, lft1 + 5], [issue.root_id, issue.lft, issue.rgt] Chris@909: child2.reload.destroy Chris@909: issue.reload Chris@1517: assert_equal [issue.id, lft1, lft1 + 3], [issue.root_id, issue.lft, issue.rgt] Chris@909: end Chris@441: Chris@441: def test_destroy_parent_issue_updated_during_children_destroy Chris@1115: parent = Issue.generate! Chris@1517: parent.generate_child!(:start_date => Date.today) Chris@1517: parent.generate_child!(:start_date => 2.days.from_now) Chris@441: Chris@441: assert_difference 'Issue.count', -3 do Chris@441: Issue.find(parent.id).destroy Chris@441: end Chris@441: end Chris@441: Chris@210: def test_destroy_child_issue_with_children Chris@1517: root = Issue.generate! Chris@1517: child = root.generate_child! Chris@1517: leaf = child.generate_child! Chris@210: leaf.init_journal(User.find(2)) Chris@210: leaf.subject = 'leaf with journal' Chris@210: leaf.save! Chris@441: Chris@210: assert_difference 'Issue.count', -2 do Chris@210: assert_difference 'Journal.count', -1 do Chris@210: assert_difference 'JournalDetail.count', -1 do Chris@210: Issue.find(child.id).destroy Chris@210: end Chris@210: end Chris@210: end Chris@441: Chris@210: root = Issue.find(root.id) Chris@210: assert root.leaf?, "Root issue is not a leaf (lft: #{root.lft}, rgt: #{root.rgt})" Chris@210: end Chris@441: Chris@909: def test_destroy_issue_with_grand_child Chris@1517: lft1 = new_issue_lft Chris@1115: parent = Issue.generate! Chris@1517: issue = parent.generate_child! Chris@1517: child = issue.generate_child! Chris@1517: grandchild1 = child.generate_child! Chris@1517: grandchild2 = child.generate_child! Chris@909: assert_difference 'Issue.count', -4 do Chris@909: Issue.find(issue.id).destroy Chris@909: parent.reload Chris@1517: assert_equal [lft1, lft1 + 1], [parent.lft, parent.rgt] Chris@909: end Chris@909: end Chris@909: Chris@0: def test_parent_priority_should_be_the_highest_child_priority Chris@1115: parent = Issue.generate!(:priority => IssuePriority.find_by_name('Normal')) Chris@0: # Create children Chris@1517: child1 = parent.generate_child!(:priority => IssuePriority.find_by_name('High')) Chris@0: assert_equal 'High', parent.reload.priority.name Chris@1517: child2 = child1.generate_child!(:priority => IssuePriority.find_by_name('Immediate')) Chris@0: assert_equal 'Immediate', child1.reload.priority.name Chris@0: assert_equal 'Immediate', parent.reload.priority.name Chris@1517: child3 = parent.generate_child!(:priority => IssuePriority.find_by_name('Low')) Chris@0: assert_equal 'Immediate', parent.reload.priority.name Chris@0: # Destroy a child Chris@0: child1.destroy Chris@0: assert_equal 'Low', parent.reload.priority.name Chris@0: # Update a child Chris@0: child3.reload.priority = IssuePriority.find_by_name('Normal') Chris@0: child3.save! Chris@0: assert_equal 'Normal', parent.reload.priority.name Chris@0: end Chris@441: Chris@0: def test_parent_dates_should_be_lowest_start_and_highest_due_dates Chris@1115: parent = Issue.generate! Chris@1517: parent.generate_child!(:start_date => '2010-01-25', :due_date => '2010-02-15') Chris@1517: parent.generate_child!( :due_date => '2010-02-13') Chris@1517: parent.generate_child!(:start_date => '2010-02-01', :due_date => '2010-02-22') Chris@0: parent.reload Chris@0: assert_equal Date.parse('2010-01-25'), parent.start_date Chris@0: assert_equal Date.parse('2010-02-22'), parent.due_date Chris@0: end Chris@441: Chris@0: def test_parent_done_ratio_should_be_average_done_ratio_of_leaves Chris@1115: parent = Issue.generate! Chris@1517: parent.generate_child!(:done_ratio => 20) Chris@0: assert_equal 20, parent.reload.done_ratio Chris@1517: parent.generate_child!(:done_ratio => 70) Chris@0: assert_equal 45, parent.reload.done_ratio Chris@441: Chris@1517: child = parent.generate_child!(:done_ratio => 0) Chris@0: assert_equal 30, parent.reload.done_ratio Chris@441: Chris@1517: child.generate_child!(:done_ratio => 30) Chris@0: assert_equal 30, child.reload.done_ratio Chris@0: assert_equal 40, parent.reload.done_ratio Chris@0: end Chris@441: Chris@0: def test_parent_done_ratio_should_be_weighted_by_estimated_times_if_any Chris@1115: parent = Issue.generate! Chris@1517: parent.generate_child!(:estimated_hours => 10, :done_ratio => 20) Chris@0: assert_equal 20, parent.reload.done_ratio Chris@1517: parent.generate_child!(:estimated_hours => 20, :done_ratio => 50) Chris@0: assert_equal (50 * 20 + 20 * 10) / 30, parent.reload.done_ratio Chris@0: end Chris@441: Chris@1464: def test_parent_done_ratio_with_child_estimate_to_0_should_reach_100 Chris@1464: parent = Issue.generate! Chris@1517: issue1 = parent.generate_child! Chris@1517: issue2 = parent.generate_child!(:estimated_hours => 0) Chris@1464: assert_equal 0, parent.reload.done_ratio Chris@1517: issue1.reload.close! Chris@1464: assert_equal 50, parent.reload.done_ratio Chris@1517: issue2.reload.close! Chris@1464: assert_equal 100, parent.reload.done_ratio Chris@1464: end Chris@1464: Chris@0: def test_parent_estimate_should_be_sum_of_leaves Chris@1115: parent = Issue.generate! Chris@1517: parent.generate_child!(:estimated_hours => nil) Chris@0: assert_equal nil, parent.reload.estimated_hours Chris@1517: parent.generate_child!(:estimated_hours => 5) Chris@0: assert_equal 5, parent.reload.estimated_hours Chris@1517: parent.generate_child!(:estimated_hours => 7) Chris@0: assert_equal 12, parent.reload.estimated_hours Chris@0: end Chris@0: Chris@1517: def test_done_ratio_of_parent_with_a_child_without_estimated_time_should_not_exceed_100 Chris@1517: parent = Issue.generate! Chris@1517: parent.generate_child!(:estimated_hours => 40) Chris@1517: parent.generate_child!(:estimated_hours => 40) Chris@1517: parent.generate_child!(:estimated_hours => 20) Chris@1517: parent.generate_child! Chris@1517: parent.reload.children.each(&:close!) Chris@1517: assert_equal 100, parent.reload.done_ratio Chris@1517: end Chris@1517: Chris@1494: def test_done_ratio_of_parent_with_a_child_with_estimated_time_at_0_should_not_exceed_100 Chris@1494: parent = Issue.generate! Chris@1517: parent.generate_child!(:estimated_hours => 40) Chris@1517: parent.generate_child!(:estimated_hours => 40) Chris@1517: parent.generate_child!(:estimated_hours => 20) Chris@1517: parent.generate_child!(:estimated_hours => 0) Chris@1517: parent.reload.children.each(&:close!) Chris@1494: assert_equal 100, parent.reload.done_ratio Chris@1494: end Chris@1494: Chris@0: def test_move_parent_updates_old_parent_attributes Chris@1115: first_parent = Issue.generate! Chris@1115: second_parent = Issue.generate! Chris@1517: child = first_parent.generate_child!(:estimated_hours => 5) Chris@0: assert_equal 5, first_parent.reload.estimated_hours Chris@0: child.update_attributes(:estimated_hours => 7, :parent_issue_id => second_parent.id) Chris@0: assert_equal 7, second_parent.reload.estimated_hours Chris@0: assert_nil first_parent.reload.estimated_hours Chris@0: end Chris@0: Chris@0: def test_reschuling_a_parent_should_reschedule_subtasks Chris@1115: parent = Issue.generate! Chris@1517: c1 = parent.generate_child!(:start_date => '2010-05-12', :due_date => '2010-05-18') Chris@1517: c2 = parent.generate_child!(:start_date => '2010-06-03', :due_date => '2010-06-10') Chris@0: parent.reload Chris@1115: parent.reschedule_on!(Date.parse('2010-06-02')) Chris@0: c1.reload Chris@0: assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-08')], [c1.start_date, c1.due_date] Chris@0: c2.reload Chris@0: assert_equal [Date.parse('2010-06-03'), Date.parse('2010-06-10')], [c2.start_date, c2.due_date] # no change Chris@0: parent.reload Chris@0: assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-10')], [parent.start_date, parent.due_date] Chris@0: end Chris@441: Chris@0: def test_project_copy_should_copy_issue_tree Chris@0: p = Project.create!(:name => 'Tree copy', :identifier => 'tree-copy', :tracker_ids => [1, 2]) Chris@1115: i1 = Issue.generate!(:project => p, :subject => 'i1') Chris@1517: i2 = i1.generate_child!(:project => p, :subject => 'i2') Chris@1517: i3 = i1.generate_child!(:project => p, :subject => 'i3') Chris@1517: i4 = i2.generate_child!(:project => p, :subject => 'i4') Chris@1115: i5 = Issue.generate!(:project => p, :subject => 'i5') Chris@0: c = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1, 2]) Chris@0: c.copy(p, :only => 'issues') Chris@0: c.reload Chris@441: Chris@0: assert_equal 5, c.issues.count Chris@1464: ic1, ic2, ic3, ic4, ic5 = c.issues.order('subject').all Chris@0: assert ic1.root? Chris@0: assert_equal ic1, ic2.parent Chris@0: assert_equal ic1, ic3.parent Chris@0: assert_equal ic2, ic4.parent Chris@0: assert ic5.root? Chris@0: end Chris@0: end