Chris@0: # Redmine - project management software
Chris@1494: # Copyright (C) 2006-2014  Jean-Philippe Lang
Chris@0: #
Chris@0: # This program is free software; you can redistribute it and/or
Chris@0: # modify it under the terms of the GNU General Public License
Chris@0: # as published by the Free Software Foundation; either version 2
Chris@0: # of the License, or (at your option) any later version.
Chris@441: #
Chris@0: # This program is distributed in the hope that it will be useful,
Chris@0: # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@0: # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
Chris@0: # GNU General Public License for more details.
Chris@441: #
Chris@0: # You should have received a copy of the GNU General Public License
Chris@0: # along with this program; if not, write to the Free Software
Chris@0: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
Chris@0: 
Chris@0: class IssuesController < ApplicationController
Chris@0:   menu_item :new_issue, :only => [:new, :create]
Chris@0:   default_search_scope :issues
Chris@441: 
Chris@14:   before_filter :find_issue, :only => [:show, :edit, :update]
Chris@1115:   before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :destroy]
Chris@1464:   before_filter :find_project, :only => [:new, :create, :update_form]
Chris@14:   before_filter :authorize, :except => [:index]
Chris@14:   before_filter :find_optional_project, :only => [:index]
Chris@0:   before_filter :check_for_default_issue_status, :only => [:new, :create]
Chris@1464:   before_filter :build_new_issue_from_params, :only => [:new, :create, :update_form]
Chris@507:   accept_rss_auth :index, :show
Chris@507:   accept_api_auth :index, :show, :create, :update, :destroy
Chris@0: 
Chris@0:   rescue_from Query::StatementInvalid, :with => :query_statement_invalid
Chris@441: 
Chris@0:   helper :journals
Chris@0:   helper :projects
Chris@441:   include ProjectsHelper
Chris@0:   helper :custom_fields
Chris@0:   include CustomFieldsHelper
Chris@0:   helper :issue_relations
Chris@0:   include IssueRelationsHelper
Chris@0:   helper :watchers
Chris@0:   include WatchersHelper
Chris@0:   helper :attachments
Chris@0:   include AttachmentsHelper
Chris@0:   helper :queries
Chris@0:   include QueriesHelper
Chris@119:   helper :repositories
Chris@119:   include RepositoriesHelper
Chris@0:   helper :sort
Chris@0:   include SortHelper
Chris@0:   include IssuesHelper
Chris@0:   helper :timelog
Chris@0:   include Redmine::Export::PDF
Chris@0: 
Chris@0:   def index
Chris@0:     retrieve_query
Chris@0:     sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
Chris@0:     sort_update(@query.sortable_columns)
Chris@1115:     @query.sort_criteria = sort_criteria.to_a
Chris@441: 
Chris@0:     if @query.valid?
Chris@119:       case params[:format]
Chris@0:       when 'csv', 'pdf'
Chris@119:         @limit = Setting.issues_export_limit.to_i
Chris@1517:         if params[:columns] == 'all'
Chris@1517:           @query.column_names = @query.available_inline_columns.map(&:name)
Chris@1517:         end
Chris@0:       when 'atom'
Chris@119:         @limit = Setting.feeds_limit.to_i
Chris@119:       when 'xml', 'json'
Chris@119:         @offset, @limit = api_offset_and_limit
Chris@1517:         @query.column_names = %w(author)
Chris@0:       else
Chris@119:         @limit = per_page_option
Chris@0:       end
Chris@441: 
Chris@0:       @issue_count = @query.issue_count
Chris@1464:       @issue_pages = Paginator.new @issue_count, @limit, params['page']
Chris@1464:       @offset ||= @issue_pages.offset
Chris@0:       @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
Chris@441:                               :order => sort_clause,
Chris@441:                               :offset => @offset,
Chris@119:                               :limit => @limit)
Chris@0:       @issue_count_by_group = @query.issue_count_by_group
Chris@441: 
Chris@0:       respond_to do |format|
Chris@909:         format.html { render :template => 'issues/index', :layout => !request.xhr? }
Chris@909:         format.api  {
Chris@1115:           Issue.load_visible_relations(@issues) if include_in_api_response?('relations')
Chris@909:         }
Chris@0:         format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
Chris@1464:         format.csv  { send_data(query_to_csv(@issues, @query, params), :type => 'text/csv; header=present', :filename => 'issues.csv') }
Chris@1464:         format.pdf  { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'issues.pdf') }
Chris@0:       end
Chris@0:     else
Chris@909:       respond_to do |format|
Chris@909:         format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
Chris@909:         format.any(:atom, :csv, :pdf) { render(:nothing => true) }
Chris@909:         format.api { render_validation_errors(@query) }
Chris@909:       end
Chris@0:     end
Chris@0:   rescue ActiveRecord::RecordNotFound
Chris@0:     render_404
Chris@0:   end
Chris@441: 
Chris@0:   def show
Chris@1115:     @journals = @issue.journals.includes(:user, :details).reorder("#{Journal.table_name}.id ASC").all
Chris@0:     @journals.each_with_index {|j,i| j.indice = i+1}
Chris@1115:     @journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
Chris@1464:     Journal.preload_journals_details_custom_fields(@journals)
Chris@1464:     # TODO: use #select! when ruby1.8 support is dropped
Chris@1464:     @journals.reject! {|journal| !journal.notes? && journal.visible_details.empty?}
Chris@0:     @journals.reverse! if User.current.wants_comments_in_reverse_order?
Chris@441: 
Chris@1115:     @changesets = @issue.changesets.visible.all
Chris@1115:     @changesets.reverse! if User.current.wants_comments_in_reverse_order?
Chris@441: 
Chris@210:     @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
Chris@0:     @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
Chris@0:     @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
Chris@909:     @priorities = IssuePriority.active
Chris@441:     @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
Chris@1464:     @relation = IssueRelation.new
Chris@1464: 
Chris@0:     respond_to do |format|
Chris@1115:       format.html {
Chris@1115:         retrieve_previous_and_next_issue_ids
Chris@1115:         render :template => 'issues/show'
Chris@1115:       }
Chris@119:       format.api
Chris@14:       format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
Chris@1115:       format.pdf  {
Chris@1115:         pdf = issue_to_pdf(@issue, :journals => @journals)
Chris@1115:         send_data(pdf, :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf")
Chris@1115:       }
Chris@0:     end
Chris@0:   end
Chris@0: 
Chris@0:   # Add a new issue
Chris@0:   # The new issue will be created from an existing one if copy_from parameter is given
Chris@0:   def new
Chris@14:     respond_to do |format|
Chris@14:       format.html { render :action => 'new', :layout => !request.xhr? }
Chris@14:     end
Chris@0:   end
Chris@0: 
Chris@0:   def create
Chris@0:     call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
Chris@1115:     @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
Chris@0:     if @issue.save
Chris@0:       call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
Chris@0:       respond_to do |format|
Chris@0:         format.html {
Chris@909:           render_attachment_warning_if_needed(@issue)
Chris@1115:           flash[:notice] = l(:notice_issue_successful_create, :id => view_context.link_to("##{@issue.id}", issue_path(@issue), :title => @issue.subject))
Chris@1464:           if params[:continue]
Chris@1464:             attrs = {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?}
Chris@1464:             redirect_to new_project_issue_path(@issue.project, :issue => attrs)
Chris@1464:           else
Chris@1464:             redirect_to issue_path(@issue)
Chris@1464:           end
Chris@0:         }
Chris@119:         format.api  { render :action => 'show', :status => :created, :location => issue_url(@issue) }
Chris@0:       end
Chris@0:       return
Chris@0:     else
Chris@0:       respond_to do |format|
Chris@0:         format.html { render :action => 'new' }
Chris@119:         format.api  { render_validation_errors(@issue) }
Chris@0:       end
Chris@0:     end
Chris@0:   end
Chris@441: 
Chris@0:   def edit
Chris@1115:     return unless update_issue_from_params
Chris@0: 
Chris@0:     respond_to do |format|
Chris@0:       format.html { }
Chris@0:       format.xml  { }
Chris@0:     end
Chris@0:   end
Chris@0: 
Chris@0:   def update
Chris@1115:     return unless update_issue_from_params
Chris@1115:     @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
Chris@1115:     saved = false
Chris@1115:     begin
Chris@1464:       saved = save_issue_with_child_records
Chris@1115:     rescue ActiveRecord::StaleObjectError
Chris@1115:       @conflict = true
Chris@1115:       if params[:last_journal_id]
Chris@1115:         @conflict_journals = @issue.journals_after(params[:last_journal_id]).all
Chris@1115:         @conflict_journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
Chris@1115:       end
Chris@1115:     end
Chris@0: 
Chris@1115:     if saved
Chris@0:       render_attachment_warning_if_needed(@issue)
Chris@0:       flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
Chris@0: 
Chris@0:       respond_to do |format|
Chris@1464:         format.html { redirect_back_or_default issue_path(@issue) }
Chris@1115:         format.api  { render_api_ok }
Chris@0:       end
Chris@0:     else
Chris@0:       respond_to do |format|
Chris@0:         format.html { render :action => 'edit' }
Chris@119:         format.api  { render_validation_errors(@issue) }
Chris@0:       end
Chris@0:     end
Chris@0:   end
Chris@0: 
Chris@1464:   # Updates the issue form when changing the project, status or tracker
Chris@1464:   # on issue creation/update
Chris@1464:   def update_form
Chris@1464:   end
Chris@1464: 
Chris@1115:   # Bulk edit/copy a set of issues
Chris@0:   def bulk_edit
Chris@0:     @issues.sort!
Chris@1115:     @copy = params[:copy].present?
Chris@1115:     @notes = params[:notes]
Chris@1115: 
Chris@1115:     if User.current.allowed_to?(:move_issues, @projects)
Chris@1115:       @allowed_projects = Issue.allowed_target_projects_on_move
Chris@1115:       if params[:issue]
Chris@1115:         @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id].to_s}
Chris@1115:         if @target_project
Chris@1115:           target_projects = [@target_project]
Chris@1115:         end
Chris@1115:       end
Chris@1115:     end
Chris@1115:     target_projects ||= @projects
Chris@1115: 
Chris@1115:     if @copy
Chris@1115:       @available_statuses = [IssueStatus.default]
Chris@1115:     else
Chris@1115:       @available_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
Chris@1115:     end
Chris@1464:     @custom_fields = target_projects.map{|p|p.all_issue_custom_fields.visible}.reduce(:&)
Chris@1115:     @assignables = target_projects.map(&:assignable_users).reduce(:&)
Chris@1115:     @trackers = target_projects.map(&:trackers).reduce(:&)
Chris@1115:     @versions = target_projects.map {|p| p.shared_versions.open}.reduce(:&)
Chris@1115:     @categories = target_projects.map {|p| p.issue_categories}.reduce(:&)
Chris@1115:     if @copy
Chris@1115:       @attachments_present = @issues.detect {|i| i.attachments.any?}.present?
Chris@1115:       @subtasks_present = @issues.detect {|i| !i.leaf?}.present?
Chris@1115:     end
Chris@1115: 
Chris@1115:     @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
Chris@1464: 
Chris@1464:     @issue_params = params[:issue] || {}
Chris@1464:     @issue_params[:custom_field_values] ||= {}
Chris@0:   end
Chris@0: 
Chris@14:   def bulk_update
Chris@0:     @issues.sort!
Chris@1115:     @copy = params[:copy].present?
Chris@14:     attributes = parse_params_for_bulk_issue_attributes(params)
Chris@14: 
Chris@1464:     unsaved_issues = []
Chris@1464:     saved_issues = []
Chris@1115: 
Chris@1115:     if @copy && params[:copy_subtasks].present?
Chris@1115:       # Descendant issues will be copied with the parent task
Chris@1115:       # Don't copy them twice
Chris@1115:       @issues.reject! {|issue| @issues.detect {|other| issue.is_descendant_of?(other)}}
Chris@1115:     end
Chris@1115: 
Chris@1464:     @issues.each do |orig_issue|
Chris@1464:       orig_issue.reload
Chris@1115:       if @copy
Chris@1464:         issue = orig_issue.copy({},
Chris@1115:           :attachments => params[:copy_attachments].present?,
Chris@1115:           :subtasks => params[:copy_subtasks].present?
Chris@1115:         )
Chris@1464:       else
Chris@1464:         issue = orig_issue
Chris@1115:       end
Chris@14:       journal = issue.init_journal(User.current, params[:notes])
Chris@14:       issue.safe_attributes = attributes
Chris@14:       call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
Chris@1115:       if issue.save
Chris@1464:         saved_issues << issue
Chris@1115:       else
Chris@1464:         unsaved_issues << orig_issue
Chris@0:       end
Chris@0:     end
Chris@1115: 
Chris@1464:     if unsaved_issues.empty?
Chris@1464:       flash[:notice] = l(:notice_successful_update) unless saved_issues.empty?
Chris@1464:       if params[:follow]
Chris@1464:         if @issues.size == 1 && saved_issues.size == 1
Chris@1464:           redirect_to issue_path(saved_issues.first)
Chris@1464:         elsif saved_issues.map(&:project).uniq.size == 1
Chris@1464:           redirect_to project_issues_path(saved_issues.map(&:project).first)
Chris@1464:         end
Chris@1464:       else
Chris@1464:         redirect_back_or_default _project_issues_path(@project)
Chris@1115:       end
Chris@1115:     else
Chris@1464:       @saved_issues = @issues
Chris@1464:       @unsaved_issues = unsaved_issues
Chris@1517:       @issues = Issue.visible.where(:id => @unsaved_issues.map(&:id)).all
Chris@1464:       bulk_edit
Chris@1464:       render :action => 'bulk_edit'
Chris@1115:     end
Chris@0:   end
Chris@441: 
Chris@0:   def destroy
Chris@1464:     @hours = TimeEntry.where(:issue_id => @issues.map(&:id)).sum(:hours).to_f
Chris@0:     if @hours > 0
Chris@0:       case params[:todo]
Chris@0:       when 'destroy'
Chris@0:         # nothing to do
Chris@0:       when 'nullify'
Chris@1517:         TimeEntry.where(['issue_id IN (?)', @issues]).update_all('issue_id = NULL')
Chris@0:       when 'reassign'
Chris@0:         reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
Chris@0:         if reassign_to.nil?
Chris@0:           flash.now[:error] = l(:error_issue_not_found_in_project)
Chris@0:           return
Chris@0:         else
Chris@1517:           TimeEntry.where(['issue_id IN (?)', @issues]).
Chris@1517:             update_all("issue_id = #{reassign_to.id}")
Chris@0:         end
Chris@0:       else
Chris@119:         # display the destroy form if it's a user request
Chris@119:         return unless api_request?
Chris@0:       end
Chris@0:     end
Chris@441:     @issues.each do |issue|
Chris@441:       begin
Chris@441:         issue.reload.destroy
Chris@441:       rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
Chris@441:         # nothing to do, issue was already deleted (eg. by a parent)
Chris@441:       end
Chris@441:     end
Chris@0:     respond_to do |format|
Chris@1464:       format.html { redirect_back_or_default _project_issues_path(@project) }
Chris@1115:       format.api  { render_api_ok }
Chris@0:     end
Chris@0:   end
Chris@0: 
Chris@1115:   private
Chris@1115: 
Chris@1115:   def find_project
Chris@1115:     project_id = params[:project_id] || (params[:issue] && params[:issue][:project_id])
Chris@1115:     @project = Project.find(project_id)
Chris@0:   rescue ActiveRecord::RecordNotFound
Chris@0:     render_404
Chris@0:   end
Chris@441: 
Chris@1115:   def retrieve_previous_and_next_issue_ids
Chris@1115:     retrieve_query_from_session
Chris@1115:     if @query
Chris@1115:       sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
Chris@1115:       sort_update(@query.sortable_columns, 'issues_index_sort')
Chris@1115:       limit = 500
Chris@1115:       issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])
Chris@1115:       if (idx = issue_ids.index(@issue.id)) && idx < limit
Chris@1115:         if issue_ids.size < 500
Chris@1115:           @issue_position = idx + 1
Chris@1115:           @issue_count = issue_ids.size
Chris@1115:         end
Chris@1115:         @prev_issue_id = issue_ids[idx - 1] if idx > 0
Chris@1115:         @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
Chris@1115:       end
Chris@1115:     end
Chris@0:   end
Chris@441: 
Chris@0:   # Used by #edit and #update to set some common instance variables
Chris@0:   # from the params
Chris@0:   # TODO: Refactor, not everything in here is needed by #edit
Chris@0:   def update_issue_from_params
Chris@0:     @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
Chris@441:     @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
chris@37:     @time_entry.attributes = params[:time_entry]
Chris@441: 
Chris@1115:     @issue.init_journal(User.current)
Chris@1115: 
Chris@1115:     issue_attributes = params[:issue]
Chris@1115:     if issue_attributes && params[:conflict_resolution]
Chris@1115:       case params[:conflict_resolution]
Chris@1115:       when 'overwrite'
Chris@1115:         issue_attributes = issue_attributes.dup
Chris@1115:         issue_attributes.delete(:lock_version)
Chris@1115:       when 'add_notes'
Chris@1115:         issue_attributes = issue_attributes.slice(:notes)
Chris@1115:       when 'cancel'
Chris@1115:         redirect_to issue_path(@issue)
Chris@1115:         return false
Chris@1115:       end
Chris@1115:     end
Chris@1115:     @issue.safe_attributes = issue_attributes
Chris@1115:     @priorities = IssuePriority.active
Chris@1115:     @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
Chris@1115:     true
Chris@0:   end
Chris@0: 
Chris@0:   # TODO: Refactor, lots of extra code in here
chris@37:   # TODO: Changing tracker on an existing issue should not trigger this
Chris@0:   def build_new_issue_from_params
Chris@14:     if params[:id].blank?
Chris@14:       @issue = Issue.new
Chris@1115:       if params[:copy_from]
Chris@1115:         begin
Chris@1115:           @copy_from = Issue.visible.find(params[:copy_from])
Chris@1115:           @copy_attachments = params[:copy_attachments].present? || request.get?
Chris@1115:           @copy_subtasks = params[:copy_subtasks].present? || request.get?
Chris@1115:           @issue.copy_from(@copy_from, :attachments => @copy_attachments, :subtasks => @copy_subtasks)
Chris@1115:         rescue ActiveRecord::RecordNotFound
Chris@1115:           render_404
Chris@1115:           return
Chris@1115:         end
Chris@1115:       end
Chris@14:       @issue.project = @project
Chris@14:     else
Chris@14:       @issue = @project.issues.visible.find(params[:id])
Chris@14:     end
Chris@441: 
Chris@0:     @issue.project = @project
Chris@1115:     @issue.author ||= User.current
Chris@0:     # Tracker must be set before custom field values
Chris@0:     @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
Chris@0:     if @issue.tracker.nil?
Chris@0:       render_error l(:error_no_tracker_in_project)
Chris@0:       return false
Chris@0:     end
Chris@909:     @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
Chris@1115:     @issue.safe_attributes = params[:issue]
Chris@1115: 
Chris@909:     @priorities = IssuePriority.active
Chris@1464:     @allowed_statuses = @issue.new_statuses_allowed_to(User.current, @issue.new_record?)
Chris@1517:     @available_watchers = @issue.watcher_users
Chris@1517:     if @issue.project.users.count <= 20
Chris@1517:       @available_watchers = (@available_watchers + @issue.project.users.sort).uniq
Chris@1517:     end
Chris@0:   end
Chris@0: 
Chris@0:   def check_for_default_issue_status
Chris@0:     if IssueStatus.default.nil?
Chris@0:       render_error l(:error_no_default_issue_status)
Chris@0:       return false
Chris@0:     end
Chris@0:   end
Chris@14: 
Chris@14:   def parse_params_for_bulk_issue_attributes(params)
Chris@14:     attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
Chris@14:     attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
Chris@1115:     if custom = attributes[:custom_field_values]
Chris@1115:       custom.reject! {|k,v| v.blank?}
Chris@1115:       custom.keys.each do |k|
Chris@1115:         if custom[k].is_a?(Array)
Chris@1115:           custom[k] << '' if custom[k].delete('__none__')
Chris@1115:         else
Chris@1115:           custom[k] = '' if custom[k] == '__none__'
Chris@1115:         end
Chris@1115:       end
Chris@1115:     end
Chris@14:     attributes
Chris@14:   end
Chris@1464: 
Chris@1464:   # Saves @issue and a time_entry from the parameters
Chris@1464:   def save_issue_with_child_records
Chris@1464:     Issue.transaction do
Chris@1464:       if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, @issue.project)
Chris@1464:         time_entry = @time_entry || TimeEntry.new
Chris@1464:         time_entry.project = @issue.project
Chris@1464:         time_entry.issue = @issue
Chris@1464:         time_entry.user = User.current
Chris@1464:         time_entry.spent_on = User.current.today
Chris@1464:         time_entry.attributes = params[:time_entry]
Chris@1464:         @issue.time_entries << time_entry
Chris@1464:       end
Chris@1464: 
Chris@1464:       call_hook(:controller_issues_edit_before_save, { :params => params, :issue => @issue, :time_entry => time_entry, :journal => @issue.current_journal})
Chris@1464:       if @issue.save
Chris@1464:         call_hook(:controller_issues_edit_after_save, { :params => params, :issue => @issue, :time_entry => time_entry, :journal => @issue.current_journal})
Chris@1464:       else
Chris@1464:         raise ActiveRecord::Rollback
Chris@1464:       end
Chris@1464:     end
Chris@1464:   end
Chris@0: end