Chris@1517: # Redmine - project management software Chris@1517: # Copyright (C) 2006-2014 Jean-Philippe Lang Chris@1517: # Chris@1517: # This program is free software; you can redistribute it and/or Chris@1517: # modify it under the terms of the GNU General Public License Chris@1517: # as published by the Free Software Foundation; either version 2 Chris@1517: # of the License, or (at your option) any later version. Chris@1517: # Chris@1517: # This program is distributed in the hope that it will be useful, Chris@1517: # but WITHOUT ANY WARRANTY; without even the implied warranty of Chris@1517: # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the Chris@1517: # GNU General Public License for more details. Chris@1517: # Chris@1517: # You should have received a copy of the GNU General Public License Chris@1517: # along with this program; if not, write to the Free Software Chris@1517: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. Chris@1517: Chris@1517: require File.expand_path('../../test_helper', __FILE__) Chris@1517: require 'issues_controller' Chris@1517: Chris@1517: class IssuesControllerTransactionTest < ActionController::TestCase Chris@1517: tests IssuesController Chris@1517: fixtures :projects, Chris@1517: :users, Chris@1517: :roles, Chris@1517: :members, Chris@1517: :member_roles, Chris@1517: :issues, Chris@1517: :issue_statuses, Chris@1517: :versions, Chris@1517: :trackers, Chris@1517: :projects_trackers, Chris@1517: :issue_categories, Chris@1517: :enabled_modules, Chris@1517: :enumerations, Chris@1517: :attachments, Chris@1517: :workflows, Chris@1517: :custom_fields, Chris@1517: :custom_values, Chris@1517: :custom_fields_projects, Chris@1517: :custom_fields_trackers, Chris@1517: :time_entries, Chris@1517: :journals, Chris@1517: :journal_details, Chris@1517: :queries Chris@1517: Chris@1517: self.use_transactional_fixtures = false Chris@1517: Chris@1517: def setup Chris@1517: User.current = nil Chris@1517: end Chris@1517: Chris@1517: def test_update_stale_issue_should_not_update_the_issue Chris@1517: issue = Issue.find(2) Chris@1517: @request.session[:user_id] = 2 Chris@1517: Chris@1517: assert_no_difference 'Journal.count' do Chris@1517: assert_no_difference 'TimeEntry.count' do Chris@1517: put :update, Chris@1517: :id => issue.id, Chris@1517: :issue => { Chris@1517: :fixed_version_id => 4, Chris@1517: :notes => 'My notes', Chris@1517: :lock_version => (issue.lock_version - 1) Chris@1517: }, Chris@1517: :time_entry => { :hours => '2.5', :comments => '', :activity_id => TimeEntryActivity.first.id } Chris@1517: end Chris@1517: end Chris@1517: Chris@1517: assert_response :success Chris@1517: assert_template 'edit' Chris@1517: Chris@1517: assert_select 'div.conflict' Chris@1517: assert_select 'input[name=?][value=?]', 'conflict_resolution', 'overwrite' Chris@1517: assert_select 'input[name=?][value=?]', 'conflict_resolution', 'add_notes' Chris@1517: assert_select 'label' do Chris@1517: assert_select 'input[name=?][value=?]', 'conflict_resolution', 'cancel' Chris@1517: assert_select 'a[href=/issues/2]' Chris@1517: end Chris@1517: end Chris@1517: Chris@1517: def test_update_stale_issue_should_save_attachments Chris@1517: set_tmp_attachments_directory Chris@1517: issue = Issue.find(2) Chris@1517: @request.session[:user_id] = 2 Chris@1517: Chris@1517: assert_no_difference 'Journal.count' do Chris@1517: assert_no_difference 'TimeEntry.count' do Chris@1517: assert_difference 'Attachment.count' do Chris@1517: put :update, Chris@1517: :id => issue.id, Chris@1517: :issue => { Chris@1517: :fixed_version_id => 4, Chris@1517: :notes => 'My notes', Chris@1517: :lock_version => (issue.lock_version - 1) Chris@1517: }, Chris@1517: :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}, Chris@1517: :time_entry => { :hours => '2.5', :comments => '', :activity_id => TimeEntryActivity.first.id } Chris@1517: end Chris@1517: end Chris@1517: end Chris@1517: Chris@1517: assert_response :success Chris@1517: assert_template 'edit' Chris@1517: attachment = Attachment.order('id DESC').first Chris@1517: assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token} Chris@1517: assert_tag 'input', :attributes => {:name => 'attachments[p0][filename]', :value => 'testfile.txt'} Chris@1517: end Chris@1517: Chris@1517: def test_update_stale_issue_without_notes_should_not_show_add_notes_option Chris@1517: issue = Issue.find(2) Chris@1517: @request.session[:user_id] = 2 Chris@1517: Chris@1517: put :update, :id => issue.id, Chris@1517: :issue => { Chris@1517: :fixed_version_id => 4, Chris@1517: :notes => '', Chris@1517: :lock_version => (issue.lock_version - 1) Chris@1517: } Chris@1517: Chris@1517: assert_tag 'div', :attributes => {:class => 'conflict'} Chris@1517: assert_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'overwrite'} Chris@1517: assert_no_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'add_notes'} Chris@1517: assert_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'cancel'} Chris@1517: end Chris@1517: Chris@1517: def test_update_stale_issue_should_show_conflicting_journals Chris@1517: @request.session[:user_id] = 2 Chris@1517: Chris@1517: put :update, :id => 1, Chris@1517: :issue => { Chris@1517: :fixed_version_id => 4, Chris@1517: :notes => '', Chris@1517: :lock_version => 2 Chris@1517: }, Chris@1517: :last_journal_id => 1 Chris@1517: Chris@1517: assert_not_nil assigns(:conflict_journals) Chris@1517: assert_equal 1, assigns(:conflict_journals).size Chris@1517: assert_equal 2, assigns(:conflict_journals).first.id Chris@1517: assert_tag 'div', :attributes => {:class => 'conflict'}, Chris@1517: :descendant => {:content => /Some notes with Redmine links/} Chris@1517: end Chris@1517: Chris@1517: def test_update_stale_issue_without_previous_journal_should_show_all_journals Chris@1517: @request.session[:user_id] = 2 Chris@1517: Chris@1517: put :update, :id => 1, Chris@1517: :issue => { Chris@1517: :fixed_version_id => 4, Chris@1517: :notes => '', Chris@1517: :lock_version => 2 Chris@1517: }, Chris@1517: :last_journal_id => '' Chris@1517: Chris@1517: assert_not_nil assigns(:conflict_journals) Chris@1517: assert_equal 2, assigns(:conflict_journals).size Chris@1517: assert_tag 'div', :attributes => {:class => 'conflict'}, Chris@1517: :descendant => {:content => /Some notes with Redmine links/} Chris@1517: assert_tag 'div', :attributes => {:class => 'conflict'}, Chris@1517: :descendant => {:content => /Journal notes/} Chris@1517: end Chris@1517: Chris@1517: def test_update_stale_issue_should_show_private_journals_with_permission_only Chris@1517: journal = Journal.create!(:journalized => Issue.find(1), :notes => 'Privates notes', :private_notes => true, :user_id => 1) Chris@1517: Chris@1517: @request.session[:user_id] = 2 Chris@1517: put :update, :id => 1, :issue => {:fixed_version_id => 4, :lock_version => 2}, :last_journal_id => '' Chris@1517: assert_include journal, assigns(:conflict_journals) Chris@1517: Chris@1517: Role.find(1).remove_permission! :view_private_notes Chris@1517: put :update, :id => 1, :issue => {:fixed_version_id => 4, :lock_version => 2}, :last_journal_id => '' Chris@1517: assert_not_include journal, assigns(:conflict_journals) Chris@1517: end Chris@1517: Chris@1517: def test_update_stale_issue_with_overwrite_conflict_resolution_should_update Chris@1517: @request.session[:user_id] = 2 Chris@1517: Chris@1517: assert_difference 'Journal.count' do Chris@1517: put :update, :id => 1, Chris@1517: :issue => { Chris@1517: :fixed_version_id => 4, Chris@1517: :notes => 'overwrite_conflict_resolution', Chris@1517: :lock_version => 2 Chris@1517: }, Chris@1517: :conflict_resolution => 'overwrite' Chris@1517: end Chris@1517: Chris@1517: assert_response 302 Chris@1517: issue = Issue.find(1) Chris@1517: assert_equal 4, issue.fixed_version_id Chris@1517: journal = Journal.order('id DESC').first Chris@1517: assert_equal 'overwrite_conflict_resolution', journal.notes Chris@1517: assert journal.details.any? Chris@1517: end Chris@1517: Chris@1517: def test_update_stale_issue_with_add_notes_conflict_resolution_should_update Chris@1517: @request.session[:user_id] = 2 Chris@1517: Chris@1517: assert_difference 'Journal.count' do Chris@1517: put :update, :id => 1, Chris@1517: :issue => { Chris@1517: :fixed_version_id => 4, Chris@1517: :notes => 'add_notes_conflict_resolution', Chris@1517: :lock_version => 2 Chris@1517: }, Chris@1517: :conflict_resolution => 'add_notes' Chris@1517: end Chris@1517: Chris@1517: assert_response 302 Chris@1517: issue = Issue.find(1) Chris@1517: assert_nil issue.fixed_version_id Chris@1517: journal = Journal.order('id DESC').first Chris@1517: assert_equal 'add_notes_conflict_resolution', journal.notes Chris@1517: assert journal.details.empty? Chris@1517: end Chris@1517: Chris@1517: def test_update_stale_issue_with_cancel_conflict_resolution_should_redirect_without_updating Chris@1517: @request.session[:user_id] = 2 Chris@1517: Chris@1517: assert_no_difference 'Journal.count' do Chris@1517: put :update, :id => 1, Chris@1517: :issue => { Chris@1517: :fixed_version_id => 4, Chris@1517: :notes => 'add_notes_conflict_resolution', Chris@1517: :lock_version => 2 Chris@1517: }, Chris@1517: :conflict_resolution => 'cancel' Chris@1517: end Chris@1517: Chris@1517: assert_redirected_to '/issues/1' Chris@1517: issue = Issue.find(1) Chris@1517: assert_nil issue.fixed_version_id Chris@1517: end Chris@1517: Chris@1517: def test_put_update_with_spent_time_and_failure_should_not_add_spent_time Chris@1517: @request.session[:user_id] = 2 Chris@1517: Chris@1517: assert_no_difference('TimeEntry.count') do Chris@1517: put :update, Chris@1517: :id => 1, Chris@1517: :issue => { :subject => '' }, Chris@1517: :time_entry => { :hours => '2.5', :comments => 'should not be added', :activity_id => TimeEntryActivity.first.id } Chris@1517: assert_response :success Chris@1517: end Chris@1517: Chris@1517: assert_select 'input[name=?][value=?]', 'time_entry[hours]', '2.5' Chris@1517: assert_select 'input[name=?][value=?]', 'time_entry[comments]', 'should not be added' Chris@1517: assert_select 'select[name=?]', 'time_entry[activity_id]' do Chris@1517: assert_select 'option[value=?][selected=selected]', TimeEntryActivity.first.id Chris@1517: end Chris@1517: end Chris@1517: Chris@1517: def test_index_should_rescue_invalid_sql_query Chris@1517: IssueQuery.any_instance.stubs(:statement).returns("INVALID STATEMENT") Chris@1517: Chris@1517: get :index Chris@1517: assert_response 500 Chris@1517: assert_tag 'p', :content => /An error occurred/ Chris@1517: assert_nil session[:query] Chris@1517: assert_nil session[:issues_index_sort] Chris@1517: end Chris@1517: end