Chris@1517: # Redmine - project management software Chris@1517: # Copyright (C) 2006-2014 Jean-Philippe Lang Chris@1517: # Chris@1517: # This program is free software; you can redistribute it and/or Chris@1517: # modify it under the terms of the GNU General Public License Chris@1517: # as published by the Free Software Foundation; either version 2 Chris@1517: # of the License, or (at your option) any later version. Chris@1517: # Chris@1517: # This program is distributed in the hope that it will be useful, Chris@1517: # but WITHOUT ANY WARRANTY; without even the implied warranty of Chris@1517: # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the Chris@1517: # GNU General Public License for more details. Chris@1517: # Chris@1517: # You should have received a copy of the GNU General Public License Chris@1517: # along with this program; if not, write to the Free Software Chris@1517: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. Chris@1517: Chris@1517: require File.expand_path('../../test_helper', __FILE__) Chris@1517: Chris@1517: class UsersControllerTest < ActionController::TestCase Chris@1517: include Redmine::I18n Chris@1517: Chris@1517: fixtures :users, :projects, :members, :member_roles, :roles, Chris@1517: :custom_fields, :custom_values, :groups_users, Chris@1517: :auth_sources Chris@1517: Chris@1517: def setup Chris@1517: User.current = nil Chris@1517: @request.session[:user_id] = 1 # admin Chris@1517: end Chris@1517: Chris@1517: def test_index Chris@1517: get :index Chris@1517: assert_response :success Chris@1517: assert_template 'index' Chris@1517: assert_not_nil assigns(:users) Chris@1517: # active users only Chris@1517: assert_nil assigns(:users).detect {|u| !u.active?} Chris@1517: end Chris@1517: Chris@1517: def test_index_with_status_filter Chris@1517: get :index, :status => 3 Chris@1517: assert_response :success Chris@1517: assert_template 'index' Chris@1517: assert_not_nil assigns(:users) Chris@1517: assert_equal [3], assigns(:users).map(&:status).uniq Chris@1517: end Chris@1517: Chris@1517: def test_index_with_name_filter Chris@1517: get :index, :name => 'john' Chris@1517: assert_response :success Chris@1517: assert_template 'index' Chris@1517: users = assigns(:users) Chris@1517: assert_not_nil users Chris@1517: assert_equal 1, users.size Chris@1517: assert_equal 'John', users.first.firstname Chris@1517: end Chris@1517: Chris@1517: def test_index_with_group_filter Chris@1517: get :index, :group_id => '10' Chris@1517: assert_response :success Chris@1517: assert_template 'index' Chris@1517: users = assigns(:users) Chris@1517: assert users.any? Chris@1517: assert_equal([], (users - Group.find(10).users)) Chris@1517: assert_select 'select[name=group_id]' do Chris@1517: assert_select 'option[value=10][selected=selected]' Chris@1517: end Chris@1517: end Chris@1517: Chris@1517: def test_show Chris@1517: @request.session[:user_id] = nil Chris@1517: get :show, :id => 2 Chris@1517: assert_response :success Chris@1517: assert_template 'show' Chris@1517: assert_not_nil assigns(:user) Chris@1517: Chris@1517: assert_tag 'li', :content => /Phone number/ Chris@1517: end Chris@1517: Chris@1517: def test_show_should_not_display_hidden_custom_fields Chris@1517: @request.session[:user_id] = nil Chris@1517: UserCustomField.find_by_name('Phone number').update_attribute :visible, false Chris@1517: get :show, :id => 2 Chris@1517: assert_response :success Chris@1517: assert_template 'show' Chris@1517: assert_not_nil assigns(:user) Chris@1517: Chris@1517: assert_no_tag 'li', :content => /Phone number/ Chris@1517: end Chris@1517: Chris@1517: def test_show_should_not_fail_when_custom_values_are_nil Chris@1517: user = User.find(2) Chris@1517: Chris@1517: # Create a custom field to illustrate the issue Chris@1517: custom_field = CustomField.create!(:name => 'Testing', :field_format => 'text') Chris@1517: custom_value = user.custom_values.build(:custom_field => custom_field).save! Chris@1517: Chris@1517: get :show, :id => 2 Chris@1517: assert_response :success Chris@1517: end Chris@1517: Chris@1517: def test_show_inactive Chris@1517: @request.session[:user_id] = nil Chris@1517: get :show, :id => 5 Chris@1517: assert_response 404 Chris@1517: end Chris@1517: Chris@1517: def test_show_should_not_reveal_users_with_no_visible_activity_or_project Chris@1517: @request.session[:user_id] = nil Chris@1517: get :show, :id => 9 Chris@1517: assert_response 404 Chris@1517: end Chris@1517: Chris@1517: def test_show_inactive_by_admin Chris@1517: @request.session[:user_id] = 1 Chris@1517: get :show, :id => 5 Chris@1517: assert_response 200 Chris@1517: assert_not_nil assigns(:user) Chris@1517: end Chris@1517: Chris@1517: def test_show_displays_memberships_based_on_project_visibility Chris@1517: @request.session[:user_id] = 1 Chris@1517: get :show, :id => 2 Chris@1517: assert_response :success Chris@1517: memberships = assigns(:memberships) Chris@1517: assert_not_nil memberships Chris@1517: project_ids = memberships.map(&:project_id) Chris@1517: assert project_ids.include?(2) #private project admin can see Chris@1517: end Chris@1517: Chris@1517: def test_show_current_should_require_authentication Chris@1517: @request.session[:user_id] = nil Chris@1517: get :show, :id => 'current' Chris@1517: assert_response 302 Chris@1517: end Chris@1517: Chris@1517: def test_show_current Chris@1517: @request.session[:user_id] = 2 Chris@1517: get :show, :id => 'current' Chris@1517: assert_response :success Chris@1517: assert_template 'show' Chris@1517: assert_equal User.find(2), assigns(:user) Chris@1517: end Chris@1517: Chris@1517: def test_new Chris@1517: get :new Chris@1517: assert_response :success Chris@1517: assert_template :new Chris@1517: assert assigns(:user) Chris@1517: end Chris@1517: Chris@1517: def test_create Chris@1517: Setting.bcc_recipients = '1' Chris@1517: Chris@1517: assert_difference 'User.count' do Chris@1517: assert_difference 'ActionMailer::Base.deliveries.size' do Chris@1517: post :create, Chris@1517: :user => { Chris@1517: :firstname => 'John', Chris@1517: :lastname => 'Doe', Chris@1517: :login => 'jdoe', Chris@1517: :password => 'secret123', Chris@1517: :password_confirmation => 'secret123', Chris@1517: :mail => 'jdoe@gmail.com', Chris@1517: :mail_notification => 'none' Chris@1517: }, Chris@1517: :send_information => '1' Chris@1517: end Chris@1517: end Chris@1517: Chris@1517: user = User.order('id DESC').first Chris@1517: assert_redirected_to :controller => 'users', :action => 'edit', :id => user.id Chris@1517: Chris@1517: assert_equal 'John', user.firstname Chris@1517: assert_equal 'Doe', user.lastname Chris@1517: assert_equal 'jdoe', user.login Chris@1517: assert_equal 'jdoe@gmail.com', user.mail Chris@1517: assert_equal 'none', user.mail_notification Chris@1517: assert user.check_password?('secret123') Chris@1517: Chris@1517: mail = ActionMailer::Base.deliveries.last Chris@1517: assert_not_nil mail Chris@1517: assert_equal [user.mail], mail.bcc Chris@1517: assert_mail_body_match 'secret', mail Chris@1517: end Chris@1517: Chris@1517: def test_create_with_preferences Chris@1517: assert_difference 'User.count' do Chris@1517: post :create, Chris@1517: :user => { Chris@1517: :firstname => 'John', Chris@1517: :lastname => 'Doe', Chris@1517: :login => 'jdoe', Chris@1517: :password => 'secret123', Chris@1517: :password_confirmation => 'secret123', Chris@1517: :mail => 'jdoe@gmail.com', Chris@1517: :mail_notification => 'none' Chris@1517: }, Chris@1517: :pref => { Chris@1517: 'hide_mail' => '1', Chris@1517: 'time_zone' => 'Paris', Chris@1517: 'comments_sorting' => 'desc', Chris@1517: 'warn_on_leaving_unsaved' => '0' Chris@1517: } Chris@1517: end Chris@1517: user = User.order('id DESC').first Chris@1517: assert_equal 'jdoe', user.login Chris@1517: assert_equal true, user.pref.hide_mail Chris@1517: assert_equal 'Paris', user.pref.time_zone Chris@1517: assert_equal 'desc', user.pref[:comments_sorting] Chris@1517: assert_equal '0', user.pref[:warn_on_leaving_unsaved] Chris@1517: end Chris@1517: Chris@1517: def test_create_with_generate_password_should_email_the_password Chris@1517: assert_difference 'User.count' do Chris@1517: post :create, :user => { Chris@1517: :login => 'randompass', Chris@1517: :firstname => 'Random', Chris@1517: :lastname => 'Pass', Chris@1517: :mail => 'randompass@example.net', Chris@1517: :language => 'en', Chris@1517: :generate_password => '1', Chris@1517: :password => '', Chris@1517: :password_confirmation => '' Chris@1517: }, :send_information => 1 Chris@1517: end Chris@1517: user = User.order('id DESC').first Chris@1517: assert_equal 'randompass', user.login Chris@1517: Chris@1517: mail = ActionMailer::Base.deliveries.last Chris@1517: assert_not_nil mail Chris@1517: m = mail_body(mail).match(/Password: ([a-zA-Z0-9]+)/) Chris@1517: assert m Chris@1517: password = m[1] Chris@1517: assert user.check_password?(password) Chris@1517: end Chris@1517: Chris@1517: def test_create_with_failure Chris@1517: assert_no_difference 'User.count' do Chris@1517: post :create, :user => {} Chris@1517: end Chris@1517: assert_response :success Chris@1517: assert_template 'new' Chris@1517: end Chris@1517: Chris@1517: def test_create_with_failure_sould_preserve_preference Chris@1517: assert_no_difference 'User.count' do Chris@1517: post :create, Chris@1517: :user => {}, Chris@1517: :pref => { Chris@1517: 'no_self_notified' => '1', Chris@1517: 'hide_mail' => '1', Chris@1517: 'time_zone' => 'Paris', Chris@1517: 'comments_sorting' => 'desc', Chris@1517: 'warn_on_leaving_unsaved' => '0' Chris@1517: } Chris@1517: end Chris@1517: assert_response :success Chris@1517: assert_template 'new' Chris@1517: Chris@1517: assert_select 'select#pref_time_zone option[selected=selected]', :text => /Paris/ Chris@1517: assert_select 'input#pref_no_self_notified[value=1][checked=checked]' Chris@1517: end Chris@1517: Chris@1517: def test_edit Chris@1517: get :edit, :id => 2 Chris@1517: assert_response :success Chris@1517: assert_template 'edit' Chris@1517: assert_equal User.find(2), assigns(:user) Chris@1517: end Chris@1517: Chris@1517: def test_update Chris@1517: ActionMailer::Base.deliveries.clear Chris@1517: put :update, :id => 2, Chris@1517: :user => {:firstname => 'Changed', :mail_notification => 'only_assigned'}, Chris@1517: :pref => {:hide_mail => '1', :comments_sorting => 'desc'} Chris@1517: user = User.find(2) Chris@1517: assert_equal 'Changed', user.firstname Chris@1517: assert_equal 'only_assigned', user.mail_notification Chris@1517: assert_equal true, user.pref[:hide_mail] Chris@1517: assert_equal 'desc', user.pref[:comments_sorting] Chris@1517: assert ActionMailer::Base.deliveries.empty? Chris@1517: end Chris@1517: Chris@1517: def test_update_with_failure Chris@1517: assert_no_difference 'User.count' do Chris@1517: put :update, :id => 2, :user => {:firstname => ''} Chris@1517: end Chris@1517: assert_response :success Chris@1517: assert_template 'edit' Chris@1517: end Chris@1517: Chris@1517: def test_update_with_group_ids_should_assign_groups Chris@1517: put :update, :id => 2, :user => {:group_ids => ['10']} Chris@1517: user = User.find(2) Chris@1517: assert_equal [10], user.group_ids Chris@1517: end Chris@1517: Chris@1517: def test_update_with_activation_should_send_a_notification Chris@1517: u = User.new(:firstname => 'Foo', :lastname => 'Bar', :mail => 'foo.bar@somenet.foo', :language => 'fr') Chris@1517: u.login = 'foo' Chris@1517: u.status = User::STATUS_REGISTERED Chris@1517: u.save! Chris@1517: ActionMailer::Base.deliveries.clear Chris@1517: Setting.bcc_recipients = '1' Chris@1517: Chris@1517: put :update, :id => u.id, :user => {:status => User::STATUS_ACTIVE} Chris@1517: assert u.reload.active? Chris@1517: mail = ActionMailer::Base.deliveries.last Chris@1517: assert_not_nil mail Chris@1517: assert_equal ['foo.bar@somenet.foo'], mail.bcc Chris@1517: assert_mail_body_match ll('fr', :notice_account_activated), mail Chris@1517: end Chris@1517: Chris@1517: def test_update_with_password_change_should_send_a_notification Chris@1517: ActionMailer::Base.deliveries.clear Chris@1517: Setting.bcc_recipients = '1' Chris@1517: Chris@1517: put :update, :id => 2, :user => {:password => 'newpass123', :password_confirmation => 'newpass123'}, :send_information => '1' Chris@1517: u = User.find(2) Chris@1517: assert u.check_password?('newpass123') Chris@1517: Chris@1517: mail = ActionMailer::Base.deliveries.last Chris@1517: assert_not_nil mail Chris@1517: assert_equal [u.mail], mail.bcc Chris@1517: assert_mail_body_match 'newpass123', mail Chris@1517: end Chris@1517: Chris@1517: def test_update_with_generate_password_should_email_the_password Chris@1517: ActionMailer::Base.deliveries.clear Chris@1517: Setting.bcc_recipients = '1' Chris@1517: Chris@1517: put :update, :id => 2, :user => { Chris@1517: :generate_password => '1', Chris@1517: :password => '', Chris@1517: :password_confirmation => '' Chris@1517: }, :send_information => '1' Chris@1517: Chris@1517: mail = ActionMailer::Base.deliveries.last Chris@1517: assert_not_nil mail Chris@1517: m = mail_body(mail).match(/Password: ([a-zA-Z0-9]+)/) Chris@1517: assert m Chris@1517: password = m[1] Chris@1517: assert User.find(2).check_password?(password) Chris@1517: end Chris@1517: Chris@1517: def test_update_without_generate_password_should_not_change_password Chris@1517: put :update, :id => 2, :user => { Chris@1517: :firstname => 'changed', Chris@1517: :generate_password => '0', Chris@1517: :password => '', Chris@1517: :password_confirmation => '' Chris@1517: }, :send_information => '1' Chris@1517: Chris@1517: user = User.find(2) Chris@1517: assert_equal 'changed', user.firstname Chris@1517: assert user.check_password?('jsmith') Chris@1517: end Chris@1517: Chris@1517: def test_update_user_switchin_from_auth_source_to_password_authentication Chris@1517: # Configure as auth source Chris@1517: u = User.find(2) Chris@1517: u.auth_source = AuthSource.find(1) Chris@1517: u.save! Chris@1517: Chris@1517: put :update, :id => u.id, :user => {:auth_source_id => '', :password => 'newpass123', :password_confirmation => 'newpass123'} Chris@1517: Chris@1517: assert_equal nil, u.reload.auth_source Chris@1517: assert u.check_password?('newpass123') Chris@1517: end Chris@1517: Chris@1517: def test_update_notified_project Chris@1517: get :edit, :id => 2 Chris@1517: assert_response :success Chris@1517: assert_template 'edit' Chris@1517: u = User.find(2) Chris@1517: assert_equal [1, 2, 5], u.projects.collect{|p| p.id}.sort Chris@1517: assert_equal [1, 2, 5], u.notified_projects_ids.sort Chris@1517: assert_select 'input[name=?][value=?]', 'user[notified_project_ids][]', '1' Chris@1517: assert_equal 'all', u.mail_notification Chris@1517: put :update, :id => 2, Chris@1517: :user => { Chris@1517: :mail_notification => 'selected', Chris@1517: :notified_project_ids => [1, 2] Chris@1517: } Chris@1517: u = User.find(2) Chris@1517: assert_equal 'selected', u.mail_notification Chris@1517: assert_equal [1, 2], u.notified_projects_ids.sort Chris@1517: end Chris@1517: Chris@1517: def test_update_status_should_not_update_attributes Chris@1517: user = User.find(2) Chris@1517: user.pref[:no_self_notified] = '1' Chris@1517: user.pref.save Chris@1517: Chris@1517: put :update, :id => 2, :user => {:status => 3} Chris@1517: assert_response 302 Chris@1517: user = User.find(2) Chris@1517: assert_equal 3, user.status Chris@1517: assert_equal '1', user.pref[:no_self_notified] Chris@1517: end Chris@1517: Chris@1517: def test_destroy Chris@1517: assert_difference 'User.count', -1 do Chris@1517: delete :destroy, :id => 2 Chris@1517: end Chris@1517: assert_redirected_to '/users' Chris@1517: assert_nil User.find_by_id(2) Chris@1517: end Chris@1517: Chris@1517: def test_destroy_should_be_denied_for_non_admin_users Chris@1517: @request.session[:user_id] = 3 Chris@1517: Chris@1517: assert_no_difference 'User.count' do Chris@1517: get :destroy, :id => 2 Chris@1517: end Chris@1517: assert_response 403 Chris@1517: end Chris@1517: Chris@1517: def test_destroy_should_redirect_to_back_url_param Chris@1517: assert_difference 'User.count', -1 do Chris@1517: delete :destroy, :id => 2, :back_url => '/users?name=foo' Chris@1517: end Chris@1517: assert_redirected_to '/users?name=foo' Chris@1517: end Chris@1517: Chris@1517: def test_create_membership Chris@1517: assert_difference 'Member.count' do Chris@1517: post :edit_membership, :id => 7, :membership => { :project_id => 3, :role_ids => [2]} Chris@1517: end Chris@1517: assert_redirected_to :action => 'edit', :id => '7', :tab => 'memberships' Chris@1517: member = Member.order('id DESC').first Chris@1517: assert_equal User.find(7), member.principal Chris@1517: assert_equal [2], member.role_ids Chris@1517: assert_equal 3, member.project_id Chris@1517: end Chris@1517: Chris@1517: def test_create_membership_js_format Chris@1517: assert_difference 'Member.count' do Chris@1517: post :edit_membership, :id => 7, :membership => {:project_id => 3, :role_ids => [2]}, :format => 'js' Chris@1517: assert_response :success Chris@1517: assert_template 'edit_membership' Chris@1517: assert_equal 'text/javascript', response.content_type Chris@1517: end Chris@1517: member = Member.order('id DESC').first Chris@1517: assert_equal User.find(7), member.principal Chris@1517: assert_equal [2], member.role_ids Chris@1517: assert_equal 3, member.project_id Chris@1517: assert_include 'tab-content-memberships', response.body Chris@1517: end Chris@1517: Chris@1517: def test_create_membership_js_format_with_failure Chris@1517: assert_no_difference 'Member.count' do Chris@1517: post :edit_membership, :id => 7, :membership => {:project_id => 3}, :format => 'js' Chris@1517: assert_response :success Chris@1517: assert_template 'edit_membership' Chris@1517: assert_equal 'text/javascript', response.content_type Chris@1517: end Chris@1517: assert_include 'alert', response.body, "Alert message not sent" Chris@1517: assert_include 'Role can\\\'t be empty', response.body, "Error message not sent" Chris@1517: end Chris@1517: Chris@1517: def test_update_membership Chris@1517: assert_no_difference 'Member.count' do Chris@1517: put :edit_membership, :id => 2, :membership_id => 1, :membership => { :role_ids => [2]} Chris@1517: assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships' Chris@1517: end Chris@1517: assert_equal [2], Member.find(1).role_ids Chris@1517: end Chris@1517: Chris@1517: def test_update_membership_js_format Chris@1517: assert_no_difference 'Member.count' do Chris@1517: put :edit_membership, :id => 2, :membership_id => 1, :membership => {:role_ids => [2]}, :format => 'js' Chris@1517: assert_response :success Chris@1517: assert_template 'edit_membership' Chris@1517: assert_equal 'text/javascript', response.content_type Chris@1517: end Chris@1517: assert_equal [2], Member.find(1).role_ids Chris@1517: assert_include 'tab-content-memberships', response.body Chris@1517: end Chris@1517: Chris@1517: def test_destroy_membership Chris@1517: assert_difference 'Member.count', -1 do Chris@1517: delete :destroy_membership, :id => 2, :membership_id => 1 Chris@1517: end Chris@1517: assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships' Chris@1517: assert_nil Member.find_by_id(1) Chris@1517: end Chris@1517: Chris@1517: def test_destroy_membership_js_format Chris@1517: assert_difference 'Member.count', -1 do Chris@1517: delete :destroy_membership, :id => 2, :membership_id => 1, :format => 'js' Chris@1517: assert_response :success Chris@1517: assert_template 'destroy_membership' Chris@1517: assert_equal 'text/javascript', response.content_type Chris@1517: end Chris@1517: assert_nil Member.find_by_id(1) Chris@1517: assert_include 'tab-content-memberships', response.body Chris@1517: end Chris@1517: end