Chris@1494: # Redmine - project management software
Chris@1494: # Copyright (C) 2006-2014  Jean-Philippe Lang
Chris@1494: #
Chris@1494: # This program is free software; you can redistribute it and/or
Chris@1494: # modify it under the terms of the GNU General Public License
Chris@1494: # as published by the Free Software Foundation; either version 2
Chris@1494: # of the License, or (at your option) any later version.
Chris@1494: #
Chris@1494: # This program is distributed in the hope that it will be useful,
Chris@1494: # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1494: # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
Chris@1494: # GNU General Public License for more details.
Chris@1494: #
Chris@1494: # You should have received a copy of the GNU General Public License
Chris@1494: # along with this program; if not, write to the Free Software
Chris@1494: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
Chris@1494: 
Chris@1494: require File.expand_path('../../../test_helper', __FILE__)
Chris@1494: 
Chris@1494: class Redmine::ApiTest::IssuesTest < Redmine::ApiTest::Base
Chris@1494:   fixtures :projects,
Chris@1494:     :users,
Chris@1494:     :roles,
Chris@1494:     :members,
Chris@1494:     :member_roles,
Chris@1494:     :issues,
Chris@1494:     :issue_statuses,
Chris@1494:     :issue_relations,
Chris@1494:     :versions,
Chris@1494:     :trackers,
Chris@1494:     :projects_trackers,
Chris@1494:     :issue_categories,
Chris@1494:     :enabled_modules,
Chris@1494:     :enumerations,
Chris@1494:     :attachments,
Chris@1494:     :workflows,
Chris@1494:     :custom_fields,
Chris@1494:     :custom_values,
Chris@1494:     :custom_fields_projects,
Chris@1494:     :custom_fields_trackers,
Chris@1494:     :time_entries,
Chris@1494:     :journals,
Chris@1494:     :journal_details,
Chris@1494:     :queries,
Chris@1494:     :attachments
Chris@1494: 
Chris@1494:   def setup
Chris@1494:     Setting.rest_api_enabled = '1'
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "/issues" do
Chris@1494:     # Use a private project to make sure auth is really working and not just
Chris@1494:     # only showing public issues.
Chris@1494:     should_allow_api_authentication(:get, "/projects/private-child/issues.xml")
Chris@1494: 
Chris@1494:     should "contain metadata" do
Chris@1494:       get '/issues.xml'
Chris@1494: 
Chris@1494:       assert_tag :tag => 'issues',
Chris@1494:         :attributes => {
Chris@1494:           :type => 'array',
Chris@1494:           :total_count => assigns(:issue_count),
Chris@1494:           :limit => 25,
Chris@1494:           :offset => 0
Chris@1494:         }
Chris@1494:     end
Chris@1494: 
Chris@1494:     context "with offset and limit" do
Chris@1494:       should "use the params" do
Chris@1494:         get '/issues.xml?offset=2&limit=3'
Chris@1494: 
Chris@1494:         assert_equal 3, assigns(:limit)
Chris@1494:         assert_equal 2, assigns(:offset)
Chris@1494:         assert_tag :tag => 'issues', :children => {:count => 3, :only => {:tag => 'issue'}}
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     context "with nometa param" do
Chris@1494:       should "not contain metadata" do
Chris@1494:         get '/issues.xml?nometa=1'
Chris@1494: 
Chris@1494:         assert_tag :tag => 'issues',
Chris@1494:           :attributes => {
Chris@1494:             :type => 'array',
Chris@1494:             :total_count => nil,
Chris@1494:             :limit => nil,
Chris@1494:             :offset => nil
Chris@1494:           }
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     context "with nometa header" do
Chris@1494:       should "not contain metadata" do
Chris@1494:         get '/issues.xml', {}, {'X-Redmine-Nometa' => '1'}
Chris@1494: 
Chris@1494:         assert_tag :tag => 'issues',
Chris@1494:           :attributes => {
Chris@1494:             :type => 'array',
Chris@1494:             :total_count => nil,
Chris@1494:             :limit => nil,
Chris@1494:             :offset => nil
Chris@1494:           }
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     context "with relations" do
Chris@1494:       should "display relations" do
Chris@1494:         get '/issues.xml?include=relations'
Chris@1494: 
Chris@1494:         assert_response :success
Chris@1494:         assert_equal 'application/xml', @response.content_type
Chris@1494:         assert_tag 'relations',
Chris@1494:           :parent => {:tag => 'issue', :child => {:tag => 'id', :content => '3'}},
Chris@1494:           :children => {:count => 1},
Chris@1494:           :child => {
Chris@1494:             :tag => 'relation',
Chris@1494:             :attributes => {:id => '2', :issue_id => '2', :issue_to_id => '3',
Chris@1494:                             :relation_type => 'relates'}
Chris@1494:           }
Chris@1494:         assert_tag 'relations',
Chris@1494:           :parent => {:tag => 'issue', :child => {:tag => 'id', :content => '1'}},
Chris@1494:           :children => {:count => 0}
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     context "with invalid query params" do
Chris@1494:       should "return errors" do
Chris@1494:         get '/issues.xml', {:f => ['start_date'], :op => {:start_date => '='}}
Chris@1494: 
Chris@1494:         assert_response :unprocessable_entity
Chris@1494:         assert_equal 'application/xml', @response.content_type
Chris@1494:         assert_tag 'errors', :child => {:tag => 'error', :content => "Start date can't be blank"}
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     context "with custom field filter" do
Chris@1494:       should "show only issues with the custom field value" do
Chris@1494:         get '/issues.xml',
Chris@1494:             {:set_filter => 1, :f => ['cf_1'], :op => {:cf_1 => '='},
Chris@1494:              :v => {:cf_1 => ['MySQL']}}
Chris@1494:         expected_ids = Issue.visible.
Chris@1494:             joins(:custom_values).
Chris@1494:             where(:custom_values => {:custom_field_id => 1, :value => 'MySQL'}).map(&:id)
Chris@1494:         assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
Chris@1494:            ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
Chris@1494:         end
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     context "with custom field filter (shorthand method)" do
Chris@1494:       should "show only issues with the custom field value" do
Chris@1494:         get '/issues.xml', { :cf_1 => 'MySQL' }
Chris@1494: 
Chris@1494:         expected_ids = Issue.visible.
Chris@1494:             joins(:custom_values).
Chris@1494:             where(:custom_values => {:custom_field_id => 1, :value => 'MySQL'}).map(&:id)
Chris@1494: 
Chris@1494:         assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
Chris@1494:           ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
Chris@1494:         end
Chris@1494:       end
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "/index.json" do
Chris@1494:     should_allow_api_authentication(:get, "/projects/private-child/issues.json")
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "/index.xml with filter" do
Chris@1494:     should "show only issues with the status_id" do
Chris@1494:       get '/issues.xml?status_id=5'
Chris@1494: 
Chris@1494:       expected_ids = Issue.visible.where(:status_id => 5).map(&:id)
Chris@1494: 
Chris@1494:       assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
Chris@1494:          ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
Chris@1494:       end
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "/index.json with filter" do
Chris@1494:     should "show only issues with the status_id" do
Chris@1494:       get '/issues.json?status_id=5'
Chris@1494: 
Chris@1494:       json = ActiveSupport::JSON.decode(response.body)
Chris@1494:       status_ids_used = json['issues'].collect {|j| j['status']['id'] }
Chris@1494:       assert_equal 3, status_ids_used.length
Chris@1494:       assert status_ids_used.all? {|id| id == 5 }
Chris@1494:     end
Chris@1494: 
Chris@1494:   end
Chris@1494: 
Chris@1494:   # Issue 6 is on a private project
Chris@1494:   context "/issues/6.xml" do
Chris@1494:     should_allow_api_authentication(:get, "/issues/6.xml")
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "/issues/6.json" do
Chris@1494:     should_allow_api_authentication(:get, "/issues/6.json")
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "GET /issues/:id" do
Chris@1494:     context "with journals" do
Chris@1494:       context ".xml" do
Chris@1494:         should "display journals" do
Chris@1494:           get '/issues/1.xml?include=journals'
Chris@1494: 
Chris@1494:           assert_tag :tag => 'issue',
Chris@1494:             :child => {
Chris@1494:               :tag => 'journals',
Chris@1494:               :attributes => { :type => 'array' },
Chris@1494:               :child => {
Chris@1494:                 :tag => 'journal',
Chris@1494:                 :attributes => { :id => '1'},
Chris@1494:                 :child => {
Chris@1494:                   :tag => 'details',
Chris@1494:                   :attributes => { :type => 'array' },
Chris@1494:                   :child => {
Chris@1494:                     :tag => 'detail',
Chris@1494:                     :attributes => { :name => 'status_id' },
Chris@1494:                     :child => {
Chris@1494:                       :tag => 'old_value',
Chris@1494:                       :content => '1',
Chris@1494:                       :sibling => {
Chris@1494:                         :tag => 'new_value',
Chris@1494:                         :content => '2'
Chris@1494:                       }
Chris@1494:                     }
Chris@1494:                   }
Chris@1494:                 }
Chris@1494:               }
Chris@1494:             }
Chris@1494:         end
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     context "with custom fields" do
Chris@1494:       context ".xml" do
Chris@1494:         should "display custom fields" do
Chris@1494:           get '/issues/3.xml'
Chris@1494: 
Chris@1494:           assert_tag :tag => 'issue',
Chris@1494:             :child => {
Chris@1494:               :tag => 'custom_fields',
Chris@1494:               :attributes => { :type => 'array' },
Chris@1494:               :child => {
Chris@1494:                 :tag => 'custom_field',
Chris@1494:                 :attributes => { :id => '1'},
Chris@1494:                 :child => {
Chris@1494:                   :tag => 'value',
Chris@1494:                   :content => 'MySQL'
Chris@1494:                 }
Chris@1494:               }
Chris@1494:             }
Chris@1494: 
Chris@1494:           assert_nothing_raised do
Chris@1494:             Hash.from_xml(response.body).to_xml
Chris@1494:           end
Chris@1494:         end
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     context "with multi custom fields" do
Chris@1494:       setup do
Chris@1494:         field = CustomField.find(1)
Chris@1494:         field.update_attribute :multiple, true
Chris@1494:         issue = Issue.find(3)
Chris@1494:         issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
Chris@1494:         issue.save!
Chris@1494:       end
Chris@1494: 
Chris@1494:       context ".xml" do
Chris@1494:         should "display custom fields" do
Chris@1494:           get '/issues/3.xml'
Chris@1494:           assert_response :success
Chris@1494:           assert_tag :tag => 'issue',
Chris@1494:             :child => {
Chris@1494:               :tag => 'custom_fields',
Chris@1494:               :attributes => { :type => 'array' },
Chris@1494:               :child => {
Chris@1494:                 :tag => 'custom_field',
Chris@1494:                 :attributes => { :id => '1'},
Chris@1494:                 :child => {
Chris@1494:                   :tag => 'value',
Chris@1494:                   :attributes => { :type => 'array' },
Chris@1494:                   :children => { :count => 2 }
Chris@1494:                 }
Chris@1494:               }
Chris@1494:             }
Chris@1494: 
Chris@1494:           xml = Hash.from_xml(response.body)
Chris@1494:           custom_fields = xml['issue']['custom_fields']
Chris@1494:           assert_kind_of Array, custom_fields
Chris@1494:           field = custom_fields.detect {|f| f['id'] == '1'}
Chris@1494:           assert_kind_of Hash, field
Chris@1494:           assert_equal ['MySQL', 'Oracle'], field['value'].sort
Chris@1494:         end
Chris@1494:       end
Chris@1494: 
Chris@1494:       context ".json" do
Chris@1494:         should "display custom fields" do
Chris@1494:           get '/issues/3.json'
Chris@1494:           assert_response :success
Chris@1494:           json = ActiveSupport::JSON.decode(response.body)
Chris@1494:           custom_fields = json['issue']['custom_fields']
Chris@1494:           assert_kind_of Array, custom_fields
Chris@1494:           field = custom_fields.detect {|f| f['id'] == 1}
Chris@1494:           assert_kind_of Hash, field
Chris@1494:           assert_equal ['MySQL', 'Oracle'], field['value'].sort
Chris@1494:         end
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     context "with empty value for multi custom field" do
Chris@1494:       setup do
Chris@1494:         field = CustomField.find(1)
Chris@1494:         field.update_attribute :multiple, true
Chris@1494:         issue = Issue.find(3)
Chris@1494:         issue.custom_field_values = {1 => ['']}
Chris@1494:         issue.save!
Chris@1494:       end
Chris@1494: 
Chris@1494:       context ".xml" do
Chris@1494:         should "display custom fields" do
Chris@1494:           get '/issues/3.xml'
Chris@1494:           assert_response :success
Chris@1494:           assert_tag :tag => 'issue',
Chris@1494:             :child => {
Chris@1494:               :tag => 'custom_fields',
Chris@1494:               :attributes => { :type => 'array' },
Chris@1494:               :child => {
Chris@1494:                 :tag => 'custom_field',
Chris@1494:                 :attributes => { :id => '1'},
Chris@1494:                 :child => {
Chris@1494:                   :tag => 'value',
Chris@1494:                   :attributes => { :type => 'array' },
Chris@1494:                   :children => { :count => 0 }
Chris@1494:                 }
Chris@1494:               }
Chris@1494:             }
Chris@1494: 
Chris@1494:           xml = Hash.from_xml(response.body)
Chris@1494:           custom_fields = xml['issue']['custom_fields']
Chris@1494:           assert_kind_of Array, custom_fields
Chris@1494:           field = custom_fields.detect {|f| f['id'] == '1'}
Chris@1494:           assert_kind_of Hash, field
Chris@1494:           assert_equal [], field['value']
Chris@1494:         end
Chris@1494:       end
Chris@1494: 
Chris@1494:       context ".json" do
Chris@1494:         should "display custom fields" do
Chris@1494:           get '/issues/3.json'
Chris@1494:           assert_response :success
Chris@1494:           json = ActiveSupport::JSON.decode(response.body)
Chris@1494:           custom_fields = json['issue']['custom_fields']
Chris@1494:           assert_kind_of Array, custom_fields
Chris@1494:           field = custom_fields.detect {|f| f['id'] == 1}
Chris@1494:           assert_kind_of Hash, field
Chris@1494:           assert_equal [], field['value'].sort
Chris@1494:         end
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     context "with attachments" do
Chris@1494:       context ".xml" do
Chris@1494:         should "display attachments" do
Chris@1494:           get '/issues/3.xml?include=attachments'
Chris@1494: 
Chris@1494:           assert_tag :tag => 'issue',
Chris@1494:             :child => {
Chris@1494:               :tag => 'attachments',
Chris@1494:               :children => {:count => 5},
Chris@1494:               :child => {
Chris@1494:                 :tag => 'attachment',
Chris@1494:                 :child => {
Chris@1494:                   :tag => 'filename',
Chris@1494:                   :content => 'source.rb',
Chris@1494:                   :sibling => {
Chris@1494:                     :tag => 'content_url',
Chris@1494:                     :content => 'http://www.example.com/attachments/download/4/source.rb'
Chris@1494:                   }
Chris@1494:                 }
Chris@1494:               }
Chris@1494:             }
Chris@1494:         end
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     context "with subtasks" do
Chris@1494:       setup do
Chris@1494:         @c1 = Issue.create!(
Chris@1494:                 :status_id => 1, :subject => "child c1",
Chris@1494:                 :tracker_id => 1, :project_id => 1, :author_id => 1,
Chris@1494:                 :parent_issue_id => 1
Chris@1494:               )
Chris@1494:         @c2 = Issue.create!(
Chris@1494:                 :status_id => 1, :subject => "child c2",
Chris@1494:                 :tracker_id => 1, :project_id => 1, :author_id => 1,
Chris@1494:                 :parent_issue_id => 1
Chris@1494:               )
Chris@1494:         @c3 = Issue.create!(
Chris@1494:                 :status_id => 1, :subject => "child c3",
Chris@1494:                 :tracker_id => 1, :project_id => 1, :author_id => 1,
Chris@1494:                 :parent_issue_id => @c1.id
Chris@1494:               )
Chris@1494:       end
Chris@1494: 
Chris@1494:       context ".xml" do
Chris@1494:         should "display children" do
Chris@1494:           get '/issues/1.xml?include=children'
Chris@1494: 
Chris@1494:           assert_tag :tag => 'issue',
Chris@1494:             :child => {
Chris@1494:               :tag => 'children',
Chris@1494:               :children => {:count => 2},
Chris@1494:               :child => {
Chris@1494:                 :tag => 'issue',
Chris@1494:                 :attributes => {:id => @c1.id.to_s},
Chris@1494:                 :child => {
Chris@1494:                   :tag => 'subject',
Chris@1494:                   :content => 'child c1',
Chris@1494:                   :sibling => {
Chris@1494:                     :tag => 'children',
Chris@1494:                     :children => {:count => 1},
Chris@1494:                     :child => {
Chris@1494:                       :tag => 'issue',
Chris@1494:                       :attributes => {:id => @c3.id.to_s}
Chris@1494:                     }
Chris@1494:                   }
Chris@1494:                 }
Chris@1494:               }
Chris@1494:             }
Chris@1494:         end
Chris@1494: 
Chris@1494:         context ".json" do
Chris@1494:           should "display children" do
Chris@1494:             get '/issues/1.json?include=children'
Chris@1494: 
Chris@1494:             json = ActiveSupport::JSON.decode(response.body)
Chris@1494:             assert_equal([
Chris@1494:               {
Chris@1494:                 'id' => @c1.id, 'subject' => 'child c1', 'tracker' => {'id' => 1, 'name' => 'Bug'},
Chris@1494:                 'children' => [{'id' => @c3.id, 'subject' => 'child c3',
Chris@1494:                                 'tracker' => {'id' => 1, 'name' => 'Bug'} }]
Chris@1494:               },
Chris@1494:               { 'id' => @c2.id, 'subject' => 'child c2', 'tracker' => {'id' => 1, 'name' => 'Bug'} }
Chris@1494:               ],
Chris@1494:               json['issue']['children'])
Chris@1494:           end
Chris@1494:         end
Chris@1494:       end
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   test "GET /issues/:id.xml?include=watchers should include watchers" do
Chris@1494:     Watcher.create!(:user_id => 3, :watchable => Issue.find(1))
Chris@1494: 
Chris@1494:     get '/issues/1.xml?include=watchers', {}, credentials('jsmith')
Chris@1494: 
Chris@1494:     assert_response :ok
Chris@1494:     assert_equal 'application/xml', response.content_type
Chris@1494:     assert_select 'issue' do
Chris@1494:       assert_select 'watchers', Issue.find(1).watchers.count
Chris@1494:       assert_select 'watchers' do
Chris@1494:         assert_select 'user[id=3]'
Chris@1494:       end
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "POST /issues.xml" do
Chris@1494:     should_allow_api_authentication(
Chris@1494:       :post,
Chris@1494:       '/issues.xml',
Chris@1494:       {:issue => {:project_id => 1, :subject => 'API test', :tracker_id => 2, :status_id => 3}},
Chris@1494:       {:success_code => :created}
Chris@1494:     )
Chris@1494:     should "create an issue with the attributes" do
Chris@1494:       assert_difference('Issue.count') do
Chris@1494:         post '/issues.xml',
Chris@1494:              {:issue => {:project_id => 1, :subject => 'API test',
Chris@1494:               :tracker_id => 2, :status_id => 3}}, credentials('jsmith')
Chris@1494:       end
Chris@1494:       issue = Issue.first(:order => 'id DESC')
Chris@1494:       assert_equal 1, issue.project_id
Chris@1494:       assert_equal 2, issue.tracker_id
Chris@1494:       assert_equal 3, issue.status_id
Chris@1494:       assert_equal 'API test', issue.subject
Chris@1494: 
Chris@1494:       assert_response :created
Chris@1494:       assert_equal 'application/xml', @response.content_type
Chris@1494:       assert_tag 'issue', :child => {:tag => 'id', :content => issue.id.to_s}
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   test "POST /issues.xml with watcher_user_ids should create issue with watchers" do
Chris@1494:     assert_difference('Issue.count') do
Chris@1494:       post '/issues.xml',
Chris@1494:            {:issue => {:project_id => 1, :subject => 'Watchers',
Chris@1494:             :tracker_id => 2, :status_id => 3, :watcher_user_ids => [3, 1]}}, credentials('jsmith')
Chris@1494:       assert_response :created
Chris@1494:     end
Chris@1494:     issue = Issue.order('id desc').first
Chris@1494:     assert_equal 2, issue.watchers.size
Chris@1494:     assert_equal [1, 3], issue.watcher_user_ids.sort
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "POST /issues.xml with failure" do
Chris@1494:     should "have an errors tag" do
Chris@1494:       assert_no_difference('Issue.count') do
Chris@1494:         post '/issues.xml', {:issue => {:project_id => 1}}, credentials('jsmith')
Chris@1494:       end
Chris@1494: 
Chris@1494:       assert_tag :errors, :child => {:tag => 'error', :content => "Subject can't be blank"}
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "POST /issues.json" do
Chris@1494:     should_allow_api_authentication(:post,
Chris@1494:                                     '/issues.json',
Chris@1494:                                     {:issue => {:project_id => 1, :subject => 'API test',
Chris@1494:                                      :tracker_id => 2, :status_id => 3}},
Chris@1494:                                     {:success_code => :created})
Chris@1494: 
Chris@1494:     should "create an issue with the attributes" do
Chris@1494:       assert_difference('Issue.count') do
Chris@1494:         post '/issues.json',
Chris@1494:              {:issue => {:project_id => 1, :subject => 'API test',
Chris@1494:                          :tracker_id => 2, :status_id => 3}},
Chris@1494:              credentials('jsmith')
Chris@1494:       end
Chris@1494: 
Chris@1494:       issue = Issue.first(:order => 'id DESC')
Chris@1494:       assert_equal 1, issue.project_id
Chris@1494:       assert_equal 2, issue.tracker_id
Chris@1494:       assert_equal 3, issue.status_id
Chris@1494:       assert_equal 'API test', issue.subject
Chris@1494:     end
Chris@1494: 
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "POST /issues.json with failure" do
Chris@1494:     should "have an errors element" do
Chris@1494:       assert_no_difference('Issue.count') do
Chris@1494:         post '/issues.json', {:issue => {:project_id => 1}}, credentials('jsmith')
Chris@1494:       end
Chris@1494: 
Chris@1494:       json = ActiveSupport::JSON.decode(response.body)
Chris@1494:       assert json['errors'].include?("Subject can't be blank")
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   # Issue 6 is on a private project
Chris@1494:   context "PUT /issues/6.xml" do
Chris@1494:     setup do
Chris@1494:       @parameters = {:issue => {:subject => 'API update', :notes => 'A new note'}}
Chris@1494:     end
Chris@1494: 
Chris@1494:     should_allow_api_authentication(:put,
Chris@1494:                                     '/issues/6.xml',
Chris@1494:                                     {:issue => {:subject => 'API update', :notes => 'A new note'}},
Chris@1494:                                     {:success_code => :ok})
Chris@1494: 
Chris@1494:     should "not create a new issue" do
Chris@1494:       assert_no_difference('Issue.count') do
Chris@1494:         put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     should "create a new journal" do
Chris@1494:       assert_difference('Journal.count') do
Chris@1494:         put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     should "add the note to the journal" do
Chris@1494:       put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1494: 
Chris@1494:       journal = Journal.last
Chris@1494:       assert_equal "A new note", journal.notes
Chris@1494:     end
Chris@1494: 
Chris@1494:     should "update the issue" do
Chris@1494:       put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1494: 
Chris@1494:       issue = Issue.find(6)
Chris@1494:       assert_equal "API update", issue.subject
Chris@1494:     end
Chris@1494: 
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "PUT /issues/3.xml with custom fields" do
Chris@1494:     setup do
Chris@1494:       @parameters = {
Chris@1494:         :issue => {:custom_fields => [{'id' => '1', 'value' => 'PostgreSQL' },
Chris@1494:         {'id' => '2', 'value' => '150'}]}
Chris@1494:       }
Chris@1494:     end
Chris@1494: 
Chris@1494:     should "update custom fields" do
Chris@1494:       assert_no_difference('Issue.count') do
Chris@1494:         put '/issues/3.xml', @parameters, credentials('jsmith')
Chris@1494:       end
Chris@1494: 
Chris@1494:       issue = Issue.find(3)
Chris@1494:       assert_equal '150', issue.custom_value_for(2).value
Chris@1494:       assert_equal 'PostgreSQL', issue.custom_value_for(1).value
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "PUT /issues/3.xml with multi custom fields" do
Chris@1494:     setup do
Chris@1494:       field = CustomField.find(1)
Chris@1494:       field.update_attribute :multiple, true
Chris@1494:       @parameters = {
Chris@1494:         :issue => {:custom_fields => [{'id' => '1', 'value' => ['MySQL', 'PostgreSQL'] },
Chris@1494:         {'id' => '2', 'value' => '150'}]}
Chris@1494:       }
Chris@1494:     end
Chris@1494: 
Chris@1494:     should "update custom fields" do
Chris@1494:       assert_no_difference('Issue.count') do
Chris@1494:         put '/issues/3.xml', @parameters, credentials('jsmith')
Chris@1494:       end
Chris@1494: 
Chris@1494:       issue = Issue.find(3)
Chris@1494:       assert_equal '150', issue.custom_value_for(2).value
Chris@1494:       assert_equal ['MySQL', 'PostgreSQL'], issue.custom_field_value(1).sort
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "PUT /issues/3.xml with project change" do
Chris@1494:     setup do
Chris@1494:       @parameters = {:issue => {:project_id => 2, :subject => 'Project changed'}}
Chris@1494:     end
Chris@1494: 
Chris@1494:     should "update project" do
Chris@1494:       assert_no_difference('Issue.count') do
Chris@1494:         put '/issues/3.xml', @parameters, credentials('jsmith')
Chris@1494:       end
Chris@1494: 
Chris@1494:       issue = Issue.find(3)
Chris@1494:       assert_equal 2, issue.project_id
Chris@1494:       assert_equal 'Project changed', issue.subject
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "PUT /issues/6.xml with failed update" do
Chris@1494:     setup do
Chris@1494:       @parameters = {:issue => {:subject => ''}}
Chris@1494:     end
Chris@1494: 
Chris@1494:     should "not create a new issue" do
Chris@1494:       assert_no_difference('Issue.count') do
Chris@1494:         put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     should "not create a new journal" do
Chris@1494:       assert_no_difference('Journal.count') do
Chris@1494:         put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1494:       end
Chris@1494:     end
Chris@1494: 
Chris@1494:     should "have an errors tag" do
Chris@1494:       put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1494: 
Chris@1494:       assert_tag :errors, :child => {:tag => 'error', :content => "Subject can't be blank"}
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "PUT /issues/6.json" do
Chris@1494:     setup do
Chris@1494:       @parameters = {:issue => {:subject => 'API update', :notes => 'A new note'}}
Chris@1494:     end
Chris@1494: 
Chris@1494:     should_allow_api_authentication(:put,
Chris@1494:                                     '/issues/6.json',
Chris@1494:                                     {:issue => {:subject => 'API update', :notes => 'A new note'}},
Chris@1494:                                     {:success_code => :ok})
Chris@1494: 
Chris@1494:     should "update the issue" do
Chris@1494:       assert_no_difference('Issue.count') do
Chris@1494:         assert_difference('Journal.count') do
Chris@1494:           put '/issues/6.json', @parameters, credentials('jsmith')
Chris@1494: 
Chris@1494:           assert_response :ok
Chris@1494:           assert_equal '', response.body
Chris@1494:         end
Chris@1494:       end
Chris@1494: 
Chris@1494:       issue = Issue.find(6)
Chris@1494:       assert_equal "API update", issue.subject
Chris@1494:       journal = Journal.last
Chris@1494:       assert_equal "A new note", journal.notes
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "PUT /issues/6.json with failed update" do
Chris@1494:     should "return errors" do
Chris@1494:       assert_no_difference('Issue.count') do
Chris@1494:         assert_no_difference('Journal.count') do
Chris@1494:           put '/issues/6.json', {:issue => {:subject => ''}}, credentials('jsmith')
Chris@1494: 
Chris@1494:           assert_response :unprocessable_entity
Chris@1494:         end
Chris@1494:       end
Chris@1494: 
Chris@1494:       json = ActiveSupport::JSON.decode(response.body)
Chris@1494:       assert json['errors'].include?("Subject can't be blank")
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "DELETE /issues/1.xml" do
Chris@1494:     should_allow_api_authentication(:delete,
Chris@1494:                                     '/issues/6.xml',
Chris@1494:                                     {},
Chris@1494:                                     {:success_code => :ok})
Chris@1494: 
Chris@1494:     should "delete the issue" do
Chris@1494:       assert_difference('Issue.count', -1) do
Chris@1494:         delete '/issues/6.xml', {}, credentials('jsmith')
Chris@1494: 
Chris@1494:         assert_response :ok
Chris@1494:         assert_equal '', response.body
Chris@1494:       end
Chris@1494: 
Chris@1494:       assert_nil Issue.find_by_id(6)
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   context "DELETE /issues/1.json" do
Chris@1494:     should_allow_api_authentication(:delete,
Chris@1494:                                     '/issues/6.json',
Chris@1494:                                     {},
Chris@1494:                                     {:success_code => :ok})
Chris@1494: 
Chris@1494:     should "delete the issue" do
Chris@1494:       assert_difference('Issue.count', -1) do
Chris@1494:         delete '/issues/6.json', {}, credentials('jsmith')
Chris@1494: 
Chris@1494:         assert_response :ok
Chris@1494:         assert_equal '', response.body
Chris@1494:       end
Chris@1494: 
Chris@1494:       assert_nil Issue.find_by_id(6)
Chris@1494:     end
Chris@1494:   end
Chris@1494: 
Chris@1494:   test "POST /issues/:id/watchers.xml should add watcher" do
Chris@1494:     assert_difference 'Watcher.count' do
Chris@1494:       post '/issues/1/watchers.xml', {:user_id => 3}, credentials('jsmith')
Chris@1494: 
Chris@1494:       assert_response :ok
Chris@1494:       assert_equal '', response.body
Chris@1494:     end
Chris@1494:     watcher = Watcher.order('id desc').first
Chris@1494:     assert_equal Issue.find(1), watcher.watchable
Chris@1494:     assert_equal User.find(3), watcher.user
Chris@1494:   end
Chris@1494: 
Chris@1494:   test "DELETE /issues/:id/watchers/:user_id.xml should remove watcher" do
Chris@1494:     Watcher.create!(:user_id => 3, :watchable => Issue.find(1))
Chris@1494: 
Chris@1494:     assert_difference 'Watcher.count', -1 do
Chris@1494:       delete '/issues/1/watchers/3.xml', {}, credentials('jsmith')
Chris@1494: 
Chris@1494:       assert_response :ok
Chris@1494:       assert_equal '', response.body
Chris@1494:     end
Chris@1494:     assert_equal false, Issue.find(1).watched_by?(User.find(3))
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_create_issue_with_uploaded_file
Chris@1494:     set_tmp_attachments_directory
Chris@1494:     # upload the file
Chris@1494:     assert_difference 'Attachment.count' do
Chris@1494:       post '/uploads.xml', 'test_create_with_upload',
Chris@1494:            {"CONTENT_TYPE" => 'application/octet-stream'}.merge(credentials('jsmith'))
Chris@1494:       assert_response :created
Chris@1494:     end
Chris@1494:     xml = Hash.from_xml(response.body)
Chris@1494:     token = xml['upload']['token']
Chris@1494:     attachment = Attachment.first(:order => 'id DESC')
Chris@1494: 
Chris@1494:     # create the issue with the upload's token
Chris@1494:     assert_difference 'Issue.count' do
Chris@1494:       post '/issues.xml',
Chris@1494:            {:issue => {:project_id => 1, :subject => 'Uploaded file',
Chris@1494:                        :uploads => [{:token => token, :filename => 'test.txt',
Chris@1494:                                      :content_type => 'text/plain'}]}},
Chris@1494:            credentials('jsmith')
Chris@1494:       assert_response :created
Chris@1494:     end
Chris@1494:     issue = Issue.first(:order => 'id DESC')
Chris@1494:     assert_equal 1, issue.attachments.count
Chris@1494:     assert_equal attachment, issue.attachments.first
Chris@1494: 
Chris@1494:     attachment.reload
Chris@1494:     assert_equal 'test.txt', attachment.filename
Chris@1494:     assert_equal 'text/plain', attachment.content_type
Chris@1494:     assert_equal 'test_create_with_upload'.size, attachment.filesize
Chris@1494:     assert_equal 2, attachment.author_id
Chris@1494: 
Chris@1494:     # get the issue with its attachments
Chris@1494:     get "/issues/#{issue.id}.xml", :include => 'attachments'
Chris@1494:     assert_response :success
Chris@1494:     xml = Hash.from_xml(response.body)
Chris@1494:     attachments = xml['issue']['attachments']
Chris@1494:     assert_kind_of Array, attachments
Chris@1494:     assert_equal 1, attachments.size
Chris@1494:     url = attachments.first['content_url']
Chris@1494:     assert_not_nil url
Chris@1494: 
Chris@1494:     # download the attachment
Chris@1494:     get url
Chris@1494:     assert_response :success
Chris@1494:   end
Chris@1494: 
Chris@1494:   def test_update_issue_with_uploaded_file
Chris@1494:     set_tmp_attachments_directory
Chris@1494:     # upload the file
Chris@1494:     assert_difference 'Attachment.count' do
Chris@1494:       post '/uploads.xml', 'test_upload_with_upload',
Chris@1494:            {"CONTENT_TYPE" => 'application/octet-stream'}.merge(credentials('jsmith'))
Chris@1494:       assert_response :created
Chris@1494:     end
Chris@1494:     xml = Hash.from_xml(response.body)
Chris@1494:     token = xml['upload']['token']
Chris@1494:     attachment = Attachment.first(:order => 'id DESC')
Chris@1494: 
Chris@1494:     # update the issue with the upload's token
Chris@1494:     assert_difference 'Journal.count' do
Chris@1494:       put '/issues/1.xml',
Chris@1494:           {:issue => {:notes => 'Attachment added',
Chris@1494:                       :uploads => [{:token => token, :filename => 'test.txt',
Chris@1494:                                     :content_type => 'text/plain'}]}},
Chris@1494:           credentials('jsmith')
Chris@1494:       assert_response :ok
Chris@1494:       assert_equal '', @response.body
Chris@1494:     end
Chris@1494: 
Chris@1494:     issue = Issue.find(1)
Chris@1494:     assert_include attachment, issue.attachments
Chris@1494:   end
Chris@1494: end