Chris@909: # Redmine - project management software
Chris@909: # Copyright (C) 2006-2011  Jean-Philippe Lang
Chris@909: #
Chris@909: # This program is free software; you can redistribute it and/or
Chris@909: # modify it under the terms of the GNU General Public License
Chris@909: # as published by the Free Software Foundation; either version 2
Chris@909: # of the License, or (at your option) any later version.
Chris@909: #
Chris@909: # This program is distributed in the hope that it will be useful,
Chris@909: # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@909: # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
Chris@909: # GNU General Public License for more details.
Chris@909: #
Chris@909: # You should have received a copy of the GNU General Public License
Chris@909: # along with this program; if not, write to the Free Software
Chris@909: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
Chris@909: 
Chris@909: require File.expand_path('../../test_helper', __FILE__)
Chris@909: require 'repositories_controller'
Chris@909: 
Chris@909: # Re-raise errors caught by the controller.
Chris@909: class RepositoriesController; def rescue_action(e) raise e end; end
Chris@909: 
Chris@909: class RepositoriesGitControllerTest < ActionController::TestCase
Chris@909:   fixtures :projects, :users, :roles, :members, :member_roles,
Chris@909:            :repositories, :enabled_modules
Chris@909: 
Chris@909:   REPOSITORY_PATH = Rails.root.join('tmp/test/git_repository').to_s
Chris@909:   REPOSITORY_PATH.gsub!(/\//, "\\") if Redmine::Platform.mswin?
Chris@909:   PRJ_ID     = 3
Chris@909:   CHAR_1_HEX = "\xc3\x9c"
Chris@909:   NUM_REV = 21
Chris@909: 
Chris@909:   ## Git, Mercurial and CVS path encodings are binary.
Chris@909:   ## Subversion supports URL encoding for path.
Chris@909:   ## Redmine Mercurial adapter and extension use URL encoding.
Chris@909:   ## Git accepts only binary path in command line parameter.
Chris@909:   ## So, there is no way to use binary command line parameter in JRuby.
Chris@909:   JRUBY_SKIP     = (RUBY_PLATFORM == 'java')
Chris@909:   JRUBY_SKIP_STR = "TODO: This test fails in JRuby"
Chris@909: 
Chris@909:   def setup
Chris@909:     @ruby19_non_utf8_pass =
Chris@909:       (RUBY_VERSION >= '1.9' && Encoding.default_external.to_s != 'UTF-8')
Chris@909: 
Chris@909:     @controller = RepositoriesController.new
Chris@909:     @request    = ActionController::TestRequest.new
Chris@909:     @response   = ActionController::TestResponse.new
Chris@909:     User.current = nil
Chris@909:     @project    = Project.find(PRJ_ID)
Chris@909:     @repository = Repository::Git.create(
Chris@909:                       :project       => @project,
Chris@909:                       :url           => REPOSITORY_PATH,
Chris@909:                       :path_encoding => 'ISO-8859-1'
Chris@909:                       )
Chris@909:     assert @repository
Chris@909:     @char_1        = CHAR_1_HEX.dup
Chris@909:     if @char_1.respond_to?(:force_encoding)
Chris@909:       @char_1.force_encoding('UTF-8')
Chris@909:     end
Chris@909: 
Chris@909:     Setting.default_language = 'en'
Chris@909:   end
Chris@909: 
Chris@909:   if File.directory?(REPOSITORY_PATH)
Chris@909:     def test_browse_root
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909: 
Chris@909:       get :show, :id => PRJ_ID
Chris@909:       assert_response :success
Chris@909:       assert_template 'show'
Chris@909:       assert_not_nil assigns(:entries)
Chris@909:       assert_equal 9, assigns(:entries).size
Chris@909:       assert assigns(:entries).detect {|e| e.name == 'images' && e.kind == 'dir'}
Chris@909:       assert assigns(:entries).detect {|e| e.name == 'this_is_a_really_long_and_verbose_directory_name' && e.kind == 'dir'}
Chris@909:       assert assigns(:entries).detect {|e| e.name == 'sources' && e.kind == 'dir'}
Chris@909:       assert assigns(:entries).detect {|e| e.name == 'README' && e.kind == 'file'}
Chris@909:       assert assigns(:entries).detect {|e| e.name == 'copied_README' && e.kind == 'file'}
Chris@909:       assert assigns(:entries).detect {|e| e.name == 'new_file.txt' && e.kind == 'file'}
Chris@909:       assert assigns(:entries).detect {|e| e.name == 'renamed_test.txt' && e.kind == 'file'}
Chris@909:       assert assigns(:entries).detect {|e| e.name == 'filemane with spaces.txt' && e.kind == 'file'}
Chris@909:       assert assigns(:entries).detect {|e| e.name == ' filename with a leading space.txt ' && e.kind == 'file'}
Chris@909:       assert_not_nil assigns(:changesets)
Chris@909:       assert assigns(:changesets).size > 0
Chris@909:     end
Chris@909: 
Chris@909:     def test_browse_branch
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909:       get :show, :id => PRJ_ID, :rev => 'test_branch'
Chris@909:       assert_response :success
Chris@909:       assert_template 'show'
Chris@909:       assert_not_nil assigns(:entries)
Chris@909:       assert_equal 4, assigns(:entries).size
Chris@909:       assert assigns(:entries).detect {|e| e.name == 'images' && e.kind == 'dir'}
Chris@909:       assert assigns(:entries).detect {|e| e.name == 'sources' && e.kind == 'dir'}
Chris@909:       assert assigns(:entries).detect {|e| e.name == 'README' && e.kind == 'file'}
Chris@909:       assert assigns(:entries).detect {|e| e.name == 'test.txt' && e.kind == 'file'}
Chris@909:       assert_not_nil assigns(:changesets)
Chris@909:       assert assigns(:changesets).size > 0
Chris@909:     end
Chris@909: 
Chris@909:     def test_browse_tag
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909:        [
Chris@909:         "tag00.lightweight",
Chris@909:         "tag01.annotated",
Chris@909:        ].each do |t1|
Chris@909:         get :show, :id => PRJ_ID, :rev => t1
Chris@909:         assert_response :success
Chris@909:         assert_template 'show'
Chris@909:         assert_not_nil assigns(:entries)
Chris@909:         assert assigns(:entries).size > 0
Chris@909:         assert_not_nil assigns(:changesets)
Chris@909:         assert assigns(:changesets).size > 0
Chris@909:       end
Chris@909:     end
Chris@909: 
Chris@909:     def test_browse_directory
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909:       get :show, :id => PRJ_ID, :path => ['images']
Chris@909:       assert_response :success
Chris@909:       assert_template 'show'
Chris@909:       assert_not_nil assigns(:entries)
Chris@909:       assert_equal ['edit.png'], assigns(:entries).collect(&:name)
Chris@909:       entry = assigns(:entries).detect {|e| e.name == 'edit.png'}
Chris@909:       assert_not_nil entry
Chris@909:       assert_equal 'file', entry.kind
Chris@909:       assert_equal 'images/edit.png', entry.path
Chris@909:       assert_not_nil assigns(:changesets)
Chris@909:       assert assigns(:changesets).size > 0
Chris@909:     end
Chris@909: 
Chris@909:     def test_browse_at_given_revision
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909:       get :show, :id => PRJ_ID, :path => ['images'],
Chris@909:           :rev => '7234cb2750b63f47bff735edc50a1c0a433c2518'
Chris@909:       assert_response :success
Chris@909:       assert_template 'show'
Chris@909:       assert_not_nil assigns(:entries)
Chris@909:       assert_equal ['delete.png'], assigns(:entries).collect(&:name)
Chris@909:       assert_not_nil assigns(:changesets)
Chris@909:       assert assigns(:changesets).size > 0
Chris@909:     end
Chris@909: 
Chris@909:     def test_changes
Chris@909:       get :changes, :id => PRJ_ID, :path => ['images', 'edit.png']
Chris@909:       assert_response :success
Chris@909:       assert_template 'changes'
Chris@909:       assert_tag :tag => 'h2', :content => 'edit.png'
Chris@909:     end
Chris@909: 
Chris@909:     def test_entry_show
Chris@909:       get :entry, :id => PRJ_ID, :path => ['sources', 'watchers_controller.rb']
Chris@909:       assert_response :success
Chris@909:       assert_template 'entry'
Chris@909:       # Line 19
Chris@909:       assert_tag :tag => 'th',
Chris@909:                  :content => '11',
Chris@909:                  :attributes => { :class => 'line-num' },
Chris@909:                  :sibling => { :tag => 'td', :content => /WITHOUT ANY WARRANTY/ }
Chris@909:     end
Chris@909: 
Chris@909:     def test_entry_show_latin_1
Chris@909:       if @ruby19_non_utf8_pass
Chris@909:         puts_ruby19_non_utf8_pass()
Chris@909:       elsif JRUBY_SKIP
Chris@909:         puts JRUBY_SKIP_STR
Chris@909:       else
Chris@909:         with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
Chris@909:           ['57ca437c', '57ca437c0acbbcb749821fdf3726a1367056d364'].each do |r1|
Chris@909:             get :entry, :id => PRJ_ID,
Chris@909:                 :path => ['latin-1-dir', "test-#{@char_1}.txt"], :rev => r1
Chris@909:             assert_response :success
Chris@909:             assert_template 'entry'
Chris@909:             assert_tag :tag => 'th',
Chris@909:                    :content => '1',
Chris@909:                    :attributes => { :class => 'line-num' },
Chris@909:                    :sibling => { :tag => 'td',
Chris@909:                                  :content => /test-#{@char_1}.txt/ }
Chris@909:           end
Chris@909:         end
Chris@909:       end
Chris@909:     end
Chris@909: 
Chris@909:     def test_entry_download
Chris@909:       get :entry, :id => PRJ_ID, :path => ['sources', 'watchers_controller.rb'],
Chris@909:           :format => 'raw'
Chris@909:       assert_response :success
Chris@909:       # File content
Chris@909:       assert @response.body.include?('WITHOUT ANY WARRANTY')
Chris@909:     end
Chris@909: 
Chris@909:     def test_directory_entry
Chris@909:       get :entry, :id => PRJ_ID, :path => ['sources']
Chris@909:       assert_response :success
Chris@909:       assert_template 'show'
Chris@909:       assert_not_nil assigns(:entry)
Chris@909:       assert_equal 'sources', assigns(:entry).name
Chris@909:     end
Chris@909: 
Chris@909:     def test_diff
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909:       # Full diff of changeset 2f9c0091
Chris@909:       ['inline', 'sbs'].each do |dt|
Chris@909:         get :diff,
Chris@909:             :id   => PRJ_ID,
Chris@909:             :rev  => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7',
Chris@909:             :type => dt
Chris@909:         assert_response :success
Chris@909:         assert_template 'diff'
Chris@909:         # Line 22 removed
Chris@909:         assert_tag :tag => 'th',
Chris@909:                    :content => /22/,
Chris@909:                    :sibling => { :tag => 'td',
Chris@909:                                  :attributes => { :class => /diff_out/ },
Chris@909:                                  :content => /def remove/ }
Chris@909:         assert_tag :tag => 'h2', :content => /2f9c0091/
Chris@909:       end
Chris@909:     end
Chris@909: 
Chris@909:     def test_diff_truncated
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909:       Setting.diff_max_lines_displayed = 5
Chris@909: 
Chris@909:       # Truncated diff of changeset 2f9c0091
Chris@909:       with_cache do
Chris@909:         get :diff, :id   => PRJ_ID, :type => 'inline',
Chris@909:             :rev  => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7'
Chris@909:         assert_response :success
Chris@909:         assert @response.body.include?("... This diff was truncated")
Chris@909: 
Chris@909:         Setting.default_language = 'fr'
Chris@909:         get :diff, :id   => PRJ_ID, :type => 'inline',
Chris@909:             :rev  => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7'
Chris@909:         assert_response :success
Chris@909:         assert ! @response.body.include?("... This diff was truncated")
Chris@909:         assert @response.body.include?("... Ce diff")
Chris@909:       end
Chris@909:     end
Chris@909: 
Chris@909:     def test_diff_two_revs
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909:       ['inline', 'sbs'].each do |dt|
Chris@909:         get :diff,
Chris@909:             :id     => PRJ_ID,
Chris@909:             :rev    => '61b685fbe55ab05b5ac68402d5720c1a6ac973d1',
Chris@909:             :rev_to => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7',
Chris@909:             :type   => dt
Chris@909:         assert_response :success
Chris@909:         assert_template 'diff'
Chris@909:         diff = assigns(:diff)
Chris@909:         assert_not_nil diff
Chris@909:         assert_tag :tag => 'h2', :content => /2f9c0091:61b685fb/
Chris@909:       end
Chris@909:     end
Chris@909: 
Chris@909:     def test_diff_latin_1
Chris@909:       if @ruby19_non_utf8_pass
Chris@909:         puts_ruby19_non_utf8_pass()
Chris@909:       else
Chris@909:         with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
Chris@909:           ['57ca437c', '57ca437c0acbbcb749821fdf3726a1367056d364'].each do |r1|
Chris@909:             ['inline', 'sbs'].each do |dt|
Chris@909:               get :diff, :id => PRJ_ID, :rev => r1, :type => dt
Chris@909:               assert_response :success
Chris@909:               assert_template 'diff'
Chris@909:               assert_tag :tag => 'thead',
Chris@909:                          :descendant => {
Chris@909:                            :tag => 'th',
Chris@909:                            :attributes => { :class => 'filename' } ,
Chris@909:                            :content => /latin-1-dir\/test-#{@char_1}.txt/ ,
Chris@909:                           },
Chris@909:                          :sibling => {
Chris@909:                            :tag => 'tbody',
Chris@909:                            :descendant => {
Chris@909:                               :tag => 'td',
Chris@909:                               :attributes => { :class => /diff_in/ },
Chris@909:                               :content => /test-#{@char_1}.txt/
Chris@909:                            }
Chris@909:                          }
Chris@909:             end
Chris@909:           end
Chris@909:         end
Chris@909:       end
Chris@909:     end
Chris@909: 
Chris@909:     def test_save_diff_type
Chris@909:       @request.session[:user_id] = 1 # admin
Chris@909:       user = User.find(1)
Chris@909:       get :diff,
Chris@909:           :id   => PRJ_ID,
Chris@909:           :rev  => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7'
Chris@909:       assert_response :success
Chris@909:       assert_template 'diff'
Chris@909:       user.reload
Chris@909:       assert_equal "inline", user.pref[:diff_type]
Chris@909:       get :diff,
Chris@909:           :id   => PRJ_ID,
Chris@909:           :rev  => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7',
Chris@909:           :type => 'sbs'
Chris@909:       assert_response :success
Chris@909:       assert_template 'diff'
Chris@909:       user.reload
Chris@909:       assert_equal "sbs", user.pref[:diff_type]
Chris@909:     end
Chris@909: 
Chris@909:     def test_annotate
Chris@909:       get :annotate, :id => PRJ_ID, :path => ['sources', 'watchers_controller.rb']
Chris@909:       assert_response :success
Chris@909:       assert_template 'annotate'
Chris@909:       # Line 24, changeset 2f9c0091
Chris@909:       assert_tag :tag => 'th', :content => '24',
Chris@909:                  :sibling => {
Chris@909:                     :tag => 'td',
Chris@909:                     :child => {
Chris@909:                        :tag => 'a',
Chris@909:                        :content => /2f9c0091/
Chris@909:                        }
Chris@909:                     }
Chris@909:       assert_tag :tag => 'th', :content => '24',
Chris@909:                  :sibling => { :tag => 'td', :content => /jsmith/ }
Chris@909:       assert_tag :tag => 'th', :content => '24',
Chris@909:                  :sibling => {
Chris@909:                     :tag => 'td',
Chris@909:                     :child => {
Chris@909:                        :tag => 'a',
Chris@909:                        :content => /2f9c0091/
Chris@909:                        }
Chris@909:                     }
Chris@909:       assert_tag :tag => 'th', :content => '24',
Chris@909:                  :sibling => { :tag => 'td', :content => /watcher =/ }
Chris@909:     end
Chris@909: 
Chris@909:     def test_annotate_at_given_revision
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909:       get :annotate, :id => PRJ_ID, :rev => 'deff7',
Chris@909:           :path => ['sources', 'watchers_controller.rb']
Chris@909:       assert_response :success
Chris@909:       assert_template 'annotate'
Chris@909:       assert_tag :tag => 'h2', :content => /@ deff712f/
Chris@909:     end
Chris@909: 
Chris@909:     def test_annotate_binary_file
Chris@909:       get :annotate, :id => PRJ_ID, :path => ['images', 'edit.png']
Chris@909:       assert_response 500
Chris@909:       assert_tag :tag => 'p', :attributes => { :id => /errorExplanation/ },
Chris@909:                               :content => /cannot be annotated/
Chris@909:     end
Chris@909: 
Chris@909:     def test_annotate_error_when_too_big
Chris@909:       with_settings :file_max_size_displayed => 1 do
Chris@909:         get :annotate, :id => PRJ_ID, :path => ['sources', 'watchers_controller.rb'], :rev => 'deff712f'
Chris@909:         assert_response 500
Chris@909:         assert_tag :tag => 'p', :attributes => { :id => /errorExplanation/ },
Chris@909:                                 :content => /exceeds the maximum text file size/
Chris@909: 
Chris@909:         get :annotate, :id => PRJ_ID, :path => ['README'], :rev => '7234cb2'
Chris@909:         assert_response :success
Chris@909:         assert_template 'annotate'
Chris@909:       end
Chris@909:     end
Chris@909: 
Chris@909:     def test_annotate_latin_1
Chris@909:       if @ruby19_non_utf8_pass
Chris@909:         puts_ruby19_non_utf8_pass()
Chris@909:       elsif JRUBY_SKIP
Chris@909:         puts JRUBY_SKIP_STR
Chris@909:       else
Chris@909:         with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
Chris@909:           ['57ca437c', '57ca437c0acbbcb749821fdf3726a1367056d364'].each do |r1|
Chris@909:             get :annotate, :id => PRJ_ID,
Chris@909:                 :path => ['latin-1-dir', "test-#{@char_1}.txt"], :rev => r1
Chris@909:             assert_tag :tag => 'th',
Chris@909:                        :content => '1',
Chris@909:                        :attributes => { :class => 'line-num' },
Chris@909:                        :sibling => { :tag => 'td',
Chris@909:                                      :content => /test-#{@char_1}.txt/ }
Chris@909:           end
Chris@909:         end
Chris@909:       end
Chris@909:     end
Chris@909: 
Chris@909:     def test_revision
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909:       ['61b685fbe55ab05b5ac68402d5720c1a6ac973d1', '61b685f'].each do |r|
Chris@909:         get :revision, :id => PRJ_ID, :rev => r
Chris@909:         assert_response :success
Chris@909:         assert_template 'revision'
Chris@909:       end
Chris@909:     end
Chris@909: 
Chris@909:     def test_empty_revision
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909:       ['', ' ', nil].each do |r|
Chris@909:         get :revision, :id => PRJ_ID, :rev => r
Chris@909:         assert_response 404
Chris@909:         assert_error_tag :content => /was not found/
Chris@909:       end
Chris@909:     end
Chris@909: 
Chris@909:     def test_destroy_valid_repository
Chris@909:       @request.session[:user_id] = 1 # admin
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909: 
Chris@909:       get :destroy, :id => PRJ_ID
Chris@909:       assert_response 302
Chris@909:       @project.reload
Chris@909:       assert_nil @project.repository
Chris@909:     end
Chris@909: 
Chris@909:     def test_destroy_invalid_repository
Chris@909:       @request.session[:user_id] = 1 # admin
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909:       @repository.fetch_changesets
Chris@909:       @project.reload
Chris@909:       assert_equal NUM_REV, @repository.changesets.count
Chris@909: 
Chris@909:       get :destroy, :id => PRJ_ID
Chris@909:       assert_response 302
Chris@909:       @project.reload
Chris@909:       assert_nil @project.repository
Chris@909: 
Chris@909:       @repository = Repository::Git.create(
Chris@909:                       :project       => @project,
Chris@909:                       :url           => "/invalid",
Chris@909:                       :path_encoding => 'ISO-8859-1'
Chris@909:                       )
Chris@909:       assert @repository
Chris@909:       @repository.fetch_changesets
Chris@909:       @repository.reload
Chris@909:       assert_equal 0, @repository.changesets.count
Chris@909: 
Chris@909:       get :destroy, :id => PRJ_ID
Chris@909:       assert_response 302
Chris@909:       @project.reload
Chris@909:       assert_nil @project.repository
Chris@909:     end
Chris@909: 
Chris@909:     private
Chris@909: 
Chris@909:     def puts_ruby19_non_utf8_pass
Chris@909:       puts "TODO: This test fails in Ruby 1.9 " +
Chris@909:            "and Encoding.default_external is not UTF-8. " +
Chris@909:            "Current value is '#{Encoding.default_external.to_s}'"
Chris@909:     end
Chris@909:   else
Chris@909:     puts "Git test repository NOT FOUND. Skipping functional tests !!!"
Chris@909:     def test_fake; assert true end
Chris@909:   end
Chris@909: 
Chris@909:   private
Chris@909:   def with_cache(&block)
Chris@909:     before = ActionController::Base.perform_caching
Chris@909:     ActionController::Base.perform_caching = true
Chris@909:     block.call
Chris@909:     ActionController::Base.perform_caching = before
Chris@909:   end
Chris@909: end