Chris@0: # Redmine - project management software Chris@0: # Copyright (C) 2006-2008 Jean-Philippe Lang Chris@0: # Chris@0: # This program is free software; you can redistribute it and/or Chris@0: # modify it under the terms of the GNU General Public License Chris@0: # as published by the Free Software Foundation; either version 2 Chris@0: # of the License, or (at your option) any later version. Chris@0: # Chris@0: # This program is distributed in the hope that it will be useful, Chris@0: # but WITHOUT ANY WARRANTY; without even the implied warranty of Chris@0: # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the Chris@0: # GNU General Public License for more details. Chris@0: # Chris@0: # You should have received a copy of the GNU General Public License Chris@0: # along with this program; if not, write to the Free Software Chris@0: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. Chris@0: Chris@0: require File.dirname(__FILE__) + '/../test_helper' Chris@0: require 'issues_controller' Chris@0: Chris@0: # Re-raise errors caught by the controller. Chris@0: class IssuesController; def rescue_action(e) raise e end; end Chris@0: Chris@0: class IssuesControllerTest < ActionController::TestCase Chris@0: fixtures :projects, Chris@0: :users, Chris@0: :roles, Chris@0: :members, Chris@0: :member_roles, Chris@0: :issues, Chris@0: :issue_statuses, Chris@0: :versions, Chris@0: :trackers, Chris@0: :projects_trackers, Chris@0: :issue_categories, Chris@0: :enabled_modules, Chris@0: :enumerations, Chris@0: :attachments, Chris@0: :workflows, Chris@0: :custom_fields, Chris@0: :custom_values, Chris@0: :custom_fields_projects, Chris@0: :custom_fields_trackers, Chris@0: :time_entries, Chris@0: :journals, Chris@0: :journal_details, Chris@0: :queries Chris@0: Chris@0: def setup Chris@0: @controller = IssuesController.new Chris@0: @request = ActionController::TestRequest.new Chris@0: @response = ActionController::TestResponse.new Chris@0: User.current = nil Chris@0: end Chris@0: Chris@0: def test_index Chris@0: Setting.default_language = 'en' Chris@0: Chris@0: get :index Chris@0: assert_response :success Chris@0: assert_template 'index.rhtml' Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_nil assigns(:project) Chris@0: assert_tag :tag => 'a', :content => /Can't print recipes/ Chris@0: assert_tag :tag => 'a', :content => /Subproject issue/ Chris@0: # private projects hidden Chris@0: assert_no_tag :tag => 'a', :content => /Issue of a private subproject/ Chris@0: assert_no_tag :tag => 'a', :content => /Issue on project 2/ Chris@0: # project column Chris@0: assert_tag :tag => 'th', :content => /Project/ Chris@0: end Chris@0: Chris@0: def test_index_should_not_list_issues_when_module_disabled Chris@0: EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1") Chris@0: get :index Chris@0: assert_response :success Chris@0: assert_template 'index.rhtml' Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_nil assigns(:project) Chris@0: assert_no_tag :tag => 'a', :content => /Can't print recipes/ Chris@0: assert_tag :tag => 'a', :content => /Subproject issue/ Chris@0: end Chris@0: Chris@0: def test_index_should_not_list_issues_when_module_disabled Chris@0: EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1") Chris@0: get :index Chris@0: assert_response :success Chris@0: assert_template 'index.rhtml' Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_nil assigns(:project) Chris@0: assert_no_tag :tag => 'a', :content => /Can't print recipes/ Chris@0: assert_tag :tag => 'a', :content => /Subproject issue/ Chris@0: end Chris@0: Chris@0: def test_index_with_project Chris@0: Setting.display_subprojects_issues = 0 Chris@0: get :index, :project_id => 1 Chris@0: assert_response :success Chris@0: assert_template 'index.rhtml' Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_tag :tag => 'a', :content => /Can't print recipes/ Chris@0: assert_no_tag :tag => 'a', :content => /Subproject issue/ Chris@0: end Chris@0: Chris@0: def test_index_with_project_and_subprojects Chris@0: Setting.display_subprojects_issues = 1 Chris@0: get :index, :project_id => 1 Chris@0: assert_response :success Chris@0: assert_template 'index.rhtml' Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_tag :tag => 'a', :content => /Can't print recipes/ Chris@0: assert_tag :tag => 'a', :content => /Subproject issue/ Chris@0: assert_no_tag :tag => 'a', :content => /Issue of a private subproject/ Chris@0: end Chris@0: Chris@0: def test_index_with_project_and_subprojects_should_show_private_subprojects Chris@0: @request.session[:user_id] = 2 Chris@0: Setting.display_subprojects_issues = 1 Chris@0: get :index, :project_id => 1 Chris@0: assert_response :success Chris@0: assert_template 'index.rhtml' Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_tag :tag => 'a', :content => /Can't print recipes/ Chris@0: assert_tag :tag => 'a', :content => /Subproject issue/ Chris@0: assert_tag :tag => 'a', :content => /Issue of a private subproject/ Chris@0: end Chris@0: Chris@0: def test_index_with_project_and_filter Chris@0: get :index, :project_id => 1, :set_filter => 1 Chris@0: assert_response :success Chris@0: assert_template 'index.rhtml' Chris@0: assert_not_nil assigns(:issues) Chris@0: end Chris@0: Chris@0: def test_index_with_query Chris@0: get :index, :project_id => 1, :query_id => 5 Chris@0: assert_response :success Chris@0: assert_template 'index.rhtml' Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_nil assigns(:issue_count_by_group) Chris@0: end Chris@0: Chris@0: def test_index_with_query_grouped_by_tracker Chris@0: get :index, :project_id => 1, :query_id => 6 Chris@0: assert_response :success Chris@0: assert_template 'index.rhtml' Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_not_nil assigns(:issue_count_by_group) Chris@0: end Chris@0: Chris@0: def test_index_with_query_grouped_by_list_custom_field Chris@0: get :index, :project_id => 1, :query_id => 9 Chris@0: assert_response :success Chris@0: assert_template 'index.rhtml' Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_not_nil assigns(:issue_count_by_group) Chris@0: end Chris@0: Chris@0: def test_index_sort_by_field_not_included_in_columns Chris@0: Setting.issue_list_default_columns = %w(subject author) Chris@0: get :index, :sort => 'tracker' Chris@0: end Chris@0: Chris@0: def test_index_csv_with_project Chris@0: Setting.default_language = 'en' Chris@0: Chris@0: get :index, :format => 'csv' Chris@0: assert_response :success Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_equal 'text/csv', @response.content_type Chris@0: assert @response.body.starts_with?("#,") Chris@0: Chris@0: get :index, :project_id => 1, :format => 'csv' Chris@0: assert_response :success Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_equal 'text/csv', @response.content_type Chris@0: end Chris@0: Chris@0: def test_index_pdf Chris@0: get :index, :format => 'pdf' Chris@0: assert_response :success Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_equal 'application/pdf', @response.content_type Chris@0: Chris@0: get :index, :project_id => 1, :format => 'pdf' Chris@0: assert_response :success Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_equal 'application/pdf', @response.content_type Chris@0: Chris@0: get :index, :project_id => 1, :query_id => 6, :format => 'pdf' Chris@0: assert_response :success Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_equal 'application/pdf', @response.content_type Chris@0: end Chris@0: Chris@0: def test_index_pdf_with_query_grouped_by_list_custom_field Chris@0: get :index, :project_id => 1, :query_id => 9, :format => 'pdf' Chris@0: assert_response :success Chris@0: assert_not_nil assigns(:issues) Chris@0: assert_not_nil assigns(:issue_count_by_group) Chris@0: assert_equal 'application/pdf', @response.content_type Chris@0: end Chris@0: Chris@0: def test_index_sort Chris@0: get :index, :sort => 'tracker,id:desc' Chris@0: assert_response :success Chris@0: Chris@0: sort_params = @request.session['issues_index_sort'] Chris@0: assert sort_params.is_a?(String) Chris@0: assert_equal 'tracker,id:desc', sort_params Chris@0: Chris@0: issues = assigns(:issues) Chris@0: assert_not_nil issues Chris@0: assert !issues.empty? Chris@0: assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id) Chris@0: end Chris@0: Chris@0: def test_index_with_columns Chris@0: columns = ['tracker', 'subject', 'assigned_to'] Chris@0: get :index, :set_filter => 1, :query => { 'column_names' => columns} Chris@0: assert_response :success Chris@0: Chris@0: # query should use specified columns Chris@0: query = assigns(:query) Chris@0: assert_kind_of Query, query Chris@0: assert_equal columns, query.column_names.map(&:to_s) Chris@0: Chris@0: # columns should be stored in session Chris@0: assert_kind_of Hash, session[:query] Chris@0: assert_kind_of Array, session[:query][:column_names] Chris@0: assert_equal columns, session[:query][:column_names].map(&:to_s) Chris@0: end Chris@0: Chris@0: def test_show_by_anonymous Chris@0: get :show, :id => 1 Chris@0: assert_response :success Chris@0: assert_template 'show.rhtml' Chris@0: assert_not_nil assigns(:issue) Chris@0: assert_equal Issue.find(1), assigns(:issue) Chris@0: Chris@0: # anonymous role is allowed to add a note Chris@0: assert_tag :tag => 'form', Chris@0: :descendant => { :tag => 'fieldset', Chris@0: :child => { :tag => 'legend', Chris@0: :content => /Notes/ } } Chris@0: end Chris@0: Chris@0: def test_show_by_manager Chris@0: @request.session[:user_id] = 2 Chris@0: get :show, :id => 1 Chris@0: assert_response :success Chris@0: Chris@0: assert_tag :tag => 'form', Chris@0: :descendant => { :tag => 'fieldset', Chris@0: :child => { :tag => 'legend', Chris@0: :content => /Change properties/ } }, Chris@0: :descendant => { :tag => 'fieldset', Chris@0: :child => { :tag => 'legend', Chris@0: :content => /Log time/ } }, Chris@0: :descendant => { :tag => 'fieldset', Chris@0: :child => { :tag => 'legend', Chris@0: :content => /Notes/ } } Chris@0: end Chris@0: Chris@0: def test_show_should_deny_anonymous_access_without_permission Chris@0: Role.anonymous.remove_permission!(:view_issues) Chris@0: get :show, :id => 1 Chris@0: assert_response :redirect Chris@0: end Chris@0: Chris@0: def test_show_should_deny_non_member_access_without_permission Chris@0: Role.non_member.remove_permission!(:view_issues) Chris@0: @request.session[:user_id] = 9 Chris@0: get :show, :id => 1 Chris@0: assert_response 403 Chris@0: end Chris@0: Chris@0: def test_show_should_deny_member_access_without_permission Chris@0: Role.find(1).remove_permission!(:view_issues) Chris@0: @request.session[:user_id] = 2 Chris@0: get :show, :id => 1 Chris@0: assert_response 403 Chris@0: end Chris@0: Chris@0: def test_show_should_not_disclose_relations_to_invisible_issues Chris@0: Setting.cross_project_issue_relations = '1' Chris@0: IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates') Chris@0: # Relation to a private project issue Chris@0: IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates') Chris@0: Chris@0: get :show, :id => 1 Chris@0: assert_response :success Chris@0: Chris@0: assert_tag :div, :attributes => { :id => 'relations' }, Chris@0: :descendant => { :tag => 'a', :content => /#2$/ } Chris@0: assert_no_tag :div, :attributes => { :id => 'relations' }, Chris@0: :descendant => { :tag => 'a', :content => /#4$/ } Chris@0: end Chris@0: Chris@0: def test_show_atom Chris@0: get :show, :id => 2, :format => 'atom' Chris@0: assert_response :success Chris@14: assert_template 'journals/index.rxml' Chris@0: # Inline image Chris@0: assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10')) Chris@0: end Chris@0: Chris@0: def test_show_export_to_pdf Chris@0: get :show, :id => 3, :format => 'pdf' Chris@0: assert_response :success Chris@0: assert_equal 'application/pdf', @response.content_type Chris@0: assert @response.body.starts_with?('%PDF') Chris@0: assert_not_nil assigns(:issue) Chris@0: end Chris@0: Chris@0: def test_get_new Chris@0: @request.session[:user_id] = 2 Chris@0: get :new, :project_id => 1, :tracker_id => 1 Chris@0: assert_response :success Chris@0: assert_template 'new' Chris@0: Chris@0: assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]', Chris@0: :value => 'Default string' } Chris@0: end Chris@0: Chris@0: def test_get_new_without_tracker_id Chris@0: @request.session[:user_id] = 2 Chris@0: get :new, :project_id => 1 Chris@0: assert_response :success Chris@0: assert_template 'new' Chris@0: Chris@0: issue = assigns(:issue) Chris@0: assert_not_nil issue Chris@0: assert_equal Project.find(1).trackers.first, issue.tracker Chris@0: end Chris@0: Chris@0: def test_get_new_with_no_default_status_should_display_an_error Chris@0: @request.session[:user_id] = 2 Chris@0: IssueStatus.delete_all Chris@0: Chris@0: get :new, :project_id => 1 Chris@0: assert_response 500 Chris@0: assert_not_nil flash[:error] Chris@0: assert_tag :tag => 'div', :attributes => { :class => /error/ }, Chris@0: :content => /No default issue/ Chris@0: end Chris@0: Chris@0: def test_get_new_with_no_tracker_should_display_an_error Chris@0: @request.session[:user_id] = 2 Chris@0: Tracker.delete_all Chris@0: Chris@0: get :new, :project_id => 1 Chris@0: assert_response 500 Chris@0: assert_not_nil flash[:error] Chris@0: assert_tag :tag => 'div', :attributes => { :class => /error/ }, Chris@0: :content => /No tracker/ Chris@0: end Chris@0: Chris@0: def test_update_new_form Chris@0: @request.session[:user_id] = 2 Chris@14: xhr :post, :new, :project_id => 1, Chris@0: :issue => {:tracker_id => 2, Chris@0: :subject => 'This is the test_new issue', Chris@0: :description => 'This is the description', Chris@0: :priority_id => 5} Chris@0: assert_response :success Chris@0: assert_template 'attributes' Chris@0: Chris@0: issue = assigns(:issue) Chris@0: assert_kind_of Issue, issue Chris@0: assert_equal 1, issue.project_id Chris@0: assert_equal 2, issue.tracker_id Chris@0: assert_equal 'This is the test_new issue', issue.subject Chris@0: end Chris@0: Chris@0: def test_post_create Chris@0: @request.session[:user_id] = 2 Chris@0: assert_difference 'Issue.count' do Chris@0: post :create, :project_id => 1, Chris@0: :issue => {:tracker_id => 3, Chris@0: :status_id => 2, Chris@0: :subject => 'This is the test_new issue', Chris@0: :description => 'This is the description', Chris@0: :priority_id => 5, Chris@0: :estimated_hours => '', Chris@0: :custom_field_values => {'2' => 'Value for field 2'}} Chris@0: end Chris@0: assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id Chris@0: Chris@0: issue = Issue.find_by_subject('This is the test_new issue') Chris@0: assert_not_nil issue Chris@0: assert_equal 2, issue.author_id Chris@0: assert_equal 3, issue.tracker_id Chris@0: assert_equal 2, issue.status_id Chris@0: assert_nil issue.estimated_hours Chris@0: v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2}) Chris@0: assert_not_nil v Chris@0: assert_equal 'Value for field 2', v.value Chris@0: end Chris@0: Chris@0: def test_post_create_and_continue Chris@0: @request.session[:user_id] = 2 Chris@0: post :create, :project_id => 1, Chris@0: :issue => {:tracker_id => 3, Chris@0: :subject => 'This is first issue', Chris@0: :priority_id => 5}, Chris@0: :continue => '' chris@22: assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', chris@22: :issue => {:tracker_id => 3} Chris@0: end Chris@0: Chris@0: def test_post_create_without_custom_fields_param Chris@0: @request.session[:user_id] = 2 Chris@0: assert_difference 'Issue.count' do Chris@0: post :create, :project_id => 1, Chris@0: :issue => {:tracker_id => 1, Chris@0: :subject => 'This is the test_new issue', Chris@0: :description => 'This is the description', Chris@0: :priority_id => 5} Chris@0: end Chris@0: assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id Chris@0: end Chris@0: Chris@0: def test_post_create_with_required_custom_field_and_without_custom_fields_param Chris@0: field = IssueCustomField.find_by_name('Database') Chris@0: field.update_attribute(:is_required, true) Chris@0: Chris@0: @request.session[:user_id] = 2 Chris@0: post :create, :project_id => 1, Chris@0: :issue => {:tracker_id => 1, Chris@0: :subject => 'This is the test_new issue', Chris@0: :description => 'This is the description', Chris@0: :priority_id => 5} Chris@0: assert_response :success Chris@0: assert_template 'new' Chris@0: issue = assigns(:issue) Chris@0: assert_not_nil issue Chris@0: assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values) Chris@0: end Chris@0: Chris@0: def test_post_create_with_watchers Chris@0: @request.session[:user_id] = 2 Chris@0: ActionMailer::Base.deliveries.clear Chris@0: Chris@0: assert_difference 'Watcher.count', 2 do Chris@0: post :create, :project_id => 1, Chris@0: :issue => {:tracker_id => 1, Chris@0: :subject => 'This is a new issue with watchers', Chris@0: :description => 'This is the description', Chris@0: :priority_id => 5, Chris@0: :watcher_user_ids => ['2', '3']} Chris@0: end Chris@0: issue = Issue.find_by_subject('This is a new issue with watchers') Chris@0: assert_not_nil issue Chris@0: assert_redirected_to :controller => 'issues', :action => 'show', :id => issue Chris@0: Chris@0: # Watchers added Chris@0: assert_equal [2, 3], issue.watcher_user_ids.sort Chris@0: assert issue.watched_by?(User.find(3)) Chris@0: # Watchers notified Chris@0: mail = ActionMailer::Base.deliveries.last Chris@0: assert_kind_of TMail::Mail, mail Chris@0: assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail) Chris@0: end Chris@0: Chris@0: def test_post_create_subissue Chris@0: @request.session[:user_id] = 2 Chris@0: Chris@0: assert_difference 'Issue.count' do Chris@0: post :create, :project_id => 1, Chris@0: :issue => {:tracker_id => 1, Chris@0: :subject => 'This is a child issue', Chris@0: :parent_issue_id => 2} Chris@0: end Chris@0: issue = Issue.find_by_subject('This is a child issue') Chris@0: assert_not_nil issue Chris@0: assert_equal Issue.find(2), issue.parent Chris@0: end Chris@0: Chris@0: def test_post_create_should_send_a_notification Chris@0: ActionMailer::Base.deliveries.clear Chris@0: @request.session[:user_id] = 2 Chris@0: assert_difference 'Issue.count' do Chris@0: post :create, :project_id => 1, Chris@0: :issue => {:tracker_id => 3, Chris@0: :subject => 'This is the test_new issue', Chris@0: :description => 'This is the description', Chris@0: :priority_id => 5, Chris@0: :estimated_hours => '', Chris@0: :custom_field_values => {'2' => 'Value for field 2'}} Chris@0: end Chris@0: assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id Chris@0: Chris@0: assert_equal 1, ActionMailer::Base.deliveries.size Chris@0: end Chris@0: Chris@0: def test_post_create_should_preserve_fields_values_on_validation_failure Chris@0: @request.session[:user_id] = 2 Chris@0: post :create, :project_id => 1, Chris@0: :issue => {:tracker_id => 1, Chris@0: # empty subject Chris@0: :subject => '', Chris@0: :description => 'This is a description', Chris@0: :priority_id => 6, Chris@0: :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}} Chris@0: assert_response :success Chris@0: assert_template 'new' Chris@0: Chris@0: assert_tag :textarea, :attributes => { :name => 'issue[description]' }, Chris@0: :content => 'This is a description' Chris@0: assert_tag :select, :attributes => { :name => 'issue[priority_id]' }, Chris@0: :child => { :tag => 'option', :attributes => { :selected => 'selected', Chris@0: :value => '6' }, Chris@0: :content => 'High' } Chris@0: # Custom fields Chris@0: assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' }, Chris@0: :child => { :tag => 'option', :attributes => { :selected => 'selected', Chris@0: :value => 'Oracle' }, Chris@0: :content => 'Oracle' } Chris@0: assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]', Chris@0: :value => 'Value for field 2'} Chris@0: end Chris@0: Chris@0: def test_post_create_should_ignore_non_safe_attributes Chris@0: @request.session[:user_id] = 2 Chris@0: assert_nothing_raised do Chris@0: post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" } Chris@0: end Chris@0: end Chris@0: Chris@0: context "without workflow privilege" do Chris@0: setup do Chris@0: Workflow.delete_all(["role_id = ?", Role.anonymous.id]) Chris@0: Role.anonymous.add_permission! :add_issues Chris@0: end Chris@0: Chris@0: context "#new" do Chris@0: should "propose default status only" do Chris@0: get :new, :project_id => 1 Chris@0: assert_response :success Chris@0: assert_template 'new' Chris@0: assert_tag :tag => 'select', Chris@0: :attributes => {:name => 'issue[status_id]'}, Chris@0: :children => {:count => 1}, Chris@0: :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}} Chris@0: end Chris@0: Chris@0: should "accept default status" do Chris@0: assert_difference 'Issue.count' do Chris@0: post :create, :project_id => 1, Chris@0: :issue => {:tracker_id => 1, Chris@0: :subject => 'This is an issue', Chris@0: :status_id => 1} Chris@0: end Chris@0: issue = Issue.last(:order => 'id') Chris@0: assert_equal IssueStatus.default, issue.status Chris@0: end Chris@0: Chris@0: should "ignore unauthorized status" do Chris@0: assert_difference 'Issue.count' do Chris@0: post :create, :project_id => 1, Chris@0: :issue => {:tracker_id => 1, Chris@0: :subject => 'This is an issue', Chris@0: :status_id => 3} Chris@0: end Chris@0: issue = Issue.last(:order => 'id') Chris@0: assert_equal IssueStatus.default, issue.status Chris@0: end Chris@0: end Chris@0: end Chris@0: Chris@0: def test_copy_issue Chris@0: @request.session[:user_id] = 2 Chris@0: get :new, :project_id => 1, :copy_from => 1 Chris@0: assert_template 'new' Chris@0: assert_not_nil assigns(:issue) Chris@0: orig = Issue.find(1) Chris@0: assert_equal orig.subject, assigns(:issue).subject Chris@0: end Chris@0: Chris@0: def test_get_edit Chris@0: @request.session[:user_id] = 2 Chris@0: get :edit, :id => 1 Chris@0: assert_response :success Chris@0: assert_template 'edit' Chris@0: assert_not_nil assigns(:issue) Chris@0: assert_equal Issue.find(1), assigns(:issue) Chris@0: end Chris@0: Chris@0: def test_get_edit_with_params Chris@0: @request.session[:user_id] = 2 Chris@0: get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 } Chris@0: assert_response :success Chris@0: assert_template 'edit' Chris@0: Chris@0: issue = assigns(:issue) Chris@0: assert_not_nil issue Chris@0: Chris@0: assert_equal 5, issue.status_id Chris@0: assert_tag :select, :attributes => { :name => 'issue[status_id]' }, Chris@0: :child => { :tag => 'option', Chris@0: :content => 'Closed', Chris@0: :attributes => { :selected => 'selected' } } Chris@0: Chris@0: assert_equal 7, issue.priority_id Chris@0: assert_tag :select, :attributes => { :name => 'issue[priority_id]' }, Chris@0: :child => { :tag => 'option', Chris@0: :content => 'Urgent', Chris@0: :attributes => { :selected => 'selected' } } Chris@0: end Chris@0: Chris@0: def test_update_edit_form Chris@0: @request.session[:user_id] = 2 Chris@14: xhr :post, :new, :project_id => 1, Chris@0: :id => 1, Chris@0: :issue => {:tracker_id => 2, Chris@0: :subject => 'This is the test_new issue', Chris@0: :description => 'This is the description', Chris@0: :priority_id => 5} Chris@0: assert_response :success Chris@0: assert_template 'attributes' Chris@0: Chris@0: issue = assigns(:issue) Chris@0: assert_kind_of Issue, issue Chris@0: assert_equal 1, issue.id Chris@0: assert_equal 1, issue.project_id Chris@0: assert_equal 2, issue.tracker_id Chris@0: assert_equal 'This is the test_new issue', issue.subject Chris@0: end Chris@0: Chris@0: def test_update_using_invalid_http_verbs Chris@0: @request.session[:user_id] = 2 Chris@0: subject = 'Updated by an invalid http verb' Chris@0: Chris@0: get :update, :id => 1, :issue => {:subject => subject} Chris@0: assert_not_equal subject, Issue.find(1).subject Chris@0: Chris@0: post :update, :id => 1, :issue => {:subject => subject} Chris@0: assert_not_equal subject, Issue.find(1).subject Chris@0: Chris@0: delete :update, :id => 1, :issue => {:subject => subject} Chris@0: assert_not_equal subject, Issue.find(1).subject Chris@0: end Chris@0: Chris@0: def test_put_update_without_custom_fields_param Chris@0: @request.session[:user_id] = 2 Chris@0: ActionMailer::Base.deliveries.clear Chris@0: Chris@0: issue = Issue.find(1) Chris@0: assert_equal '125', issue.custom_value_for(2).value Chris@0: old_subject = issue.subject Chris@0: new_subject = 'Subject modified by IssuesControllerTest#test_post_edit' Chris@0: Chris@0: assert_difference('Journal.count') do Chris@0: assert_difference('JournalDetail.count', 2) do Chris@0: put :update, :id => 1, :issue => {:subject => new_subject, Chris@0: :priority_id => '6', Chris@0: :category_id => '1' # no change Chris@0: } Chris@0: end Chris@0: end Chris@0: assert_redirected_to :action => 'show', :id => '1' Chris@0: issue.reload Chris@0: assert_equal new_subject, issue.subject Chris@0: # Make sure custom fields were not cleared Chris@0: assert_equal '125', issue.custom_value_for(2).value Chris@0: Chris@0: mail = ActionMailer::Base.deliveries.last Chris@0: assert_kind_of TMail::Mail, mail Chris@0: assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]") Chris@0: assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}") Chris@0: end Chris@0: Chris@0: def test_put_update_with_custom_field_change Chris@0: @request.session[:user_id] = 2 Chris@0: issue = Issue.find(1) Chris@0: assert_equal '125', issue.custom_value_for(2).value Chris@0: Chris@0: assert_difference('Journal.count') do Chris@0: assert_difference('JournalDetail.count', 3) do Chris@0: put :update, :id => 1, :issue => {:subject => 'Custom field change', Chris@0: :priority_id => '6', Chris@0: :category_id => '1', # no change Chris@0: :custom_field_values => { '2' => 'New custom value' } Chris@0: } Chris@0: end Chris@0: end Chris@0: assert_redirected_to :action => 'show', :id => '1' Chris@0: issue.reload Chris@0: assert_equal 'New custom value', issue.custom_value_for(2).value Chris@0: Chris@0: mail = ActionMailer::Base.deliveries.last Chris@0: assert_kind_of TMail::Mail, mail Chris@0: assert mail.body.include?("Searchable field changed from 125 to New custom value") Chris@0: end Chris@0: Chris@0: def test_put_update_with_status_and_assignee_change Chris@0: issue = Issue.find(1) Chris@0: assert_equal 1, issue.status_id Chris@0: @request.session[:user_id] = 2 Chris@0: assert_difference('TimeEntry.count', 0) do Chris@0: put :update, Chris@0: :id => 1, Chris@0: :issue => { :status_id => 2, :assigned_to_id => 3 }, Chris@0: :notes => 'Assigned to dlopper', Chris@0: :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first } Chris@0: end Chris@0: assert_redirected_to :action => 'show', :id => '1' Chris@0: issue.reload Chris@0: assert_equal 2, issue.status_id Chris@0: j = Journal.find(:first, :order => 'id DESC') Chris@0: assert_equal 'Assigned to dlopper', j.notes Chris@0: assert_equal 2, j.details.size Chris@0: Chris@0: mail = ActionMailer::Base.deliveries.last Chris@0: assert mail.body.include?("Status changed from New to Assigned") Chris@0: # subject should contain the new status Chris@0: assert mail.subject.include?("(#{ IssueStatus.find(2).name })") Chris@0: end Chris@0: Chris@0: def test_put_update_with_note_only Chris@0: notes = 'Note added by IssuesControllerTest#test_update_with_note_only' Chris@0: # anonymous user Chris@0: put :update, Chris@0: :id => 1, Chris@0: :notes => notes Chris@0: assert_redirected_to :action => 'show', :id => '1' Chris@0: j = Journal.find(:first, :order => 'id DESC') Chris@0: assert_equal notes, j.notes Chris@0: assert_equal 0, j.details.size Chris@0: assert_equal User.anonymous, j.user Chris@0: Chris@0: mail = ActionMailer::Base.deliveries.last Chris@0: assert mail.body.include?(notes) Chris@0: end Chris@0: Chris@0: def test_put_update_with_note_and_spent_time Chris@0: @request.session[:user_id] = 2 Chris@0: spent_hours_before = Issue.find(1).spent_hours Chris@0: assert_difference('TimeEntry.count') do Chris@0: put :update, Chris@0: :id => 1, Chris@0: :notes => '2.5 hours added', Chris@0: :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id } Chris@0: end Chris@0: assert_redirected_to :action => 'show', :id => '1' Chris@0: Chris@0: issue = Issue.find(1) Chris@0: Chris@0: j = Journal.find(:first, :order => 'id DESC') Chris@0: assert_equal '2.5 hours added', j.notes Chris@0: assert_equal 0, j.details.size Chris@0: Chris@0: t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time') Chris@0: assert_not_nil t Chris@0: assert_equal 2.5, t.hours Chris@0: assert_equal spent_hours_before + 2.5, issue.spent_hours Chris@0: end Chris@0: Chris@0: def test_put_update_with_attachment_only Chris@0: set_tmp_attachments_directory Chris@0: Chris@0: # Delete all fixtured journals, a race condition can occur causing the wrong Chris@0: # journal to get fetched in the next find. Chris@0: Journal.delete_all Chris@0: Chris@0: # anonymous user Chris@0: put :update, Chris@0: :id => 1, Chris@0: :notes => '', Chris@0: :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}} Chris@0: assert_redirected_to :action => 'show', :id => '1' Chris@0: j = Issue.find(1).journals.find(:first, :order => 'id DESC') Chris@0: assert j.notes.blank? Chris@0: assert_equal 1, j.details.size Chris@0: assert_equal 'testfile.txt', j.details.first.value Chris@0: assert_equal User.anonymous, j.user Chris@0: Chris@0: mail = ActionMailer::Base.deliveries.last Chris@0: assert mail.body.include?('testfile.txt') Chris@0: end Chris@0: Chris@0: def test_put_update_with_attachment_that_fails_to_save Chris@0: set_tmp_attachments_directory Chris@0: Chris@0: # Delete all fixtured journals, a race condition can occur causing the wrong Chris@0: # journal to get fetched in the next find. Chris@0: Journal.delete_all Chris@0: Chris@0: # Mock out the unsaved attachment Chris@0: Attachment.any_instance.stubs(:create).returns(Attachment.new) Chris@0: Chris@0: # anonymous user Chris@0: put :update, Chris@0: :id => 1, Chris@0: :notes => '', Chris@0: :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}} Chris@0: assert_redirected_to :action => 'show', :id => '1' Chris@0: assert_equal '1 file(s) could not be saved.', flash[:warning] Chris@0: Chris@0: end if Object.const_defined?(:Mocha) Chris@0: Chris@0: def test_put_update_with_no_change Chris@0: issue = Issue.find(1) Chris@0: issue.journals.clear Chris@0: ActionMailer::Base.deliveries.clear Chris@0: Chris@0: put :update, Chris@0: :id => 1, Chris@0: :notes => '' Chris@0: assert_redirected_to :action => 'show', :id => '1' Chris@0: Chris@0: issue.reload Chris@0: assert issue.journals.empty? Chris@0: # No email should be sent Chris@0: assert ActionMailer::Base.deliveries.empty? Chris@0: end Chris@0: Chris@0: def test_put_update_should_send_a_notification Chris@0: @request.session[:user_id] = 2 Chris@0: ActionMailer::Base.deliveries.clear Chris@0: issue = Issue.find(1) Chris@0: old_subject = issue.subject Chris@0: new_subject = 'Subject modified by IssuesControllerTest#test_post_edit' Chris@0: Chris@0: put :update, :id => 1, :issue => {:subject => new_subject, Chris@0: :priority_id => '6', Chris@0: :category_id => '1' # no change Chris@0: } Chris@0: assert_equal 1, ActionMailer::Base.deliveries.size Chris@0: end Chris@0: Chris@0: def test_put_update_with_invalid_spent_time Chris@0: @request.session[:user_id] = 2 Chris@0: notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time' Chris@0: Chris@0: assert_no_difference('Journal.count') do Chris@0: put :update, Chris@0: :id => 1, Chris@0: :notes => notes, Chris@0: :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"} Chris@0: end Chris@0: assert_response :success Chris@0: assert_template 'edit' Chris@0: Chris@0: assert_tag :textarea, :attributes => { :name => 'notes' }, Chris@0: :content => notes Chris@0: assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" } Chris@0: end Chris@0: Chris@0: def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject Chris@0: issue = Issue.find(2) Chris@0: @request.session[:user_id] = 2 Chris@0: Chris@0: put :update, Chris@0: :id => issue.id, Chris@0: :issue => { Chris@0: :fixed_version_id => 4 Chris@0: } Chris@0: Chris@0: assert_response :redirect Chris@0: issue.reload Chris@0: assert_equal 4, issue.fixed_version_id Chris@0: assert_not_equal issue.project_id, issue.fixed_version.project_id Chris@0: end Chris@0: Chris@0: def test_put_update_should_redirect_back_using_the_back_url_parameter Chris@0: issue = Issue.find(2) Chris@0: @request.session[:user_id] = 2 Chris@0: Chris@0: put :update, Chris@0: :id => issue.id, Chris@0: :issue => { Chris@0: :fixed_version_id => 4 Chris@0: }, Chris@0: :back_url => '/issues' Chris@0: Chris@0: assert_response :redirect Chris@0: assert_redirected_to '/issues' Chris@0: end Chris@0: Chris@0: def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host Chris@0: issue = Issue.find(2) Chris@0: @request.session[:user_id] = 2 Chris@0: Chris@0: put :update, Chris@0: :id => issue.id, Chris@0: :issue => { Chris@0: :fixed_version_id => 4 Chris@0: }, Chris@0: :back_url => 'http://google.com' Chris@0: Chris@0: assert_response :redirect Chris@0: assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id Chris@0: end Chris@0: Chris@0: def test_get_bulk_edit Chris@0: @request.session[:user_id] = 2 Chris@0: get :bulk_edit, :ids => [1, 2] Chris@0: assert_response :success Chris@0: assert_template 'bulk_edit' Chris@0: Chris@0: # Project specific custom field, date type Chris@0: field = CustomField.find(9) Chris@0: assert !field.is_for_all? Chris@0: assert_equal 'date', field.field_format Chris@0: assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'} Chris@0: Chris@0: # System wide custom field Chris@0: assert CustomField.find(1).is_for_all? Chris@0: assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'} Chris@0: end Chris@0: Chris@14: def test_bulk_update Chris@0: @request.session[:user_id] = 2 Chris@0: # update issues priority Chris@14: post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing', Chris@0: :issue => {:priority_id => 7, Chris@0: :assigned_to_id => '', Chris@0: :custom_field_values => {'2' => ''}} Chris@0: Chris@0: assert_response 302 Chris@0: # check that the issues were updated Chris@0: assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id} Chris@0: Chris@0: issue = Issue.find(1) Chris@0: journal = issue.journals.find(:first, :order => 'created_on DESC') Chris@0: assert_equal '125', issue.custom_value_for(2).value Chris@0: assert_equal 'Bulk editing', journal.notes Chris@0: assert_equal 1, journal.details.size Chris@0: end Chris@0: Chris@14: def test_bullk_update_should_send_a_notification Chris@0: @request.session[:user_id] = 2 Chris@0: ActionMailer::Base.deliveries.clear Chris@14: post(:bulk_update, Chris@0: { Chris@0: :ids => [1, 2], Chris@0: :notes => 'Bulk editing', Chris@0: :issue => { Chris@0: :priority_id => 7, Chris@0: :assigned_to_id => '', Chris@0: :custom_field_values => {'2' => ''} Chris@0: } Chris@0: }) Chris@0: Chris@0: assert_response 302 Chris@0: assert_equal 2, ActionMailer::Base.deliveries.size Chris@0: end Chris@0: Chris@14: def test_bulk_update_status Chris@0: @request.session[:user_id] = 2 Chris@0: # update issues priority Chris@14: post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status', Chris@0: :issue => {:priority_id => '', Chris@0: :assigned_to_id => '', Chris@0: :status_id => '5'} Chris@0: Chris@0: assert_response 302 Chris@0: issue = Issue.find(1) Chris@0: assert issue.closed? Chris@0: end Chris@0: Chris@14: def test_bulk_update_custom_field Chris@0: @request.session[:user_id] = 2 Chris@0: # update issues priority Chris@14: post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field', Chris@0: :issue => {:priority_id => '', Chris@0: :assigned_to_id => '', Chris@0: :custom_field_values => {'2' => '777'}} Chris@0: Chris@0: assert_response 302 Chris@0: Chris@0: issue = Issue.find(1) Chris@0: journal = issue.journals.find(:first, :order => 'created_on DESC') Chris@0: assert_equal '777', issue.custom_value_for(2).value Chris@0: assert_equal 1, journal.details.size Chris@0: assert_equal '125', journal.details.first.old_value Chris@0: assert_equal '777', journal.details.first.value Chris@0: end Chris@0: Chris@14: def test_bulk_update_unassign Chris@0: assert_not_nil Issue.find(2).assigned_to Chris@0: @request.session[:user_id] = 2 Chris@0: # unassign issues Chris@14: post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'} Chris@0: assert_response 302 Chris@0: # check that the issues were updated Chris@0: assert_nil Issue.find(2).assigned_to Chris@0: end Chris@0: Chris@14: def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject Chris@0: @request.session[:user_id] = 2 Chris@0: Chris@14: post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4} Chris@0: Chris@0: assert_response :redirect Chris@0: issues = Issue.find([1,2]) Chris@0: issues.each do |issue| Chris@0: assert_equal 4, issue.fixed_version_id Chris@0: assert_not_equal issue.project_id, issue.fixed_version.project_id Chris@0: end Chris@0: end Chris@0: Chris@14: def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter Chris@0: @request.session[:user_id] = 2 Chris@14: post :bulk_update, :ids => [1,2], :back_url => '/issues' Chris@0: Chris@0: assert_response :redirect Chris@0: assert_redirected_to '/issues' Chris@0: end Chris@0: Chris@14: def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host Chris@0: @request.session[:user_id] = 2 Chris@14: post :bulk_update, :ids => [1,2], :back_url => 'http://google.com' Chris@0: Chris@0: assert_response :redirect Chris@0: assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier Chris@0: end Chris@0: Chris@0: def test_destroy_issue_with_no_time_entries Chris@0: assert_nil TimeEntry.find_by_issue_id(2) Chris@0: @request.session[:user_id] = 2 Chris@0: post :destroy, :id => 2 Chris@0: assert_redirected_to :action => 'index', :project_id => 'ecookbook' Chris@0: assert_nil Issue.find_by_id(2) Chris@0: end Chris@0: Chris@0: def test_destroy_issues_with_time_entries Chris@0: @request.session[:user_id] = 2 Chris@0: post :destroy, :ids => [1, 3] Chris@0: assert_response :success Chris@0: assert_template 'destroy' Chris@0: assert_not_nil assigns(:hours) Chris@0: assert Issue.find_by_id(1) && Issue.find_by_id(3) Chris@0: end Chris@0: Chris@0: def test_destroy_issues_and_destroy_time_entries Chris@0: @request.session[:user_id] = 2 Chris@0: post :destroy, :ids => [1, 3], :todo => 'destroy' Chris@0: assert_redirected_to :action => 'index', :project_id => 'ecookbook' Chris@0: assert !(Issue.find_by_id(1) || Issue.find_by_id(3)) Chris@0: assert_nil TimeEntry.find_by_id([1, 2]) Chris@0: end Chris@0: Chris@0: def test_destroy_issues_and_assign_time_entries_to_project Chris@0: @request.session[:user_id] = 2 Chris@0: post :destroy, :ids => [1, 3], :todo => 'nullify' Chris@0: assert_redirected_to :action => 'index', :project_id => 'ecookbook' Chris@0: assert !(Issue.find_by_id(1) || Issue.find_by_id(3)) Chris@0: assert_nil TimeEntry.find(1).issue_id Chris@0: assert_nil TimeEntry.find(2).issue_id Chris@0: end Chris@0: Chris@0: def test_destroy_issues_and_reassign_time_entries_to_another_issue Chris@0: @request.session[:user_id] = 2 Chris@0: post :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2 Chris@0: assert_redirected_to :action => 'index', :project_id => 'ecookbook' Chris@0: assert !(Issue.find_by_id(1) || Issue.find_by_id(3)) Chris@0: assert_equal 2, TimeEntry.find(1).issue_id Chris@0: assert_equal 2, TimeEntry.find(2).issue_id Chris@0: end Chris@0: Chris@0: def test_default_search_scope Chris@0: get :index Chris@0: assert_tag :div, :attributes => {:id => 'quick-search'}, Chris@0: :child => {:tag => 'form', Chris@0: :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}} Chris@0: end Chris@0: end