Chris@245: # Redmine - project management software Chris@1115: # Copyright (C) 2006-2012 Jean-Philippe Lang Chris@0: # Chris@0: # This program is free software; you can redistribute it and/or Chris@0: # modify it under the terms of the GNU General Public License Chris@0: # as published by the Free Software Foundation; either version 2 Chris@0: # of the License, or (at your option) any later version. Chris@441: # Chris@0: # This program is distributed in the hope that it will be useful, Chris@0: # but WITHOUT ANY WARRANTY; without even the implied warranty of Chris@0: # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the Chris@0: # GNU General Public License for more details. Chris@441: # Chris@0: # You should have received a copy of the GNU General Public License Chris@0: # along with this program; if not, write to the Free Software Chris@0: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. Chris@0: Chris@119: require File.expand_path('../../test_helper', __FILE__) Chris@0: Chris@0: class IssueTest < ActiveSupport::TestCase Chris@0: fixtures :projects, :users, :members, :member_roles, :roles, Chris@1115: :groups_users, Chris@0: :trackers, :projects_trackers, Chris@0: :enabled_modules, Chris@0: :versions, Chris@441: :issue_statuses, :issue_categories, :issue_relations, :workflows, Chris@0: :enumerations, Chris@1115: :issues, :journals, :journal_details, Chris@0: :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values, Chris@0: :time_entries Chris@0: Chris@1115: include Redmine::I18n Chris@1115: Chris@1115: def teardown Chris@1115: User.current = nil Chris@1115: end Chris@1115: Chris@0: def test_create Chris@909: issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, Chris@909: :status_id => 1, :priority => IssuePriority.all.first, Chris@909: :subject => 'test_create', Chris@909: :description => 'IssueTest#test_create', :estimated_hours => '1:30') Chris@0: assert issue.save Chris@0: issue.reload Chris@0: assert_equal 1.5, issue.estimated_hours Chris@0: end Chris@441: Chris@0: def test_create_minimal Chris@909: issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, Chris@909: :status_id => 1, :priority => IssuePriority.all.first, Chris@909: :subject => 'test_create') Chris@0: assert issue.save Chris@0: assert issue.description.nil? Chris@1115: assert_nil issue.estimated_hours Chris@1115: end Chris@1115: Chris@1115: def test_start_date_format_should_be_validated Chris@1115: set_language_if_valid 'en' Chris@1115: ['2012', 'ABC', '2012-15-20'].each do |invalid_date| Chris@1115: issue = Issue.new(:start_date => invalid_date) Chris@1115: assert !issue.valid? Chris@1115: assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}" Chris@1115: end Chris@1115: end Chris@1115: Chris@1115: def test_due_date_format_should_be_validated Chris@1115: set_language_if_valid 'en' Chris@1115: ['2012', 'ABC', '2012-15-20'].each do |invalid_date| Chris@1115: issue = Issue.new(:due_date => invalid_date) Chris@1115: assert !issue.valid? Chris@1115: assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}" Chris@1115: end Chris@1115: end Chris@1115: Chris@1115: def test_due_date_lesser_than_start_date_should_not_validate Chris@1115: set_language_if_valid 'en' Chris@1115: issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02') Chris@1115: assert !issue.valid? Chris@1115: assert_include 'Due date must be greater than start date', issue.errors.full_messages Chris@0: end Chris@441: Chris@0: def test_create_with_required_custom_field Chris@1115: set_language_if_valid 'en' Chris@0: field = IssueCustomField.find_by_name('Database') Chris@0: field.update_attribute(:is_required, true) Chris@441: Chris@909: issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, Chris@909: :status_id => 1, :subject => 'test_create', Chris@909: :description => 'IssueTest#test_create_with_required_custom_field') Chris@0: assert issue.available_custom_fields.include?(field) Chris@0: # No value for the custom field Chris@0: assert !issue.save Chris@1115: assert_equal ["Database can't be blank"], issue.errors.full_messages Chris@0: # Blank value Chris@0: issue.custom_field_values = { field.id => '' } Chris@0: assert !issue.save Chris@1115: assert_equal ["Database can't be blank"], issue.errors.full_messages Chris@0: # Invalid value Chris@0: issue.custom_field_values = { field.id => 'SQLServer' } Chris@0: assert !issue.save Chris@1115: assert_equal ["Database is not included in the list"], issue.errors.full_messages Chris@0: # Valid value Chris@0: issue.custom_field_values = { field.id => 'PostgreSQL' } Chris@0: assert issue.save Chris@0: issue.reload Chris@0: assert_equal 'PostgreSQL', issue.custom_value_for(field).value Chris@0: end Chris@441: Chris@909: def test_create_with_group_assignment Chris@909: with_settings :issue_group_assignment => '1' do Chris@909: assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1, Chris@909: :subject => 'Group assignment', Chris@909: :assigned_to_id => 11).save Chris@909: issue = Issue.first(:order => 'id DESC') Chris@909: assert_kind_of Group, issue.assigned_to Chris@909: assert_equal Group.find(11), issue.assigned_to Chris@909: end Chris@909: end Chris@909: Chris@1115: def test_create_with_parent_issue_id Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, Chris@1115: :author_id => 1, :subject => 'Group assignment', Chris@1115: :parent_issue_id => 1) Chris@1115: assert_save issue Chris@1115: assert_equal 1, issue.parent_issue_id Chris@1115: assert_equal Issue.find(1), issue.parent Chris@1115: end Chris@1115: Chris@1115: def test_create_with_sharp_parent_issue_id Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, Chris@1115: :author_id => 1, :subject => 'Group assignment', Chris@1115: :parent_issue_id => "#1") Chris@1115: assert_save issue Chris@1115: assert_equal 1, issue.parent_issue_id Chris@1115: assert_equal Issue.find(1), issue.parent Chris@1115: end Chris@1115: Chris@1115: def test_create_with_invalid_parent_issue_id Chris@1115: set_language_if_valid 'en' Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, Chris@1115: :author_id => 1, :subject => 'Group assignment', Chris@1115: :parent_issue_id => '01ABC') Chris@1115: assert !issue.save Chris@1115: assert_equal '01ABC', issue.parent_issue_id Chris@1115: assert_include 'Parent task is invalid', issue.errors.full_messages Chris@1115: end Chris@1115: Chris@1115: def test_create_with_invalid_sharp_parent_issue_id Chris@1115: set_language_if_valid 'en' Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, Chris@1115: :author_id => 1, :subject => 'Group assignment', Chris@1115: :parent_issue_id => '#01ABC') Chris@1115: assert !issue.save Chris@1115: assert_equal '#01ABC', issue.parent_issue_id Chris@1115: assert_include 'Parent task is invalid', issue.errors.full_messages Chris@1115: end Chris@1115: Chris@441: def assert_visibility_match(user, issues) Chris@441: assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort Chris@441: end Chris@441: Chris@0: def test_visible_scope_for_anonymous Chris@0: # Anonymous user should see issues of public projects only Chris@0: issues = Issue.visible(User.anonymous).all Chris@0: assert issues.any? Chris@0: assert_nil issues.detect {|issue| !issue.project.is_public?} Chris@441: assert_nil issues.detect {|issue| issue.is_private?} Chris@441: assert_visibility_match User.anonymous, issues Chris@441: end Chris@441: Chris@441: def test_visible_scope_for_anonymous_without_view_issues_permissions Chris@0: # Anonymous user should not see issues without permission Chris@0: Role.anonymous.remove_permission!(:view_issues) Chris@0: issues = Issue.visible(User.anonymous).all Chris@0: assert issues.empty? Chris@441: assert_visibility_match User.anonymous, issues Chris@0: end Chris@441: Chris@1115: def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default Chris@1115: assert Role.anonymous.update_attribute(:issues_visibility, 'default') Chris@1115: issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true) Chris@1115: assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first Chris@1115: assert !issue.visible?(User.anonymous) Chris@1115: end Chris@1115: Chris@1115: def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own Chris@1115: assert Role.anonymous.update_attribute(:issues_visibility, 'own') Chris@1115: issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true) Chris@1115: assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first Chris@1115: assert !issue.visible?(User.anonymous) Chris@1115: end Chris@1115: Chris@441: def test_visible_scope_for_non_member Chris@0: user = User.find(9) Chris@0: assert user.projects.empty? Chris@0: # Non member user should see issues of public projects only Chris@0: issues = Issue.visible(user).all Chris@0: assert issues.any? Chris@0: assert_nil issues.detect {|issue| !issue.project.is_public?} Chris@441: assert_nil issues.detect {|issue| issue.is_private?} Chris@441: assert_visibility_match user, issues Chris@441: end Chris@441: Chris@441: def test_visible_scope_for_non_member_with_own_issues_visibility Chris@441: Role.non_member.update_attribute :issues_visibility, 'own' Chris@441: Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member') Chris@441: user = User.find(9) Chris@441: Chris@441: issues = Issue.visible(user).all Chris@441: assert issues.any? Chris@441: assert_nil issues.detect {|issue| issue.author != user} Chris@441: assert_visibility_match user, issues Chris@441: end Chris@441: Chris@441: def test_visible_scope_for_non_member_without_view_issues_permissions Chris@0: # Non member user should not see issues without permission Chris@0: Role.non_member.remove_permission!(:view_issues) Chris@441: user = User.find(9) Chris@441: assert user.projects.empty? Chris@0: issues = Issue.visible(user).all Chris@0: assert issues.empty? Chris@441: assert_visibility_match user, issues Chris@441: end Chris@441: Chris@441: def test_visible_scope_for_member Chris@441: user = User.find(9) Chris@0: # User should see issues of projects for which he has view_issues permissions only Chris@441: Role.non_member.remove_permission!(:view_issues) Chris@441: Member.create!(:principal => user, :project_id => 3, :role_ids => [2]) Chris@0: issues = Issue.visible(user).all Chris@0: assert issues.any? Chris@441: assert_nil issues.detect {|issue| issue.project_id != 3} Chris@441: assert_nil issues.detect {|issue| issue.is_private?} Chris@441: assert_visibility_match user, issues Chris@0: end Chris@441: Chris@909: def test_visible_scope_for_member_with_groups_should_return_assigned_issues Chris@909: user = User.find(8) Chris@909: assert user.groups.any? Chris@909: Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2]) Chris@909: Role.non_member.remove_permission!(:view_issues) Chris@909: Chris@909: issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3, Chris@909: :status_id => 1, :priority => IssuePriority.all.first, Chris@909: :subject => 'Assignment test', Chris@909: :assigned_to => user.groups.first, Chris@909: :is_private => true) Chris@909: Chris@909: Role.find(2).update_attribute :issues_visibility, 'default' Chris@909: issues = Issue.visible(User.find(8)).all Chris@909: assert issues.any? Chris@909: assert issues.include?(issue) Chris@909: Chris@909: Role.find(2).update_attribute :issues_visibility, 'own' Chris@909: issues = Issue.visible(User.find(8)).all Chris@909: assert issues.any? Chris@909: assert issues.include?(issue) Chris@909: end Chris@909: Chris@0: def test_visible_scope_for_admin Chris@0: user = User.find(1) Chris@0: user.members.each(&:destroy) Chris@0: assert user.projects.empty? Chris@0: issues = Issue.visible(user).all Chris@0: assert issues.any? Chris@0: # Admin should see issues on private projects that he does not belong to Chris@0: assert issues.detect {|issue| !issue.project.is_public?} Chris@441: # Admin should see private issues of other users Chris@441: assert issues.detect {|issue| issue.is_private? && issue.author != user} Chris@441: assert_visibility_match user, issues Chris@0: end Chris@441: Chris@441: def test_visible_scope_with_project Chris@441: project = Project.find(1) Chris@441: issues = Issue.visible(User.find(2), :project => project).all Chris@441: projects = issues.collect(&:project).uniq Chris@441: assert_equal 1, projects.size Chris@441: assert_equal project, projects.first Chris@441: end Chris@441: Chris@441: def test_visible_scope_with_project_and_subprojects Chris@441: project = Project.find(1) Chris@441: issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all Chris@441: projects = issues.collect(&:project).uniq Chris@441: assert projects.size > 1 Chris@441: assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)} Chris@441: end Chris@441: Chris@441: def test_visible_and_nested_set_scopes Chris@441: assert_equal 0, Issue.find(1).descendants.visible.all.size Chris@441: end Chris@441: Chris@1115: def test_open_scope Chris@1115: issues = Issue.open.all Chris@1115: assert_nil issues.detect(&:closed?) Chris@1115: end Chris@1115: Chris@1115: def test_open_scope_with_arg Chris@1115: issues = Issue.open(false).all Chris@1115: assert_equal issues, issues.select(&:closed?) Chris@1115: end Chris@1115: Chris@0: def test_errors_full_messages_should_include_custom_fields_errors Chris@0: field = IssueCustomField.find_by_name('Database') Chris@441: Chris@909: issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, Chris@909: :status_id => 1, :subject => 'test_create', Chris@909: :description => 'IssueTest#test_create_with_required_custom_field') Chris@0: assert issue.available_custom_fields.include?(field) Chris@0: # Invalid value Chris@0: issue.custom_field_values = { field.id => 'SQLServer' } Chris@441: Chris@0: assert !issue.valid? Chris@0: assert_equal 1, issue.errors.full_messages.size Chris@909: assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", Chris@909: issue.errors.full_messages.first Chris@0: end Chris@441: Chris@0: def test_update_issue_with_required_custom_field Chris@0: field = IssueCustomField.find_by_name('Database') Chris@0: field.update_attribute(:is_required, true) Chris@441: Chris@0: issue = Issue.find(1) Chris@0: assert_nil issue.custom_value_for(field) Chris@0: assert issue.available_custom_fields.include?(field) Chris@0: # No change to custom values, issue can be saved Chris@0: assert issue.save Chris@0: # Blank value Chris@0: issue.custom_field_values = { field.id => '' } Chris@0: assert !issue.save Chris@0: # Valid value Chris@0: issue.custom_field_values = { field.id => 'PostgreSQL' } Chris@0: assert issue.save Chris@0: issue.reload Chris@0: assert_equal 'PostgreSQL', issue.custom_value_for(field).value Chris@0: end Chris@441: Chris@0: def test_should_not_update_attributes_if_custom_fields_validation_fails Chris@0: issue = Issue.find(1) Chris@0: field = IssueCustomField.find_by_name('Database') Chris@0: assert issue.available_custom_fields.include?(field) Chris@441: Chris@0: issue.custom_field_values = { field.id => 'Invalid' } Chris@0: issue.subject = 'Should be not be saved' Chris@0: assert !issue.save Chris@441: Chris@0: issue.reload Chris@0: assert_equal "Can't print recipes", issue.subject Chris@0: end Chris@441: Chris@0: def test_should_not_recreate_custom_values_objects_on_update Chris@0: field = IssueCustomField.find_by_name('Database') Chris@441: Chris@0: issue = Issue.find(1) Chris@0: issue.custom_field_values = { field.id => 'PostgreSQL' } Chris@0: assert issue.save Chris@0: custom_value = issue.custom_value_for(field) Chris@0: issue.reload Chris@0: issue.custom_field_values = { field.id => 'MySQL' } Chris@0: assert issue.save Chris@0: issue.reload Chris@0: assert_equal custom_value.id, issue.custom_value_for(field).id Chris@0: end Chris@441: Chris@909: def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields Chris@1115: issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, Chris@1115: :status_id => 1, :subject => 'Test', Chris@1115: :custom_field_values => {'2' => 'Test'}) Chris@909: assert !Tracker.find(2).custom_field_ids.include?(2) Chris@909: Chris@909: issue = Issue.find(issue.id) Chris@909: issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}} Chris@909: Chris@909: issue = Issue.find(issue.id) Chris@909: custom_value = issue.custom_value_for(2) Chris@909: assert_not_nil custom_value Chris@909: assert_equal 'Test', custom_value.value Chris@909: end Chris@909: Chris@0: def test_assigning_tracker_id_should_reload_custom_fields_values Chris@0: issue = Issue.new(:project => Project.find(1)) Chris@0: assert issue.custom_field_values.empty? Chris@0: issue.tracker_id = 1 Chris@0: assert issue.custom_field_values.any? Chris@0: end Chris@441: Chris@1115: def test_assigning_attributes_should_assign_project_and_tracker_first Chris@1115: seq = sequence('seq') Chris@1115: issue = Issue.new Chris@1115: issue.expects(:project_id=).in_sequence(seq) Chris@1115: issue.expects(:tracker_id=).in_sequence(seq) Chris@1115: issue.expects(:subject=).in_sequence(seq) Chris@1115: issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'} Chris@1115: end Chris@1115: Chris@1115: def test_assigning_tracker_and_custom_fields_should_assign_custom_fields Chris@0: attributes = ActiveSupport::OrderedHash.new Chris@0: attributes['custom_field_values'] = { '1' => 'MySQL' } Chris@0: attributes['tracker_id'] = '1' Chris@0: issue = Issue.new(:project => Project.find(1)) Chris@0: issue.attributes = attributes Chris@1115: assert_equal 'MySQL', issue.custom_field_value(1) Chris@0: end Chris@441: Chris@0: def test_should_update_issue_with_disabled_tracker Chris@0: p = Project.find(1) Chris@0: issue = Issue.find(1) Chris@441: Chris@0: p.trackers.delete(issue.tracker) Chris@0: assert !p.trackers.include?(issue.tracker) Chris@441: Chris@0: issue.reload Chris@0: issue.subject = 'New subject' Chris@0: assert issue.save Chris@0: end Chris@441: Chris@0: def test_should_not_set_a_disabled_tracker Chris@0: p = Project.find(1) Chris@0: p.trackers.delete(Tracker.find(2)) Chris@441: Chris@0: issue = Issue.find(1) Chris@0: issue.tracker_id = 2 Chris@0: issue.subject = 'New subject' Chris@0: assert !issue.save Chris@909: assert_not_nil issue.errors[:tracker_id] Chris@0: end Chris@441: Chris@0: def test_category_based_assignment Chris@909: issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3, Chris@909: :status_id => 1, :priority => IssuePriority.all.first, Chris@909: :subject => 'Assignment test', Chris@909: :description => 'Assignment test', :category_id => 1) Chris@0: assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to Chris@0: end Chris@441: Chris@245: def test_new_statuses_allowed_to Chris@1115: WorkflowTransition.delete_all Chris@1115: WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, Chris@1115: :old_status_id => 1, :new_status_id => 2, Chris@1115: :author => false, :assignee => false) Chris@1115: WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, Chris@1115: :old_status_id => 1, :new_status_id => 3, Chris@1115: :author => true, :assignee => false) Chris@1115: WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, Chris@1115: :new_status_id => 4, :author => false, Chris@1115: :assignee => true) Chris@1115: WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, Chris@1115: :old_status_id => 1, :new_status_id => 5, Chris@1115: :author => true, :assignee => true) Chris@245: status = IssueStatus.find(1) Chris@245: role = Role.find(1) Chris@245: tracker = Tracker.find(1) Chris@245: user = User.find(2) Chris@441: Chris@1115: issue = Issue.generate!(:tracker => tracker, :status => status, Chris@1115: :project_id => 1, :author_id => 1) Chris@245: assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id) Chris@441: Chris@1115: issue = Issue.generate!(:tracker => tracker, :status => status, Chris@1115: :project_id => 1, :author => user) Chris@909: assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id) Chris@441: Chris@1115: issue = Issue.generate!(:tracker => tracker, :status => status, Chris@1115: :project_id => 1, :author_id => 1, Chris@1115: :assigned_to => user) Chris@909: assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id) Chris@441: Chris@1115: issue = Issue.generate!(:tracker => tracker, :status => status, Chris@1115: :project_id => 1, :author => user, Chris@1115: :assigned_to => user) Chris@245: assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id) Chris@245: end Chris@441: Chris@1115: def test_new_statuses_allowed_to_should_return_all_transitions_for_admin Chris@1115: admin = User.find(1) Chris@1115: issue = Issue.find(1) Chris@1115: assert !admin.member_of?(issue.project) Chris@1115: expected_statuses = [issue.status] + Chris@1115: WorkflowTransition.find_all_by_old_status_id( Chris@1115: issue.status_id).map(&:new_status).uniq.sort Chris@1115: assert_equal expected_statuses, issue.new_statuses_allowed_to(admin) Chris@1115: end Chris@1115: Chris@1115: def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying Chris@1115: issue = Issue.find(1).copy Chris@1115: assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id) Chris@1115: Chris@1115: issue = Issue.find(2).copy Chris@1115: assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id) Chris@1115: end Chris@1115: Chris@1115: def test_safe_attributes_names_should_not_include_disabled_field Chris@1115: tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id)) Chris@1115: Chris@1115: issue = Issue.new(:tracker => tracker) Chris@1115: assert_include 'tracker_id', issue.safe_attribute_names Chris@1115: assert_include 'status_id', issue.safe_attribute_names Chris@1115: assert_include 'subject', issue.safe_attribute_names Chris@1115: assert_include 'description', issue.safe_attribute_names Chris@1115: assert_include 'custom_field_values', issue.safe_attribute_names Chris@1115: assert_include 'custom_fields', issue.safe_attribute_names Chris@1115: assert_include 'lock_version', issue.safe_attribute_names Chris@1115: Chris@1115: tracker.core_fields.each do |field| Chris@1115: assert_include field, issue.safe_attribute_names Chris@1115: end Chris@1115: Chris@1115: tracker.disabled_core_fields.each do |field| Chris@1115: assert_not_include field, issue.safe_attribute_names Chris@1115: end Chris@1115: end Chris@1115: Chris@1115: def test_safe_attributes_should_ignore_disabled_fields Chris@1115: tracker = Tracker.find(1) Chris@1115: tracker.core_fields = %w(assigned_to_id due_date) Chris@1115: tracker.save! Chris@1115: Chris@1115: issue = Issue.new(:tracker => tracker) Chris@1115: issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'} Chris@1115: assert_nil issue.start_date Chris@1115: assert_equal Date.parse('2012-07-14'), issue.due_date Chris@1115: end Chris@1115: Chris@1115: def test_safe_attributes_should_accept_target_tracker_enabled_fields Chris@1115: source = Tracker.find(1) Chris@1115: source.core_fields = [] Chris@1115: source.save! Chris@1115: target = Tracker.find(2) Chris@1115: target.core_fields = %w(assigned_to_id due_date) Chris@1115: target.save! Chris@1115: Chris@1115: issue = Issue.new(:tracker => source) Chris@1115: issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'} Chris@1115: assert_equal target, issue.tracker Chris@1115: assert_equal Date.parse('2012-07-14'), issue.due_date Chris@1115: end Chris@1115: Chris@1115: def test_safe_attributes_should_not_include_readonly_fields Chris@1115: WorkflowPermission.delete_all Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 1, :field_name => 'due_date', Chris@1115: :rule => 'readonly') Chris@1115: user = User.find(2) Chris@1115: Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1) Chris@1115: assert_equal %w(due_date), issue.read_only_attribute_names(user) Chris@1115: assert_not_include 'due_date', issue.safe_attribute_names(user) Chris@1115: Chris@1115: issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user Chris@1115: assert_equal Date.parse('2012-07-14'), issue.start_date Chris@1115: assert_nil issue.due_date Chris@1115: end Chris@1115: Chris@1115: def test_safe_attributes_should_not_include_readonly_custom_fields Chris@1115: cf1 = IssueCustomField.create!(:name => 'Writable field', Chris@1115: :field_format => 'string', Chris@1115: :is_for_all => true, :tracker_ids => [1]) Chris@1115: cf2 = IssueCustomField.create!(:name => 'Readonly field', Chris@1115: :field_format => 'string', Chris@1115: :is_for_all => true, :tracker_ids => [1]) Chris@1115: WorkflowPermission.delete_all Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 1, :field_name => cf2.id.to_s, Chris@1115: :rule => 'readonly') Chris@1115: user = User.find(2) Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1) Chris@1115: assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user) Chris@1115: assert_not_include cf2.id.to_s, issue.safe_attribute_names(user) Chris@1115: Chris@1115: issue.send :safe_attributes=, {'custom_field_values' => { Chris@1115: cf1.id.to_s => 'value1', cf2.id.to_s => 'value2' Chris@1115: }}, user Chris@1115: assert_equal 'value1', issue.custom_field_value(cf1) Chris@1115: assert_nil issue.custom_field_value(cf2) Chris@1115: Chris@1115: issue.send :safe_attributes=, {'custom_fields' => [ Chris@1115: {'id' => cf1.id.to_s, 'value' => 'valuea'}, Chris@1115: {'id' => cf2.id.to_s, 'value' => 'valueb'} Chris@1115: ]}, user Chris@1115: assert_equal 'valuea', issue.custom_field_value(cf1) Chris@1115: assert_nil issue.custom_field_value(cf2) Chris@1115: end Chris@1115: Chris@1115: def test_editable_custom_field_values_should_return_non_readonly_custom_values Chris@1115: cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string', Chris@1115: :is_for_all => true, :tracker_ids => [1, 2]) Chris@1115: cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string', Chris@1115: :is_for_all => true, :tracker_ids => [1, 2]) Chris@1115: WorkflowPermission.delete_all Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, Chris@1115: :field_name => cf2.id.to_s, :rule => 'readonly') Chris@1115: user = User.find(2) Chris@1115: Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1) Chris@1115: values = issue.editable_custom_field_values(user) Chris@1115: assert values.detect {|value| value.custom_field == cf1} Chris@1115: assert_nil values.detect {|value| value.custom_field == cf2} Chris@1115: Chris@1115: issue.tracker_id = 2 Chris@1115: values = issue.editable_custom_field_values(user) Chris@1115: assert values.detect {|value| value.custom_field == cf1} Chris@1115: assert values.detect {|value| value.custom_field == cf2} Chris@1115: end Chris@1115: Chris@1115: def test_safe_attributes_should_accept_target_tracker_writable_fields Chris@1115: WorkflowPermission.delete_all Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 1, :field_name => 'due_date', Chris@1115: :rule => 'readonly') Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, Chris@1115: :role_id => 1, :field_name => 'start_date', Chris@1115: :rule => 'readonly') Chris@1115: user = User.find(2) Chris@1115: Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1) Chris@1115: Chris@1115: issue.send :safe_attributes=, {'start_date' => '2012-07-12', Chris@1115: 'due_date' => '2012-07-14'}, user Chris@1115: assert_equal Date.parse('2012-07-12'), issue.start_date Chris@1115: assert_nil issue.due_date Chris@1115: Chris@1115: issue.send :safe_attributes=, {'start_date' => '2012-07-15', Chris@1115: 'due_date' => '2012-07-16', Chris@1115: 'tracker_id' => 2}, user Chris@1115: assert_equal Date.parse('2012-07-12'), issue.start_date Chris@1115: assert_equal Date.parse('2012-07-16'), issue.due_date Chris@1115: end Chris@1115: Chris@1115: def test_safe_attributes_should_accept_target_status_writable_fields Chris@1115: WorkflowPermission.delete_all Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 1, :field_name => 'due_date', Chris@1115: :rule => 'readonly') Chris@1115: WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1, Chris@1115: :role_id => 1, :field_name => 'start_date', Chris@1115: :rule => 'readonly') Chris@1115: user = User.find(2) Chris@1115: Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1) Chris@1115: Chris@1115: issue.send :safe_attributes=, {'start_date' => '2012-07-12', Chris@1115: 'due_date' => '2012-07-14'}, Chris@1115: user Chris@1115: assert_equal Date.parse('2012-07-12'), issue.start_date Chris@1115: assert_nil issue.due_date Chris@1115: Chris@1115: issue.send :safe_attributes=, {'start_date' => '2012-07-15', Chris@1115: 'due_date' => '2012-07-16', Chris@1115: 'status_id' => 2}, Chris@1115: user Chris@1115: assert_equal Date.parse('2012-07-12'), issue.start_date Chris@1115: assert_equal Date.parse('2012-07-16'), issue.due_date Chris@1115: end Chris@1115: Chris@1115: def test_required_attributes_should_be_validated Chris@1115: cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', Chris@1115: :is_for_all => true, :tracker_ids => [1, 2]) Chris@1115: Chris@1115: WorkflowPermission.delete_all Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 1, :field_name => 'due_date', Chris@1115: :rule => 'required') Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 1, :field_name => 'category_id', Chris@1115: :rule => 'required') Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 1, :field_name => cf.id.to_s, Chris@1115: :rule => 'required') Chris@1115: Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, Chris@1115: :role_id => 1, :field_name => 'start_date', Chris@1115: :rule => 'required') Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, Chris@1115: :role_id => 1, :field_name => cf.id.to_s, Chris@1115: :rule => 'required') Chris@1115: user = User.find(2) Chris@1115: Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, Chris@1115: :status_id => 1, :subject => 'Required fields', Chris@1115: :author => user) Chris@1115: assert_equal [cf.id.to_s, "category_id", "due_date"], Chris@1115: issue.required_attribute_names(user).sort Chris@1115: assert !issue.save, "Issue was saved" Chris@1115: assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"], Chris@1115: issue.errors.full_messages.sort Chris@1115: Chris@1115: issue.tracker_id = 2 Chris@1115: assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort Chris@1115: assert !issue.save, "Issue was saved" Chris@1115: assert_equal ["Foo can't be blank", "Start date can't be blank"], Chris@1115: issue.errors.full_messages.sort Chris@1115: Chris@1115: issue.start_date = Date.today Chris@1115: issue.custom_field_values = {cf.id.to_s => 'bar'} Chris@1115: assert issue.save Chris@1115: end Chris@1115: Chris@1115: def test_required_attribute_names_for_multiple_roles_should_intersect_rules Chris@1115: WorkflowPermission.delete_all Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 1, :field_name => 'due_date', Chris@1115: :rule => 'required') Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 1, :field_name => 'start_date', Chris@1115: :rule => 'required') Chris@1115: user = User.find(2) Chris@1115: member = Member.find(1) Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1) Chris@1115: Chris@1115: assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort Chris@1115: Chris@1115: member.role_ids = [1, 2] Chris@1115: member.save! Chris@1115: assert_equal [], issue.required_attribute_names(user.reload) Chris@1115: Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 2, :field_name => 'due_date', Chris@1115: :rule => 'required') Chris@1115: assert_equal %w(due_date), issue.required_attribute_names(user) Chris@1115: Chris@1115: member.role_ids = [1, 2, 3] Chris@1115: member.save! Chris@1115: assert_equal [], issue.required_attribute_names(user.reload) Chris@1115: Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 2, :field_name => 'due_date', Chris@1115: :rule => 'readonly') Chris@1115: # required + readonly => required Chris@1115: assert_equal %w(due_date), issue.required_attribute_names(user) Chris@1115: end Chris@1115: Chris@1115: def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules Chris@1115: WorkflowPermission.delete_all Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 1, :field_name => 'due_date', Chris@1115: :rule => 'readonly') Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 1, :field_name => 'start_date', Chris@1115: :rule => 'readonly') Chris@1115: user = User.find(2) Chris@1115: member = Member.find(1) Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1) Chris@1115: Chris@1115: assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort Chris@1115: Chris@1115: member.role_ids = [1, 2] Chris@1115: member.save! Chris@1115: assert_equal [], issue.read_only_attribute_names(user.reload) Chris@1115: Chris@1115: WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, Chris@1115: :role_id => 2, :field_name => 'due_date', Chris@1115: :rule => 'readonly') Chris@1115: assert_equal %w(due_date), issue.read_only_attribute_names(user) Chris@1115: end Chris@1115: Chris@0: def test_copy Chris@0: issue = Issue.new.copy_from(1) Chris@1115: assert issue.copy? Chris@0: assert issue.save Chris@0: issue.reload Chris@0: orig = Issue.find(1) Chris@0: assert_equal orig.subject, issue.subject Chris@0: assert_equal orig.tracker, issue.tracker Chris@0: assert_equal "125", issue.custom_value_for(2).value Chris@0: end Chris@0: Chris@0: def test_copy_should_copy_status Chris@0: orig = Issue.find(8) Chris@0: assert orig.status != IssueStatus.default Chris@441: Chris@0: issue = Issue.new.copy_from(orig) Chris@0: assert issue.save Chris@0: issue.reload Chris@0: assert_equal orig.status, issue.status Chris@0: end Chris@441: Chris@1115: def test_copy_should_add_relation_with_copied_issue Chris@1115: copied = Issue.find(1) Chris@1115: issue = Issue.new.copy_from(copied) Chris@1115: assert issue.save Chris@1115: issue.reload Chris@1115: Chris@1115: assert_equal 1, issue.relations.size Chris@1115: relation = issue.relations.first Chris@1115: assert_equal 'copied_to', relation.relation_type Chris@1115: assert_equal copied, relation.issue_from Chris@1115: assert_equal issue, relation.issue_to Chris@1115: end Chris@1115: Chris@1115: def test_copy_should_copy_subtasks Chris@1115: issue = Issue.generate_with_descendants! Chris@1115: Chris@1115: copy = issue.reload.copy Chris@1115: copy.author = User.find(7) Chris@1115: assert_difference 'Issue.count', 1+issue.descendants.count do Chris@1115: assert copy.save Chris@1115: end Chris@1115: copy.reload Chris@1115: assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort Chris@1115: child_copy = copy.children.detect {|c| c.subject == 'Child1'} Chris@1115: assert_equal %w(Child11), child_copy.children.map(&:subject).sort Chris@1115: assert_equal copy.author, child_copy.author Chris@1115: end Chris@1115: Chris@1115: def test_copy_should_copy_subtasks_to_target_project Chris@1115: issue = Issue.generate_with_descendants! Chris@1115: Chris@1115: copy = issue.copy(:project_id => 3) Chris@1115: assert_difference 'Issue.count', 1+issue.descendants.count do Chris@1115: assert copy.save Chris@1115: end Chris@1115: assert_equal [3], copy.reload.descendants.map(&:project_id).uniq Chris@1115: end Chris@1115: Chris@1115: def test_copy_should_not_copy_subtasks_twice_when_saving_twice Chris@1115: issue = Issue.generate_with_descendants! Chris@1115: Chris@1115: copy = issue.reload.copy Chris@1115: assert_difference 'Issue.count', 1+issue.descendants.count do Chris@1115: assert copy.save Chris@1115: assert copy.save Chris@1115: end Chris@1115: end Chris@1115: Chris@1115: def test_should_not_call_after_project_change_on_creation Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1, Chris@1115: :subject => 'Test', :author_id => 1) Chris@1115: issue.expects(:after_project_change).never Chris@1115: issue.save! Chris@1115: end Chris@1115: Chris@1115: def test_should_not_call_after_project_change_on_update Chris@1115: issue = Issue.find(1) Chris@1115: issue.project = Project.find(1) Chris@1115: issue.subject = 'No project change' Chris@1115: issue.expects(:after_project_change).never Chris@1115: issue.save! Chris@1115: end Chris@1115: Chris@1115: def test_should_call_after_project_change_on_project_change Chris@1115: issue = Issue.find(1) Chris@1115: issue.project = Project.find(2) Chris@1115: issue.expects(:after_project_change).once Chris@1115: issue.save! Chris@1115: end Chris@1115: Chris@1115: def test_adding_journal_should_update_timestamp Chris@1115: issue = Issue.find(1) Chris@1115: updated_on_was = issue.updated_on Chris@1115: Chris@1115: issue.init_journal(User.first, "Adding notes") Chris@1115: assert_difference 'Journal.count' do Chris@1115: assert issue.save Chris@1115: end Chris@1115: issue.reload Chris@1115: Chris@1115: assert_not_equal updated_on_was, issue.updated_on Chris@1115: end Chris@1115: Chris@0: def test_should_close_duplicates Chris@0: # Create 3 issues Chris@1115: issue1 = Issue.generate! Chris@1115: issue2 = Issue.generate! Chris@1115: issue3 = Issue.generate! Chris@441: Chris@0: # 2 is a dupe of 1 Chris@1115: IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, Chris@1115: :relation_type => IssueRelation::TYPE_DUPLICATES) Chris@0: # And 3 is a dupe of 2 Chris@1115: IssueRelation.create!(:issue_from => issue3, :issue_to => issue2, Chris@1115: :relation_type => IssueRelation::TYPE_DUPLICATES) Chris@0: # And 3 is a dupe of 1 (circular duplicates) Chris@1115: IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, Chris@1115: :relation_type => IssueRelation::TYPE_DUPLICATES) Chris@441: Chris@0: assert issue1.reload.duplicates.include?(issue2) Chris@441: Chris@0: # Closing issue 1 Chris@0: issue1.init_journal(User.find(:first), "Closing issue1") Chris@0: issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true} Chris@0: assert issue1.save Chris@0: # 2 and 3 should be also closed Chris@0: assert issue2.reload.closed? Chris@441: assert issue3.reload.closed? Chris@0: end Chris@441: Chris@0: def test_should_not_close_duplicated_issue Chris@1115: issue1 = Issue.generate! Chris@1115: issue2 = Issue.generate! Chris@441: Chris@0: # 2 is a dupe of 1 Chris@1115: IssueRelation.create(:issue_from => issue2, :issue_to => issue1, Chris@1115: :relation_type => IssueRelation::TYPE_DUPLICATES) Chris@0: # 2 is a dup of 1 but 1 is not a duplicate of 2 Chris@0: assert !issue2.reload.duplicates.include?(issue1) Chris@441: Chris@0: # Closing issue 2 Chris@0: issue2.init_journal(User.find(:first), "Closing issue2") Chris@0: issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true} Chris@0: assert issue2.save Chris@0: # 1 should not be also closed Chris@0: assert !issue1.reload.closed? Chris@0: end Chris@441: Chris@0: def test_assignable_versions Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, Chris@1115: :status_id => 1, :fixed_version_id => 1, Chris@1115: :subject => 'New issue') Chris@0: assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq Chris@0: end Chris@441: Chris@0: def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, Chris@1115: :status_id => 1, :fixed_version_id => 1, Chris@1115: :subject => 'New issue') Chris@0: assert !issue.save Chris@909: assert_not_nil issue.errors[:fixed_version_id] Chris@0: end Chris@441: Chris@0: def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, Chris@1115: :status_id => 1, :fixed_version_id => 2, Chris@1115: :subject => 'New issue') Chris@0: assert !issue.save Chris@909: assert_not_nil issue.errors[:fixed_version_id] Chris@0: end Chris@441: Chris@0: def test_should_be_able_to_assign_a_new_issue_to_an_open_version Chris@1115: issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, Chris@1115: :status_id => 1, :fixed_version_id => 3, Chris@1115: :subject => 'New issue') Chris@0: assert issue.save Chris@0: end Chris@441: Chris@0: def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version Chris@0: issue = Issue.find(11) Chris@0: assert_equal 'closed', issue.fixed_version.status Chris@0: issue.subject = 'Subject changed' Chris@0: assert issue.save Chris@0: end Chris@441: Chris@0: def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version Chris@0: issue = Issue.find(11) Chris@0: issue.status_id = 1 Chris@0: assert !issue.save Chris@909: assert_not_nil issue.errors[:base] Chris@0: end Chris@441: Chris@0: def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version Chris@0: issue = Issue.find(11) Chris@0: issue.status_id = 1 Chris@0: issue.fixed_version_id = 3 Chris@0: assert issue.save Chris@0: end Chris@441: Chris@0: def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version Chris@0: issue = Issue.find(12) Chris@0: assert_equal 'locked', issue.fixed_version.status Chris@0: issue.status_id = 1 Chris@0: assert issue.save Chris@0: end Chris@441: Chris@1115: def test_should_not_be_able_to_keep_unshared_version_when_changing_project Chris@1115: issue = Issue.find(2) Chris@1115: assert_equal 2, issue.fixed_version_id Chris@1115: issue.project_id = 3 Chris@1115: assert_nil issue.fixed_version_id Chris@1115: issue.fixed_version_id = 2 Chris@1115: assert !issue.save Chris@1115: assert_include 'Target version is not included in the list', issue.errors.full_messages Chris@1115: end Chris@1115: Chris@1115: def test_should_keep_shared_version_when_changing_project Chris@1115: Version.find(2).update_attribute :sharing, 'tree' Chris@1115: Chris@1115: issue = Issue.find(2) Chris@1115: assert_equal 2, issue.fixed_version_id Chris@1115: issue.project_id = 3 Chris@1115: assert_equal 2, issue.fixed_version_id Chris@1115: assert issue.save Chris@1115: end Chris@1115: Chris@1115: def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled Chris@1115: assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2)) Chris@1115: end Chris@1115: Chris@1115: def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled Chris@1115: Project.find(2).disable_module! :issue_tracking Chris@1115: assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2)) Chris@1115: end Chris@1115: Chris@0: def test_move_to_another_project_with_same_category Chris@0: issue = Issue.find(1) Chris@1115: issue.project = Project.find(2) Chris@1115: assert issue.save Chris@0: issue.reload Chris@0: assert_equal 2, issue.project_id Chris@0: # Category changes Chris@0: assert_equal 4, issue.category_id Chris@0: # Make sure time entries were move to the target project Chris@0: assert_equal 2, issue.time_entries.first.project_id Chris@0: end Chris@441: Chris@0: def test_move_to_another_project_without_same_category Chris@0: issue = Issue.find(2) Chris@1115: issue.project = Project.find(2) Chris@1115: assert issue.save Chris@0: issue.reload Chris@0: assert_equal 2, issue.project_id Chris@0: # Category cleared Chris@0: assert_nil issue.category_id Chris@0: end Chris@441: Chris@0: def test_move_to_another_project_should_clear_fixed_version_when_not_shared Chris@0: issue = Issue.find(1) Chris@0: issue.update_attribute(:fixed_version_id, 1) Chris@1115: issue.project = Project.find(2) Chris@1115: assert issue.save Chris@0: issue.reload Chris@0: assert_equal 2, issue.project_id Chris@0: # Cleared fixed_version Chris@0: assert_equal nil, issue.fixed_version Chris@0: end Chris@441: Chris@0: def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project Chris@0: issue = Issue.find(1) Chris@0: issue.update_attribute(:fixed_version_id, 4) Chris@1115: issue.project = Project.find(5) Chris@1115: assert issue.save Chris@0: issue.reload Chris@0: assert_equal 5, issue.project_id Chris@0: # Keep fixed_version Chris@0: assert_equal 4, issue.fixed_version_id Chris@0: end Chris@441: Chris@0: def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project Chris@0: issue = Issue.find(1) Chris@0: issue.update_attribute(:fixed_version_id, 1) Chris@1115: issue.project = Project.find(5) Chris@1115: assert issue.save Chris@0: issue.reload Chris@0: assert_equal 5, issue.project_id Chris@0: # Cleared fixed_version Chris@0: assert_equal nil, issue.fixed_version Chris@0: end Chris@441: Chris@0: def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide Chris@0: issue = Issue.find(1) Chris@0: issue.update_attribute(:fixed_version_id, 7) Chris@1115: issue.project = Project.find(2) Chris@1115: assert issue.save Chris@0: issue.reload Chris@0: assert_equal 2, issue.project_id Chris@0: # Keep fixed_version Chris@0: assert_equal 7, issue.fixed_version_id Chris@0: end Chris@441: Chris@1115: def test_move_to_another_project_should_keep_parent_if_valid Chris@1115: issue = Issue.find(1) Chris@1115: issue.update_attribute(:parent_issue_id, 2) Chris@1115: issue.project = Project.find(3) Chris@1115: assert issue.save Chris@1115: issue.reload Chris@1115: assert_equal 2, issue.parent_id Chris@1115: end Chris@1115: Chris@1115: def test_move_to_another_project_should_clear_parent_if_not_valid Chris@1115: issue = Issue.find(1) Chris@1115: issue.update_attribute(:parent_issue_id, 2) Chris@1115: issue.project = Project.find(2) Chris@1115: assert issue.save Chris@1115: issue.reload Chris@1115: assert_nil issue.parent_id Chris@1115: end Chris@1115: Chris@0: def test_move_to_another_project_with_disabled_tracker Chris@0: issue = Issue.find(1) Chris@0: target = Project.find(2) Chris@0: target.tracker_ids = [3] Chris@0: target.save Chris@1115: issue.project = target Chris@1115: assert issue.save Chris@0: issue.reload Chris@1115: assert_equal 2, issue.project_id Chris@1115: assert_equal 3, issue.tracker_id Chris@0: end Chris@441: Chris@0: def test_copy_to_the_same_project Chris@0: issue = Issue.find(1) Chris@1115: copy = issue.copy Chris@0: assert_difference 'Issue.count' do Chris@1115: copy.save! Chris@0: end Chris@0: assert_kind_of Issue, copy Chris@0: assert_equal issue.project, copy.project Chris@0: assert_equal "125", copy.custom_value_for(2).value Chris@0: end Chris@441: Chris@0: def test_copy_to_another_project_and_tracker Chris@0: issue = Issue.find(1) Chris@1115: copy = issue.copy(:project_id => 3, :tracker_id => 2) Chris@0: assert_difference 'Issue.count' do Chris@1115: copy.save! Chris@0: end Chris@0: copy.reload Chris@0: assert_kind_of Issue, copy Chris@0: assert_equal Project.find(3), copy.project Chris@0: assert_equal Tracker.find(2), copy.tracker Chris@0: # Custom field #2 is not associated with target tracker Chris@0: assert_nil copy.custom_value_for(2) Chris@0: end Chris@0: Chris@1115: context "#copy" do Chris@1115: setup do Chris@1115: @issue = Issue.find(1) Chris@1115: end Chris@0: Chris@1115: should "not create a journal" do Chris@1115: copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3) Chris@1115: copy.save! Chris@1115: assert_equal 0, copy.reload.journals.size Chris@1115: end Chris@441: Chris@1115: should "allow assigned_to changes" do Chris@1115: copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3) Chris@1115: assert_equal 3, copy.assigned_to_id Chris@1115: end Chris@0: Chris@1115: should "allow status changes" do Chris@1115: copy = @issue.copy(:project_id => 3, :tracker_id => 2, :status_id => 2) Chris@1115: assert_equal 2, copy.status_id Chris@1115: end Chris@0: Chris@1115: should "allow start date changes" do Chris@1115: date = Date.today Chris@1115: copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date) Chris@1115: assert_equal date, copy.start_date Chris@1115: end Chris@0: Chris@1115: should "allow due date changes" do Chris@1115: date = Date.today Chris@1115: copy = @issue.copy(:project_id => 3, :tracker_id => 2, :due_date => date) Chris@1115: assert_equal date, copy.due_date Chris@1115: end Chris@0: Chris@1115: should "set current user as author" do Chris@1115: User.current = User.find(9) Chris@1115: copy = @issue.copy(:project_id => 3, :tracker_id => 2) Chris@1115: assert_equal User.current, copy.author Chris@1115: end Chris@441: Chris@1115: should "create a journal with notes" do Chris@1115: date = Date.today Chris@1115: notes = "Notes added when copying" Chris@1115: copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date) Chris@1115: copy.init_journal(User.current, notes) Chris@1115: copy.save! Chris@441: Chris@1115: assert_equal 1, copy.journals.size Chris@1115: journal = copy.journals.first Chris@1115: assert_equal 0, journal.details.size Chris@1115: assert_equal notes, journal.notes Chris@1115: end Chris@1115: end Chris@441: Chris@1115: def test_valid_parent_project Chris@1115: issue = Issue.find(1) Chris@1115: issue_in_same_project = Issue.find(2) Chris@1115: issue_in_child_project = Issue.find(5) Chris@1115: issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1) Chris@1115: issue_in_other_child_project = Issue.find(6) Chris@1115: issue_in_different_tree = Issue.find(4) Chris@441: Chris@1115: with_settings :cross_project_subtasks => '' do Chris@1115: assert_equal true, issue.valid_parent_project?(issue_in_same_project) Chris@1115: assert_equal false, issue.valid_parent_project?(issue_in_child_project) Chris@1115: assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project) Chris@1115: assert_equal false, issue.valid_parent_project?(issue_in_different_tree) Chris@0: end Chris@1115: Chris@1115: with_settings :cross_project_subtasks => 'system' do Chris@1115: assert_equal true, issue.valid_parent_project?(issue_in_same_project) Chris@1115: assert_equal true, issue.valid_parent_project?(issue_in_child_project) Chris@1115: assert_equal true, issue.valid_parent_project?(issue_in_different_tree) Chris@1115: end Chris@1115: Chris@1115: with_settings :cross_project_subtasks => 'tree' do Chris@1115: assert_equal true, issue.valid_parent_project?(issue_in_same_project) Chris@1115: assert_equal true, issue.valid_parent_project?(issue_in_child_project) Chris@1115: assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project) Chris@1115: assert_equal false, issue.valid_parent_project?(issue_in_different_tree) Chris@1115: Chris@1115: assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project) Chris@1115: assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project) Chris@1115: end Chris@1115: Chris@1115: with_settings :cross_project_subtasks => 'descendants' do Chris@1115: assert_equal true, issue.valid_parent_project?(issue_in_same_project) Chris@1115: assert_equal false, issue.valid_parent_project?(issue_in_child_project) Chris@1115: assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project) Chris@1115: assert_equal false, issue.valid_parent_project?(issue_in_different_tree) Chris@1115: Chris@1115: assert_equal true, issue_in_child_project.valid_parent_project?(issue) Chris@1115: assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project) Chris@1115: end Chris@1115: end Chris@1115: Chris@1115: def test_recipients_should_include_previous_assignee Chris@1115: user = User.find(3) Chris@1115: user.members.update_all ["mail_notification = ?", false] Chris@1115: user.update_attribute :mail_notification, 'only_assigned' Chris@1115: Chris@1115: issue = Issue.find(2) Chris@1115: issue.assigned_to = nil Chris@1115: assert_include user.mail, issue.recipients Chris@1115: issue.save! Chris@1115: assert !issue.recipients.include?(user.mail) Chris@0: end Chris@441: Chris@0: def test_recipients_should_not_include_users_that_cannot_view_the_issue Chris@0: issue = Issue.find(12) Chris@0: assert issue.recipients.include?(issue.author.mail) Chris@1115: # copy the issue to a private project Chris@1115: copy = issue.copy(:project_id => 5, :tracker_id => 2) Chris@0: # author is not a member of project anymore Chris@0: assert !copy.recipients.include?(copy.author.mail) Chris@0: end Chris@0: Chris@909: def test_recipients_should_include_the_assigned_group_members Chris@1115: group_member = User.generate! Chris@909: group = Group.generate! Chris@909: group.users << group_member Chris@909: Chris@909: issue = Issue.find(12) Chris@909: issue.assigned_to = group Chris@909: assert issue.recipients.include?(group_member.mail) Chris@909: end Chris@909: Chris@0: def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue Chris@0: user = User.find(3) Chris@0: issue = Issue.find(9) Chris@0: Watcher.create!(:user => user, :watchable => issue) Chris@0: assert issue.watched_by?(user) Chris@0: assert !issue.watcher_recipients.include?(user.mail) Chris@0: end Chris@441: Chris@0: def test_issue_destroy Chris@0: Issue.find(1).destroy Chris@0: assert_nil Issue.find_by_id(1) Chris@0: assert_nil TimeEntry.find_by_issue_id(1) Chris@0: end Chris@441: Chris@1115: def test_destroying_a_deleted_issue_should_not_raise_an_error Chris@1115: issue = Issue.find(1) Chris@1115: Issue.find(1).destroy Chris@1115: Chris@1115: assert_nothing_raised do Chris@1115: assert_no_difference 'Issue.count' do Chris@1115: issue.destroy Chris@1115: end Chris@1115: assert issue.destroyed? Chris@1115: end Chris@1115: end Chris@1115: Chris@1115: def test_destroying_a_stale_issue_should_not_raise_an_error Chris@1115: issue = Issue.find(1) Chris@1115: Issue.find(1).update_attribute :subject, "Updated" Chris@1115: Chris@1115: assert_nothing_raised do Chris@1115: assert_difference 'Issue.count', -1 do Chris@1115: issue.destroy Chris@1115: end Chris@1115: assert issue.destroyed? Chris@1115: end Chris@1115: end Chris@1115: Chris@0: def test_blocked Chris@0: blocked_issue = Issue.find(9) Chris@0: blocking_issue = Issue.find(10) Chris@441: Chris@0: assert blocked_issue.blocked? Chris@0: assert !blocking_issue.blocked? Chris@0: end Chris@441: Chris@0: def test_blocked_issues_dont_allow_closed_statuses Chris@0: blocked_issue = Issue.find(9) Chris@441: Chris@0: allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002)) Chris@0: assert !allowed_statuses.empty? Chris@0: closed_statuses = allowed_statuses.select {|st| st.is_closed?} Chris@0: assert closed_statuses.empty? Chris@0: end Chris@441: Chris@0: def test_unblocked_issues_allow_closed_statuses Chris@0: blocking_issue = Issue.find(10) Chris@441: Chris@0: allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002)) Chris@0: assert !allowed_statuses.empty? Chris@0: closed_statuses = allowed_statuses.select {|st| st.is_closed?} Chris@0: assert !closed_statuses.empty? Chris@0: end Chris@441: Chris@1115: def test_reschedule_an_issue_without_dates Chris@1115: with_settings :non_working_week_days => [] do Chris@1115: issue = Issue.new(:start_date => nil, :due_date => nil) Chris@1115: issue.reschedule_on '2012-10-09'.to_date Chris@1115: assert_equal '2012-10-09'.to_date, issue.start_date Chris@1115: assert_equal '2012-10-09'.to_date, issue.due_date Chris@1115: end Chris@441: Chris@1115: with_settings :non_working_week_days => %w(6 7) do Chris@1115: issue = Issue.new(:start_date => nil, :due_date => nil) Chris@1115: issue.reschedule_on '2012-10-09'.to_date Chris@1115: assert_equal '2012-10-09'.to_date, issue.start_date Chris@1115: assert_equal '2012-10-09'.to_date, issue.due_date Chris@1115: Chris@1115: issue = Issue.new(:start_date => nil, :due_date => nil) Chris@1115: issue.reschedule_on '2012-10-13'.to_date Chris@1115: assert_equal '2012-10-15'.to_date, issue.start_date Chris@1115: assert_equal '2012-10-15'.to_date, issue.due_date Chris@1115: end Chris@1115: end Chris@1115: Chris@1115: def test_reschedule_an_issue_with_start_date Chris@1115: with_settings :non_working_week_days => [] do Chris@1115: issue = Issue.new(:start_date => '2012-10-09', :due_date => nil) Chris@1115: issue.reschedule_on '2012-10-13'.to_date Chris@1115: assert_equal '2012-10-13'.to_date, issue.start_date Chris@1115: assert_equal '2012-10-13'.to_date, issue.due_date Chris@1115: end Chris@1115: Chris@1115: with_settings :non_working_week_days => %w(6 7) do Chris@1115: issue = Issue.new(:start_date => '2012-10-09', :due_date => nil) Chris@1115: issue.reschedule_on '2012-10-11'.to_date Chris@1115: assert_equal '2012-10-11'.to_date, issue.start_date Chris@1115: assert_equal '2012-10-11'.to_date, issue.due_date Chris@1115: Chris@1115: issue = Issue.new(:start_date => '2012-10-09', :due_date => nil) Chris@1115: issue.reschedule_on '2012-10-13'.to_date Chris@1115: assert_equal '2012-10-15'.to_date, issue.start_date Chris@1115: assert_equal '2012-10-15'.to_date, issue.due_date Chris@1115: end Chris@1115: end Chris@1115: Chris@1115: def test_reschedule_an_issue_with_start_and_due_dates Chris@1115: with_settings :non_working_week_days => [] do Chris@1115: issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15') Chris@1115: issue.reschedule_on '2012-10-13'.to_date Chris@1115: assert_equal '2012-10-13'.to_date, issue.start_date Chris@1115: assert_equal '2012-10-19'.to_date, issue.due_date Chris@1115: end Chris@1115: Chris@1115: with_settings :non_working_week_days => %w(6 7) do Chris@1115: issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days Chris@1115: issue.reschedule_on '2012-10-11'.to_date Chris@1115: assert_equal '2012-10-11'.to_date, issue.start_date Chris@1115: assert_equal '2012-10-23'.to_date, issue.due_date Chris@1115: Chris@1115: issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') Chris@1115: issue.reschedule_on '2012-10-13'.to_date Chris@1115: assert_equal '2012-10-15'.to_date, issue.start_date Chris@1115: assert_equal '2012-10-25'.to_date, issue.due_date Chris@1115: end Chris@1115: end Chris@1115: Chris@1115: def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue Chris@1115: issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17') Chris@1115: issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17') Chris@1115: IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, Chris@1115: :relation_type => IssueRelation::TYPE_PRECEDES) Chris@1115: assert_equal Date.parse('2012-10-18'), issue2.reload.start_date Chris@1115: Chris@1115: issue1.due_date = '2012-10-23' chris@37: issue1.save! Chris@1115: issue2.reload Chris@1115: assert_equal Date.parse('2012-10-24'), issue2.start_date Chris@1115: assert_equal Date.parse('2012-10-26'), issue2.due_date Chris@1115: end Chris@1115: Chris@1115: def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue Chris@1115: issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17') Chris@1115: issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17') Chris@1115: IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, Chris@1115: :relation_type => IssueRelation::TYPE_PRECEDES) Chris@1115: assert_equal Date.parse('2012-10-18'), issue2.reload.start_date Chris@1115: Chris@1115: issue1.start_date = '2012-09-17' Chris@1115: issue1.due_date = '2012-09-18' Chris@1115: issue1.save! Chris@1115: issue2.reload Chris@1115: assert_equal Date.parse('2012-09-19'), issue2.start_date Chris@1115: assert_equal Date.parse('2012-09-21'), issue2.due_date Chris@1115: end Chris@1115: Chris@1115: def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues Chris@1115: issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17') Chris@1115: issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17') Chris@1115: issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02') Chris@1115: IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, Chris@1115: :relation_type => IssueRelation::TYPE_PRECEDES) Chris@1115: IssueRelation.create!(:issue_from => issue3, :issue_to => issue2, Chris@1115: :relation_type => IssueRelation::TYPE_PRECEDES) Chris@1115: assert_equal Date.parse('2012-10-18'), issue2.reload.start_date Chris@1115: Chris@1115: issue1.start_date = '2012-09-17' Chris@1115: issue1.due_date = '2012-09-18' Chris@1115: issue1.save! Chris@1115: issue2.reload Chris@1115: # Issue 2 must start after Issue 3 Chris@1115: assert_equal Date.parse('2012-10-03'), issue2.start_date Chris@1115: assert_equal Date.parse('2012-10-05'), issue2.due_date Chris@1115: end Chris@1115: Chris@1115: def test_rescheduling_a_stale_issue_should_not_raise_an_error Chris@1115: with_settings :non_working_week_days => [] do Chris@1115: stale = Issue.find(1) Chris@1115: issue = Issue.find(1) Chris@1115: issue.subject = "Updated" Chris@1115: issue.save! Chris@1115: date = 10.days.from_now.to_date Chris@1115: assert_nothing_raised do Chris@1115: stale.reschedule_on!(date) Chris@1115: end Chris@1115: assert_equal date, stale.reload.start_date Chris@1115: end chris@37: end Chris@441: Chris@0: def test_overdue Chris@0: assert Issue.new(:due_date => 1.day.ago.to_date).overdue? Chris@0: assert !Issue.new(:due_date => Date.today).overdue? Chris@0: assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue? Chris@0: assert !Issue.new(:due_date => nil).overdue? Chris@1115: assert !Issue.new(:due_date => 1.day.ago.to_date, Chris@1115: :status => IssueStatus.find(:first, Chris@1115: :conditions => {:is_closed => true}) Chris@1115: ).overdue? Chris@0: end chris@22: chris@22: context "#behind_schedule?" do chris@22: should "be false if the issue has no start_date" do Chris@1115: assert !Issue.new(:start_date => nil, Chris@1115: :due_date => 1.day.from_now.to_date, Chris@1115: :done_ratio => 0).behind_schedule? chris@22: end chris@22: chris@22: should "be false if the issue has no end_date" do Chris@1115: assert !Issue.new(:start_date => 1.day.from_now.to_date, Chris@1115: :due_date => nil, Chris@1115: :done_ratio => 0).behind_schedule? chris@22: end chris@22: chris@22: should "be false if the issue has more done than it's calendar time" do Chris@1115: assert !Issue.new(:start_date => 50.days.ago.to_date, Chris@1115: :due_date => 50.days.from_now.to_date, Chris@1115: :done_ratio => 90).behind_schedule? chris@22: end chris@22: chris@22: should "be true if the issue hasn't been started at all" do Chris@1115: assert Issue.new(:start_date => 1.day.ago.to_date, Chris@1115: :due_date => 1.day.from_now.to_date, Chris@1115: :done_ratio => 0).behind_schedule? chris@22: end chris@22: chris@22: should "be true if the issue has used more calendar time than it's done ratio" do Chris@1115: assert Issue.new(:start_date => 100.days.ago.to_date, Chris@1115: :due_date => Date.today, Chris@1115: :done_ratio => 90).behind_schedule? chris@22: end chris@22: end chris@37: chris@37: context "#assignable_users" do chris@37: should "be Users" do chris@37: assert_kind_of User, Issue.find(1).assignable_users.first chris@37: end chris@37: chris@37: should "include the issue author" do chris@37: non_project_member = User.generate! Chris@1115: issue = Issue.generate!(:author => non_project_member) chris@37: chris@37: assert issue.assignable_users.include?(non_project_member) chris@37: end chris@37: Chris@909: should "include the current assignee" do Chris@909: user = User.generate! Chris@1115: issue = Issue.generate!(:assigned_to => user) Chris@909: user.lock! Chris@909: Chris@909: assert Issue.find(issue.id).assignable_users.include?(user) Chris@909: end Chris@909: chris@37: should "not show the issue author twice" do chris@37: assignable_user_ids = Issue.find(1).assignable_users.collect(&:id) chris@37: assert_equal 2, assignable_user_ids.length Chris@441: chris@37: assignable_user_ids.each do |user_id| Chris@1115: assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, Chris@1115: "User #{user_id} appears more or less than once" chris@37: end chris@37: end Chris@909: Chris@909: context "with issue_group_assignment" do Chris@909: should "include groups" do Chris@909: issue = Issue.new(:project => Project.find(2)) Chris@909: Chris@909: with_settings :issue_group_assignment => '1' do Chris@909: assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort Chris@909: assert issue.assignable_users.include?(Group.find(11)) Chris@909: end Chris@909: end Chris@909: end Chris@909: Chris@909: context "without issue_group_assignment" do Chris@909: should "not include groups" do Chris@909: issue = Issue.new(:project => Project.find(2)) Chris@909: Chris@909: with_settings :issue_group_assignment => '0' do Chris@909: assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort Chris@909: assert !issue.assignable_users.include?(Group.find(11)) Chris@909: end Chris@909: end Chris@909: end Chris@0: end Chris@441: Chris@0: def test_create_should_send_email_notification Chris@0: ActionMailer::Base.deliveries.clear Chris@909: issue = Issue.new(:project_id => 1, :tracker_id => 1, Chris@909: :author_id => 3, :status_id => 1, Chris@909: :priority => IssuePriority.all.first, Chris@909: :subject => 'test_create', :estimated_hours => '1:30') Chris@0: Chris@0: assert issue.save Chris@0: assert_equal 1, ActionMailer::Base.deliveries.size Chris@0: end chris@37: Chris@0: def test_stale_issue_should_not_send_email_notification Chris@0: ActionMailer::Base.deliveries.clear Chris@0: issue = Issue.find(1) Chris@0: stale = Issue.find(1) Chris@441: Chris@0: issue.init_journal(User.find(1)) Chris@0: issue.subject = 'Subjet update' Chris@0: assert issue.save Chris@0: assert_equal 1, ActionMailer::Base.deliveries.size Chris@0: ActionMailer::Base.deliveries.clear Chris@441: Chris@0: stale.init_journal(User.find(1)) Chris@0: stale.subject = 'Another subjet update' Chris@0: assert_raise ActiveRecord::StaleObjectError do Chris@0: stale.save Chris@0: end Chris@0: assert ActionMailer::Base.deliveries.empty? Chris@0: end Chris@441: Chris@245: def test_journalized_description Chris@245: IssueCustomField.delete_all Chris@441: Chris@245: i = Issue.first Chris@245: old_description = i.description Chris@245: new_description = "This is the new description" Chris@441: Chris@245: i.init_journal(User.find(2)) Chris@245: i.description = new_description Chris@245: assert_difference 'Journal.count', 1 do Chris@245: assert_difference 'JournalDetail.count', 1 do Chris@245: i.save! Chris@245: end Chris@245: end Chris@441: Chris@245: detail = JournalDetail.first(:order => 'id DESC') Chris@245: assert_equal i, detail.journal.journalized Chris@245: assert_equal 'attr', detail.property Chris@245: assert_equal 'description', detail.prop_key Chris@245: assert_equal old_description, detail.old_value Chris@245: assert_equal new_description, detail.value Chris@245: end Chris@909: Chris@507: def test_blank_descriptions_should_not_be_journalized Chris@507: IssueCustomField.delete_all Chris@507: Issue.update_all("description = NULL", "id=1") Chris@909: Chris@507: i = Issue.find(1) Chris@507: i.init_journal(User.find(2)) Chris@507: i.subject = "blank description" Chris@507: i.description = "\r\n" Chris@909: Chris@507: assert_difference 'Journal.count', 1 do Chris@507: assert_difference 'JournalDetail.count', 1 do Chris@507: i.save! Chris@507: end Chris@507: end Chris@507: end Chris@909: Chris@1115: def test_journalized_multi_custom_field Chris@1115: field = IssueCustomField.create!(:name => 'filter', :field_format => 'list', Chris@1115: :is_filter => true, :is_for_all => true, Chris@1115: :tracker_ids => [1], Chris@1115: :possible_values => ['value1', 'value2', 'value3'], Chris@1115: :multiple => true) Chris@1115: Chris@1115: issue = Issue.create!(:project_id => 1, :tracker_id => 1, Chris@1115: :subject => 'Test', :author_id => 1) Chris@1115: Chris@1115: assert_difference 'Journal.count' do Chris@1115: assert_difference 'JournalDetail.count' do Chris@1115: issue.init_journal(User.first) Chris@1115: issue.custom_field_values = {field.id => ['value1']} Chris@1115: issue.save! Chris@1115: end Chris@1115: assert_difference 'JournalDetail.count' do Chris@1115: issue.init_journal(User.first) Chris@1115: issue.custom_field_values = {field.id => ['value1', 'value2']} Chris@1115: issue.save! Chris@1115: end Chris@1115: assert_difference 'JournalDetail.count', 2 do Chris@1115: issue.init_journal(User.first) Chris@1115: issue.custom_field_values = {field.id => ['value3', 'value2']} Chris@1115: issue.save! Chris@1115: end Chris@1115: assert_difference 'JournalDetail.count', 2 do Chris@1115: issue.init_journal(User.first) Chris@1115: issue.custom_field_values = {field.id => nil} Chris@1115: issue.save! Chris@1115: end Chris@1115: end Chris@1115: end Chris@1115: Chris@507: def test_description_eol_should_be_normalized Chris@507: i = Issue.new(:description => "CR \r LF \n CRLF \r\n") Chris@507: assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description Chris@507: end Chris@441: Chris@0: def test_saving_twice_should_not_duplicate_journal_details Chris@0: i = Issue.find(:first) Chris@0: i.init_journal(User.find(2), 'Some notes') Chris@0: # initial changes Chris@0: i.subject = 'New subject' Chris@0: i.done_ratio = i.done_ratio + 10 Chris@0: assert_difference 'Journal.count' do Chris@0: assert i.save Chris@0: end Chris@0: # 1 more change Chris@0: i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id]) Chris@0: assert_no_difference 'Journal.count' do Chris@0: assert_difference 'JournalDetail.count', 1 do Chris@0: i.save Chris@0: end Chris@0: end Chris@0: # no more change Chris@0: assert_no_difference 'Journal.count' do Chris@0: assert_no_difference 'JournalDetail.count' do Chris@0: i.save Chris@0: end Chris@0: end Chris@0: end Chris@0: Chris@128: def test_all_dependent_issues Chris@128: IssueRelation.delete_all Chris@909: assert IssueRelation.create!(:issue_from => Issue.find(1), Chris@909: :issue_to => Issue.find(2), Chris@909: :relation_type => IssueRelation::TYPE_PRECEDES) Chris@909: assert IssueRelation.create!(:issue_from => Issue.find(2), Chris@909: :issue_to => Issue.find(3), Chris@909: :relation_type => IssueRelation::TYPE_PRECEDES) Chris@909: assert IssueRelation.create!(:issue_from => Issue.find(3), Chris@909: :issue_to => Issue.find(8), Chris@909: :relation_type => IssueRelation::TYPE_PRECEDES) Chris@441: Chris@128: assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort Chris@128: end Chris@128: Chris@128: def test_all_dependent_issues_with_persistent_circular_dependency Chris@128: IssueRelation.delete_all Chris@909: assert IssueRelation.create!(:issue_from => Issue.find(1), Chris@909: :issue_to => Issue.find(2), Chris@909: :relation_type => IssueRelation::TYPE_PRECEDES) Chris@909: assert IssueRelation.create!(:issue_from => Issue.find(2), Chris@909: :issue_to => Issue.find(3), Chris@909: :relation_type => IssueRelation::TYPE_PRECEDES) Chris@441: Chris@1115: r = IssueRelation.create!(:issue_from => Issue.find(3), Chris@1115: :issue_to => Issue.find(7), Chris@1115: :relation_type => IssueRelation::TYPE_PRECEDES) Chris@1115: IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id]) Chris@1115: Chris@128: assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort Chris@128: end Chris@441: Chris@441: def test_all_dependent_issues_with_persistent_multiple_circular_dependencies Chris@441: IssueRelation.delete_all Chris@909: assert IssueRelation.create!(:issue_from => Issue.find(1), Chris@909: :issue_to => Issue.find(2), Chris@909: :relation_type => IssueRelation::TYPE_RELATES) Chris@909: assert IssueRelation.create!(:issue_from => Issue.find(2), Chris@909: :issue_to => Issue.find(3), Chris@909: :relation_type => IssueRelation::TYPE_RELATES) Chris@909: assert IssueRelation.create!(:issue_from => Issue.find(3), Chris@909: :issue_to => Issue.find(8), Chris@909: :relation_type => IssueRelation::TYPE_RELATES) Chris@1115: Chris@1115: r = IssueRelation.create!(:issue_from => Issue.find(8), Chris@1115: :issue_to => Issue.find(7), Chris@1115: :relation_type => IssueRelation::TYPE_RELATES) Chris@1115: IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id]) Chris@1115: Chris@1115: r = IssueRelation.create!(:issue_from => Issue.find(3), Chris@1115: :issue_to => Issue.find(7), Chris@1115: :relation_type => IssueRelation::TYPE_RELATES) Chris@1115: IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id]) Chris@441: Chris@441: assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort Chris@441: end Chris@441: Chris@0: context "#done_ratio" do Chris@0: setup do Chris@0: @issue = Issue.find(1) Chris@0: @issue_status = IssueStatus.find(1) Chris@0: @issue_status.update_attribute(:default_done_ratio, 50) chris@37: @issue2 = Issue.find(2) chris@37: @issue_status2 = IssueStatus.find(2) chris@37: @issue_status2.update_attribute(:default_done_ratio, 0) Chris@0: end Chris@441: Chris@1115: teardown do Chris@1115: Setting.issue_done_ratio = 'issue_field' Chris@1115: end Chris@1115: Chris@0: context "with Setting.issue_done_ratio using the issue_field" do Chris@0: setup do Chris@0: Setting.issue_done_ratio = 'issue_field' Chris@0: end Chris@441: Chris@0: should "read the issue's field" do Chris@0: assert_equal 0, @issue.done_ratio chris@37: assert_equal 30, @issue2.done_ratio Chris@0: end Chris@0: end Chris@0: Chris@0: context "with Setting.issue_done_ratio using the issue_status" do Chris@0: setup do Chris@0: Setting.issue_done_ratio = 'issue_status' Chris@0: end Chris@441: Chris@0: should "read the Issue Status's default done ratio" do Chris@0: assert_equal 50, @issue.done_ratio chris@37: assert_equal 0, @issue2.done_ratio Chris@0: end Chris@0: end Chris@0: end Chris@0: Chris@0: context "#update_done_ratio_from_issue_status" do Chris@0: setup do Chris@0: @issue = Issue.find(1) Chris@0: @issue_status = IssueStatus.find(1) Chris@0: @issue_status.update_attribute(:default_done_ratio, 50) chris@37: @issue2 = Issue.find(2) chris@37: @issue_status2 = IssueStatus.find(2) chris@37: @issue_status2.update_attribute(:default_done_ratio, 0) Chris@0: end Chris@441: Chris@0: context "with Setting.issue_done_ratio using the issue_field" do Chris@0: setup do Chris@0: Setting.issue_done_ratio = 'issue_field' Chris@0: end Chris@441: Chris@0: should "not change the issue" do Chris@0: @issue.update_done_ratio_from_issue_status chris@37: @issue2.update_done_ratio_from_issue_status Chris@0: chris@37: assert_equal 0, @issue.read_attribute(:done_ratio) chris@37: assert_equal 30, @issue2.read_attribute(:done_ratio) Chris@0: end Chris@0: end Chris@0: Chris@0: context "with Setting.issue_done_ratio using the issue_status" do Chris@0: setup do Chris@0: Setting.issue_done_ratio = 'issue_status' Chris@0: end Chris@441: chris@37: should "change the issue's done ratio" do Chris@0: @issue.update_done_ratio_from_issue_status chris@37: @issue2.update_done_ratio_from_issue_status Chris@0: chris@37: assert_equal 50, @issue.read_attribute(:done_ratio) chris@37: assert_equal 0, @issue2.read_attribute(:done_ratio) Chris@0: end Chris@0: end Chris@0: end Chris@0: Chris@0: test "#by_tracker" do Chris@441: User.current = User.anonymous Chris@0: groups = Issue.by_tracker(Project.find(1)) Chris@0: assert_equal 3, groups.size Chris@0: assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i} Chris@0: end Chris@0: Chris@0: test "#by_version" do Chris@441: User.current = User.anonymous Chris@0: groups = Issue.by_version(Project.find(1)) Chris@0: assert_equal 3, groups.size Chris@0: assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i} Chris@0: end Chris@0: Chris@0: test "#by_priority" do Chris@441: User.current = User.anonymous Chris@0: groups = Issue.by_priority(Project.find(1)) Chris@0: assert_equal 4, groups.size Chris@0: assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i} Chris@0: end Chris@0: Chris@0: test "#by_category" do Chris@441: User.current = User.anonymous Chris@0: groups = Issue.by_category(Project.find(1)) Chris@0: assert_equal 2, groups.size Chris@0: assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i} Chris@0: end Chris@0: Chris@0: test "#by_assigned_to" do Chris@441: User.current = User.anonymous Chris@0: groups = Issue.by_assigned_to(Project.find(1)) Chris@0: assert_equal 2, groups.size Chris@0: assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i} Chris@0: end Chris@0: Chris@0: test "#by_author" do Chris@441: User.current = User.anonymous Chris@0: groups = Issue.by_author(Project.find(1)) Chris@0: assert_equal 4, groups.size Chris@0: assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i} Chris@0: end Chris@0: Chris@0: test "#by_subproject" do Chris@441: User.current = User.anonymous Chris@0: groups = Issue.by_subproject(Project.find(1)) Chris@441: # Private descendant not visible Chris@441: assert_equal 1, groups.size Chris@441: assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i} Chris@0: end Chris@441: Chris@1115: def test_recently_updated_scope Chris@0: #should return the last updated issue Chris@1115: assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first Chris@0: end Chris@0: Chris@0: def test_on_active_projects_scope Chris@0: assert Project.find(2).archive Chris@441: Chris@0: before = Issue.on_active_project.length Chris@0: # test inclusion to results Chris@1115: issue = Issue.generate!(:tracker => Project.find(2).trackers.first) Chris@0: assert_equal before + 1, Issue.on_active_project.length Chris@0: Chris@0: # Move to an archived project Chris@0: issue.project = Project.find(2) Chris@0: assert issue.save Chris@0: assert_equal before, Issue.on_active_project.length Chris@0: end chris@37: chris@37: context "Issue#recipients" do chris@37: setup do chris@37: @project = Project.find(1) Chris@1115: @author = User.generate! Chris@1115: @assignee = User.generate! Chris@1115: @issue = Issue.generate!(:project => @project, :assigned_to => @assignee, :author => @author) chris@37: end Chris@441: chris@37: should "include project recipients" do chris@37: assert @project.recipients.present? chris@37: @project.recipients.each do |project_recipient| chris@37: assert @issue.recipients.include?(project_recipient) chris@37: end chris@37: end chris@37: chris@37: should "include the author if the author is active" do chris@37: assert @issue.author, "No author set for Issue" chris@37: assert @issue.recipients.include?(@issue.author.mail) chris@37: end Chris@441: chris@37: should "include the assigned to user if the assigned to user is active" do chris@37: assert @issue.assigned_to, "No assigned_to set for Issue" chris@37: assert @issue.recipients.include?(@issue.assigned_to.mail) chris@37: end chris@37: chris@37: should "not include users who opt out of all email" do chris@37: @author.update_attribute(:mail_notification, :none) chris@37: chris@37: assert !@issue.recipients.include?(@issue.author.mail) chris@37: end chris@37: chris@37: should "not include the issue author if they are only notified of assigned issues" do chris@37: @author.update_attribute(:mail_notification, :only_assigned) chris@37: chris@37: assert !@issue.recipients.include?(@issue.author.mail) chris@37: end chris@37: chris@37: should "not include the assigned user if they are only notified of owned issues" do chris@37: @assignee.update_attribute(:mail_notification, :only_owner) chris@37: chris@37: assert !@issue.recipients.include?(@issue.assigned_to.mail) chris@37: end Chris@1115: end chris@37: Chris@1115: def test_last_journal_id_with_journals_should_return_the_journal_id Chris@1115: assert_equal 2, Issue.find(1).last_journal_id Chris@1115: end Chris@1115: Chris@1115: def test_last_journal_id_without_journals_should_return_nil Chris@1115: assert_nil Issue.find(3).last_journal_id Chris@1115: end Chris@1115: Chris@1115: def test_journals_after_should_return_journals_with_greater_id Chris@1115: assert_equal [Journal.find(2)], Issue.find(1).journals_after('1') Chris@1115: assert_equal [], Issue.find(1).journals_after('2') Chris@1115: end Chris@1115: Chris@1115: def test_journals_after_with_blank_arg_should_return_all_journals Chris@1115: assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('') Chris@1115: end Chris@1115: Chris@1115: def test_css_classes_should_include_priority Chris@1115: issue = Issue.new(:priority => IssuePriority.find(8)) Chris@1115: classes = issue.css_classes.split(' ') Chris@1115: assert_include 'priority-8', classes Chris@1115: assert_include 'priority-highest', classes Chris@1115: end Chris@1115: Chris@1115: def test_save_attachments_with_hash_should_save_attachments_in_keys_order Chris@1115: set_tmp_attachments_directory Chris@1115: issue = Issue.generate! Chris@1115: issue.save_attachments({ Chris@1115: 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')}, Chris@1115: '3' => {'file' => mock_file_with_options(:original_filename => 'bar')}, Chris@1115: '1' => {'file' => mock_file_with_options(:original_filename => 'foo')} Chris@1115: }) Chris@1115: issue.attach_saved_attachments Chris@1115: Chris@1115: assert_equal 3, issue.reload.attachments.count Chris@1115: assert_equal %w(upload foo bar), issue.attachments.map(&:filename) chris@37: end Chris@0: end