Mercurial > hg > soundsoftware-site
diff test/unit/query_test.rb @ 1298:4f746d8966dd redmine_2.3_integration
Merge from redmine-2.3 branch to create new branch redmine-2.3-integration
author | Chris Cannam |
---|---|
date | Fri, 14 Jun 2013 09:28:30 +0100 |
parents | 622f24f53b42 |
children |
line wrap: on
line diff
--- a/test/unit/query_test.rb Fri Jun 14 09:07:32 2013 +0100 +++ b/test/unit/query_test.rb Fri Jun 14 09:28:30 2013 +0100 @@ -1,5 +1,5 @@ # Redmine - project management software -# Copyright (C) 2006-2012 Jean-Philippe Lang +# Copyright (C) 2006-2013 Jean-Philippe Lang # # This program is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License @@ -28,21 +28,26 @@ :projects_trackers, :custom_fields_trackers + def test_available_filters_should_be_ordered + query = IssueQuery.new + assert_equal 0, query.available_filters.keys.index('status_id') + end + def test_custom_fields_for_all_projects_should_be_available_in_global_queries - query = Query.new(:project => nil, :name => '_') + query = IssueQuery.new(:project => nil, :name => '_') assert query.available_filters.has_key?('cf_1') assert !query.available_filters.has_key?('cf_3') end def test_system_shared_versions_should_be_available_in_global_queries Version.find(2).update_attribute :sharing, 'system' - query = Query.new(:project => nil, :name => '_') + query = IssueQuery.new(:project => nil, :name => '_') assert query.available_filters.has_key?('fixed_version_id') assert query.available_filters['fixed_version_id'][:values].detect {|v| v.last == '2'} end def test_project_filter_in_global_queries - query = Query.new(:project => nil, :name => '_') + query = IssueQuery.new(:project => nil, :name => '_') project_filter = query.available_filters["project_id"] assert_not_nil project_filter project_ids = project_filter[:values].map{|p| p[1]} @@ -63,7 +68,7 @@ end def assert_query_statement_includes(query, condition) - assert query.statement.include?(condition), "Query statement condition not found in: #{query.statement}" + assert_include condition, query.statement end def assert_query_result(expected, query) @@ -75,14 +80,14 @@ def test_query_should_allow_shared_versions_for_a_project_query subproject_version = Version.find(4) - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('fixed_version_id', '=', [subproject_version.id.to_s]) assert query.statement.include?("#{Issue.table_name}.fixed_version_id IN ('4')") end def test_query_with_multiple_custom_fields - query = Query.find(1) + query = IssueQuery.find(1) assert query.valid? assert query.statement.include?("#{CustomValue.table_name}.value IN ('MySQL')") issues = find_issues_with_query(query) @@ -91,7 +96,7 @@ end def test_operator_none - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('fixed_version_id', '!*', ['']) query.add_filter('cf_1', '!*', ['']) assert query.statement.include?("#{Issue.table_name}.fixed_version_id IS NULL") @@ -100,7 +105,7 @@ end def test_operator_none_for_integer - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('estimated_hours', '!*', ['']) issues = find_issues_with_query(query) assert !issues.empty? @@ -108,7 +113,7 @@ end def test_operator_none_for_date - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('start_date', '!*', ['']) issues = find_issues_with_query(query) assert !issues.empty? @@ -116,7 +121,7 @@ end def test_operator_none_for_string_custom_field - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('cf_2', '!*', ['']) assert query.has_filter?('cf_2') issues = find_issues_with_query(query) @@ -125,7 +130,7 @@ end def test_operator_all - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('fixed_version_id', '*', ['']) query.add_filter('cf_1', '*', ['']) assert query.statement.include?("#{Issue.table_name}.fixed_version_id IS NOT NULL") @@ -134,7 +139,7 @@ end def test_operator_all_for_date - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('start_date', '*', ['']) issues = find_issues_with_query(query) assert !issues.empty? @@ -142,7 +147,7 @@ end def test_operator_all_for_string_custom_field - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('cf_2', '*', ['']) assert query.has_filter?('cf_2') issues = find_issues_with_query(query) @@ -151,7 +156,7 @@ end def test_numeric_filter_should_not_accept_non_numeric_values - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter('estimated_hours', '=', ['a']) assert query.has_filter?('estimated_hours') @@ -161,7 +166,7 @@ def test_operator_is_on_float Issue.update_all("estimated_hours = 171.2", "id=2") - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter('estimated_hours', '=', ['171.20']) issues = find_issues_with_query(query) assert_equal 1, issues.size @@ -174,7 +179,7 @@ CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '12') CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '') - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter("cf_#{f.id}", '=', ['12']) issues = find_issues_with_query(query) assert_equal 1, issues.size @@ -187,7 +192,7 @@ CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '-12') CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '') - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter("cf_#{f.id}", '=', ['-12']) assert query.valid? issues = find_issues_with_query(query) @@ -201,7 +206,7 @@ CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '12.7') CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '') - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter("cf_#{f.id}", '=', ['12.7']) issues = find_issues_with_query(query) assert_equal 1, issues.size @@ -214,7 +219,7 @@ CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '-12.7') CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '') - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter("cf_#{f.id}", '=', ['-12.7']) assert query.valid? issues = find_issues_with_query(query) @@ -229,12 +234,12 @@ CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => 'value2') CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => 'value1') - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter("cf_#{f.id}", '=', ['value1']) issues = find_issues_with_query(query) assert_equal [1, 3], issues.map(&:id).sort - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter("cf_#{f.id}", '=', ['value2']) issues = find_issues_with_query(query) assert_equal [1], issues.map(&:id).sort @@ -247,13 +252,13 @@ CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => 'value2') CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => 'value1') - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter("cf_#{f.id}", '!', ['value1']) issues = find_issues_with_query(query) assert !issues.map(&:id).include?(1) assert !issues.map(&:id).include?(3) - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter("cf_#{f.id}", '!', ['value2']) issues = find_issues_with_query(query) assert !issues.map(&:id).include?(1) @@ -264,7 +269,7 @@ # is_private filter only available for those who can set issues private User.current = User.find(2) - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') assert query.available_filters.key?('is_private') query.add_filter("is_private", '=', ['1']) @@ -279,7 +284,7 @@ # is_private filter only available for those who can set issues private User.current = User.find(2) - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') assert query.available_filters.key?('is_private') query.add_filter("is_private", '!', ['1']) @@ -291,14 +296,14 @@ end def test_operator_greater_than - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('done_ratio', '>=', ['40']) assert query.statement.include?("#{Issue.table_name}.done_ratio >= 40.0") find_issues_with_query(query) end def test_operator_greater_than_a_float - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('estimated_hours', '>=', ['40.5']) assert query.statement.include?("#{Issue.table_name}.estimated_hours >= 40.5") find_issues_with_query(query) @@ -310,7 +315,7 @@ CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '12') CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '') - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter("cf_#{f.id}", '>=', ['8']) issues = find_issues_with_query(query) assert_equal 1, issues.size @@ -318,7 +323,7 @@ end def test_operator_lesser_than - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('done_ratio', '<=', ['30']) assert query.statement.include?("#{Issue.table_name}.done_ratio <= 30.0") find_issues_with_query(query) @@ -326,14 +331,28 @@ def test_operator_lesser_than_on_custom_field f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_filter => true, :is_for_all => true) - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter("cf_#{f.id}", '<=', ['30']) - assert query.statement.include?("CAST(custom_values.value AS decimal(60,3)) <= 30.0") + assert_match /CAST.+ <= 30\.0/, query.statement find_issues_with_query(query) end + def test_operator_lesser_than_on_date_custom_field + f = IssueCustomField.create!(:name => 'filter', :field_format => 'date', :is_filter => true, :is_for_all => true) + CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '2013-04-11') + CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '2013-05-14') + CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '') + + query = IssueQuery.new(:project => Project.find(1), :name => '_') + query.add_filter("cf_#{f.id}", '<=', ['2013-05-01']) + issue_ids = find_issues_with_query(query).map(&:id) + assert_include 1, issue_ids + assert_not_include 2, issue_ids + assert_not_include 3, issue_ids + end + def test_operator_between - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('done_ratio', '><', ['30', '40']) assert_include "#{Issue.table_name}.done_ratio BETWEEN 30.0 AND 40.0", query.statement find_issues_with_query(query) @@ -341,14 +360,14 @@ def test_operator_between_on_custom_field f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_filter => true, :is_for_all => true) - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter("cf_#{f.id}", '><', ['30', '40']) - assert_include "CAST(custom_values.value AS decimal(60,3)) BETWEEN 30.0 AND 40.0", query.statement + assert_match /CAST.+ BETWEEN 30.0 AND 40.0/, query.statement find_issues_with_query(query) end def test_date_filter_should_not_accept_non_date_values - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter('created_on', '=', ['a']) assert query.has_filter?('created_on') @@ -356,7 +375,7 @@ end def test_date_filter_should_not_accept_invalid_date_values - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter('created_on', '=', ['2011-01-34']) assert query.has_filter?('created_on') @@ -364,7 +383,7 @@ end def test_relative_date_filter_should_not_accept_non_integer_values - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter('created_on', '>t-', ['a']) assert query.has_filter?('created_on') @@ -372,28 +391,28 @@ end def test_operator_date_equals - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter('due_date', '=', ['2011-07-10']) assert_match /issues\.due_date > '2011-07-09 23:59:59(\.9+)?' AND issues\.due_date <= '2011-07-10 23:59:59(\.9+)?/, query.statement find_issues_with_query(query) end def test_operator_date_lesser_than - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter('due_date', '<=', ['2011-07-10']) assert_match /issues\.due_date <= '2011-07-10 23:59:59(\.9+)?/, query.statement find_issues_with_query(query) end def test_operator_date_greater_than - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter('due_date', '>=', ['2011-07-10']) assert_match /issues\.due_date > '2011-07-09 23:59:59(\.9+)?'/, query.statement find_issues_with_query(query) end def test_operator_date_between - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.add_filter('due_date', '><', ['2011-06-23', '2011-07-10']) assert_match /issues\.due_date > '2011-06-22 23:59:59(\.9+)?' AND issues\.due_date <= '2011-07-10 23:59:59(\.9+)?/, query.statement find_issues_with_query(query) @@ -401,7 +420,7 @@ def test_operator_in_more_than Issue.find(7).update_attribute(:due_date, (Date.today + 15)) - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('due_date', '>t+', ['15']) issues = find_issues_with_query(query) assert !issues.empty? @@ -409,7 +428,7 @@ end def test_operator_in_less_than - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('due_date', '<t+', ['15']) issues = find_issues_with_query(query) assert !issues.empty? @@ -417,7 +436,7 @@ end def test_operator_in_the_next_days - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('due_date', '><t+', ['15']) issues = find_issues_with_query(query) assert !issues.empty? @@ -426,7 +445,7 @@ def test_operator_less_than_ago Issue.find(7).update_attribute(:due_date, (Date.today - 3)) - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('due_date', '>t-', ['3']) issues = find_issues_with_query(query) assert !issues.empty? @@ -435,7 +454,7 @@ def test_operator_in_the_past_days Issue.find(7).update_attribute(:due_date, (Date.today - 3)) - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('due_date', '><t-', ['3']) issues = find_issues_with_query(query) assert !issues.empty? @@ -444,7 +463,7 @@ def test_operator_more_than_ago Issue.find(7).update_attribute(:due_date, (Date.today - 10)) - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('due_date', '<t-', ['10']) assert query.statement.include?("#{Issue.table_name}.due_date <=") issues = find_issues_with_query(query) @@ -454,7 +473,7 @@ def test_operator_in Issue.find(7).update_attribute(:due_date, (Date.today + 2)) - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('due_date', 't+', ['2']) issues = find_issues_with_query(query) assert !issues.empty? @@ -463,7 +482,7 @@ def test_operator_ago Issue.find(7).update_attribute(:due_date, (Date.today - 3)) - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('due_date', 't-', ['3']) issues = find_issues_with_query(query) assert !issues.empty? @@ -471,7 +490,7 @@ end def test_operator_today - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('due_date', 't', ['']) issues = find_issues_with_query(query) assert !issues.empty? @@ -479,19 +498,19 @@ end def test_operator_this_week_on_date - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('due_date', 'w', ['']) find_issues_with_query(query) end def test_operator_this_week_on_datetime - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('created_on', 'w', ['']) find_issues_with_query(query) end def test_operator_contains - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('subject', '~', ['uNable']) assert query.statement.include?("LOWER(#{Issue.table_name}.subject) LIKE '%unable%'") result = find_issues_with_query(query) @@ -505,7 +524,7 @@ Date.stubs(:today).returns(Date.parse('2011-04-29')) - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('due_date', 'w', ['']) assert query.statement.match(/issues\.due_date > '2011-04-24 23:59:59(\.9+)?' AND issues\.due_date <= '2011-05-01 23:59:59(\.9+)?/), "range not found in #{query.statement}" I18n.locale = :en @@ -517,13 +536,13 @@ Date.stubs(:today).returns(Date.parse('2011-04-29')) - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('due_date', 'w', ['']) assert query.statement.match(/issues\.due_date > '2011-04-23 23:59:59(\.9+)?' AND issues\.due_date <= '2011-04-30 23:59:59(\.9+)?/), "range not found in #{query.statement}" end def test_operator_does_not_contains - query = Query.new(:project => Project.find(1), :name => '_') + query = IssueQuery.new(:project => Project.find(1), :name => '_') query.add_filter('subject', '!~', ['uNable']) assert query.statement.include?("LOWER(#{Issue.table_name}.subject) NOT LIKE '%unable%'") find_issues_with_query(query) @@ -538,7 +557,7 @@ i3 = Issue.generate!(:project_id => 1, :tracker_id => 1, :assigned_to => Group.find(11)) group.users << user - query = Query.new(:name => '_', :filters => { 'assigned_to_id' => {:operator => '=', :values => ['me']}}) + query = IssueQuery.new(:name => '_', :filters => { 'assigned_to_id' => {:operator => '=', :values => ['me']}}) result = query.issues assert_equal Issue.visible.all(:conditions => {:assigned_to_id => ([2] + user.reload.group_ids)}).sort_by(&:id), result.sort_by(&:id) @@ -553,7 +572,7 @@ issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :custom_field_values => {cf.id.to_s => '2'}, :subject => 'Test', :author_id => 1) issue2 = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {cf.id.to_s => '3'}) - query = Query.new(:name => '_', :project => Project.find(1)) + query = IssueQuery.new(:name => '_', :project => Project.find(1)) filter = query.available_filters["cf_#{cf.id}"] assert_not_nil filter assert_include 'me', filter[:values].map{|v| v[1]} @@ -566,7 +585,7 @@ def test_filter_my_projects User.current = User.find(2) - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') filter = query.available_filters['project_id'] assert_not_nil filter assert_include 'mine', filter[:values].map{|v| v[1]} @@ -578,7 +597,7 @@ def test_filter_watched_issues User.current = User.find(1) - query = Query.new(:name => '_', :filters => { 'watcher_id' => {:operator => '=', :values => ['me']}}) + query = IssueQuery.new(:name => '_', :filters => { 'watcher_id' => {:operator => '=', :values => ['me']}}) result = find_issues_with_query(query) assert_not_nil result assert !result.empty? @@ -588,7 +607,7 @@ def test_filter_unwatched_issues User.current = User.find(1) - query = Query.new(:name => '_', :filters => { 'watcher_id' => {:operator => '!', :values => ['me']}}) + query = IssueQuery.new(:name => '_', :filters => { 'watcher_id' => {:operator => '!', :values => ['me']}}) result = find_issues_with_query(query) assert_not_nil result assert !result.empty? @@ -601,7 +620,7 @@ CustomValue.create!(:custom_field => field, :customized => Project.find(3), :value => 'Foo') CustomValue.create!(:custom_field => field, :customized => Project.find(5), :value => 'Foo') - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') filter_name = "project.cf_#{field.id}" assert_include filter_name, query.available_filters.keys query.filters = {filter_name => {:operator => '=', :values => ['Foo']}} @@ -612,7 +631,7 @@ field = UserCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string') CustomValue.create!(:custom_field => field, :customized => User.find(3), :value => 'Foo') - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') filter_name = "author.cf_#{field.id}" assert_include filter_name, query.available_filters.keys query.filters = {filter_name => {:operator => '=', :values => ['Foo']}} @@ -623,7 +642,7 @@ field = UserCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string') CustomValue.create!(:custom_field => field, :customized => User.find(3), :value => 'Foo') - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') filter_name = "assigned_to.cf_#{field.id}" assert_include filter_name, query.available_filters.keys query.filters = {filter_name => {:operator => '=', :values => ['Foo']}} @@ -634,7 +653,7 @@ field = VersionCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string') CustomValue.create!(:custom_field => field, :customized => Version.find(2), :value => 'Foo') - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') filter_name = "fixed_version.cf_#{field.id}" assert_include filter_name, query.available_filters.keys query.filters = {filter_name => {:operator => '=', :values => ['Foo']}} @@ -646,11 +665,11 @@ IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(2)) IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(3), :issue_to => Issue.find(1)) - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.filters = {"relates" => {:operator => '=', :values => ['1']}} assert_equal [2, 3], find_issues_with_query(query).map(&:id).sort - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.filters = {"relates" => {:operator => '=', :values => ['2']}} assert_equal [1], find_issues_with_query(query).map(&:id).sort end @@ -663,15 +682,15 @@ IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Project.find(3).issues.first) end - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.filters = {"relates" => {:operator => '=p', :values => ['2']}} assert_equal [1, 2], find_issues_with_query(query).map(&:id).sort - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.filters = {"relates" => {:operator => '=p', :values => ['3']}} assert_equal [1], find_issues_with_query(query).map(&:id).sort - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.filters = {"relates" => {:operator => '=p', :values => ['4']}} assert_equal [], find_issues_with_query(query).map(&:id).sort end @@ -684,7 +703,7 @@ IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Project.find(3).issues.first) end - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.filters = {"relates" => {:operator => '=!p', :values => ['1']}} assert_equal [1], find_issues_with_query(query).map(&:id).sort end @@ -697,7 +716,7 @@ IssueRelation.create!(:relation_type => "relates", :issue_to => Project.find(2).issues.first, :issue_from => Issue.find(3)) end - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.filters = {"relates" => {:operator => '!p', :values => ['2']}} ids = find_issues_with_query(query).map(&:id).sort assert_include 2, ids @@ -710,7 +729,7 @@ IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(2)) IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(3), :issue_to => Issue.find(1)) - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.filters = {"relates" => {:operator => '!*', :values => ['']}} ids = find_issues_with_query(query).map(&:id) assert_equal [], ids & [1, 2, 3] @@ -722,13 +741,13 @@ IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(2)) IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(3), :issue_to => Issue.find(1)) - query = Query.new(:name => '_') + query = IssueQuery.new(:name => '_') query.filters = {"relates" => {:operator => '*', :values => ['']}} assert_equal [1, 2, 3], find_issues_with_query(query).map(&:id).sort end def test_statement_should_be_nil_with_no_filters - q = Query.new(:name => '_') + q = IssueQuery.new(:name => '_') q.filters = {} assert q.valid? @@ -736,44 +755,62 @@ end def test_default_columns - q = Query.new + q = IssueQuery.new assert q.columns.any? assert q.inline_columns.any? assert q.block_columns.empty? end def test_set_column_names - q = Query.new + q = IssueQuery.new q.column_names = ['tracker', :subject, '', 'unknonw_column'] - assert_equal [:tracker, :subject], q.columns.collect {|c| c.name} - c = q.columns.first - assert q.has_column?(c) + assert_equal [:id, :tracker, :subject], q.columns.collect {|c| c.name} + end + + def test_has_column_should_accept_a_column_name + q = IssueQuery.new + q.column_names = ['tracker', :subject] + assert q.has_column?(:tracker) + assert !q.has_column?(:category) + end + + def test_has_column_should_accept_a_column + q = IssueQuery.new + q.column_names = ['tracker', :subject] + + tracker_column = q.available_columns.detect {|c| c.name==:tracker} + assert_kind_of QueryColumn, tracker_column + category_column = q.available_columns.detect {|c| c.name==:category} + assert_kind_of QueryColumn, category_column + + assert q.has_column?(tracker_column) + assert !q.has_column?(category_column) end def test_inline_and_block_columns - q = Query.new + q = IssueQuery.new q.column_names = ['subject', 'description', 'tracker'] - assert_equal [:subject, :tracker], q.inline_columns.map(&:name) + assert_equal [:id, :subject, :tracker], q.inline_columns.map(&:name) assert_equal [:description], q.block_columns.map(&:name) end def test_custom_field_columns_should_be_inline - q = Query.new + q = IssueQuery.new columns = q.available_columns.select {|column| column.is_a? QueryCustomFieldColumn} assert columns.any? assert_nil columns.detect {|column| !column.inline?} end def test_query_should_preload_spent_hours - q = Query.new(:name => '_', :column_names => [:subject, :spent_hours]) + q = IssueQuery.new(:name => '_', :column_names => [:subject, :spent_hours]) assert q.has_column?(:spent_hours) issues = q.issues assert_not_nil issues.first.instance_variable_get("@spent_hours") end def test_groupable_columns_should_include_custom_fields - q = Query.new + q = IssueQuery.new column = q.groupable_columns.detect {|c| c.name == :cf_1} assert_not_nil column assert_kind_of QueryCustomFieldColumn, column @@ -783,7 +820,7 @@ field = CustomField.find(1) field.update_attribute :multiple, true - q = Query.new + q = IssueQuery.new column = q.groupable_columns.detect {|c| c.name == :cf_1} assert_nil column end @@ -791,19 +828,19 @@ def test_groupable_columns_should_include_user_custom_fields cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1], :field_format => 'user') - q = Query.new + q = IssueQuery.new assert q.groupable_columns.detect {|c| c.name == "cf_#{cf.id}".to_sym} end def test_groupable_columns_should_include_version_custom_fields cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1], :field_format => 'version') - q = Query.new + q = IssueQuery.new assert q.groupable_columns.detect {|c| c.name == "cf_#{cf.id}".to_sym} end def test_grouped_with_valid_column - q = Query.new(:group_by => 'status') + q = IssueQuery.new(:group_by => 'status') assert q.grouped? assert_not_nil q.group_by_column assert_equal :status, q.group_by_column.name @@ -812,7 +849,7 @@ end def test_grouped_with_invalid_column - q = Query.new(:group_by => 'foo') + q = IssueQuery.new(:group_by => 'foo') assert !q.grouped? assert_nil q.group_by_column assert_nil q.group_by_statement @@ -820,7 +857,7 @@ def test_sortable_columns_should_sort_assignees_according_to_user_format_setting with_settings :user_format => 'lastname_coma_firstname' do - q = Query.new + q = IssueQuery.new assert q.sortable_columns.has_key?('assigned_to') assert_equal %w(users.lastname users.firstname users.id), q.sortable_columns['assigned_to'] end @@ -828,14 +865,14 @@ def test_sortable_columns_should_sort_authors_according_to_user_format_setting with_settings :user_format => 'lastname_coma_firstname' do - q = Query.new + q = IssueQuery.new assert q.sortable_columns.has_key?('author') assert_equal %w(authors.lastname authors.firstname authors.id), q.sortable_columns['author'] end end def test_sortable_columns_should_include_custom_field - q = Query.new + q = IssueQuery.new assert q.sortable_columns['cf_1'] end @@ -843,29 +880,29 @@ field = CustomField.find(1) field.update_attribute :multiple, true - q = Query.new + q = IssueQuery.new assert !q.sortable_columns['cf_1'] end def test_default_sort - q = Query.new + q = IssueQuery.new assert_equal [], q.sort_criteria end def test_set_sort_criteria_with_hash - q = Query.new + q = IssueQuery.new q.sort_criteria = {'0' => ['priority', 'desc'], '2' => ['tracker']} assert_equal [['priority', 'desc'], ['tracker', 'asc']], q.sort_criteria end def test_set_sort_criteria_with_array - q = Query.new + q = IssueQuery.new q.sort_criteria = [['priority', 'desc'], 'tracker'] assert_equal [['priority', 'desc'], ['tracker', 'asc']], q.sort_criteria end def test_create_query_with_sort - q = Query.new(:name => 'Sorted') + q = IssueQuery.new(:name => 'Sorted') q.sort_criteria = [['priority', 'desc'], 'tracker'] assert q.save q.reload @@ -873,53 +910,47 @@ end def test_sort_by_string_custom_field_asc - q = Query.new + q = IssueQuery.new c = q.available_columns.find {|col| col.is_a?(QueryCustomFieldColumn) && col.custom_field.field_format == 'string' } assert c assert c.sortable - issues = Issue.includes([:assigned_to, :status, :tracker, :project, :priority]).where( - q.statement - ).order("#{c.sortable} ASC").all + issues = q.issues(:order => "#{c.sortable} ASC") values = issues.collect {|i| i.custom_value_for(c.custom_field).to_s} assert !values.empty? assert_equal values.sort, values end def test_sort_by_string_custom_field_desc - q = Query.new + q = IssueQuery.new c = q.available_columns.find {|col| col.is_a?(QueryCustomFieldColumn) && col.custom_field.field_format == 'string' } assert c assert c.sortable - issues = Issue.includes([:assigned_to, :status, :tracker, :project, :priority]).where( - q.statement - ).order("#{c.sortable} DESC").all + issues = q.issues(:order => "#{c.sortable} DESC") values = issues.collect {|i| i.custom_value_for(c.custom_field).to_s} assert !values.empty? assert_equal values.sort.reverse, values end def test_sort_by_float_custom_field_asc - q = Query.new + q = IssueQuery.new c = q.available_columns.find {|col| col.is_a?(QueryCustomFieldColumn) && col.custom_field.field_format == 'float' } assert c assert c.sortable - issues = Issue.includes([:assigned_to, :status, :tracker, :project, :priority]).where( - q.statement - ).order("#{c.sortable} ASC").all + issues = q.issues(:order => "#{c.sortable} ASC") values = issues.collect {|i| begin; Kernel.Float(i.custom_value_for(c.custom_field).to_s); rescue; nil; end}.compact assert !values.empty? assert_equal values.sort, values end def test_invalid_query_should_raise_query_statement_invalid_error - q = Query.new + q = IssueQuery.new assert_raise Query::StatementInvalid do q.issues(:conditions => "foo = 1") end end def test_issue_count - q = Query.new(:name => '_') + q = IssueQuery.new(:name => '_') issue_count = q.issue_count assert_equal q.issues.size, issue_count end @@ -935,7 +966,7 @@ end def test_issue_count_by_association_group - q = Query.new(:name => '_', :group_by => 'assigned_to') + q = IssueQuery.new(:name => '_', :group_by => 'assigned_to') count_by_group = q.issue_count_by_group assert_kind_of Hash, count_by_group assert_equal %w(NilClass User), count_by_group.keys.collect {|k| k.class.name}.uniq.sort @@ -944,7 +975,7 @@ end def test_issue_count_by_list_custom_field_group - q = Query.new(:name => '_', :group_by => 'cf_1') + q = IssueQuery.new(:name => '_', :group_by => 'cf_1') count_by_group = q.issue_count_by_group assert_kind_of Hash, count_by_group assert_equal %w(NilClass String), count_by_group.keys.collect {|k| k.class.name}.uniq.sort @@ -953,7 +984,7 @@ end def test_issue_count_by_date_custom_field_group - q = Query.new(:name => '_', :group_by => 'cf_8') + q = IssueQuery.new(:name => '_', :group_by => 'cf_8') count_by_group = q.issue_count_by_group assert_kind_of Hash, count_by_group assert_equal %w(Date NilClass), count_by_group.keys.collect {|k| k.class.name}.uniq.sort @@ -963,7 +994,7 @@ def test_issue_count_with_nil_group_only Issue.update_all("assigned_to_id = NULL") - q = Query.new(:name => '_', :group_by => 'assigned_to') + q = IssueQuery.new(:name => '_', :group_by => 'assigned_to') count_by_group = q.issue_count_by_group assert_kind_of Hash, count_by_group assert_equal 1, count_by_group.keys.size @@ -971,7 +1002,7 @@ end def test_issue_ids - q = Query.new(:name => '_') + q = IssueQuery.new(:name => '_') order = "issues.subject, issues.id" issues = q.issues(:order => order) assert_equal issues.map(&:id), q.issue_ids(:order => order) @@ -979,13 +1010,13 @@ def test_label_for set_language_if_valid 'en' - q = Query.new + q = IssueQuery.new assert_equal 'Assignee', q.label_for('assigned_to_id') end def test_label_for_fr set_language_if_valid 'fr' - q = Query.new + q = IssueQuery.new s = "Assign\xc3\xa9 \xc3\xa0" s.force_encoding('UTF-8') if s.respond_to?(:force_encoding) assert_equal s, q.label_for('assigned_to_id') @@ -997,32 +1028,32 @@ developer = User.find(3) # Public query on project 1 - q = Query.find(1) + q = IssueQuery.find(1) assert q.editable_by?(admin) assert q.editable_by?(manager) assert !q.editable_by?(developer) # Private query on project 1 - q = Query.find(2) + q = IssueQuery.find(2) assert q.editable_by?(admin) assert !q.editable_by?(manager) assert q.editable_by?(developer) # Private query for all projects - q = Query.find(3) + q = IssueQuery.find(3) assert q.editable_by?(admin) assert !q.editable_by?(manager) assert q.editable_by?(developer) # Public query for all projects - q = Query.find(4) + q = IssueQuery.find(4) assert q.editable_by?(admin) assert !q.editable_by?(manager) assert !q.editable_by?(developer) end def test_visible_scope - query_ids = Query.visible(User.anonymous).map(&:id) + query_ids = IssueQuery.visible(User.anonymous).map(&:id) assert query_ids.include?(1), 'public query on public project was not visible' assert query_ids.include?(4), 'public query for all projects was not visible' @@ -1031,81 +1062,50 @@ assert !query_ids.include?(7), 'public query on private project was visible' end - context "#available_filters" do - setup do - @query = Query.new(:name => "_") - end + test "#available_filters should include users of visible projects in cross-project view" do + users = IssueQuery.new.available_filters["assigned_to_id"] + assert_not_nil users + assert users[:values].map{|u|u[1]}.include?("3") + end - should "include users of visible projects in cross-project view" do - users = @query.available_filters["assigned_to_id"] - assert_not_nil users - assert users[:values].map{|u|u[1]}.include?("3") - end + test "#available_filters should include users of subprojects" do + user1 = User.generate! + user2 = User.generate! + project = Project.find(1) + Member.create!(:principal => user1, :project => project.children.visible.first, :role_ids => [1]) - should "include users of subprojects" do - user1 = User.generate! - user2 = User.generate! - project = Project.find(1) - Member.create!(:principal => user1, :project => project.children.visible.first, :role_ids => [1]) - @query.project = project + users = IssueQuery.new(:project => project).available_filters["assigned_to_id"] + assert_not_nil users + assert users[:values].map{|u|u[1]}.include?(user1.id.to_s) + assert !users[:values].map{|u|u[1]}.include?(user2.id.to_s) + end - users = @query.available_filters["assigned_to_id"] - assert_not_nil users - assert users[:values].map{|u|u[1]}.include?(user1.id.to_s) - assert !users[:values].map{|u|u[1]}.include?(user2.id.to_s) - end + test "#available_filters should include visible projects in cross-project view" do + projects = IssueQuery.new.available_filters["project_id"] + assert_not_nil projects + assert projects[:values].map{|u|u[1]}.include?("1") + end - should "include visible projects in cross-project view" do - projects = @query.available_filters["project_id"] - assert_not_nil projects - assert projects[:values].map{|u|u[1]}.include?("1") - end + test "#available_filters should include 'member_of_group' filter" do + query = IssueQuery.new + assert query.available_filters.keys.include?("member_of_group") + assert_equal :list_optional, query.available_filters["member_of_group"][:type] + assert query.available_filters["member_of_group"][:values].present? + assert_equal Group.all.sort.map {|g| [g.name, g.id.to_s]}, + query.available_filters["member_of_group"][:values].sort + end - context "'member_of_group' filter" do - should "be present" do - assert @query.available_filters.keys.include?("member_of_group") - end + test "#available_filters should include 'assigned_to_role' filter" do + query = IssueQuery.new + assert query.available_filters.keys.include?("assigned_to_role") + assert_equal :list_optional, query.available_filters["assigned_to_role"][:type] - should "be an optional list" do - assert_equal :list_optional, @query.available_filters["member_of_group"][:type] - end + assert query.available_filters["assigned_to_role"][:values].include?(['Manager','1']) + assert query.available_filters["assigned_to_role"][:values].include?(['Developer','2']) + assert query.available_filters["assigned_to_role"][:values].include?(['Reporter','3']) - should "have a list of the groups as values" do - Group.destroy_all # No fixtures - group1 = Group.generate!.reload - group2 = Group.generate!.reload - - expected_group_list = [ - [group1.name, group1.id.to_s], - [group2.name, group2.id.to_s] - ] - assert_equal expected_group_list.sort, @query.available_filters["member_of_group"][:values].sort - end - - end - - context "'assigned_to_role' filter" do - should "be present" do - assert @query.available_filters.keys.include?("assigned_to_role") - end - - should "be an optional list" do - assert_equal :list_optional, @query.available_filters["assigned_to_role"][:type] - end - - should "have a list of the Roles as values" do - assert @query.available_filters["assigned_to_role"][:values].include?(['Manager','1']) - assert @query.available_filters["assigned_to_role"][:values].include?(['Developer','2']) - assert @query.available_filters["assigned_to_role"][:values].include?(['Reporter','3']) - end - - should "not include the built in Roles as values" do - assert ! @query.available_filters["assigned_to_role"][:values].include?(['Non member','4']) - assert ! @query.available_filters["assigned_to_role"][:values].include?(['Anonymous','5']) - end - - end - + assert ! query.available_filters["assigned_to_role"][:values].include?(['Non member','4']) + assert ! query.available_filters["assigned_to_role"][:values].include?(['Anonymous','5']) end context "#statement" do @@ -1127,34 +1127,34 @@ end should "search assigned to for users in the group" do - @query = Query.new(:name => '_') + @query = IssueQuery.new(:name => '_') @query.add_filter('member_of_group', '=', [@group.id.to_s]) - assert_query_statement_includes @query, "#{Issue.table_name}.assigned_to_id IN ('#{@user_in_group.id}','#{@second_user_in_group.id}')" + assert_query_statement_includes @query, "#{Issue.table_name}.assigned_to_id IN ('#{@user_in_group.id}','#{@second_user_in_group.id}','#{@group.id}')" assert_find_issues_with_query_is_successful @query end should "search not assigned to any group member (none)" do - @query = Query.new(:name => '_') + @query = IssueQuery.new(:name => '_') @query.add_filter('member_of_group', '!*', ['']) # Users not in a group - assert_query_statement_includes @query, "#{Issue.table_name}.assigned_to_id IS NULL OR #{Issue.table_name}.assigned_to_id NOT IN ('#{@user_in_group.id}','#{@second_user_in_group.id}','#{@user_in_group2.id}')" + assert_query_statement_includes @query, "#{Issue.table_name}.assigned_to_id IS NULL OR #{Issue.table_name}.assigned_to_id NOT IN ('#{@user_in_group.id}','#{@second_user_in_group.id}','#{@user_in_group2.id}','#{@group.id}','#{@group2.id}')" assert_find_issues_with_query_is_successful @query end should "search assigned to any group member (all)" do - @query = Query.new(:name => '_') + @query = IssueQuery.new(:name => '_') @query.add_filter('member_of_group', '*', ['']) # Only users in a group - assert_query_statement_includes @query, "#{Issue.table_name}.assigned_to_id IN ('#{@user_in_group.id}','#{@second_user_in_group.id}','#{@user_in_group2.id}')" + assert_query_statement_includes @query, "#{Issue.table_name}.assigned_to_id IN ('#{@user_in_group.id}','#{@second_user_in_group.id}','#{@user_in_group2.id}','#{@group.id}','#{@group2.id}')" assert_find_issues_with_query_is_successful @query end should "return an empty set with = empty group" do @empty_group = Group.generate! - @query = Query.new(:name => '_') + @query = IssueQuery.new(:name => '_') @query.add_filter('member_of_group', '=', [@empty_group.id.to_s]) assert_equal [], find_issues_with_query(@query) @@ -1162,7 +1162,7 @@ should "return issues with ! empty group" do @empty_group = Group.generate! - @query = Query.new(:name => '_') + @query = IssueQuery.new(:name => '_') @query.add_filter('member_of_group', '!', [@empty_group.id.to_s]) assert_find_issues_with_query_is_successful @query @@ -1191,7 +1191,7 @@ end should "search assigned to for users with the Role" do - @query = Query.new(:name => '_', :project => @project) + @query = IssueQuery.new(:name => '_', :project => @project) @query.add_filter('assigned_to_role', '=', [@manager_role.id.to_s]) assert_query_result [@issue1, @issue3], @query @@ -1201,7 +1201,7 @@ other_project = Project.generate! User.add_to_project(@developer, other_project, @manager_role) - @query = Query.new(:name => '_', :project => @project) + @query = IssueQuery.new(:name => '_', :project => @project) @query.add_filter('assigned_to_role', '=', [@manager_role.id.to_s]) assert_query_result [@issue1, @issue3], @query @@ -1209,28 +1209,28 @@ should "return an empty set with empty role" do @empty_role = Role.generate! - @query = Query.new(:name => '_', :project => @project) + @query = IssueQuery.new(:name => '_', :project => @project) @query.add_filter('assigned_to_role', '=', [@empty_role.id.to_s]) assert_query_result [], @query end should "search assigned to for users without the Role" do - @query = Query.new(:name => '_', :project => @project) + @query = IssueQuery.new(:name => '_', :project => @project) @query.add_filter('assigned_to_role', '!', [@manager_role.id.to_s]) assert_query_result [@issue2, @issue4, @issue5], @query end should "search assigned to for users not assigned to any Role (none)" do - @query = Query.new(:name => '_', :project => @project) + @query = IssueQuery.new(:name => '_', :project => @project) @query.add_filter('assigned_to_role', '!*', ['']) assert_query_result [@issue4, @issue5], @query end should "search assigned to for users assigned to any Role (all)" do - @query = Query.new(:name => '_', :project => @project) + @query = IssueQuery.new(:name => '_', :project => @project) @query.add_filter('assigned_to_role', '*', ['']) assert_query_result [@issue1, @issue2, @issue3], @query @@ -1238,12 +1238,11 @@ should "return issues with ! empty role" do @empty_role = Role.generate! - @query = Query.new(:name => '_', :project => @project) + @query = IssueQuery.new(:name => '_', :project => @project) @query.add_filter('assigned_to_role', '!', [@empty_role.id.to_s]) assert_query_result [@issue1, @issue2, @issue3, @issue4, @issue5], @query end end end - end