diff test/integration/api_test/attachments_test.rb @ 1115:433d4f72a19b redmine-2.2

Update to Redmine SVN revision 11137 on 2.2-stable branch

--- a/test/integration/api_test/attachments_test.rb	Wed Jun 27 14:54:18 2012 +0100
+++ b/test/integration/api_test/attachments_test.rb	Mon Jan 07 12:01:42 2013 +0000
@@ -1,5 +1,5 @@
 # Redmine - project management software
-# Copyright (C) 2006-2011  Jean-Philippe Lang
+# Copyright (C) 2006-2012  Jean-Philippe Lang
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -30,57 +30,121 @@
 
   def setup
     Setting.rest_api_enabled = '1'
-    Attachment.storage_path = "#{Rails.root}/test/fixtures/files"
+    set_fixtures_attachments_directory
   end
 
-  context "/attachments/:id" do
-    context "GET" do
-      should "return the attachment" do
-        get '/attachments/7.xml', {}, :authorization => credentials('jsmith')
-        assert_response :success
-        assert_equal 'application/xml', @response.content_type
-        assert_tag :tag => 'attachment',
-          :child => {
-            :tag => 'id',
-            :content => '7',
-            :sibling => {
-              :tag => 'filename',
-              :content => 'archive.zip',
-              :sibling => {
-                :tag => 'content_url',
-                :content => 'http://www.example.com/attachments/download/7/archive.zip'
-              }
-            }
+  def teardown
+    set_tmp_attachments_directory
+  end
+
+  test "GET /attachments/:id.xml should return the attachment" do
+    get '/attachments/7.xml', {}, credentials('jsmith')
+    assert_response :success
+    assert_equal 'application/xml', @response.content_type
+    assert_tag :tag => 'attachment',
+      :child => {
+        :tag => 'id',
+        :content => '7',
+        :sibling => {
+          :tag => 'filename',
+          :content => 'archive.zip',
+          :sibling => {
+            :tag => 'content_url',
+            :content => 'http://www.example.com/attachments/download/7/archive.zip'
           }
-      end
+        }
+      }
+  end
 
-      should "deny access without credentials" do
-        get '/attachments/7.xml'
-        assert_response 401
-        set_tmp_attachments_directory
+  test "GET /attachments/:id.xml should deny access without credentials" do
+    get '/attachments/7.xml'
+    assert_response 401
+    set_tmp_attachments_directory
+  end
+
+  test "GET /attachments/download/:id/:filename should return the attachment content" do
+    get '/attachments/download/7/archive.zip', {}, credentials('jsmith')
+    assert_response :success
+    assert_equal 'application/octet-stream', @response.content_type
+    set_tmp_attachments_directory
+  end
+
+  test "GET /attachments/download/:id/:filename should deny access without credentials" do
+    get '/attachments/download/7/archive.zip'
+    assert_response 302
+    set_tmp_attachments_directory
+  end
+
+  test "POST /uploads.xml should return the token" do
+    set_tmp_attachments_directory
+    assert_difference 'Attachment.count' do
+      post '/uploads.xml', 'File content', {"CONTENT_TYPE" => 'application/octet-stream'}.merge(credentials('jsmith'))
+      assert_response :created
+      assert_equal 'application/xml', response.content_type
+    end
+
+    xml = Hash.from_xml(response.body)
+    assert_kind_of Hash, xml['upload']
+    token = xml['upload']['token']
+    assert_not_nil token
+
+    attachment = Attachment.first(:order => 'id DESC')
+    assert_equal token, attachment.token
+    assert_nil attachment.container
+    assert_equal 2, attachment.author_id
+    assert_equal 'File content'.size, attachment.filesize
+    assert attachment.content_type.blank?
+    assert attachment.filename.present?
+    assert_match /\d+_[0-9a-z]+/, attachment.diskfile
+    assert File.exist?(attachment.diskfile)
+    assert_equal 'File content', File.read(attachment.diskfile)
+  end
+
+  test "POST /uploads.json should return the token" do
+    set_tmp_attachments_directory
+    assert_difference 'Attachment.count' do
+      post '/uploads.json', 'File content', {"CONTENT_TYPE" => 'application/octet-stream'}.merge(credentials('jsmith'))
+      assert_response :created
+      assert_equal 'application/json', response.content_type
+    end
+
+    json = ActiveSupport::JSON.decode(response.body)
+    assert_kind_of Hash, json['upload']
+    token = json['upload']['token']
+    assert_not_nil token
+
+    attachment = Attachment.first(:order => 'id DESC')
+    assert_equal token, attachment.token
+  end
+
+  test "POST /uploads.xml should accept :filename param as the attachment filename" do
+    set_tmp_attachments_directory
+    assert_difference 'Attachment.count' do
+      post '/uploads.xml?filename=test.txt', 'File content', {"CONTENT_TYPE" => 'application/octet-stream'}.merge(credentials('jsmith'))
+      assert_response :created
+    end
+
+    attachment = Attachment.order('id DESC').first
+    assert_equal 'test.txt', attachment.filename
+    assert_match /_test\.txt$/, attachment.diskfile
+  end
+
+  test "POST /uploads.xml should not accept other content types" do
+    set_tmp_attachments_directory
+    assert_no_difference 'Attachment.count' do
+      post '/uploads.xml', 'PNG DATA', {"CONTENT_TYPE" => 'image/png'}.merge(credentials('jsmith'))
+      assert_response 406
+    end
+  end
+
+  test "POST /uploads.xml should return errors if file is too big" do
+    set_tmp_attachments_directory
+    with_settings :attachment_max_size => 1 do
+      assert_no_difference 'Attachment.count' do
+        post '/uploads.xml', ('x' * 2048), {"CONTENT_TYPE" => 'application/octet-stream'}.merge(credentials('jsmith'))
+        assert_response 422
+        assert_tag 'error', :content => /exceeds the maximum allowed file size/
       end
     end
   end
-
-  context "/attachments/download/:id/:filename" do
-    context "GET" do
-      should "return the attachment content" do
-        get '/attachments/download/7/archive.zip',
-            {}, :authorization => credentials('jsmith')
-        assert_response :success
-        assert_equal 'application/octet-stream', @response.content_type
-        set_tmp_attachments_directory
-      end
-
-      should "deny access without credentials" do
-        get '/attachments/download/7/archive.zip'
-        assert_response 302
-        set_tmp_attachments_directory
-      end
-    end
-  end
-
-  def credentials(user, password=nil)
-    ActionController::HttpAuthentication::Basic.encode_credentials(user, password || user)
-  end
 end