diff test/integration/api_test/memberships_test.rb @ 1526:404aa68d4227

Merge from live branch

--- a/test/integration/api_test/memberships_test.rb	Mon Mar 17 08:57:04 2014 +0000
+++ b/test/integration/api_test/memberships_test.rb	Thu Sep 11 12:46:20 2014 +0100
@@ -1,5 +1,5 @@
 # Redmine - project management software
-# Copyright (C) 2006-2012  Jean-Philippe Lang
+# Copyright (C) 2006-2014  Jean-Philippe Lang
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -17,184 +17,164 @@
 
 require File.expand_path('../../../test_helper', __FILE__)
 
-class ApiTest::MembershipsTest < ActionController::IntegrationTest
+class Redmine::ApiTest::MembershipsTest < Redmine::ApiTest::Base
   fixtures :projects, :users, :roles, :members, :member_roles
 
   def setup
     Setting.rest_api_enabled = '1'
   end
 
-  context "/projects/:project_id/memberships" do
-    context "GET" do
-      context "xml" do
-        should "return memberships" do
-          get '/projects/1/memberships.xml', {}, credentials('jsmith')
+  test "GET /projects/:project_id/memberships.xml should return memberships" do
+    get '/projects/1/memberships.xml', {}, credentials('jsmith')
 
-          assert_response :success
-          assert_equal 'application/xml', @response.content_type
-          assert_tag :tag => 'memberships',
-            :attributes => {:type => 'array'},
-            :child => {
-              :tag => 'membership',
+    assert_response :success
+    assert_equal 'application/xml', @response.content_type
+    assert_tag :tag => 'memberships',
+      :attributes => {:type => 'array'},
+      :child => {
+        :tag => 'membership',
+        :child => {
+          :tag => 'id',
+          :content => '2',
+          :sibling => {
+            :tag => 'user',
+            :attributes => {:id => '3', :name => 'Dave Lopper'},
+            :sibling => {
+              :tag => 'roles',
               :child => {
-                :tag => 'id',
-                :content => '2',
-                :sibling => {
-                  :tag => 'user',
-                  :attributes => {:id => '3', :name => 'Dave Lopper'},
-                  :sibling => {
-                    :tag => 'roles',
-                    :child => {
-                      :tag => 'role',
-                      :attributes => {:id => '2', :name => 'Developer'}
-                    }
-                  }
-                }
+                :tag => 'role',
+                :attributes => {:id => '2', :name => 'Developer'}
               }
             }
-        end
-      end
+          }
+        }
+      }
+  end
 
-      context "json" do
-        should "return memberships" do
-          get '/projects/1/memberships.json', {}, credentials('jsmith')
+  test "GET /projects/:project_id/memberships.json should return memberships" do
+    get '/projects/1/memberships.json', {}, credentials('jsmith')
 
-          assert_response :success
-          assert_equal 'application/json', @response.content_type
-          json = ActiveSupport::JSON.decode(response.body)
-          assert_equal({
-            "memberships" =>
-              [{"id"=>1,
-                "project" => {"name"=>"eCookbook", "id"=>1},
-                "roles" => [{"name"=>"Manager", "id"=>1}],
-                "user" => {"name"=>"John Smith", "id"=>2}},
-               {"id"=>2,
-                "project" => {"name"=>"eCookbook", "id"=>1},
-                "roles" => [{"name"=>"Developer", "id"=>2}],
-                "user" => {"name"=>"Dave Lopper", "id"=>3}}],
-           "limit" => 25,
-           "total_count" => 2,
-           "offset" => 0},
-           json)
-        end
-      end
-    end
+    assert_response :success
+    assert_equal 'application/json', @response.content_type
+    json = ActiveSupport::JSON.decode(response.body)
+    assert_equal({
+      "memberships" =>
+        [{"id"=>1,
+          "project" => {"name"=>"eCookbook", "id"=>1},
+          "roles" => [{"name"=>"Manager", "id"=>1}],
+          "user" => {"name"=>"John Smith", "id"=>2}},
+         {"id"=>2,
+          "project" => {"name"=>"eCookbook", "id"=>1},
+          "roles" => [{"name"=>"Developer", "id"=>2}],
+          "user" => {"name"=>"Dave Lopper", "id"=>3}}],
+     "limit" => 25,
+     "total_count" => 2,
+     "offset" => 0},
+     json)
+  end
 
-    context "POST" do
-      context "xml" do
-        should "create membership" do
-          assert_difference 'Member.count' do
-            post '/projects/1/memberships.xml', {:membership => {:user_id => 7, :role_ids => [2,3]}}, credentials('jsmith')
+  test "GET /projects/:project_id/memberships.xml should succeed for closed project" do
+    project = Project.find(1)
+    project.close
+    assert !project.reload.active?
+    get '/projects/1/memberships.json', {}, credentials('jsmith')
+    assert_response :success
+  end
 
-            assert_response :created
-          end
-        end
+  test "POST /projects/:project_id/memberships.xml should create the membership" do
+    assert_difference 'Member.count' do
+      post '/projects/1/memberships.xml', {:membership => {:user_id => 7, :role_ids => [2,3]}}, credentials('jsmith')
 
-        should "return errors on failure" do
-          assert_no_difference 'Member.count' do
-            post '/projects/1/memberships.xml', {:membership => {:role_ids => [2,3]}}, credentials('jsmith')
-
-            assert_response :unprocessable_entity
-            assert_equal 'application/xml', @response.content_type
-            assert_tag 'errors', :child => {:tag => 'error', :content => "Principal can't be blank"}
-          end
-        end
-      end
+      assert_response :created
     end
   end
 
-  context "/memberships/:id" do
-    context "GET" do
-      context "xml" do
-        should "return the membership" do
-          get '/memberships/2.xml', {}, credentials('jsmith')
+  test "POST /projects/:project_id/memberships.xml with invalid parameters should return errors" do
+    assert_no_difference 'Member.count' do
+      post '/projects/1/memberships.xml', {:membership => {:role_ids => [2,3]}}, credentials('jsmith')
 
-          assert_response :success
-          assert_equal 'application/xml', @response.content_type
-          assert_tag :tag => 'membership',
+      assert_response :unprocessable_entity
+      assert_equal 'application/xml', @response.content_type
+      assert_tag 'errors', :child => {:tag => 'error', :content => "Principal can't be blank"}
+    end
+  end
+
+  test "GET /memberships/:id.xml should return the membership" do
+    get '/memberships/2.xml', {}, credentials('jsmith')
+
+    assert_response :success
+    assert_equal 'application/xml', @response.content_type
+    assert_tag :tag => 'membership',
+      :child => {
+        :tag => 'id',
+        :content => '2',
+        :sibling => {
+          :tag => 'user',
+          :attributes => {:id => '3', :name => 'Dave Lopper'},
+          :sibling => {
+            :tag => 'roles',
             :child => {
-              :tag => 'id',
-              :content => '2',
-              :sibling => {
-                :tag => 'user',
-                :attributes => {:id => '3', :name => 'Dave Lopper'},
-                :sibling => {
-                  :tag => 'roles',
-                  :child => {
-                    :tag => 'role',
-                    :attributes => {:id => '2', :name => 'Developer'}
-                  }
-                }
-              }
+              :tag => 'role',
+              :attributes => {:id => '2', :name => 'Developer'}
             }
-        end
-      end
+          }
+        }
+      }
+  end
 
-      context "json" do
-        should "return the membership" do
-          get '/memberships/2.json', {}, credentials('jsmith')
+  test "GET /memberships/:id.json should return the membership" do
+    get '/memberships/2.json', {}, credentials('jsmith')
 
-          assert_response :success
-          assert_equal 'application/json', @response.content_type
-          json = ActiveSupport::JSON.decode(response.body)
-          assert_equal(
-            {"membership" => {
-              "id" => 2,
-              "project" => {"name"=>"eCookbook", "id"=>1},
-              "roles" => [{"name"=>"Developer", "id"=>2}],
-              "user" => {"name"=>"Dave Lopper", "id"=>3}}
-            },
-            json)
-        end
-      end
+    assert_response :success
+    assert_equal 'application/json', @response.content_type
+    json = ActiveSupport::JSON.decode(response.body)
+    assert_equal(
+      {"membership" => {
+        "id" => 2,
+        "project" => {"name"=>"eCookbook", "id"=>1},
+        "roles" => [{"name"=>"Developer", "id"=>2}],
+        "user" => {"name"=>"Dave Lopper", "id"=>3}}
+      },
+      json)
+  end
+
+  test "PUT /memberships/:id.xml should update the membership" do
+    assert_not_equal [1,2], Member.find(2).role_ids.sort
+    assert_no_difference 'Member.count' do
+      put '/memberships/2.xml', {:membership => {:user_id => 3, :role_ids => [1,2]}}, credentials('jsmith')
+
+      assert_response :ok
+      assert_equal '', @response.body
     end
+    member = Member.find(2)
+    assert_equal [1,2], member.role_ids.sort
+  end
 
-    context "PUT" do
-      context "xml" do
-        should "update membership" do
-          assert_not_equal [1,2], Member.find(2).role_ids.sort
-          assert_no_difference 'Member.count' do
-            put '/memberships/2.xml', {:membership => {:user_id => 3, :role_ids => [1,2]}}, credentials('jsmith')
+  test "PUT /memberships/:id.xml with invalid parameters should return errors" do
+    put '/memberships/2.xml', {:membership => {:user_id => 3, :role_ids => [99]}}, credentials('jsmith')
 
-            assert_response :ok
-            assert_equal '', @response.body
-          end
-          member = Member.find(2)
-          assert_equal [1,2], member.role_ids.sort
-        end
+    assert_response :unprocessable_entity
+    assert_equal 'application/xml', @response.content_type
+    assert_tag 'errors', :child => {:tag => 'error', :content => /member_roles is invalid/}
+  end
 
-        should "return errors on failure" do
-          put '/memberships/2.xml', {:membership => {:user_id => 3, :role_ids => [99]}}, credentials('jsmith')
+  test "DELETE /memberships/:id.xml should destroy the membership" do
+    assert_difference 'Member.count', -1 do
+      delete '/memberships/2.xml', {}, credentials('jsmith')
 
-          assert_response :unprocessable_entity
-          assert_equal 'application/xml', @response.content_type
-          assert_tag 'errors', :child => {:tag => 'error', :content => /member_roles is invalid/}
-        end
-      end
+      assert_response :ok
+      assert_equal '', @response.body
     end
+    assert_nil Member.find_by_id(2)
+  end
 
-    context "DELETE" do
-      context "xml" do
-        should "destroy membership" do
-          assert_difference 'Member.count', -1 do
-            delete '/memberships/2.xml', {}, credentials('jsmith')
+  test "DELETE /memberships/:id.xml should respond with 422 on failure" do
+    assert_no_difference 'Member.count' do
+      # A membership with an inherited role can't be deleted
+      Member.find(2).member_roles.first.update_attribute :inherited_from, 99
+      delete '/memberships/2.xml', {}, credentials('jsmith')
 
-            assert_response :ok
-            assert_equal '', @response.body
-          end
-          assert_nil Member.find_by_id(2)
-        end
-
-        should "respond with 422 on failure" do
-          assert_no_difference 'Member.count' do
-            # A membership with an inherited role can't be deleted
-            Member.find(2).member_roles.first.update_attribute :inherited_from, 99
-            delete '/memberships/2.xml', {}, credentials('jsmith')
-
-            assert_response :unprocessable_entity
-          end
-        end
-      end
+      assert_response :unprocessable_entity
     end
   end
 end