comparison app/models/issue_query.rb @ 1517:dffacf8a6908 redmine-2.5

Update to Redmine SVN revision 13367 on 2.5-stable branch

       issue_custom_fields = project.all_issue_custom_fields
     else
       if all_projects.any?
         principals += Principal.member_of(all_projects)
       end
-      versions = Version.visible.find_all_by_sharing('system')
+      versions = Version.visible.where(:sharing => 'system').all
       issue_custom_fields = IssueCustomField.where(:is_for_all => true)
     end
     principals.uniq!
     principals.sort!
     users = principals.select {|p| p.is_a?(User)}
 
     add_available_filter "status_id",
-      :type => :list_status, :values => IssueStatus.sorted.all.collect{|s| [s.name, s.id.to_s] }
+      :type => :list_status, :values => IssueStatus.sorted.collect{|s| [s.name, s.id.to_s] }
 
     if project.nil?
       project_values = []
       if User.current.logged? && User.current.memberships.any?
         project_values << ["<< #{l(:label_my_projects).downcase} >>", "mine"]

       order(order_option).
       joins(joins_for_order_statement(order_option.join(','))).
       limit(options[:limit]).
       offset(options[:offset])
 
-    if has_custom_field_column?
-      scope = scope.preload(:custom_values)
+    scope = scope.preload(:custom_values)
+    if has_column?(:author)
+      scope = scope.preload(:author)
     end
 
     issues = scope.all
 
     if has_column?(:spent_hours)

       operator = '=' # Override the operator since we want to find by assigned_to
     elsif operator == "!*"
       groups = Group.all
       operator = '!' # Override the operator since we want to find by assigned_to
     else
-      groups = Group.find_all_by_id(value)
+      groups = Group.where(:id => value).all
     end
     groups ||= []
 
     members_of_groups = groups.inject([]) {|user_ids, group|
       user_ids + group.user_ids + [group.id]