comparison .svn/pristine/e4/e4d010d3b6164a54f0034d95f4b23cdc28bbe4ec.svn-base @ 1295:622f24f53b42 redmine-2.3

Update to Redmine SVN revision 11972 on 2.3-stable branch
author Chris Cannam
date Fri, 14 Jun 2013 09:02:21 +0100
parents
children
comparison
equal deleted inserted replaced
1294:3e4c3460b6ca 1295:622f24f53b42
1 # Redmine - project management software
2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 #
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
8 #
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
13 #
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
18 require File.expand_path('../../test_helper', __FILE__)
19 require 'issues_controller'
20
21 class IssuesControllerTest < ActionController::TestCase
22 fixtures :projects,
23 :users,
24 :roles,
25 :members,
26 :member_roles,
27 :issues,
28 :issue_statuses,
29 :versions,
30 :trackers,
31 :projects_trackers,
32 :issue_categories,
33 :enabled_modules,
34 :enumerations,
35 :attachments,
36 :workflows,
37 :custom_fields,
38 :custom_values,
39 :custom_fields_projects,
40 :custom_fields_trackers,
41 :time_entries,
42 :journals,
43 :journal_details,
44 :queries,
45 :repositories,
46 :changesets
47
48 include Redmine::I18n
49
50 def setup
51 @controller = IssuesController.new
52 @request = ActionController::TestRequest.new
53 @response = ActionController::TestResponse.new
54 User.current = nil
55 end
56
57 def test_index
58 with_settings :default_language => "en" do
59 get :index
60 assert_response :success
61 assert_template 'index'
62 assert_not_nil assigns(:issues)
63 assert_nil assigns(:project)
64
65 # links to visible issues
66 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
67 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
68 # private projects hidden
69 assert_select 'a[href=/issues/6]', 0
70 assert_select 'a[href=/issues/4]', 0
71 # project column
72 assert_select 'th', :text => /Project/
73 end
74 end
75
76 def test_index_should_not_list_issues_when_module_disabled
77 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
78 get :index
79 assert_response :success
80 assert_template 'index'
81 assert_not_nil assigns(:issues)
82 assert_nil assigns(:project)
83
84 assert_select 'a[href=/issues/1]', 0
85 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
86 end
87
88 def test_index_should_list_visible_issues_only
89 get :index, :per_page => 100
90 assert_response :success
91 assert_not_nil assigns(:issues)
92 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
93 end
94
95 def test_index_with_project
96 Setting.display_subprojects_issues = 0
97 get :index, :project_id => 1
98 assert_response :success
99 assert_template 'index'
100 assert_not_nil assigns(:issues)
101
102 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
103 assert_select 'a[href=/issues/5]', 0
104 end
105
106 def test_index_with_project_and_subprojects
107 Setting.display_subprojects_issues = 1
108 get :index, :project_id => 1
109 assert_response :success
110 assert_template 'index'
111 assert_not_nil assigns(:issues)
112
113 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
114 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
115 assert_select 'a[href=/issues/6]', 0
116 end
117
118 def test_index_with_project_and_subprojects_should_show_private_subprojects_with_permission
119 @request.session[:user_id] = 2
120 Setting.display_subprojects_issues = 1
121 get :index, :project_id => 1
122 assert_response :success
123 assert_template 'index'
124 assert_not_nil assigns(:issues)
125
126 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
127 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
128 assert_select 'a[href=/issues/6]', :text => /Issue of a private subproject/
129 end
130
131 def test_index_with_project_and_default_filter
132 get :index, :project_id => 1, :set_filter => 1
133 assert_response :success
134 assert_template 'index'
135 assert_not_nil assigns(:issues)
136
137 query = assigns(:query)
138 assert_not_nil query
139 # default filter
140 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
141 end
142
143 def test_index_with_project_and_filter
144 get :index, :project_id => 1, :set_filter => 1,
145 :f => ['tracker_id'],
146 :op => {'tracker_id' => '='},
147 :v => {'tracker_id' => ['1']}
148 assert_response :success
149 assert_template 'index'
150 assert_not_nil assigns(:issues)
151
152 query = assigns(:query)
153 assert_not_nil query
154 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
155 end
156
157 def test_index_with_short_filters
158 to_test = {
159 'status_id' => {
160 'o' => { :op => 'o', :values => [''] },
161 'c' => { :op => 'c', :values => [''] },
162 '7' => { :op => '=', :values => ['7'] },
163 '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
164 '=7' => { :op => '=', :values => ['7'] },
165 '!3' => { :op => '!', :values => ['3'] },
166 '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
167 'subject' => {
168 'This is a subject' => { :op => '=', :values => ['This is a subject'] },
169 'o' => { :op => '=', :values => ['o'] },
170 '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
171 '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
172 'tracker_id' => {
173 '3' => { :op => '=', :values => ['3'] },
174 '=3' => { :op => '=', :values => ['3'] }},
175 'start_date' => {
176 '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
177 '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
178 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
179 '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
180 '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
181 '<t+2' => { :op => '<t+', :values => ['2'] },
182 '>t+2' => { :op => '>t+', :values => ['2'] },
183 't+2' => { :op => 't+', :values => ['2'] },
184 't' => { :op => 't', :values => [''] },
185 'w' => { :op => 'w', :values => [''] },
186 '>t-2' => { :op => '>t-', :values => ['2'] },
187 '<t-2' => { :op => '<t-', :values => ['2'] },
188 't-2' => { :op => 't-', :values => ['2'] }},
189 'created_on' => {
190 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
191 '<t-2' => { :op => '<t-', :values => ['2'] },
192 '>t-2' => { :op => '>t-', :values => ['2'] },
193 't-2' => { :op => 't-', :values => ['2'] }},
194 'cf_1' => {
195 'c' => { :op => '=', :values => ['c'] },
196 '!c' => { :op => '!', :values => ['c'] },
197 '!*' => { :op => '!*', :values => [''] },
198 '*' => { :op => '*', :values => [''] }},
199 'estimated_hours' => {
200 '=13.4' => { :op => '=', :values => ['13.4'] },
201 '>=45' => { :op => '>=', :values => ['45'] },
202 '<=125' => { :op => '<=', :values => ['125'] },
203 '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
204 '!*' => { :op => '!*', :values => [''] },
205 '*' => { :op => '*', :values => [''] }}
206 }
207
208 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
209
210 to_test.each do |field, expression_and_expected|
211 expression_and_expected.each do |filter_expression, expected|
212
213 get :index, :set_filter => 1, field => filter_expression
214
215 assert_response :success
216 assert_template 'index'
217 assert_not_nil assigns(:issues)
218
219 query = assigns(:query)
220 assert_not_nil query
221 assert query.has_filter?(field)
222 assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
223 end
224 end
225 end
226
227 def test_index_with_project_and_empty_filters
228 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
229 assert_response :success
230 assert_template 'index'
231 assert_not_nil assigns(:issues)
232
233 query = assigns(:query)
234 assert_not_nil query
235 # no filter
236 assert_equal({}, query.filters)
237 end
238
239 def test_index_with_project_custom_field_filter
240 field = ProjectCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
241 CustomValue.create!(:custom_field => field, :customized => Project.find(3), :value => 'Foo')
242 CustomValue.create!(:custom_field => field, :customized => Project.find(5), :value => 'Foo')
243 filter_name = "project.cf_#{field.id}"
244 @request.session[:user_id] = 1
245
246 get :index, :set_filter => 1,
247 :f => [filter_name],
248 :op => {filter_name => '='},
249 :v => {filter_name => ['Foo']}
250 assert_response :success
251 assert_template 'index'
252 assert_equal [3, 5], assigns(:issues).map(&:project_id).uniq.sort
253 end
254
255 def test_index_with_query
256 get :index, :project_id => 1, :query_id => 5
257 assert_response :success
258 assert_template 'index'
259 assert_not_nil assigns(:issues)
260 assert_nil assigns(:issue_count_by_group)
261 end
262
263 def test_index_with_query_grouped_by_tracker
264 get :index, :project_id => 1, :query_id => 6
265 assert_response :success
266 assert_template 'index'
267 assert_not_nil assigns(:issues)
268 assert_not_nil assigns(:issue_count_by_group)
269 end
270
271 def test_index_with_query_grouped_by_list_custom_field
272 get :index, :project_id => 1, :query_id => 9
273 assert_response :success
274 assert_template 'index'
275 assert_not_nil assigns(:issues)
276 assert_not_nil assigns(:issue_count_by_group)
277 end
278
279 def test_index_with_query_grouped_by_user_custom_field
280 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
281 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
282 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
283 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
284 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
285
286 get :index, :project_id => 1, :set_filter => 1, :group_by => "cf_#{cf.id}"
287 assert_response :success
288
289 assert_select 'tr.group', 3
290 assert_select 'tr.group' do
291 assert_select 'a', :text => 'John Smith'
292 assert_select 'span.count', :text => '1'
293 end
294 assert_select 'tr.group' do
295 assert_select 'a', :text => 'Dave Lopper'
296 assert_select 'span.count', :text => '2'
297 end
298 end
299
300 def test_index_with_query_grouped_by_tracker
301 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
302
303 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc'
304 assert_response :success
305
306 trackers = assigns(:issues).map(&:tracker).uniq
307 assert_equal [1, 2, 3], trackers.map(&:id)
308 end
309
310 def test_index_with_query_grouped_by_tracker_in_reverse_order
311 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
312
313 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc,tracker:desc'
314 assert_response :success
315
316 trackers = assigns(:issues).map(&:tracker).uniq
317 assert_equal [3, 2, 1], trackers.map(&:id)
318 end
319
320 def test_index_with_query_id_and_project_id_should_set_session_query
321 get :index, :project_id => 1, :query_id => 4
322 assert_response :success
323 assert_kind_of Hash, session[:query]
324 assert_equal 4, session[:query][:id]
325 assert_equal 1, session[:query][:project_id]
326 end
327
328 def test_index_with_invalid_query_id_should_respond_404
329 get :index, :project_id => 1, :query_id => 999
330 assert_response 404
331 end
332
333 def test_index_with_cross_project_query_in_session_should_show_project_issues
334 q = Query.create!(:name => "test", :user_id => 2, :is_public => false, :project => nil)
335 @request.session[:query] = {:id => q.id, :project_id => 1}
336
337 with_settings :display_subprojects_issues => '0' do
338 get :index, :project_id => 1
339 end
340 assert_response :success
341 assert_not_nil assigns(:query)
342 assert_equal q.id, assigns(:query).id
343 assert_equal 1, assigns(:query).project_id
344 assert_equal [1], assigns(:issues).map(&:project_id).uniq
345 end
346
347 def test_private_query_should_not_be_available_to_other_users
348 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
349 @request.session[:user_id] = 3
350
351 get :index, :query_id => q.id
352 assert_response 403
353 end
354
355 def test_private_query_should_be_available_to_its_user
356 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
357 @request.session[:user_id] = 2
358
359 get :index, :query_id => q.id
360 assert_response :success
361 end
362
363 def test_public_query_should_be_available_to_other_users
364 q = Query.create!(:name => "private", :user => User.find(2), :is_public => true, :project => nil)
365 @request.session[:user_id] = 3
366
367 get :index, :query_id => q.id
368 assert_response :success
369 end
370
371 def test_index_should_omit_page_param_in_export_links
372 get :index, :page => 2
373 assert_response :success
374 assert_select 'a.atom[href=/issues.atom]'
375 assert_select 'a.csv[href=/issues.csv]'
376 assert_select 'a.pdf[href=/issues.pdf]'
377 assert_select 'form#csv-export-form[action=/issues.csv]'
378 end
379
380 def test_index_csv
381 get :index, :format => 'csv'
382 assert_response :success
383 assert_not_nil assigns(:issues)
384 assert_equal 'text/csv; header=present', @response.content_type
385 assert @response.body.starts_with?("#,")
386 lines = @response.body.chomp.split("\n")
387 assert_equal assigns(:query).columns.size + 1, lines[0].split(',').size
388 end
389
390 def test_index_csv_with_project
391 get :index, :project_id => 1, :format => 'csv'
392 assert_response :success
393 assert_not_nil assigns(:issues)
394 assert_equal 'text/csv; header=present', @response.content_type
395 end
396
397 def test_index_csv_with_description
398 get :index, :format => 'csv', :description => '1'
399 assert_response :success
400 assert_not_nil assigns(:issues)
401 assert_equal 'text/csv; header=present', @response.content_type
402 assert @response.body.starts_with?("#,")
403 lines = @response.body.chomp.split("\n")
404 assert_equal assigns(:query).columns.size + 2, lines[0].split(',').size
405 end
406
407 def test_index_csv_with_spent_time_column
408 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :subject => 'test_index_csv_with_spent_time_column', :author_id => 2)
409 TimeEntry.create!(:project => issue.project, :issue => issue, :hours => 7.33, :user => User.find(2), :spent_on => Date.today)
410
411 get :index, :format => 'csv', :set_filter => '1', :c => %w(subject spent_hours)
412 assert_response :success
413 assert_equal 'text/csv; header=present', @response.content_type
414 lines = @response.body.chomp.split("\n")
415 assert_include "#{issue.id},#{issue.subject},7.33", lines
416 end
417
418 def test_index_csv_with_all_columns
419 get :index, :format => 'csv', :columns => 'all'
420 assert_response :success
421 assert_not_nil assigns(:issues)
422 assert_equal 'text/csv; header=present', @response.content_type
423 assert @response.body.starts_with?("#,")
424 lines = @response.body.chomp.split("\n")
425 assert_equal assigns(:query).available_inline_columns.size + 1, lines[0].split(',').size
426 end
427
428 def test_index_csv_with_multi_column_field
429 CustomField.find(1).update_attribute :multiple, true
430 issue = Issue.find(1)
431 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
432 issue.save!
433
434 get :index, :format => 'csv', :columns => 'all'
435 assert_response :success
436 lines = @response.body.chomp.split("\n")
437 assert lines.detect {|line| line.include?('"MySQL, Oracle"')}
438 end
439
440 def test_index_csv_big_5
441 with_settings :default_language => "zh-TW" do
442 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88"
443 str_big5 = "\xa4@\xa4\xeb"
444 if str_utf8.respond_to?(:force_encoding)
445 str_utf8.force_encoding('UTF-8')
446 str_big5.force_encoding('Big5')
447 end
448 issue = Issue.generate!(:subject => str_utf8)
449
450 get :index, :project_id => 1,
451 :f => ['subject'],
452 :op => '=', :values => [str_utf8],
453 :format => 'csv'
454 assert_equal 'text/csv; header=present', @response.content_type
455 lines = @response.body.chomp.split("\n")
456 s1 = "\xaa\xac\xbaA"
457 if str_utf8.respond_to?(:force_encoding)
458 s1.force_encoding('Big5')
459 end
460 assert lines[0].include?(s1)
461 assert lines[1].include?(str_big5)
462 end
463 end
464
465 def test_index_csv_cannot_convert_should_be_replaced_big_5
466 with_settings :default_language => "zh-TW" do
467 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85"
468 if str_utf8.respond_to?(:force_encoding)
469 str_utf8.force_encoding('UTF-8')
470 end
471 issue = Issue.generate!(:subject => str_utf8)
472
473 get :index, :project_id => 1,
474 :f => ['subject'],
475 :op => '=', :values => [str_utf8],
476 :c => ['status', 'subject'],
477 :format => 'csv',
478 :set_filter => 1
479 assert_equal 'text/csv; header=present', @response.content_type
480 lines = @response.body.chomp.split("\n")
481 s1 = "\xaa\xac\xbaA" # status
482 if str_utf8.respond_to?(:force_encoding)
483 s1.force_encoding('Big5')
484 end
485 assert lines[0].include?(s1)
486 s2 = lines[1].split(",")[2]
487 if s1.respond_to?(:force_encoding)
488 s3 = "\xa5H?" # subject
489 s3.force_encoding('Big5')
490 assert_equal s3, s2
491 elsif RUBY_PLATFORM == 'java'
492 assert_equal "??", s2
493 else
494 assert_equal "\xa5H???", s2
495 end
496 end
497 end
498
499 def test_index_csv_tw
500 with_settings :default_language => "zh-TW" do
501 str1 = "test_index_csv_tw"
502 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
503
504 get :index, :project_id => 1,
505 :f => ['subject'],
506 :op => '=', :values => [str1],
507 :c => ['estimated_hours', 'subject'],
508 :format => 'csv',
509 :set_filter => 1
510 assert_equal 'text/csv; header=present', @response.content_type
511 lines = @response.body.chomp.split("\n")
512 assert_equal "#{issue.id},1234.50,#{str1}", lines[1]
513 end
514 end
515
516 def test_index_csv_fr
517 with_settings :default_language => "fr" do
518 str1 = "test_index_csv_fr"
519 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
520
521 get :index, :project_id => 1,
522 :f => ['subject'],
523 :op => '=', :values => [str1],
524 :c => ['estimated_hours', 'subject'],
525 :format => 'csv',
526 :set_filter => 1
527 assert_equal 'text/csv; header=present', @response.content_type
528 lines = @response.body.chomp.split("\n")
529 assert_equal "#{issue.id};1234,50;#{str1}", lines[1]
530 end
531 end
532
533 def test_index_pdf
534 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
535 with_settings :default_language => lang do
536
537 get :index
538 assert_response :success
539 assert_template 'index'
540
541 if lang == "ja"
542 if RUBY_PLATFORM != 'java'
543 assert_equal "CP932", l(:general_pdf_encoding)
544 end
545 if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
546 next
547 end
548 end
549
550 get :index, :format => 'pdf'
551 assert_response :success
552 assert_not_nil assigns(:issues)
553 assert_equal 'application/pdf', @response.content_type
554
555 get :index, :project_id => 1, :format => 'pdf'
556 assert_response :success
557 assert_not_nil assigns(:issues)
558 assert_equal 'application/pdf', @response.content_type
559
560 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
561 assert_response :success
562 assert_not_nil assigns(:issues)
563 assert_equal 'application/pdf', @response.content_type
564 end
565 end
566 end
567
568 def test_index_pdf_with_query_grouped_by_list_custom_field
569 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
570 assert_response :success
571 assert_not_nil assigns(:issues)
572 assert_not_nil assigns(:issue_count_by_group)
573 assert_equal 'application/pdf', @response.content_type
574 end
575
576 def test_index_atom
577 get :index, :project_id => 'ecookbook', :format => 'atom'
578 assert_response :success
579 assert_template 'common/feed'
580 assert_equal 'application/atom+xml', response.content_type
581
582 assert_select 'feed' do
583 assert_select 'link[rel=self][href=?]', 'http://test.host/projects/ecookbook/issues.atom'
584 assert_select 'link[rel=alternate][href=?]', 'http://test.host/projects/ecookbook/issues'
585 assert_select 'entry link[href=?]', 'http://test.host/issues/1'
586 end
587 end
588
589 def test_index_sort
590 get :index, :sort => 'tracker,id:desc'
591 assert_response :success
592
593 sort_params = @request.session['issues_index_sort']
594 assert sort_params.is_a?(String)
595 assert_equal 'tracker,id:desc', sort_params
596
597 issues = assigns(:issues)
598 assert_not_nil issues
599 assert !issues.empty?
600 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
601 end
602
603 def test_index_sort_by_field_not_included_in_columns
604 Setting.issue_list_default_columns = %w(subject author)
605 get :index, :sort => 'tracker'
606 end
607
608 def test_index_sort_by_assigned_to
609 get :index, :sort => 'assigned_to'
610 assert_response :success
611 assignees = assigns(:issues).collect(&:assigned_to).compact
612 assert_equal assignees.sort, assignees
613 end
614
615 def test_index_sort_by_assigned_to_desc
616 get :index, :sort => 'assigned_to:desc'
617 assert_response :success
618 assignees = assigns(:issues).collect(&:assigned_to).compact
619 assert_equal assignees.sort.reverse, assignees
620 end
621
622 def test_index_group_by_assigned_to
623 get :index, :group_by => 'assigned_to', :sort => 'priority'
624 assert_response :success
625 end
626
627 def test_index_sort_by_author
628 get :index, :sort => 'author'
629 assert_response :success
630 authors = assigns(:issues).collect(&:author)
631 assert_equal authors.sort, authors
632 end
633
634 def test_index_sort_by_author_desc
635 get :index, :sort => 'author:desc'
636 assert_response :success
637 authors = assigns(:issues).collect(&:author)
638 assert_equal authors.sort.reverse, authors
639 end
640
641 def test_index_group_by_author
642 get :index, :group_by => 'author', :sort => 'priority'
643 assert_response :success
644 end
645
646 def test_index_sort_by_spent_hours
647 get :index, :sort => 'spent_hours:desc'
648 assert_response :success
649 hours = assigns(:issues).collect(&:spent_hours)
650 assert_equal hours.sort.reverse, hours
651 end
652
653 def test_index_sort_by_user_custom_field
654 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
655 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
656 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
657 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
658 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
659
660 get :index, :project_id => 1, :set_filter => 1, :sort => "cf_#{cf.id},id"
661 assert_response :success
662
663 assert_equal [2, 3, 1], assigns(:issues).select {|issue| issue.custom_field_value(cf).present?}.map(&:id)
664 end
665
666 def test_index_with_columns
667 columns = ['tracker', 'subject', 'assigned_to']
668 get :index, :set_filter => 1, :c => columns
669 assert_response :success
670
671 # query should use specified columns
672 query = assigns(:query)
673 assert_kind_of Query, query
674 assert_equal columns, query.column_names.map(&:to_s)
675
676 # columns should be stored in session
677 assert_kind_of Hash, session[:query]
678 assert_kind_of Array, session[:query][:column_names]
679 assert_equal columns, session[:query][:column_names].map(&:to_s)
680
681 # ensure only these columns are kept in the selected columns list
682 assert_select 'select#selected_columns option' do
683 assert_select 'option', 3
684 assert_select 'option[value=tracker]'
685 assert_select 'option[value=project]', 0
686 end
687 end
688
689 def test_index_without_project_should_implicitly_add_project_column_to_default_columns
690 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
691 get :index, :set_filter => 1
692
693 # query should use specified columns
694 query = assigns(:query)
695 assert_kind_of Query, query
696 assert_equal [:project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
697 end
698
699 def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
700 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
701 columns = ['tracker', 'subject', 'assigned_to']
702 get :index, :set_filter => 1, :c => columns
703
704 # query should use specified columns
705 query = assigns(:query)
706 assert_kind_of Query, query
707 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
708 end
709
710 def test_index_with_custom_field_column
711 columns = %w(tracker subject cf_2)
712 get :index, :set_filter => 1, :c => columns
713 assert_response :success
714
715 # query should use specified columns
716 query = assigns(:query)
717 assert_kind_of Query, query
718 assert_equal columns, query.column_names.map(&:to_s)
719
720 assert_select 'table.issues td.cf_2.string'
721 end
722
723 def test_index_with_multi_custom_field_column
724 field = CustomField.find(1)
725 field.update_attribute :multiple, true
726 issue = Issue.find(1)
727 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
728 issue.save!
729
730 get :index, :set_filter => 1, :c => %w(tracker subject cf_1)
731 assert_response :success
732
733 assert_select 'table.issues td.cf_1', :text => 'MySQL, Oracle'
734 end
735
736 def test_index_with_multi_user_custom_field_column
737 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
738 :tracker_ids => [1], :is_for_all => true)
739 issue = Issue.find(1)
740 issue.custom_field_values = {field.id => ['2', '3']}
741 issue.save!
742
743 get :index, :set_filter => 1, :c => ['tracker', 'subject', "cf_#{field.id}"]
744 assert_response :success
745
746 assert_select "table.issues td.cf_#{field.id}" do
747 assert_select 'a', 2
748 assert_select 'a[href=?]', '/users/2', :text => 'John Smith'
749 assert_select 'a[href=?]', '/users/3', :text => 'Dave Lopper'
750 end
751 end
752
753 def test_index_with_date_column
754 with_settings :date_format => '%d/%m/%Y' do
755 Issue.find(1).update_attribute :start_date, '1987-08-24'
756
757 get :index, :set_filter => 1, :c => %w(start_date)
758
759 assert_select "table.issues td.start_date", :text => '24/08/1987'
760 end
761 end
762
763 def test_index_with_done_ratio_column
764 Issue.find(1).update_attribute :done_ratio, 40
765
766 get :index, :set_filter => 1, :c => %w(done_ratio)
767
768 assert_select 'table.issues td.done_ratio' do
769 assert_select 'table.progress' do
770 assert_select 'td.closed[style=?]', 'width: 40%;'
771 end
772 end
773 end
774
775 def test_index_with_spent_hours_column
776 get :index, :set_filter => 1, :c => %w(subject spent_hours)
777
778 assert_select 'table.issues tr#issue-3 td.spent_hours', :text => '1.00'
779 end
780
781 def test_index_should_not_show_spent_hours_column_without_permission
782 Role.anonymous.remove_permission! :view_time_entries
783 get :index, :set_filter => 1, :c => %w(subject spent_hours)
784
785 assert_select 'td.spent_hours', 0
786 end
787
788 def test_index_with_fixed_version_column
789 get :index, :set_filter => 1, :c => %w(fixed_version)
790
791 assert_select 'table.issues td.fixed_version' do
792 assert_select 'a[href=?]', '/versions/2', :text => '1.0'
793 end
794 end
795
796 def test_index_with_relations_column
797 IssueRelation.delete_all
798 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(7))
799 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(8), :issue_to => Issue.find(1))
800 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(1), :issue_to => Issue.find(11))
801 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(12), :issue_to => Issue.find(2))
802
803 get :index, :set_filter => 1, :c => %w(subject relations)
804 assert_response :success
805 assert_select "tr#issue-1 td.relations" do
806 assert_select "span", 3
807 assert_select "span", :text => "Related to #7"
808 assert_select "span", :text => "Related to #8"
809 assert_select "span", :text => "Blocks #11"
810 end
811 assert_select "tr#issue-2 td.relations" do
812 assert_select "span", 1
813 assert_select "span", :text => "Blocked by #12"
814 end
815 assert_select "tr#issue-3 td.relations" do
816 assert_select "span", 0
817 end
818
819 get :index, :set_filter => 1, :c => %w(relations), :format => 'csv'
820 assert_response :success
821 assert_equal 'text/csv; header=present', response.content_type
822 lines = response.body.chomp.split("\n")
823 assert_include '1,"Related to #7, Related to #8, Blocks #11"', lines
824 assert_include '2,Blocked by #12', lines
825 assert_include '3,""', lines
826
827 get :index, :set_filter => 1, :c => %w(subject relations), :format => 'pdf'
828 assert_response :success
829 assert_equal 'application/pdf', response.content_type
830 end
831
832 def test_index_with_description_column
833 get :index, :set_filter => 1, :c => %w(subject description)
834
835 assert_select 'table.issues thead th', 3 # columns: chekbox + id + subject
836 assert_select 'td.description[colspan=3]', :text => 'Unable to print recipes'
837
838 get :index, :set_filter => 1, :c => %w(subject description), :format => 'pdf'
839 assert_response :success
840 assert_equal 'application/pdf', response.content_type
841 end
842
843 def test_index_send_html_if_query_is_invalid
844 get :index, :f => ['start_date'], :op => {:start_date => '='}
845 assert_equal 'text/html', @response.content_type
846 assert_template 'index'
847 end
848
849 def test_index_send_nothing_if_query_is_invalid
850 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
851 assert_equal 'text/csv', @response.content_type
852 assert @response.body.blank?
853 end
854
855 def test_show_by_anonymous
856 get :show, :id => 1
857 assert_response :success
858 assert_template 'show'
859 assert_equal Issue.find(1), assigns(:issue)
860
861 assert_select 'div.issue div.description', :text => /Unable to print recipes/
862
863 # anonymous role is allowed to add a note
864 assert_select 'form#issue-form' do
865 assert_select 'fieldset' do
866 assert_select 'legend', :text => 'Notes'
867 assert_select 'textarea[name=?]', 'issue[notes]'
868 end
869 end
870
871 assert_select 'title', :text => "Bug #1: Can&#x27;t print recipes - eCookbook - Redmine"
872 end
873
874 def test_show_by_manager
875 @request.session[:user_id] = 2
876 get :show, :id => 1
877 assert_response :success
878
879 assert_select 'a', :text => /Quote/
880
881 assert_select 'form#issue-form' do
882 assert_select 'fieldset' do
883 assert_select 'legend', :text => 'Change properties'
884 assert_select 'input[name=?]', 'issue[subject]'
885 end
886 assert_select 'fieldset' do
887 assert_select 'legend', :text => 'Log time'
888 assert_select 'input[name=?]', 'time_entry[hours]'
889 end
890 assert_select 'fieldset' do
891 assert_select 'legend', :text => 'Notes'
892 assert_select 'textarea[name=?]', 'issue[notes]'
893 end
894 end
895 end
896
897 def test_show_should_display_update_form
898 @request.session[:user_id] = 2
899 get :show, :id => 1
900 assert_response :success
901
902 assert_tag 'form', :attributes => {:id => 'issue-form'}
903 assert_tag 'input', :attributes => {:name => 'issue[is_private]'}
904 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
905 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
906 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
907 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
908 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
909 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
910 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
911 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
912 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
913 assert_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
914 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
915 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
916 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
917 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
918 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
919 assert_tag 'textarea', :attributes => {:name => 'issue[notes]'}
920 end
921
922 def test_show_should_display_update_form_with_minimal_permissions
923 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
924 WorkflowTransition.delete_all :role_id => 1
925
926 @request.session[:user_id] = 2
927 get :show, :id => 1
928 assert_response :success
929
930 assert_tag 'form', :attributes => {:id => 'issue-form'}
931 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
932 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
933 assert_no_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
934 assert_no_tag 'input', :attributes => {:name => 'issue[subject]'}
935 assert_no_tag 'textarea', :attributes => {:name => 'issue[description]'}
936 assert_no_tag 'select', :attributes => {:name => 'issue[status_id]'}
937 assert_no_tag 'select', :attributes => {:name => 'issue[priority_id]'}
938 assert_no_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
939 assert_no_tag 'select', :attributes => {:name => 'issue[category_id]'}
940 assert_no_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
941 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
942 assert_no_tag 'input', :attributes => {:name => 'issue[start_date]'}
943 assert_no_tag 'input', :attributes => {:name => 'issue[due_date]'}
944 assert_no_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
945 assert_no_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
946 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
947 assert_tag 'textarea', :attributes => {:name => 'issue[notes]'}
948 end
949
950 def test_show_should_display_update_form_with_workflow_permissions
951 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
952
953 @request.session[:user_id] = 2
954 get :show, :id => 1
955 assert_response :success
956
957 assert_tag 'form', :attributes => {:id => 'issue-form'}
958 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
959 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
960 assert_no_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
961 assert_no_tag 'input', :attributes => {:name => 'issue[subject]'}
962 assert_no_tag 'textarea', :attributes => {:name => 'issue[description]'}
963 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
964 assert_no_tag 'select', :attributes => {:name => 'issue[priority_id]'}
965 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
966 assert_no_tag 'select', :attributes => {:name => 'issue[category_id]'}
967 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
968 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
969 assert_no_tag 'input', :attributes => {:name => 'issue[start_date]'}
970 assert_no_tag 'input', :attributes => {:name => 'issue[due_date]'}
971 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
972 assert_no_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
973 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
974 assert_tag 'textarea', :attributes => {:name => 'issue[notes]'}
975 end
976
977 def test_show_should_not_display_update_form_without_permissions
978 Role.find(1).update_attribute :permissions, [:view_issues]
979
980 @request.session[:user_id] = 2
981 get :show, :id => 1
982 assert_response :success
983
984 assert_select 'form#issue-form', 0
985 end
986
987 def test_update_form_should_not_display_inactive_enumerations
988 assert !IssuePriority.find(15).active?
989
990 @request.session[:user_id] = 2
991 get :show, :id => 1
992 assert_response :success
993
994 assert_select 'form#issue-form' do
995 assert_select 'select[name=?]', 'issue[priority_id]' do
996 assert_select 'option[value=4]'
997 assert_select 'option[value=15]', 0
998 end
999 end
1000 end
1001
1002 def test_update_form_should_allow_attachment_upload
1003 @request.session[:user_id] = 2
1004 get :show, :id => 1
1005
1006 assert_select 'form#issue-form[method=post][enctype=multipart/form-data]' do
1007 assert_select 'input[type=file][name=?]', 'attachments[1][file]'
1008 end
1009 end
1010
1011 def test_show_should_deny_anonymous_access_without_permission
1012 Role.anonymous.remove_permission!(:view_issues)
1013 get :show, :id => 1
1014 assert_response :redirect
1015 end
1016
1017 def test_show_should_deny_anonymous_access_to_private_issue
1018 Issue.update_all(["is_private = ?", true], "id = 1")
1019 get :show, :id => 1
1020 assert_response :redirect
1021 end
1022
1023 def test_show_should_deny_non_member_access_without_permission
1024 Role.non_member.remove_permission!(:view_issues)
1025 @request.session[:user_id] = 9
1026 get :show, :id => 1
1027 assert_response 403
1028 end
1029
1030 def test_show_should_deny_non_member_access_to_private_issue
1031 Issue.update_all(["is_private = ?", true], "id = 1")
1032 @request.session[:user_id] = 9
1033 get :show, :id => 1
1034 assert_response 403
1035 end
1036
1037 def test_show_should_deny_member_access_without_permission
1038 Role.find(1).remove_permission!(:view_issues)
1039 @request.session[:user_id] = 2
1040 get :show, :id => 1
1041 assert_response 403
1042 end
1043
1044 def test_show_should_deny_member_access_to_private_issue_without_permission
1045 Issue.update_all(["is_private = ?", true], "id = 1")
1046 @request.session[:user_id] = 3
1047 get :show, :id => 1
1048 assert_response 403
1049 end
1050
1051 def test_show_should_allow_author_access_to_private_issue
1052 Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
1053 @request.session[:user_id] = 3
1054 get :show, :id => 1
1055 assert_response :success
1056 end
1057
1058 def test_show_should_allow_assignee_access_to_private_issue
1059 Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
1060 @request.session[:user_id] = 3
1061 get :show, :id => 1
1062 assert_response :success
1063 end
1064
1065 def test_show_should_allow_member_access_to_private_issue_with_permission
1066 Issue.update_all(["is_private = ?", true], "id = 1")
1067 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
1068 @request.session[:user_id] = 3
1069 get :show, :id => 1
1070 assert_response :success
1071 end
1072
1073 def test_show_should_not_disclose_relations_to_invisible_issues
1074 Setting.cross_project_issue_relations = '1'
1075 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
1076 # Relation to a private project issue
1077 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
1078
1079 get :show, :id => 1
1080 assert_response :success
1081
1082 assert_select 'div#relations' do
1083 assert_select 'a', :text => /#2$/
1084 assert_select 'a', :text => /#4$/, :count => 0
1085 end
1086 end
1087
1088 def test_show_should_list_subtasks
1089 Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1090
1091 get :show, :id => 1
1092 assert_response :success
1093
1094 assert_select 'div#issue_tree' do
1095 assert_select 'td.subject', :text => /Child Issue/
1096 end
1097 end
1098
1099 def test_show_should_list_parents
1100 issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1101
1102 get :show, :id => issue.id
1103 assert_response :success
1104
1105 assert_select 'div.subject' do
1106 assert_select 'h3', 'Child Issue'
1107 assert_select 'a[href=/issues/1]'
1108 end
1109 end
1110
1111 def test_show_should_not_display_prev_next_links_without_query_in_session
1112 get :show, :id => 1
1113 assert_response :success
1114 assert_nil assigns(:prev_issue_id)
1115 assert_nil assigns(:next_issue_id)
1116
1117 assert_select 'div.next-prev-links', 0
1118 end
1119
1120 def test_show_should_display_prev_next_links_with_query_in_session
1121 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1122 @request.session['issues_index_sort'] = 'id'
1123
1124 with_settings :display_subprojects_issues => '0' do
1125 get :show, :id => 3
1126 end
1127
1128 assert_response :success
1129 # Previous and next issues for all projects
1130 assert_equal 2, assigns(:prev_issue_id)
1131 assert_equal 5, assigns(:next_issue_id)
1132
1133 count = Issue.open.visible.count
1134
1135 assert_select 'div.next-prev-links' do
1136 assert_select 'a[href=/issues/2]', :text => /Previous/
1137 assert_select 'a[href=/issues/5]', :text => /Next/
1138 assert_select 'span.position', :text => "3 of #{count}"
1139 end
1140 end
1141
1142 def test_show_should_display_prev_next_links_with_saved_query_in_session
1143 query = Query.create!(:name => 'test', :is_public => true, :user_id => 1,
1144 :filters => {'status_id' => {:values => ['5'], :operator => '='}},
1145 :sort_criteria => [['id', 'asc']])
1146 @request.session[:query] = {:id => query.id, :project_id => nil}
1147
1148 get :show, :id => 11
1149
1150 assert_response :success
1151 assert_equal query, assigns(:query)
1152 # Previous and next issues for all projects
1153 assert_equal 8, assigns(:prev_issue_id)
1154 assert_equal 12, assigns(:next_issue_id)
1155
1156 assert_select 'div.next-prev-links' do
1157 assert_select 'a[href=/issues/8]', :text => /Previous/
1158 assert_select 'a[href=/issues/12]', :text => /Next/
1159 end
1160 end
1161
1162 def test_show_should_display_prev_next_links_with_query_and_sort_on_association
1163 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1164
1165 %w(project tracker status priority author assigned_to category fixed_version).each do |assoc_sort|
1166 @request.session['issues_index_sort'] = assoc_sort
1167
1168 get :show, :id => 3
1169 assert_response :success, "Wrong response status for #{assoc_sort} sort"
1170
1171 assert_select 'div.next-prev-links' do
1172 assert_select 'a', :text => /(Previous|Next)/
1173 end
1174 end
1175 end
1176
1177 def test_show_should_display_prev_next_links_with_project_query_in_session
1178 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1179 @request.session['issues_index_sort'] = 'id'
1180
1181 with_settings :display_subprojects_issues => '0' do
1182 get :show, :id => 3
1183 end
1184
1185 assert_response :success
1186 # Previous and next issues inside project
1187 assert_equal 2, assigns(:prev_issue_id)
1188 assert_equal 7, assigns(:next_issue_id)
1189
1190 assert_select 'div.next-prev-links' do
1191 assert_select 'a[href=/issues/2]', :text => /Previous/
1192 assert_select 'a[href=/issues/7]', :text => /Next/
1193 end
1194 end
1195
1196 def test_show_should_not_display_prev_link_for_first_issue
1197 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1198 @request.session['issues_index_sort'] = 'id'
1199
1200 with_settings :display_subprojects_issues => '0' do
1201 get :show, :id => 1
1202 end
1203
1204 assert_response :success
1205 assert_nil assigns(:prev_issue_id)
1206 assert_equal 2, assigns(:next_issue_id)
1207
1208 assert_select 'div.next-prev-links' do
1209 assert_select 'a', :text => /Previous/, :count => 0
1210 assert_select 'a[href=/issues/2]', :text => /Next/
1211 end
1212 end
1213
1214 def test_show_should_not_display_prev_next_links_for_issue_not_in_query_results
1215 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'c'}}, :project_id => 1}
1216 @request.session['issues_index_sort'] = 'id'
1217
1218 get :show, :id => 1
1219
1220 assert_response :success
1221 assert_nil assigns(:prev_issue_id)
1222 assert_nil assigns(:next_issue_id)
1223
1224 assert_select 'a', :text => /Previous/, :count => 0
1225 assert_select 'a', :text => /Next/, :count => 0
1226 end
1227
1228 def test_show_show_should_display_prev_next_links_with_query_sort_by_user_custom_field
1229 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
1230 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
1231 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
1232 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
1233 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
1234
1235 query = Query.create!(:name => 'test', :is_public => true, :user_id => 1, :filters => {},
1236 :sort_criteria => [["cf_#{cf.id}", 'asc'], ['id', 'asc']])
1237 @request.session[:query] = {:id => query.id, :project_id => nil}
1238
1239 get :show, :id => 3
1240 assert_response :success
1241
1242 assert_equal 2, assigns(:prev_issue_id)
1243 assert_equal 1, assigns(:next_issue_id)
1244
1245 assert_select 'div.next-prev-links' do
1246 assert_select 'a[href=/issues/2]', :text => /Previous/
1247 assert_select 'a[href=/issues/1]', :text => /Next/
1248 end
1249 end
1250
1251 def test_show_should_display_link_to_the_assignee
1252 get :show, :id => 2
1253 assert_response :success
1254 assert_select '.assigned-to' do
1255 assert_select 'a[href=/users/3]'
1256 end
1257 end
1258
1259 def test_show_should_display_visible_changesets_from_other_projects
1260 project = Project.find(2)
1261 issue = project.issues.first
1262 issue.changeset_ids = [102]
1263 issue.save!
1264 # changesets from other projects should be displayed even if repository
1265 # is disabled on issue's project
1266 project.disable_module! :repository
1267
1268 @request.session[:user_id] = 2
1269 get :show, :id => issue.id
1270
1271 assert_select 'a[href=?]', '/projects/ecookbook/repository/revisions/3'
1272 end
1273
1274 def test_show_should_display_watchers
1275 @request.session[:user_id] = 2
1276 Issue.find(1).add_watcher User.find(2)
1277
1278 get :show, :id => 1
1279 assert_select 'div#watchers ul' do
1280 assert_select 'li' do
1281 assert_select 'a[href=/users/2]'
1282 assert_select 'a img[alt=Delete]'
1283 end
1284 end
1285 end
1286
1287 def test_show_should_display_watchers_with_gravatars
1288 @request.session[:user_id] = 2
1289 Issue.find(1).add_watcher User.find(2)
1290
1291 with_settings :gravatar_enabled => '1' do
1292 get :show, :id => 1
1293 end
1294
1295 assert_select 'div#watchers ul' do
1296 assert_select 'li' do
1297 assert_select 'img.gravatar'
1298 assert_select 'a[href=/users/2]'
1299 assert_select 'a img[alt=Delete]'
1300 end
1301 end
1302 end
1303
1304 def test_show_with_thumbnails_enabled_should_display_thumbnails
1305 @request.session[:user_id] = 2
1306
1307 with_settings :thumbnails_enabled => '1' do
1308 get :show, :id => 14
1309 assert_response :success
1310 end
1311
1312 assert_select 'div.thumbnails' do
1313 assert_select 'a[href=/attachments/16/testfile.png]' do
1314 assert_select 'img[src=/attachments/thumbnail/16]'
1315 end
1316 end
1317 end
1318
1319 def test_show_with_thumbnails_disabled_should_not_display_thumbnails
1320 @request.session[:user_id] = 2
1321
1322 with_settings :thumbnails_enabled => '0' do
1323 get :show, :id => 14
1324 assert_response :success
1325 end
1326
1327 assert_select 'div.thumbnails', 0
1328 end
1329
1330 def test_show_with_multi_custom_field
1331 field = CustomField.find(1)
1332 field.update_attribute :multiple, true
1333 issue = Issue.find(1)
1334 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
1335 issue.save!
1336
1337 get :show, :id => 1
1338 assert_response :success
1339
1340 assert_select 'td', :text => 'MySQL, Oracle'
1341 end
1342
1343 def test_show_with_multi_user_custom_field
1344 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1345 :tracker_ids => [1], :is_for_all => true)
1346 issue = Issue.find(1)
1347 issue.custom_field_values = {field.id => ['2', '3']}
1348 issue.save!
1349
1350 get :show, :id => 1
1351 assert_response :success
1352
1353 # TODO: should display links
1354 assert_select 'td', :text => 'Dave Lopper, John Smith'
1355 end
1356
1357 def test_show_should_display_private_notes_with_permission_only
1358 journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Privates notes', :private_notes => true, :user_id => 1)
1359 @request.session[:user_id] = 2
1360
1361 get :show, :id => 2
1362 assert_response :success
1363 assert_include journal, assigns(:journals)
1364
1365 Role.find(1).remove_permission! :view_private_notes
1366 get :show, :id => 2
1367 assert_response :success
1368 assert_not_include journal, assigns(:journals)
1369 end
1370
1371 def test_show_atom
1372 get :show, :id => 2, :format => 'atom'
1373 assert_response :success
1374 assert_template 'journals/index'
1375 # Inline image
1376 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
1377 end
1378
1379 def test_show_export_to_pdf
1380 get :show, :id => 3, :format => 'pdf'
1381 assert_response :success
1382 assert_equal 'application/pdf', @response.content_type
1383 assert @response.body.starts_with?('%PDF')
1384 assert_not_nil assigns(:issue)
1385 end
1386
1387 def test_show_export_to_pdf_with_ancestors
1388 issue = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1389
1390 get :show, :id => issue.id, :format => 'pdf'
1391 assert_response :success
1392 assert_equal 'application/pdf', @response.content_type
1393 assert @response.body.starts_with?('%PDF')
1394 end
1395
1396 def test_show_export_to_pdf_with_descendants
1397 c1 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1398 c2 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1399 c3 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => c1.id)
1400
1401 get :show, :id => 1, :format => 'pdf'
1402 assert_response :success
1403 assert_equal 'application/pdf', @response.content_type
1404 assert @response.body.starts_with?('%PDF')
1405 end
1406
1407 def test_show_export_to_pdf_with_journals
1408 get :show, :id => 1, :format => 'pdf'
1409 assert_response :success
1410 assert_equal 'application/pdf', @response.content_type
1411 assert @response.body.starts_with?('%PDF')
1412 end
1413
1414 def test_show_export_to_pdf_with_changesets
1415 Issue.find(3).changesets = Changeset.find_all_by_id(100, 101, 102)
1416
1417 get :show, :id => 3, :format => 'pdf'
1418 assert_response :success
1419 assert_equal 'application/pdf', @response.content_type
1420 assert @response.body.starts_with?('%PDF')
1421 end
1422
1423 def test_get_new
1424 @request.session[:user_id] = 2
1425 get :new, :project_id => 1, :tracker_id => 1
1426 assert_response :success
1427 assert_template 'new'
1428
1429 assert_tag 'input', :attributes => {:name => 'issue[is_private]'}
1430 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
1431 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
1432 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
1433 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
1434 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
1435 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
1436 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
1437 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
1438 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
1439 assert_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
1440 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
1441 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
1442 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
1443 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]', :value => 'Default string' }
1444 assert_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
1445
1446 # Be sure we don't display inactive IssuePriorities
1447 assert ! IssuePriority.find(15).active?
1448 assert_no_tag :option, :attributes => {:value => '15'},
1449 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
1450 end
1451
1452 def test_get_new_with_minimal_permissions
1453 Role.find(1).update_attribute :permissions, [:add_issues]
1454 WorkflowTransition.delete_all :role_id => 1
1455
1456 @request.session[:user_id] = 2
1457 get :new, :project_id => 1, :tracker_id => 1
1458 assert_response :success
1459 assert_template 'new'
1460
1461 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
1462 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
1463 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
1464 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
1465 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
1466 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
1467 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
1468 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
1469 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
1470 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
1471 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
1472 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
1473 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
1474 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
1475 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]', :value => 'Default string' }
1476 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
1477 end
1478
1479 def test_get_new_with_list_custom_field
1480 @request.session[:user_id] = 2
1481 get :new, :project_id => 1, :tracker_id => 1
1482 assert_response :success
1483 assert_template 'new'
1484
1485 assert_select 'select.list_cf[name=?]', 'issue[custom_field_values][1]' do
1486 assert_select 'option', 4
1487 assert_select 'option[value=MySQL]', :text => 'MySQL'
1488 end
1489 end
1490
1491 def test_get_new_with_multi_custom_field
1492 field = IssueCustomField.find(1)
1493 field.update_attribute :multiple, true
1494
1495 @request.session[:user_id] = 2
1496 get :new, :project_id => 1, :tracker_id => 1
1497 assert_response :success
1498 assert_template 'new'
1499
1500 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
1501 assert_select 'option', 3
1502 assert_select 'option[value=MySQL]', :text => 'MySQL'
1503 end
1504 assert_select 'input[name=?][type=hidden][value=?]', 'issue[custom_field_values][1][]', ''
1505 end
1506
1507 def test_get_new_with_multi_user_custom_field
1508 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1509 :tracker_ids => [1], :is_for_all => true)
1510
1511 @request.session[:user_id] = 2
1512 get :new, :project_id => 1, :tracker_id => 1
1513 assert_response :success
1514 assert_template 'new'
1515
1516 assert_select 'select[name=?][multiple=multiple]', "issue[custom_field_values][#{field.id}][]" do
1517 assert_select 'option', Project.find(1).users.count
1518 assert_select 'option[value=2]', :text => 'John Smith'
1519 end
1520 assert_select 'input[name=?][type=hidden][value=?]', "issue[custom_field_values][#{field.id}][]", ''
1521 end
1522
1523 def test_get_new_with_date_custom_field
1524 field = IssueCustomField.create!(:name => 'Date', :field_format => 'date', :tracker_ids => [1], :is_for_all => true)
1525
1526 @request.session[:user_id] = 2
1527 get :new, :project_id => 1, :tracker_id => 1
1528 assert_response :success
1529
1530 assert_select 'input[name=?]', "issue[custom_field_values][#{field.id}]"
1531 end
1532
1533 def test_get_new_with_text_custom_field
1534 field = IssueCustomField.create!(:name => 'Text', :field_format => 'text', :tracker_ids => [1], :is_for_all => true)
1535
1536 @request.session[:user_id] = 2
1537 get :new, :project_id => 1, :tracker_id => 1
1538 assert_response :success
1539
1540 assert_select 'textarea[name=?]', "issue[custom_field_values][#{field.id}]"
1541 end
1542
1543 def test_get_new_without_default_start_date_is_creation_date
1544 Setting.default_issue_start_date_to_creation_date = 0
1545
1546 @request.session[:user_id] = 2
1547 get :new, :project_id => 1, :tracker_id => 1
1548 assert_response :success
1549 assert_template 'new'
1550
1551 assert_select 'input[name=?]', 'issue[start_date]'
1552 assert_select 'input[name=?][value]', 'issue[start_date]', 0
1553 end
1554
1555 def test_get_new_with_default_start_date_is_creation_date
1556 Setting.default_issue_start_date_to_creation_date = 1
1557
1558 @request.session[:user_id] = 2
1559 get :new, :project_id => 1, :tracker_id => 1
1560 assert_response :success
1561 assert_template 'new'
1562
1563 assert_select 'input[name=?][value=?]', 'issue[start_date]', Date.today.to_s
1564 end
1565
1566 def test_get_new_form_should_allow_attachment_upload
1567 @request.session[:user_id] = 2
1568 get :new, :project_id => 1, :tracker_id => 1
1569
1570 assert_select 'form[id=issue-form][method=post][enctype=multipart/form-data]' do
1571 assert_select 'input[name=?][type=file]', 'attachments[1][file]'
1572 assert_select 'input[name=?][maxlength=255]', 'attachments[1][description]'
1573 end
1574 end
1575
1576 def test_get_new_should_prefill_the_form_from_params
1577 @request.session[:user_id] = 2
1578 get :new, :project_id => 1,
1579 :issue => {:tracker_id => 3, :description => 'Prefilled', :custom_field_values => {'2' => 'Custom field value'}}
1580
1581 issue = assigns(:issue)
1582 assert_equal 3, issue.tracker_id
1583 assert_equal 'Prefilled', issue.description
1584 assert_equal 'Custom field value', issue.custom_field_value(2)
1585
1586 assert_select 'select[name=?]', 'issue[tracker_id]' do
1587 assert_select 'option[value=3][selected=selected]'
1588 end
1589 assert_select 'textarea[name=?]', 'issue[description]', :text => /Prefilled/
1590 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Custom field value'
1591 end
1592
1593 def test_get_new_should_mark_required_fields
1594 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1595 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1596 WorkflowPermission.delete_all
1597 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1598 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1599 @request.session[:user_id] = 2
1600
1601 get :new, :project_id => 1
1602 assert_response :success
1603 assert_template 'new'
1604
1605 assert_select 'label[for=issue_start_date]' do
1606 assert_select 'span[class=required]', 0
1607 end
1608 assert_select 'label[for=issue_due_date]' do
1609 assert_select 'span[class=required]'
1610 end
1611 assert_select 'label[for=?]', "issue_custom_field_values_#{cf1.id}" do
1612 assert_select 'span[class=required]', 0
1613 end
1614 assert_select 'label[for=?]', "issue_custom_field_values_#{cf2.id}" do
1615 assert_select 'span[class=required]'
1616 end
1617 end
1618
1619 def test_get_new_should_not_display_readonly_fields
1620 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1621 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1622 WorkflowPermission.delete_all
1623 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1624 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1625 @request.session[:user_id] = 2
1626
1627 get :new, :project_id => 1
1628 assert_response :success
1629 assert_template 'new'
1630
1631 assert_select 'input[name=?]', 'issue[start_date]'
1632 assert_select 'input[name=?]', 'issue[due_date]', 0
1633 assert_select 'input[name=?]', "issue[custom_field_values][#{cf1.id}]"
1634 assert_select 'input[name=?]', "issue[custom_field_values][#{cf2.id}]", 0
1635 end
1636
1637 def test_get_new_without_tracker_id
1638 @request.session[:user_id] = 2
1639 get :new, :project_id => 1
1640 assert_response :success
1641 assert_template 'new'
1642
1643 issue = assigns(:issue)
1644 assert_not_nil issue
1645 assert_equal Project.find(1).trackers.first, issue.tracker
1646 end
1647
1648 def test_get_new_with_no_default_status_should_display_an_error
1649 @request.session[:user_id] = 2
1650 IssueStatus.delete_all
1651
1652 get :new, :project_id => 1
1653 assert_response 500
1654 assert_error_tag :content => /No default issue/
1655 end
1656
1657 def test_get_new_with_no_tracker_should_display_an_error
1658 @request.session[:user_id] = 2
1659 Tracker.delete_all
1660
1661 get :new, :project_id => 1
1662 assert_response 500
1663 assert_error_tag :content => /No tracker/
1664 end
1665
1666 def test_update_new_form
1667 @request.session[:user_id] = 2
1668 xhr :post, :new, :project_id => 1,
1669 :issue => {:tracker_id => 2,
1670 :subject => 'This is the test_new issue',
1671 :description => 'This is the description',
1672 :priority_id => 5}
1673 assert_response :success
1674 assert_template 'update_form'
1675 assert_template 'form'
1676 assert_equal 'text/javascript', response.content_type
1677
1678 issue = assigns(:issue)
1679 assert_kind_of Issue, issue
1680 assert_equal 1, issue.project_id
1681 assert_equal 2, issue.tracker_id
1682 assert_equal 'This is the test_new issue', issue.subject
1683 end
1684
1685 def test_update_new_form_should_propose_transitions_based_on_initial_status
1686 @request.session[:user_id] = 2
1687 WorkflowTransition.delete_all
1688 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2)
1689 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5)
1690 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 5, :new_status_id => 4)
1691
1692 xhr :post, :new, :project_id => 1,
1693 :issue => {:tracker_id => 1,
1694 :status_id => 5,
1695 :subject => 'This is an issue'}
1696
1697 assert_equal 5, assigns(:issue).status_id
1698 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
1699 end
1700
1701 def test_post_create
1702 @request.session[:user_id] = 2
1703 assert_difference 'Issue.count' do
1704 post :create, :project_id => 1,
1705 :issue => {:tracker_id => 3,
1706 :status_id => 2,
1707 :subject => 'This is the test_new issue',
1708 :description => 'This is the description',
1709 :priority_id => 5,
1710 :start_date => '2010-11-07',
1711 :estimated_hours => '',
1712 :custom_field_values => {'2' => 'Value for field 2'}}
1713 end
1714 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1715
1716 issue = Issue.find_by_subject('This is the test_new issue')
1717 assert_not_nil issue
1718 assert_equal 2, issue.author_id
1719 assert_equal 3, issue.tracker_id
1720 assert_equal 2, issue.status_id
1721 assert_equal Date.parse('2010-11-07'), issue.start_date
1722 assert_nil issue.estimated_hours
1723 v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
1724 assert_not_nil v
1725 assert_equal 'Value for field 2', v.value
1726 end
1727
1728 def test_post_new_with_group_assignment
1729 group = Group.find(11)
1730 project = Project.find(1)
1731 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
1732
1733 with_settings :issue_group_assignment => '1' do
1734 @request.session[:user_id] = 2
1735 assert_difference 'Issue.count' do
1736 post :create, :project_id => project.id,
1737 :issue => {:tracker_id => 3,
1738 :status_id => 1,
1739 :subject => 'This is the test_new_with_group_assignment issue',
1740 :assigned_to_id => group.id}
1741 end
1742 end
1743 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1744
1745 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
1746 assert_not_nil issue
1747 assert_equal group, issue.assigned_to
1748 end
1749
1750 def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
1751 Setting.default_issue_start_date_to_creation_date = 0
1752
1753 @request.session[:user_id] = 2
1754 assert_difference 'Issue.count' do
1755 post :create, :project_id => 1,
1756 :issue => {:tracker_id => 3,
1757 :status_id => 2,
1758 :subject => 'This is the test_new issue',
1759 :description => 'This is the description',
1760 :priority_id => 5,
1761 :estimated_hours => '',
1762 :custom_field_values => {'2' => 'Value for field 2'}}
1763 end
1764 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1765
1766 issue = Issue.find_by_subject('This is the test_new issue')
1767 assert_not_nil issue
1768 assert_nil issue.start_date
1769 end
1770
1771 def test_post_create_without_start_date_and_default_start_date_is_creation_date
1772 Setting.default_issue_start_date_to_creation_date = 1
1773
1774 @request.session[:user_id] = 2
1775 assert_difference 'Issue.count' do
1776 post :create, :project_id => 1,
1777 :issue => {:tracker_id => 3,
1778 :status_id => 2,
1779 :subject => 'This is the test_new issue',
1780 :description => 'This is the description',
1781 :priority_id => 5,
1782 :estimated_hours => '',
1783 :custom_field_values => {'2' => 'Value for field 2'}}
1784 end
1785 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1786
1787 issue = Issue.find_by_subject('This is the test_new issue')
1788 assert_not_nil issue
1789 assert_equal Date.today, issue.start_date
1790 end
1791
1792 def test_post_create_and_continue
1793 @request.session[:user_id] = 2
1794 assert_difference 'Issue.count' do
1795 post :create, :project_id => 1,
1796 :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
1797 :continue => ''
1798 end
1799
1800 issue = Issue.first(:order => 'id DESC')
1801 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
1802 assert_not_nil flash[:notice], "flash was not set"
1803 assert_include %|<a href="/issues/#{issue.id}" title="This is first issue">##{issue.id}</a>|, flash[:notice], "issue link not found in the flash message"
1804 end
1805
1806 def test_post_create_without_custom_fields_param
1807 @request.session[:user_id] = 2
1808 assert_difference 'Issue.count' do
1809 post :create, :project_id => 1,
1810 :issue => {:tracker_id => 1,
1811 :subject => 'This is the test_new issue',
1812 :description => 'This is the description',
1813 :priority_id => 5}
1814 end
1815 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1816 end
1817
1818 def test_post_create_with_multi_custom_field
1819 field = IssueCustomField.find_by_name('Database')
1820 field.update_attribute(:multiple, true)
1821
1822 @request.session[:user_id] = 2
1823 assert_difference 'Issue.count' do
1824 post :create, :project_id => 1,
1825 :issue => {:tracker_id => 1,
1826 :subject => 'This is the test_new issue',
1827 :description => 'This is the description',
1828 :priority_id => 5,
1829 :custom_field_values => {'1' => ['', 'MySQL', 'Oracle']}}
1830 end
1831 assert_response 302
1832 issue = Issue.first(:order => 'id DESC')
1833 assert_equal ['MySQL', 'Oracle'], issue.custom_field_value(1).sort
1834 end
1835
1836 def test_post_create_with_empty_multi_custom_field
1837 field = IssueCustomField.find_by_name('Database')
1838 field.update_attribute(:multiple, true)
1839
1840 @request.session[:user_id] = 2
1841 assert_difference 'Issue.count' do
1842 post :create, :project_id => 1,
1843 :issue => {:tracker_id => 1,
1844 :subject => 'This is the test_new issue',
1845 :description => 'This is the description',
1846 :priority_id => 5,
1847 :custom_field_values => {'1' => ['']}}
1848 end
1849 assert_response 302
1850 issue = Issue.first(:order => 'id DESC')
1851 assert_equal [''], issue.custom_field_value(1).sort
1852 end
1853
1854 def test_post_create_with_multi_user_custom_field
1855 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1856 :tracker_ids => [1], :is_for_all => true)
1857
1858 @request.session[:user_id] = 2
1859 assert_difference 'Issue.count' do
1860 post :create, :project_id => 1,
1861 :issue => {:tracker_id => 1,
1862 :subject => 'This is the test_new issue',
1863 :description => 'This is the description',
1864 :priority_id => 5,
1865 :custom_field_values => {field.id.to_s => ['', '2', '3']}}
1866 end
1867 assert_response 302
1868 issue = Issue.first(:order => 'id DESC')
1869 assert_equal ['2', '3'], issue.custom_field_value(field).sort
1870 end
1871
1872 def test_post_create_with_required_custom_field_and_without_custom_fields_param
1873 field = IssueCustomField.find_by_name('Database')
1874 field.update_attribute(:is_required, true)
1875
1876 @request.session[:user_id] = 2
1877 assert_no_difference 'Issue.count' do
1878 post :create, :project_id => 1,
1879 :issue => {:tracker_id => 1,
1880 :subject => 'This is the test_new issue',
1881 :description => 'This is the description',
1882 :priority_id => 5}
1883 end
1884 assert_response :success
1885 assert_template 'new'
1886 issue = assigns(:issue)
1887 assert_not_nil issue
1888 assert_error_tag :content => /Database can&#x27;t be blank/
1889 end
1890
1891 def test_create_should_validate_required_fields
1892 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1893 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1894 WorkflowPermission.delete_all
1895 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1896 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1897 @request.session[:user_id] = 2
1898
1899 assert_no_difference 'Issue.count' do
1900 post :create, :project_id => 1, :issue => {
1901 :tracker_id => 2,
1902 :status_id => 1,
1903 :subject => 'Test',
1904 :start_date => '',
1905 :due_date => '',
1906 :custom_field_values => {cf1.id.to_s => '', cf2.id.to_s => ''}
1907 }
1908 assert_response :success
1909 assert_template 'new'
1910 end
1911
1912 assert_error_tag :content => /Due date can&#x27;t be blank/i
1913 assert_error_tag :content => /Bar can&#x27;t be blank/i
1914 end
1915
1916 def test_create_should_ignore_readonly_fields
1917 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1918 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1919 WorkflowPermission.delete_all
1920 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1921 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1922 @request.session[:user_id] = 2
1923
1924 assert_difference 'Issue.count' do
1925 post :create, :project_id => 1, :issue => {
1926 :tracker_id => 2,
1927 :status_id => 1,
1928 :subject => 'Test',
1929 :start_date => '2012-07-14',
1930 :due_date => '2012-07-16',
1931 :custom_field_values => {cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'}
1932 }
1933 assert_response 302
1934 end
1935
1936 issue = Issue.first(:order => 'id DESC')
1937 assert_equal Date.parse('2012-07-14'), issue.start_date
1938 assert_nil issue.due_date
1939 assert_equal 'value1', issue.custom_field_value(cf1)
1940 assert_nil issue.custom_field_value(cf2)
1941 end
1942
1943 def test_post_create_with_watchers
1944 @request.session[:user_id] = 2
1945 ActionMailer::Base.deliveries.clear
1946
1947 assert_difference 'Watcher.count', 2 do
1948 post :create, :project_id => 1,
1949 :issue => {:tracker_id => 1,
1950 :subject => 'This is a new issue with watchers',
1951 :description => 'This is the description',
1952 :priority_id => 5,
1953 :watcher_user_ids => ['2', '3']}
1954 end
1955 issue = Issue.find_by_subject('This is a new issue with watchers')
1956 assert_not_nil issue
1957 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
1958
1959 # Watchers added
1960 assert_equal [2, 3], issue.watcher_user_ids.sort
1961 assert issue.watched_by?(User.find(3))
1962 # Watchers notified
1963 mail = ActionMailer::Base.deliveries.last
1964 assert_not_nil mail
1965 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
1966 end
1967
1968 def test_post_create_subissue
1969 @request.session[:user_id] = 2
1970
1971 assert_difference 'Issue.count' do
1972 post :create, :project_id => 1,
1973 :issue => {:tracker_id => 1,
1974 :subject => 'This is a child issue',
1975 :parent_issue_id => '2'}
1976 assert_response 302
1977 end
1978 issue = Issue.order('id DESC').first
1979 assert_equal Issue.find(2), issue.parent
1980 end
1981
1982 def test_post_create_subissue_with_sharp_parent_id
1983 @request.session[:user_id] = 2
1984
1985 assert_difference 'Issue.count' do
1986 post :create, :project_id => 1,
1987 :issue => {:tracker_id => 1,
1988 :subject => 'This is a child issue',
1989 :parent_issue_id => '#2'}
1990 assert_response 302
1991 end
1992 issue = Issue.order('id DESC').first
1993 assert_equal Issue.find(2), issue.parent
1994 end
1995
1996 def test_post_create_subissue_with_non_visible_parent_id_should_not_validate
1997 @request.session[:user_id] = 2
1998
1999 assert_no_difference 'Issue.count' do
2000 post :create, :project_id => 1,
2001 :issue => {:tracker_id => 1,
2002 :subject => 'This is a child issue',
2003 :parent_issue_id => '4'}
2004
2005 assert_response :success
2006 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '4'
2007 assert_error_tag :content => /Parent task is invalid/i
2008 end
2009 end
2010
2011 def test_post_create_subissue_with_non_numeric_parent_id_should_not_validate
2012 @request.session[:user_id] = 2
2013
2014 assert_no_difference 'Issue.count' do
2015 post :create, :project_id => 1,
2016 :issue => {:tracker_id => 1,
2017 :subject => 'This is a child issue',
2018 :parent_issue_id => '01ABC'}
2019
2020 assert_response :success
2021 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '01ABC'
2022 assert_error_tag :content => /Parent task is invalid/i
2023 end
2024 end
2025
2026 def test_post_create_private
2027 @request.session[:user_id] = 2
2028
2029 assert_difference 'Issue.count' do
2030 post :create, :project_id => 1,
2031 :issue => {:tracker_id => 1,
2032 :subject => 'This is a private issue',
2033 :is_private => '1'}
2034 end
2035 issue = Issue.first(:order => 'id DESC')
2036 assert issue.is_private?
2037 end
2038
2039 def test_post_create_private_with_set_own_issues_private_permission
2040 role = Role.find(1)
2041 role.remove_permission! :set_issues_private
2042 role.add_permission! :set_own_issues_private
2043
2044 @request.session[:user_id] = 2
2045
2046 assert_difference 'Issue.count' do
2047 post :create, :project_id => 1,
2048 :issue => {:tracker_id => 1,
2049 :subject => 'This is a private issue',
2050 :is_private => '1'}
2051 end
2052 issue = Issue.first(:order => 'id DESC')
2053 assert issue.is_private?
2054 end
2055
2056 def test_post_create_should_send_a_notification
2057 ActionMailer::Base.deliveries.clear
2058 @request.session[:user_id] = 2
2059 assert_difference 'Issue.count' do
2060 post :create, :project_id => 1,
2061 :issue => {:tracker_id => 3,
2062 :subject => 'This is the test_new issue',
2063 :description => 'This is the description',
2064 :priority_id => 5,
2065 :estimated_hours => '',
2066 :custom_field_values => {'2' => 'Value for field 2'}}
2067 end
2068 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
2069
2070 assert_equal 1, ActionMailer::Base.deliveries.size
2071 end
2072
2073 def test_post_create_should_preserve_fields_values_on_validation_failure
2074 @request.session[:user_id] = 2
2075 post :create, :project_id => 1,
2076 :issue => {:tracker_id => 1,
2077 # empty subject
2078 :subject => '',
2079 :description => 'This is a description',
2080 :priority_id => 6,
2081 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
2082 assert_response :success
2083 assert_template 'new'
2084
2085 assert_tag :textarea, :attributes => { :name => 'issue[description]' },
2086 :content => "\nThis is a description"
2087 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
2088 :child => { :tag => 'option', :attributes => { :selected => 'selected',
2089 :value => '6' },
2090 :content => 'High' }
2091 # Custom fields
2092 assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
2093 :child => { :tag => 'option', :attributes => { :selected => 'selected',
2094 :value => 'Oracle' },
2095 :content => 'Oracle' }
2096 assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
2097 :value => 'Value for field 2'}
2098 end
2099
2100 def test_post_create_with_failure_should_preserve_watchers
2101 assert !User.find(8).member_of?(Project.find(1))
2102
2103 @request.session[:user_id] = 2
2104 post :create, :project_id => 1,
2105 :issue => {:tracker_id => 1,
2106 :watcher_user_ids => ['3', '8']}
2107 assert_response :success
2108 assert_template 'new'
2109
2110 assert_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]', :value => '2', :checked => nil}
2111 assert_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]', :value => '3', :checked => 'checked'}
2112 assert_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]', :value => '8', :checked => 'checked'}
2113 end
2114
2115 def test_post_create_should_ignore_non_safe_attributes
2116 @request.session[:user_id] = 2
2117 assert_nothing_raised do
2118 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
2119 end
2120 end
2121
2122 def test_post_create_with_attachment
2123 set_tmp_attachments_directory
2124 @request.session[:user_id] = 2
2125
2126 assert_difference 'Issue.count' do
2127 assert_difference 'Attachment.count' do
2128 post :create, :project_id => 1,
2129 :issue => { :tracker_id => '1', :subject => 'With attachment' },
2130 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2131 end
2132 end
2133
2134 issue = Issue.first(:order => 'id DESC')
2135 attachment = Attachment.first(:order => 'id DESC')
2136
2137 assert_equal issue, attachment.container
2138 assert_equal 2, attachment.author_id
2139 assert_equal 'testfile.txt', attachment.filename
2140 assert_equal 'text/plain', attachment.content_type
2141 assert_equal 'test file', attachment.description
2142 assert_equal 59, attachment.filesize
2143 assert File.exists?(attachment.diskfile)
2144 assert_equal 59, File.size(attachment.diskfile)
2145 end
2146
2147 def test_post_create_with_failure_should_save_attachments
2148 set_tmp_attachments_directory
2149 @request.session[:user_id] = 2
2150
2151 assert_no_difference 'Issue.count' do
2152 assert_difference 'Attachment.count' do
2153 post :create, :project_id => 1,
2154 :issue => { :tracker_id => '1', :subject => '' },
2155 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2156 assert_response :success
2157 assert_template 'new'
2158 end
2159 end
2160
2161 attachment = Attachment.first(:order => 'id DESC')
2162 assert_equal 'testfile.txt', attachment.filename
2163 assert File.exists?(attachment.diskfile)
2164 assert_nil attachment.container
2165
2166 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
2167 assert_tag 'span', :content => /testfile.txt/
2168 end
2169
2170 def test_post_create_with_failure_should_keep_saved_attachments
2171 set_tmp_attachments_directory
2172 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2173 @request.session[:user_id] = 2
2174
2175 assert_no_difference 'Issue.count' do
2176 assert_no_difference 'Attachment.count' do
2177 post :create, :project_id => 1,
2178 :issue => { :tracker_id => '1', :subject => '' },
2179 :attachments => {'p0' => {'token' => attachment.token}}
2180 assert_response :success
2181 assert_template 'new'
2182 end
2183 end
2184
2185 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
2186 assert_tag 'span', :content => /testfile.txt/
2187 end
2188
2189 def test_post_create_should_attach_saved_attachments
2190 set_tmp_attachments_directory
2191 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2192 @request.session[:user_id] = 2
2193
2194 assert_difference 'Issue.count' do
2195 assert_no_difference 'Attachment.count' do
2196 post :create, :project_id => 1,
2197 :issue => { :tracker_id => '1', :subject => 'Saved attachments' },
2198 :attachments => {'p0' => {'token' => attachment.token}}
2199 assert_response 302
2200 end
2201 end
2202
2203 issue = Issue.first(:order => 'id DESC')
2204 assert_equal 1, issue.attachments.count
2205
2206 attachment.reload
2207 assert_equal issue, attachment.container
2208 end
2209
2210 context "without workflow privilege" do
2211 setup do
2212 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2213 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2214 end
2215
2216 context "#new" do
2217 should "propose default status only" do
2218 get :new, :project_id => 1
2219 assert_response :success
2220 assert_template 'new'
2221 assert_tag :tag => 'select',
2222 :attributes => {:name => 'issue[status_id]'},
2223 :children => {:count => 1},
2224 :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
2225 end
2226
2227 should "accept default status" do
2228 assert_difference 'Issue.count' do
2229 post :create, :project_id => 1,
2230 :issue => {:tracker_id => 1,
2231 :subject => 'This is an issue',
2232 :status_id => 1}
2233 end
2234 issue = Issue.last(:order => 'id')
2235 assert_equal IssueStatus.default, issue.status
2236 end
2237
2238 should "ignore unauthorized status" do
2239 assert_difference 'Issue.count' do
2240 post :create, :project_id => 1,
2241 :issue => {:tracker_id => 1,
2242 :subject => 'This is an issue',
2243 :status_id => 3}
2244 end
2245 issue = Issue.last(:order => 'id')
2246 assert_equal IssueStatus.default, issue.status
2247 end
2248 end
2249
2250 context "#update" do
2251 should "ignore status change" do
2252 assert_difference 'Journal.count' do
2253 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2254 end
2255 assert_equal 1, Issue.find(1).status_id
2256 end
2257
2258 should "ignore attributes changes" do
2259 assert_difference 'Journal.count' do
2260 put :update, :id => 1, :issue => {:subject => 'changed', :assigned_to_id => 2, :notes => 'just trying'}
2261 end
2262 issue = Issue.find(1)
2263 assert_equal "Can't print recipes", issue.subject
2264 assert_nil issue.assigned_to
2265 end
2266 end
2267 end
2268
2269 context "with workflow privilege" do
2270 setup do
2271 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2272 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
2273 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
2274 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2275 end
2276
2277 context "#update" do
2278 should "accept authorized status" do
2279 assert_difference 'Journal.count' do
2280 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2281 end
2282 assert_equal 3, Issue.find(1).status_id
2283 end
2284
2285 should "ignore unauthorized status" do
2286 assert_difference 'Journal.count' do
2287 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2288 end
2289 assert_equal 1, Issue.find(1).status_id
2290 end
2291
2292 should "accept authorized attributes changes" do
2293 assert_difference 'Journal.count' do
2294 put :update, :id => 1, :issue => {:assigned_to_id => 2, :notes => 'just trying'}
2295 end
2296 issue = Issue.find(1)
2297 assert_equal 2, issue.assigned_to_id
2298 end
2299
2300 should "ignore unauthorized attributes changes" do
2301 assert_difference 'Journal.count' do
2302 put :update, :id => 1, :issue => {:subject => 'changed', :notes => 'just trying'}
2303 end
2304 issue = Issue.find(1)
2305 assert_equal "Can't print recipes", issue.subject
2306 end
2307 end
2308
2309 context "and :edit_issues permission" do
2310 setup do
2311 Role.anonymous.add_permission! :add_issues, :edit_issues
2312 end
2313
2314 should "accept authorized status" do
2315 assert_difference 'Journal.count' do
2316 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2317 end
2318 assert_equal 3, Issue.find(1).status_id
2319 end
2320
2321 should "ignore unauthorized status" do
2322 assert_difference 'Journal.count' do
2323 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2324 end
2325 assert_equal 1, Issue.find(1).status_id
2326 end
2327
2328 should "accept authorized attributes changes" do
2329 assert_difference 'Journal.count' do
2330 put :update, :id => 1, :issue => {:subject => 'changed', :assigned_to_id => 2, :notes => 'just trying'}
2331 end
2332 issue = Issue.find(1)
2333 assert_equal "changed", issue.subject
2334 assert_equal 2, issue.assigned_to_id
2335 end
2336 end
2337 end
2338
2339 def test_new_as_copy
2340 @request.session[:user_id] = 2
2341 get :new, :project_id => 1, :copy_from => 1
2342
2343 assert_response :success
2344 assert_template 'new'
2345
2346 assert_not_nil assigns(:issue)
2347 orig = Issue.find(1)
2348 assert_equal 1, assigns(:issue).project_id
2349 assert_equal orig.subject, assigns(:issue).subject
2350 assert assigns(:issue).copy?
2351
2352 assert_tag 'form', :attributes => {:id => 'issue-form', :action => '/projects/ecookbook/issues'}
2353 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
2354 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
2355 :child => {:tag => 'option', :attributes => {:value => '1', :selected => 'selected'}, :content => 'eCookbook'}
2356 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
2357 :child => {:tag => 'option', :attributes => {:value => '2', :selected => nil}, :content => 'OnlineStore'}
2358 assert_tag 'input', :attributes => {:name => 'copy_from', :value => '1'}
2359
2360 # "New issue" menu item should not link to copy
2361 assert_select '#main-menu a.new-issue[href=/projects/ecookbook/issues/new]'
2362 end
2363
2364 def test_new_as_copy_with_attachments_should_show_copy_attachments_checkbox
2365 @request.session[:user_id] = 2
2366 issue = Issue.find(3)
2367 assert issue.attachments.count > 0
2368 get :new, :project_id => 1, :copy_from => 3
2369
2370 assert_tag 'input', :attributes => {:name => 'copy_attachments', :type => 'checkbox', :checked => 'checked', :value => '1'}
2371 end
2372
2373 def test_new_as_copy_without_attachments_should_not_show_copy_attachments_checkbox
2374 @request.session[:user_id] = 2
2375 issue = Issue.find(3)
2376 issue.attachments.delete_all
2377 get :new, :project_id => 1, :copy_from => 3
2378
2379 assert_no_tag 'input', :attributes => {:name => 'copy_attachments', :type => 'checkbox', :checked => 'checked', :value => '1'}
2380 end
2381
2382 def test_new_as_copy_with_subtasks_should_show_copy_subtasks_checkbox
2383 @request.session[:user_id] = 2
2384 issue = Issue.generate_with_descendants!
2385 get :new, :project_id => 1, :copy_from => issue.id
2386
2387 assert_select 'input[type=checkbox][name=copy_subtasks][checked=checked][value=1]'
2388 end
2389
2390 def test_new_as_copy_with_invalid_issue_should_respond_with_404
2391 @request.session[:user_id] = 2
2392 get :new, :project_id => 1, :copy_from => 99999
2393 assert_response 404
2394 end
2395
2396 def test_create_as_copy_on_different_project
2397 @request.session[:user_id] = 2
2398 assert_difference 'Issue.count' do
2399 post :create, :project_id => 1, :copy_from => 1,
2400 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2401
2402 assert_not_nil assigns(:issue)
2403 assert assigns(:issue).copy?
2404 end
2405 issue = Issue.first(:order => 'id DESC')
2406 assert_redirected_to "/issues/#{issue.id}"
2407
2408 assert_equal 2, issue.project_id
2409 assert_equal 3, issue.tracker_id
2410 assert_equal 'Copy', issue.subject
2411 end
2412
2413 def test_create_as_copy_should_copy_attachments
2414 @request.session[:user_id] = 2
2415 issue = Issue.find(3)
2416 count = issue.attachments.count
2417 assert count > 0
2418
2419 assert_difference 'Issue.count' do
2420 assert_difference 'Attachment.count', count do
2421 assert_no_difference 'Journal.count' do
2422 post :create, :project_id => 1, :copy_from => 3,
2423 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
2424 :copy_attachments => '1'
2425 end
2426 end
2427 end
2428 copy = Issue.first(:order => 'id DESC')
2429 assert_equal count, copy.attachments.count
2430 assert_equal issue.attachments.map(&:filename).sort, copy.attachments.map(&:filename).sort
2431 end
2432
2433 def test_create_as_copy_without_copy_attachments_option_should_not_copy_attachments
2434 @request.session[:user_id] = 2
2435 issue = Issue.find(3)
2436 count = issue.attachments.count
2437 assert count > 0
2438
2439 assert_difference 'Issue.count' do
2440 assert_no_difference 'Attachment.count' do
2441 assert_no_difference 'Journal.count' do
2442 post :create, :project_id => 1, :copy_from => 3,
2443 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'}
2444 end
2445 end
2446 end
2447 copy = Issue.first(:order => 'id DESC')
2448 assert_equal 0, copy.attachments.count
2449 end
2450
2451 def test_create_as_copy_with_attachments_should_add_new_files
2452 @request.session[:user_id] = 2
2453 issue = Issue.find(3)
2454 count = issue.attachments.count
2455 assert count > 0
2456
2457 assert_difference 'Issue.count' do
2458 assert_difference 'Attachment.count', count + 1 do
2459 assert_no_difference 'Journal.count' do
2460 post :create, :project_id => 1, :copy_from => 3,
2461 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
2462 :copy_attachments => '1',
2463 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2464 end
2465 end
2466 end
2467 copy = Issue.first(:order => 'id DESC')
2468 assert_equal count + 1, copy.attachments.count
2469 end
2470
2471 def test_create_as_copy_should_add_relation_with_copied_issue
2472 @request.session[:user_id] = 2
2473
2474 assert_difference 'Issue.count' do
2475 assert_difference 'IssueRelation.count' do
2476 post :create, :project_id => 1, :copy_from => 1,
2477 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2478 end
2479 end
2480 copy = Issue.first(:order => 'id DESC')
2481 assert_equal 1, copy.relations.size
2482 end
2483
2484 def test_create_as_copy_should_copy_subtasks
2485 @request.session[:user_id] = 2
2486 issue = Issue.generate_with_descendants!
2487 count = issue.descendants.count
2488
2489 assert_difference 'Issue.count', count+1 do
2490 assert_no_difference 'Journal.count' do
2491 post :create, :project_id => 1, :copy_from => issue.id,
2492 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with subtasks'},
2493 :copy_subtasks => '1'
2494 end
2495 end
2496 copy = Issue.where(:parent_id => nil).first(:order => 'id DESC')
2497 assert_equal count, copy.descendants.count
2498 assert_equal issue.descendants.map(&:subject).sort, copy.descendants.map(&:subject).sort
2499 end
2500
2501 def test_create_as_copy_without_copy_subtasks_option_should_not_copy_subtasks
2502 @request.session[:user_id] = 2
2503 issue = Issue.generate_with_descendants!
2504
2505 assert_difference 'Issue.count', 1 do
2506 assert_no_difference 'Journal.count' do
2507 post :create, :project_id => 1, :copy_from => 3,
2508 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with subtasks'}
2509 end
2510 end
2511 copy = Issue.where(:parent_id => nil).first(:order => 'id DESC')
2512 assert_equal 0, copy.descendants.count
2513 end
2514
2515 def test_create_as_copy_with_failure
2516 @request.session[:user_id] = 2
2517 post :create, :project_id => 1, :copy_from => 1,
2518 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => ''}
2519
2520 assert_response :success
2521 assert_template 'new'
2522
2523 assert_not_nil assigns(:issue)
2524 assert assigns(:issue).copy?
2525
2526 assert_tag 'form', :attributes => {:id => 'issue-form', :action => '/projects/ecookbook/issues'}
2527 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
2528 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
2529 :child => {:tag => 'option', :attributes => {:value => '1', :selected => nil}, :content => 'eCookbook'}
2530 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
2531 :child => {:tag => 'option', :attributes => {:value => '2', :selected => 'selected'}, :content => 'OnlineStore'}
2532 assert_tag 'input', :attributes => {:name => 'copy_from', :value => '1'}
2533 end
2534
2535 def test_create_as_copy_on_project_without_permission_should_ignore_target_project
2536 @request.session[:user_id] = 2
2537 assert !User.find(2).member_of?(Project.find(4))
2538
2539 assert_difference 'Issue.count' do
2540 post :create, :project_id => 1, :copy_from => 1,
2541 :issue => {:project_id => '4', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2542 end
2543 issue = Issue.first(:order => 'id DESC')
2544 assert_equal 1, issue.project_id
2545 end
2546
2547 def test_get_edit
2548 @request.session[:user_id] = 2
2549 get :edit, :id => 1
2550 assert_response :success
2551 assert_template 'edit'
2552 assert_not_nil assigns(:issue)
2553 assert_equal Issue.find(1), assigns(:issue)
2554
2555 # Be sure we don't display inactive IssuePriorities
2556 assert ! IssuePriority.find(15).active?
2557 assert_no_tag :option, :attributes => {:value => '15'},
2558 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
2559 end
2560
2561 def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
2562 @request.session[:user_id] = 2
2563 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
2564
2565 get :edit, :id => 1
2566 assert_tag 'input', :attributes => {:name => 'time_entry[hours]'}
2567 end
2568
2569 def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
2570 @request.session[:user_id] = 2
2571 Role.find_by_name('Manager').remove_permission! :log_time
2572
2573 get :edit, :id => 1
2574 assert_no_tag 'input', :attributes => {:name => 'time_entry[hours]'}
2575 end
2576
2577 def test_get_edit_with_params
2578 @request.session[:user_id] = 2
2579 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
2580 :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => TimeEntryActivity.first.id }
2581 assert_response :success
2582 assert_template 'edit'
2583
2584 issue = assigns(:issue)
2585 assert_not_nil issue
2586
2587 assert_equal 5, issue.status_id
2588 assert_tag :select, :attributes => { :name => 'issue[status_id]' },
2589 :child => { :tag => 'option',
2590 :content => 'Closed',
2591 :attributes => { :selected => 'selected' } }
2592
2593 assert_equal 7, issue.priority_id
2594 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
2595 :child => { :tag => 'option',
2596 :content => 'Urgent',
2597 :attributes => { :selected => 'selected' } }
2598
2599 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => '2.5' }
2600 assert_tag :select, :attributes => { :name => 'time_entry[activity_id]' },
2601 :child => { :tag => 'option',
2602 :attributes => { :selected => 'selected', :value => TimeEntryActivity.first.id } }
2603 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => 'test_get_edit_with_params' }
2604 end
2605
2606 def test_get_edit_with_multi_custom_field
2607 field = CustomField.find(1)
2608 field.update_attribute :multiple, true
2609 issue = Issue.find(1)
2610 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2611 issue.save!
2612
2613 @request.session[:user_id] = 2
2614 get :edit, :id => 1
2615 assert_response :success
2616 assert_template 'edit'
2617
2618 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]', :multiple => 'multiple'}
2619 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]'},
2620 :child => {:tag => 'option', :attributes => {:value => 'MySQL', :selected => 'selected'}}
2621 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]'},
2622 :child => {:tag => 'option', :attributes => {:value => 'PostgreSQL', :selected => nil}}
2623 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]'},
2624 :child => {:tag => 'option', :attributes => {:value => 'Oracle', :selected => 'selected'}}
2625 end
2626
2627 def test_update_edit_form
2628 @request.session[:user_id] = 2
2629 xhr :put, :new, :project_id => 1,
2630 :id => 1,
2631 :issue => {:tracker_id => 2,
2632 :subject => 'This is the test_new issue',
2633 :description => 'This is the description',
2634 :priority_id => 5}
2635 assert_response :success
2636 assert_equal 'text/javascript', response.content_type
2637 assert_template 'update_form'
2638 assert_template 'form'
2639
2640 issue = assigns(:issue)
2641 assert_kind_of Issue, issue
2642 assert_equal 1, issue.id
2643 assert_equal 1, issue.project_id
2644 assert_equal 2, issue.tracker_id
2645 assert_equal 'This is the test_new issue', issue.subject
2646 end
2647
2648 def test_update_edit_form_should_keep_issue_author
2649 @request.session[:user_id] = 3
2650 xhr :put, :new, :project_id => 1, :id => 1, :issue => {:subject => 'Changed'}
2651 assert_response :success
2652 assert_equal 'text/javascript', response.content_type
2653
2654 issue = assigns(:issue)
2655 assert_equal User.find(2), issue.author
2656 assert_equal 2, issue.author_id
2657 assert_not_equal User.current, issue.author
2658 end
2659
2660 def test_update_edit_form_should_propose_transitions_based_on_initial_status
2661 @request.session[:user_id] = 2
2662 WorkflowTransition.delete_all
2663 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
2664 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
2665 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 5, :new_status_id => 4)
2666
2667 xhr :put, :new, :project_id => 1,
2668 :id => 2,
2669 :issue => {:tracker_id => 2,
2670 :status_id => 5,
2671 :subject => 'This is an issue'}
2672
2673 assert_equal 5, assigns(:issue).status_id
2674 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
2675 end
2676
2677 def test_update_edit_form_with_project_change
2678 @request.session[:user_id] = 2
2679 xhr :put, :new, :project_id => 1,
2680 :id => 1,
2681 :issue => {:project_id => 2,
2682 :tracker_id => 2,
2683 :subject => 'This is the test_new issue',
2684 :description => 'This is the description',
2685 :priority_id => 5}
2686 assert_response :success
2687 assert_template 'form'
2688
2689 issue = assigns(:issue)
2690 assert_kind_of Issue, issue
2691 assert_equal 1, issue.id
2692 assert_equal 2, issue.project_id
2693 assert_equal 2, issue.tracker_id
2694 assert_equal 'This is the test_new issue', issue.subject
2695 end
2696
2697 def test_put_update_without_custom_fields_param
2698 @request.session[:user_id] = 2
2699 ActionMailer::Base.deliveries.clear
2700
2701 issue = Issue.find(1)
2702 assert_equal '125', issue.custom_value_for(2).value
2703 old_subject = issue.subject
2704 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
2705
2706 assert_difference('Journal.count') do
2707 assert_difference('JournalDetail.count', 2) do
2708 put :update, :id => 1, :issue => {:subject => new_subject,
2709 :priority_id => '6',
2710 :category_id => '1' # no change
2711 }
2712 end
2713 end
2714 assert_redirected_to :action => 'show', :id => '1'
2715 issue.reload
2716 assert_equal new_subject, issue.subject
2717 # Make sure custom fields were not cleared
2718 assert_equal '125', issue.custom_value_for(2).value
2719
2720 mail = ActionMailer::Base.deliveries.last
2721 assert_not_nil mail
2722 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2723 assert_mail_body_match "Subject changed from #{old_subject} to #{new_subject}", mail
2724 end
2725
2726 def test_put_update_with_project_change
2727 @request.session[:user_id] = 2
2728 ActionMailer::Base.deliveries.clear
2729
2730 assert_difference('Journal.count') do
2731 assert_difference('JournalDetail.count', 3) do
2732 put :update, :id => 1, :issue => {:project_id => '2',
2733 :tracker_id => '1', # no change
2734 :priority_id => '6',
2735 :category_id => '3'
2736 }
2737 end
2738 end
2739 assert_redirected_to :action => 'show', :id => '1'
2740 issue = Issue.find(1)
2741 assert_equal 2, issue.project_id
2742 assert_equal 1, issue.tracker_id
2743 assert_equal 6, issue.priority_id
2744 assert_equal 3, issue.category_id
2745
2746 mail = ActionMailer::Base.deliveries.last
2747 assert_not_nil mail
2748 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2749 assert_mail_body_match "Project changed from eCookbook to OnlineStore", mail
2750 end
2751
2752 def test_put_update_with_tracker_change
2753 @request.session[:user_id] = 2
2754 ActionMailer::Base.deliveries.clear
2755
2756 assert_difference('Journal.count') do
2757 assert_difference('JournalDetail.count', 2) do
2758 put :update, :id => 1, :issue => {:project_id => '1',
2759 :tracker_id => '2',
2760 :priority_id => '6'
2761 }
2762 end
2763 end
2764 assert_redirected_to :action => 'show', :id => '1'
2765 issue = Issue.find(1)
2766 assert_equal 1, issue.project_id
2767 assert_equal 2, issue.tracker_id
2768 assert_equal 6, issue.priority_id
2769 assert_equal 1, issue.category_id
2770
2771 mail = ActionMailer::Base.deliveries.last
2772 assert_not_nil mail
2773 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2774 assert_mail_body_match "Tracker changed from Bug to Feature request", mail
2775 end
2776
2777 def test_put_update_with_custom_field_change
2778 @request.session[:user_id] = 2
2779 issue = Issue.find(1)
2780 assert_equal '125', issue.custom_value_for(2).value
2781
2782 assert_difference('Journal.count') do
2783 assert_difference('JournalDetail.count', 3) do
2784 put :update, :id => 1, :issue => {:subject => 'Custom field change',
2785 :priority_id => '6',
2786 :category_id => '1', # no change
2787 :custom_field_values => { '2' => 'New custom value' }
2788 }
2789 end
2790 end
2791 assert_redirected_to :action => 'show', :id => '1'
2792 issue.reload
2793 assert_equal 'New custom value', issue.custom_value_for(2).value
2794
2795 mail = ActionMailer::Base.deliveries.last
2796 assert_not_nil mail
2797 assert_mail_body_match "Searchable field changed from 125 to New custom value", mail
2798 end
2799
2800 def test_put_update_with_multi_custom_field_change
2801 field = CustomField.find(1)
2802 field.update_attribute :multiple, true
2803 issue = Issue.find(1)
2804 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2805 issue.save!
2806
2807 @request.session[:user_id] = 2
2808 assert_difference('Journal.count') do
2809 assert_difference('JournalDetail.count', 3) do
2810 put :update, :id => 1,
2811 :issue => {
2812 :subject => 'Custom field change',
2813 :custom_field_values => { '1' => ['', 'Oracle', 'PostgreSQL'] }
2814 }
2815 end
2816 end
2817 assert_redirected_to :action => 'show', :id => '1'
2818 assert_equal ['Oracle', 'PostgreSQL'], Issue.find(1).custom_field_value(1).sort
2819 end
2820
2821 def test_put_update_with_status_and_assignee_change
2822 issue = Issue.find(1)
2823 assert_equal 1, issue.status_id
2824 @request.session[:user_id] = 2
2825 assert_difference('TimeEntry.count', 0) do
2826 put :update,
2827 :id => 1,
2828 :issue => { :status_id => 2, :assigned_to_id => 3, :notes => 'Assigned to dlopper' },
2829 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
2830 end
2831 assert_redirected_to :action => 'show', :id => '1'
2832 issue.reload
2833 assert_equal 2, issue.status_id
2834 j = Journal.find(:first, :order => 'id DESC')
2835 assert_equal 'Assigned to dlopper', j.notes
2836 assert_equal 2, j.details.size
2837
2838 mail = ActionMailer::Base.deliveries.last
2839 assert_mail_body_match "Status changed from New to Assigned", mail
2840 # subject should contain the new status
2841 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
2842 end
2843
2844 def test_put_update_with_note_only
2845 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
2846 # anonymous user
2847 put :update,
2848 :id => 1,
2849 :issue => { :notes => notes }
2850 assert_redirected_to :action => 'show', :id => '1'
2851 j = Journal.find(:first, :order => 'id DESC')
2852 assert_equal notes, j.notes
2853 assert_equal 0, j.details.size
2854 assert_equal User.anonymous, j.user
2855
2856 mail = ActionMailer::Base.deliveries.last
2857 assert_mail_body_match notes, mail
2858 end
2859
2860 def test_put_update_with_private_note_only
2861 notes = 'Private note'
2862 @request.session[:user_id] = 2
2863
2864 assert_difference 'Journal.count' do
2865 put :update, :id => 1, :issue => {:notes => notes, :private_notes => '1'}
2866 assert_redirected_to :action => 'show', :id => '1'
2867 end
2868
2869 j = Journal.order('id DESC').first
2870 assert_equal notes, j.notes
2871 assert_equal true, j.private_notes
2872 end
2873
2874 def test_put_update_with_private_note_and_changes
2875 notes = 'Private note'
2876 @request.session[:user_id] = 2
2877
2878 assert_difference 'Journal.count', 2 do
2879 put :update, :id => 1, :issue => {:subject => 'New subject', :notes => notes, :private_notes => '1'}
2880 assert_redirected_to :action => 'show', :id => '1'
2881 end
2882
2883 j = Journal.order('id DESC').first
2884 assert_equal notes, j.notes
2885 assert_equal true, j.private_notes
2886 assert_equal 0, j.details.count
2887
2888 j = Journal.order('id DESC').offset(1).first
2889 assert_nil j.notes
2890 assert_equal false, j.private_notes
2891 assert_equal 1, j.details.count
2892 end
2893
2894 def test_put_update_with_note_and_spent_time
2895 @request.session[:user_id] = 2
2896 spent_hours_before = Issue.find(1).spent_hours
2897 assert_difference('TimeEntry.count') do
2898 put :update,
2899 :id => 1,
2900 :issue => { :notes => '2.5 hours added' },
2901 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
2902 end
2903 assert_redirected_to :action => 'show', :id => '1'
2904
2905 issue = Issue.find(1)
2906
2907 j = Journal.find(:first, :order => 'id DESC')
2908 assert_equal '2.5 hours added', j.notes
2909 assert_equal 0, j.details.size
2910
2911 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
2912 assert_not_nil t
2913 assert_equal 2.5, t.hours
2914 assert_equal spent_hours_before + 2.5, issue.spent_hours
2915 end
2916
2917 def test_put_update_should_preserve_parent_issue_even_if_not_visible
2918 parent = Issue.generate!(:project_id => 1, :is_private => true)
2919 issue = Issue.generate!(:parent_issue_id => parent.id)
2920 assert !parent.visible?(User.find(3))
2921 @request.session[:user_id] = 3
2922
2923 get :edit, :id => issue.id
2924 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', parent.id.to_s
2925
2926 put :update, :id => issue.id, :issue => {:subject => 'New subject', :parent_issue_id => parent.id.to_s}
2927 assert_response 302
2928 assert_equal parent, issue.parent
2929 end
2930
2931 def test_put_update_with_attachment_only
2932 set_tmp_attachments_directory
2933
2934 # Delete all fixtured journals, a race condition can occur causing the wrong
2935 # journal to get fetched in the next find.
2936 Journal.delete_all
2937
2938 # anonymous user
2939 assert_difference 'Attachment.count' do
2940 put :update, :id => 1,
2941 :issue => {:notes => ''},
2942 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2943 end
2944
2945 assert_redirected_to :action => 'show', :id => '1'
2946 j = Issue.find(1).journals.find(:first, :order => 'id DESC')
2947 assert j.notes.blank?
2948 assert_equal 1, j.details.size
2949 assert_equal 'testfile.txt', j.details.first.value
2950 assert_equal User.anonymous, j.user
2951
2952 attachment = Attachment.first(:order => 'id DESC')
2953 assert_equal Issue.find(1), attachment.container
2954 assert_equal User.anonymous, attachment.author
2955 assert_equal 'testfile.txt', attachment.filename
2956 assert_equal 'text/plain', attachment.content_type
2957 assert_equal 'test file', attachment.description
2958 assert_equal 59, attachment.filesize
2959 assert File.exists?(attachment.diskfile)
2960 assert_equal 59, File.size(attachment.diskfile)
2961
2962 mail = ActionMailer::Base.deliveries.last
2963 assert_mail_body_match 'testfile.txt', mail
2964 end
2965
2966 def test_put_update_with_failure_should_save_attachments
2967 set_tmp_attachments_directory
2968 @request.session[:user_id] = 2
2969
2970 assert_no_difference 'Journal.count' do
2971 assert_difference 'Attachment.count' do
2972 put :update, :id => 1,
2973 :issue => { :subject => '' },
2974 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2975 assert_response :success
2976 assert_template 'edit'
2977 end
2978 end
2979
2980 attachment = Attachment.first(:order => 'id DESC')
2981 assert_equal 'testfile.txt', attachment.filename
2982 assert File.exists?(attachment.diskfile)
2983 assert_nil attachment.container
2984
2985 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
2986 assert_tag 'span', :content => /testfile.txt/
2987 end
2988
2989 def test_put_update_with_failure_should_keep_saved_attachments
2990 set_tmp_attachments_directory
2991 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2992 @request.session[:user_id] = 2
2993
2994 assert_no_difference 'Journal.count' do
2995 assert_no_difference 'Attachment.count' do
2996 put :update, :id => 1,
2997 :issue => { :subject => '' },
2998 :attachments => {'p0' => {'token' => attachment.token}}
2999 assert_response :success
3000 assert_template 'edit'
3001 end
3002 end
3003
3004 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
3005 assert_tag 'span', :content => /testfile.txt/
3006 end
3007
3008 def test_put_update_should_attach_saved_attachments
3009 set_tmp_attachments_directory
3010 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
3011 @request.session[:user_id] = 2
3012
3013 assert_difference 'Journal.count' do
3014 assert_difference 'JournalDetail.count' do
3015 assert_no_difference 'Attachment.count' do
3016 put :update, :id => 1,
3017 :issue => {:notes => 'Attachment added'},
3018 :attachments => {'p0' => {'token' => attachment.token}}
3019 assert_redirected_to '/issues/1'
3020 end
3021 end
3022 end
3023
3024 attachment.reload
3025 assert_equal Issue.find(1), attachment.container
3026
3027 journal = Journal.first(:order => 'id DESC')
3028 assert_equal 1, journal.details.size
3029 assert_equal 'testfile.txt', journal.details.first.value
3030 end
3031
3032 def test_put_update_with_attachment_that_fails_to_save
3033 set_tmp_attachments_directory
3034
3035 # Delete all fixtured journals, a race condition can occur causing the wrong
3036 # journal to get fetched in the next find.
3037 Journal.delete_all
3038
3039 # Mock out the unsaved attachment
3040 Attachment.any_instance.stubs(:create).returns(Attachment.new)
3041
3042 # anonymous user
3043 put :update,
3044 :id => 1,
3045 :issue => {:notes => ''},
3046 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
3047 assert_redirected_to :action => 'show', :id => '1'
3048 assert_equal '1 file(s) could not be saved.', flash[:warning]
3049 end
3050
3051 def test_put_update_with_no_change
3052 issue = Issue.find(1)
3053 issue.journals.clear
3054 ActionMailer::Base.deliveries.clear
3055
3056 put :update,
3057 :id => 1,
3058 :issue => {:notes => ''}
3059 assert_redirected_to :action => 'show', :id => '1'
3060
3061 issue.reload
3062 assert issue.journals.empty?
3063 # No email should be sent
3064 assert ActionMailer::Base.deliveries.empty?
3065 end
3066
3067 def test_put_update_should_send_a_notification
3068 @request.session[:user_id] = 2
3069 ActionMailer::Base.deliveries.clear
3070 issue = Issue.find(1)
3071 old_subject = issue.subject
3072 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
3073
3074 put :update, :id => 1, :issue => {:subject => new_subject,
3075 :priority_id => '6',
3076 :category_id => '1' # no change
3077 }
3078 assert_equal 1, ActionMailer::Base.deliveries.size
3079 end
3080
3081 def test_put_update_with_invalid_spent_time_hours_only
3082 @request.session[:user_id] = 2
3083 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3084
3085 assert_no_difference('Journal.count') do
3086 put :update,
3087 :id => 1,
3088 :issue => {:notes => notes},
3089 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
3090 end
3091 assert_response :success
3092 assert_template 'edit'
3093
3094 assert_error_tag :descendant => {:content => /Activity can&#x27;t be blank/}
3095 assert_tag :textarea, :attributes => { :name => 'issue[notes]' }, :content => "\n"+notes
3096 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
3097 end
3098
3099 def test_put_update_with_invalid_spent_time_comments_only
3100 @request.session[:user_id] = 2
3101 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3102
3103 assert_no_difference('Journal.count') do
3104 put :update,
3105 :id => 1,
3106 :issue => {:notes => notes},
3107 :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
3108 end
3109 assert_response :success
3110 assert_template 'edit'
3111
3112 assert_error_tag :descendant => {:content => /Activity can&#x27;t be blank/}
3113 assert_error_tag :descendant => {:content => /Hours can&#x27;t be blank/}
3114 assert_tag :textarea, :attributes => { :name => 'issue[notes]' }, :content => "\n"+notes
3115 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => "this is my comment" }
3116 end
3117
3118 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
3119 issue = Issue.find(2)
3120 @request.session[:user_id] = 2
3121
3122 put :update,
3123 :id => issue.id,
3124 :issue => {
3125 :fixed_version_id => 4
3126 }
3127
3128 assert_response :redirect
3129 issue.reload
3130 assert_equal 4, issue.fixed_version_id
3131 assert_not_equal issue.project_id, issue.fixed_version.project_id
3132 end
3133
3134 def test_put_update_should_redirect_back_using_the_back_url_parameter
3135 issue = Issue.find(2)
3136 @request.session[:user_id] = 2
3137
3138 put :update,
3139 :id => issue.id,
3140 :issue => {
3141 :fixed_version_id => 4
3142 },
3143 :back_url => '/issues'
3144
3145 assert_response :redirect
3146 assert_redirected_to '/issues'
3147 end
3148
3149 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3150 issue = Issue.find(2)
3151 @request.session[:user_id] = 2
3152
3153 put :update,
3154 :id => issue.id,
3155 :issue => {
3156 :fixed_version_id => 4
3157 },
3158 :back_url => 'http://google.com'
3159
3160 assert_response :redirect
3161 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
3162 end
3163
3164 def test_get_bulk_edit
3165 @request.session[:user_id] = 2
3166 get :bulk_edit, :ids => [1, 2]
3167 assert_response :success
3168 assert_template 'bulk_edit'
3169
3170 assert_tag :select, :attributes => {:name => 'issue[project_id]'}
3171 assert_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
3172
3173 # Project specific custom field, date type
3174 field = CustomField.find(9)
3175 assert !field.is_for_all?
3176 assert_equal 'date', field.field_format
3177 assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
3178
3179 # System wide custom field
3180 assert CustomField.find(1).is_for_all?
3181 assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
3182
3183 # Be sure we don't display inactive IssuePriorities
3184 assert ! IssuePriority.find(15).active?
3185 assert_no_tag :option, :attributes => {:value => '15'},
3186 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
3187 end
3188
3189 def test_get_bulk_edit_on_different_projects
3190 @request.session[:user_id] = 2
3191 get :bulk_edit, :ids => [1, 2, 6]
3192 assert_response :success
3193 assert_template 'bulk_edit'
3194
3195 # Can not set issues from different projects as children of an issue
3196 assert_no_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
3197
3198 # Project specific custom field, date type
3199 field = CustomField.find(9)
3200 assert !field.is_for_all?
3201 assert !field.project_ids.include?(Issue.find(6).project_id)
3202 assert_no_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
3203 end
3204
3205 def test_get_bulk_edit_with_user_custom_field
3206 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
3207
3208 @request.session[:user_id] = 2
3209 get :bulk_edit, :ids => [1, 2]
3210 assert_response :success
3211 assert_template 'bulk_edit'
3212
3213 assert_tag :select,
3214 :attributes => {:name => "issue[custom_field_values][#{field.id}]", :class => 'user_cf'},
3215 :children => {
3216 :only => {:tag => 'option'},
3217 :count => Project.find(1).users.count + 2 # "no change" + "none" options
3218 }
3219 end
3220
3221 def test_get_bulk_edit_with_version_custom_field
3222 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
3223
3224 @request.session[:user_id] = 2
3225 get :bulk_edit, :ids => [1, 2]
3226 assert_response :success
3227 assert_template 'bulk_edit'
3228
3229 assert_tag :select,
3230 :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
3231 :children => {
3232 :only => {:tag => 'option'},
3233 :count => Project.find(1).shared_versions.count + 2 # "no change" + "none" options
3234 }
3235 end
3236
3237 def test_get_bulk_edit_with_multi_custom_field
3238 field = CustomField.find(1)
3239 field.update_attribute :multiple, true
3240
3241 @request.session[:user_id] = 2
3242 get :bulk_edit, :ids => [1, 2]
3243 assert_response :success
3244 assert_template 'bulk_edit'
3245
3246 assert_tag :select,
3247 :attributes => {:name => "issue[custom_field_values][1][]"},
3248 :children => {
3249 :only => {:tag => 'option'},
3250 :count => field.possible_values.size + 1 # "none" options
3251 }
3252 end
3253
3254 def test_bulk_edit_should_only_propose_statuses_allowed_for_all_issues
3255 WorkflowTransition.delete_all
3256 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 1)
3257 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
3258 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
3259 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
3260 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3)
3261 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
3262 @request.session[:user_id] = 2
3263 get :bulk_edit, :ids => [1, 2]
3264
3265 assert_response :success
3266 statuses = assigns(:available_statuses)
3267 assert_not_nil statuses
3268 assert_equal [1, 3], statuses.map(&:id).sort
3269
3270 assert_tag 'select', :attributes => {:name => 'issue[status_id]'},
3271 :children => {:count => 3} # 2 statuses + "no change" option
3272 end
3273
3274 def test_bulk_edit_should_propose_target_project_open_shared_versions
3275 @request.session[:user_id] = 2
3276 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3277 assert_response :success
3278 assert_template 'bulk_edit'
3279 assert_equal Project.find(1).shared_versions.open.all.sort, assigns(:versions).sort
3280 assert_tag 'select',
3281 :attributes => {:name => 'issue[fixed_version_id]'},
3282 :descendant => {:tag => 'option', :content => '2.0'}
3283 end
3284
3285 def test_bulk_edit_should_propose_target_project_categories
3286 @request.session[:user_id] = 2
3287 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3288 assert_response :success
3289 assert_template 'bulk_edit'
3290 assert_equal Project.find(1).issue_categories.sort, assigns(:categories).sort
3291 assert_tag 'select',
3292 :attributes => {:name => 'issue[category_id]'},
3293 :descendant => {:tag => 'option', :content => 'Recipes'}
3294 end
3295
3296 def test_bulk_update
3297 @request.session[:user_id] = 2
3298 # update issues priority
3299 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3300 :issue => {:priority_id => 7,
3301 :assigned_to_id => '',
3302 :custom_field_values => {'2' => ''}}
3303
3304 assert_response 302
3305 # check that the issues were updated
3306 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
3307
3308 issue = Issue.find(1)
3309 journal = issue.journals.find(:first, :order => 'created_on DESC')
3310 assert_equal '125', issue.custom_value_for(2).value
3311 assert_equal 'Bulk editing', journal.notes
3312 assert_equal 1, journal.details.size
3313 end
3314
3315 def test_bulk_update_with_group_assignee
3316 group = Group.find(11)
3317 project = Project.find(1)
3318 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
3319
3320 @request.session[:user_id] = 2
3321 # update issues assignee
3322 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3323 :issue => {:priority_id => '',
3324 :assigned_to_id => group.id,
3325 :custom_field_values => {'2' => ''}}
3326
3327 assert_response 302
3328 assert_equal [group, group], Issue.find_all_by_id([1, 2]).collect {|i| i.assigned_to}
3329 end
3330
3331 def test_bulk_update_on_different_projects
3332 @request.session[:user_id] = 2
3333 # update issues priority
3334 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
3335 :issue => {:priority_id => 7,
3336 :assigned_to_id => '',
3337 :custom_field_values => {'2' => ''}}
3338
3339 assert_response 302
3340 # check that the issues were updated
3341 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
3342
3343 issue = Issue.find(1)
3344 journal = issue.journals.find(:first, :order => 'created_on DESC')
3345 assert_equal '125', issue.custom_value_for(2).value
3346 assert_equal 'Bulk editing', journal.notes
3347 assert_equal 1, journal.details.size
3348 end
3349
3350 def test_bulk_update_on_different_projects_without_rights
3351 @request.session[:user_id] = 3
3352 user = User.find(3)
3353 action = { :controller => "issues", :action => "bulk_update" }
3354 assert user.allowed_to?(action, Issue.find(1).project)
3355 assert ! user.allowed_to?(action, Issue.find(6).project)
3356 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
3357 :issue => {:priority_id => 7,
3358 :assigned_to_id => '',
3359 :custom_field_values => {'2' => ''}}
3360 assert_response 403
3361 assert_not_equal "Bulk should fail", Journal.last.notes
3362 end
3363
3364 def test_bullk_update_should_send_a_notification
3365 @request.session[:user_id] = 2
3366 ActionMailer::Base.deliveries.clear
3367 post(:bulk_update,
3368 {
3369 :ids => [1, 2],
3370 :notes => 'Bulk editing',
3371 :issue => {
3372 :priority_id => 7,
3373 :assigned_to_id => '',
3374 :custom_field_values => {'2' => ''}
3375 }
3376 })
3377
3378 assert_response 302
3379 assert_equal 2, ActionMailer::Base.deliveries.size
3380 end
3381
3382 def test_bulk_update_project
3383 @request.session[:user_id] = 2
3384 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}
3385 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3386 # Issues moved to project 2
3387 assert_equal 2, Issue.find(1).project_id
3388 assert_equal 2, Issue.find(2).project_id
3389 # No tracker change
3390 assert_equal 1, Issue.find(1).tracker_id
3391 assert_equal 2, Issue.find(2).tracker_id
3392 end
3393
3394 def test_bulk_update_project_on_single_issue_should_follow_when_needed
3395 @request.session[:user_id] = 2
3396 post :bulk_update, :id => 1, :issue => {:project_id => '2'}, :follow => '1'
3397 assert_redirected_to '/issues/1'
3398 end
3399
3400 def test_bulk_update_project_on_multiple_issues_should_follow_when_needed
3401 @request.session[:user_id] = 2
3402 post :bulk_update, :id => [1, 2], :issue => {:project_id => '2'}, :follow => '1'
3403 assert_redirected_to '/projects/onlinestore/issues'
3404 end
3405
3406 def test_bulk_update_tracker
3407 @request.session[:user_id] = 2
3408 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2'}
3409 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3410 assert_equal 2, Issue.find(1).tracker_id
3411 assert_equal 2, Issue.find(2).tracker_id
3412 end
3413
3414 def test_bulk_update_status
3415 @request.session[:user_id] = 2
3416 # update issues priority
3417 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
3418 :issue => {:priority_id => '',
3419 :assigned_to_id => '',
3420 :status_id => '5'}
3421
3422 assert_response 302
3423 issue = Issue.find(1)
3424 assert issue.closed?
3425 end
3426
3427 def test_bulk_update_priority
3428 @request.session[:user_id] = 2
3429 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
3430
3431 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3432 assert_equal 6, Issue.find(1).priority_id
3433 assert_equal 6, Issue.find(2).priority_id
3434 end
3435
3436 def test_bulk_update_with_notes
3437 @request.session[:user_id] = 2
3438 post :bulk_update, :ids => [1, 2], :notes => 'Moving two issues'
3439
3440 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3441 assert_equal 'Moving two issues', Issue.find(1).journals.sort_by(&:id).last.notes
3442 assert_equal 'Moving two issues', Issue.find(2).journals.sort_by(&:id).last.notes
3443 end
3444
3445 def test_bulk_update_parent_id
3446 @request.session[:user_id] = 2
3447 post :bulk_update, :ids => [1, 3],
3448 :notes => 'Bulk editing parent',
3449 :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'}
3450
3451 assert_response 302
3452 parent = Issue.find(2)
3453 assert_equal parent.id, Issue.find(1).parent_id
3454 assert_equal parent.id, Issue.find(3).parent_id
3455 assert_equal [1, 3], parent.children.collect(&:id).sort
3456 end
3457
3458 def test_bulk_update_custom_field
3459 @request.session[:user_id] = 2
3460 # update issues priority
3461 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
3462 :issue => {:priority_id => '',
3463 :assigned_to_id => '',
3464 :custom_field_values => {'2' => '777'}}
3465
3466 assert_response 302
3467
3468 issue = Issue.find(1)
3469 journal = issue.journals.find(:first, :order => 'created_on DESC')
3470 assert_equal '777', issue.custom_value_for(2).value
3471 assert_equal 1, journal.details.size
3472 assert_equal '125', journal.details.first.old_value
3473 assert_equal '777', journal.details.first.value
3474 end
3475
3476 def test_bulk_update_custom_field_to_blank
3477 @request.session[:user_id] = 2
3478 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing custom field',
3479 :issue => {:priority_id => '',
3480 :assigned_to_id => '',
3481 :custom_field_values => {'1' => '__none__'}}
3482 assert_response 302
3483 assert_equal '', Issue.find(1).custom_field_value(1)
3484 assert_equal '', Issue.find(3).custom_field_value(1)
3485 end
3486
3487 def test_bulk_update_multi_custom_field
3488 field = CustomField.find(1)
3489 field.update_attribute :multiple, true
3490
3491 @request.session[:user_id] = 2
3492 post :bulk_update, :ids => [1, 2, 3], :notes => 'Bulk editing multi custom field',
3493 :issue => {:priority_id => '',
3494 :assigned_to_id => '',
3495 :custom_field_values => {'1' => ['MySQL', 'Oracle']}}
3496
3497 assert_response 302
3498
3499 assert_equal ['MySQL', 'Oracle'], Issue.find(1).custom_field_value(1).sort
3500 assert_equal ['MySQL', 'Oracle'], Issue.find(3).custom_field_value(1).sort
3501 # the custom field is not associated with the issue tracker
3502 assert_nil Issue.find(2).custom_field_value(1)
3503 end
3504
3505 def test_bulk_update_multi_custom_field_to_blank
3506 field = CustomField.find(1)
3507 field.update_attribute :multiple, true
3508
3509 @request.session[:user_id] = 2
3510 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing multi custom field',
3511 :issue => {:priority_id => '',
3512 :assigned_to_id => '',
3513 :custom_field_values => {'1' => ['__none__']}}
3514 assert_response 302
3515 assert_equal [''], Issue.find(1).custom_field_value(1)
3516 assert_equal [''], Issue.find(3).custom_field_value(1)
3517 end
3518
3519 def test_bulk_update_unassign
3520 assert_not_nil Issue.find(2).assigned_to
3521 @request.session[:user_id] = 2
3522 # unassign issues
3523 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
3524 assert_response 302
3525 # check that the issues were updated
3526 assert_nil Issue.find(2).assigned_to
3527 end
3528
3529 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
3530 @request.session[:user_id] = 2
3531
3532 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
3533
3534 assert_response :redirect
3535 issues = Issue.find([1,2])
3536 issues.each do |issue|
3537 assert_equal 4, issue.fixed_version_id
3538 assert_not_equal issue.project_id, issue.fixed_version.project_id
3539 end
3540 end
3541
3542 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
3543 @request.session[:user_id] = 2
3544 post :bulk_update, :ids => [1,2], :back_url => '/issues'
3545
3546 assert_response :redirect
3547 assert_redirected_to '/issues'
3548 end
3549
3550 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3551 @request.session[:user_id] = 2
3552 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
3553
3554 assert_response :redirect
3555 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
3556 end
3557
3558 def test_bulk_update_with_failure_should_set_flash
3559 @request.session[:user_id] = 2
3560 Issue.update_all("subject = ''", "id = 2") # Make it invalid
3561 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
3562
3563 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3564 assert_equal 'Failed to save 1 issue(s) on 2 selected: #2.', flash[:error]
3565 end
3566
3567 def test_get_bulk_copy
3568 @request.session[:user_id] = 2
3569 get :bulk_edit, :ids => [1, 2, 3], :copy => '1'
3570 assert_response :success
3571 assert_template 'bulk_edit'
3572
3573 issues = assigns(:issues)
3574 assert_not_nil issues
3575 assert_equal [1, 2, 3], issues.map(&:id).sort
3576
3577 assert_select 'input[name=copy_attachments]'
3578 end
3579
3580 def test_bulk_copy_to_another_project
3581 @request.session[:user_id] = 2
3582 assert_difference 'Issue.count', 2 do
3583 assert_no_difference 'Project.find(1).issues.count' do
3584 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}, :copy => '1'
3585 end
3586 end
3587 assert_redirected_to '/projects/ecookbook/issues'
3588
3589 copies = Issue.all(:order => 'id DESC', :limit => issues.size)
3590 copies.each do |copy|
3591 assert_equal 2, copy.project_id
3592 end
3593 end
3594
3595 def test_bulk_copy_should_allow_not_changing_the_issue_attributes
3596 @request.session[:user_id] = 2
3597 issues = [
3598 Issue.create!(:project_id => 1, :tracker_id => 1, :status_id => 1, :priority_id => 2, :subject => 'issue 1', :author_id => 1, :assigned_to_id => nil),
3599 Issue.create!(:project_id => 2, :tracker_id => 3, :status_id => 2, :priority_id => 1, :subject => 'issue 2', :author_id => 2, :assigned_to_id => 3)
3600 ]
3601
3602 assert_difference 'Issue.count', issues.size do
3603 post :bulk_update, :ids => issues.map(&:id), :copy => '1',
3604 :issue => {
3605 :project_id => '', :tracker_id => '', :assigned_to_id => '',
3606 :status_id => '', :start_date => '', :due_date => ''
3607 }
3608 end
3609
3610 copies = Issue.all(:order => 'id DESC', :limit => issues.size)
3611 issues.each do |orig|
3612 copy = copies.detect {|c| c.subject == orig.subject}
3613 assert_not_nil copy
3614 assert_equal orig.project_id, copy.project_id
3615 assert_equal orig.tracker_id, copy.tracker_id
3616 assert_equal orig.status_id, copy.status_id
3617 assert_equal orig.assigned_to_id, copy.assigned_to_id
3618 assert_equal orig.priority_id, copy.priority_id
3619 end
3620 end
3621
3622 def test_bulk_copy_should_allow_changing_the_issue_attributes
3623 # Fixes random test failure with Mysql
3624 # where Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
3625 # doesn't return the expected results
3626 Issue.delete_all("project_id=2")
3627
3628 @request.session[:user_id] = 2
3629 assert_difference 'Issue.count', 2 do
3630 assert_no_difference 'Project.find(1).issues.count' do
3631 post :bulk_update, :ids => [1, 2], :copy => '1',
3632 :issue => {
3633 :project_id => '2', :tracker_id => '', :assigned_to_id => '4',
3634 :status_id => '1', :start_date => '2009-12-01', :due_date => '2009-12-31'
3635 }
3636 end
3637 end
3638
3639 copied_issues = Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
3640 assert_equal 2, copied_issues.size
3641 copied_issues.each do |issue|
3642 assert_equal 2, issue.project_id, "Project is incorrect"
3643 assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
3644 assert_equal 1, issue.status_id, "Status is incorrect"
3645 assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
3646 assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
3647 end
3648 end
3649
3650 def test_bulk_copy_should_allow_adding_a_note
3651 @request.session[:user_id] = 2
3652 assert_difference 'Issue.count', 1 do
3653 post :bulk_update, :ids => [1], :copy => '1',
3654 :notes => 'Copying one issue',
3655 :issue => {
3656 :project_id => '', :tracker_id => '', :assigned_to_id => '4',
3657 :status_id => '3', :start_date => '2009-12-01', :due_date => '2009-12-31'
3658 }
3659 end
3660
3661 issue = Issue.first(:order => 'id DESC')
3662 assert_equal 1, issue.journals.size
3663 journal = issue.journals.first
3664 assert_equal 0, journal.details.size
3665 assert_equal 'Copying one issue', journal.notes
3666 end
3667
3668 def test_bulk_copy_should_allow_not_copying_the_attachments
3669 attachment_count = Issue.find(3).attachments.size
3670 assert attachment_count > 0
3671 @request.session[:user_id] = 2
3672
3673 assert_difference 'Issue.count', 1 do
3674 assert_no_difference 'Attachment.count' do
3675 post :bulk_update, :ids => [3], :copy => '1',
3676 :issue => {
3677 :project_id => ''
3678 }
3679 end
3680 end
3681 end
3682
3683 def test_bulk_copy_should_allow_copying_the_attachments
3684 attachment_count = Issue.find(3).attachments.size
3685 assert attachment_count > 0
3686 @request.session[:user_id] = 2
3687
3688 assert_difference 'Issue.count', 1 do
3689 assert_difference 'Attachment.count', attachment_count do
3690 post :bulk_update, :ids => [3], :copy => '1', :copy_attachments => '1',
3691 :issue => {
3692 :project_id => ''
3693 }
3694 end
3695 end
3696 end
3697
3698 def test_bulk_copy_should_add_relations_with_copied_issues
3699 @request.session[:user_id] = 2
3700
3701 assert_difference 'Issue.count', 2 do
3702 assert_difference 'IssueRelation.count', 2 do
3703 post :bulk_update, :ids => [1, 3], :copy => '1',
3704 :issue => {
3705 :project_id => '1'
3706 }
3707 end
3708 end
3709 end
3710
3711 def test_bulk_copy_should_allow_not_copying_the_subtasks
3712 issue = Issue.generate_with_descendants!
3713 @request.session[:user_id] = 2
3714
3715 assert_difference 'Issue.count', 1 do
3716 post :bulk_update, :ids => [issue.id], :copy => '1',
3717 :issue => {
3718 :project_id => ''
3719 }
3720 end
3721 end
3722
3723 def test_bulk_copy_should_allow_copying_the_subtasks
3724 issue = Issue.generate_with_descendants!
3725 count = issue.descendants.count
3726 @request.session[:user_id] = 2
3727
3728 assert_difference 'Issue.count', count+1 do
3729 post :bulk_update, :ids => [issue.id], :copy => '1', :copy_subtasks => '1',
3730 :issue => {
3731 :project_id => ''
3732 }
3733 end
3734 copy = Issue.where(:parent_id => nil).order("id DESC").first
3735 assert_equal count, copy.descendants.count
3736 end
3737
3738 def test_bulk_copy_should_not_copy_selected_subtasks_twice
3739 issue = Issue.generate_with_descendants!
3740 count = issue.descendants.count
3741 @request.session[:user_id] = 2
3742
3743 assert_difference 'Issue.count', count+1 do
3744 post :bulk_update, :ids => issue.self_and_descendants.map(&:id), :copy => '1', :copy_subtasks => '1',
3745 :issue => {
3746 :project_id => ''
3747 }
3748 end
3749 copy = Issue.where(:parent_id => nil).order("id DESC").first
3750 assert_equal count, copy.descendants.count
3751 end
3752
3753 def test_bulk_copy_to_another_project_should_follow_when_needed
3754 @request.session[:user_id] = 2
3755 post :bulk_update, :ids => [1], :copy => '1', :issue => {:project_id => 2}, :follow => '1'
3756 issue = Issue.first(:order => 'id DESC')
3757 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
3758 end
3759
3760 def test_destroy_issue_with_no_time_entries
3761 assert_nil TimeEntry.find_by_issue_id(2)
3762 @request.session[:user_id] = 2
3763
3764 assert_difference 'Issue.count', -1 do
3765 delete :destroy, :id => 2
3766 end
3767 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3768 assert_nil Issue.find_by_id(2)
3769 end
3770
3771 def test_destroy_issues_with_time_entries
3772 @request.session[:user_id] = 2
3773
3774 assert_no_difference 'Issue.count' do
3775 delete :destroy, :ids => [1, 3]
3776 end
3777 assert_response :success
3778 assert_template 'destroy'
3779 assert_not_nil assigns(:hours)
3780 assert Issue.find_by_id(1) && Issue.find_by_id(3)
3781 assert_tag 'form',
3782 :descendant => {:tag => 'input', :attributes => {:name => '_method', :value => 'delete'}}
3783 end
3784
3785 def test_destroy_issues_and_destroy_time_entries
3786 @request.session[:user_id] = 2
3787
3788 assert_difference 'Issue.count', -2 do
3789 assert_difference 'TimeEntry.count', -3 do
3790 delete :destroy, :ids => [1, 3], :todo => 'destroy'
3791 end
3792 end
3793 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3794 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3795 assert_nil TimeEntry.find_by_id([1, 2])
3796 end
3797
3798 def test_destroy_issues_and_assign_time_entries_to_project
3799 @request.session[:user_id] = 2
3800
3801 assert_difference 'Issue.count', -2 do
3802 assert_no_difference 'TimeEntry.count' do
3803 delete :destroy, :ids => [1, 3], :todo => 'nullify'
3804 end
3805 end
3806 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3807 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3808 assert_nil TimeEntry.find(1).issue_id
3809 assert_nil TimeEntry.find(2).issue_id
3810 end
3811
3812 def test_destroy_issues_and_reassign_time_entries_to_another_issue
3813 @request.session[:user_id] = 2
3814
3815 assert_difference 'Issue.count', -2 do
3816 assert_no_difference 'TimeEntry.count' do
3817 delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
3818 end
3819 end
3820 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3821 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3822 assert_equal 2, TimeEntry.find(1).issue_id
3823 assert_equal 2, TimeEntry.find(2).issue_id
3824 end
3825
3826 def test_destroy_issues_from_different_projects
3827 @request.session[:user_id] = 2
3828
3829 assert_difference 'Issue.count', -3 do
3830 delete :destroy, :ids => [1, 2, 6], :todo => 'destroy'
3831 end
3832 assert_redirected_to :controller => 'issues', :action => 'index'
3833 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
3834 end
3835
3836 def test_destroy_parent_and_child_issues
3837 parent = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Parent Issue')
3838 child = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Child Issue', :parent_issue_id => parent.id)
3839 assert child.is_descendant_of?(parent.reload)
3840
3841 @request.session[:user_id] = 2
3842 assert_difference 'Issue.count', -2 do
3843 delete :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
3844 end
3845 assert_response 302
3846 end
3847
3848 def test_default_search_scope
3849 get :index
3850 assert_tag :div, :attributes => {:id => 'quick-search'},
3851 :child => {:tag => 'form',
3852 :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}}
3853 end
3854 end