Chris@245
|
1 # Redmine - project management software
|
Chris@1494
|
2 # Copyright (C) 2006-2014 Jean-Philippe Lang
|
Chris@0
|
3 #
|
Chris@0
|
4 # This program is free software; you can redistribute it and/or
|
Chris@0
|
5 # modify it under the terms of the GNU General Public License
|
Chris@0
|
6 # as published by the Free Software Foundation; either version 2
|
Chris@0
|
7 # of the License, or (at your option) any later version.
|
Chris@441
|
8 #
|
Chris@0
|
9 # This program is distributed in the hope that it will be useful,
|
Chris@0
|
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
|
Chris@0
|
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
Chris@0
|
12 # GNU General Public License for more details.
|
Chris@441
|
13 #
|
Chris@0
|
14 # You should have received a copy of the GNU General Public License
|
Chris@0
|
15 # along with this program; if not, write to the Free Software
|
Chris@0
|
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
Chris@0
|
17
|
Chris@0
|
18 class Issue < ActiveRecord::Base
|
Chris@117
|
19 include Redmine::SafeAttributes
|
Chris@1115
|
20 include Redmine::Utils::DateCalculation
|
Chris@1464
|
21 include Redmine::I18n
|
Chris@441
|
22
|
Chris@0
|
23 belongs_to :project
|
Chris@0
|
24 belongs_to :tracker
|
Chris@0
|
25 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
|
Chris@0
|
26 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
|
Chris@909
|
27 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
|
Chris@0
|
28 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
|
Chris@0
|
29 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
|
Chris@0
|
30 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
|
Chris@0
|
31
|
Chris@0
|
32 has_many :journals, :as => :journalized, :dependent => :destroy
|
Chris@1115
|
33 has_many :visible_journals,
|
Chris@1115
|
34 :class_name => 'Journal',
|
Chris@1115
|
35 :as => :journalized,
|
Chris@1115
|
36 :conditions => Proc.new {
|
Chris@1115
|
37 ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
|
Chris@1115
|
38 },
|
Chris@1115
|
39 :readonly => true
|
Chris@1115
|
40
|
Chris@1517
|
41 has_many :time_entries, :dependent => :destroy
|
Chris@0
|
42 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
|
Chris@441
|
43
|
Chris@0
|
44 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
|
Chris@0
|
45 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
|
Chris@441
|
46
|
Chris@210
|
47 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
|
Chris@909
|
48 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
|
Chris@0
|
49 acts_as_customizable
|
Chris@0
|
50 acts_as_watchable
|
Chris@0
|
51 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
|
Chris@1115
|
52 :include => [:project, :visible_journals],
|
Chris@0
|
53 # sort by id so that limited eager loading doesn't break with postgresql
|
Chris@0
|
54 :order_column => "#{table_name}.id"
|
Chris@0
|
55 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
|
Chris@0
|
56 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
|
Chris@0
|
57 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
|
Chris@441
|
58
|
Chris@0
|
59 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
|
Chris@0
|
60 :author_key => :author_id
|
Chris@0
|
61
|
Chris@0
|
62 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
|
Chris@0
|
63
|
Chris@0
|
64 attr_reader :current_journal
|
Chris@1115
|
65 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
|
Chris@0
|
66
|
Chris@0
|
67 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
|
Chris@0
|
68
|
Chris@0
|
69 validates_length_of :subject, :maximum => 255
|
Chris@0
|
70 validates_inclusion_of :done_ratio, :in => 0..100
|
Chris@1464
|
71 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
|
Chris@1464
|
72 validates :start_date, :date => true
|
Chris@1464
|
73 validates :due_date, :date => true
|
Chris@1115
|
74 validate :validate_issue, :validate_required_fields
|
Chris@0
|
75
|
Chris@1464
|
76 scope :visible, lambda {|*args|
|
Chris@1464
|
77 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
|
Chris@1464
|
78 }
|
Chris@441
|
79
|
Chris@1115
|
80 scope :open, lambda {|*args|
|
Chris@1115
|
81 is_closed = args.size > 0 ? !args.first : false
|
Chris@1464
|
82 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
|
chris@22
|
83 }
|
chris@22
|
84
|
Chris@1464
|
85 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
|
Chris@1464
|
86 scope :on_active_project, lambda {
|
Chris@1464
|
87 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
|
Chris@1464
|
88 }
|
Chris@1464
|
89 scope :fixed_version, lambda {|versions|
|
Chris@1464
|
90 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
|
Chris@1464
|
91 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
|
Chris@1464
|
92 }
|
Chris@0
|
93
|
Chris@0
|
94 before_create :default_assign
|
Chris@1464
|
95 before_save :close_duplicates, :update_done_ratio_from_issue_status,
|
Chris@1464
|
96 :force_updated_on_change, :update_closed_on, :set_assigned_to_was
|
Chris@1115
|
97 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
|
Chris@1464
|
98 after_save :reschedule_following_issues, :update_nested_set_attributes,
|
Chris@1464
|
99 :update_parent_attributes, :create_journal
|
Chris@1115
|
100 # Should be after_create but would be called before previous after_save callbacks
|
Chris@1115
|
101 after_save :after_create_from_copy
|
Chris@0
|
102 after_destroy :update_parent_attributes
|
Chris@1464
|
103 after_create :send_notification
|
Chris@1464
|
104 # Keep it at the end of after_save callbacks
|
Chris@1464
|
105 after_save :clear_assigned_to_was
|
Chris@441
|
106
|
Chris@441
|
107 # Returns a SQL conditions string used to find all issues visible by the specified user
|
Chris@441
|
108 def self.visible_condition(user, options={})
|
Chris@441
|
109 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
|
Chris@1115
|
110 if user.logged?
|
Chris@1115
|
111 case role.issues_visibility
|
Chris@1115
|
112 when 'all'
|
Chris@1115
|
113 nil
|
Chris@1115
|
114 when 'default'
|
Chris@1464
|
115 user_ids = [user.id] + user.groups.map(&:id).compact
|
Chris@1115
|
116 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
|
Chris@1115
|
117 when 'own'
|
Chris@1464
|
118 user_ids = [user.id] + user.groups.map(&:id).compact
|
Chris@1115
|
119 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
|
Chris@1115
|
120 else
|
Chris@1115
|
121 '1=0'
|
Chris@1115
|
122 end
|
Chris@441
|
123 else
|
Chris@1115
|
124 "(#{table_name}.is_private = #{connection.quoted_false})"
|
Chris@441
|
125 end
|
Chris@441
|
126 end
|
Chris@441
|
127 end
|
Chris@441
|
128
|
Chris@0
|
129 # Returns true if usr or current user is allowed to view the issue
|
Chris@0
|
130 def visible?(usr=nil)
|
Chris@441
|
131 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
|
Chris@1115
|
132 if user.logged?
|
Chris@1115
|
133 case role.issues_visibility
|
Chris@1115
|
134 when 'all'
|
Chris@1115
|
135 true
|
Chris@1115
|
136 when 'default'
|
Chris@1115
|
137 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
|
Chris@1115
|
138 when 'own'
|
Chris@1115
|
139 self.author == user || user.is_or_belongs_to?(assigned_to)
|
Chris@1115
|
140 else
|
Chris@1115
|
141 false
|
Chris@1115
|
142 end
|
Chris@441
|
143 else
|
Chris@1115
|
144 !self.is_private?
|
Chris@441
|
145 end
|
Chris@441
|
146 end
|
Chris@0
|
147 end
|
Chris@441
|
148
|
Chris@1464
|
149 # Returns true if user or current user is allowed to edit or add a note to the issue
|
Chris@1464
|
150 def editable?(user=User.current)
|
Chris@1464
|
151 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
|
Chris@1464
|
152 end
|
Chris@1464
|
153
|
Chris@1115
|
154 def initialize(attributes=nil, *args)
|
Chris@1115
|
155 super
|
Chris@0
|
156 if new_record?
|
Chris@0
|
157 # set default values for new records only
|
Chris@0
|
158 self.status ||= IssueStatus.default
|
Chris@0
|
159 self.priority ||= IssuePriority.default
|
Chris@1115
|
160 self.watcher_user_ids = []
|
Chris@0
|
161 end
|
Chris@0
|
162 end
|
Chris@441
|
163
|
Chris@1464
|
164 def create_or_update
|
Chris@1464
|
165 super
|
Chris@1464
|
166 ensure
|
Chris@1464
|
167 @status_was = nil
|
Chris@1464
|
168 end
|
Chris@1464
|
169 private :create_or_update
|
Chris@1464
|
170
|
Chris@1115
|
171 # AR#Persistence#destroy would raise and RecordNotFound exception
|
Chris@1115
|
172 # if the issue was already deleted or updated (non matching lock_version).
|
Chris@1115
|
173 # This is a problem when bulk deleting issues or deleting a project
|
Chris@1115
|
174 # (because an issue may already be deleted if its parent was deleted
|
Chris@1115
|
175 # first).
|
Chris@1115
|
176 # The issue is reloaded by the nested_set before being deleted so
|
Chris@1115
|
177 # the lock_version condition should not be an issue but we handle it.
|
Chris@1115
|
178 def destroy
|
Chris@1115
|
179 super
|
Chris@1115
|
180 rescue ActiveRecord::RecordNotFound
|
Chris@1115
|
181 # Stale or already deleted
|
Chris@1115
|
182 begin
|
Chris@1115
|
183 reload
|
Chris@1115
|
184 rescue ActiveRecord::RecordNotFound
|
Chris@1115
|
185 # The issue was actually already deleted
|
Chris@1115
|
186 @destroyed = true
|
Chris@1115
|
187 return freeze
|
Chris@1115
|
188 end
|
Chris@1115
|
189 # The issue was stale, retry to destroy
|
Chris@1115
|
190 super
|
Chris@1115
|
191 end
|
Chris@1115
|
192
|
Chris@1464
|
193 alias :base_reload :reload
|
Chris@1115
|
194 def reload(*args)
|
Chris@1115
|
195 @workflow_rule_by_attribute = nil
|
Chris@1115
|
196 @assignable_versions = nil
|
Chris@1464
|
197 @relations = nil
|
Chris@1464
|
198 base_reload(*args)
|
Chris@1115
|
199 end
|
Chris@1115
|
200
|
Chris@0
|
201 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
|
Chris@0
|
202 def available_custom_fields
|
Chris@1517
|
203 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields) : []
|
Chris@0
|
204 end
|
Chris@441
|
205
|
Chris@1464
|
206 def visible_custom_field_values(user=nil)
|
Chris@1464
|
207 user_real = user || User.current
|
Chris@1464
|
208 custom_field_values.select do |value|
|
Chris@1464
|
209 value.custom_field.visible_by?(project, user_real)
|
Chris@1464
|
210 end
|
Chris@1464
|
211 end
|
Chris@1464
|
212
|
Chris@1115
|
213 # Copies attributes from another issue, arg can be an id or an Issue
|
Chris@1115
|
214 def copy_from(arg, options={})
|
Chris@0
|
215 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
|
Chris@0
|
216 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
|
Chris@0
|
217 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
|
Chris@0
|
218 self.status = issue.status
|
Chris@1115
|
219 self.author = User.current
|
Chris@1115
|
220 unless options[:attachments] == false
|
Chris@1115
|
221 self.attachments = issue.attachments.map do |attachement|
|
Chris@1115
|
222 attachement.copy(:container => self)
|
Chris@1115
|
223 end
|
Chris@1115
|
224 end
|
Chris@1115
|
225 @copied_from = issue
|
Chris@1115
|
226 @copy_options = options
|
Chris@0
|
227 self
|
Chris@0
|
228 end
|
Chris@441
|
229
|
Chris@1115
|
230 # Returns an unsaved copy of the issue
|
Chris@1115
|
231 def copy(attributes=nil, copy_options={})
|
Chris@1115
|
232 copy = self.class.new.copy_from(self, copy_options)
|
Chris@1115
|
233 copy.attributes = attributes if attributes
|
Chris@1115
|
234 copy
|
Chris@1115
|
235 end
|
Chris@1115
|
236
|
Chris@1115
|
237 # Returns true if the issue is a copy
|
Chris@1115
|
238 def copy?
|
Chris@1115
|
239 @copied_from.present?
|
Chris@1115
|
240 end
|
Chris@1115
|
241
|
Chris@0
|
242 # Moves/copies an issue to a new project and tracker
|
Chris@0
|
243 # Returns the moved/copied issue on success, false on failure
|
Chris@1115
|
244 def move_to_project(new_project, new_tracker=nil, options={})
|
Chris@1115
|
245 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
|
Chris@441
|
246
|
Chris@1115
|
247 if options[:copy]
|
Chris@1115
|
248 issue = self.copy
|
Chris@1115
|
249 else
|
Chris@1115
|
250 issue = self
|
Chris@1115
|
251 end
|
Chris@441
|
252
|
Chris@1115
|
253 issue.init_journal(User.current, options[:notes])
|
Chris@1115
|
254
|
Chris@1115
|
255 # Preserve previous behaviour
|
Chris@1115
|
256 # #move_to_project doesn't change tracker automatically
|
Chris@1115
|
257 issue.send :project=, new_project, true
|
Chris@0
|
258 if new_tracker
|
Chris@0
|
259 issue.tracker = new_tracker
|
Chris@0
|
260 end
|
Chris@0
|
261 # Allow bulk setting of attributes on the issue
|
Chris@0
|
262 if options[:attributes]
|
Chris@0
|
263 issue.attributes = options[:attributes]
|
Chris@0
|
264 end
|
Chris@441
|
265
|
Chris@1115
|
266 issue.save ? issue : false
|
Chris@0
|
267 end
|
Chris@0
|
268
|
Chris@0
|
269 def status_id=(sid)
|
Chris@0
|
270 self.status = nil
|
Chris@1115
|
271 result = write_attribute(:status_id, sid)
|
Chris@1115
|
272 @workflow_rule_by_attribute = nil
|
Chris@1115
|
273 result
|
Chris@0
|
274 end
|
Chris@441
|
275
|
Chris@0
|
276 def priority_id=(pid)
|
Chris@0
|
277 self.priority = nil
|
Chris@0
|
278 write_attribute(:priority_id, pid)
|
Chris@0
|
279 end
|
Chris@0
|
280
|
Chris@1115
|
281 def category_id=(cid)
|
Chris@1115
|
282 self.category = nil
|
Chris@1115
|
283 write_attribute(:category_id, cid)
|
Chris@1115
|
284 end
|
Chris@1115
|
285
|
Chris@1115
|
286 def fixed_version_id=(vid)
|
Chris@1115
|
287 self.fixed_version = nil
|
Chris@1115
|
288 write_attribute(:fixed_version_id, vid)
|
Chris@1115
|
289 end
|
Chris@1115
|
290
|
Chris@0
|
291 def tracker_id=(tid)
|
Chris@0
|
292 self.tracker = nil
|
Chris@0
|
293 result = write_attribute(:tracker_id, tid)
|
Chris@0
|
294 @custom_field_values = nil
|
Chris@1115
|
295 @workflow_rule_by_attribute = nil
|
Chris@0
|
296 result
|
Chris@0
|
297 end
|
Chris@909
|
298
|
Chris@1115
|
299 def project_id=(project_id)
|
Chris@1115
|
300 if project_id.to_s != self.project_id.to_s
|
Chris@1115
|
301 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
|
Chris@1115
|
302 end
|
Chris@1115
|
303 end
|
Chris@1115
|
304
|
Chris@1115
|
305 def project=(project, keep_tracker=false)
|
Chris@1115
|
306 project_was = self.project
|
Chris@1115
|
307 write_attribute(:project_id, project ? project.id : nil)
|
Chris@1115
|
308 association_instance_set('project', project)
|
Chris@1115
|
309 if project_was && project && project_was != project
|
Chris@1115
|
310 @assignable_versions = nil
|
Chris@1115
|
311
|
Chris@1115
|
312 unless keep_tracker || project.trackers.include?(tracker)
|
Chris@1115
|
313 self.tracker = project.trackers.first
|
Chris@1115
|
314 end
|
Chris@1115
|
315 # Reassign to the category with same name if any
|
Chris@1115
|
316 if category
|
Chris@1115
|
317 self.category = project.issue_categories.find_by_name(category.name)
|
Chris@1115
|
318 end
|
Chris@1115
|
319 # Keep the fixed_version if it's still valid in the new_project
|
Chris@1115
|
320 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
|
Chris@1115
|
321 self.fixed_version = nil
|
Chris@1115
|
322 end
|
Chris@1115
|
323 # Clear the parent task if it's no longer valid
|
Chris@1115
|
324 unless valid_parent_project?
|
Chris@1115
|
325 self.parent_issue_id = nil
|
Chris@1115
|
326 end
|
Chris@1115
|
327 @custom_field_values = nil
|
Chris@1115
|
328 end
|
Chris@1115
|
329 end
|
Chris@1115
|
330
|
Chris@507
|
331 def description=(arg)
|
Chris@507
|
332 if arg.is_a?(String)
|
Chris@507
|
333 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
|
Chris@507
|
334 end
|
Chris@507
|
335 write_attribute(:description, arg)
|
Chris@507
|
336 end
|
Chris@441
|
337
|
Chris@1115
|
338 # Overrides assign_attributes so that project and tracker get assigned first
|
Chris@1115
|
339 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
|
Chris@0
|
340 return if new_attributes.nil?
|
Chris@1115
|
341 attrs = new_attributes.dup
|
Chris@1115
|
342 attrs.stringify_keys!
|
Chris@1115
|
343
|
Chris@1115
|
344 %w(project project_id tracker tracker_id).each do |attr|
|
Chris@1115
|
345 if attrs.has_key?(attr)
|
Chris@1115
|
346 send "#{attr}=", attrs.delete(attr)
|
Chris@1115
|
347 end
|
Chris@0
|
348 end
|
Chris@1115
|
349 send :assign_attributes_without_project_and_tracker_first, attrs, *args
|
Chris@0
|
350 end
|
Chris@0
|
351 # Do not redefine alias chain on reload (see #4838)
|
Chris@1115
|
352 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
|
Chris@441
|
353
|
Chris@0
|
354 def estimated_hours=(h)
|
Chris@0
|
355 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
|
Chris@0
|
356 end
|
Chris@441
|
357
|
Chris@1115
|
358 safe_attributes 'project_id',
|
Chris@1115
|
359 :if => lambda {|issue, user|
|
Chris@1115
|
360 if issue.new_record?
|
Chris@1115
|
361 issue.copy?
|
Chris@1115
|
362 elsif user.allowed_to?(:move_issues, issue.project)
|
Chris@1464
|
363 Issue.allowed_target_projects_on_move.count > 1
|
Chris@1115
|
364 end
|
Chris@1115
|
365 }
|
Chris@1115
|
366
|
Chris@117
|
367 safe_attributes 'tracker_id',
|
Chris@117
|
368 'status_id',
|
Chris@117
|
369 'category_id',
|
Chris@117
|
370 'assigned_to_id',
|
Chris@117
|
371 'priority_id',
|
Chris@117
|
372 'fixed_version_id',
|
Chris@117
|
373 'subject',
|
Chris@117
|
374 'description',
|
Chris@117
|
375 'start_date',
|
Chris@117
|
376 'due_date',
|
Chris@117
|
377 'done_ratio',
|
Chris@117
|
378 'estimated_hours',
|
Chris@117
|
379 'custom_field_values',
|
Chris@117
|
380 'custom_fields',
|
Chris@117
|
381 'lock_version',
|
Chris@1115
|
382 'notes',
|
Chris@117
|
383 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
|
Chris@441
|
384
|
Chris@117
|
385 safe_attributes 'status_id',
|
Chris@117
|
386 'assigned_to_id',
|
Chris@117
|
387 'fixed_version_id',
|
Chris@117
|
388 'done_ratio',
|
Chris@1115
|
389 'lock_version',
|
Chris@1115
|
390 'notes',
|
Chris@117
|
391 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
|
chris@37
|
392
|
Chris@1115
|
393 safe_attributes 'notes',
|
Chris@1115
|
394 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
|
Chris@1115
|
395
|
Chris@1115
|
396 safe_attributes 'private_notes',
|
Chris@1115
|
397 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
|
Chris@1115
|
398
|
Chris@1115
|
399 safe_attributes 'watcher_user_ids',
|
Chris@1115
|
400 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
|
Chris@1115
|
401
|
Chris@441
|
402 safe_attributes 'is_private',
|
Chris@441
|
403 :if => lambda {|issue, user|
|
Chris@441
|
404 user.allowed_to?(:set_issues_private, issue.project) ||
|
Chris@441
|
405 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
|
Chris@441
|
406 }
|
Chris@441
|
407
|
Chris@1115
|
408 safe_attributes 'parent_issue_id',
|
Chris@1115
|
409 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
|
Chris@1115
|
410 user.allowed_to?(:manage_subtasks, issue.project)}
|
Chris@1115
|
411
|
Chris@1115
|
412 def safe_attribute_names(user=nil)
|
Chris@1115
|
413 names = super
|
Chris@1115
|
414 names -= disabled_core_fields
|
Chris@1115
|
415 names -= read_only_attribute_names(user)
|
Chris@1115
|
416 names
|
Chris@1115
|
417 end
|
Chris@1115
|
418
|
Chris@0
|
419 # Safely sets attributes
|
Chris@0
|
420 # Should be called from controllers instead of #attributes=
|
Chris@0
|
421 # attr_accessible is too rough because we still want things like
|
Chris@0
|
422 # Issue.new(:project => foo) to work
|
Chris@0
|
423 def safe_attributes=(attrs, user=User.current)
|
chris@37
|
424 return unless attrs.is_a?(Hash)
|
Chris@441
|
425
|
Chris@1115
|
426 attrs = attrs.dup
|
Chris@441
|
427
|
Chris@1115
|
428 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
|
Chris@1115
|
429 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
|
Chris@1464
|
430 if allowed_target_projects(user).where(:id => p.to_i).exists?
|
Chris@1115
|
431 self.project_id = p
|
Chris@1115
|
432 end
|
Chris@1115
|
433 end
|
Chris@1115
|
434
|
Chris@1115
|
435 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
|
chris@37
|
436 self.tracker_id = t
|
chris@37
|
437 end
|
Chris@441
|
438
|
Chris@1115
|
439 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
|
Chris@1115
|
440 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
|
Chris@1115
|
441 self.status_id = s
|
Chris@0
|
442 end
|
Chris@0
|
443 end
|
Chris@441
|
444
|
Chris@1115
|
445 attrs = delete_unsafe_attributes(attrs, user)
|
Chris@1115
|
446 return if attrs.empty?
|
Chris@1115
|
447
|
Chris@0
|
448 unless leaf?
|
Chris@0
|
449 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
|
Chris@0
|
450 end
|
Chris@441
|
451
|
Chris@1115
|
452 if attrs['parent_issue_id'].present?
|
Chris@1115
|
453 s = attrs['parent_issue_id'].to_s
|
Chris@1294
|
454 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
|
Chris@1115
|
455 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
|
Chris@0
|
456 end
|
Chris@0
|
457 end
|
Chris@441
|
458
|
Chris@1115
|
459 if attrs['custom_field_values'].present?
|
Chris@1464
|
460 editable_custom_field_ids = editable_custom_field_values(user).map {|v| v.custom_field_id.to_s}
|
Chris@1464
|
461 # TODO: use #select when ruby1.8 support is dropped
|
Chris@1464
|
462 attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| !editable_custom_field_ids.include?(k.to_s)}
|
Chris@1115
|
463 end
|
Chris@1115
|
464
|
Chris@1115
|
465 if attrs['custom_fields'].present?
|
Chris@1464
|
466 editable_custom_field_ids = editable_custom_field_values(user).map {|v| v.custom_field_id.to_s}
|
Chris@1464
|
467 # TODO: use #select when ruby1.8 support is dropped
|
Chris@1464
|
468 attrs['custom_fields'] = attrs['custom_fields'].reject {|c| !editable_custom_field_ids.include?(c['id'].to_s)}
|
Chris@1115
|
469 end
|
Chris@1115
|
470
|
Chris@1115
|
471 # mass-assignment security bypass
|
Chris@1115
|
472 assign_attributes attrs, :without_protection => true
|
Chris@0
|
473 end
|
Chris@441
|
474
|
Chris@1115
|
475 def disabled_core_fields
|
Chris@1115
|
476 tracker ? tracker.disabled_core_fields : []
|
Chris@1115
|
477 end
|
Chris@1115
|
478
|
Chris@1115
|
479 # Returns the custom_field_values that can be edited by the given user
|
Chris@1115
|
480 def editable_custom_field_values(user=nil)
|
Chris@1464
|
481 visible_custom_field_values(user).reject do |value|
|
Chris@1115
|
482 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
|
Chris@1115
|
483 end
|
Chris@1115
|
484 end
|
Chris@1115
|
485
|
Chris@1517
|
486 # Returns the custom fields that can be edited by the given user
|
Chris@1517
|
487 def editable_custom_fields(user=nil)
|
Chris@1517
|
488 editable_custom_field_values(user).map(&:custom_field).uniq
|
Chris@1517
|
489 end
|
Chris@1517
|
490
|
Chris@1115
|
491 # Returns the names of attributes that are read-only for user or the current user
|
Chris@1115
|
492 # For users with multiple roles, the read-only fields are the intersection of
|
Chris@1115
|
493 # read-only fields of each role
|
Chris@1115
|
494 # The result is an array of strings where sustom fields are represented with their ids
|
Chris@1115
|
495 #
|
Chris@1115
|
496 # Examples:
|
Chris@1115
|
497 # issue.read_only_attribute_names # => ['due_date', '2']
|
Chris@1115
|
498 # issue.read_only_attribute_names(user) # => []
|
Chris@1115
|
499 def read_only_attribute_names(user=nil)
|
Chris@1115
|
500 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
|
Chris@1115
|
501 end
|
Chris@1115
|
502
|
Chris@1115
|
503 # Returns the names of required attributes for user or the current user
|
Chris@1115
|
504 # For users with multiple roles, the required fields are the intersection of
|
Chris@1115
|
505 # required fields of each role
|
Chris@1115
|
506 # The result is an array of strings where sustom fields are represented with their ids
|
Chris@1115
|
507 #
|
Chris@1115
|
508 # Examples:
|
Chris@1115
|
509 # issue.required_attribute_names # => ['due_date', '2']
|
Chris@1115
|
510 # issue.required_attribute_names(user) # => []
|
Chris@1115
|
511 def required_attribute_names(user=nil)
|
Chris@1115
|
512 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
|
Chris@1115
|
513 end
|
Chris@1115
|
514
|
Chris@1115
|
515 # Returns true if the attribute is required for user
|
Chris@1115
|
516 def required_attribute?(name, user=nil)
|
Chris@1115
|
517 required_attribute_names(user).include?(name.to_s)
|
Chris@1115
|
518 end
|
Chris@1115
|
519
|
Chris@1115
|
520 # Returns a hash of the workflow rule by attribute for the given user
|
Chris@1115
|
521 #
|
Chris@1115
|
522 # Examples:
|
Chris@1115
|
523 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
|
Chris@1115
|
524 def workflow_rule_by_attribute(user=nil)
|
Chris@1115
|
525 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
|
Chris@1115
|
526
|
Chris@1115
|
527 user_real = user || User.current
|
Chris@1115
|
528 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
|
Chris@1115
|
529 return {} if roles.empty?
|
Chris@1115
|
530
|
Chris@1115
|
531 result = {}
|
Chris@1115
|
532 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
|
Chris@1115
|
533 if workflow_permissions.any?
|
Chris@1115
|
534 workflow_rules = workflow_permissions.inject({}) do |h, wp|
|
Chris@1115
|
535 h[wp.field_name] ||= []
|
Chris@1115
|
536 h[wp.field_name] << wp.rule
|
Chris@1115
|
537 h
|
Chris@1115
|
538 end
|
Chris@1115
|
539 workflow_rules.each do |attr, rules|
|
Chris@1115
|
540 next if rules.size < roles.size
|
Chris@1115
|
541 uniq_rules = rules.uniq
|
Chris@1115
|
542 if uniq_rules.size == 1
|
Chris@1115
|
543 result[attr] = uniq_rules.first
|
Chris@1115
|
544 else
|
Chris@1115
|
545 result[attr] = 'required'
|
Chris@1115
|
546 end
|
Chris@1115
|
547 end
|
Chris@1115
|
548 end
|
Chris@1115
|
549 @workflow_rule_by_attribute = result if user.nil?
|
Chris@1115
|
550 result
|
Chris@1115
|
551 end
|
Chris@1115
|
552 private :workflow_rule_by_attribute
|
Chris@1115
|
553
|
Chris@0
|
554 def done_ratio
|
chris@37
|
555 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
|
Chris@0
|
556 status.default_done_ratio
|
Chris@0
|
557 else
|
Chris@0
|
558 read_attribute(:done_ratio)
|
Chris@0
|
559 end
|
Chris@0
|
560 end
|
Chris@0
|
561
|
Chris@0
|
562 def self.use_status_for_done_ratio?
|
Chris@0
|
563 Setting.issue_done_ratio == 'issue_status'
|
Chris@0
|
564 end
|
Chris@0
|
565
|
Chris@0
|
566 def self.use_field_for_done_ratio?
|
Chris@0
|
567 Setting.issue_done_ratio == 'issue_field'
|
Chris@0
|
568 end
|
Chris@441
|
569
|
Chris@909
|
570 def validate_issue
|
Chris@1464
|
571 if due_date && start_date && (start_date_changed? || due_date_changed?) && due_date < start_date
|
Chris@0
|
572 errors.add :due_date, :greater_than_start_date
|
Chris@0
|
573 end
|
Chris@441
|
574
|
Chris@1464
|
575 if start_date && start_date_changed? && soonest_start && start_date < soonest_start
|
Chris@1464
|
576 errors.add :start_date, :earlier_than_minimum_start_date, :date => format_date(soonest_start)
|
Chris@0
|
577 end
|
Chris@441
|
578
|
Chris@0
|
579 if fixed_version
|
Chris@0
|
580 if !assignable_versions.include?(fixed_version)
|
Chris@0
|
581 errors.add :fixed_version_id, :inclusion
|
Chris@0
|
582 elsif reopened? && fixed_version.closed?
|
Chris@909
|
583 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
|
Chris@0
|
584 end
|
Chris@0
|
585 end
|
Chris@441
|
586
|
Chris@0
|
587 # Checks that the issue can not be added/moved to a disabled tracker
|
Chris@0
|
588 if project && (tracker_id_changed? || project_id_changed?)
|
Chris@0
|
589 unless project.trackers.include?(tracker)
|
Chris@0
|
590 errors.add :tracker_id, :inclusion
|
Chris@0
|
591 end
|
Chris@0
|
592 end
|
Chris@441
|
593
|
Chris@0
|
594 # Checks parent issue assignment
|
Chris@1115
|
595 if @invalid_parent_issue_id.present?
|
Chris@1115
|
596 errors.add :parent_issue_id, :invalid
|
Chris@1115
|
597 elsif @parent_issue
|
Chris@1115
|
598 if !valid_parent_project?(@parent_issue)
|
Chris@1115
|
599 errors.add :parent_issue_id, :invalid
|
Chris@1464
|
600 elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))
|
Chris@1464
|
601 errors.add :parent_issue_id, :invalid
|
Chris@0
|
602 elsif !new_record?
|
Chris@0
|
603 # moving an existing issue
|
Chris@0
|
604 if @parent_issue.root_id != root_id
|
Chris@0
|
605 # we can always move to another tree
|
Chris@0
|
606 elsif move_possible?(@parent_issue)
|
Chris@0
|
607 # move accepted inside tree
|
Chris@0
|
608 else
|
Chris@1115
|
609 errors.add :parent_issue_id, :invalid
|
Chris@1115
|
610 end
|
Chris@1115
|
611 end
|
Chris@1115
|
612 end
|
Chris@1115
|
613 end
|
Chris@1115
|
614
|
Chris@1115
|
615 # Validates the issue against additional workflow requirements
|
Chris@1115
|
616 def validate_required_fields
|
Chris@1115
|
617 user = new_record? ? author : current_journal.try(:user)
|
Chris@1115
|
618
|
Chris@1115
|
619 required_attribute_names(user).each do |attribute|
|
Chris@1115
|
620 if attribute =~ /^\d+$/
|
Chris@1115
|
621 attribute = attribute.to_i
|
Chris@1115
|
622 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
|
Chris@1115
|
623 if v && v.value.blank?
|
Chris@1115
|
624 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
|
Chris@1115
|
625 end
|
Chris@1115
|
626 else
|
Chris@1115
|
627 if respond_to?(attribute) && send(attribute).blank?
|
Chris@1115
|
628 errors.add attribute, :blank
|
Chris@0
|
629 end
|
Chris@0
|
630 end
|
Chris@0
|
631 end
|
Chris@0
|
632 end
|
Chris@441
|
633
|
Chris@0
|
634 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
|
Chris@0
|
635 # even if the user turns off the setting later
|
Chris@0
|
636 def update_done_ratio_from_issue_status
|
chris@37
|
637 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
|
Chris@0
|
638 self.done_ratio = status.default_done_ratio
|
Chris@0
|
639 end
|
Chris@0
|
640 end
|
Chris@441
|
641
|
Chris@0
|
642 def init_journal(user, notes = "")
|
Chris@0
|
643 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
|
Chris@1115
|
644 if new_record?
|
Chris@1115
|
645 @current_journal.notify = false
|
Chris@1115
|
646 else
|
Chris@1115
|
647 @attributes_before_change = attributes.dup
|
Chris@1115
|
648 @custom_values_before_change = {}
|
Chris@1115
|
649 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
|
Chris@1115
|
650 end
|
Chris@0
|
651 @current_journal
|
Chris@0
|
652 end
|
Chris@441
|
653
|
Chris@1115
|
654 # Returns the id of the last journal or nil
|
Chris@1115
|
655 def last_journal_id
|
Chris@1115
|
656 if new_record?
|
Chris@1115
|
657 nil
|
Chris@1115
|
658 else
|
Chris@1115
|
659 journals.maximum(:id)
|
Chris@1115
|
660 end
|
Chris@1115
|
661 end
|
Chris@1115
|
662
|
Chris@1115
|
663 # Returns a scope for journals that have an id greater than journal_id
|
Chris@1115
|
664 def journals_after(journal_id)
|
Chris@1115
|
665 scope = journals.reorder("#{Journal.table_name}.id ASC")
|
Chris@1115
|
666 if journal_id.present?
|
Chris@1115
|
667 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
|
Chris@1115
|
668 end
|
Chris@1115
|
669 scope
|
Chris@1115
|
670 end
|
Chris@1115
|
671
|
Chris@1464
|
672 # Returns the initial status of the issue
|
Chris@1464
|
673 # Returns nil for a new issue
|
Chris@1464
|
674 def status_was
|
Chris@1464
|
675 if status_id_was && status_id_was.to_i > 0
|
Chris@1464
|
676 @status_was ||= IssueStatus.find_by_id(status_id_was)
|
Chris@1464
|
677 end
|
Chris@1464
|
678 end
|
Chris@1464
|
679
|
Chris@0
|
680 # Return true if the issue is closed, otherwise false
|
Chris@0
|
681 def closed?
|
Chris@0
|
682 self.status.is_closed?
|
Chris@0
|
683 end
|
Chris@441
|
684
|
Chris@0
|
685 # Return true if the issue is being reopened
|
Chris@0
|
686 def reopened?
|
Chris@0
|
687 if !new_record? && status_id_changed?
|
Chris@0
|
688 status_was = IssueStatus.find_by_id(status_id_was)
|
Chris@0
|
689 status_new = IssueStatus.find_by_id(status_id)
|
Chris@0
|
690 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
|
Chris@0
|
691 return true
|
Chris@0
|
692 end
|
Chris@0
|
693 end
|
Chris@0
|
694 false
|
Chris@0
|
695 end
|
Chris@0
|
696
|
Chris@0
|
697 # Return true if the issue is being closed
|
Chris@0
|
698 def closing?
|
Chris@0
|
699 if !new_record? && status_id_changed?
|
Chris@1464
|
700 if status_was && status && !status_was.is_closed? && status.is_closed?
|
Chris@0
|
701 return true
|
Chris@0
|
702 end
|
Chris@0
|
703 end
|
Chris@0
|
704 false
|
Chris@0
|
705 end
|
Chris@441
|
706
|
Chris@0
|
707 # Returns true if the issue is overdue
|
Chris@0
|
708 def overdue?
|
Chris@0
|
709 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
|
Chris@0
|
710 end
|
chris@22
|
711
|
chris@22
|
712 # Is the amount of work done less than it should for the due date
|
chris@22
|
713 def behind_schedule?
|
chris@22
|
714 return false if start_date.nil? || due_date.nil?
|
Chris@1464
|
715 done_date = start_date + ((due_date - start_date + 1) * done_ratio / 100).floor
|
chris@22
|
716 return done_date <= Date.today
|
chris@22
|
717 end
|
chris@22
|
718
|
chris@22
|
719 # Does this issue have children?
|
chris@22
|
720 def children?
|
chris@22
|
721 !leaf?
|
chris@22
|
722 end
|
Chris@441
|
723
|
Chris@0
|
724 # Users the issue can be assigned to
|
Chris@0
|
725 def assignable_users
|
chris@37
|
726 users = project.assignable_users
|
chris@37
|
727 users << author if author
|
Chris@909
|
728 users << assigned_to if assigned_to
|
chris@37
|
729 users.uniq.sort
|
Chris@0
|
730 end
|
Chris@441
|
731
|
Chris@0
|
732 # Versions that the issue can be assigned to
|
Chris@0
|
733 def assignable_versions
|
Chris@1115
|
734 return @assignable_versions if @assignable_versions
|
Chris@1115
|
735
|
Chris@1115
|
736 versions = project.shared_versions.open.all
|
Chris@1115
|
737 if fixed_version
|
Chris@1115
|
738 if fixed_version_id_changed?
|
Chris@1115
|
739 # nothing to do
|
Chris@1115
|
740 elsif project_id_changed?
|
Chris@1115
|
741 if project.shared_versions.include?(fixed_version)
|
Chris@1115
|
742 versions << fixed_version
|
Chris@1115
|
743 end
|
Chris@1115
|
744 else
|
Chris@1115
|
745 versions << fixed_version
|
Chris@1115
|
746 end
|
Chris@1115
|
747 end
|
Chris@1115
|
748 @assignable_versions = versions.uniq.sort
|
Chris@0
|
749 end
|
Chris@441
|
750
|
Chris@0
|
751 # Returns true if this issue is blocked by another issue that is still open
|
Chris@0
|
752 def blocked?
|
Chris@0
|
753 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
|
Chris@0
|
754 end
|
Chris@441
|
755
|
Chris@1115
|
756 # Returns an array of statuses that user is able to apply
|
Chris@1115
|
757 def new_statuses_allowed_to(user=User.current, include_default=false)
|
Chris@1115
|
758 if new_record? && @copied_from
|
Chris@1115
|
759 [IssueStatus.default, @copied_from.status].compact.uniq.sort
|
Chris@1115
|
760 else
|
Chris@1115
|
761 initial_status = nil
|
Chris@1115
|
762 if new_record?
|
Chris@1115
|
763 initial_status = IssueStatus.default
|
Chris@1115
|
764 elsif status_id_was
|
Chris@1115
|
765 initial_status = IssueStatus.find_by_id(status_id_was)
|
Chris@1115
|
766 end
|
Chris@1115
|
767 initial_status ||= status
|
Chris@1464
|
768
|
Chris@1464
|
769 initial_assigned_to_id = assigned_to_id_changed? ? assigned_to_id_was : assigned_to_id
|
Chris@1464
|
770 assignee_transitions_allowed = initial_assigned_to_id.present? &&
|
Chris@1464
|
771 (user.id == initial_assigned_to_id || user.group_ids.include?(initial_assigned_to_id))
|
Chris@1464
|
772
|
Chris@1115
|
773 statuses = initial_status.find_new_statuses_allowed_to(
|
Chris@1115
|
774 user.admin ? Role.all : user.roles_for_project(project),
|
Chris@1115
|
775 tracker,
|
Chris@1115
|
776 author == user,
|
Chris@1464
|
777 assignee_transitions_allowed
|
Chris@1115
|
778 )
|
Chris@1115
|
779 statuses << initial_status unless statuses.empty?
|
Chris@1115
|
780 statuses << IssueStatus.default if include_default
|
Chris@1115
|
781 statuses = statuses.compact.uniq.sort
|
Chris@1115
|
782 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
|
Chris@1115
|
783 end
|
Chris@0
|
784 end
|
Chris@441
|
785
|
Chris@1464
|
786 # Returns the previous assignee if changed
|
Chris@1115
|
787 def assigned_to_was
|
Chris@1464
|
788 # assigned_to_id_was is reset before after_save callbacks
|
Chris@1464
|
789 user_id = @previous_assigned_to_id || assigned_to_id_was
|
Chris@1464
|
790 if user_id && user_id != assigned_to_id
|
Chris@1464
|
791 @assigned_to_was ||= User.find_by_id(user_id)
|
Chris@1115
|
792 end
|
Chris@1115
|
793 end
|
Chris@1115
|
794
|
Chris@1115
|
795 # Returns the users that should be notified
|
Chris@1115
|
796 def notified_users
|
Chris@1115
|
797 notified = []
|
chris@37
|
798 # Author and assignee are always notified unless they have been
|
chris@37
|
799 # locked or don't want to be notified
|
Chris@1115
|
800 notified << author if author
|
Chris@909
|
801 if assigned_to
|
Chris@1115
|
802 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
|
Chris@909
|
803 end
|
Chris@1115
|
804 if assigned_to_was
|
Chris@1115
|
805 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
|
Chris@1115
|
806 end
|
Chris@1115
|
807 notified = notified.select {|u| u.active? && u.notify_about?(self)}
|
Chris@1115
|
808
|
Chris@1115
|
809 notified += project.notified_users
|
Chris@0
|
810 notified.uniq!
|
Chris@0
|
811 # Remove users that can not view the issue
|
Chris@0
|
812 notified.reject! {|user| !visible?(user)}
|
Chris@1115
|
813 notified
|
Chris@1115
|
814 end
|
Chris@1115
|
815
|
Chris@1115
|
816 # Returns the email addresses that should be notified
|
Chris@1115
|
817 def recipients
|
Chris@1115
|
818 notified_users.collect(&:mail)
|
Chris@1115
|
819 end
|
Chris@1115
|
820
|
Chris@1464
|
821 def each_notification(users, &block)
|
Chris@1464
|
822 if users.any?
|
Chris@1464
|
823 if custom_field_values.detect {|value| !value.custom_field.visible?}
|
Chris@1464
|
824 users_by_custom_field_visibility = users.group_by do |user|
|
Chris@1464
|
825 visible_custom_field_values(user).map(&:custom_field_id).sort
|
Chris@1464
|
826 end
|
Chris@1464
|
827 users_by_custom_field_visibility.values.each do |users|
|
Chris@1464
|
828 yield(users)
|
Chris@1464
|
829 end
|
Chris@1464
|
830 else
|
Chris@1464
|
831 yield(users)
|
Chris@1464
|
832 end
|
Chris@1464
|
833 end
|
Chris@1464
|
834 end
|
Chris@1464
|
835
|
Chris@1115
|
836 # Returns the number of hours spent on this issue
|
Chris@1115
|
837 def spent_hours
|
Chris@1115
|
838 @spent_hours ||= time_entries.sum(:hours) || 0
|
Chris@0
|
839 end
|
Chris@441
|
840
|
Chris@0
|
841 # Returns the total number of hours spent on this issue and its descendants
|
Chris@0
|
842 #
|
Chris@0
|
843 # Example:
|
Chris@0
|
844 # spent_hours => 0.0
|
Chris@0
|
845 # spent_hours => 50.2
|
Chris@1115
|
846 def total_spent_hours
|
Chris@1517
|
847 @total_spent_hours ||=
|
Chris@1517
|
848 self_and_descendants.
|
Chris@1517
|
849 joins("LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").
|
Chris@1517
|
850 sum("#{TimeEntry.table_name}.hours").to_f || 0.0
|
Chris@0
|
851 end
|
Chris@441
|
852
|
Chris@0
|
853 def relations
|
Chris@1464
|
854 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
|
Chris@909
|
855 end
|
Chris@909
|
856
|
Chris@909
|
857 # Preloads relations for a collection of issues
|
Chris@909
|
858 def self.load_relations(issues)
|
Chris@909
|
859 if issues.any?
|
Chris@1464
|
860 relations = IssueRelation.where("issue_from_id IN (:ids) OR issue_to_id IN (:ids)", :ids => issues.map(&:id)).all
|
Chris@909
|
861 issues.each do |issue|
|
Chris@909
|
862 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
|
Chris@909
|
863 end
|
Chris@909
|
864 end
|
Chris@909
|
865 end
|
Chris@909
|
866
|
Chris@1115
|
867 # Preloads visible spent time for a collection of issues
|
Chris@1115
|
868 def self.load_visible_spent_hours(issues, user=User.current)
|
Chris@1115
|
869 if issues.any?
|
Chris@1464
|
870 hours_by_issue_id = TimeEntry.visible(user).group(:issue_id).sum(:hours)
|
Chris@1115
|
871 issues.each do |issue|
|
Chris@1115
|
872 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
|
Chris@1115
|
873 end
|
Chris@1115
|
874 end
|
Chris@1115
|
875 end
|
Chris@1115
|
876
|
Chris@1115
|
877 # Preloads visible relations for a collection of issues
|
Chris@1115
|
878 def self.load_visible_relations(issues, user=User.current)
|
Chris@1115
|
879 if issues.any?
|
Chris@1115
|
880 issue_ids = issues.map(&:id)
|
Chris@1115
|
881 # Relations with issue_from in given issues and visible issue_to
|
Chris@1115
|
882 relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
|
Chris@1115
|
883 # Relations with issue_to in given issues and visible issue_from
|
Chris@1115
|
884 relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
|
Chris@1115
|
885
|
Chris@1115
|
886 issues.each do |issue|
|
Chris@1115
|
887 relations =
|
Chris@1115
|
888 relations_from.select {|relation| relation.issue_from_id == issue.id} +
|
Chris@1115
|
889 relations_to.select {|relation| relation.issue_to_id == issue.id}
|
Chris@1115
|
890
|
Chris@1464
|
891 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
|
Chris@1115
|
892 end
|
Chris@1115
|
893 end
|
Chris@1115
|
894 end
|
Chris@1115
|
895
|
Chris@909
|
896 # Finds an issue relation given its id.
|
Chris@909
|
897 def find_relation(relation_id)
|
Chris@1464
|
898 IssueRelation.where("issue_to_id = ? OR issue_from_id = ?", id, id).find(relation_id)
|
Chris@0
|
899 end
|
Chris@441
|
900
|
Chris@1464
|
901 # Returns all the other issues that depend on the issue
|
Chris@1464
|
902 # The algorithm is a modified breadth first search (bfs)
|
Chris@441
|
903 def all_dependent_issues(except=[])
|
Chris@1464
|
904 # The found dependencies
|
Chris@0
|
905 dependencies = []
|
Chris@1464
|
906
|
Chris@1464
|
907 # The visited flag for every node (issue) used by the breadth first search
|
Chris@1464
|
908 eNOT_DISCOVERED = 0 # The issue is "new" to the algorithm, it has not seen it before.
|
Chris@1464
|
909
|
Chris@1464
|
910 ePROCESS_ALL = 1 # The issue is added to the queue. Process both children and relations of
|
Chris@1464
|
911 # the issue when it is processed.
|
Chris@1464
|
912
|
Chris@1464
|
913 ePROCESS_RELATIONS_ONLY = 2 # The issue was added to the queue and will be output as dependent issue,
|
Chris@1464
|
914 # but its children will not be added to the queue when it is processed.
|
Chris@1464
|
915
|
Chris@1464
|
916 eRELATIONS_PROCESSED = 3 # The related issues, the parent issue and the issue itself have been added to
|
Chris@1464
|
917 # the queue, but its children have not been added.
|
Chris@1464
|
918
|
Chris@1464
|
919 ePROCESS_CHILDREN_ONLY = 4 # The relations and the parent of the issue have been added to the queue, but
|
Chris@1464
|
920 # the children still need to be processed.
|
Chris@1464
|
921
|
Chris@1464
|
922 eALL_PROCESSED = 5 # The issue and all its children, its parent and its related issues have been
|
Chris@1464
|
923 # added as dependent issues. It needs no further processing.
|
Chris@1464
|
924
|
Chris@1464
|
925 issue_status = Hash.new(eNOT_DISCOVERED)
|
Chris@1464
|
926
|
Chris@1464
|
927 # The queue
|
Chris@1464
|
928 queue = []
|
Chris@1464
|
929
|
Chris@1464
|
930 # Initialize the bfs, add start node (self) to the queue
|
Chris@1464
|
931 queue << self
|
Chris@1464
|
932 issue_status[self] = ePROCESS_ALL
|
Chris@1464
|
933
|
Chris@1464
|
934 while (!queue.empty?) do
|
Chris@1464
|
935 current_issue = queue.shift
|
Chris@1464
|
936 current_issue_status = issue_status[current_issue]
|
Chris@1464
|
937 dependencies << current_issue
|
Chris@1464
|
938
|
Chris@1464
|
939 # Add parent to queue, if not already in it.
|
Chris@1464
|
940 parent = current_issue.parent
|
Chris@1464
|
941 parent_status = issue_status[parent]
|
Chris@1464
|
942
|
Chris@1464
|
943 if parent && (parent_status == eNOT_DISCOVERED) && !except.include?(parent)
|
Chris@1464
|
944 queue << parent
|
Chris@1464
|
945 issue_status[parent] = ePROCESS_RELATIONS_ONLY
|
Chris@128
|
946 end
|
Chris@1464
|
947
|
Chris@1464
|
948 # Add children to queue, but only if they are not already in it and
|
Chris@1464
|
949 # the children of the current node need to be processed.
|
Chris@1464
|
950 if (current_issue_status == ePROCESS_CHILDREN_ONLY || current_issue_status == ePROCESS_ALL)
|
Chris@1464
|
951 current_issue.children.each do |child|
|
Chris@1464
|
952 next if except.include?(child)
|
Chris@1464
|
953
|
Chris@1464
|
954 if (issue_status[child] == eNOT_DISCOVERED)
|
Chris@1464
|
955 queue << child
|
Chris@1464
|
956 issue_status[child] = ePROCESS_ALL
|
Chris@1464
|
957 elsif (issue_status[child] == eRELATIONS_PROCESSED)
|
Chris@1464
|
958 queue << child
|
Chris@1464
|
959 issue_status[child] = ePROCESS_CHILDREN_ONLY
|
Chris@1464
|
960 elsif (issue_status[child] == ePROCESS_RELATIONS_ONLY)
|
Chris@1464
|
961 queue << child
|
Chris@1464
|
962 issue_status[child] = ePROCESS_ALL
|
Chris@1464
|
963 end
|
Chris@1464
|
964 end
|
Chris@1464
|
965 end
|
Chris@1464
|
966
|
Chris@1464
|
967 # Add related issues to the queue, if they are not already in it.
|
Chris@1464
|
968 current_issue.relations_from.map(&:issue_to).each do |related_issue|
|
Chris@1464
|
969 next if except.include?(related_issue)
|
Chris@1464
|
970
|
Chris@1464
|
971 if (issue_status[related_issue] == eNOT_DISCOVERED)
|
Chris@1464
|
972 queue << related_issue
|
Chris@1464
|
973 issue_status[related_issue] = ePROCESS_ALL
|
Chris@1464
|
974 elsif (issue_status[related_issue] == eRELATIONS_PROCESSED)
|
Chris@1464
|
975 queue << related_issue
|
Chris@1464
|
976 issue_status[related_issue] = ePROCESS_CHILDREN_ONLY
|
Chris@1464
|
977 elsif (issue_status[related_issue] == ePROCESS_RELATIONS_ONLY)
|
Chris@1464
|
978 queue << related_issue
|
Chris@1464
|
979 issue_status[related_issue] = ePROCESS_ALL
|
Chris@1464
|
980 end
|
Chris@1464
|
981 end
|
Chris@1464
|
982
|
Chris@1464
|
983 # Set new status for current issue
|
Chris@1464
|
984 if (current_issue_status == ePROCESS_ALL) || (current_issue_status == ePROCESS_CHILDREN_ONLY)
|
Chris@1464
|
985 issue_status[current_issue] = eALL_PROCESSED
|
Chris@1464
|
986 elsif (current_issue_status == ePROCESS_RELATIONS_ONLY)
|
Chris@1464
|
987 issue_status[current_issue] = eRELATIONS_PROCESSED
|
Chris@1464
|
988 end
|
Chris@1464
|
989 end # while
|
Chris@1464
|
990
|
Chris@1464
|
991 # Remove the issues from the "except" parameter from the result array
|
Chris@1464
|
992 dependencies -= except
|
Chris@1464
|
993 dependencies.delete(self)
|
Chris@1464
|
994
|
Chris@0
|
995 dependencies
|
Chris@0
|
996 end
|
Chris@441
|
997
|
Chris@0
|
998 # Returns an array of issues that duplicate this one
|
Chris@0
|
999 def duplicates
|
Chris@0
|
1000 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
|
Chris@0
|
1001 end
|
Chris@441
|
1002
|
Chris@0
|
1003 # Returns the due date or the target due date if any
|
Chris@0
|
1004 # Used on gantt chart
|
Chris@0
|
1005 def due_before
|
Chris@0
|
1006 due_date || (fixed_version ? fixed_version.effective_date : nil)
|
Chris@0
|
1007 end
|
Chris@441
|
1008
|
Chris@0
|
1009 # Returns the time scheduled for this issue.
|
Chris@441
|
1010 #
|
Chris@0
|
1011 # Example:
|
Chris@0
|
1012 # Start Date: 2/26/09, End Date: 3/04/09
|
Chris@0
|
1013 # duration => 6
|
Chris@0
|
1014 def duration
|
Chris@0
|
1015 (start_date && due_date) ? due_date - start_date : 0
|
Chris@0
|
1016 end
|
Chris@441
|
1017
|
Chris@1115
|
1018 # Returns the duration in working days
|
Chris@1115
|
1019 def working_duration
|
Chris@1115
|
1020 (start_date && due_date) ? working_days(start_date, due_date) : 0
|
Chris@1115
|
1021 end
|
Chris@1115
|
1022
|
Chris@1115
|
1023 def soonest_start(reload=false)
|
Chris@1115
|
1024 @soonest_start = nil if reload
|
Chris@0
|
1025 @soonest_start ||= (
|
Chris@1115
|
1026 relations_to(reload).collect{|relation| relation.successor_soonest_start} +
|
Chris@1464
|
1027 [(@parent_issue || parent).try(:soonest_start)]
|
Chris@0
|
1028 ).compact.max
|
Chris@0
|
1029 end
|
Chris@441
|
1030
|
Chris@1115
|
1031 # Sets start_date on the given date or the next working day
|
Chris@1115
|
1032 # and changes due_date to keep the same working duration.
|
Chris@1115
|
1033 def reschedule_on(date)
|
Chris@1115
|
1034 wd = working_duration
|
Chris@1115
|
1035 date = next_working_date(date)
|
Chris@1115
|
1036 self.start_date = date
|
Chris@1115
|
1037 self.due_date = add_working_days(date, wd)
|
Chris@1115
|
1038 end
|
Chris@1115
|
1039
|
Chris@1115
|
1040 # Reschedules the issue on the given date or the next working day and saves the record.
|
Chris@1115
|
1041 # If the issue is a parent task, this is done by rescheduling its subtasks.
|
Chris@1115
|
1042 def reschedule_on!(date)
|
Chris@0
|
1043 return if date.nil?
|
Chris@0
|
1044 if leaf?
|
Chris@1115
|
1045 if start_date.nil? || start_date != date
|
Chris@1115
|
1046 if start_date && start_date > date
|
Chris@1115
|
1047 # Issue can not be moved earlier than its soonest start date
|
Chris@1115
|
1048 date = [soonest_start(true), date].compact.max
|
Chris@1115
|
1049 end
|
Chris@1115
|
1050 reschedule_on(date)
|
Chris@1115
|
1051 begin
|
Chris@1115
|
1052 save
|
Chris@1115
|
1053 rescue ActiveRecord::StaleObjectError
|
Chris@1115
|
1054 reload
|
Chris@1115
|
1055 reschedule_on(date)
|
Chris@1115
|
1056 save
|
Chris@1115
|
1057 end
|
Chris@0
|
1058 end
|
Chris@0
|
1059 else
|
Chris@0
|
1060 leaves.each do |leaf|
|
Chris@1115
|
1061 if leaf.start_date
|
Chris@1115
|
1062 # Only move subtask if it starts at the same date as the parent
|
Chris@1115
|
1063 # or if it starts before the given date
|
Chris@1115
|
1064 if start_date == leaf.start_date || date > leaf.start_date
|
Chris@1115
|
1065 leaf.reschedule_on!(date)
|
Chris@1115
|
1066 end
|
Chris@1115
|
1067 else
|
Chris@1115
|
1068 leaf.reschedule_on!(date)
|
Chris@1115
|
1069 end
|
Chris@0
|
1070 end
|
Chris@0
|
1071 end
|
Chris@0
|
1072 end
|
Chris@441
|
1073
|
Chris@0
|
1074 def <=>(issue)
|
Chris@0
|
1075 if issue.nil?
|
Chris@0
|
1076 -1
|
Chris@0
|
1077 elsif root_id != issue.root_id
|
Chris@0
|
1078 (root_id || 0) <=> (issue.root_id || 0)
|
Chris@0
|
1079 else
|
Chris@0
|
1080 (lft || 0) <=> (issue.lft || 0)
|
Chris@0
|
1081 end
|
Chris@0
|
1082 end
|
Chris@441
|
1083
|
Chris@0
|
1084 def to_s
|
Chris@0
|
1085 "#{tracker} ##{id}: #{subject}"
|
Chris@0
|
1086 end
|
Chris@441
|
1087
|
Chris@0
|
1088 # Returns a string of css classes that apply to the issue
|
Chris@1464
|
1089 def css_classes(user=User.current)
|
Chris@1464
|
1090 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
|
Chris@0
|
1091 s << ' closed' if closed?
|
Chris@0
|
1092 s << ' overdue' if overdue?
|
Chris@441
|
1093 s << ' child' if child?
|
Chris@441
|
1094 s << ' parent' unless leaf?
|
Chris@441
|
1095 s << ' private' if is_private?
|
Chris@1464
|
1096 if user.logged?
|
Chris@1464
|
1097 s << ' created-by-me' if author_id == user.id
|
Chris@1464
|
1098 s << ' assigned-to-me' if assigned_to_id == user.id
|
Chris@1494
|
1099 s << ' assigned-to-my-group' if user.groups.any? {|g| g.id == assigned_to_id}
|
Chris@1464
|
1100 end
|
Chris@0
|
1101 s
|
Chris@0
|
1102 end
|
Chris@0
|
1103
|
Chris@0
|
1104 # Unassigns issues from +version+ if it's no longer shared with issue's project
|
Chris@0
|
1105 def self.update_versions_from_sharing_change(version)
|
Chris@0
|
1106 # Update issues assigned to the version
|
Chris@0
|
1107 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
|
Chris@0
|
1108 end
|
Chris@441
|
1109
|
Chris@0
|
1110 # Unassigns issues from versions that are no longer shared
|
Chris@0
|
1111 # after +project+ was moved
|
Chris@0
|
1112 def self.update_versions_from_hierarchy_change(project)
|
Chris@0
|
1113 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
|
Chris@0
|
1114 # Update issues of the moved projects and issues assigned to a version of a moved project
|
Chris@0
|
1115 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
|
Chris@0
|
1116 end
|
Chris@0
|
1117
|
Chris@0
|
1118 def parent_issue_id=(arg)
|
Chris@1115
|
1119 s = arg.to_s.strip.presence
|
Chris@1115
|
1120 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
|
Chris@0
|
1121 @parent_issue.id
|
Chris@1464
|
1122 @invalid_parent_issue_id = nil
|
Chris@1464
|
1123 elsif s.blank?
|
Chris@1464
|
1124 @parent_issue = nil
|
Chris@1464
|
1125 @invalid_parent_issue_id = nil
|
Chris@0
|
1126 else
|
Chris@0
|
1127 @parent_issue = nil
|
Chris@1115
|
1128 @invalid_parent_issue_id = arg
|
Chris@0
|
1129 end
|
Chris@0
|
1130 end
|
Chris@441
|
1131
|
Chris@0
|
1132 def parent_issue_id
|
Chris@1115
|
1133 if @invalid_parent_issue_id
|
Chris@1115
|
1134 @invalid_parent_issue_id
|
Chris@1115
|
1135 elsif instance_variable_defined? :@parent_issue
|
Chris@0
|
1136 @parent_issue.nil? ? nil : @parent_issue.id
|
Chris@0
|
1137 else
|
Chris@0
|
1138 parent_id
|
Chris@0
|
1139 end
|
Chris@0
|
1140 end
|
Chris@0
|
1141
|
Chris@1464
|
1142 # Returns true if issue's project is a valid
|
Chris@1464
|
1143 # parent issue project
|
Chris@1115
|
1144 def valid_parent_project?(issue=parent)
|
Chris@1115
|
1145 return true if issue.nil? || issue.project_id == project_id
|
Chris@1115
|
1146
|
Chris@1115
|
1147 case Setting.cross_project_subtasks
|
Chris@1115
|
1148 when 'system'
|
Chris@1115
|
1149 true
|
Chris@1115
|
1150 when 'tree'
|
Chris@1115
|
1151 issue.project.root == project.root
|
Chris@1115
|
1152 when 'hierarchy'
|
Chris@1115
|
1153 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
|
Chris@1115
|
1154 when 'descendants'
|
Chris@1115
|
1155 issue.project.is_or_is_ancestor_of?(project)
|
Chris@1115
|
1156 else
|
Chris@1115
|
1157 false
|
Chris@1115
|
1158 end
|
Chris@1115
|
1159 end
|
Chris@1115
|
1160
|
Chris@0
|
1161 # Extracted from the ReportsController.
|
Chris@0
|
1162 def self.by_tracker(project)
|
Chris@0
|
1163 count_and_group_by(:project => project,
|
Chris@0
|
1164 :field => 'tracker_id',
|
Chris@0
|
1165 :joins => Tracker.table_name)
|
Chris@0
|
1166 end
|
Chris@0
|
1167
|
Chris@0
|
1168 def self.by_version(project)
|
Chris@0
|
1169 count_and_group_by(:project => project,
|
Chris@0
|
1170 :field => 'fixed_version_id',
|
Chris@0
|
1171 :joins => Version.table_name)
|
Chris@0
|
1172 end
|
Chris@0
|
1173
|
Chris@0
|
1174 def self.by_priority(project)
|
Chris@0
|
1175 count_and_group_by(:project => project,
|
Chris@0
|
1176 :field => 'priority_id',
|
Chris@0
|
1177 :joins => IssuePriority.table_name)
|
Chris@0
|
1178 end
|
Chris@0
|
1179
|
Chris@0
|
1180 def self.by_category(project)
|
Chris@0
|
1181 count_and_group_by(:project => project,
|
Chris@0
|
1182 :field => 'category_id',
|
Chris@0
|
1183 :joins => IssueCategory.table_name)
|
Chris@0
|
1184 end
|
Chris@0
|
1185
|
Chris@0
|
1186 def self.by_assigned_to(project)
|
Chris@0
|
1187 count_and_group_by(:project => project,
|
Chris@0
|
1188 :field => 'assigned_to_id',
|
Chris@0
|
1189 :joins => User.table_name)
|
Chris@0
|
1190 end
|
Chris@0
|
1191
|
Chris@0
|
1192 def self.by_author(project)
|
Chris@0
|
1193 count_and_group_by(:project => project,
|
Chris@0
|
1194 :field => 'author_id',
|
Chris@0
|
1195 :joins => User.table_name)
|
Chris@0
|
1196 end
|
Chris@0
|
1197
|
Chris@0
|
1198 def self.by_subproject(project)
|
Chris@0
|
1199 ActiveRecord::Base.connection.select_all("select s.id as status_id,
|
Chris@0
|
1200 s.is_closed as closed,
|
Chris@441
|
1201 #{Issue.table_name}.project_id as project_id,
|
Chris@441
|
1202 count(#{Issue.table_name}.id) as total
|
Chris@0
|
1203 from
|
Chris@441
|
1204 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
|
Chris@0
|
1205 where
|
Chris@441
|
1206 #{Issue.table_name}.status_id=s.id
|
Chris@441
|
1207 and #{Issue.table_name}.project_id = #{Project.table_name}.id
|
Chris@441
|
1208 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
|
Chris@441
|
1209 and #{Issue.table_name}.project_id <> #{project.id}
|
Chris@441
|
1210 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
|
Chris@0
|
1211 end
|
Chris@0
|
1212 # End ReportsController extraction
|
Chris@441
|
1213
|
Chris@1464
|
1214 # Returns a scope of projects that user can assign the issue to
|
Chris@1115
|
1215 def allowed_target_projects(user=User.current)
|
Chris@1115
|
1216 if new_record?
|
Chris@1464
|
1217 Project.where(Project.allowed_to_condition(user, :add_issues))
|
Chris@1115
|
1218 else
|
Chris@1115
|
1219 self.class.allowed_target_projects_on_move(user)
|
Chris@0
|
1220 end
|
Chris@1115
|
1221 end
|
Chris@1115
|
1222
|
Chris@1464
|
1223 # Returns a scope of projects that user can move issues to
|
Chris@1115
|
1224 def self.allowed_target_projects_on_move(user=User.current)
|
Chris@1464
|
1225 Project.where(Project.allowed_to_condition(user, :move_issues))
|
Chris@0
|
1226 end
|
Chris@441
|
1227
|
Chris@0
|
1228 private
|
Chris@441
|
1229
|
Chris@1115
|
1230 def after_project_change
|
Chris@1115
|
1231 # Update project_id on related time entries
|
Chris@1517
|
1232 TimeEntry.where({:issue_id => id}).update_all(["project_id = ?", project_id])
|
Chris@1115
|
1233
|
Chris@1115
|
1234 # Delete issue relations
|
Chris@1115
|
1235 unless Setting.cross_project_issue_relations?
|
Chris@1115
|
1236 relations_from.clear
|
Chris@1115
|
1237 relations_to.clear
|
Chris@1115
|
1238 end
|
Chris@1115
|
1239
|
Chris@1115
|
1240 # Move subtasks that were in the same project
|
Chris@1115
|
1241 children.each do |child|
|
Chris@1115
|
1242 next unless child.project_id == project_id_was
|
Chris@1115
|
1243 # Change project and keep project
|
Chris@1115
|
1244 child.send :project=, project, true
|
Chris@1115
|
1245 unless child.save
|
Chris@1115
|
1246 raise ActiveRecord::Rollback
|
Chris@1115
|
1247 end
|
Chris@1115
|
1248 end
|
Chris@1115
|
1249 end
|
Chris@1115
|
1250
|
Chris@1115
|
1251 # Callback for after the creation of an issue by copy
|
Chris@1115
|
1252 # * adds a "copied to" relation with the copied issue
|
Chris@1115
|
1253 # * copies subtasks from the copied issue
|
Chris@1115
|
1254 def after_create_from_copy
|
Chris@1115
|
1255 return unless copy? && !@after_create_from_copy_handled
|
Chris@1115
|
1256
|
Chris@1115
|
1257 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
|
Chris@1115
|
1258 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
|
Chris@1115
|
1259 unless relation.save
|
Chris@1115
|
1260 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
|
Chris@1115
|
1261 end
|
Chris@1115
|
1262 end
|
Chris@1115
|
1263
|
Chris@1115
|
1264 unless @copied_from.leaf? || @copy_options[:subtasks] == false
|
Chris@1464
|
1265 copy_options = (@copy_options || {}).merge(:subtasks => false)
|
Chris@1464
|
1266 copied_issue_ids = {@copied_from.id => self.id}
|
Chris@1464
|
1267 @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
|
Chris@1464
|
1268 # Do not copy self when copying an issue as a descendant of the copied issue
|
Chris@1464
|
1269 next if child == self
|
Chris@1464
|
1270 # Do not copy subtasks of issues that were not copied
|
Chris@1464
|
1271 next unless copied_issue_ids[child.parent_id]
|
Chris@1464
|
1272 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
|
Chris@1115
|
1273 unless child.visible?
|
Chris@1115
|
1274 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
|
Chris@1115
|
1275 next
|
Chris@1115
|
1276 end
|
Chris@1464
|
1277 copy = Issue.new.copy_from(child, copy_options)
|
Chris@1115
|
1278 copy.author = author
|
Chris@1115
|
1279 copy.project = project
|
Chris@1464
|
1280 copy.parent_issue_id = copied_issue_ids[child.parent_id]
|
Chris@1115
|
1281 unless copy.save
|
Chris@1115
|
1282 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
|
Chris@1464
|
1283 next
|
Chris@1115
|
1284 end
|
Chris@1464
|
1285 copied_issue_ids[child.id] = copy.id
|
Chris@1115
|
1286 end
|
Chris@1115
|
1287 end
|
Chris@1115
|
1288 @after_create_from_copy_handled = true
|
Chris@1115
|
1289 end
|
Chris@1115
|
1290
|
Chris@0
|
1291 def update_nested_set_attributes
|
Chris@0
|
1292 if root_id.nil?
|
Chris@0
|
1293 # issue was just created
|
Chris@0
|
1294 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
|
Chris@0
|
1295 set_default_left_and_right
|
Chris@1517
|
1296 Issue.where(["id = ?", id]).
|
Chris@1517
|
1297 update_all(["root_id = ?, lft = ?, rgt = ?", root_id, lft, rgt])
|
Chris@0
|
1298 if @parent_issue
|
Chris@0
|
1299 move_to_child_of(@parent_issue)
|
Chris@0
|
1300 end
|
Chris@0
|
1301 elsif parent_issue_id != parent_id
|
Chris@1464
|
1302 update_nested_set_attributes_on_parent_change
|
Chris@0
|
1303 end
|
Chris@0
|
1304 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
|
Chris@0
|
1305 end
|
Chris@441
|
1306
|
Chris@1464
|
1307 # Updates the nested set for when an existing issue is moved
|
Chris@1464
|
1308 def update_nested_set_attributes_on_parent_change
|
Chris@1464
|
1309 former_parent_id = parent_id
|
Chris@1464
|
1310 # moving an existing issue
|
Chris@1464
|
1311 if @parent_issue && @parent_issue.root_id == root_id
|
Chris@1464
|
1312 # inside the same tree
|
Chris@1464
|
1313 move_to_child_of(@parent_issue)
|
Chris@1464
|
1314 else
|
Chris@1464
|
1315 # to another tree
|
Chris@1464
|
1316 unless root?
|
Chris@1464
|
1317 move_to_right_of(root)
|
Chris@1464
|
1318 end
|
Chris@1464
|
1319 old_root_id = root_id
|
Chris@1464
|
1320 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
|
Chris@1464
|
1321 target_maxright = nested_set_scope.maximum(right_column_name) || 0
|
Chris@1464
|
1322 offset = target_maxright + 1 - lft
|
Chris@1517
|
1323 Issue.where(["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt]).
|
Chris@1517
|
1324 update_all(["root_id = ?, lft = lft + ?, rgt = rgt + ?", root_id, offset, offset])
|
Chris@1464
|
1325 self[left_column_name] = lft + offset
|
Chris@1464
|
1326 self[right_column_name] = rgt + offset
|
Chris@1464
|
1327 if @parent_issue
|
Chris@1464
|
1328 move_to_child_of(@parent_issue)
|
Chris@1464
|
1329 end
|
Chris@1464
|
1330 end
|
Chris@1464
|
1331 # delete invalid relations of all descendants
|
Chris@1464
|
1332 self_and_descendants.each do |issue|
|
Chris@1464
|
1333 issue.relations.each do |relation|
|
Chris@1464
|
1334 relation.destroy unless relation.valid?
|
Chris@1464
|
1335 end
|
Chris@1464
|
1336 end
|
Chris@1464
|
1337 # update former parent
|
Chris@1464
|
1338 recalculate_attributes_for(former_parent_id) if former_parent_id
|
Chris@1464
|
1339 end
|
Chris@1464
|
1340
|
Chris@0
|
1341 def update_parent_attributes
|
Chris@0
|
1342 recalculate_attributes_for(parent_id) if parent_id
|
Chris@0
|
1343 end
|
Chris@0
|
1344
|
Chris@0
|
1345 def recalculate_attributes_for(issue_id)
|
Chris@0
|
1346 if issue_id && p = Issue.find_by_id(issue_id)
|
Chris@0
|
1347 # priority = highest priority of children
|
Chris@1517
|
1348 if priority_position = p.children.joins(:priority).maximum("#{IssuePriority.table_name}.position")
|
Chris@0
|
1349 p.priority = IssuePriority.find_by_position(priority_position)
|
Chris@0
|
1350 end
|
Chris@441
|
1351
|
Chris@0
|
1352 # start/due dates = lowest/highest dates of children
|
Chris@0
|
1353 p.start_date = p.children.minimum(:start_date)
|
Chris@0
|
1354 p.due_date = p.children.maximum(:due_date)
|
Chris@0
|
1355 if p.start_date && p.due_date && p.due_date < p.start_date
|
Chris@0
|
1356 p.start_date, p.due_date = p.due_date, p.start_date
|
Chris@0
|
1357 end
|
Chris@441
|
1358
|
Chris@0
|
1359 # done ratio = weighted average ratio of leaves
|
chris@37
|
1360 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
|
Chris@0
|
1361 leaves_count = p.leaves.count
|
Chris@0
|
1362 if leaves_count > 0
|
Chris@1494
|
1363 average = p.leaves.where("estimated_hours > 0").average(:estimated_hours).to_f
|
Chris@0
|
1364 if average == 0
|
Chris@0
|
1365 average = 1
|
Chris@0
|
1366 end
|
Chris@1517
|
1367 done = p.leaves.joins(:status).
|
Chris@1517
|
1368 sum("COALESCE(CASE WHEN estimated_hours > 0 THEN estimated_hours ELSE NULL END, #{average}) " +
|
Chris@1517
|
1369 "* (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)").to_f
|
Chris@0
|
1370 progress = done / (average * leaves_count)
|
Chris@0
|
1371 p.done_ratio = progress.round
|
Chris@0
|
1372 end
|
Chris@0
|
1373 end
|
Chris@441
|
1374
|
Chris@0
|
1375 # estimate = sum of leaves estimates
|
Chris@0
|
1376 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
|
Chris@0
|
1377 p.estimated_hours = nil if p.estimated_hours == 0.0
|
Chris@441
|
1378
|
Chris@0
|
1379 # ancestors will be recursively updated
|
Chris@1115
|
1380 p.save(:validate => false)
|
Chris@0
|
1381 end
|
Chris@0
|
1382 end
|
Chris@441
|
1383
|
Chris@0
|
1384 # Update issues so their versions are not pointing to a
|
Chris@0
|
1385 # fixed_version that is not shared with the issue's project
|
Chris@0
|
1386 def self.update_versions(conditions=nil)
|
Chris@0
|
1387 # Only need to update issues with a fixed_version from
|
Chris@0
|
1388 # a different project and that is not systemwide shared
|
Chris@1464
|
1389 Issue.includes(:project, :fixed_version).
|
Chris@1464
|
1390 where("#{Issue.table_name}.fixed_version_id IS NOT NULL" +
|
Chris@1115
|
1391 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
|
Chris@1464
|
1392 " AND #{Version.table_name}.sharing <> 'system'").
|
Chris@1464
|
1393 where(conditions).each do |issue|
|
Chris@0
|
1394 next if issue.project.nil? || issue.fixed_version.nil?
|
Chris@0
|
1395 unless issue.project.shared_versions.include?(issue.fixed_version)
|
Chris@0
|
1396 issue.init_journal(User.current)
|
Chris@0
|
1397 issue.fixed_version = nil
|
Chris@0
|
1398 issue.save
|
Chris@0
|
1399 end
|
Chris@0
|
1400 end
|
Chris@0
|
1401 end
|
Chris@441
|
1402
|
Chris@1115
|
1403 # Callback on file attachment
|
Chris@909
|
1404 def attachment_added(obj)
|
Chris@909
|
1405 if @current_journal && !obj.new_record?
|
Chris@909
|
1406 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
|
Chris@909
|
1407 end
|
Chris@909
|
1408 end
|
Chris@909
|
1409
|
Chris@909
|
1410 # Callback on attachment deletion
|
Chris@0
|
1411 def attachment_removed(obj)
|
Chris@1115
|
1412 if @current_journal && !obj.new_record?
|
Chris@1115
|
1413 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
|
Chris@1115
|
1414 @current_journal.save
|
Chris@1115
|
1415 end
|
Chris@0
|
1416 end
|
Chris@441
|
1417
|
Chris@0
|
1418 # Default assignment based on category
|
Chris@0
|
1419 def default_assign
|
Chris@0
|
1420 if assigned_to.nil? && category && category.assigned_to
|
Chris@0
|
1421 self.assigned_to = category.assigned_to
|
Chris@0
|
1422 end
|
Chris@0
|
1423 end
|
Chris@0
|
1424
|
Chris@0
|
1425 # Updates start/due dates of following issues
|
Chris@0
|
1426 def reschedule_following_issues
|
Chris@0
|
1427 if start_date_changed? || due_date_changed?
|
Chris@0
|
1428 relations_from.each do |relation|
|
Chris@0
|
1429 relation.set_issue_to_dates
|
Chris@0
|
1430 end
|
Chris@0
|
1431 end
|
Chris@0
|
1432 end
|
Chris@0
|
1433
|
Chris@0
|
1434 # Closes duplicates if the issue is being closed
|
Chris@0
|
1435 def close_duplicates
|
Chris@0
|
1436 if closing?
|
Chris@0
|
1437 duplicates.each do |duplicate|
|
Chris@0
|
1438 # Reload is need in case the duplicate was updated by a previous duplicate
|
Chris@0
|
1439 duplicate.reload
|
Chris@0
|
1440 # Don't re-close it if it's already closed
|
Chris@0
|
1441 next if duplicate.closed?
|
Chris@0
|
1442 # Same user and notes
|
Chris@0
|
1443 if @current_journal
|
Chris@0
|
1444 duplicate.init_journal(@current_journal.user, @current_journal.notes)
|
Chris@0
|
1445 end
|
Chris@0
|
1446 duplicate.update_attribute :status, self.status
|
Chris@0
|
1447 end
|
Chris@0
|
1448 end
|
Chris@0
|
1449 end
|
Chris@441
|
1450
|
Chris@1464
|
1451 # Make sure updated_on is updated when adding a note and set updated_on now
|
Chris@1464
|
1452 # so we can set closed_on with the same value on closing
|
Chris@1115
|
1453 def force_updated_on_change
|
Chris@1464
|
1454 if @current_journal || changed?
|
Chris@1115
|
1455 self.updated_on = current_time_from_proper_timezone
|
Chris@1464
|
1456 if new_record?
|
Chris@1464
|
1457 self.created_on = updated_on
|
Chris@1464
|
1458 end
|
Chris@1464
|
1459 end
|
Chris@1464
|
1460 end
|
Chris@1464
|
1461
|
Chris@1464
|
1462 # Callback for setting closed_on when the issue is closed.
|
Chris@1464
|
1463 # The closed_on attribute stores the time of the last closing
|
Chris@1464
|
1464 # and is preserved when the issue is reopened.
|
Chris@1464
|
1465 def update_closed_on
|
Chris@1464
|
1466 if closing? || (new_record? && closed?)
|
Chris@1464
|
1467 self.closed_on = updated_on
|
Chris@1115
|
1468 end
|
Chris@1115
|
1469 end
|
Chris@1115
|
1470
|
Chris@0
|
1471 # Saves the changes in a Journal
|
Chris@0
|
1472 # Called after_save
|
Chris@0
|
1473 def create_journal
|
Chris@0
|
1474 if @current_journal
|
Chris@0
|
1475 # attributes changes
|
Chris@1115
|
1476 if @attributes_before_change
|
Chris@1464
|
1477 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
|
Chris@1115
|
1478 before = @attributes_before_change[c]
|
Chris@1115
|
1479 after = send(c)
|
Chris@1115
|
1480 next if before == after || (before.blank? && after.blank?)
|
Chris@1115
|
1481 @current_journal.details << JournalDetail.new(:property => 'attr',
|
Chris@1115
|
1482 :prop_key => c,
|
Chris@1115
|
1483 :old_value => before,
|
Chris@1115
|
1484 :value => after)
|
Chris@1115
|
1485 }
|
Chris@1115
|
1486 end
|
Chris@1115
|
1487 if @custom_values_before_change
|
Chris@1115
|
1488 # custom fields changes
|
Chris@1115
|
1489 custom_field_values.each {|c|
|
Chris@1115
|
1490 before = @custom_values_before_change[c.custom_field_id]
|
Chris@1115
|
1491 after = c.value
|
Chris@1115
|
1492 next if before == after || (before.blank? && after.blank?)
|
Chris@1115
|
1493
|
Chris@1115
|
1494 if before.is_a?(Array) || after.is_a?(Array)
|
Chris@1115
|
1495 before = [before] unless before.is_a?(Array)
|
Chris@1115
|
1496 after = [after] unless after.is_a?(Array)
|
Chris@1115
|
1497
|
Chris@1115
|
1498 # values removed
|
Chris@1115
|
1499 (before - after).reject(&:blank?).each do |value|
|
Chris@1115
|
1500 @current_journal.details << JournalDetail.new(:property => 'cf',
|
Chris@1115
|
1501 :prop_key => c.custom_field_id,
|
Chris@1115
|
1502 :old_value => value,
|
Chris@1115
|
1503 :value => nil)
|
Chris@1115
|
1504 end
|
Chris@1115
|
1505 # values added
|
Chris@1115
|
1506 (after - before).reject(&:blank?).each do |value|
|
Chris@1115
|
1507 @current_journal.details << JournalDetail.new(:property => 'cf',
|
Chris@1115
|
1508 :prop_key => c.custom_field_id,
|
Chris@1115
|
1509 :old_value => nil,
|
Chris@1115
|
1510 :value => value)
|
Chris@1115
|
1511 end
|
Chris@1115
|
1512 else
|
Chris@1115
|
1513 @current_journal.details << JournalDetail.new(:property => 'cf',
|
Chris@1115
|
1514 :prop_key => c.custom_field_id,
|
Chris@1115
|
1515 :old_value => before,
|
Chris@1115
|
1516 :value => after)
|
Chris@1115
|
1517 end
|
Chris@1115
|
1518 }
|
Chris@1115
|
1519 end
|
Chris@0
|
1520 @current_journal.save
|
Chris@0
|
1521 # reset current journal
|
Chris@0
|
1522 init_journal @current_journal.user, @current_journal.notes
|
Chris@0
|
1523 end
|
Chris@0
|
1524 end
|
Chris@0
|
1525
|
Chris@1464
|
1526 def send_notification
|
Chris@1464
|
1527 if Setting.notified_events.include?('issue_added')
|
Chris@1464
|
1528 Mailer.deliver_issue_add(self)
|
Chris@1464
|
1529 end
|
Chris@1464
|
1530 end
|
Chris@1464
|
1531
|
Chris@1464
|
1532 # Stores the previous assignee so we can still have access
|
Chris@1464
|
1533 # to it during after_save callbacks (assigned_to_id_was is reset)
|
Chris@1464
|
1534 def set_assigned_to_was
|
Chris@1464
|
1535 @previous_assigned_to_id = assigned_to_id_was
|
Chris@1464
|
1536 end
|
Chris@1464
|
1537
|
Chris@1464
|
1538 # Clears the previous assignee at the end of after_save callbacks
|
Chris@1464
|
1539 def clear_assigned_to_was
|
Chris@1464
|
1540 @assigned_to_was = nil
|
Chris@1464
|
1541 @previous_assigned_to_id = nil
|
Chris@1464
|
1542 end
|
Chris@1464
|
1543
|
Chris@0
|
1544 # Query generator for selecting groups of issue counts for a project
|
Chris@0
|
1545 # based on specific criteria
|
Chris@0
|
1546 #
|
Chris@0
|
1547 # Options
|
Chris@0
|
1548 # * project - Project to search in.
|
Chris@0
|
1549 # * field - String. Issue field to key off of in the grouping.
|
Chris@0
|
1550 # * joins - String. The table name to join against.
|
Chris@0
|
1551 def self.count_and_group_by(options)
|
Chris@0
|
1552 project = options.delete(:project)
|
Chris@0
|
1553 select_field = options.delete(:field)
|
Chris@0
|
1554 joins = options.delete(:joins)
|
Chris@0
|
1555
|
Chris@441
|
1556 where = "#{Issue.table_name}.#{select_field}=j.id"
|
Chris@441
|
1557
|
Chris@0
|
1558 ActiveRecord::Base.connection.select_all("select s.id as status_id,
|
Chris@0
|
1559 s.is_closed as closed,
|
Chris@0
|
1560 j.id as #{select_field},
|
Chris@441
|
1561 count(#{Issue.table_name}.id) as total
|
Chris@0
|
1562 from
|
Chris@441
|
1563 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
|
Chris@0
|
1564 where
|
Chris@441
|
1565 #{Issue.table_name}.status_id=s.id
|
Chris@0
|
1566 and #{where}
|
Chris@441
|
1567 and #{Issue.table_name}.project_id=#{Project.table_name}.id
|
Chris@441
|
1568 and #{visible_condition(User.current, :project => project)}
|
Chris@0
|
1569 group by s.id, s.is_closed, j.id")
|
Chris@0
|
1570 end
|
Chris@0
|
1571 end
|