annotate .svn/pristine/a7/a7c522fa48845e70c7a7bc89a951a0055cb1f96f.svn-base @ 1298:4f746d8966dd redmine_2.3_integration

Merge from redmine-2.3 branch to create new branch redmine-2.3-integration
author Chris Cannam
date Fri, 14 Jun 2013 09:28:30 +0100
parents 622f24f53b42
children
rev   line source
Chris@1295 1 # Redmine - project management software
Chris@1295 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
Chris@1295 3 #
Chris@1295 4 # This program is free software; you can redistribute it and/or
Chris@1295 5 # modify it under the terms of the GNU General Public License
Chris@1295 6 # as published by the Free Software Foundation; either version 2
Chris@1295 7 # of the License, or (at your option) any later version.
Chris@1295 8 #
Chris@1295 9 # This program is distributed in the hope that it will be useful,
Chris@1295 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1295 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@1295 12 # GNU General Public License for more details.
Chris@1295 13 #
Chris@1295 14 # You should have received a copy of the GNU General Public License
Chris@1295 15 # along with this program; if not, write to the Free Software
Chris@1295 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@1295 17
Chris@1295 18 require File.expand_path('../../test_helper', __FILE__)
Chris@1295 19
Chris@1295 20 class IssueTest < ActiveSupport::TestCase
Chris@1295 21 fixtures :projects, :users, :members, :member_roles, :roles,
Chris@1295 22 :groups_users,
Chris@1295 23 :trackers, :projects_trackers,
Chris@1295 24 :enabled_modules,
Chris@1295 25 :versions,
Chris@1295 26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
Chris@1295 27 :enumerations,
Chris@1295 28 :issues, :journals, :journal_details,
Chris@1295 29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
Chris@1295 30 :time_entries
Chris@1295 31
Chris@1295 32 include Redmine::I18n
Chris@1295 33
Chris@1295 34 def teardown
Chris@1295 35 User.current = nil
Chris@1295 36 end
Chris@1295 37
Chris@1295 38 def test_initialize
Chris@1295 39 issue = Issue.new
Chris@1295 40
Chris@1295 41 assert_nil issue.project_id
Chris@1295 42 assert_nil issue.tracker_id
Chris@1295 43 assert_nil issue.author_id
Chris@1295 44 assert_nil issue.assigned_to_id
Chris@1295 45 assert_nil issue.category_id
Chris@1295 46
Chris@1295 47 assert_equal IssueStatus.default, issue.status
Chris@1295 48 assert_equal IssuePriority.default, issue.priority
Chris@1295 49 end
Chris@1295 50
Chris@1295 51 def test_create
Chris@1295 52 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1295 53 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1295 54 :subject => 'test_create',
Chris@1295 55 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
Chris@1295 56 assert issue.save
Chris@1295 57 issue.reload
Chris@1295 58 assert_equal 1.5, issue.estimated_hours
Chris@1295 59 end
Chris@1295 60
Chris@1295 61 def test_create_minimal
Chris@1295 62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1295 63 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1295 64 :subject => 'test_create')
Chris@1295 65 assert issue.save
Chris@1295 66 assert issue.description.nil?
Chris@1295 67 assert_nil issue.estimated_hours
Chris@1295 68 end
Chris@1295 69
Chris@1295 70 def test_start_date_format_should_be_validated
Chris@1295 71 set_language_if_valid 'en'
Chris@1295 72 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
Chris@1295 73 issue = Issue.new(:start_date => invalid_date)
Chris@1295 74 assert !issue.valid?
Chris@1295 75 assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
Chris@1295 76 end
Chris@1295 77 end
Chris@1295 78
Chris@1295 79 def test_due_date_format_should_be_validated
Chris@1295 80 set_language_if_valid 'en'
Chris@1295 81 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
Chris@1295 82 issue = Issue.new(:due_date => invalid_date)
Chris@1295 83 assert !issue.valid?
Chris@1295 84 assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
Chris@1295 85 end
Chris@1295 86 end
Chris@1295 87
Chris@1295 88 def test_due_date_lesser_than_start_date_should_not_validate
Chris@1295 89 set_language_if_valid 'en'
Chris@1295 90 issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
Chris@1295 91 assert !issue.valid?
Chris@1295 92 assert_include 'Due date must be greater than start date', issue.errors.full_messages
Chris@1295 93 end
Chris@1295 94
Chris@1295 95 def test_estimated_hours_should_be_validated
Chris@1295 96 set_language_if_valid 'en'
Chris@1295 97 ['-2'].each do |invalid|
Chris@1295 98 issue = Issue.new(:estimated_hours => invalid)
Chris@1295 99 assert !issue.valid?
Chris@1295 100 assert_include 'Estimated time is invalid', issue.errors.full_messages
Chris@1295 101 end
Chris@1295 102 end
Chris@1295 103
Chris@1295 104 def test_create_with_required_custom_field
Chris@1295 105 set_language_if_valid 'en'
Chris@1295 106 field = IssueCustomField.find_by_name('Database')
Chris@1295 107 field.update_attribute(:is_required, true)
Chris@1295 108
Chris@1295 109 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 110 :status_id => 1, :subject => 'test_create',
Chris@1295 111 :description => 'IssueTest#test_create_with_required_custom_field')
Chris@1295 112 assert issue.available_custom_fields.include?(field)
Chris@1295 113 # No value for the custom field
Chris@1295 114 assert !issue.save
Chris@1295 115 assert_equal ["Database can't be blank"], issue.errors.full_messages
Chris@1295 116 # Blank value
Chris@1295 117 issue.custom_field_values = { field.id => '' }
Chris@1295 118 assert !issue.save
Chris@1295 119 assert_equal ["Database can't be blank"], issue.errors.full_messages
Chris@1295 120 # Invalid value
Chris@1295 121 issue.custom_field_values = { field.id => 'SQLServer' }
Chris@1295 122 assert !issue.save
Chris@1295 123 assert_equal ["Database is not included in the list"], issue.errors.full_messages
Chris@1295 124 # Valid value
Chris@1295 125 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1295 126 assert issue.save
Chris@1295 127 issue.reload
Chris@1295 128 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
Chris@1295 129 end
Chris@1295 130
Chris@1295 131 def test_create_with_group_assignment
Chris@1295 132 with_settings :issue_group_assignment => '1' do
Chris@1295 133 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
Chris@1295 134 :subject => 'Group assignment',
Chris@1295 135 :assigned_to_id => 11).save
Chris@1295 136 issue = Issue.first(:order => 'id DESC')
Chris@1295 137 assert_kind_of Group, issue.assigned_to
Chris@1295 138 assert_equal Group.find(11), issue.assigned_to
Chris@1295 139 end
Chris@1295 140 end
Chris@1295 141
Chris@1295 142 def test_create_with_parent_issue_id
Chris@1295 143 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1295 144 :author_id => 1, :subject => 'Group assignment',
Chris@1295 145 :parent_issue_id => 1)
Chris@1295 146 assert_save issue
Chris@1295 147 assert_equal 1, issue.parent_issue_id
Chris@1295 148 assert_equal Issue.find(1), issue.parent
Chris@1295 149 end
Chris@1295 150
Chris@1295 151 def test_create_with_sharp_parent_issue_id
Chris@1295 152 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1295 153 :author_id => 1, :subject => 'Group assignment',
Chris@1295 154 :parent_issue_id => "#1")
Chris@1295 155 assert_save issue
Chris@1295 156 assert_equal 1, issue.parent_issue_id
Chris@1295 157 assert_equal Issue.find(1), issue.parent
Chris@1295 158 end
Chris@1295 159
Chris@1295 160 def test_create_with_invalid_parent_issue_id
Chris@1295 161 set_language_if_valid 'en'
Chris@1295 162 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1295 163 :author_id => 1, :subject => 'Group assignment',
Chris@1295 164 :parent_issue_id => '01ABC')
Chris@1295 165 assert !issue.save
Chris@1295 166 assert_equal '01ABC', issue.parent_issue_id
Chris@1295 167 assert_include 'Parent task is invalid', issue.errors.full_messages
Chris@1295 168 end
Chris@1295 169
Chris@1295 170 def test_create_with_invalid_sharp_parent_issue_id
Chris@1295 171 set_language_if_valid 'en'
Chris@1295 172 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1295 173 :author_id => 1, :subject => 'Group assignment',
Chris@1295 174 :parent_issue_id => '#01ABC')
Chris@1295 175 assert !issue.save
Chris@1295 176 assert_equal '#01ABC', issue.parent_issue_id
Chris@1295 177 assert_include 'Parent task is invalid', issue.errors.full_messages
Chris@1295 178 end
Chris@1295 179
Chris@1295 180 def assert_visibility_match(user, issues)
Chris@1295 181 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
Chris@1295 182 end
Chris@1295 183
Chris@1295 184 def test_visible_scope_for_anonymous
Chris@1295 185 # Anonymous user should see issues of public projects only
Chris@1295 186 issues = Issue.visible(User.anonymous).all
Chris@1295 187 assert issues.any?
Chris@1295 188 assert_nil issues.detect {|issue| !issue.project.is_public?}
Chris@1295 189 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1295 190 assert_visibility_match User.anonymous, issues
Chris@1295 191 end
Chris@1295 192
Chris@1295 193 def test_visible_scope_for_anonymous_without_view_issues_permissions
Chris@1295 194 # Anonymous user should not see issues without permission
Chris@1295 195 Role.anonymous.remove_permission!(:view_issues)
Chris@1295 196 issues = Issue.visible(User.anonymous).all
Chris@1295 197 assert issues.empty?
Chris@1295 198 assert_visibility_match User.anonymous, issues
Chris@1295 199 end
Chris@1295 200
Chris@1295 201 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
Chris@1295 202 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
Chris@1295 203 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
Chris@1295 204 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
Chris@1295 205 assert !issue.visible?(User.anonymous)
Chris@1295 206 end
Chris@1295 207
Chris@1295 208 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
Chris@1295 209 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
Chris@1295 210 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
Chris@1295 211 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
Chris@1295 212 assert !issue.visible?(User.anonymous)
Chris@1295 213 end
Chris@1295 214
Chris@1295 215 def test_visible_scope_for_non_member
Chris@1295 216 user = User.find(9)
Chris@1295 217 assert user.projects.empty?
Chris@1295 218 # Non member user should see issues of public projects only
Chris@1295 219 issues = Issue.visible(user).all
Chris@1295 220 assert issues.any?
Chris@1295 221 assert_nil issues.detect {|issue| !issue.project.is_public?}
Chris@1295 222 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1295 223 assert_visibility_match user, issues
Chris@1295 224 end
Chris@1295 225
Chris@1295 226 def test_visible_scope_for_non_member_with_own_issues_visibility
Chris@1295 227 Role.non_member.update_attribute :issues_visibility, 'own'
Chris@1295 228 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
Chris@1295 229 user = User.find(9)
Chris@1295 230
Chris@1295 231 issues = Issue.visible(user).all
Chris@1295 232 assert issues.any?
Chris@1295 233 assert_nil issues.detect {|issue| issue.author != user}
Chris@1295 234 assert_visibility_match user, issues
Chris@1295 235 end
Chris@1295 236
Chris@1295 237 def test_visible_scope_for_non_member_without_view_issues_permissions
Chris@1295 238 # Non member user should not see issues without permission
Chris@1295 239 Role.non_member.remove_permission!(:view_issues)
Chris@1295 240 user = User.find(9)
Chris@1295 241 assert user.projects.empty?
Chris@1295 242 issues = Issue.visible(user).all
Chris@1295 243 assert issues.empty?
Chris@1295 244 assert_visibility_match user, issues
Chris@1295 245 end
Chris@1295 246
Chris@1295 247 def test_visible_scope_for_member
Chris@1295 248 user = User.find(9)
Chris@1295 249 # User should see issues of projects for which he has view_issues permissions only
Chris@1295 250 Role.non_member.remove_permission!(:view_issues)
Chris@1295 251 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
Chris@1295 252 issues = Issue.visible(user).all
Chris@1295 253 assert issues.any?
Chris@1295 254 assert_nil issues.detect {|issue| issue.project_id != 3}
Chris@1295 255 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1295 256 assert_visibility_match user, issues
Chris@1295 257 end
Chris@1295 258
Chris@1295 259 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
Chris@1295 260 user = User.find(8)
Chris@1295 261 assert user.groups.any?
Chris@1295 262 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
Chris@1295 263 Role.non_member.remove_permission!(:view_issues)
Chris@1295 264
Chris@1295 265 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1295 266 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1295 267 :subject => 'Assignment test',
Chris@1295 268 :assigned_to => user.groups.first,
Chris@1295 269 :is_private => true)
Chris@1295 270
Chris@1295 271 Role.find(2).update_attribute :issues_visibility, 'default'
Chris@1295 272 issues = Issue.visible(User.find(8)).all
Chris@1295 273 assert issues.any?
Chris@1295 274 assert issues.include?(issue)
Chris@1295 275
Chris@1295 276 Role.find(2).update_attribute :issues_visibility, 'own'
Chris@1295 277 issues = Issue.visible(User.find(8)).all
Chris@1295 278 assert issues.any?
Chris@1295 279 assert issues.include?(issue)
Chris@1295 280 end
Chris@1295 281
Chris@1295 282 def test_visible_scope_for_admin
Chris@1295 283 user = User.find(1)
Chris@1295 284 user.members.each(&:destroy)
Chris@1295 285 assert user.projects.empty?
Chris@1295 286 issues = Issue.visible(user).all
Chris@1295 287 assert issues.any?
Chris@1295 288 # Admin should see issues on private projects that he does not belong to
Chris@1295 289 assert issues.detect {|issue| !issue.project.is_public?}
Chris@1295 290 # Admin should see private issues of other users
Chris@1295 291 assert issues.detect {|issue| issue.is_private? && issue.author != user}
Chris@1295 292 assert_visibility_match user, issues
Chris@1295 293 end
Chris@1295 294
Chris@1295 295 def test_visible_scope_with_project
Chris@1295 296 project = Project.find(1)
Chris@1295 297 issues = Issue.visible(User.find(2), :project => project).all
Chris@1295 298 projects = issues.collect(&:project).uniq
Chris@1295 299 assert_equal 1, projects.size
Chris@1295 300 assert_equal project, projects.first
Chris@1295 301 end
Chris@1295 302
Chris@1295 303 def test_visible_scope_with_project_and_subprojects
Chris@1295 304 project = Project.find(1)
Chris@1295 305 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
Chris@1295 306 projects = issues.collect(&:project).uniq
Chris@1295 307 assert projects.size > 1
Chris@1295 308 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
Chris@1295 309 end
Chris@1295 310
Chris@1295 311 def test_visible_and_nested_set_scopes
Chris@1295 312 assert_equal 0, Issue.find(1).descendants.visible.all.size
Chris@1295 313 end
Chris@1295 314
Chris@1295 315 def test_open_scope
Chris@1295 316 issues = Issue.open.all
Chris@1295 317 assert_nil issues.detect(&:closed?)
Chris@1295 318 end
Chris@1295 319
Chris@1295 320 def test_open_scope_with_arg
Chris@1295 321 issues = Issue.open(false).all
Chris@1295 322 assert_equal issues, issues.select(&:closed?)
Chris@1295 323 end
Chris@1295 324
Chris@1295 325 def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
Chris@1295 326 version = Version.find(2)
Chris@1295 327 assert version.fixed_issues.any?
Chris@1295 328 assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
Chris@1295 329 end
Chris@1295 330
Chris@1295 331 def test_fixed_version_scope_with_empty_array_should_return_no_result
Chris@1295 332 assert_equal 0, Issue.fixed_version([]).count
Chris@1295 333 end
Chris@1295 334
Chris@1295 335 def test_errors_full_messages_should_include_custom_fields_errors
Chris@1295 336 field = IssueCustomField.find_by_name('Database')
Chris@1295 337
Chris@1295 338 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 339 :status_id => 1, :subject => 'test_create',
Chris@1295 340 :description => 'IssueTest#test_create_with_required_custom_field')
Chris@1295 341 assert issue.available_custom_fields.include?(field)
Chris@1295 342 # Invalid value
Chris@1295 343 issue.custom_field_values = { field.id => 'SQLServer' }
Chris@1295 344
Chris@1295 345 assert !issue.valid?
Chris@1295 346 assert_equal 1, issue.errors.full_messages.size
Chris@1295 347 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
Chris@1295 348 issue.errors.full_messages.first
Chris@1295 349 end
Chris@1295 350
Chris@1295 351 def test_update_issue_with_required_custom_field
Chris@1295 352 field = IssueCustomField.find_by_name('Database')
Chris@1295 353 field.update_attribute(:is_required, true)
Chris@1295 354
Chris@1295 355 issue = Issue.find(1)
Chris@1295 356 assert_nil issue.custom_value_for(field)
Chris@1295 357 assert issue.available_custom_fields.include?(field)
Chris@1295 358 # No change to custom values, issue can be saved
Chris@1295 359 assert issue.save
Chris@1295 360 # Blank value
Chris@1295 361 issue.custom_field_values = { field.id => '' }
Chris@1295 362 assert !issue.save
Chris@1295 363 # Valid value
Chris@1295 364 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1295 365 assert issue.save
Chris@1295 366 issue.reload
Chris@1295 367 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
Chris@1295 368 end
Chris@1295 369
Chris@1295 370 def test_should_not_update_attributes_if_custom_fields_validation_fails
Chris@1295 371 issue = Issue.find(1)
Chris@1295 372 field = IssueCustomField.find_by_name('Database')
Chris@1295 373 assert issue.available_custom_fields.include?(field)
Chris@1295 374
Chris@1295 375 issue.custom_field_values = { field.id => 'Invalid' }
Chris@1295 376 issue.subject = 'Should be not be saved'
Chris@1295 377 assert !issue.save
Chris@1295 378
Chris@1295 379 issue.reload
Chris@1295 380 assert_equal "Can't print recipes", issue.subject
Chris@1295 381 end
Chris@1295 382
Chris@1295 383 def test_should_not_recreate_custom_values_objects_on_update
Chris@1295 384 field = IssueCustomField.find_by_name('Database')
Chris@1295 385
Chris@1295 386 issue = Issue.find(1)
Chris@1295 387 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1295 388 assert issue.save
Chris@1295 389 custom_value = issue.custom_value_for(field)
Chris@1295 390 issue.reload
Chris@1295 391 issue.custom_field_values = { field.id => 'MySQL' }
Chris@1295 392 assert issue.save
Chris@1295 393 issue.reload
Chris@1295 394 assert_equal custom_value.id, issue.custom_value_for(field).id
Chris@1295 395 end
Chris@1295 396
Chris@1295 397 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
Chris@1295 398 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 399 :status_id => 1, :subject => 'Test',
Chris@1295 400 :custom_field_values => {'2' => 'Test'})
Chris@1295 401 assert !Tracker.find(2).custom_field_ids.include?(2)
Chris@1295 402
Chris@1295 403 issue = Issue.find(issue.id)
Chris@1295 404 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
Chris@1295 405
Chris@1295 406 issue = Issue.find(issue.id)
Chris@1295 407 custom_value = issue.custom_value_for(2)
Chris@1295 408 assert_not_nil custom_value
Chris@1295 409 assert_equal 'Test', custom_value.value
Chris@1295 410 end
Chris@1295 411
Chris@1295 412 def test_assigning_tracker_id_should_reload_custom_fields_values
Chris@1295 413 issue = Issue.new(:project => Project.find(1))
Chris@1295 414 assert issue.custom_field_values.empty?
Chris@1295 415 issue.tracker_id = 1
Chris@1295 416 assert issue.custom_field_values.any?
Chris@1295 417 end
Chris@1295 418
Chris@1295 419 def test_assigning_attributes_should_assign_project_and_tracker_first
Chris@1295 420 seq = sequence('seq')
Chris@1295 421 issue = Issue.new
Chris@1295 422 issue.expects(:project_id=).in_sequence(seq)
Chris@1295 423 issue.expects(:tracker_id=).in_sequence(seq)
Chris@1295 424 issue.expects(:subject=).in_sequence(seq)
Chris@1295 425 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
Chris@1295 426 end
Chris@1295 427
Chris@1295 428 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
Chris@1295 429 attributes = ActiveSupport::OrderedHash.new
Chris@1295 430 attributes['custom_field_values'] = { '1' => 'MySQL' }
Chris@1295 431 attributes['tracker_id'] = '1'
Chris@1295 432 issue = Issue.new(:project => Project.find(1))
Chris@1295 433 issue.attributes = attributes
Chris@1295 434 assert_equal 'MySQL', issue.custom_field_value(1)
Chris@1295 435 end
Chris@1295 436
Chris@1295 437 def test_reload_should_reload_custom_field_values
Chris@1295 438 issue = Issue.generate!
Chris@1295 439 issue.custom_field_values = {'2' => 'Foo'}
Chris@1295 440 issue.save!
Chris@1295 441
Chris@1295 442 issue = Issue.order('id desc').first
Chris@1295 443 assert_equal 'Foo', issue.custom_field_value(2)
Chris@1295 444
Chris@1295 445 issue.custom_field_values = {'2' => 'Bar'}
Chris@1295 446 assert_equal 'Bar', issue.custom_field_value(2)
Chris@1295 447
Chris@1295 448 issue.reload
Chris@1295 449 assert_equal 'Foo', issue.custom_field_value(2)
Chris@1295 450 end
Chris@1295 451
Chris@1295 452 def test_should_update_issue_with_disabled_tracker
Chris@1295 453 p = Project.find(1)
Chris@1295 454 issue = Issue.find(1)
Chris@1295 455
Chris@1295 456 p.trackers.delete(issue.tracker)
Chris@1295 457 assert !p.trackers.include?(issue.tracker)
Chris@1295 458
Chris@1295 459 issue.reload
Chris@1295 460 issue.subject = 'New subject'
Chris@1295 461 assert issue.save
Chris@1295 462 end
Chris@1295 463
Chris@1295 464 def test_should_not_set_a_disabled_tracker
Chris@1295 465 p = Project.find(1)
Chris@1295 466 p.trackers.delete(Tracker.find(2))
Chris@1295 467
Chris@1295 468 issue = Issue.find(1)
Chris@1295 469 issue.tracker_id = 2
Chris@1295 470 issue.subject = 'New subject'
Chris@1295 471 assert !issue.save
Chris@1295 472 assert_not_nil issue.errors[:tracker_id]
Chris@1295 473 end
Chris@1295 474
Chris@1295 475 def test_category_based_assignment
Chris@1295 476 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1295 477 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1295 478 :subject => 'Assignment test',
Chris@1295 479 :description => 'Assignment test', :category_id => 1)
Chris@1295 480 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
Chris@1295 481 end
Chris@1295 482
Chris@1295 483 def test_new_statuses_allowed_to
Chris@1295 484 WorkflowTransition.delete_all
Chris@1295 485 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1295 486 :old_status_id => 1, :new_status_id => 2,
Chris@1295 487 :author => false, :assignee => false)
Chris@1295 488 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1295 489 :old_status_id => 1, :new_status_id => 3,
Chris@1295 490 :author => true, :assignee => false)
Chris@1295 491 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
Chris@1295 492 :new_status_id => 4, :author => false,
Chris@1295 493 :assignee => true)
Chris@1295 494 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1295 495 :old_status_id => 1, :new_status_id => 5,
Chris@1295 496 :author => true, :assignee => true)
Chris@1295 497 status = IssueStatus.find(1)
Chris@1295 498 role = Role.find(1)
Chris@1295 499 tracker = Tracker.find(1)
Chris@1295 500 user = User.find(2)
Chris@1295 501
Chris@1295 502 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1295 503 :project_id => 1, :author_id => 1)
Chris@1295 504 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1295 505
Chris@1295 506 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1295 507 :project_id => 1, :author => user)
Chris@1295 508 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1295 509
Chris@1295 510 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1295 511 :project_id => 1, :author_id => 1,
Chris@1295 512 :assigned_to => user)
Chris@1295 513 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1295 514
Chris@1295 515 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1295 516 :project_id => 1, :author => user,
Chris@1295 517 :assigned_to => user)
Chris@1295 518 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1295 519 end
Chris@1295 520
Chris@1295 521 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
Chris@1295 522 admin = User.find(1)
Chris@1295 523 issue = Issue.find(1)
Chris@1295 524 assert !admin.member_of?(issue.project)
Chris@1295 525 expected_statuses = [issue.status] +
Chris@1295 526 WorkflowTransition.find_all_by_old_status_id(
Chris@1295 527 issue.status_id).map(&:new_status).uniq.sort
Chris@1295 528 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
Chris@1295 529 end
Chris@1295 530
Chris@1295 531 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
Chris@1295 532 issue = Issue.find(1).copy
Chris@1295 533 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
Chris@1295 534
Chris@1295 535 issue = Issue.find(2).copy
Chris@1295 536 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
Chris@1295 537 end
Chris@1295 538
Chris@1295 539 def test_safe_attributes_names_should_not_include_disabled_field
Chris@1295 540 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
Chris@1295 541
Chris@1295 542 issue = Issue.new(:tracker => tracker)
Chris@1295 543 assert_include 'tracker_id', issue.safe_attribute_names
Chris@1295 544 assert_include 'status_id', issue.safe_attribute_names
Chris@1295 545 assert_include 'subject', issue.safe_attribute_names
Chris@1295 546 assert_include 'description', issue.safe_attribute_names
Chris@1295 547 assert_include 'custom_field_values', issue.safe_attribute_names
Chris@1295 548 assert_include 'custom_fields', issue.safe_attribute_names
Chris@1295 549 assert_include 'lock_version', issue.safe_attribute_names
Chris@1295 550
Chris@1295 551 tracker.core_fields.each do |field|
Chris@1295 552 assert_include field, issue.safe_attribute_names
Chris@1295 553 end
Chris@1295 554
Chris@1295 555 tracker.disabled_core_fields.each do |field|
Chris@1295 556 assert_not_include field, issue.safe_attribute_names
Chris@1295 557 end
Chris@1295 558 end
Chris@1295 559
Chris@1295 560 def test_safe_attributes_should_ignore_disabled_fields
Chris@1295 561 tracker = Tracker.find(1)
Chris@1295 562 tracker.core_fields = %w(assigned_to_id due_date)
Chris@1295 563 tracker.save!
Chris@1295 564
Chris@1295 565 issue = Issue.new(:tracker => tracker)
Chris@1295 566 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
Chris@1295 567 assert_nil issue.start_date
Chris@1295 568 assert_equal Date.parse('2012-07-14'), issue.due_date
Chris@1295 569 end
Chris@1295 570
Chris@1295 571 def test_safe_attributes_should_accept_target_tracker_enabled_fields
Chris@1295 572 source = Tracker.find(1)
Chris@1295 573 source.core_fields = []
Chris@1295 574 source.save!
Chris@1295 575 target = Tracker.find(2)
Chris@1295 576 target.core_fields = %w(assigned_to_id due_date)
Chris@1295 577 target.save!
Chris@1295 578
Chris@1295 579 issue = Issue.new(:tracker => source)
Chris@1295 580 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
Chris@1295 581 assert_equal target, issue.tracker
Chris@1295 582 assert_equal Date.parse('2012-07-14'), issue.due_date
Chris@1295 583 end
Chris@1295 584
Chris@1295 585 def test_safe_attributes_should_not_include_readonly_fields
Chris@1295 586 WorkflowPermission.delete_all
Chris@1295 587 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 588 :role_id => 1, :field_name => 'due_date',
Chris@1295 589 :rule => 'readonly')
Chris@1295 590 user = User.find(2)
Chris@1295 591
Chris@1295 592 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1295 593 assert_equal %w(due_date), issue.read_only_attribute_names(user)
Chris@1295 594 assert_not_include 'due_date', issue.safe_attribute_names(user)
Chris@1295 595
Chris@1295 596 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
Chris@1295 597 assert_equal Date.parse('2012-07-14'), issue.start_date
Chris@1295 598 assert_nil issue.due_date
Chris@1295 599 end
Chris@1295 600
Chris@1295 601 def test_safe_attributes_should_not_include_readonly_custom_fields
Chris@1295 602 cf1 = IssueCustomField.create!(:name => 'Writable field',
Chris@1295 603 :field_format => 'string',
Chris@1295 604 :is_for_all => true, :tracker_ids => [1])
Chris@1295 605 cf2 = IssueCustomField.create!(:name => 'Readonly field',
Chris@1295 606 :field_format => 'string',
Chris@1295 607 :is_for_all => true, :tracker_ids => [1])
Chris@1295 608 WorkflowPermission.delete_all
Chris@1295 609 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 610 :role_id => 1, :field_name => cf2.id.to_s,
Chris@1295 611 :rule => 'readonly')
Chris@1295 612 user = User.find(2)
Chris@1295 613 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1295 614 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
Chris@1295 615 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
Chris@1295 616
Chris@1295 617 issue.send :safe_attributes=, {'custom_field_values' => {
Chris@1295 618 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
Chris@1295 619 }}, user
Chris@1295 620 assert_equal 'value1', issue.custom_field_value(cf1)
Chris@1295 621 assert_nil issue.custom_field_value(cf2)
Chris@1295 622
Chris@1295 623 issue.send :safe_attributes=, {'custom_fields' => [
Chris@1295 624 {'id' => cf1.id.to_s, 'value' => 'valuea'},
Chris@1295 625 {'id' => cf2.id.to_s, 'value' => 'valueb'}
Chris@1295 626 ]}, user
Chris@1295 627 assert_equal 'valuea', issue.custom_field_value(cf1)
Chris@1295 628 assert_nil issue.custom_field_value(cf2)
Chris@1295 629 end
Chris@1295 630
Chris@1295 631 def test_editable_custom_field_values_should_return_non_readonly_custom_values
Chris@1295 632 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
Chris@1295 633 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1295 634 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
Chris@1295 635 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1295 636 WorkflowPermission.delete_all
Chris@1295 637 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
Chris@1295 638 :field_name => cf2.id.to_s, :rule => 'readonly')
Chris@1295 639 user = User.find(2)
Chris@1295 640
Chris@1295 641 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1295 642 values = issue.editable_custom_field_values(user)
Chris@1295 643 assert values.detect {|value| value.custom_field == cf1}
Chris@1295 644 assert_nil values.detect {|value| value.custom_field == cf2}
Chris@1295 645
Chris@1295 646 issue.tracker_id = 2
Chris@1295 647 values = issue.editable_custom_field_values(user)
Chris@1295 648 assert values.detect {|value| value.custom_field == cf1}
Chris@1295 649 assert values.detect {|value| value.custom_field == cf2}
Chris@1295 650 end
Chris@1295 651
Chris@1295 652 def test_safe_attributes_should_accept_target_tracker_writable_fields
Chris@1295 653 WorkflowPermission.delete_all
Chris@1295 654 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 655 :role_id => 1, :field_name => 'due_date',
Chris@1295 656 :rule => 'readonly')
Chris@1295 657 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1295 658 :role_id => 1, :field_name => 'start_date',
Chris@1295 659 :rule => 'readonly')
Chris@1295 660 user = User.find(2)
Chris@1295 661
Chris@1295 662 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1295 663
Chris@1295 664 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
Chris@1295 665 'due_date' => '2012-07-14'}, user
Chris@1295 666 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1295 667 assert_nil issue.due_date
Chris@1295 668
Chris@1295 669 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
Chris@1295 670 'due_date' => '2012-07-16',
Chris@1295 671 'tracker_id' => 2}, user
Chris@1295 672 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1295 673 assert_equal Date.parse('2012-07-16'), issue.due_date
Chris@1295 674 end
Chris@1295 675
Chris@1295 676 def test_safe_attributes_should_accept_target_status_writable_fields
Chris@1295 677 WorkflowPermission.delete_all
Chris@1295 678 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 679 :role_id => 1, :field_name => 'due_date',
Chris@1295 680 :rule => 'readonly')
Chris@1295 681 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
Chris@1295 682 :role_id => 1, :field_name => 'start_date',
Chris@1295 683 :rule => 'readonly')
Chris@1295 684 user = User.find(2)
Chris@1295 685
Chris@1295 686 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1295 687
Chris@1295 688 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
Chris@1295 689 'due_date' => '2012-07-14'},
Chris@1295 690 user
Chris@1295 691 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1295 692 assert_nil issue.due_date
Chris@1295 693
Chris@1295 694 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
Chris@1295 695 'due_date' => '2012-07-16',
Chris@1295 696 'status_id' => 2},
Chris@1295 697 user
Chris@1295 698 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1295 699 assert_equal Date.parse('2012-07-16'), issue.due_date
Chris@1295 700 end
Chris@1295 701
Chris@1295 702 def test_required_attributes_should_be_validated
Chris@1295 703 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
Chris@1295 704 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1295 705
Chris@1295 706 WorkflowPermission.delete_all
Chris@1295 707 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 708 :role_id => 1, :field_name => 'due_date',
Chris@1295 709 :rule => 'required')
Chris@1295 710 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 711 :role_id => 1, :field_name => 'category_id',
Chris@1295 712 :rule => 'required')
Chris@1295 713 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 714 :role_id => 1, :field_name => cf.id.to_s,
Chris@1295 715 :rule => 'required')
Chris@1295 716
Chris@1295 717 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1295 718 :role_id => 1, :field_name => 'start_date',
Chris@1295 719 :rule => 'required')
Chris@1295 720 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1295 721 :role_id => 1, :field_name => cf.id.to_s,
Chris@1295 722 :rule => 'required')
Chris@1295 723 user = User.find(2)
Chris@1295 724
Chris@1295 725 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1295 726 :status_id => 1, :subject => 'Required fields',
Chris@1295 727 :author => user)
Chris@1295 728 assert_equal [cf.id.to_s, "category_id", "due_date"],
Chris@1295 729 issue.required_attribute_names(user).sort
Chris@1295 730 assert !issue.save, "Issue was saved"
Chris@1295 731 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
Chris@1295 732 issue.errors.full_messages.sort
Chris@1295 733
Chris@1295 734 issue.tracker_id = 2
Chris@1295 735 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
Chris@1295 736 assert !issue.save, "Issue was saved"
Chris@1295 737 assert_equal ["Foo can't be blank", "Start date can't be blank"],
Chris@1295 738 issue.errors.full_messages.sort
Chris@1295 739
Chris@1295 740 issue.start_date = Date.today
Chris@1295 741 issue.custom_field_values = {cf.id.to_s => 'bar'}
Chris@1295 742 assert issue.save
Chris@1295 743 end
Chris@1295 744
Chris@1295 745 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
Chris@1295 746 WorkflowPermission.delete_all
Chris@1295 747 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 748 :role_id => 1, :field_name => 'due_date',
Chris@1295 749 :rule => 'required')
Chris@1295 750 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 751 :role_id => 1, :field_name => 'start_date',
Chris@1295 752 :rule => 'required')
Chris@1295 753 user = User.find(2)
Chris@1295 754 member = Member.find(1)
Chris@1295 755 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1295 756
Chris@1295 757 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
Chris@1295 758
Chris@1295 759 member.role_ids = [1, 2]
Chris@1295 760 member.save!
Chris@1295 761 assert_equal [], issue.required_attribute_names(user.reload)
Chris@1295 762
Chris@1295 763 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 764 :role_id => 2, :field_name => 'due_date',
Chris@1295 765 :rule => 'required')
Chris@1295 766 assert_equal %w(due_date), issue.required_attribute_names(user)
Chris@1295 767
Chris@1295 768 member.role_ids = [1, 2, 3]
Chris@1295 769 member.save!
Chris@1295 770 assert_equal [], issue.required_attribute_names(user.reload)
Chris@1295 771
Chris@1295 772 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 773 :role_id => 2, :field_name => 'due_date',
Chris@1295 774 :rule => 'readonly')
Chris@1295 775 # required + readonly => required
Chris@1295 776 assert_equal %w(due_date), issue.required_attribute_names(user)
Chris@1295 777 end
Chris@1295 778
Chris@1295 779 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
Chris@1295 780 WorkflowPermission.delete_all
Chris@1295 781 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 782 :role_id => 1, :field_name => 'due_date',
Chris@1295 783 :rule => 'readonly')
Chris@1295 784 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 785 :role_id => 1, :field_name => 'start_date',
Chris@1295 786 :rule => 'readonly')
Chris@1295 787 user = User.find(2)
Chris@1295 788 member = Member.find(1)
Chris@1295 789 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1295 790
Chris@1295 791 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
Chris@1295 792
Chris@1295 793 member.role_ids = [1, 2]
Chris@1295 794 member.save!
Chris@1295 795 assert_equal [], issue.read_only_attribute_names(user.reload)
Chris@1295 796
Chris@1295 797 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 798 :role_id => 2, :field_name => 'due_date',
Chris@1295 799 :rule => 'readonly')
Chris@1295 800 assert_equal %w(due_date), issue.read_only_attribute_names(user)
Chris@1295 801 end
Chris@1295 802
Chris@1295 803 def test_copy
Chris@1295 804 issue = Issue.new.copy_from(1)
Chris@1295 805 assert issue.copy?
Chris@1295 806 assert issue.save
Chris@1295 807 issue.reload
Chris@1295 808 orig = Issue.find(1)
Chris@1295 809 assert_equal orig.subject, issue.subject
Chris@1295 810 assert_equal orig.tracker, issue.tracker
Chris@1295 811 assert_equal "125", issue.custom_value_for(2).value
Chris@1295 812 end
Chris@1295 813
Chris@1295 814 def test_copy_should_copy_status
Chris@1295 815 orig = Issue.find(8)
Chris@1295 816 assert orig.status != IssueStatus.default
Chris@1295 817
Chris@1295 818 issue = Issue.new.copy_from(orig)
Chris@1295 819 assert issue.save
Chris@1295 820 issue.reload
Chris@1295 821 assert_equal orig.status, issue.status
Chris@1295 822 end
Chris@1295 823
Chris@1295 824 def test_copy_should_add_relation_with_copied_issue
Chris@1295 825 copied = Issue.find(1)
Chris@1295 826 issue = Issue.new.copy_from(copied)
Chris@1295 827 assert issue.save
Chris@1295 828 issue.reload
Chris@1295 829
Chris@1295 830 assert_equal 1, issue.relations.size
Chris@1295 831 relation = issue.relations.first
Chris@1295 832 assert_equal 'copied_to', relation.relation_type
Chris@1295 833 assert_equal copied, relation.issue_from
Chris@1295 834 assert_equal issue, relation.issue_to
Chris@1295 835 end
Chris@1295 836
Chris@1295 837 def test_copy_should_copy_subtasks
Chris@1295 838 issue = Issue.generate_with_descendants!
Chris@1295 839
Chris@1295 840 copy = issue.reload.copy
Chris@1295 841 copy.author = User.find(7)
Chris@1295 842 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1295 843 assert copy.save
Chris@1295 844 end
Chris@1295 845 copy.reload
Chris@1295 846 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
Chris@1295 847 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
Chris@1295 848 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
Chris@1295 849 assert_equal copy.author, child_copy.author
Chris@1295 850 end
Chris@1295 851
Chris@1295 852 def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
Chris@1295 853 parent = Issue.generate!
Chris@1295 854 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
Chris@1295 855 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
Chris@1295 856
Chris@1295 857 copy = parent.reload.copy
Chris@1295 858 copy.parent_issue_id = parent.id
Chris@1295 859 copy.author = User.find(7)
Chris@1295 860 assert_difference 'Issue.count', 3 do
Chris@1295 861 assert copy.save
Chris@1295 862 end
Chris@1295 863 parent.reload
Chris@1295 864 copy.reload
Chris@1295 865 assert_equal parent, copy.parent
Chris@1295 866 assert_equal 3, parent.children.count
Chris@1295 867 assert_equal 5, parent.descendants.count
Chris@1295 868 assert_equal 2, copy.children.count
Chris@1295 869 assert_equal 2, copy.descendants.count
Chris@1295 870 end
Chris@1295 871
Chris@1295 872 def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
Chris@1295 873 parent = Issue.generate!
Chris@1295 874 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
Chris@1295 875 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
Chris@1295 876
Chris@1295 877 copy = parent.reload.copy
Chris@1295 878 copy.parent_issue_id = child1.id
Chris@1295 879 copy.author = User.find(7)
Chris@1295 880 assert_difference 'Issue.count', 3 do
Chris@1295 881 assert copy.save
Chris@1295 882 end
Chris@1295 883 parent.reload
Chris@1295 884 child1.reload
Chris@1295 885 copy.reload
Chris@1295 886 assert_equal child1, copy.parent
Chris@1295 887 assert_equal 2, parent.children.count
Chris@1295 888 assert_equal 5, parent.descendants.count
Chris@1295 889 assert_equal 1, child1.children.count
Chris@1295 890 assert_equal 3, child1.descendants.count
Chris@1295 891 assert_equal 2, copy.children.count
Chris@1295 892 assert_equal 2, copy.descendants.count
Chris@1295 893 end
Chris@1295 894
Chris@1295 895 def test_copy_should_copy_subtasks_to_target_project
Chris@1295 896 issue = Issue.generate_with_descendants!
Chris@1295 897
Chris@1295 898 copy = issue.copy(:project_id => 3)
Chris@1295 899 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1295 900 assert copy.save
Chris@1295 901 end
Chris@1295 902 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
Chris@1295 903 end
Chris@1295 904
Chris@1295 905 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
Chris@1295 906 issue = Issue.generate_with_descendants!
Chris@1295 907
Chris@1295 908 copy = issue.reload.copy
Chris@1295 909 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1295 910 assert copy.save
Chris@1295 911 assert copy.save
Chris@1295 912 end
Chris@1295 913 end
Chris@1295 914
Chris@1295 915 def test_should_not_call_after_project_change_on_creation
Chris@1295 916 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
Chris@1295 917 :subject => 'Test', :author_id => 1)
Chris@1295 918 issue.expects(:after_project_change).never
Chris@1295 919 issue.save!
Chris@1295 920 end
Chris@1295 921
Chris@1295 922 def test_should_not_call_after_project_change_on_update
Chris@1295 923 issue = Issue.find(1)
Chris@1295 924 issue.project = Project.find(1)
Chris@1295 925 issue.subject = 'No project change'
Chris@1295 926 issue.expects(:after_project_change).never
Chris@1295 927 issue.save!
Chris@1295 928 end
Chris@1295 929
Chris@1295 930 def test_should_call_after_project_change_on_project_change
Chris@1295 931 issue = Issue.find(1)
Chris@1295 932 issue.project = Project.find(2)
Chris@1295 933 issue.expects(:after_project_change).once
Chris@1295 934 issue.save!
Chris@1295 935 end
Chris@1295 936
Chris@1295 937 def test_adding_journal_should_update_timestamp
Chris@1295 938 issue = Issue.find(1)
Chris@1295 939 updated_on_was = issue.updated_on
Chris@1295 940
Chris@1295 941 issue.init_journal(User.first, "Adding notes")
Chris@1295 942 assert_difference 'Journal.count' do
Chris@1295 943 assert issue.save
Chris@1295 944 end
Chris@1295 945 issue.reload
Chris@1295 946
Chris@1295 947 assert_not_equal updated_on_was, issue.updated_on
Chris@1295 948 end
Chris@1295 949
Chris@1295 950 def test_should_close_duplicates
Chris@1295 951 # Create 3 issues
Chris@1295 952 issue1 = Issue.generate!
Chris@1295 953 issue2 = Issue.generate!
Chris@1295 954 issue3 = Issue.generate!
Chris@1295 955
Chris@1295 956 # 2 is a dupe of 1
Chris@1295 957 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
Chris@1295 958 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1295 959 # And 3 is a dupe of 2
Chris@1295 960 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
Chris@1295 961 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1295 962 # And 3 is a dupe of 1 (circular duplicates)
Chris@1295 963 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
Chris@1295 964 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1295 965
Chris@1295 966 assert issue1.reload.duplicates.include?(issue2)
Chris@1295 967
Chris@1295 968 # Closing issue 1
Chris@1295 969 issue1.init_journal(User.first, "Closing issue1")
Chris@1295 970 issue1.status = IssueStatus.where(:is_closed => true).first
Chris@1295 971 assert issue1.save
Chris@1295 972 # 2 and 3 should be also closed
Chris@1295 973 assert issue2.reload.closed?
Chris@1295 974 assert issue3.reload.closed?
Chris@1295 975 end
Chris@1295 976
Chris@1295 977 def test_should_not_close_duplicated_issue
Chris@1295 978 issue1 = Issue.generate!
Chris@1295 979 issue2 = Issue.generate!
Chris@1295 980
Chris@1295 981 # 2 is a dupe of 1
Chris@1295 982 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
Chris@1295 983 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1295 984 # 2 is a dup of 1 but 1 is not a duplicate of 2
Chris@1295 985 assert !issue2.reload.duplicates.include?(issue1)
Chris@1295 986
Chris@1295 987 # Closing issue 2
Chris@1295 988 issue2.init_journal(User.first, "Closing issue2")
Chris@1295 989 issue2.status = IssueStatus.where(:is_closed => true).first
Chris@1295 990 assert issue2.save
Chris@1295 991 # 1 should not be also closed
Chris@1295 992 assert !issue1.reload.closed?
Chris@1295 993 end
Chris@1295 994
Chris@1295 995 def test_assignable_versions
Chris@1295 996 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 997 :status_id => 1, :fixed_version_id => 1,
Chris@1295 998 :subject => 'New issue')
Chris@1295 999 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
Chris@1295 1000 end
Chris@1295 1001
Chris@1295 1002 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
Chris@1295 1003 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 1004 :status_id => 1, :fixed_version_id => 1,
Chris@1295 1005 :subject => 'New issue')
Chris@1295 1006 assert !issue.save
Chris@1295 1007 assert_not_nil issue.errors[:fixed_version_id]
Chris@1295 1008 end
Chris@1295 1009
Chris@1295 1010 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
Chris@1295 1011 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 1012 :status_id => 1, :fixed_version_id => 2,
Chris@1295 1013 :subject => 'New issue')
Chris@1295 1014 assert !issue.save
Chris@1295 1015 assert_not_nil issue.errors[:fixed_version_id]
Chris@1295 1016 end
Chris@1295 1017
Chris@1295 1018 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
Chris@1295 1019 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 1020 :status_id => 1, :fixed_version_id => 3,
Chris@1295 1021 :subject => 'New issue')
Chris@1295 1022 assert issue.save
Chris@1295 1023 end
Chris@1295 1024
Chris@1295 1025 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
Chris@1295 1026 issue = Issue.find(11)
Chris@1295 1027 assert_equal 'closed', issue.fixed_version.status
Chris@1295 1028 issue.subject = 'Subject changed'
Chris@1295 1029 assert issue.save
Chris@1295 1030 end
Chris@1295 1031
Chris@1295 1032 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
Chris@1295 1033 issue = Issue.find(11)
Chris@1295 1034 issue.status_id = 1
Chris@1295 1035 assert !issue.save
Chris@1295 1036 assert_not_nil issue.errors[:base]
Chris@1295 1037 end
Chris@1295 1038
Chris@1295 1039 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
Chris@1295 1040 issue = Issue.find(11)
Chris@1295 1041 issue.status_id = 1
Chris@1295 1042 issue.fixed_version_id = 3
Chris@1295 1043 assert issue.save
Chris@1295 1044 end
Chris@1295 1045
Chris@1295 1046 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
Chris@1295 1047 issue = Issue.find(12)
Chris@1295 1048 assert_equal 'locked', issue.fixed_version.status
Chris@1295 1049 issue.status_id = 1
Chris@1295 1050 assert issue.save
Chris@1295 1051 end
Chris@1295 1052
Chris@1295 1053 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
Chris@1295 1054 issue = Issue.find(2)
Chris@1295 1055 assert_equal 2, issue.fixed_version_id
Chris@1295 1056 issue.project_id = 3
Chris@1295 1057 assert_nil issue.fixed_version_id
Chris@1295 1058 issue.fixed_version_id = 2
Chris@1295 1059 assert !issue.save
Chris@1295 1060 assert_include 'Target version is not included in the list', issue.errors.full_messages
Chris@1295 1061 end
Chris@1295 1062
Chris@1295 1063 def test_should_keep_shared_version_when_changing_project
Chris@1295 1064 Version.find(2).update_attribute :sharing, 'tree'
Chris@1295 1065
Chris@1295 1066 issue = Issue.find(2)
Chris@1295 1067 assert_equal 2, issue.fixed_version_id
Chris@1295 1068 issue.project_id = 3
Chris@1295 1069 assert_equal 2, issue.fixed_version_id
Chris@1295 1070 assert issue.save
Chris@1295 1071 end
Chris@1295 1072
Chris@1295 1073 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
Chris@1295 1074 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
Chris@1295 1075 end
Chris@1295 1076
Chris@1295 1077 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
Chris@1295 1078 Project.find(2).disable_module! :issue_tracking
Chris@1295 1079 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
Chris@1295 1080 end
Chris@1295 1081
Chris@1295 1082 def test_move_to_another_project_with_same_category
Chris@1295 1083 issue = Issue.find(1)
Chris@1295 1084 issue.project = Project.find(2)
Chris@1295 1085 assert issue.save
Chris@1295 1086 issue.reload
Chris@1295 1087 assert_equal 2, issue.project_id
Chris@1295 1088 # Category changes
Chris@1295 1089 assert_equal 4, issue.category_id
Chris@1295 1090 # Make sure time entries were move to the target project
Chris@1295 1091 assert_equal 2, issue.time_entries.first.project_id
Chris@1295 1092 end
Chris@1295 1093
Chris@1295 1094 def test_move_to_another_project_without_same_category
Chris@1295 1095 issue = Issue.find(2)
Chris@1295 1096 issue.project = Project.find(2)
Chris@1295 1097 assert issue.save
Chris@1295 1098 issue.reload
Chris@1295 1099 assert_equal 2, issue.project_id
Chris@1295 1100 # Category cleared
Chris@1295 1101 assert_nil issue.category_id
Chris@1295 1102 end
Chris@1295 1103
Chris@1295 1104 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
Chris@1295 1105 issue = Issue.find(1)
Chris@1295 1106 issue.update_attribute(:fixed_version_id, 1)
Chris@1295 1107 issue.project = Project.find(2)
Chris@1295 1108 assert issue.save
Chris@1295 1109 issue.reload
Chris@1295 1110 assert_equal 2, issue.project_id
Chris@1295 1111 # Cleared fixed_version
Chris@1295 1112 assert_equal nil, issue.fixed_version
Chris@1295 1113 end
Chris@1295 1114
Chris@1295 1115 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
Chris@1295 1116 issue = Issue.find(1)
Chris@1295 1117 issue.update_attribute(:fixed_version_id, 4)
Chris@1295 1118 issue.project = Project.find(5)
Chris@1295 1119 assert issue.save
Chris@1295 1120 issue.reload
Chris@1295 1121 assert_equal 5, issue.project_id
Chris@1295 1122 # Keep fixed_version
Chris@1295 1123 assert_equal 4, issue.fixed_version_id
Chris@1295 1124 end
Chris@1295 1125
Chris@1295 1126 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
Chris@1295 1127 issue = Issue.find(1)
Chris@1295 1128 issue.update_attribute(:fixed_version_id, 1)
Chris@1295 1129 issue.project = Project.find(5)
Chris@1295 1130 assert issue.save
Chris@1295 1131 issue.reload
Chris@1295 1132 assert_equal 5, issue.project_id
Chris@1295 1133 # Cleared fixed_version
Chris@1295 1134 assert_equal nil, issue.fixed_version
Chris@1295 1135 end
Chris@1295 1136
Chris@1295 1137 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
Chris@1295 1138 issue = Issue.find(1)
Chris@1295 1139 issue.update_attribute(:fixed_version_id, 7)
Chris@1295 1140 issue.project = Project.find(2)
Chris@1295 1141 assert issue.save
Chris@1295 1142 issue.reload
Chris@1295 1143 assert_equal 2, issue.project_id
Chris@1295 1144 # Keep fixed_version
Chris@1295 1145 assert_equal 7, issue.fixed_version_id
Chris@1295 1146 end
Chris@1295 1147
Chris@1295 1148 def test_move_to_another_project_should_keep_parent_if_valid
Chris@1295 1149 issue = Issue.find(1)
Chris@1295 1150 issue.update_attribute(:parent_issue_id, 2)
Chris@1295 1151 issue.project = Project.find(3)
Chris@1295 1152 assert issue.save
Chris@1295 1153 issue.reload
Chris@1295 1154 assert_equal 2, issue.parent_id
Chris@1295 1155 end
Chris@1295 1156
Chris@1295 1157 def test_move_to_another_project_should_clear_parent_if_not_valid
Chris@1295 1158 issue = Issue.find(1)
Chris@1295 1159 issue.update_attribute(:parent_issue_id, 2)
Chris@1295 1160 issue.project = Project.find(2)
Chris@1295 1161 assert issue.save
Chris@1295 1162 issue.reload
Chris@1295 1163 assert_nil issue.parent_id
Chris@1295 1164 end
Chris@1295 1165
Chris@1295 1166 def test_move_to_another_project_with_disabled_tracker
Chris@1295 1167 issue = Issue.find(1)
Chris@1295 1168 target = Project.find(2)
Chris@1295 1169 target.tracker_ids = [3]
Chris@1295 1170 target.save
Chris@1295 1171 issue.project = target
Chris@1295 1172 assert issue.save
Chris@1295 1173 issue.reload
Chris@1295 1174 assert_equal 2, issue.project_id
Chris@1295 1175 assert_equal 3, issue.tracker_id
Chris@1295 1176 end
Chris@1295 1177
Chris@1295 1178 def test_copy_to_the_same_project
Chris@1295 1179 issue = Issue.find(1)
Chris@1295 1180 copy = issue.copy
Chris@1295 1181 assert_difference 'Issue.count' do
Chris@1295 1182 copy.save!
Chris@1295 1183 end
Chris@1295 1184 assert_kind_of Issue, copy
Chris@1295 1185 assert_equal issue.project, copy.project
Chris@1295 1186 assert_equal "125", copy.custom_value_for(2).value
Chris@1295 1187 end
Chris@1295 1188
Chris@1295 1189 def test_copy_to_another_project_and_tracker
Chris@1295 1190 issue = Issue.find(1)
Chris@1295 1191 copy = issue.copy(:project_id => 3, :tracker_id => 2)
Chris@1295 1192 assert_difference 'Issue.count' do
Chris@1295 1193 copy.save!
Chris@1295 1194 end
Chris@1295 1195 copy.reload
Chris@1295 1196 assert_kind_of Issue, copy
Chris@1295 1197 assert_equal Project.find(3), copy.project
Chris@1295 1198 assert_equal Tracker.find(2), copy.tracker
Chris@1295 1199 # Custom field #2 is not associated with target tracker
Chris@1295 1200 assert_nil copy.custom_value_for(2)
Chris@1295 1201 end
Chris@1295 1202
Chris@1295 1203 test "#copy should not create a journal" do
Chris@1295 1204 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
Chris@1295 1205 copy.save!
Chris@1295 1206 assert_equal 0, copy.reload.journals.size
Chris@1295 1207 end
Chris@1295 1208
Chris@1295 1209 test "#copy should allow assigned_to changes" do
Chris@1295 1210 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
Chris@1295 1211 assert_equal 3, copy.assigned_to_id
Chris@1295 1212 end
Chris@1295 1213
Chris@1295 1214 test "#copy should allow status changes" do
Chris@1295 1215 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
Chris@1295 1216 assert_equal 2, copy.status_id
Chris@1295 1217 end
Chris@1295 1218
Chris@1295 1219 test "#copy should allow start date changes" do
Chris@1295 1220 date = Date.today
Chris@1295 1221 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
Chris@1295 1222 assert_equal date, copy.start_date
Chris@1295 1223 end
Chris@1295 1224
Chris@1295 1225 test "#copy should allow due date changes" do
Chris@1295 1226 date = Date.today
Chris@1295 1227 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
Chris@1295 1228 assert_equal date, copy.due_date
Chris@1295 1229 end
Chris@1295 1230
Chris@1295 1231 test "#copy should set current user as author" do
Chris@1295 1232 User.current = User.find(9)
Chris@1295 1233 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
Chris@1295 1234 assert_equal User.current, copy.author
Chris@1295 1235 end
Chris@1295 1236
Chris@1295 1237 test "#copy should create a journal with notes" do
Chris@1295 1238 date = Date.today
Chris@1295 1239 notes = "Notes added when copying"
Chris@1295 1240 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
Chris@1295 1241 copy.init_journal(User.current, notes)
Chris@1295 1242 copy.save!
Chris@1295 1243
Chris@1295 1244 assert_equal 1, copy.journals.size
Chris@1295 1245 journal = copy.journals.first
Chris@1295 1246 assert_equal 0, journal.details.size
Chris@1295 1247 assert_equal notes, journal.notes
Chris@1295 1248 end
Chris@1295 1249
Chris@1295 1250 def test_valid_parent_project
Chris@1295 1251 issue = Issue.find(1)
Chris@1295 1252 issue_in_same_project = Issue.find(2)
Chris@1295 1253 issue_in_child_project = Issue.find(5)
Chris@1295 1254 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
Chris@1295 1255 issue_in_other_child_project = Issue.find(6)
Chris@1295 1256 issue_in_different_tree = Issue.find(4)
Chris@1295 1257
Chris@1295 1258 with_settings :cross_project_subtasks => '' do
Chris@1295 1259 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1295 1260 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
Chris@1295 1261 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1295 1262 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1295 1263 end
Chris@1295 1264
Chris@1295 1265 with_settings :cross_project_subtasks => 'system' do
Chris@1295 1266 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1295 1267 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
Chris@1295 1268 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
Chris@1295 1269 end
Chris@1295 1270
Chris@1295 1271 with_settings :cross_project_subtasks => 'tree' do
Chris@1295 1272 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1295 1273 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
Chris@1295 1274 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1295 1275 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1295 1276
Chris@1295 1277 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
Chris@1295 1278 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
Chris@1295 1279 end
Chris@1295 1280
Chris@1295 1281 with_settings :cross_project_subtasks => 'descendants' do
Chris@1295 1282 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1295 1283 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
Chris@1295 1284 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1295 1285 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1295 1286
Chris@1295 1287 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
Chris@1295 1288 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
Chris@1295 1289 end
Chris@1295 1290 end
Chris@1295 1291
Chris@1295 1292 def test_recipients_should_include_previous_assignee
Chris@1295 1293 user = User.find(3)
Chris@1295 1294 user.members.update_all ["mail_notification = ?", false]
Chris@1295 1295 user.update_attribute :mail_notification, 'only_assigned'
Chris@1295 1296
Chris@1295 1297 issue = Issue.find(2)
Chris@1295 1298 issue.assigned_to = nil
Chris@1295 1299 assert_include user.mail, issue.recipients
Chris@1295 1300 issue.save!
Chris@1295 1301 assert !issue.recipients.include?(user.mail)
Chris@1295 1302 end
Chris@1295 1303
Chris@1295 1304 def test_recipients_should_not_include_users_that_cannot_view_the_issue
Chris@1295 1305 issue = Issue.find(12)
Chris@1295 1306 assert issue.recipients.include?(issue.author.mail)
Chris@1295 1307 # copy the issue to a private project
Chris@1295 1308 copy = issue.copy(:project_id => 5, :tracker_id => 2)
Chris@1295 1309 # author is not a member of project anymore
Chris@1295 1310 assert !copy.recipients.include?(copy.author.mail)
Chris@1295 1311 end
Chris@1295 1312
Chris@1295 1313 def test_recipients_should_include_the_assigned_group_members
Chris@1295 1314 group_member = User.generate!
Chris@1295 1315 group = Group.generate!
Chris@1295 1316 group.users << group_member
Chris@1295 1317
Chris@1295 1318 issue = Issue.find(12)
Chris@1295 1319 issue.assigned_to = group
Chris@1295 1320 assert issue.recipients.include?(group_member.mail)
Chris@1295 1321 end
Chris@1295 1322
Chris@1295 1323 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
Chris@1295 1324 user = User.find(3)
Chris@1295 1325 issue = Issue.find(9)
Chris@1295 1326 Watcher.create!(:user => user, :watchable => issue)
Chris@1295 1327 assert issue.watched_by?(user)
Chris@1295 1328 assert !issue.watcher_recipients.include?(user.mail)
Chris@1295 1329 end
Chris@1295 1330
Chris@1295 1331 def test_issue_destroy
Chris@1295 1332 Issue.find(1).destroy
Chris@1295 1333 assert_nil Issue.find_by_id(1)
Chris@1295 1334 assert_nil TimeEntry.find_by_issue_id(1)
Chris@1295 1335 end
Chris@1295 1336
Chris@1295 1337 def test_destroying_a_deleted_issue_should_not_raise_an_error
Chris@1295 1338 issue = Issue.find(1)
Chris@1295 1339 Issue.find(1).destroy
Chris@1295 1340
Chris@1295 1341 assert_nothing_raised do
Chris@1295 1342 assert_no_difference 'Issue.count' do
Chris@1295 1343 issue.destroy
Chris@1295 1344 end
Chris@1295 1345 assert issue.destroyed?
Chris@1295 1346 end
Chris@1295 1347 end
Chris@1295 1348
Chris@1295 1349 def test_destroying_a_stale_issue_should_not_raise_an_error
Chris@1295 1350 issue = Issue.find(1)
Chris@1295 1351 Issue.find(1).update_attribute :subject, "Updated"
Chris@1295 1352
Chris@1295 1353 assert_nothing_raised do
Chris@1295 1354 assert_difference 'Issue.count', -1 do
Chris@1295 1355 issue.destroy
Chris@1295 1356 end
Chris@1295 1357 assert issue.destroyed?
Chris@1295 1358 end
Chris@1295 1359 end
Chris@1295 1360
Chris@1295 1361 def test_blocked
Chris@1295 1362 blocked_issue = Issue.find(9)
Chris@1295 1363 blocking_issue = Issue.find(10)
Chris@1295 1364
Chris@1295 1365 assert blocked_issue.blocked?
Chris@1295 1366 assert !blocking_issue.blocked?
Chris@1295 1367 end
Chris@1295 1368
Chris@1295 1369 def test_blocked_issues_dont_allow_closed_statuses
Chris@1295 1370 blocked_issue = Issue.find(9)
Chris@1295 1371
Chris@1295 1372 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
Chris@1295 1373 assert !allowed_statuses.empty?
Chris@1295 1374 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
Chris@1295 1375 assert closed_statuses.empty?
Chris@1295 1376 end
Chris@1295 1377
Chris@1295 1378 def test_unblocked_issues_allow_closed_statuses
Chris@1295 1379 blocking_issue = Issue.find(10)
Chris@1295 1380
Chris@1295 1381 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
Chris@1295 1382 assert !allowed_statuses.empty?
Chris@1295 1383 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
Chris@1295 1384 assert !closed_statuses.empty?
Chris@1295 1385 end
Chris@1295 1386
Chris@1295 1387 def test_reschedule_an_issue_without_dates
Chris@1295 1388 with_settings :non_working_week_days => [] do
Chris@1295 1389 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1295 1390 issue.reschedule_on '2012-10-09'.to_date
Chris@1295 1391 assert_equal '2012-10-09'.to_date, issue.start_date
Chris@1295 1392 assert_equal '2012-10-09'.to_date, issue.due_date
Chris@1295 1393 end
Chris@1295 1394
Chris@1295 1395 with_settings :non_working_week_days => %w(6 7) do
Chris@1295 1396 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1295 1397 issue.reschedule_on '2012-10-09'.to_date
Chris@1295 1398 assert_equal '2012-10-09'.to_date, issue.start_date
Chris@1295 1399 assert_equal '2012-10-09'.to_date, issue.due_date
Chris@1295 1400
Chris@1295 1401 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1295 1402 issue.reschedule_on '2012-10-13'.to_date
Chris@1295 1403 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1295 1404 assert_equal '2012-10-15'.to_date, issue.due_date
Chris@1295 1405 end
Chris@1295 1406 end
Chris@1295 1407
Chris@1295 1408 def test_reschedule_an_issue_with_start_date
Chris@1295 1409 with_settings :non_working_week_days => [] do
Chris@1295 1410 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1295 1411 issue.reschedule_on '2012-10-13'.to_date
Chris@1295 1412 assert_equal '2012-10-13'.to_date, issue.start_date
Chris@1295 1413 assert_equal '2012-10-13'.to_date, issue.due_date
Chris@1295 1414 end
Chris@1295 1415
Chris@1295 1416 with_settings :non_working_week_days => %w(6 7) do
Chris@1295 1417 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1295 1418 issue.reschedule_on '2012-10-11'.to_date
Chris@1295 1419 assert_equal '2012-10-11'.to_date, issue.start_date
Chris@1295 1420 assert_equal '2012-10-11'.to_date, issue.due_date
Chris@1295 1421
Chris@1295 1422 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1295 1423 issue.reschedule_on '2012-10-13'.to_date
Chris@1295 1424 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1295 1425 assert_equal '2012-10-15'.to_date, issue.due_date
Chris@1295 1426 end
Chris@1295 1427 end
Chris@1295 1428
Chris@1295 1429 def test_reschedule_an_issue_with_start_and_due_dates
Chris@1295 1430 with_settings :non_working_week_days => [] do
Chris@1295 1431 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
Chris@1295 1432 issue.reschedule_on '2012-10-13'.to_date
Chris@1295 1433 assert_equal '2012-10-13'.to_date, issue.start_date
Chris@1295 1434 assert_equal '2012-10-19'.to_date, issue.due_date
Chris@1295 1435 end
Chris@1295 1436
Chris@1295 1437 with_settings :non_working_week_days => %w(6 7) do
Chris@1295 1438 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
Chris@1295 1439 issue.reschedule_on '2012-10-11'.to_date
Chris@1295 1440 assert_equal '2012-10-11'.to_date, issue.start_date
Chris@1295 1441 assert_equal '2012-10-23'.to_date, issue.due_date
Chris@1295 1442
Chris@1295 1443 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
Chris@1295 1444 issue.reschedule_on '2012-10-13'.to_date
Chris@1295 1445 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1295 1446 assert_equal '2012-10-25'.to_date, issue.due_date
Chris@1295 1447 end
Chris@1295 1448 end
Chris@1295 1449
Chris@1295 1450 def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
Chris@1295 1451 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1452 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1453 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1295 1454 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1455 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1295 1456
Chris@1295 1457 issue1.due_date = '2012-10-23'
Chris@1295 1458 issue1.save!
Chris@1295 1459 issue2.reload
Chris@1295 1460 assert_equal Date.parse('2012-10-24'), issue2.start_date
Chris@1295 1461 assert_equal Date.parse('2012-10-26'), issue2.due_date
Chris@1295 1462 end
Chris@1295 1463
Chris@1295 1464 def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
Chris@1295 1465 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1466 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1467 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1295 1468 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1469 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1295 1470
Chris@1295 1471 issue1.start_date = '2012-09-17'
Chris@1295 1472 issue1.due_date = '2012-09-18'
Chris@1295 1473 issue1.save!
Chris@1295 1474 issue2.reload
Chris@1295 1475 assert_equal Date.parse('2012-09-19'), issue2.start_date
Chris@1295 1476 assert_equal Date.parse('2012-09-21'), issue2.due_date
Chris@1295 1477 end
Chris@1295 1478
Chris@1295 1479 def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
Chris@1295 1480 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1481 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1482 issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
Chris@1295 1483 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1295 1484 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1485 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
Chris@1295 1486 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1487 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1295 1488
Chris@1295 1489 issue1.start_date = '2012-09-17'
Chris@1295 1490 issue1.due_date = '2012-09-18'
Chris@1295 1491 issue1.save!
Chris@1295 1492 issue2.reload
Chris@1295 1493 # Issue 2 must start after Issue 3
Chris@1295 1494 assert_equal Date.parse('2012-10-03'), issue2.start_date
Chris@1295 1495 assert_equal Date.parse('2012-10-05'), issue2.due_date
Chris@1295 1496 end
Chris@1295 1497
Chris@1295 1498 def test_rescheduling_a_stale_issue_should_not_raise_an_error
Chris@1295 1499 with_settings :non_working_week_days => [] do
Chris@1295 1500 stale = Issue.find(1)
Chris@1295 1501 issue = Issue.find(1)
Chris@1295 1502 issue.subject = "Updated"
Chris@1295 1503 issue.save!
Chris@1295 1504 date = 10.days.from_now.to_date
Chris@1295 1505 assert_nothing_raised do
Chris@1295 1506 stale.reschedule_on!(date)
Chris@1295 1507 end
Chris@1295 1508 assert_equal date, stale.reload.start_date
Chris@1295 1509 end
Chris@1295 1510 end
Chris@1295 1511
Chris@1295 1512 def test_child_issue_should_consider_parent_soonest_start_on_create
Chris@1295 1513 set_language_if_valid 'en'
Chris@1295 1514 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1515 issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
Chris@1295 1516 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1295 1517 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1518 issue1.reload
Chris@1295 1519 issue2.reload
Chris@1295 1520 assert_equal Date.parse('2012-10-18'), issue2.start_date
Chris@1295 1521
Chris@1295 1522 child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
Chris@1295 1523 :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
Chris@1295 1524 assert !child.valid?
Chris@1295 1525 assert_include 'Start date is invalid', child.errors.full_messages
Chris@1295 1526 assert_equal Date.parse('2012-10-18'), child.soonest_start
Chris@1295 1527 child.start_date = '2012-10-18'
Chris@1295 1528 assert child.save
Chris@1295 1529 end
Chris@1295 1530
Chris@1295 1531 def test_setting_parent_to_a_dependent_issue_should_not_validate
Chris@1295 1532 set_language_if_valid 'en'
Chris@1295 1533 issue1 = Issue.generate!
Chris@1295 1534 issue2 = Issue.generate!
Chris@1295 1535 issue3 = Issue.generate!
Chris@1295 1536 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1537 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1538 issue3.reload
Chris@1295 1539 issue3.parent_issue_id = issue2.id
Chris@1295 1540 assert !issue3.valid?
Chris@1295 1541 assert_include 'Parent task is invalid', issue3.errors.full_messages
Chris@1295 1542 end
Chris@1295 1543
Chris@1295 1544 def test_setting_parent_should_not_allow_circular_dependency
Chris@1295 1545 set_language_if_valid 'en'
Chris@1295 1546 issue1 = Issue.generate!
Chris@1295 1547 issue2 = Issue.generate!
Chris@1295 1548 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1549 issue3 = Issue.generate!
Chris@1295 1550 issue2.reload
Chris@1295 1551 issue2.parent_issue_id = issue3.id
Chris@1295 1552 issue2.save!
Chris@1295 1553 issue4 = Issue.generate!
Chris@1295 1554 IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1555 issue4.reload
Chris@1295 1556 issue4.parent_issue_id = issue1.id
Chris@1295 1557 assert !issue4.valid?
Chris@1295 1558 assert_include 'Parent task is invalid', issue4.errors.full_messages
Chris@1295 1559 end
Chris@1295 1560
Chris@1295 1561 def test_overdue
Chris@1295 1562 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
Chris@1295 1563 assert !Issue.new(:due_date => Date.today).overdue?
Chris@1295 1564 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
Chris@1295 1565 assert !Issue.new(:due_date => nil).overdue?
Chris@1295 1566 assert !Issue.new(:due_date => 1.day.ago.to_date,
Chris@1295 1567 :status => IssueStatus.where(:is_closed => true).first
Chris@1295 1568 ).overdue?
Chris@1295 1569 end
Chris@1295 1570
Chris@1295 1571 test "#behind_schedule? should be false if the issue has no start_date" do
Chris@1295 1572 assert !Issue.new(:start_date => nil,
Chris@1295 1573 :due_date => 1.day.from_now.to_date,
Chris@1295 1574 :done_ratio => 0).behind_schedule?
Chris@1295 1575 end
Chris@1295 1576
Chris@1295 1577 test "#behind_schedule? should be false if the issue has no end_date" do
Chris@1295 1578 assert !Issue.new(:start_date => 1.day.from_now.to_date,
Chris@1295 1579 :due_date => nil,
Chris@1295 1580 :done_ratio => 0).behind_schedule?
Chris@1295 1581 end
Chris@1295 1582
Chris@1295 1583 test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
Chris@1295 1584 assert !Issue.new(:start_date => 50.days.ago.to_date,
Chris@1295 1585 :due_date => 50.days.from_now.to_date,
Chris@1295 1586 :done_ratio => 90).behind_schedule?
Chris@1295 1587 end
Chris@1295 1588
Chris@1295 1589 test "#behind_schedule? should be true if the issue hasn't been started at all" do
Chris@1295 1590 assert Issue.new(:start_date => 1.day.ago.to_date,
Chris@1295 1591 :due_date => 1.day.from_now.to_date,
Chris@1295 1592 :done_ratio => 0).behind_schedule?
Chris@1295 1593 end
Chris@1295 1594
Chris@1295 1595 test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
Chris@1295 1596 assert Issue.new(:start_date => 100.days.ago.to_date,
Chris@1295 1597 :due_date => Date.today,
Chris@1295 1598 :done_ratio => 90).behind_schedule?
Chris@1295 1599 end
Chris@1295 1600
Chris@1295 1601 test "#assignable_users should be Users" do
Chris@1295 1602 assert_kind_of User, Issue.find(1).assignable_users.first
Chris@1295 1603 end
Chris@1295 1604
Chris@1295 1605 test "#assignable_users should include the issue author" do
Chris@1295 1606 non_project_member = User.generate!
Chris@1295 1607 issue = Issue.generate!(:author => non_project_member)
Chris@1295 1608
Chris@1295 1609 assert issue.assignable_users.include?(non_project_member)
Chris@1295 1610 end
Chris@1295 1611
Chris@1295 1612 test "#assignable_users should include the current assignee" do
Chris@1295 1613 user = User.generate!
Chris@1295 1614 issue = Issue.generate!(:assigned_to => user)
Chris@1295 1615 user.lock!
Chris@1295 1616
Chris@1295 1617 assert Issue.find(issue.id).assignable_users.include?(user)
Chris@1295 1618 end
Chris@1295 1619
Chris@1295 1620 test "#assignable_users should not show the issue author twice" do
Chris@1295 1621 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
Chris@1295 1622 assert_equal 2, assignable_user_ids.length
Chris@1295 1623
Chris@1295 1624 assignable_user_ids.each do |user_id|
Chris@1295 1625 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
Chris@1295 1626 "User #{user_id} appears more or less than once"
Chris@1295 1627 end
Chris@1295 1628 end
Chris@1295 1629
Chris@1295 1630 test "#assignable_users with issue_group_assignment should include groups" do
Chris@1295 1631 issue = Issue.new(:project => Project.find(2))
Chris@1295 1632
Chris@1295 1633 with_settings :issue_group_assignment => '1' do
Chris@1295 1634 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
Chris@1295 1635 assert issue.assignable_users.include?(Group.find(11))
Chris@1295 1636 end
Chris@1295 1637 end
Chris@1295 1638
Chris@1295 1639 test "#assignable_users without issue_group_assignment should not include groups" do
Chris@1295 1640 issue = Issue.new(:project => Project.find(2))
Chris@1295 1641
Chris@1295 1642 with_settings :issue_group_assignment => '0' do
Chris@1295 1643 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
Chris@1295 1644 assert !issue.assignable_users.include?(Group.find(11))
Chris@1295 1645 end
Chris@1295 1646 end
Chris@1295 1647
Chris@1295 1648 def test_create_should_send_email_notification
Chris@1295 1649 ActionMailer::Base.deliveries.clear
Chris@1295 1650 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1295 1651 :author_id => 3, :status_id => 1,
Chris@1295 1652 :priority => IssuePriority.all.first,
Chris@1295 1653 :subject => 'test_create', :estimated_hours => '1:30')
Chris@1295 1654
Chris@1295 1655 assert issue.save
Chris@1295 1656 assert_equal 1, ActionMailer::Base.deliveries.size
Chris@1295 1657 end
Chris@1295 1658
Chris@1295 1659 def test_stale_issue_should_not_send_email_notification
Chris@1295 1660 ActionMailer::Base.deliveries.clear
Chris@1295 1661 issue = Issue.find(1)
Chris@1295 1662 stale = Issue.find(1)
Chris@1295 1663
Chris@1295 1664 issue.init_journal(User.find(1))
Chris@1295 1665 issue.subject = 'Subjet update'
Chris@1295 1666 assert issue.save
Chris@1295 1667 assert_equal 1, ActionMailer::Base.deliveries.size
Chris@1295 1668 ActionMailer::Base.deliveries.clear
Chris@1295 1669
Chris@1295 1670 stale.init_journal(User.find(1))
Chris@1295 1671 stale.subject = 'Another subjet update'
Chris@1295 1672 assert_raise ActiveRecord::StaleObjectError do
Chris@1295 1673 stale.save
Chris@1295 1674 end
Chris@1295 1675 assert ActionMailer::Base.deliveries.empty?
Chris@1295 1676 end
Chris@1295 1677
Chris@1295 1678 def test_journalized_description
Chris@1295 1679 IssueCustomField.delete_all
Chris@1295 1680
Chris@1295 1681 i = Issue.first
Chris@1295 1682 old_description = i.description
Chris@1295 1683 new_description = "This is the new description"
Chris@1295 1684
Chris@1295 1685 i.init_journal(User.find(2))
Chris@1295 1686 i.description = new_description
Chris@1295 1687 assert_difference 'Journal.count', 1 do
Chris@1295 1688 assert_difference 'JournalDetail.count', 1 do
Chris@1295 1689 i.save!
Chris@1295 1690 end
Chris@1295 1691 end
Chris@1295 1692
Chris@1295 1693 detail = JournalDetail.first(:order => 'id DESC')
Chris@1295 1694 assert_equal i, detail.journal.journalized
Chris@1295 1695 assert_equal 'attr', detail.property
Chris@1295 1696 assert_equal 'description', detail.prop_key
Chris@1295 1697 assert_equal old_description, detail.old_value
Chris@1295 1698 assert_equal new_description, detail.value
Chris@1295 1699 end
Chris@1295 1700
Chris@1295 1701 def test_blank_descriptions_should_not_be_journalized
Chris@1295 1702 IssueCustomField.delete_all
Chris@1295 1703 Issue.update_all("description = NULL", "id=1")
Chris@1295 1704
Chris@1295 1705 i = Issue.find(1)
Chris@1295 1706 i.init_journal(User.find(2))
Chris@1295 1707 i.subject = "blank description"
Chris@1295 1708 i.description = "\r\n"
Chris@1295 1709
Chris@1295 1710 assert_difference 'Journal.count', 1 do
Chris@1295 1711 assert_difference 'JournalDetail.count', 1 do
Chris@1295 1712 i.save!
Chris@1295 1713 end
Chris@1295 1714 end
Chris@1295 1715 end
Chris@1295 1716
Chris@1295 1717 def test_journalized_multi_custom_field
Chris@1295 1718 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
Chris@1295 1719 :is_filter => true, :is_for_all => true,
Chris@1295 1720 :tracker_ids => [1],
Chris@1295 1721 :possible_values => ['value1', 'value2', 'value3'],
Chris@1295 1722 :multiple => true)
Chris@1295 1723
Chris@1295 1724 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
Chris@1295 1725 :subject => 'Test', :author_id => 1)
Chris@1295 1726
Chris@1295 1727 assert_difference 'Journal.count' do
Chris@1295 1728 assert_difference 'JournalDetail.count' do
Chris@1295 1729 issue.init_journal(User.first)
Chris@1295 1730 issue.custom_field_values = {field.id => ['value1']}
Chris@1295 1731 issue.save!
Chris@1295 1732 end
Chris@1295 1733 assert_difference 'JournalDetail.count' do
Chris@1295 1734 issue.init_journal(User.first)
Chris@1295 1735 issue.custom_field_values = {field.id => ['value1', 'value2']}
Chris@1295 1736 issue.save!
Chris@1295 1737 end
Chris@1295 1738 assert_difference 'JournalDetail.count', 2 do
Chris@1295 1739 issue.init_journal(User.first)
Chris@1295 1740 issue.custom_field_values = {field.id => ['value3', 'value2']}
Chris@1295 1741 issue.save!
Chris@1295 1742 end
Chris@1295 1743 assert_difference 'JournalDetail.count', 2 do
Chris@1295 1744 issue.init_journal(User.first)
Chris@1295 1745 issue.custom_field_values = {field.id => nil}
Chris@1295 1746 issue.save!
Chris@1295 1747 end
Chris@1295 1748 end
Chris@1295 1749 end
Chris@1295 1750
Chris@1295 1751 def test_description_eol_should_be_normalized
Chris@1295 1752 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
Chris@1295 1753 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
Chris@1295 1754 end
Chris@1295 1755
Chris@1295 1756 def test_saving_twice_should_not_duplicate_journal_details
Chris@1295 1757 i = Issue.first
Chris@1295 1758 i.init_journal(User.find(2), 'Some notes')
Chris@1295 1759 # initial changes
Chris@1295 1760 i.subject = 'New subject'
Chris@1295 1761 i.done_ratio = i.done_ratio + 10
Chris@1295 1762 assert_difference 'Journal.count' do
Chris@1295 1763 assert i.save
Chris@1295 1764 end
Chris@1295 1765 # 1 more change
Chris@1295 1766 i.priority = IssuePriority.where("id <> ?", i.priority_id).first
Chris@1295 1767 assert_no_difference 'Journal.count' do
Chris@1295 1768 assert_difference 'JournalDetail.count', 1 do
Chris@1295 1769 i.save
Chris@1295 1770 end
Chris@1295 1771 end
Chris@1295 1772 # no more change
Chris@1295 1773 assert_no_difference 'Journal.count' do
Chris@1295 1774 assert_no_difference 'JournalDetail.count' do
Chris@1295 1775 i.save
Chris@1295 1776 end
Chris@1295 1777 end
Chris@1295 1778 end
Chris@1295 1779
Chris@1295 1780 def test_all_dependent_issues
Chris@1295 1781 IssueRelation.delete_all
Chris@1295 1782 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1295 1783 :issue_to => Issue.find(2),
Chris@1295 1784 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1785 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1295 1786 :issue_to => Issue.find(3),
Chris@1295 1787 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1788 assert IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1295 1789 :issue_to => Issue.find(8),
Chris@1295 1790 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1791
Chris@1295 1792 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1295 1793 end
Chris@1295 1794
Chris@1295 1795 def test_all_dependent_issues_with_persistent_circular_dependency
Chris@1295 1796 IssueRelation.delete_all
Chris@1295 1797 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1295 1798 :issue_to => Issue.find(2),
Chris@1295 1799 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1800 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1295 1801 :issue_to => Issue.find(3),
Chris@1295 1802 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1803
Chris@1295 1804 r = IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1295 1805 :issue_to => Issue.find(7),
Chris@1295 1806 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1807 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
Chris@1295 1808
Chris@1295 1809 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1295 1810 end
Chris@1295 1811
Chris@1295 1812 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
Chris@1295 1813 IssueRelation.delete_all
Chris@1295 1814 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1295 1815 :issue_to => Issue.find(2),
Chris@1295 1816 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1295 1817 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1295 1818 :issue_to => Issue.find(3),
Chris@1295 1819 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1295 1820 assert IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1295 1821 :issue_to => Issue.find(8),
Chris@1295 1822 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1295 1823
Chris@1295 1824 r = IssueRelation.create!(:issue_from => Issue.find(8),
Chris@1295 1825 :issue_to => Issue.find(7),
Chris@1295 1826 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1295 1827 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
Chris@1295 1828
Chris@1295 1829 r = IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1295 1830 :issue_to => Issue.find(7),
Chris@1295 1831 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1295 1832 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
Chris@1295 1833
Chris@1295 1834 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1295 1835 end
Chris@1295 1836
Chris@1295 1837 test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
Chris@1295 1838 @issue = Issue.find(1)
Chris@1295 1839 @issue_status = IssueStatus.find(1)
Chris@1295 1840 @issue_status.update_attribute(:default_done_ratio, 50)
Chris@1295 1841 @issue2 = Issue.find(2)
Chris@1295 1842 @issue_status2 = IssueStatus.find(2)
Chris@1295 1843 @issue_status2.update_attribute(:default_done_ratio, 0)
Chris@1295 1844
Chris@1295 1845 with_settings :issue_done_ratio => 'issue_field' do
Chris@1295 1846 assert_equal 0, @issue.done_ratio
Chris@1295 1847 assert_equal 30, @issue2.done_ratio
Chris@1295 1848 end
Chris@1295 1849
Chris@1295 1850 with_settings :issue_done_ratio => 'issue_status' do
Chris@1295 1851 assert_equal 50, @issue.done_ratio
Chris@1295 1852 assert_equal 0, @issue2.done_ratio
Chris@1295 1853 end
Chris@1295 1854 end
Chris@1295 1855
Chris@1295 1856 test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
Chris@1295 1857 @issue = Issue.find(1)
Chris@1295 1858 @issue_status = IssueStatus.find(1)
Chris@1295 1859 @issue_status.update_attribute(:default_done_ratio, 50)
Chris@1295 1860 @issue2 = Issue.find(2)
Chris@1295 1861 @issue_status2 = IssueStatus.find(2)
Chris@1295 1862 @issue_status2.update_attribute(:default_done_ratio, 0)
Chris@1295 1863
Chris@1295 1864 with_settings :issue_done_ratio => 'issue_field' do
Chris@1295 1865 @issue.update_done_ratio_from_issue_status
Chris@1295 1866 @issue2.update_done_ratio_from_issue_status
Chris@1295 1867
Chris@1295 1868 assert_equal 0, @issue.read_attribute(:done_ratio)
Chris@1295 1869 assert_equal 30, @issue2.read_attribute(:done_ratio)
Chris@1295 1870 end
Chris@1295 1871
Chris@1295 1872 with_settings :issue_done_ratio => 'issue_status' do
Chris@1295 1873 @issue.update_done_ratio_from_issue_status
Chris@1295 1874 @issue2.update_done_ratio_from_issue_status
Chris@1295 1875
Chris@1295 1876 assert_equal 50, @issue.read_attribute(:done_ratio)
Chris@1295 1877 assert_equal 0, @issue2.read_attribute(:done_ratio)
Chris@1295 1878 end
Chris@1295 1879 end
Chris@1295 1880
Chris@1295 1881 test "#by_tracker" do
Chris@1295 1882 User.current = User.anonymous
Chris@1295 1883 groups = Issue.by_tracker(Project.find(1))
Chris@1295 1884 assert_equal 3, groups.size
Chris@1295 1885 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1886 end
Chris@1295 1887
Chris@1295 1888 test "#by_version" do
Chris@1295 1889 User.current = User.anonymous
Chris@1295 1890 groups = Issue.by_version(Project.find(1))
Chris@1295 1891 assert_equal 3, groups.size
Chris@1295 1892 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1893 end
Chris@1295 1894
Chris@1295 1895 test "#by_priority" do
Chris@1295 1896 User.current = User.anonymous
Chris@1295 1897 groups = Issue.by_priority(Project.find(1))
Chris@1295 1898 assert_equal 4, groups.size
Chris@1295 1899 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1900 end
Chris@1295 1901
Chris@1295 1902 test "#by_category" do
Chris@1295 1903 User.current = User.anonymous
Chris@1295 1904 groups = Issue.by_category(Project.find(1))
Chris@1295 1905 assert_equal 2, groups.size
Chris@1295 1906 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1907 end
Chris@1295 1908
Chris@1295 1909 test "#by_assigned_to" do
Chris@1295 1910 User.current = User.anonymous
Chris@1295 1911 groups = Issue.by_assigned_to(Project.find(1))
Chris@1295 1912 assert_equal 2, groups.size
Chris@1295 1913 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1914 end
Chris@1295 1915
Chris@1295 1916 test "#by_author" do
Chris@1295 1917 User.current = User.anonymous
Chris@1295 1918 groups = Issue.by_author(Project.find(1))
Chris@1295 1919 assert_equal 4, groups.size
Chris@1295 1920 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1921 end
Chris@1295 1922
Chris@1295 1923 test "#by_subproject" do
Chris@1295 1924 User.current = User.anonymous
Chris@1295 1925 groups = Issue.by_subproject(Project.find(1))
Chris@1295 1926 # Private descendant not visible
Chris@1295 1927 assert_equal 1, groups.size
Chris@1295 1928 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1929 end
Chris@1295 1930
Chris@1295 1931 def test_recently_updated_scope
Chris@1295 1932 #should return the last updated issue
Chris@1295 1933 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
Chris@1295 1934 end
Chris@1295 1935
Chris@1295 1936 def test_on_active_projects_scope
Chris@1295 1937 assert Project.find(2).archive
Chris@1295 1938
Chris@1295 1939 before = Issue.on_active_project.length
Chris@1295 1940 # test inclusion to results
Chris@1295 1941 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
Chris@1295 1942 assert_equal before + 1, Issue.on_active_project.length
Chris@1295 1943
Chris@1295 1944 # Move to an archived project
Chris@1295 1945 issue.project = Project.find(2)
Chris@1295 1946 assert issue.save
Chris@1295 1947 assert_equal before, Issue.on_active_project.length
Chris@1295 1948 end
Chris@1295 1949
Chris@1295 1950 test "Issue#recipients should include project recipients" do
Chris@1295 1951 issue = Issue.generate!
Chris@1295 1952 assert issue.project.recipients.present?
Chris@1295 1953 issue.project.recipients.each do |project_recipient|
Chris@1295 1954 assert issue.recipients.include?(project_recipient)
Chris@1295 1955 end
Chris@1295 1956 end
Chris@1295 1957
Chris@1295 1958 test "Issue#recipients should include the author if the author is active" do
Chris@1295 1959 issue = Issue.generate!(:author => User.generate!)
Chris@1295 1960 assert issue.author, "No author set for Issue"
Chris@1295 1961 assert issue.recipients.include?(issue.author.mail)
Chris@1295 1962 end
Chris@1295 1963
Chris@1295 1964 test "Issue#recipients should include the assigned to user if the assigned to user is active" do
Chris@1295 1965 issue = Issue.generate!(:assigned_to => User.generate!)
Chris@1295 1966 assert issue.assigned_to, "No assigned_to set for Issue"
Chris@1295 1967 assert issue.recipients.include?(issue.assigned_to.mail)
Chris@1295 1968 end
Chris@1295 1969
Chris@1295 1970 test "Issue#recipients should not include users who opt out of all email" do
Chris@1295 1971 issue = Issue.generate!(:author => User.generate!)
Chris@1295 1972 issue.author.update_attribute(:mail_notification, :none)
Chris@1295 1973 assert !issue.recipients.include?(issue.author.mail)
Chris@1295 1974 end
Chris@1295 1975
Chris@1295 1976 test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
Chris@1295 1977 issue = Issue.generate!(:author => User.generate!)
Chris@1295 1978 issue.author.update_attribute(:mail_notification, :only_assigned)
Chris@1295 1979 assert !issue.recipients.include?(issue.author.mail)
Chris@1295 1980 end
Chris@1295 1981
Chris@1295 1982 test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
Chris@1295 1983 issue = Issue.generate!(:assigned_to => User.generate!)
Chris@1295 1984 issue.assigned_to.update_attribute(:mail_notification, :only_owner)
Chris@1295 1985 assert !issue.recipients.include?(issue.assigned_to.mail)
Chris@1295 1986 end
Chris@1295 1987
Chris@1295 1988 def test_last_journal_id_with_journals_should_return_the_journal_id
Chris@1295 1989 assert_equal 2, Issue.find(1).last_journal_id
Chris@1295 1990 end
Chris@1295 1991
Chris@1295 1992 def test_last_journal_id_without_journals_should_return_nil
Chris@1295 1993 assert_nil Issue.find(3).last_journal_id
Chris@1295 1994 end
Chris@1295 1995
Chris@1295 1996 def test_journals_after_should_return_journals_with_greater_id
Chris@1295 1997 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
Chris@1295 1998 assert_equal [], Issue.find(1).journals_after('2')
Chris@1295 1999 end
Chris@1295 2000
Chris@1295 2001 def test_journals_after_with_blank_arg_should_return_all_journals
Chris@1295 2002 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
Chris@1295 2003 end
Chris@1295 2004
Chris@1295 2005 def test_css_classes_should_include_tracker
Chris@1295 2006 issue = Issue.new(:tracker => Tracker.find(2))
Chris@1295 2007 classes = issue.css_classes.split(' ')
Chris@1295 2008 assert_include 'tracker-2', classes
Chris@1295 2009 end
Chris@1295 2010
Chris@1295 2011 def test_css_classes_should_include_priority
Chris@1295 2012 issue = Issue.new(:priority => IssuePriority.find(8))
Chris@1295 2013 classes = issue.css_classes.split(' ')
Chris@1295 2014 assert_include 'priority-8', classes
Chris@1295 2015 assert_include 'priority-highest', classes
Chris@1295 2016 end
Chris@1295 2017
Chris@1295 2018 def test_save_attachments_with_hash_should_save_attachments_in_keys_order
Chris@1295 2019 set_tmp_attachments_directory
Chris@1295 2020 issue = Issue.generate!
Chris@1295 2021 issue.save_attachments({
Chris@1295 2022 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
Chris@1295 2023 '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
Chris@1295 2024 '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
Chris@1295 2025 })
Chris@1295 2026 issue.attach_saved_attachments
Chris@1295 2027
Chris@1295 2028 assert_equal 3, issue.reload.attachments.count
Chris@1295 2029 assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
Chris@1295 2030 end
Chris@1295 2031
Chris@1295 2032 def test_closed_on_should_be_nil_when_creating_an_open_issue
Chris@1295 2033 issue = Issue.generate!(:status_id => 1).reload
Chris@1295 2034 assert !issue.closed?
Chris@1295 2035 assert_nil issue.closed_on
Chris@1295 2036 end
Chris@1295 2037
Chris@1295 2038 def test_closed_on_should_be_set_when_creating_a_closed_issue
Chris@1295 2039 issue = Issue.generate!(:status_id => 5).reload
Chris@1295 2040 assert issue.closed?
Chris@1295 2041 assert_not_nil issue.closed_on
Chris@1295 2042 assert_equal issue.updated_on, issue.closed_on
Chris@1295 2043 assert_equal issue.created_on, issue.closed_on
Chris@1295 2044 end
Chris@1295 2045
Chris@1295 2046 def test_closed_on_should_be_nil_when_updating_an_open_issue
Chris@1295 2047 issue = Issue.find(1)
Chris@1295 2048 issue.subject = 'Not closed yet'
Chris@1295 2049 issue.save!
Chris@1295 2050 issue.reload
Chris@1295 2051 assert_nil issue.closed_on
Chris@1295 2052 end
Chris@1295 2053
Chris@1295 2054 def test_closed_on_should_be_set_when_closing_an_open_issue
Chris@1295 2055 issue = Issue.find(1)
Chris@1295 2056 issue.subject = 'Now closed'
Chris@1295 2057 issue.status_id = 5
Chris@1295 2058 issue.save!
Chris@1295 2059 issue.reload
Chris@1295 2060 assert_not_nil issue.closed_on
Chris@1295 2061 assert_equal issue.updated_on, issue.closed_on
Chris@1295 2062 end
Chris@1295 2063
Chris@1295 2064 def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
Chris@1295 2065 issue = Issue.open(false).first
Chris@1295 2066 was_closed_on = issue.closed_on
Chris@1295 2067 assert_not_nil was_closed_on
Chris@1295 2068 issue.subject = 'Updating a closed issue'
Chris@1295 2069 issue.save!
Chris@1295 2070 issue.reload
Chris@1295 2071 assert_equal was_closed_on, issue.closed_on
Chris@1295 2072 end
Chris@1295 2073
Chris@1295 2074 def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
Chris@1295 2075 issue = Issue.open(false).first
Chris@1295 2076 was_closed_on = issue.closed_on
Chris@1295 2077 assert_not_nil was_closed_on
Chris@1295 2078 issue.subject = 'Reopening a closed issue'
Chris@1295 2079 issue.status_id = 1
Chris@1295 2080 issue.save!
Chris@1295 2081 issue.reload
Chris@1295 2082 assert !issue.closed?
Chris@1295 2083 assert_equal was_closed_on, issue.closed_on
Chris@1295 2084 end
Chris@1295 2085
Chris@1295 2086 def test_status_was_should_return_nil_for_new_issue
Chris@1295 2087 issue = Issue.new
Chris@1295 2088 assert_nil issue.status_was
Chris@1295 2089 end
Chris@1295 2090
Chris@1295 2091 def test_status_was_should_return_status_before_change
Chris@1295 2092 issue = Issue.find(1)
Chris@1295 2093 issue.status = IssueStatus.find(2)
Chris@1295 2094 assert_equal IssueStatus.find(1), issue.status_was
Chris@1295 2095 end
Chris@1295 2096
Chris@1295 2097 def test_status_was_should_be_reset_on_save
Chris@1295 2098 issue = Issue.find(1)
Chris@1295 2099 issue.status = IssueStatus.find(2)
Chris@1295 2100 assert_equal IssueStatus.find(1), issue.status_was
Chris@1295 2101 assert issue.save!
Chris@1295 2102 assert_equal IssueStatus.find(2), issue.status_was
Chris@1295 2103 end
Chris@1295 2104 end