annotate .svn/pristine/85/85cb4b5b2aa4587d3f8e85f0dc40fcad929d49ad.svn-base @ 1298:4f746d8966dd redmine_2.3_integration

Merge from redmine-2.3 branch to create new branch redmine-2.3-integration
author Chris Cannam
date Fri, 14 Jun 2013 09:28:30 +0100
parents 622f24f53b42
children
rev   line source
Chris@1295 1 # Redmine - project management software
Chris@1295 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
Chris@1295 3 #
Chris@1295 4 # This program is free software; you can redistribute it and/or
Chris@1295 5 # modify it under the terms of the GNU General Public License
Chris@1295 6 # as published by the Free Software Foundation; either version 2
Chris@1295 7 # of the License, or (at your option) any later version.
Chris@1295 8 #
Chris@1295 9 # This program is distributed in the hope that it will be useful,
Chris@1295 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1295 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@1295 12 # GNU General Public License for more details.
Chris@1295 13 #
Chris@1295 14 # You should have received a copy of the GNU General Public License
Chris@1295 15 # along with this program; if not, write to the Free Software
Chris@1295 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@1295 17
Chris@1295 18 require File.expand_path('../../test_helper', __FILE__)
Chris@1295 19 require 'users_controller'
Chris@1295 20
Chris@1295 21 # Re-raise errors caught by the controller.
Chris@1295 22 class UsersController; def rescue_action(e) raise e end; end
Chris@1295 23
Chris@1295 24 class UsersControllerTest < ActionController::TestCase
Chris@1295 25 include Redmine::I18n
Chris@1295 26
Chris@1295 27 fixtures :users, :projects, :members, :member_roles, :roles,
Chris@1295 28 :custom_fields, :custom_values, :groups_users,
Chris@1295 29 :auth_sources
Chris@1295 30
Chris@1295 31 def setup
Chris@1295 32 @controller = UsersController.new
Chris@1295 33 @request = ActionController::TestRequest.new
Chris@1295 34 @response = ActionController::TestResponse.new
Chris@1295 35 User.current = nil
Chris@1295 36 @request.session[:user_id] = 1 # admin
Chris@1295 37 end
Chris@1295 38
Chris@1295 39 def test_index
Chris@1295 40 get :index
Chris@1295 41 assert_response :success
Chris@1295 42 assert_template 'index'
Chris@1295 43 end
Chris@1295 44
Chris@1295 45 def test_index
Chris@1295 46 get :index
Chris@1295 47 assert_response :success
Chris@1295 48 assert_template 'index'
Chris@1295 49 assert_not_nil assigns(:users)
Chris@1295 50 # active users only
Chris@1295 51 assert_nil assigns(:users).detect {|u| !u.active?}
Chris@1295 52 end
Chris@1295 53
Chris@1295 54 def test_index_with_status_filter
Chris@1295 55 get :index, :status => 3
Chris@1295 56 assert_response :success
Chris@1295 57 assert_template 'index'
Chris@1295 58 assert_not_nil assigns(:users)
Chris@1295 59 assert_equal [3], assigns(:users).map(&:status).uniq
Chris@1295 60 end
Chris@1295 61
Chris@1295 62 def test_index_with_name_filter
Chris@1295 63 get :index, :name => 'john'
Chris@1295 64 assert_response :success
Chris@1295 65 assert_template 'index'
Chris@1295 66 users = assigns(:users)
Chris@1295 67 assert_not_nil users
Chris@1295 68 assert_equal 1, users.size
Chris@1295 69 assert_equal 'John', users.first.firstname
Chris@1295 70 end
Chris@1295 71
Chris@1295 72 def test_index_with_group_filter
Chris@1295 73 get :index, :group_id => '10'
Chris@1295 74 assert_response :success
Chris@1295 75 assert_template 'index'
Chris@1295 76 users = assigns(:users)
Chris@1295 77 assert users.any?
Chris@1295 78 assert_equal([], (users - Group.find(10).users))
Chris@1295 79 assert_select 'select[name=group_id]' do
Chris@1295 80 assert_select 'option[value=10][selected=selected]'
Chris@1295 81 end
Chris@1295 82 end
Chris@1295 83
Chris@1295 84 def test_show
Chris@1295 85 @request.session[:user_id] = nil
Chris@1295 86 get :show, :id => 2
Chris@1295 87 assert_response :success
Chris@1295 88 assert_template 'show'
Chris@1295 89 assert_not_nil assigns(:user)
Chris@1295 90
Chris@1295 91 assert_tag 'li', :content => /Phone number/
Chris@1295 92 end
Chris@1295 93
Chris@1295 94 def test_show_should_not_display_hidden_custom_fields
Chris@1295 95 @request.session[:user_id] = nil
Chris@1295 96 UserCustomField.find_by_name('Phone number').update_attribute :visible, false
Chris@1295 97 get :show, :id => 2
Chris@1295 98 assert_response :success
Chris@1295 99 assert_template 'show'
Chris@1295 100 assert_not_nil assigns(:user)
Chris@1295 101
Chris@1295 102 assert_no_tag 'li', :content => /Phone number/
Chris@1295 103 end
Chris@1295 104
Chris@1295 105 def test_show_should_not_fail_when_custom_values_are_nil
Chris@1295 106 user = User.find(2)
Chris@1295 107
Chris@1295 108 # Create a custom field to illustrate the issue
Chris@1295 109 custom_field = CustomField.create!(:name => 'Testing', :field_format => 'text')
Chris@1295 110 custom_value = user.custom_values.build(:custom_field => custom_field).save!
Chris@1295 111
Chris@1295 112 get :show, :id => 2
Chris@1295 113 assert_response :success
Chris@1295 114 end
Chris@1295 115
Chris@1295 116 def test_show_inactive
Chris@1295 117 @request.session[:user_id] = nil
Chris@1295 118 get :show, :id => 5
Chris@1295 119 assert_response 404
Chris@1295 120 end
Chris@1295 121
Chris@1295 122 def test_show_should_not_reveal_users_with_no_visible_activity_or_project
Chris@1295 123 @request.session[:user_id] = nil
Chris@1295 124 get :show, :id => 9
Chris@1295 125 assert_response 404
Chris@1295 126 end
Chris@1295 127
Chris@1295 128 def test_show_inactive_by_admin
Chris@1295 129 @request.session[:user_id] = 1
Chris@1295 130 get :show, :id => 5
Chris@1295 131 assert_response 200
Chris@1295 132 assert_not_nil assigns(:user)
Chris@1295 133 end
Chris@1295 134
Chris@1295 135 def test_show_displays_memberships_based_on_project_visibility
Chris@1295 136 @request.session[:user_id] = 1
Chris@1295 137 get :show, :id => 2
Chris@1295 138 assert_response :success
Chris@1295 139 memberships = assigns(:memberships)
Chris@1295 140 assert_not_nil memberships
Chris@1295 141 project_ids = memberships.map(&:project_id)
Chris@1295 142 assert project_ids.include?(2) #private project admin can see
Chris@1295 143 end
Chris@1295 144
Chris@1295 145 def test_show_current_should_require_authentication
Chris@1295 146 @request.session[:user_id] = nil
Chris@1295 147 get :show, :id => 'current'
Chris@1295 148 assert_response 302
Chris@1295 149 end
Chris@1295 150
Chris@1295 151 def test_show_current
Chris@1295 152 @request.session[:user_id] = 2
Chris@1295 153 get :show, :id => 'current'
Chris@1295 154 assert_response :success
Chris@1295 155 assert_template 'show'
Chris@1295 156 assert_equal User.find(2), assigns(:user)
Chris@1295 157 end
Chris@1295 158
Chris@1295 159 def test_new
Chris@1295 160 get :new
Chris@1295 161 assert_response :success
Chris@1295 162 assert_template :new
Chris@1295 163 assert assigns(:user)
Chris@1295 164 end
Chris@1295 165
Chris@1295 166 def test_create
Chris@1295 167 Setting.bcc_recipients = '1'
Chris@1295 168
Chris@1295 169 assert_difference 'User.count' do
Chris@1295 170 assert_difference 'ActionMailer::Base.deliveries.size' do
Chris@1295 171 post :create,
Chris@1295 172 :user => {
Chris@1295 173 :firstname => 'John',
Chris@1295 174 :lastname => 'Doe',
Chris@1295 175 :login => 'jdoe',
Chris@1295 176 :password => 'secret123',
Chris@1295 177 :password_confirmation => 'secret123',
Chris@1295 178 :mail => 'jdoe@gmail.com',
Chris@1295 179 :mail_notification => 'none'
Chris@1295 180 },
Chris@1295 181 :send_information => '1'
Chris@1295 182 end
Chris@1295 183 end
Chris@1295 184
Chris@1295 185 user = User.first(:order => 'id DESC')
Chris@1295 186 assert_redirected_to :controller => 'users', :action => 'edit', :id => user.id
Chris@1295 187
Chris@1295 188 assert_equal 'John', user.firstname
Chris@1295 189 assert_equal 'Doe', user.lastname
Chris@1295 190 assert_equal 'jdoe', user.login
Chris@1295 191 assert_equal 'jdoe@gmail.com', user.mail
Chris@1295 192 assert_equal 'none', user.mail_notification
Chris@1295 193 assert user.check_password?('secret123')
Chris@1295 194
Chris@1295 195 mail = ActionMailer::Base.deliveries.last
Chris@1295 196 assert_not_nil mail
Chris@1295 197 assert_equal [user.mail], mail.bcc
Chris@1295 198 assert_mail_body_match 'secret', mail
Chris@1295 199 end
Chris@1295 200
Chris@1295 201 def test_create_with_preferences
Chris@1295 202 assert_difference 'User.count' do
Chris@1295 203 post :create,
Chris@1295 204 :user => {
Chris@1295 205 :firstname => 'John',
Chris@1295 206 :lastname => 'Doe',
Chris@1295 207 :login => 'jdoe',
Chris@1295 208 :password => 'secret123',
Chris@1295 209 :password_confirmation => 'secret123',
Chris@1295 210 :mail => 'jdoe@gmail.com',
Chris@1295 211 :mail_notification => 'none'
Chris@1295 212 },
Chris@1295 213 :pref => {
Chris@1295 214 'hide_mail' => '1',
Chris@1295 215 'time_zone' => 'Paris',
Chris@1295 216 'comments_sorting' => 'desc',
Chris@1295 217 'warn_on_leaving_unsaved' => '0'
Chris@1295 218 }
Chris@1295 219 end
Chris@1295 220 user = User.first(:order => 'id DESC')
Chris@1295 221 assert_equal 'jdoe', user.login
Chris@1295 222 assert_equal true, user.pref.hide_mail
Chris@1295 223 assert_equal 'Paris', user.pref.time_zone
Chris@1295 224 assert_equal 'desc', user.pref[:comments_sorting]
Chris@1295 225 assert_equal '0', user.pref[:warn_on_leaving_unsaved]
Chris@1295 226 end
Chris@1295 227
Chris@1295 228 def test_create_with_failure
Chris@1295 229 assert_no_difference 'User.count' do
Chris@1295 230 post :create, :user => {}
Chris@1295 231 end
Chris@1295 232 assert_response :success
Chris@1295 233 assert_template 'new'
Chris@1295 234 end
Chris@1295 235
Chris@1295 236 def test_edit
Chris@1295 237 get :edit, :id => 2
Chris@1295 238 assert_response :success
Chris@1295 239 assert_template 'edit'
Chris@1295 240 assert_equal User.find(2), assigns(:user)
Chris@1295 241 end
Chris@1295 242
Chris@1295 243 def test_update
Chris@1295 244 ActionMailer::Base.deliveries.clear
Chris@1295 245 put :update, :id => 2,
Chris@1295 246 :user => {:firstname => 'Changed', :mail_notification => 'only_assigned'},
Chris@1295 247 :pref => {:hide_mail => '1', :comments_sorting => 'desc'}
Chris@1295 248 user = User.find(2)
Chris@1295 249 assert_equal 'Changed', user.firstname
Chris@1295 250 assert_equal 'only_assigned', user.mail_notification
Chris@1295 251 assert_equal true, user.pref[:hide_mail]
Chris@1295 252 assert_equal 'desc', user.pref[:comments_sorting]
Chris@1295 253 assert ActionMailer::Base.deliveries.empty?
Chris@1295 254 end
Chris@1295 255
Chris@1295 256 def test_update_with_failure
Chris@1295 257 assert_no_difference 'User.count' do
Chris@1295 258 put :update, :id => 2, :user => {:firstname => ''}
Chris@1295 259 end
Chris@1295 260 assert_response :success
Chris@1295 261 assert_template 'edit'
Chris@1295 262 end
Chris@1295 263
Chris@1295 264 def test_update_with_group_ids_should_assign_groups
Chris@1295 265 put :update, :id => 2, :user => {:group_ids => ['10']}
Chris@1295 266 user = User.find(2)
Chris@1295 267 assert_equal [10], user.group_ids
Chris@1295 268 end
Chris@1295 269
Chris@1295 270 def test_update_with_activation_should_send_a_notification
Chris@1295 271 u = User.new(:firstname => 'Foo', :lastname => 'Bar', :mail => 'foo.bar@somenet.foo', :language => 'fr')
Chris@1295 272 u.login = 'foo'
Chris@1295 273 u.status = User::STATUS_REGISTERED
Chris@1295 274 u.save!
Chris@1295 275 ActionMailer::Base.deliveries.clear
Chris@1295 276 Setting.bcc_recipients = '1'
Chris@1295 277
Chris@1295 278 put :update, :id => u.id, :user => {:status => User::STATUS_ACTIVE}
Chris@1295 279 assert u.reload.active?
Chris@1295 280 mail = ActionMailer::Base.deliveries.last
Chris@1295 281 assert_not_nil mail
Chris@1295 282 assert_equal ['foo.bar@somenet.foo'], mail.bcc
Chris@1295 283 assert_mail_body_match ll('fr', :notice_account_activated), mail
Chris@1295 284 end
Chris@1295 285
Chris@1295 286 def test_update_with_password_change_should_send_a_notification
Chris@1295 287 ActionMailer::Base.deliveries.clear
Chris@1295 288 Setting.bcc_recipients = '1'
Chris@1295 289
Chris@1295 290 put :update, :id => 2, :user => {:password => 'newpass123', :password_confirmation => 'newpass123'}, :send_information => '1'
Chris@1295 291 u = User.find(2)
Chris@1295 292 assert u.check_password?('newpass123')
Chris@1295 293
Chris@1295 294 mail = ActionMailer::Base.deliveries.last
Chris@1295 295 assert_not_nil mail
Chris@1295 296 assert_equal [u.mail], mail.bcc
Chris@1295 297 assert_mail_body_match 'newpass123', mail
Chris@1295 298 end
Chris@1295 299
Chris@1295 300 def test_update_user_switchin_from_auth_source_to_password_authentication
Chris@1295 301 # Configure as auth source
Chris@1295 302 u = User.find(2)
Chris@1295 303 u.auth_source = AuthSource.find(1)
Chris@1295 304 u.save!
Chris@1295 305
Chris@1295 306 put :update, :id => u.id, :user => {:auth_source_id => '', :password => 'newpass123', :password_confirmation => 'newpass123'}
Chris@1295 307
Chris@1295 308 assert_equal nil, u.reload.auth_source
Chris@1295 309 assert u.check_password?('newpass123')
Chris@1295 310 end
Chris@1295 311
Chris@1295 312 def test_update_notified_project
Chris@1295 313 get :edit, :id => 2
Chris@1295 314 assert_response :success
Chris@1295 315 assert_template 'edit'
Chris@1295 316 u = User.find(2)
Chris@1295 317 assert_equal [1, 2, 5], u.projects.collect{|p| p.id}.sort
Chris@1295 318 assert_equal [1, 2, 5], u.notified_projects_ids.sort
Chris@1295 319 assert_tag :tag => 'input',
Chris@1295 320 :attributes => {
Chris@1295 321 :id => 'notified_project_ids_',
Chris@1295 322 :value => 1,
Chris@1295 323 }
Chris@1295 324 assert_equal 'all', u.mail_notification
Chris@1295 325 put :update, :id => 2,
Chris@1295 326 :user => {
Chris@1295 327 :mail_notification => 'selected',
Chris@1295 328 },
Chris@1295 329 :notified_project_ids => [1, 2]
Chris@1295 330 u = User.find(2)
Chris@1295 331 assert_equal 'selected', u.mail_notification
Chris@1295 332 assert_equal [1, 2], u.notified_projects_ids.sort
Chris@1295 333 end
Chris@1295 334
Chris@1295 335 def test_destroy
Chris@1295 336 assert_difference 'User.count', -1 do
Chris@1295 337 delete :destroy, :id => 2
Chris@1295 338 end
Chris@1295 339 assert_redirected_to '/users'
Chris@1295 340 assert_nil User.find_by_id(2)
Chris@1295 341 end
Chris@1295 342
Chris@1295 343 def test_destroy_should_be_denied_for_non_admin_users
Chris@1295 344 @request.session[:user_id] = 3
Chris@1295 345
Chris@1295 346 assert_no_difference 'User.count' do
Chris@1295 347 get :destroy, :id => 2
Chris@1295 348 end
Chris@1295 349 assert_response 403
Chris@1295 350 end
Chris@1295 351
Chris@1295 352 def test_destroy_should_redirect_to_back_url_param
Chris@1295 353 assert_difference 'User.count', -1 do
Chris@1295 354 delete :destroy, :id => 2, :back_url => '/users?name=foo'
Chris@1295 355 end
Chris@1295 356 assert_redirected_to '/users?name=foo'
Chris@1295 357 end
Chris@1295 358
Chris@1295 359 def test_create_membership
Chris@1295 360 assert_difference 'Member.count' do
Chris@1295 361 post :edit_membership, :id => 7, :membership => { :project_id => 3, :role_ids => [2]}
Chris@1295 362 end
Chris@1295 363 assert_redirected_to :action => 'edit', :id => '7', :tab => 'memberships'
Chris@1295 364 member = Member.first(:order => 'id DESC')
Chris@1295 365 assert_equal User.find(7), member.principal
Chris@1295 366 assert_equal [2], member.role_ids
Chris@1295 367 assert_equal 3, member.project_id
Chris@1295 368 end
Chris@1295 369
Chris@1295 370 def test_create_membership_js_format
Chris@1295 371 assert_difference 'Member.count' do
Chris@1295 372 post :edit_membership, :id => 7, :membership => {:project_id => 3, :role_ids => [2]}, :format => 'js'
Chris@1295 373 assert_response :success
Chris@1295 374 assert_template 'edit_membership'
Chris@1295 375 assert_equal 'text/javascript', response.content_type
Chris@1295 376 end
Chris@1295 377 member = Member.first(:order => 'id DESC')
Chris@1295 378 assert_equal User.find(7), member.principal
Chris@1295 379 assert_equal [2], member.role_ids
Chris@1295 380 assert_equal 3, member.project_id
Chris@1295 381 assert_include 'tab-content-memberships', response.body
Chris@1295 382 end
Chris@1295 383
Chris@1295 384 def test_create_membership_js_format_with_failure
Chris@1295 385 assert_no_difference 'Member.count' do
Chris@1295 386 post :edit_membership, :id => 7, :membership => {:project_id => 3}, :format => 'js'
Chris@1295 387 assert_response :success
Chris@1295 388 assert_template 'edit_membership'
Chris@1295 389 assert_equal 'text/javascript', response.content_type
Chris@1295 390 end
Chris@1295 391 assert_include 'alert', response.body, "Alert message not sent"
Chris@1295 392 assert_include 'Role can\\\'t be empty', response.body, "Error message not sent"
Chris@1295 393 end
Chris@1295 394
Chris@1295 395 def test_update_membership
Chris@1295 396 assert_no_difference 'Member.count' do
Chris@1295 397 put :edit_membership, :id => 2, :membership_id => 1, :membership => { :role_ids => [2]}
Chris@1295 398 assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships'
Chris@1295 399 end
Chris@1295 400 assert_equal [2], Member.find(1).role_ids
Chris@1295 401 end
Chris@1295 402
Chris@1295 403 def test_update_membership_js_format
Chris@1295 404 assert_no_difference 'Member.count' do
Chris@1295 405 put :edit_membership, :id => 2, :membership_id => 1, :membership => {:role_ids => [2]}, :format => 'js'
Chris@1295 406 assert_response :success
Chris@1295 407 assert_template 'edit_membership'
Chris@1295 408 assert_equal 'text/javascript', response.content_type
Chris@1295 409 end
Chris@1295 410 assert_equal [2], Member.find(1).role_ids
Chris@1295 411 assert_include 'tab-content-memberships', response.body
Chris@1295 412 end
Chris@1295 413
Chris@1295 414 def test_destroy_membership
Chris@1295 415 assert_difference 'Member.count', -1 do
Chris@1295 416 delete :destroy_membership, :id => 2, :membership_id => 1
Chris@1295 417 end
Chris@1295 418 assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships'
Chris@1295 419 assert_nil Member.find_by_id(1)
Chris@1295 420 end
Chris@1295 421
Chris@1295 422 def test_destroy_membership_js_format
Chris@1295 423 assert_difference 'Member.count', -1 do
Chris@1295 424 delete :destroy_membership, :id => 2, :membership_id => 1, :format => 'js'
Chris@1295 425 assert_response :success
Chris@1295 426 assert_template 'destroy_membership'
Chris@1295 427 assert_equal 'text/javascript', response.content_type
Chris@1295 428 end
Chris@1295 429 assert_nil Member.find_by_id(1)
Chris@1295 430 assert_include 'tab-content-memberships', response.body
Chris@1295 431 end
Chris@1295 432 end