annotate .svn/pristine/4f/4f68d76f852340754bcbaa389f8acdaba7e60be4.svn-base @ 1298:4f746d8966dd redmine_2.3_integration

Merge from redmine-2.3 branch to create new branch redmine-2.3-integration
author Chris Cannam
date Fri, 14 Jun 2013 09:28:30 +0100
parents 622f24f53b42
children
rev   line source
Chris@1295 1 # Redmine - project management software
Chris@1295 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
Chris@1295 3 #
Chris@1295 4 # This program is free software; you can redistribute it and/or
Chris@1295 5 # modify it under the terms of the GNU General Public License
Chris@1295 6 # as published by the Free Software Foundation; either version 2
Chris@1295 7 # of the License, or (at your option) any later version.
Chris@1295 8 #
Chris@1295 9 # This program is distributed in the hope that it will be useful,
Chris@1295 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1295 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@1295 12 # GNU General Public License for more details.
Chris@1295 13 #
Chris@1295 14 # You should have received a copy of the GNU General Public License
Chris@1295 15 # along with this program; if not, write to the Free Software
Chris@1295 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@1295 17
Chris@1295 18 require File.expand_path('../../test_helper', __FILE__)
Chris@1295 19
Chris@1295 20 class ProjectEnumerationsControllerTest < ActionController::TestCase
Chris@1295 21 fixtures :projects, :trackers, :issue_statuses, :issues,
Chris@1295 22 :enumerations, :users, :issue_categories,
Chris@1295 23 :projects_trackers,
Chris@1295 24 :roles,
Chris@1295 25 :member_roles,
Chris@1295 26 :members,
Chris@1295 27 :enabled_modules,
Chris@1295 28 :custom_fields, :custom_fields_projects,
Chris@1295 29 :custom_fields_trackers, :custom_values,
Chris@1295 30 :time_entries
Chris@1295 31
Chris@1295 32 self.use_transactional_fixtures = false
Chris@1295 33
Chris@1295 34 def setup
Chris@1295 35 @request.session[:user_id] = nil
Chris@1295 36 Setting.default_language = 'en'
Chris@1295 37 end
Chris@1295 38
Chris@1295 39 def test_update_to_override_system_activities
Chris@1295 40 @request.session[:user_id] = 2 # manager
Chris@1295 41 billable_field = TimeEntryActivityCustomField.find_by_name("Billable")
Chris@1295 42
Chris@1295 43 put :update, :project_id => 1, :enumerations => {
Chris@1295 44 "9"=> {"parent_id"=>"9", "custom_field_values"=>{"7" => "1"}, "active"=>"0"}, # Design, De-activate
Chris@1295 45 "10"=> {"parent_id"=>"10", "custom_field_values"=>{"7"=>"0"}, "active"=>"1"}, # Development, Change custom value
Chris@1295 46 "14"=>{"parent_id"=>"14", "custom_field_values"=>{"7"=>"1"}, "active"=>"1"}, # Inactive Activity, Activate with custom value
Chris@1295 47 "11"=>{"parent_id"=>"11", "custom_field_values"=>{"7"=>"1"}, "active"=>"1"} # QA, no changes
Chris@1295 48 }
Chris@1295 49
Chris@1295 50 assert_response :redirect
Chris@1295 51 assert_redirected_to '/projects/ecookbook/settings/activities'
Chris@1295 52
Chris@1295 53 # Created project specific activities...
Chris@1295 54 project = Project.find('ecookbook')
Chris@1295 55
Chris@1295 56 # ... Design
Chris@1295 57 design = project.time_entry_activities.find_by_name("Design")
Chris@1295 58 assert design, "Project activity not found"
Chris@1295 59
Chris@1295 60 assert_equal 9, design.parent_id # Relate to the system activity
Chris@1295 61 assert_not_equal design.parent.id, design.id # Different records
Chris@1295 62 assert_equal design.parent.name, design.name # Same name
Chris@1295 63 assert !design.active?
Chris@1295 64
Chris@1295 65 # ... Development
Chris@1295 66 development = project.time_entry_activities.find_by_name("Development")
Chris@1295 67 assert development, "Project activity not found"
Chris@1295 68
Chris@1295 69 assert_equal 10, development.parent_id # Relate to the system activity
Chris@1295 70 assert_not_equal development.parent.id, development.id # Different records
Chris@1295 71 assert_equal development.parent.name, development.name # Same name
Chris@1295 72 assert development.active?
Chris@1295 73 assert_equal "0", development.custom_value_for(billable_field).value
Chris@1295 74
Chris@1295 75 # ... Inactive Activity
Chris@1295 76 previously_inactive = project.time_entry_activities.find_by_name("Inactive Activity")
Chris@1295 77 assert previously_inactive, "Project activity not found"
Chris@1295 78
Chris@1295 79 assert_equal 14, previously_inactive.parent_id # Relate to the system activity
Chris@1295 80 assert_not_equal previously_inactive.parent.id, previously_inactive.id # Different records
Chris@1295 81 assert_equal previously_inactive.parent.name, previously_inactive.name # Same name
Chris@1295 82 assert previously_inactive.active?
Chris@1295 83 assert_equal "1", previously_inactive.custom_value_for(billable_field).value
Chris@1295 84
Chris@1295 85 # ... QA
Chris@1295 86 assert_equal nil, project.time_entry_activities.find_by_name("QA"), "Custom QA activity created when it wasn't modified"
Chris@1295 87 end
Chris@1295 88
Chris@1295 89 def test_update_will_update_project_specific_activities
Chris@1295 90 @request.session[:user_id] = 2 # manager
Chris@1295 91
Chris@1295 92 project_activity = TimeEntryActivity.new({
Chris@1295 93 :name => 'Project Specific',
Chris@1295 94 :parent => TimeEntryActivity.first,
Chris@1295 95 :project => Project.find(1),
Chris@1295 96 :active => true
Chris@1295 97 })
Chris@1295 98 assert project_activity.save
Chris@1295 99 project_activity_two = TimeEntryActivity.new({
Chris@1295 100 :name => 'Project Specific Two',
Chris@1295 101 :parent => TimeEntryActivity.last,
Chris@1295 102 :project => Project.find(1),
Chris@1295 103 :active => true
Chris@1295 104 })
Chris@1295 105 assert project_activity_two.save
Chris@1295 106
Chris@1295 107
Chris@1295 108 put :update, :project_id => 1, :enumerations => {
Chris@1295 109 project_activity.id => {"custom_field_values"=>{"7" => "1"}, "active"=>"0"}, # De-activate
Chris@1295 110 project_activity_two.id => {"custom_field_values"=>{"7" => "1"}, "active"=>"0"} # De-activate
Chris@1295 111 }
Chris@1295 112
Chris@1295 113 assert_response :redirect
Chris@1295 114 assert_redirected_to '/projects/ecookbook/settings/activities'
Chris@1295 115
Chris@1295 116 # Created project specific activities...
Chris@1295 117 project = Project.find('ecookbook')
Chris@1295 118 assert_equal 2, project.time_entry_activities.count
Chris@1295 119
Chris@1295 120 activity_one = project.time_entry_activities.find_by_name(project_activity.name)
Chris@1295 121 assert activity_one, "Project activity not found"
Chris@1295 122 assert_equal project_activity.id, activity_one.id
Chris@1295 123 assert !activity_one.active?
Chris@1295 124
Chris@1295 125 activity_two = project.time_entry_activities.find_by_name(project_activity_two.name)
Chris@1295 126 assert activity_two, "Project activity not found"
Chris@1295 127 assert_equal project_activity_two.id, activity_two.id
Chris@1295 128 assert !activity_two.active?
Chris@1295 129 end
Chris@1295 130
Chris@1295 131 def test_update_when_creating_new_activities_will_convert_existing_data
Chris@1295 132 assert_equal 3, TimeEntry.find_all_by_activity_id_and_project_id(9, 1).size
Chris@1295 133
Chris@1295 134 @request.session[:user_id] = 2 # manager
Chris@1295 135 put :update, :project_id => 1, :enumerations => {
Chris@1295 136 "9"=> {"parent_id"=>"9", "custom_field_values"=>{"7" => "1"}, "active"=>"0"} # Design, De-activate
Chris@1295 137 }
Chris@1295 138 assert_response :redirect
Chris@1295 139
Chris@1295 140 # No more TimeEntries using the system activity
Chris@1295 141 assert_equal 0, TimeEntry.find_all_by_activity_id_and_project_id(9, 1).size, "Time Entries still assigned to system activities"
Chris@1295 142 # All TimeEntries using project activity
Chris@1295 143 project_specific_activity = TimeEntryActivity.find_by_parent_id_and_project_id(9, 1)
Chris@1295 144 assert_equal 3, TimeEntry.find_all_by_activity_id_and_project_id(project_specific_activity.id, 1).size, "No Time Entries assigned to the project activity"
Chris@1295 145 end
Chris@1295 146
Chris@1295 147 def test_update_when_creating_new_activities_will_not_convert_existing_data_if_an_exception_is_raised
Chris@1295 148 # TODO: Need to cause an exception on create but these tests
Chris@1295 149 # aren't setup for mocking. Just create a record now so the
Chris@1295 150 # second one is a dupicate
Chris@1295 151 parent = TimeEntryActivity.find(9)
Chris@1295 152 TimeEntryActivity.create!({:name => parent.name, :project_id => 1, :position => parent.position, :active => true})
Chris@1295 153 TimeEntry.create!({:project_id => 1, :hours => 1.0, :user => User.find(1), :issue_id => 3, :activity_id => 10, :spent_on => '2009-01-01'})
Chris@1295 154
Chris@1295 155 assert_equal 3, TimeEntry.find_all_by_activity_id_and_project_id(9, 1).size
Chris@1295 156 assert_equal 1, TimeEntry.find_all_by_activity_id_and_project_id(10, 1).size
Chris@1295 157
Chris@1295 158 @request.session[:user_id] = 2 # manager
Chris@1295 159 put :update, :project_id => 1, :enumerations => {
Chris@1295 160 "9"=> {"parent_id"=>"9", "custom_field_values"=>{"7" => "1"}, "active"=>"0"}, # Design
Chris@1295 161 "10"=> {"parent_id"=>"10", "custom_field_values"=>{"7"=>"0"}, "active"=>"1"} # Development, Change custom value
Chris@1295 162 }
Chris@1295 163 assert_response :redirect
Chris@1295 164
Chris@1295 165 # TimeEntries shouldn't have been reassigned on the failed record
Chris@1295 166 assert_equal 3, TimeEntry.find_all_by_activity_id_and_project_id(9, 1).size, "Time Entries are not assigned to system activities"
Chris@1295 167 # TimeEntries shouldn't have been reassigned on the saved record either
Chris@1295 168 assert_equal 1, TimeEntry.find_all_by_activity_id_and_project_id(10, 1).size, "Time Entries are not assigned to system activities"
Chris@1295 169 end
Chris@1295 170
Chris@1295 171 def test_destroy
Chris@1295 172 @request.session[:user_id] = 2 # manager
Chris@1295 173 project_activity = TimeEntryActivity.new({
Chris@1295 174 :name => 'Project Specific',
Chris@1295 175 :parent => TimeEntryActivity.first,
Chris@1295 176 :project => Project.find(1),
Chris@1295 177 :active => true
Chris@1295 178 })
Chris@1295 179 assert project_activity.save
Chris@1295 180 project_activity_two = TimeEntryActivity.new({
Chris@1295 181 :name => 'Project Specific Two',
Chris@1295 182 :parent => TimeEntryActivity.last,
Chris@1295 183 :project => Project.find(1),
Chris@1295 184 :active => true
Chris@1295 185 })
Chris@1295 186 assert project_activity_two.save
Chris@1295 187
Chris@1295 188 delete :destroy, :project_id => 1
Chris@1295 189 assert_response :redirect
Chris@1295 190 assert_redirected_to '/projects/ecookbook/settings/activities'
Chris@1295 191
Chris@1295 192 assert_nil TimeEntryActivity.find_by_id(project_activity.id)
Chris@1295 193 assert_nil TimeEntryActivity.find_by_id(project_activity_two.id)
Chris@1295 194 end
Chris@1295 195
Chris@1295 196 def test_destroy_should_reassign_time_entries_back_to_the_system_activity
Chris@1295 197 @request.session[:user_id] = 2 # manager
Chris@1295 198 project_activity = TimeEntryActivity.new({
Chris@1295 199 :name => 'Project Specific Design',
Chris@1295 200 :parent => TimeEntryActivity.find(9),
Chris@1295 201 :project => Project.find(1),
Chris@1295 202 :active => true
Chris@1295 203 })
Chris@1295 204 assert project_activity.save
Chris@1295 205 assert TimeEntry.update_all("activity_id = '#{project_activity.id}'", ["project_id = ? AND activity_id = ?", 1, 9])
Chris@1295 206 assert_equal 3, TimeEntry.find_all_by_activity_id_and_project_id(project_activity.id, 1).size
Chris@1295 207
Chris@1295 208 delete :destroy, :project_id => 1
Chris@1295 209 assert_response :redirect
Chris@1295 210 assert_redirected_to '/projects/ecookbook/settings/activities'
Chris@1295 211
Chris@1295 212 assert_nil TimeEntryActivity.find_by_id(project_activity.id)
Chris@1295 213 assert_equal 0, TimeEntry.find_all_by_activity_id_and_project_id(project_activity.id, 1).size, "TimeEntries still assigned to project specific activity"
Chris@1295 214 assert_equal 3, TimeEntry.find_all_by_activity_id_and_project_id(9, 1).size, "TimeEntries still assigned to project specific activity"
Chris@1295 215 end
Chris@1295 216
Chris@1295 217 end