annotate .svn/pristine/4b/4b6ad4ee97c77f142f2ea07d73404f963b296d82.svn-base @ 1298:4f746d8966dd redmine_2.3_integration

Merge from redmine-2.3 branch to create new branch redmine-2.3-integration
author Chris Cannam
date Fri, 14 Jun 2013 09:28:30 +0100
parents 622f24f53b42
children
rev   line source
Chris@1295 1 # Redmine - project management software
Chris@1295 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
Chris@1295 3 #
Chris@1295 4 # This program is free software; you can redistribute it and/or
Chris@1295 5 # modify it under the terms of the GNU General Public License
Chris@1295 6 # as published by the Free Software Foundation; either version 2
Chris@1295 7 # of the License, or (at your option) any later version.
Chris@1295 8 #
Chris@1295 9 # This program is distributed in the hope that it will be useful,
Chris@1295 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1295 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@1295 12 # GNU General Public License for more details.
Chris@1295 13 #
Chris@1295 14 # You should have received a copy of the GNU General Public License
Chris@1295 15 # along with this program; if not, write to the Free Software
Chris@1295 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@1295 17
Chris@1295 18 require File.expand_path('../../test_helper', __FILE__)
Chris@1295 19
Chris@1295 20 class IssueTest < ActiveSupport::TestCase
Chris@1295 21 fixtures :projects, :users, :members, :member_roles, :roles,
Chris@1295 22 :groups_users,
Chris@1295 23 :trackers, :projects_trackers,
Chris@1295 24 :enabled_modules,
Chris@1295 25 :versions,
Chris@1295 26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
Chris@1295 27 :enumerations,
Chris@1295 28 :issues, :journals, :journal_details,
Chris@1295 29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
Chris@1295 30 :time_entries
Chris@1295 31
Chris@1295 32 include Redmine::I18n
Chris@1295 33
Chris@1295 34 def teardown
Chris@1295 35 User.current = nil
Chris@1295 36 end
Chris@1295 37
Chris@1295 38 def test_create
Chris@1295 39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1295 40 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1295 41 :subject => 'test_create',
Chris@1295 42 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
Chris@1295 43 assert issue.save
Chris@1295 44 issue.reload
Chris@1295 45 assert_equal 1.5, issue.estimated_hours
Chris@1295 46 end
Chris@1295 47
Chris@1295 48 def test_create_minimal
Chris@1295 49 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1295 50 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1295 51 :subject => 'test_create')
Chris@1295 52 assert issue.save
Chris@1295 53 assert issue.description.nil?
Chris@1295 54 assert_nil issue.estimated_hours
Chris@1295 55 end
Chris@1295 56
Chris@1295 57 def test_start_date_format_should_be_validated
Chris@1295 58 set_language_if_valid 'en'
Chris@1295 59 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
Chris@1295 60 issue = Issue.new(:start_date => invalid_date)
Chris@1295 61 assert !issue.valid?
Chris@1295 62 assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
Chris@1295 63 end
Chris@1295 64 end
Chris@1295 65
Chris@1295 66 def test_due_date_format_should_be_validated
Chris@1295 67 set_language_if_valid 'en'
Chris@1295 68 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
Chris@1295 69 issue = Issue.new(:due_date => invalid_date)
Chris@1295 70 assert !issue.valid?
Chris@1295 71 assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
Chris@1295 72 end
Chris@1295 73 end
Chris@1295 74
Chris@1295 75 def test_due_date_lesser_than_start_date_should_not_validate
Chris@1295 76 set_language_if_valid 'en'
Chris@1295 77 issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
Chris@1295 78 assert !issue.valid?
Chris@1295 79 assert_include 'Due date must be greater than start date', issue.errors.full_messages
Chris@1295 80 end
Chris@1295 81
Chris@1295 82 def test_create_with_required_custom_field
Chris@1295 83 set_language_if_valid 'en'
Chris@1295 84 field = IssueCustomField.find_by_name('Database')
Chris@1295 85 field.update_attribute(:is_required, true)
Chris@1295 86
Chris@1295 87 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 88 :status_id => 1, :subject => 'test_create',
Chris@1295 89 :description => 'IssueTest#test_create_with_required_custom_field')
Chris@1295 90 assert issue.available_custom_fields.include?(field)
Chris@1295 91 # No value for the custom field
Chris@1295 92 assert !issue.save
Chris@1295 93 assert_equal ["Database can't be blank"], issue.errors.full_messages
Chris@1295 94 # Blank value
Chris@1295 95 issue.custom_field_values = { field.id => '' }
Chris@1295 96 assert !issue.save
Chris@1295 97 assert_equal ["Database can't be blank"], issue.errors.full_messages
Chris@1295 98 # Invalid value
Chris@1295 99 issue.custom_field_values = { field.id => 'SQLServer' }
Chris@1295 100 assert !issue.save
Chris@1295 101 assert_equal ["Database is not included in the list"], issue.errors.full_messages
Chris@1295 102 # Valid value
Chris@1295 103 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1295 104 assert issue.save
Chris@1295 105 issue.reload
Chris@1295 106 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
Chris@1295 107 end
Chris@1295 108
Chris@1295 109 def test_create_with_group_assignment
Chris@1295 110 with_settings :issue_group_assignment => '1' do
Chris@1295 111 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
Chris@1295 112 :subject => 'Group assignment',
Chris@1295 113 :assigned_to_id => 11).save
Chris@1295 114 issue = Issue.first(:order => 'id DESC')
Chris@1295 115 assert_kind_of Group, issue.assigned_to
Chris@1295 116 assert_equal Group.find(11), issue.assigned_to
Chris@1295 117 end
Chris@1295 118 end
Chris@1295 119
Chris@1295 120 def test_create_with_parent_issue_id
Chris@1295 121 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1295 122 :author_id => 1, :subject => 'Group assignment',
Chris@1295 123 :parent_issue_id => 1)
Chris@1295 124 assert_save issue
Chris@1295 125 assert_equal 1, issue.parent_issue_id
Chris@1295 126 assert_equal Issue.find(1), issue.parent
Chris@1295 127 end
Chris@1295 128
Chris@1295 129 def test_create_with_sharp_parent_issue_id
Chris@1295 130 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1295 131 :author_id => 1, :subject => 'Group assignment',
Chris@1295 132 :parent_issue_id => "#1")
Chris@1295 133 assert_save issue
Chris@1295 134 assert_equal 1, issue.parent_issue_id
Chris@1295 135 assert_equal Issue.find(1), issue.parent
Chris@1295 136 end
Chris@1295 137
Chris@1295 138 def test_create_with_invalid_parent_issue_id
Chris@1295 139 set_language_if_valid 'en'
Chris@1295 140 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1295 141 :author_id => 1, :subject => 'Group assignment',
Chris@1295 142 :parent_issue_id => '01ABC')
Chris@1295 143 assert !issue.save
Chris@1295 144 assert_equal '01ABC', issue.parent_issue_id
Chris@1295 145 assert_include 'Parent task is invalid', issue.errors.full_messages
Chris@1295 146 end
Chris@1295 147
Chris@1295 148 def test_create_with_invalid_sharp_parent_issue_id
Chris@1295 149 set_language_if_valid 'en'
Chris@1295 150 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1295 151 :author_id => 1, :subject => 'Group assignment',
Chris@1295 152 :parent_issue_id => '#01ABC')
Chris@1295 153 assert !issue.save
Chris@1295 154 assert_equal '#01ABC', issue.parent_issue_id
Chris@1295 155 assert_include 'Parent task is invalid', issue.errors.full_messages
Chris@1295 156 end
Chris@1295 157
Chris@1295 158 def assert_visibility_match(user, issues)
Chris@1295 159 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
Chris@1295 160 end
Chris@1295 161
Chris@1295 162 def test_visible_scope_for_anonymous
Chris@1295 163 # Anonymous user should see issues of public projects only
Chris@1295 164 issues = Issue.visible(User.anonymous).all
Chris@1295 165 assert issues.any?
Chris@1295 166 assert_nil issues.detect {|issue| !issue.project.is_public?}
Chris@1295 167 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1295 168 assert_visibility_match User.anonymous, issues
Chris@1295 169 end
Chris@1295 170
Chris@1295 171 def test_visible_scope_for_anonymous_without_view_issues_permissions
Chris@1295 172 # Anonymous user should not see issues without permission
Chris@1295 173 Role.anonymous.remove_permission!(:view_issues)
Chris@1295 174 issues = Issue.visible(User.anonymous).all
Chris@1295 175 assert issues.empty?
Chris@1295 176 assert_visibility_match User.anonymous, issues
Chris@1295 177 end
Chris@1295 178
Chris@1295 179 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
Chris@1295 180 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
Chris@1295 181 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
Chris@1295 182 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
Chris@1295 183 assert !issue.visible?(User.anonymous)
Chris@1295 184 end
Chris@1295 185
Chris@1295 186 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
Chris@1295 187 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
Chris@1295 188 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
Chris@1295 189 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
Chris@1295 190 assert !issue.visible?(User.anonymous)
Chris@1295 191 end
Chris@1295 192
Chris@1295 193 def test_visible_scope_for_non_member
Chris@1295 194 user = User.find(9)
Chris@1295 195 assert user.projects.empty?
Chris@1295 196 # Non member user should see issues of public projects only
Chris@1295 197 issues = Issue.visible(user).all
Chris@1295 198 assert issues.any?
Chris@1295 199 assert_nil issues.detect {|issue| !issue.project.is_public?}
Chris@1295 200 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1295 201 assert_visibility_match user, issues
Chris@1295 202 end
Chris@1295 203
Chris@1295 204 def test_visible_scope_for_non_member_with_own_issues_visibility
Chris@1295 205 Role.non_member.update_attribute :issues_visibility, 'own'
Chris@1295 206 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
Chris@1295 207 user = User.find(9)
Chris@1295 208
Chris@1295 209 issues = Issue.visible(user).all
Chris@1295 210 assert issues.any?
Chris@1295 211 assert_nil issues.detect {|issue| issue.author != user}
Chris@1295 212 assert_visibility_match user, issues
Chris@1295 213 end
Chris@1295 214
Chris@1295 215 def test_visible_scope_for_non_member_without_view_issues_permissions
Chris@1295 216 # Non member user should not see issues without permission
Chris@1295 217 Role.non_member.remove_permission!(:view_issues)
Chris@1295 218 user = User.find(9)
Chris@1295 219 assert user.projects.empty?
Chris@1295 220 issues = Issue.visible(user).all
Chris@1295 221 assert issues.empty?
Chris@1295 222 assert_visibility_match user, issues
Chris@1295 223 end
Chris@1295 224
Chris@1295 225 def test_visible_scope_for_member
Chris@1295 226 user = User.find(9)
Chris@1295 227 # User should see issues of projects for which he has view_issues permissions only
Chris@1295 228 Role.non_member.remove_permission!(:view_issues)
Chris@1295 229 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
Chris@1295 230 issues = Issue.visible(user).all
Chris@1295 231 assert issues.any?
Chris@1295 232 assert_nil issues.detect {|issue| issue.project_id != 3}
Chris@1295 233 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1295 234 assert_visibility_match user, issues
Chris@1295 235 end
Chris@1295 236
Chris@1295 237 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
Chris@1295 238 user = User.find(8)
Chris@1295 239 assert user.groups.any?
Chris@1295 240 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
Chris@1295 241 Role.non_member.remove_permission!(:view_issues)
Chris@1295 242
Chris@1295 243 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1295 244 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1295 245 :subject => 'Assignment test',
Chris@1295 246 :assigned_to => user.groups.first,
Chris@1295 247 :is_private => true)
Chris@1295 248
Chris@1295 249 Role.find(2).update_attribute :issues_visibility, 'default'
Chris@1295 250 issues = Issue.visible(User.find(8)).all
Chris@1295 251 assert issues.any?
Chris@1295 252 assert issues.include?(issue)
Chris@1295 253
Chris@1295 254 Role.find(2).update_attribute :issues_visibility, 'own'
Chris@1295 255 issues = Issue.visible(User.find(8)).all
Chris@1295 256 assert issues.any?
Chris@1295 257 assert issues.include?(issue)
Chris@1295 258 end
Chris@1295 259
Chris@1295 260 def test_visible_scope_for_admin
Chris@1295 261 user = User.find(1)
Chris@1295 262 user.members.each(&:destroy)
Chris@1295 263 assert user.projects.empty?
Chris@1295 264 issues = Issue.visible(user).all
Chris@1295 265 assert issues.any?
Chris@1295 266 # Admin should see issues on private projects that he does not belong to
Chris@1295 267 assert issues.detect {|issue| !issue.project.is_public?}
Chris@1295 268 # Admin should see private issues of other users
Chris@1295 269 assert issues.detect {|issue| issue.is_private? && issue.author != user}
Chris@1295 270 assert_visibility_match user, issues
Chris@1295 271 end
Chris@1295 272
Chris@1295 273 def test_visible_scope_with_project
Chris@1295 274 project = Project.find(1)
Chris@1295 275 issues = Issue.visible(User.find(2), :project => project).all
Chris@1295 276 projects = issues.collect(&:project).uniq
Chris@1295 277 assert_equal 1, projects.size
Chris@1295 278 assert_equal project, projects.first
Chris@1295 279 end
Chris@1295 280
Chris@1295 281 def test_visible_scope_with_project_and_subprojects
Chris@1295 282 project = Project.find(1)
Chris@1295 283 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
Chris@1295 284 projects = issues.collect(&:project).uniq
Chris@1295 285 assert projects.size > 1
Chris@1295 286 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
Chris@1295 287 end
Chris@1295 288
Chris@1295 289 def test_visible_and_nested_set_scopes
Chris@1295 290 assert_equal 0, Issue.find(1).descendants.visible.all.size
Chris@1295 291 end
Chris@1295 292
Chris@1295 293 def test_open_scope
Chris@1295 294 issues = Issue.open.all
Chris@1295 295 assert_nil issues.detect(&:closed?)
Chris@1295 296 end
Chris@1295 297
Chris@1295 298 def test_open_scope_with_arg
Chris@1295 299 issues = Issue.open(false).all
Chris@1295 300 assert_equal issues, issues.select(&:closed?)
Chris@1295 301 end
Chris@1295 302
Chris@1295 303 def test_errors_full_messages_should_include_custom_fields_errors
Chris@1295 304 field = IssueCustomField.find_by_name('Database')
Chris@1295 305
Chris@1295 306 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 307 :status_id => 1, :subject => 'test_create',
Chris@1295 308 :description => 'IssueTest#test_create_with_required_custom_field')
Chris@1295 309 assert issue.available_custom_fields.include?(field)
Chris@1295 310 # Invalid value
Chris@1295 311 issue.custom_field_values = { field.id => 'SQLServer' }
Chris@1295 312
Chris@1295 313 assert !issue.valid?
Chris@1295 314 assert_equal 1, issue.errors.full_messages.size
Chris@1295 315 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
Chris@1295 316 issue.errors.full_messages.first
Chris@1295 317 end
Chris@1295 318
Chris@1295 319 def test_update_issue_with_required_custom_field
Chris@1295 320 field = IssueCustomField.find_by_name('Database')
Chris@1295 321 field.update_attribute(:is_required, true)
Chris@1295 322
Chris@1295 323 issue = Issue.find(1)
Chris@1295 324 assert_nil issue.custom_value_for(field)
Chris@1295 325 assert issue.available_custom_fields.include?(field)
Chris@1295 326 # No change to custom values, issue can be saved
Chris@1295 327 assert issue.save
Chris@1295 328 # Blank value
Chris@1295 329 issue.custom_field_values = { field.id => '' }
Chris@1295 330 assert !issue.save
Chris@1295 331 # Valid value
Chris@1295 332 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1295 333 assert issue.save
Chris@1295 334 issue.reload
Chris@1295 335 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
Chris@1295 336 end
Chris@1295 337
Chris@1295 338 def test_should_not_update_attributes_if_custom_fields_validation_fails
Chris@1295 339 issue = Issue.find(1)
Chris@1295 340 field = IssueCustomField.find_by_name('Database')
Chris@1295 341 assert issue.available_custom_fields.include?(field)
Chris@1295 342
Chris@1295 343 issue.custom_field_values = { field.id => 'Invalid' }
Chris@1295 344 issue.subject = 'Should be not be saved'
Chris@1295 345 assert !issue.save
Chris@1295 346
Chris@1295 347 issue.reload
Chris@1295 348 assert_equal "Can't print recipes", issue.subject
Chris@1295 349 end
Chris@1295 350
Chris@1295 351 def test_should_not_recreate_custom_values_objects_on_update
Chris@1295 352 field = IssueCustomField.find_by_name('Database')
Chris@1295 353
Chris@1295 354 issue = Issue.find(1)
Chris@1295 355 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1295 356 assert issue.save
Chris@1295 357 custom_value = issue.custom_value_for(field)
Chris@1295 358 issue.reload
Chris@1295 359 issue.custom_field_values = { field.id => 'MySQL' }
Chris@1295 360 assert issue.save
Chris@1295 361 issue.reload
Chris@1295 362 assert_equal custom_value.id, issue.custom_value_for(field).id
Chris@1295 363 end
Chris@1295 364
Chris@1295 365 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
Chris@1295 366 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 367 :status_id => 1, :subject => 'Test',
Chris@1295 368 :custom_field_values => {'2' => 'Test'})
Chris@1295 369 assert !Tracker.find(2).custom_field_ids.include?(2)
Chris@1295 370
Chris@1295 371 issue = Issue.find(issue.id)
Chris@1295 372 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
Chris@1295 373
Chris@1295 374 issue = Issue.find(issue.id)
Chris@1295 375 custom_value = issue.custom_value_for(2)
Chris@1295 376 assert_not_nil custom_value
Chris@1295 377 assert_equal 'Test', custom_value.value
Chris@1295 378 end
Chris@1295 379
Chris@1295 380 def test_assigning_tracker_id_should_reload_custom_fields_values
Chris@1295 381 issue = Issue.new(:project => Project.find(1))
Chris@1295 382 assert issue.custom_field_values.empty?
Chris@1295 383 issue.tracker_id = 1
Chris@1295 384 assert issue.custom_field_values.any?
Chris@1295 385 end
Chris@1295 386
Chris@1295 387 def test_assigning_attributes_should_assign_project_and_tracker_first
Chris@1295 388 seq = sequence('seq')
Chris@1295 389 issue = Issue.new
Chris@1295 390 issue.expects(:project_id=).in_sequence(seq)
Chris@1295 391 issue.expects(:tracker_id=).in_sequence(seq)
Chris@1295 392 issue.expects(:subject=).in_sequence(seq)
Chris@1295 393 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
Chris@1295 394 end
Chris@1295 395
Chris@1295 396 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
Chris@1295 397 attributes = ActiveSupport::OrderedHash.new
Chris@1295 398 attributes['custom_field_values'] = { '1' => 'MySQL' }
Chris@1295 399 attributes['tracker_id'] = '1'
Chris@1295 400 issue = Issue.new(:project => Project.find(1))
Chris@1295 401 issue.attributes = attributes
Chris@1295 402 assert_equal 'MySQL', issue.custom_field_value(1)
Chris@1295 403 end
Chris@1295 404
Chris@1295 405 def test_should_update_issue_with_disabled_tracker
Chris@1295 406 p = Project.find(1)
Chris@1295 407 issue = Issue.find(1)
Chris@1295 408
Chris@1295 409 p.trackers.delete(issue.tracker)
Chris@1295 410 assert !p.trackers.include?(issue.tracker)
Chris@1295 411
Chris@1295 412 issue.reload
Chris@1295 413 issue.subject = 'New subject'
Chris@1295 414 assert issue.save
Chris@1295 415 end
Chris@1295 416
Chris@1295 417 def test_should_not_set_a_disabled_tracker
Chris@1295 418 p = Project.find(1)
Chris@1295 419 p.trackers.delete(Tracker.find(2))
Chris@1295 420
Chris@1295 421 issue = Issue.find(1)
Chris@1295 422 issue.tracker_id = 2
Chris@1295 423 issue.subject = 'New subject'
Chris@1295 424 assert !issue.save
Chris@1295 425 assert_not_nil issue.errors[:tracker_id]
Chris@1295 426 end
Chris@1295 427
Chris@1295 428 def test_category_based_assignment
Chris@1295 429 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1295 430 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1295 431 :subject => 'Assignment test',
Chris@1295 432 :description => 'Assignment test', :category_id => 1)
Chris@1295 433 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
Chris@1295 434 end
Chris@1295 435
Chris@1295 436 def test_new_statuses_allowed_to
Chris@1295 437 WorkflowTransition.delete_all
Chris@1295 438 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1295 439 :old_status_id => 1, :new_status_id => 2,
Chris@1295 440 :author => false, :assignee => false)
Chris@1295 441 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1295 442 :old_status_id => 1, :new_status_id => 3,
Chris@1295 443 :author => true, :assignee => false)
Chris@1295 444 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
Chris@1295 445 :new_status_id => 4, :author => false,
Chris@1295 446 :assignee => true)
Chris@1295 447 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1295 448 :old_status_id => 1, :new_status_id => 5,
Chris@1295 449 :author => true, :assignee => true)
Chris@1295 450 status = IssueStatus.find(1)
Chris@1295 451 role = Role.find(1)
Chris@1295 452 tracker = Tracker.find(1)
Chris@1295 453 user = User.find(2)
Chris@1295 454
Chris@1295 455 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1295 456 :project_id => 1, :author_id => 1)
Chris@1295 457 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1295 458
Chris@1295 459 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1295 460 :project_id => 1, :author => user)
Chris@1295 461 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1295 462
Chris@1295 463 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1295 464 :project_id => 1, :author_id => 1,
Chris@1295 465 :assigned_to => user)
Chris@1295 466 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1295 467
Chris@1295 468 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1295 469 :project_id => 1, :author => user,
Chris@1295 470 :assigned_to => user)
Chris@1295 471 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1295 472 end
Chris@1295 473
Chris@1295 474 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
Chris@1295 475 admin = User.find(1)
Chris@1295 476 issue = Issue.find(1)
Chris@1295 477 assert !admin.member_of?(issue.project)
Chris@1295 478 expected_statuses = [issue.status] +
Chris@1295 479 WorkflowTransition.find_all_by_old_status_id(
Chris@1295 480 issue.status_id).map(&:new_status).uniq.sort
Chris@1295 481 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
Chris@1295 482 end
Chris@1295 483
Chris@1295 484 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
Chris@1295 485 issue = Issue.find(1).copy
Chris@1295 486 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
Chris@1295 487
Chris@1295 488 issue = Issue.find(2).copy
Chris@1295 489 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
Chris@1295 490 end
Chris@1295 491
Chris@1295 492 def test_safe_attributes_names_should_not_include_disabled_field
Chris@1295 493 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
Chris@1295 494
Chris@1295 495 issue = Issue.new(:tracker => tracker)
Chris@1295 496 assert_include 'tracker_id', issue.safe_attribute_names
Chris@1295 497 assert_include 'status_id', issue.safe_attribute_names
Chris@1295 498 assert_include 'subject', issue.safe_attribute_names
Chris@1295 499 assert_include 'description', issue.safe_attribute_names
Chris@1295 500 assert_include 'custom_field_values', issue.safe_attribute_names
Chris@1295 501 assert_include 'custom_fields', issue.safe_attribute_names
Chris@1295 502 assert_include 'lock_version', issue.safe_attribute_names
Chris@1295 503
Chris@1295 504 tracker.core_fields.each do |field|
Chris@1295 505 assert_include field, issue.safe_attribute_names
Chris@1295 506 end
Chris@1295 507
Chris@1295 508 tracker.disabled_core_fields.each do |field|
Chris@1295 509 assert_not_include field, issue.safe_attribute_names
Chris@1295 510 end
Chris@1295 511 end
Chris@1295 512
Chris@1295 513 def test_safe_attributes_should_ignore_disabled_fields
Chris@1295 514 tracker = Tracker.find(1)
Chris@1295 515 tracker.core_fields = %w(assigned_to_id due_date)
Chris@1295 516 tracker.save!
Chris@1295 517
Chris@1295 518 issue = Issue.new(:tracker => tracker)
Chris@1295 519 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
Chris@1295 520 assert_nil issue.start_date
Chris@1295 521 assert_equal Date.parse('2012-07-14'), issue.due_date
Chris@1295 522 end
Chris@1295 523
Chris@1295 524 def test_safe_attributes_should_accept_target_tracker_enabled_fields
Chris@1295 525 source = Tracker.find(1)
Chris@1295 526 source.core_fields = []
Chris@1295 527 source.save!
Chris@1295 528 target = Tracker.find(2)
Chris@1295 529 target.core_fields = %w(assigned_to_id due_date)
Chris@1295 530 target.save!
Chris@1295 531
Chris@1295 532 issue = Issue.new(:tracker => source)
Chris@1295 533 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
Chris@1295 534 assert_equal target, issue.tracker
Chris@1295 535 assert_equal Date.parse('2012-07-14'), issue.due_date
Chris@1295 536 end
Chris@1295 537
Chris@1295 538 def test_safe_attributes_should_not_include_readonly_fields
Chris@1295 539 WorkflowPermission.delete_all
Chris@1295 540 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 541 :role_id => 1, :field_name => 'due_date',
Chris@1295 542 :rule => 'readonly')
Chris@1295 543 user = User.find(2)
Chris@1295 544
Chris@1295 545 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1295 546 assert_equal %w(due_date), issue.read_only_attribute_names(user)
Chris@1295 547 assert_not_include 'due_date', issue.safe_attribute_names(user)
Chris@1295 548
Chris@1295 549 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
Chris@1295 550 assert_equal Date.parse('2012-07-14'), issue.start_date
Chris@1295 551 assert_nil issue.due_date
Chris@1295 552 end
Chris@1295 553
Chris@1295 554 def test_safe_attributes_should_not_include_readonly_custom_fields
Chris@1295 555 cf1 = IssueCustomField.create!(:name => 'Writable field',
Chris@1295 556 :field_format => 'string',
Chris@1295 557 :is_for_all => true, :tracker_ids => [1])
Chris@1295 558 cf2 = IssueCustomField.create!(:name => 'Readonly field',
Chris@1295 559 :field_format => 'string',
Chris@1295 560 :is_for_all => true, :tracker_ids => [1])
Chris@1295 561 WorkflowPermission.delete_all
Chris@1295 562 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 563 :role_id => 1, :field_name => cf2.id.to_s,
Chris@1295 564 :rule => 'readonly')
Chris@1295 565 user = User.find(2)
Chris@1295 566 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1295 567 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
Chris@1295 568 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
Chris@1295 569
Chris@1295 570 issue.send :safe_attributes=, {'custom_field_values' => {
Chris@1295 571 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
Chris@1295 572 }}, user
Chris@1295 573 assert_equal 'value1', issue.custom_field_value(cf1)
Chris@1295 574 assert_nil issue.custom_field_value(cf2)
Chris@1295 575
Chris@1295 576 issue.send :safe_attributes=, {'custom_fields' => [
Chris@1295 577 {'id' => cf1.id.to_s, 'value' => 'valuea'},
Chris@1295 578 {'id' => cf2.id.to_s, 'value' => 'valueb'}
Chris@1295 579 ]}, user
Chris@1295 580 assert_equal 'valuea', issue.custom_field_value(cf1)
Chris@1295 581 assert_nil issue.custom_field_value(cf2)
Chris@1295 582 end
Chris@1295 583
Chris@1295 584 def test_editable_custom_field_values_should_return_non_readonly_custom_values
Chris@1295 585 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
Chris@1295 586 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1295 587 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
Chris@1295 588 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1295 589 WorkflowPermission.delete_all
Chris@1295 590 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
Chris@1295 591 :field_name => cf2.id.to_s, :rule => 'readonly')
Chris@1295 592 user = User.find(2)
Chris@1295 593
Chris@1295 594 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1295 595 values = issue.editable_custom_field_values(user)
Chris@1295 596 assert values.detect {|value| value.custom_field == cf1}
Chris@1295 597 assert_nil values.detect {|value| value.custom_field == cf2}
Chris@1295 598
Chris@1295 599 issue.tracker_id = 2
Chris@1295 600 values = issue.editable_custom_field_values(user)
Chris@1295 601 assert values.detect {|value| value.custom_field == cf1}
Chris@1295 602 assert values.detect {|value| value.custom_field == cf2}
Chris@1295 603 end
Chris@1295 604
Chris@1295 605 def test_safe_attributes_should_accept_target_tracker_writable_fields
Chris@1295 606 WorkflowPermission.delete_all
Chris@1295 607 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 608 :role_id => 1, :field_name => 'due_date',
Chris@1295 609 :rule => 'readonly')
Chris@1295 610 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1295 611 :role_id => 1, :field_name => 'start_date',
Chris@1295 612 :rule => 'readonly')
Chris@1295 613 user = User.find(2)
Chris@1295 614
Chris@1295 615 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1295 616
Chris@1295 617 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
Chris@1295 618 'due_date' => '2012-07-14'}, user
Chris@1295 619 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1295 620 assert_nil issue.due_date
Chris@1295 621
Chris@1295 622 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
Chris@1295 623 'due_date' => '2012-07-16',
Chris@1295 624 'tracker_id' => 2}, user
Chris@1295 625 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1295 626 assert_equal Date.parse('2012-07-16'), issue.due_date
Chris@1295 627 end
Chris@1295 628
Chris@1295 629 def test_safe_attributes_should_accept_target_status_writable_fields
Chris@1295 630 WorkflowPermission.delete_all
Chris@1295 631 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 632 :role_id => 1, :field_name => 'due_date',
Chris@1295 633 :rule => 'readonly')
Chris@1295 634 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
Chris@1295 635 :role_id => 1, :field_name => 'start_date',
Chris@1295 636 :rule => 'readonly')
Chris@1295 637 user = User.find(2)
Chris@1295 638
Chris@1295 639 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1295 640
Chris@1295 641 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
Chris@1295 642 'due_date' => '2012-07-14'},
Chris@1295 643 user
Chris@1295 644 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1295 645 assert_nil issue.due_date
Chris@1295 646
Chris@1295 647 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
Chris@1295 648 'due_date' => '2012-07-16',
Chris@1295 649 'status_id' => 2},
Chris@1295 650 user
Chris@1295 651 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1295 652 assert_equal Date.parse('2012-07-16'), issue.due_date
Chris@1295 653 end
Chris@1295 654
Chris@1295 655 def test_required_attributes_should_be_validated
Chris@1295 656 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
Chris@1295 657 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1295 658
Chris@1295 659 WorkflowPermission.delete_all
Chris@1295 660 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 661 :role_id => 1, :field_name => 'due_date',
Chris@1295 662 :rule => 'required')
Chris@1295 663 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 664 :role_id => 1, :field_name => 'category_id',
Chris@1295 665 :rule => 'required')
Chris@1295 666 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 667 :role_id => 1, :field_name => cf.id.to_s,
Chris@1295 668 :rule => 'required')
Chris@1295 669
Chris@1295 670 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1295 671 :role_id => 1, :field_name => 'start_date',
Chris@1295 672 :rule => 'required')
Chris@1295 673 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1295 674 :role_id => 1, :field_name => cf.id.to_s,
Chris@1295 675 :rule => 'required')
Chris@1295 676 user = User.find(2)
Chris@1295 677
Chris@1295 678 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1295 679 :status_id => 1, :subject => 'Required fields',
Chris@1295 680 :author => user)
Chris@1295 681 assert_equal [cf.id.to_s, "category_id", "due_date"],
Chris@1295 682 issue.required_attribute_names(user).sort
Chris@1295 683 assert !issue.save, "Issue was saved"
Chris@1295 684 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
Chris@1295 685 issue.errors.full_messages.sort
Chris@1295 686
Chris@1295 687 issue.tracker_id = 2
Chris@1295 688 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
Chris@1295 689 assert !issue.save, "Issue was saved"
Chris@1295 690 assert_equal ["Foo can't be blank", "Start date can't be blank"],
Chris@1295 691 issue.errors.full_messages.sort
Chris@1295 692
Chris@1295 693 issue.start_date = Date.today
Chris@1295 694 issue.custom_field_values = {cf.id.to_s => 'bar'}
Chris@1295 695 assert issue.save
Chris@1295 696 end
Chris@1295 697
Chris@1295 698 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
Chris@1295 699 WorkflowPermission.delete_all
Chris@1295 700 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 701 :role_id => 1, :field_name => 'due_date',
Chris@1295 702 :rule => 'required')
Chris@1295 703 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 704 :role_id => 1, :field_name => 'start_date',
Chris@1295 705 :rule => 'required')
Chris@1295 706 user = User.find(2)
Chris@1295 707 member = Member.find(1)
Chris@1295 708 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1295 709
Chris@1295 710 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
Chris@1295 711
Chris@1295 712 member.role_ids = [1, 2]
Chris@1295 713 member.save!
Chris@1295 714 assert_equal [], issue.required_attribute_names(user.reload)
Chris@1295 715
Chris@1295 716 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 717 :role_id => 2, :field_name => 'due_date',
Chris@1295 718 :rule => 'required')
Chris@1295 719 assert_equal %w(due_date), issue.required_attribute_names(user)
Chris@1295 720
Chris@1295 721 member.role_ids = [1, 2, 3]
Chris@1295 722 member.save!
Chris@1295 723 assert_equal [], issue.required_attribute_names(user.reload)
Chris@1295 724
Chris@1295 725 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 726 :role_id => 2, :field_name => 'due_date',
Chris@1295 727 :rule => 'readonly')
Chris@1295 728 # required + readonly => required
Chris@1295 729 assert_equal %w(due_date), issue.required_attribute_names(user)
Chris@1295 730 end
Chris@1295 731
Chris@1295 732 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
Chris@1295 733 WorkflowPermission.delete_all
Chris@1295 734 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 735 :role_id => 1, :field_name => 'due_date',
Chris@1295 736 :rule => 'readonly')
Chris@1295 737 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 738 :role_id => 1, :field_name => 'start_date',
Chris@1295 739 :rule => 'readonly')
Chris@1295 740 user = User.find(2)
Chris@1295 741 member = Member.find(1)
Chris@1295 742 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1295 743
Chris@1295 744 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
Chris@1295 745
Chris@1295 746 member.role_ids = [1, 2]
Chris@1295 747 member.save!
Chris@1295 748 assert_equal [], issue.read_only_attribute_names(user.reload)
Chris@1295 749
Chris@1295 750 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1295 751 :role_id => 2, :field_name => 'due_date',
Chris@1295 752 :rule => 'readonly')
Chris@1295 753 assert_equal %w(due_date), issue.read_only_attribute_names(user)
Chris@1295 754 end
Chris@1295 755
Chris@1295 756 def test_copy
Chris@1295 757 issue = Issue.new.copy_from(1)
Chris@1295 758 assert issue.copy?
Chris@1295 759 assert issue.save
Chris@1295 760 issue.reload
Chris@1295 761 orig = Issue.find(1)
Chris@1295 762 assert_equal orig.subject, issue.subject
Chris@1295 763 assert_equal orig.tracker, issue.tracker
Chris@1295 764 assert_equal "125", issue.custom_value_for(2).value
Chris@1295 765 end
Chris@1295 766
Chris@1295 767 def test_copy_should_copy_status
Chris@1295 768 orig = Issue.find(8)
Chris@1295 769 assert orig.status != IssueStatus.default
Chris@1295 770
Chris@1295 771 issue = Issue.new.copy_from(orig)
Chris@1295 772 assert issue.save
Chris@1295 773 issue.reload
Chris@1295 774 assert_equal orig.status, issue.status
Chris@1295 775 end
Chris@1295 776
Chris@1295 777 def test_copy_should_add_relation_with_copied_issue
Chris@1295 778 copied = Issue.find(1)
Chris@1295 779 issue = Issue.new.copy_from(copied)
Chris@1295 780 assert issue.save
Chris@1295 781 issue.reload
Chris@1295 782
Chris@1295 783 assert_equal 1, issue.relations.size
Chris@1295 784 relation = issue.relations.first
Chris@1295 785 assert_equal 'copied_to', relation.relation_type
Chris@1295 786 assert_equal copied, relation.issue_from
Chris@1295 787 assert_equal issue, relation.issue_to
Chris@1295 788 end
Chris@1295 789
Chris@1295 790 def test_copy_should_copy_subtasks
Chris@1295 791 issue = Issue.generate_with_descendants!
Chris@1295 792
Chris@1295 793 copy = issue.reload.copy
Chris@1295 794 copy.author = User.find(7)
Chris@1295 795 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1295 796 assert copy.save
Chris@1295 797 end
Chris@1295 798 copy.reload
Chris@1295 799 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
Chris@1295 800 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
Chris@1295 801 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
Chris@1295 802 assert_equal copy.author, child_copy.author
Chris@1295 803 end
Chris@1295 804
Chris@1295 805 def test_copy_should_copy_subtasks_to_target_project
Chris@1295 806 issue = Issue.generate_with_descendants!
Chris@1295 807
Chris@1295 808 copy = issue.copy(:project_id => 3)
Chris@1295 809 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1295 810 assert copy.save
Chris@1295 811 end
Chris@1295 812 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
Chris@1295 813 end
Chris@1295 814
Chris@1295 815 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
Chris@1295 816 issue = Issue.generate_with_descendants!
Chris@1295 817
Chris@1295 818 copy = issue.reload.copy
Chris@1295 819 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1295 820 assert copy.save
Chris@1295 821 assert copy.save
Chris@1295 822 end
Chris@1295 823 end
Chris@1295 824
Chris@1295 825 def test_should_not_call_after_project_change_on_creation
Chris@1295 826 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
Chris@1295 827 :subject => 'Test', :author_id => 1)
Chris@1295 828 issue.expects(:after_project_change).never
Chris@1295 829 issue.save!
Chris@1295 830 end
Chris@1295 831
Chris@1295 832 def test_should_not_call_after_project_change_on_update
Chris@1295 833 issue = Issue.find(1)
Chris@1295 834 issue.project = Project.find(1)
Chris@1295 835 issue.subject = 'No project change'
Chris@1295 836 issue.expects(:after_project_change).never
Chris@1295 837 issue.save!
Chris@1295 838 end
Chris@1295 839
Chris@1295 840 def test_should_call_after_project_change_on_project_change
Chris@1295 841 issue = Issue.find(1)
Chris@1295 842 issue.project = Project.find(2)
Chris@1295 843 issue.expects(:after_project_change).once
Chris@1295 844 issue.save!
Chris@1295 845 end
Chris@1295 846
Chris@1295 847 def test_adding_journal_should_update_timestamp
Chris@1295 848 issue = Issue.find(1)
Chris@1295 849 updated_on_was = issue.updated_on
Chris@1295 850
Chris@1295 851 issue.init_journal(User.first, "Adding notes")
Chris@1295 852 assert_difference 'Journal.count' do
Chris@1295 853 assert issue.save
Chris@1295 854 end
Chris@1295 855 issue.reload
Chris@1295 856
Chris@1295 857 assert_not_equal updated_on_was, issue.updated_on
Chris@1295 858 end
Chris@1295 859
Chris@1295 860 def test_should_close_duplicates
Chris@1295 861 # Create 3 issues
Chris@1295 862 issue1 = Issue.generate!
Chris@1295 863 issue2 = Issue.generate!
Chris@1295 864 issue3 = Issue.generate!
Chris@1295 865
Chris@1295 866 # 2 is a dupe of 1
Chris@1295 867 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
Chris@1295 868 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1295 869 # And 3 is a dupe of 2
Chris@1295 870 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
Chris@1295 871 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1295 872 # And 3 is a dupe of 1 (circular duplicates)
Chris@1295 873 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
Chris@1295 874 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1295 875
Chris@1295 876 assert issue1.reload.duplicates.include?(issue2)
Chris@1295 877
Chris@1295 878 # Closing issue 1
Chris@1295 879 issue1.init_journal(User.find(:first), "Closing issue1")
Chris@1295 880 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
Chris@1295 881 assert issue1.save
Chris@1295 882 # 2 and 3 should be also closed
Chris@1295 883 assert issue2.reload.closed?
Chris@1295 884 assert issue3.reload.closed?
Chris@1295 885 end
Chris@1295 886
Chris@1295 887 def test_should_not_close_duplicated_issue
Chris@1295 888 issue1 = Issue.generate!
Chris@1295 889 issue2 = Issue.generate!
Chris@1295 890
Chris@1295 891 # 2 is a dupe of 1
Chris@1295 892 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
Chris@1295 893 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1295 894 # 2 is a dup of 1 but 1 is not a duplicate of 2
Chris@1295 895 assert !issue2.reload.duplicates.include?(issue1)
Chris@1295 896
Chris@1295 897 # Closing issue 2
Chris@1295 898 issue2.init_journal(User.find(:first), "Closing issue2")
Chris@1295 899 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
Chris@1295 900 assert issue2.save
Chris@1295 901 # 1 should not be also closed
Chris@1295 902 assert !issue1.reload.closed?
Chris@1295 903 end
Chris@1295 904
Chris@1295 905 def test_assignable_versions
Chris@1295 906 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 907 :status_id => 1, :fixed_version_id => 1,
Chris@1295 908 :subject => 'New issue')
Chris@1295 909 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
Chris@1295 910 end
Chris@1295 911
Chris@1295 912 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
Chris@1295 913 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 914 :status_id => 1, :fixed_version_id => 1,
Chris@1295 915 :subject => 'New issue')
Chris@1295 916 assert !issue.save
Chris@1295 917 assert_not_nil issue.errors[:fixed_version_id]
Chris@1295 918 end
Chris@1295 919
Chris@1295 920 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
Chris@1295 921 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 922 :status_id => 1, :fixed_version_id => 2,
Chris@1295 923 :subject => 'New issue')
Chris@1295 924 assert !issue.save
Chris@1295 925 assert_not_nil issue.errors[:fixed_version_id]
Chris@1295 926 end
Chris@1295 927
Chris@1295 928 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
Chris@1295 929 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1295 930 :status_id => 1, :fixed_version_id => 3,
Chris@1295 931 :subject => 'New issue')
Chris@1295 932 assert issue.save
Chris@1295 933 end
Chris@1295 934
Chris@1295 935 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
Chris@1295 936 issue = Issue.find(11)
Chris@1295 937 assert_equal 'closed', issue.fixed_version.status
Chris@1295 938 issue.subject = 'Subject changed'
Chris@1295 939 assert issue.save
Chris@1295 940 end
Chris@1295 941
Chris@1295 942 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
Chris@1295 943 issue = Issue.find(11)
Chris@1295 944 issue.status_id = 1
Chris@1295 945 assert !issue.save
Chris@1295 946 assert_not_nil issue.errors[:base]
Chris@1295 947 end
Chris@1295 948
Chris@1295 949 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
Chris@1295 950 issue = Issue.find(11)
Chris@1295 951 issue.status_id = 1
Chris@1295 952 issue.fixed_version_id = 3
Chris@1295 953 assert issue.save
Chris@1295 954 end
Chris@1295 955
Chris@1295 956 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
Chris@1295 957 issue = Issue.find(12)
Chris@1295 958 assert_equal 'locked', issue.fixed_version.status
Chris@1295 959 issue.status_id = 1
Chris@1295 960 assert issue.save
Chris@1295 961 end
Chris@1295 962
Chris@1295 963 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
Chris@1295 964 issue = Issue.find(2)
Chris@1295 965 assert_equal 2, issue.fixed_version_id
Chris@1295 966 issue.project_id = 3
Chris@1295 967 assert_nil issue.fixed_version_id
Chris@1295 968 issue.fixed_version_id = 2
Chris@1295 969 assert !issue.save
Chris@1295 970 assert_include 'Target version is not included in the list', issue.errors.full_messages
Chris@1295 971 end
Chris@1295 972
Chris@1295 973 def test_should_keep_shared_version_when_changing_project
Chris@1295 974 Version.find(2).update_attribute :sharing, 'tree'
Chris@1295 975
Chris@1295 976 issue = Issue.find(2)
Chris@1295 977 assert_equal 2, issue.fixed_version_id
Chris@1295 978 issue.project_id = 3
Chris@1295 979 assert_equal 2, issue.fixed_version_id
Chris@1295 980 assert issue.save
Chris@1295 981 end
Chris@1295 982
Chris@1295 983 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
Chris@1295 984 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
Chris@1295 985 end
Chris@1295 986
Chris@1295 987 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
Chris@1295 988 Project.find(2).disable_module! :issue_tracking
Chris@1295 989 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
Chris@1295 990 end
Chris@1295 991
Chris@1295 992 def test_move_to_another_project_with_same_category
Chris@1295 993 issue = Issue.find(1)
Chris@1295 994 issue.project = Project.find(2)
Chris@1295 995 assert issue.save
Chris@1295 996 issue.reload
Chris@1295 997 assert_equal 2, issue.project_id
Chris@1295 998 # Category changes
Chris@1295 999 assert_equal 4, issue.category_id
Chris@1295 1000 # Make sure time entries were move to the target project
Chris@1295 1001 assert_equal 2, issue.time_entries.first.project_id
Chris@1295 1002 end
Chris@1295 1003
Chris@1295 1004 def test_move_to_another_project_without_same_category
Chris@1295 1005 issue = Issue.find(2)
Chris@1295 1006 issue.project = Project.find(2)
Chris@1295 1007 assert issue.save
Chris@1295 1008 issue.reload
Chris@1295 1009 assert_equal 2, issue.project_id
Chris@1295 1010 # Category cleared
Chris@1295 1011 assert_nil issue.category_id
Chris@1295 1012 end
Chris@1295 1013
Chris@1295 1014 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
Chris@1295 1015 issue = Issue.find(1)
Chris@1295 1016 issue.update_attribute(:fixed_version_id, 1)
Chris@1295 1017 issue.project = Project.find(2)
Chris@1295 1018 assert issue.save
Chris@1295 1019 issue.reload
Chris@1295 1020 assert_equal 2, issue.project_id
Chris@1295 1021 # Cleared fixed_version
Chris@1295 1022 assert_equal nil, issue.fixed_version
Chris@1295 1023 end
Chris@1295 1024
Chris@1295 1025 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
Chris@1295 1026 issue = Issue.find(1)
Chris@1295 1027 issue.update_attribute(:fixed_version_id, 4)
Chris@1295 1028 issue.project = Project.find(5)
Chris@1295 1029 assert issue.save
Chris@1295 1030 issue.reload
Chris@1295 1031 assert_equal 5, issue.project_id
Chris@1295 1032 # Keep fixed_version
Chris@1295 1033 assert_equal 4, issue.fixed_version_id
Chris@1295 1034 end
Chris@1295 1035
Chris@1295 1036 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
Chris@1295 1037 issue = Issue.find(1)
Chris@1295 1038 issue.update_attribute(:fixed_version_id, 1)
Chris@1295 1039 issue.project = Project.find(5)
Chris@1295 1040 assert issue.save
Chris@1295 1041 issue.reload
Chris@1295 1042 assert_equal 5, issue.project_id
Chris@1295 1043 # Cleared fixed_version
Chris@1295 1044 assert_equal nil, issue.fixed_version
Chris@1295 1045 end
Chris@1295 1046
Chris@1295 1047 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
Chris@1295 1048 issue = Issue.find(1)
Chris@1295 1049 issue.update_attribute(:fixed_version_id, 7)
Chris@1295 1050 issue.project = Project.find(2)
Chris@1295 1051 assert issue.save
Chris@1295 1052 issue.reload
Chris@1295 1053 assert_equal 2, issue.project_id
Chris@1295 1054 # Keep fixed_version
Chris@1295 1055 assert_equal 7, issue.fixed_version_id
Chris@1295 1056 end
Chris@1295 1057
Chris@1295 1058 def test_move_to_another_project_should_keep_parent_if_valid
Chris@1295 1059 issue = Issue.find(1)
Chris@1295 1060 issue.update_attribute(:parent_issue_id, 2)
Chris@1295 1061 issue.project = Project.find(3)
Chris@1295 1062 assert issue.save
Chris@1295 1063 issue.reload
Chris@1295 1064 assert_equal 2, issue.parent_id
Chris@1295 1065 end
Chris@1295 1066
Chris@1295 1067 def test_move_to_another_project_should_clear_parent_if_not_valid
Chris@1295 1068 issue = Issue.find(1)
Chris@1295 1069 issue.update_attribute(:parent_issue_id, 2)
Chris@1295 1070 issue.project = Project.find(2)
Chris@1295 1071 assert issue.save
Chris@1295 1072 issue.reload
Chris@1295 1073 assert_nil issue.parent_id
Chris@1295 1074 end
Chris@1295 1075
Chris@1295 1076 def test_move_to_another_project_with_disabled_tracker
Chris@1295 1077 issue = Issue.find(1)
Chris@1295 1078 target = Project.find(2)
Chris@1295 1079 target.tracker_ids = [3]
Chris@1295 1080 target.save
Chris@1295 1081 issue.project = target
Chris@1295 1082 assert issue.save
Chris@1295 1083 issue.reload
Chris@1295 1084 assert_equal 2, issue.project_id
Chris@1295 1085 assert_equal 3, issue.tracker_id
Chris@1295 1086 end
Chris@1295 1087
Chris@1295 1088 def test_copy_to_the_same_project
Chris@1295 1089 issue = Issue.find(1)
Chris@1295 1090 copy = issue.copy
Chris@1295 1091 assert_difference 'Issue.count' do
Chris@1295 1092 copy.save!
Chris@1295 1093 end
Chris@1295 1094 assert_kind_of Issue, copy
Chris@1295 1095 assert_equal issue.project, copy.project
Chris@1295 1096 assert_equal "125", copy.custom_value_for(2).value
Chris@1295 1097 end
Chris@1295 1098
Chris@1295 1099 def test_copy_to_another_project_and_tracker
Chris@1295 1100 issue = Issue.find(1)
Chris@1295 1101 copy = issue.copy(:project_id => 3, :tracker_id => 2)
Chris@1295 1102 assert_difference 'Issue.count' do
Chris@1295 1103 copy.save!
Chris@1295 1104 end
Chris@1295 1105 copy.reload
Chris@1295 1106 assert_kind_of Issue, copy
Chris@1295 1107 assert_equal Project.find(3), copy.project
Chris@1295 1108 assert_equal Tracker.find(2), copy.tracker
Chris@1295 1109 # Custom field #2 is not associated with target tracker
Chris@1295 1110 assert_nil copy.custom_value_for(2)
Chris@1295 1111 end
Chris@1295 1112
Chris@1295 1113 context "#copy" do
Chris@1295 1114 setup do
Chris@1295 1115 @issue = Issue.find(1)
Chris@1295 1116 end
Chris@1295 1117
Chris@1295 1118 should "not create a journal" do
Chris@1295 1119 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
Chris@1295 1120 copy.save!
Chris@1295 1121 assert_equal 0, copy.reload.journals.size
Chris@1295 1122 end
Chris@1295 1123
Chris@1295 1124 should "allow assigned_to changes" do
Chris@1295 1125 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
Chris@1295 1126 assert_equal 3, copy.assigned_to_id
Chris@1295 1127 end
Chris@1295 1128
Chris@1295 1129 should "allow status changes" do
Chris@1295 1130 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
Chris@1295 1131 assert_equal 2, copy.status_id
Chris@1295 1132 end
Chris@1295 1133
Chris@1295 1134 should "allow start date changes" do
Chris@1295 1135 date = Date.today
Chris@1295 1136 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
Chris@1295 1137 assert_equal date, copy.start_date
Chris@1295 1138 end
Chris@1295 1139
Chris@1295 1140 should "allow due date changes" do
Chris@1295 1141 date = Date.today
Chris@1295 1142 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :due_date => date)
Chris@1295 1143 assert_equal date, copy.due_date
Chris@1295 1144 end
Chris@1295 1145
Chris@1295 1146 should "set current user as author" do
Chris@1295 1147 User.current = User.find(9)
Chris@1295 1148 copy = @issue.copy(:project_id => 3, :tracker_id => 2)
Chris@1295 1149 assert_equal User.current, copy.author
Chris@1295 1150 end
Chris@1295 1151
Chris@1295 1152 should "create a journal with notes" do
Chris@1295 1153 date = Date.today
Chris@1295 1154 notes = "Notes added when copying"
Chris@1295 1155 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
Chris@1295 1156 copy.init_journal(User.current, notes)
Chris@1295 1157 copy.save!
Chris@1295 1158
Chris@1295 1159 assert_equal 1, copy.journals.size
Chris@1295 1160 journal = copy.journals.first
Chris@1295 1161 assert_equal 0, journal.details.size
Chris@1295 1162 assert_equal notes, journal.notes
Chris@1295 1163 end
Chris@1295 1164 end
Chris@1295 1165
Chris@1295 1166 def test_valid_parent_project
Chris@1295 1167 issue = Issue.find(1)
Chris@1295 1168 issue_in_same_project = Issue.find(2)
Chris@1295 1169 issue_in_child_project = Issue.find(5)
Chris@1295 1170 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
Chris@1295 1171 issue_in_other_child_project = Issue.find(6)
Chris@1295 1172 issue_in_different_tree = Issue.find(4)
Chris@1295 1173
Chris@1295 1174 with_settings :cross_project_subtasks => '' do
Chris@1295 1175 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1295 1176 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
Chris@1295 1177 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1295 1178 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1295 1179 end
Chris@1295 1180
Chris@1295 1181 with_settings :cross_project_subtasks => 'system' do
Chris@1295 1182 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1295 1183 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
Chris@1295 1184 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
Chris@1295 1185 end
Chris@1295 1186
Chris@1295 1187 with_settings :cross_project_subtasks => 'tree' do
Chris@1295 1188 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1295 1189 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
Chris@1295 1190 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1295 1191 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1295 1192
Chris@1295 1193 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
Chris@1295 1194 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
Chris@1295 1195 end
Chris@1295 1196
Chris@1295 1197 with_settings :cross_project_subtasks => 'descendants' do
Chris@1295 1198 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1295 1199 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
Chris@1295 1200 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1295 1201 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1295 1202
Chris@1295 1203 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
Chris@1295 1204 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
Chris@1295 1205 end
Chris@1295 1206 end
Chris@1295 1207
Chris@1295 1208 def test_recipients_should_include_previous_assignee
Chris@1295 1209 user = User.find(3)
Chris@1295 1210 user.members.update_all ["mail_notification = ?", false]
Chris@1295 1211 user.update_attribute :mail_notification, 'only_assigned'
Chris@1295 1212
Chris@1295 1213 issue = Issue.find(2)
Chris@1295 1214 issue.assigned_to = nil
Chris@1295 1215 assert_include user.mail, issue.recipients
Chris@1295 1216 issue.save!
Chris@1295 1217 assert !issue.recipients.include?(user.mail)
Chris@1295 1218 end
Chris@1295 1219
Chris@1295 1220 def test_recipients_should_not_include_users_that_cannot_view_the_issue
Chris@1295 1221 issue = Issue.find(12)
Chris@1295 1222 assert issue.recipients.include?(issue.author.mail)
Chris@1295 1223 # copy the issue to a private project
Chris@1295 1224 copy = issue.copy(:project_id => 5, :tracker_id => 2)
Chris@1295 1225 # author is not a member of project anymore
Chris@1295 1226 assert !copy.recipients.include?(copy.author.mail)
Chris@1295 1227 end
Chris@1295 1228
Chris@1295 1229 def test_recipients_should_include_the_assigned_group_members
Chris@1295 1230 group_member = User.generate!
Chris@1295 1231 group = Group.generate!
Chris@1295 1232 group.users << group_member
Chris@1295 1233
Chris@1295 1234 issue = Issue.find(12)
Chris@1295 1235 issue.assigned_to = group
Chris@1295 1236 assert issue.recipients.include?(group_member.mail)
Chris@1295 1237 end
Chris@1295 1238
Chris@1295 1239 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
Chris@1295 1240 user = User.find(3)
Chris@1295 1241 issue = Issue.find(9)
Chris@1295 1242 Watcher.create!(:user => user, :watchable => issue)
Chris@1295 1243 assert issue.watched_by?(user)
Chris@1295 1244 assert !issue.watcher_recipients.include?(user.mail)
Chris@1295 1245 end
Chris@1295 1246
Chris@1295 1247 def test_issue_destroy
Chris@1295 1248 Issue.find(1).destroy
Chris@1295 1249 assert_nil Issue.find_by_id(1)
Chris@1295 1250 assert_nil TimeEntry.find_by_issue_id(1)
Chris@1295 1251 end
Chris@1295 1252
Chris@1295 1253 def test_destroying_a_deleted_issue_should_not_raise_an_error
Chris@1295 1254 issue = Issue.find(1)
Chris@1295 1255 Issue.find(1).destroy
Chris@1295 1256
Chris@1295 1257 assert_nothing_raised do
Chris@1295 1258 assert_no_difference 'Issue.count' do
Chris@1295 1259 issue.destroy
Chris@1295 1260 end
Chris@1295 1261 assert issue.destroyed?
Chris@1295 1262 end
Chris@1295 1263 end
Chris@1295 1264
Chris@1295 1265 def test_destroying_a_stale_issue_should_not_raise_an_error
Chris@1295 1266 issue = Issue.find(1)
Chris@1295 1267 Issue.find(1).update_attribute :subject, "Updated"
Chris@1295 1268
Chris@1295 1269 assert_nothing_raised do
Chris@1295 1270 assert_difference 'Issue.count', -1 do
Chris@1295 1271 issue.destroy
Chris@1295 1272 end
Chris@1295 1273 assert issue.destroyed?
Chris@1295 1274 end
Chris@1295 1275 end
Chris@1295 1276
Chris@1295 1277 def test_blocked
Chris@1295 1278 blocked_issue = Issue.find(9)
Chris@1295 1279 blocking_issue = Issue.find(10)
Chris@1295 1280
Chris@1295 1281 assert blocked_issue.blocked?
Chris@1295 1282 assert !blocking_issue.blocked?
Chris@1295 1283 end
Chris@1295 1284
Chris@1295 1285 def test_blocked_issues_dont_allow_closed_statuses
Chris@1295 1286 blocked_issue = Issue.find(9)
Chris@1295 1287
Chris@1295 1288 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
Chris@1295 1289 assert !allowed_statuses.empty?
Chris@1295 1290 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
Chris@1295 1291 assert closed_statuses.empty?
Chris@1295 1292 end
Chris@1295 1293
Chris@1295 1294 def test_unblocked_issues_allow_closed_statuses
Chris@1295 1295 blocking_issue = Issue.find(10)
Chris@1295 1296
Chris@1295 1297 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
Chris@1295 1298 assert !allowed_statuses.empty?
Chris@1295 1299 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
Chris@1295 1300 assert !closed_statuses.empty?
Chris@1295 1301 end
Chris@1295 1302
Chris@1295 1303 def test_reschedule_an_issue_without_dates
Chris@1295 1304 with_settings :non_working_week_days => [] do
Chris@1295 1305 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1295 1306 issue.reschedule_on '2012-10-09'.to_date
Chris@1295 1307 assert_equal '2012-10-09'.to_date, issue.start_date
Chris@1295 1308 assert_equal '2012-10-09'.to_date, issue.due_date
Chris@1295 1309 end
Chris@1295 1310
Chris@1295 1311 with_settings :non_working_week_days => %w(6 7) do
Chris@1295 1312 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1295 1313 issue.reschedule_on '2012-10-09'.to_date
Chris@1295 1314 assert_equal '2012-10-09'.to_date, issue.start_date
Chris@1295 1315 assert_equal '2012-10-09'.to_date, issue.due_date
Chris@1295 1316
Chris@1295 1317 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1295 1318 issue.reschedule_on '2012-10-13'.to_date
Chris@1295 1319 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1295 1320 assert_equal '2012-10-15'.to_date, issue.due_date
Chris@1295 1321 end
Chris@1295 1322 end
Chris@1295 1323
Chris@1295 1324 def test_reschedule_an_issue_with_start_date
Chris@1295 1325 with_settings :non_working_week_days => [] do
Chris@1295 1326 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1295 1327 issue.reschedule_on '2012-10-13'.to_date
Chris@1295 1328 assert_equal '2012-10-13'.to_date, issue.start_date
Chris@1295 1329 assert_equal '2012-10-13'.to_date, issue.due_date
Chris@1295 1330 end
Chris@1295 1331
Chris@1295 1332 with_settings :non_working_week_days => %w(6 7) do
Chris@1295 1333 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1295 1334 issue.reschedule_on '2012-10-11'.to_date
Chris@1295 1335 assert_equal '2012-10-11'.to_date, issue.start_date
Chris@1295 1336 assert_equal '2012-10-11'.to_date, issue.due_date
Chris@1295 1337
Chris@1295 1338 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1295 1339 issue.reschedule_on '2012-10-13'.to_date
Chris@1295 1340 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1295 1341 assert_equal '2012-10-15'.to_date, issue.due_date
Chris@1295 1342 end
Chris@1295 1343 end
Chris@1295 1344
Chris@1295 1345 def test_reschedule_an_issue_with_start_and_due_dates
Chris@1295 1346 with_settings :non_working_week_days => [] do
Chris@1295 1347 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
Chris@1295 1348 issue.reschedule_on '2012-10-13'.to_date
Chris@1295 1349 assert_equal '2012-10-13'.to_date, issue.start_date
Chris@1295 1350 assert_equal '2012-10-19'.to_date, issue.due_date
Chris@1295 1351 end
Chris@1295 1352
Chris@1295 1353 with_settings :non_working_week_days => %w(6 7) do
Chris@1295 1354 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
Chris@1295 1355 issue.reschedule_on '2012-10-11'.to_date
Chris@1295 1356 assert_equal '2012-10-11'.to_date, issue.start_date
Chris@1295 1357 assert_equal '2012-10-23'.to_date, issue.due_date
Chris@1295 1358
Chris@1295 1359 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
Chris@1295 1360 issue.reschedule_on '2012-10-13'.to_date
Chris@1295 1361 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1295 1362 assert_equal '2012-10-25'.to_date, issue.due_date
Chris@1295 1363 end
Chris@1295 1364 end
Chris@1295 1365
Chris@1295 1366 def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
Chris@1295 1367 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1368 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1369 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1295 1370 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1371 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1295 1372
Chris@1295 1373 issue1.due_date = '2012-10-23'
Chris@1295 1374 issue1.save!
Chris@1295 1375 issue2.reload
Chris@1295 1376 assert_equal Date.parse('2012-10-24'), issue2.start_date
Chris@1295 1377 assert_equal Date.parse('2012-10-26'), issue2.due_date
Chris@1295 1378 end
Chris@1295 1379
Chris@1295 1380 def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
Chris@1295 1381 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1382 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1383 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1295 1384 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1385 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1295 1386
Chris@1295 1387 issue1.start_date = '2012-09-17'
Chris@1295 1388 issue1.due_date = '2012-09-18'
Chris@1295 1389 issue1.save!
Chris@1295 1390 issue2.reload
Chris@1295 1391 assert_equal Date.parse('2012-09-19'), issue2.start_date
Chris@1295 1392 assert_equal Date.parse('2012-09-21'), issue2.due_date
Chris@1295 1393 end
Chris@1295 1394
Chris@1295 1395 def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
Chris@1295 1396 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1397 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1295 1398 issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
Chris@1295 1399 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1295 1400 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1401 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
Chris@1295 1402 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1403 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1295 1404
Chris@1295 1405 issue1.start_date = '2012-09-17'
Chris@1295 1406 issue1.due_date = '2012-09-18'
Chris@1295 1407 issue1.save!
Chris@1295 1408 issue2.reload
Chris@1295 1409 # Issue 2 must start after Issue 3
Chris@1295 1410 assert_equal Date.parse('2012-10-03'), issue2.start_date
Chris@1295 1411 assert_equal Date.parse('2012-10-05'), issue2.due_date
Chris@1295 1412 end
Chris@1295 1413
Chris@1295 1414 def test_rescheduling_a_stale_issue_should_not_raise_an_error
Chris@1295 1415 with_settings :non_working_week_days => [] do
Chris@1295 1416 stale = Issue.find(1)
Chris@1295 1417 issue = Issue.find(1)
Chris@1295 1418 issue.subject = "Updated"
Chris@1295 1419 issue.save!
Chris@1295 1420 date = 10.days.from_now.to_date
Chris@1295 1421 assert_nothing_raised do
Chris@1295 1422 stale.reschedule_on!(date)
Chris@1295 1423 end
Chris@1295 1424 assert_equal date, stale.reload.start_date
Chris@1295 1425 end
Chris@1295 1426 end
Chris@1295 1427
Chris@1295 1428 def test_overdue
Chris@1295 1429 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
Chris@1295 1430 assert !Issue.new(:due_date => Date.today).overdue?
Chris@1295 1431 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
Chris@1295 1432 assert !Issue.new(:due_date => nil).overdue?
Chris@1295 1433 assert !Issue.new(:due_date => 1.day.ago.to_date,
Chris@1295 1434 :status => IssueStatus.find(:first,
Chris@1295 1435 :conditions => {:is_closed => true})
Chris@1295 1436 ).overdue?
Chris@1295 1437 end
Chris@1295 1438
Chris@1295 1439 context "#behind_schedule?" do
Chris@1295 1440 should "be false if the issue has no start_date" do
Chris@1295 1441 assert !Issue.new(:start_date => nil,
Chris@1295 1442 :due_date => 1.day.from_now.to_date,
Chris@1295 1443 :done_ratio => 0).behind_schedule?
Chris@1295 1444 end
Chris@1295 1445
Chris@1295 1446 should "be false if the issue has no end_date" do
Chris@1295 1447 assert !Issue.new(:start_date => 1.day.from_now.to_date,
Chris@1295 1448 :due_date => nil,
Chris@1295 1449 :done_ratio => 0).behind_schedule?
Chris@1295 1450 end
Chris@1295 1451
Chris@1295 1452 should "be false if the issue has more done than it's calendar time" do
Chris@1295 1453 assert !Issue.new(:start_date => 50.days.ago.to_date,
Chris@1295 1454 :due_date => 50.days.from_now.to_date,
Chris@1295 1455 :done_ratio => 90).behind_schedule?
Chris@1295 1456 end
Chris@1295 1457
Chris@1295 1458 should "be true if the issue hasn't been started at all" do
Chris@1295 1459 assert Issue.new(:start_date => 1.day.ago.to_date,
Chris@1295 1460 :due_date => 1.day.from_now.to_date,
Chris@1295 1461 :done_ratio => 0).behind_schedule?
Chris@1295 1462 end
Chris@1295 1463
Chris@1295 1464 should "be true if the issue has used more calendar time than it's done ratio" do
Chris@1295 1465 assert Issue.new(:start_date => 100.days.ago.to_date,
Chris@1295 1466 :due_date => Date.today,
Chris@1295 1467 :done_ratio => 90).behind_schedule?
Chris@1295 1468 end
Chris@1295 1469 end
Chris@1295 1470
Chris@1295 1471 context "#assignable_users" do
Chris@1295 1472 should "be Users" do
Chris@1295 1473 assert_kind_of User, Issue.find(1).assignable_users.first
Chris@1295 1474 end
Chris@1295 1475
Chris@1295 1476 should "include the issue author" do
Chris@1295 1477 non_project_member = User.generate!
Chris@1295 1478 issue = Issue.generate!(:author => non_project_member)
Chris@1295 1479
Chris@1295 1480 assert issue.assignable_users.include?(non_project_member)
Chris@1295 1481 end
Chris@1295 1482
Chris@1295 1483 should "include the current assignee" do
Chris@1295 1484 user = User.generate!
Chris@1295 1485 issue = Issue.generate!(:assigned_to => user)
Chris@1295 1486 user.lock!
Chris@1295 1487
Chris@1295 1488 assert Issue.find(issue.id).assignable_users.include?(user)
Chris@1295 1489 end
Chris@1295 1490
Chris@1295 1491 should "not show the issue author twice" do
Chris@1295 1492 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
Chris@1295 1493 assert_equal 2, assignable_user_ids.length
Chris@1295 1494
Chris@1295 1495 assignable_user_ids.each do |user_id|
Chris@1295 1496 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
Chris@1295 1497 "User #{user_id} appears more or less than once"
Chris@1295 1498 end
Chris@1295 1499 end
Chris@1295 1500
Chris@1295 1501 context "with issue_group_assignment" do
Chris@1295 1502 should "include groups" do
Chris@1295 1503 issue = Issue.new(:project => Project.find(2))
Chris@1295 1504
Chris@1295 1505 with_settings :issue_group_assignment => '1' do
Chris@1295 1506 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
Chris@1295 1507 assert issue.assignable_users.include?(Group.find(11))
Chris@1295 1508 end
Chris@1295 1509 end
Chris@1295 1510 end
Chris@1295 1511
Chris@1295 1512 context "without issue_group_assignment" do
Chris@1295 1513 should "not include groups" do
Chris@1295 1514 issue = Issue.new(:project => Project.find(2))
Chris@1295 1515
Chris@1295 1516 with_settings :issue_group_assignment => '0' do
Chris@1295 1517 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
Chris@1295 1518 assert !issue.assignable_users.include?(Group.find(11))
Chris@1295 1519 end
Chris@1295 1520 end
Chris@1295 1521 end
Chris@1295 1522 end
Chris@1295 1523
Chris@1295 1524 def test_create_should_send_email_notification
Chris@1295 1525 ActionMailer::Base.deliveries.clear
Chris@1295 1526 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1295 1527 :author_id => 3, :status_id => 1,
Chris@1295 1528 :priority => IssuePriority.all.first,
Chris@1295 1529 :subject => 'test_create', :estimated_hours => '1:30')
Chris@1295 1530
Chris@1295 1531 assert issue.save
Chris@1295 1532 assert_equal 1, ActionMailer::Base.deliveries.size
Chris@1295 1533 end
Chris@1295 1534
Chris@1295 1535 def test_stale_issue_should_not_send_email_notification
Chris@1295 1536 ActionMailer::Base.deliveries.clear
Chris@1295 1537 issue = Issue.find(1)
Chris@1295 1538 stale = Issue.find(1)
Chris@1295 1539
Chris@1295 1540 issue.init_journal(User.find(1))
Chris@1295 1541 issue.subject = 'Subjet update'
Chris@1295 1542 assert issue.save
Chris@1295 1543 assert_equal 1, ActionMailer::Base.deliveries.size
Chris@1295 1544 ActionMailer::Base.deliveries.clear
Chris@1295 1545
Chris@1295 1546 stale.init_journal(User.find(1))
Chris@1295 1547 stale.subject = 'Another subjet update'
Chris@1295 1548 assert_raise ActiveRecord::StaleObjectError do
Chris@1295 1549 stale.save
Chris@1295 1550 end
Chris@1295 1551 assert ActionMailer::Base.deliveries.empty?
Chris@1295 1552 end
Chris@1295 1553
Chris@1295 1554 def test_journalized_description
Chris@1295 1555 IssueCustomField.delete_all
Chris@1295 1556
Chris@1295 1557 i = Issue.first
Chris@1295 1558 old_description = i.description
Chris@1295 1559 new_description = "This is the new description"
Chris@1295 1560
Chris@1295 1561 i.init_journal(User.find(2))
Chris@1295 1562 i.description = new_description
Chris@1295 1563 assert_difference 'Journal.count', 1 do
Chris@1295 1564 assert_difference 'JournalDetail.count', 1 do
Chris@1295 1565 i.save!
Chris@1295 1566 end
Chris@1295 1567 end
Chris@1295 1568
Chris@1295 1569 detail = JournalDetail.first(:order => 'id DESC')
Chris@1295 1570 assert_equal i, detail.journal.journalized
Chris@1295 1571 assert_equal 'attr', detail.property
Chris@1295 1572 assert_equal 'description', detail.prop_key
Chris@1295 1573 assert_equal old_description, detail.old_value
Chris@1295 1574 assert_equal new_description, detail.value
Chris@1295 1575 end
Chris@1295 1576
Chris@1295 1577 def test_blank_descriptions_should_not_be_journalized
Chris@1295 1578 IssueCustomField.delete_all
Chris@1295 1579 Issue.update_all("description = NULL", "id=1")
Chris@1295 1580
Chris@1295 1581 i = Issue.find(1)
Chris@1295 1582 i.init_journal(User.find(2))
Chris@1295 1583 i.subject = "blank description"
Chris@1295 1584 i.description = "\r\n"
Chris@1295 1585
Chris@1295 1586 assert_difference 'Journal.count', 1 do
Chris@1295 1587 assert_difference 'JournalDetail.count', 1 do
Chris@1295 1588 i.save!
Chris@1295 1589 end
Chris@1295 1590 end
Chris@1295 1591 end
Chris@1295 1592
Chris@1295 1593 def test_journalized_multi_custom_field
Chris@1295 1594 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
Chris@1295 1595 :is_filter => true, :is_for_all => true,
Chris@1295 1596 :tracker_ids => [1],
Chris@1295 1597 :possible_values => ['value1', 'value2', 'value3'],
Chris@1295 1598 :multiple => true)
Chris@1295 1599
Chris@1295 1600 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
Chris@1295 1601 :subject => 'Test', :author_id => 1)
Chris@1295 1602
Chris@1295 1603 assert_difference 'Journal.count' do
Chris@1295 1604 assert_difference 'JournalDetail.count' do
Chris@1295 1605 issue.init_journal(User.first)
Chris@1295 1606 issue.custom_field_values = {field.id => ['value1']}
Chris@1295 1607 issue.save!
Chris@1295 1608 end
Chris@1295 1609 assert_difference 'JournalDetail.count' do
Chris@1295 1610 issue.init_journal(User.first)
Chris@1295 1611 issue.custom_field_values = {field.id => ['value1', 'value2']}
Chris@1295 1612 issue.save!
Chris@1295 1613 end
Chris@1295 1614 assert_difference 'JournalDetail.count', 2 do
Chris@1295 1615 issue.init_journal(User.first)
Chris@1295 1616 issue.custom_field_values = {field.id => ['value3', 'value2']}
Chris@1295 1617 issue.save!
Chris@1295 1618 end
Chris@1295 1619 assert_difference 'JournalDetail.count', 2 do
Chris@1295 1620 issue.init_journal(User.first)
Chris@1295 1621 issue.custom_field_values = {field.id => nil}
Chris@1295 1622 issue.save!
Chris@1295 1623 end
Chris@1295 1624 end
Chris@1295 1625 end
Chris@1295 1626
Chris@1295 1627 def test_description_eol_should_be_normalized
Chris@1295 1628 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
Chris@1295 1629 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
Chris@1295 1630 end
Chris@1295 1631
Chris@1295 1632 def test_saving_twice_should_not_duplicate_journal_details
Chris@1295 1633 i = Issue.find(:first)
Chris@1295 1634 i.init_journal(User.find(2), 'Some notes')
Chris@1295 1635 # initial changes
Chris@1295 1636 i.subject = 'New subject'
Chris@1295 1637 i.done_ratio = i.done_ratio + 10
Chris@1295 1638 assert_difference 'Journal.count' do
Chris@1295 1639 assert i.save
Chris@1295 1640 end
Chris@1295 1641 # 1 more change
Chris@1295 1642 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
Chris@1295 1643 assert_no_difference 'Journal.count' do
Chris@1295 1644 assert_difference 'JournalDetail.count', 1 do
Chris@1295 1645 i.save
Chris@1295 1646 end
Chris@1295 1647 end
Chris@1295 1648 # no more change
Chris@1295 1649 assert_no_difference 'Journal.count' do
Chris@1295 1650 assert_no_difference 'JournalDetail.count' do
Chris@1295 1651 i.save
Chris@1295 1652 end
Chris@1295 1653 end
Chris@1295 1654 end
Chris@1295 1655
Chris@1295 1656 def test_all_dependent_issues
Chris@1295 1657 IssueRelation.delete_all
Chris@1295 1658 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1295 1659 :issue_to => Issue.find(2),
Chris@1295 1660 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1661 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1295 1662 :issue_to => Issue.find(3),
Chris@1295 1663 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1664 assert IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1295 1665 :issue_to => Issue.find(8),
Chris@1295 1666 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1667
Chris@1295 1668 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1295 1669 end
Chris@1295 1670
Chris@1295 1671 def test_all_dependent_issues_with_persistent_circular_dependency
Chris@1295 1672 IssueRelation.delete_all
Chris@1295 1673 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1295 1674 :issue_to => Issue.find(2),
Chris@1295 1675 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1676 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1295 1677 :issue_to => Issue.find(3),
Chris@1295 1678 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1679
Chris@1295 1680 r = IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1295 1681 :issue_to => Issue.find(7),
Chris@1295 1682 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1295 1683 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
Chris@1295 1684
Chris@1295 1685 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1295 1686 end
Chris@1295 1687
Chris@1295 1688 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
Chris@1295 1689 IssueRelation.delete_all
Chris@1295 1690 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1295 1691 :issue_to => Issue.find(2),
Chris@1295 1692 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1295 1693 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1295 1694 :issue_to => Issue.find(3),
Chris@1295 1695 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1295 1696 assert IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1295 1697 :issue_to => Issue.find(8),
Chris@1295 1698 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1295 1699
Chris@1295 1700 r = IssueRelation.create!(:issue_from => Issue.find(8),
Chris@1295 1701 :issue_to => Issue.find(7),
Chris@1295 1702 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1295 1703 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
Chris@1295 1704
Chris@1295 1705 r = IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1295 1706 :issue_to => Issue.find(7),
Chris@1295 1707 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1295 1708 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
Chris@1295 1709
Chris@1295 1710 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1295 1711 end
Chris@1295 1712
Chris@1295 1713 context "#done_ratio" do
Chris@1295 1714 setup do
Chris@1295 1715 @issue = Issue.find(1)
Chris@1295 1716 @issue_status = IssueStatus.find(1)
Chris@1295 1717 @issue_status.update_attribute(:default_done_ratio, 50)
Chris@1295 1718 @issue2 = Issue.find(2)
Chris@1295 1719 @issue_status2 = IssueStatus.find(2)
Chris@1295 1720 @issue_status2.update_attribute(:default_done_ratio, 0)
Chris@1295 1721 end
Chris@1295 1722
Chris@1295 1723 teardown do
Chris@1295 1724 Setting.issue_done_ratio = 'issue_field'
Chris@1295 1725 end
Chris@1295 1726
Chris@1295 1727 context "with Setting.issue_done_ratio using the issue_field" do
Chris@1295 1728 setup do
Chris@1295 1729 Setting.issue_done_ratio = 'issue_field'
Chris@1295 1730 end
Chris@1295 1731
Chris@1295 1732 should "read the issue's field" do
Chris@1295 1733 assert_equal 0, @issue.done_ratio
Chris@1295 1734 assert_equal 30, @issue2.done_ratio
Chris@1295 1735 end
Chris@1295 1736 end
Chris@1295 1737
Chris@1295 1738 context "with Setting.issue_done_ratio using the issue_status" do
Chris@1295 1739 setup do
Chris@1295 1740 Setting.issue_done_ratio = 'issue_status'
Chris@1295 1741 end
Chris@1295 1742
Chris@1295 1743 should "read the Issue Status's default done ratio" do
Chris@1295 1744 assert_equal 50, @issue.done_ratio
Chris@1295 1745 assert_equal 0, @issue2.done_ratio
Chris@1295 1746 end
Chris@1295 1747 end
Chris@1295 1748 end
Chris@1295 1749
Chris@1295 1750 context "#update_done_ratio_from_issue_status" do
Chris@1295 1751 setup do
Chris@1295 1752 @issue = Issue.find(1)
Chris@1295 1753 @issue_status = IssueStatus.find(1)
Chris@1295 1754 @issue_status.update_attribute(:default_done_ratio, 50)
Chris@1295 1755 @issue2 = Issue.find(2)
Chris@1295 1756 @issue_status2 = IssueStatus.find(2)
Chris@1295 1757 @issue_status2.update_attribute(:default_done_ratio, 0)
Chris@1295 1758 end
Chris@1295 1759
Chris@1295 1760 context "with Setting.issue_done_ratio using the issue_field" do
Chris@1295 1761 setup do
Chris@1295 1762 Setting.issue_done_ratio = 'issue_field'
Chris@1295 1763 end
Chris@1295 1764
Chris@1295 1765 should "not change the issue" do
Chris@1295 1766 @issue.update_done_ratio_from_issue_status
Chris@1295 1767 @issue2.update_done_ratio_from_issue_status
Chris@1295 1768
Chris@1295 1769 assert_equal 0, @issue.read_attribute(:done_ratio)
Chris@1295 1770 assert_equal 30, @issue2.read_attribute(:done_ratio)
Chris@1295 1771 end
Chris@1295 1772 end
Chris@1295 1773
Chris@1295 1774 context "with Setting.issue_done_ratio using the issue_status" do
Chris@1295 1775 setup do
Chris@1295 1776 Setting.issue_done_ratio = 'issue_status'
Chris@1295 1777 end
Chris@1295 1778
Chris@1295 1779 should "change the issue's done ratio" do
Chris@1295 1780 @issue.update_done_ratio_from_issue_status
Chris@1295 1781 @issue2.update_done_ratio_from_issue_status
Chris@1295 1782
Chris@1295 1783 assert_equal 50, @issue.read_attribute(:done_ratio)
Chris@1295 1784 assert_equal 0, @issue2.read_attribute(:done_ratio)
Chris@1295 1785 end
Chris@1295 1786 end
Chris@1295 1787 end
Chris@1295 1788
Chris@1295 1789 test "#by_tracker" do
Chris@1295 1790 User.current = User.anonymous
Chris@1295 1791 groups = Issue.by_tracker(Project.find(1))
Chris@1295 1792 assert_equal 3, groups.size
Chris@1295 1793 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1794 end
Chris@1295 1795
Chris@1295 1796 test "#by_version" do
Chris@1295 1797 User.current = User.anonymous
Chris@1295 1798 groups = Issue.by_version(Project.find(1))
Chris@1295 1799 assert_equal 3, groups.size
Chris@1295 1800 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1801 end
Chris@1295 1802
Chris@1295 1803 test "#by_priority" do
Chris@1295 1804 User.current = User.anonymous
Chris@1295 1805 groups = Issue.by_priority(Project.find(1))
Chris@1295 1806 assert_equal 4, groups.size
Chris@1295 1807 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1808 end
Chris@1295 1809
Chris@1295 1810 test "#by_category" do
Chris@1295 1811 User.current = User.anonymous
Chris@1295 1812 groups = Issue.by_category(Project.find(1))
Chris@1295 1813 assert_equal 2, groups.size
Chris@1295 1814 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1815 end
Chris@1295 1816
Chris@1295 1817 test "#by_assigned_to" do
Chris@1295 1818 User.current = User.anonymous
Chris@1295 1819 groups = Issue.by_assigned_to(Project.find(1))
Chris@1295 1820 assert_equal 2, groups.size
Chris@1295 1821 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1822 end
Chris@1295 1823
Chris@1295 1824 test "#by_author" do
Chris@1295 1825 User.current = User.anonymous
Chris@1295 1826 groups = Issue.by_author(Project.find(1))
Chris@1295 1827 assert_equal 4, groups.size
Chris@1295 1828 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1829 end
Chris@1295 1830
Chris@1295 1831 test "#by_subproject" do
Chris@1295 1832 User.current = User.anonymous
Chris@1295 1833 groups = Issue.by_subproject(Project.find(1))
Chris@1295 1834 # Private descendant not visible
Chris@1295 1835 assert_equal 1, groups.size
Chris@1295 1836 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1295 1837 end
Chris@1295 1838
Chris@1295 1839 def test_recently_updated_scope
Chris@1295 1840 #should return the last updated issue
Chris@1295 1841 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
Chris@1295 1842 end
Chris@1295 1843
Chris@1295 1844 def test_on_active_projects_scope
Chris@1295 1845 assert Project.find(2).archive
Chris@1295 1846
Chris@1295 1847 before = Issue.on_active_project.length
Chris@1295 1848 # test inclusion to results
Chris@1295 1849 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
Chris@1295 1850 assert_equal before + 1, Issue.on_active_project.length
Chris@1295 1851
Chris@1295 1852 # Move to an archived project
Chris@1295 1853 issue.project = Project.find(2)
Chris@1295 1854 assert issue.save
Chris@1295 1855 assert_equal before, Issue.on_active_project.length
Chris@1295 1856 end
Chris@1295 1857
Chris@1295 1858 context "Issue#recipients" do
Chris@1295 1859 setup do
Chris@1295 1860 @project = Project.find(1)
Chris@1295 1861 @author = User.generate!
Chris@1295 1862 @assignee = User.generate!
Chris@1295 1863 @issue = Issue.generate!(:project => @project, :assigned_to => @assignee, :author => @author)
Chris@1295 1864 end
Chris@1295 1865
Chris@1295 1866 should "include project recipients" do
Chris@1295 1867 assert @project.recipients.present?
Chris@1295 1868 @project.recipients.each do |project_recipient|
Chris@1295 1869 assert @issue.recipients.include?(project_recipient)
Chris@1295 1870 end
Chris@1295 1871 end
Chris@1295 1872
Chris@1295 1873 should "include the author if the author is active" do
Chris@1295 1874 assert @issue.author, "No author set for Issue"
Chris@1295 1875 assert @issue.recipients.include?(@issue.author.mail)
Chris@1295 1876 end
Chris@1295 1877
Chris@1295 1878 should "include the assigned to user if the assigned to user is active" do
Chris@1295 1879 assert @issue.assigned_to, "No assigned_to set for Issue"
Chris@1295 1880 assert @issue.recipients.include?(@issue.assigned_to.mail)
Chris@1295 1881 end
Chris@1295 1882
Chris@1295 1883 should "not include users who opt out of all email" do
Chris@1295 1884 @author.update_attribute(:mail_notification, :none)
Chris@1295 1885
Chris@1295 1886 assert !@issue.recipients.include?(@issue.author.mail)
Chris@1295 1887 end
Chris@1295 1888
Chris@1295 1889 should "not include the issue author if they are only notified of assigned issues" do
Chris@1295 1890 @author.update_attribute(:mail_notification, :only_assigned)
Chris@1295 1891
Chris@1295 1892 assert !@issue.recipients.include?(@issue.author.mail)
Chris@1295 1893 end
Chris@1295 1894
Chris@1295 1895 should "not include the assigned user if they are only notified of owned issues" do
Chris@1295 1896 @assignee.update_attribute(:mail_notification, :only_owner)
Chris@1295 1897
Chris@1295 1898 assert !@issue.recipients.include?(@issue.assigned_to.mail)
Chris@1295 1899 end
Chris@1295 1900 end
Chris@1295 1901
Chris@1295 1902 def test_last_journal_id_with_journals_should_return_the_journal_id
Chris@1295 1903 assert_equal 2, Issue.find(1).last_journal_id
Chris@1295 1904 end
Chris@1295 1905
Chris@1295 1906 def test_last_journal_id_without_journals_should_return_nil
Chris@1295 1907 assert_nil Issue.find(3).last_journal_id
Chris@1295 1908 end
Chris@1295 1909
Chris@1295 1910 def test_journals_after_should_return_journals_with_greater_id
Chris@1295 1911 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
Chris@1295 1912 assert_equal [], Issue.find(1).journals_after('2')
Chris@1295 1913 end
Chris@1295 1914
Chris@1295 1915 def test_journals_after_with_blank_arg_should_return_all_journals
Chris@1295 1916 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
Chris@1295 1917 end
Chris@1295 1918
Chris@1295 1919 def test_css_classes_should_include_priority
Chris@1295 1920 issue = Issue.new(:priority => IssuePriority.find(8))
Chris@1295 1921 classes = issue.css_classes.split(' ')
Chris@1295 1922 assert_include 'priority-8', classes
Chris@1295 1923 assert_include 'priority-highest', classes
Chris@1295 1924 end
Chris@1295 1925
Chris@1295 1926 def test_save_attachments_with_hash_should_save_attachments_in_keys_order
Chris@1295 1927 set_tmp_attachments_directory
Chris@1295 1928 issue = Issue.generate!
Chris@1295 1929 issue.save_attachments({
Chris@1295 1930 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
Chris@1295 1931 '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
Chris@1295 1932 '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
Chris@1295 1933 })
Chris@1295 1934 issue.attach_saved_attachments
Chris@1295 1935
Chris@1295 1936 assert_equal 3, issue.reload.attachments.count
Chris@1295 1937 assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
Chris@1295 1938 end
Chris@1295 1939 end