annotate .svn/pristine/bf/bf3891524da5c087cfdb90a3d5894f8ee7c55a30.svn-base @ 1524:82fac3dcf466 redmine-2.5-integration

Fix failure to interpret Javascript when autocompleting members for project
author Chris Cannam <chris.cannam@soundsoftware.ac.uk>
date Thu, 11 Sep 2014 10:24:38 +0100
parents dffacf8a6908
children
rev   line source
Chris@1517 1 # Redmine - project management software
Chris@1517 2 # Copyright (C) 2006-2014 Jean-Philippe Lang
Chris@1517 3 #
Chris@1517 4 # This program is free software; you can redistribute it and/or
Chris@1517 5 # modify it under the terms of the GNU General Public License
Chris@1517 6 # as published by the Free Software Foundation; either version 2
Chris@1517 7 # of the License, or (at your option) any later version.
Chris@1517 8 #
Chris@1517 9 # This program is distributed in the hope that it will be useful,
Chris@1517 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1517 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@1517 12 # GNU General Public License for more details.
Chris@1517 13 #
Chris@1517 14 # You should have received a copy of the GNU General Public License
Chris@1517 15 # along with this program; if not, write to the Free Software
Chris@1517 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@1517 17
Chris@1517 18 require File.expand_path('../../test_helper', __FILE__)
Chris@1517 19
Chris@1517 20 class WorkflowsControllerTest < ActionController::TestCase
Chris@1517 21 fixtures :roles, :trackers, :workflows, :users, :issue_statuses
Chris@1517 22
Chris@1517 23 def setup
Chris@1517 24 User.current = nil
Chris@1517 25 @request.session[:user_id] = 1 # admin
Chris@1517 26 end
Chris@1517 27
Chris@1517 28 def test_index
Chris@1517 29 get :index
Chris@1517 30 assert_response :success
Chris@1517 31 assert_template 'index'
Chris@1517 32
Chris@1517 33 count = WorkflowTransition.where(:role_id => 1, :tracker_id => 2).count
Chris@1517 34 assert_tag :tag => 'a', :content => count.to_s,
Chris@1517 35 :attributes => { :href => '/workflows/edit?role_id=1&amp;tracker_id=2' }
Chris@1517 36 end
Chris@1517 37
Chris@1517 38 def test_get_edit
Chris@1517 39 get :edit
Chris@1517 40 assert_response :success
Chris@1517 41 assert_template 'edit'
Chris@1517 42 assert_not_nil assigns(:roles)
Chris@1517 43 assert_not_nil assigns(:trackers)
Chris@1517 44 end
Chris@1517 45
Chris@1517 46 def test_get_edit_with_role_and_tracker
Chris@1517 47 WorkflowTransition.delete_all
Chris@1517 48 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 2, :new_status_id => 3)
Chris@1517 49 WorkflowTransition.create!(:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 5)
Chris@1517 50
Chris@1517 51 get :edit, :role_id => 2, :tracker_id => 1
Chris@1517 52 assert_response :success
Chris@1517 53 assert_template 'edit'
Chris@1517 54
Chris@1517 55 # used status only
Chris@1517 56 assert_not_nil assigns(:statuses)
Chris@1517 57 assert_equal [2, 3, 5], assigns(:statuses).collect(&:id)
Chris@1517 58
Chris@1517 59 # allowed transitions
Chris@1517 60 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
Chris@1517 61 :name => 'issue_status[3][5][]',
Chris@1517 62 :value => 'always',
Chris@1517 63 :checked => 'checked' }
Chris@1517 64 # not allowed
Chris@1517 65 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
Chris@1517 66 :name => 'issue_status[3][2][]',
Chris@1517 67 :value => 'always',
Chris@1517 68 :checked => nil }
Chris@1517 69 # unused
Chris@1517 70 assert_no_tag :tag => 'input', :attributes => { :type => 'checkbox',
Chris@1517 71 :name => 'issue_status[1][1][]' }
Chris@1517 72 end
Chris@1517 73
Chris@1517 74 def test_get_edit_with_role_and_tracker_and_all_statuses
Chris@1517 75 WorkflowTransition.delete_all
Chris@1517 76
Chris@1517 77 get :edit, :role_id => 2, :tracker_id => 1, :used_statuses_only => '0'
Chris@1517 78 assert_response :success
Chris@1517 79 assert_template 'edit'
Chris@1517 80
Chris@1517 81 assert_not_nil assigns(:statuses)
Chris@1517 82 assert_equal IssueStatus.count, assigns(:statuses).size
Chris@1517 83
Chris@1517 84 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
Chris@1517 85 :name => 'issue_status[1][1][]',
Chris@1517 86 :value => 'always',
Chris@1517 87 :checked => nil }
Chris@1517 88 end
Chris@1517 89
Chris@1517 90 def test_post_edit
Chris@1517 91 post :edit, :role_id => 2, :tracker_id => 1,
Chris@1517 92 :issue_status => {
Chris@1517 93 '4' => {'5' => ['always']},
Chris@1517 94 '3' => {'1' => ['always'], '2' => ['always']}
Chris@1517 95 }
Chris@1517 96 assert_redirected_to '/workflows/edit?role_id=2&tracker_id=1'
Chris@1517 97
Chris@1517 98 assert_equal 3, WorkflowTransition.where(:tracker_id => 1, :role_id => 2).count
Chris@1517 99 assert_not_nil WorkflowTransition.where(:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 2).first
Chris@1517 100 assert_nil WorkflowTransition.where(:role_id => 2, :tracker_id => 1, :old_status_id => 5, :new_status_id => 4).first
Chris@1517 101 end
Chris@1517 102
Chris@1517 103 def test_post_edit_with_additional_transitions
Chris@1517 104 post :edit, :role_id => 2, :tracker_id => 1,
Chris@1517 105 :issue_status => {
Chris@1517 106 '4' => {'5' => ['always']},
Chris@1517 107 '3' => {'1' => ['author'], '2' => ['assignee'], '4' => ['author', 'assignee']}
Chris@1517 108 }
Chris@1517 109 assert_redirected_to '/workflows/edit?role_id=2&tracker_id=1'
Chris@1517 110
Chris@1517 111 assert_equal 4, WorkflowTransition.where(:tracker_id => 1, :role_id => 2).count
Chris@1517 112
Chris@1517 113 w = WorkflowTransition.where(:role_id => 2, :tracker_id => 1, :old_status_id => 4, :new_status_id => 5).first
Chris@1517 114 assert ! w.author
Chris@1517 115 assert ! w.assignee
Chris@1517 116 w = WorkflowTransition.where(:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 1).first
Chris@1517 117 assert w.author
Chris@1517 118 assert ! w.assignee
Chris@1517 119 w = WorkflowTransition.where(:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 2).first
Chris@1517 120 assert ! w.author
Chris@1517 121 assert w.assignee
Chris@1517 122 w = WorkflowTransition.where(:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 4).first
Chris@1517 123 assert w.author
Chris@1517 124 assert w.assignee
Chris@1517 125 end
Chris@1517 126
Chris@1517 127 def test_clear_workflow
Chris@1517 128 assert WorkflowTransition.where(:role_id => 1, :tracker_id => 2).count > 0
Chris@1517 129
Chris@1517 130 post :edit, :role_id => 1, :tracker_id => 2
Chris@1517 131 assert_equal 0, WorkflowTransition.where(:role_id => 1, :tracker_id => 2).count
Chris@1517 132 end
Chris@1517 133
Chris@1517 134 def test_get_permissions
Chris@1517 135 get :permissions
Chris@1517 136
Chris@1517 137 assert_response :success
Chris@1517 138 assert_template 'permissions'
Chris@1517 139 assert_not_nil assigns(:roles)
Chris@1517 140 assert_not_nil assigns(:trackers)
Chris@1517 141 end
Chris@1517 142
Chris@1517 143 def test_get_permissions_with_role_and_tracker
Chris@1517 144 WorkflowPermission.delete_all
Chris@1517 145 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :field_name => 'assigned_to_id', :rule => 'required')
Chris@1517 146 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :field_name => 'fixed_version_id', :rule => 'required')
Chris@1517 147 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 3, :field_name => 'fixed_version_id', :rule => 'readonly')
Chris@1517 148
Chris@1517 149 get :permissions, :role_id => 1, :tracker_id => 2
Chris@1517 150 assert_response :success
Chris@1517 151 assert_template 'permissions'
Chris@1517 152
Chris@1517 153 assert_select 'input[name=role_id][value=1]'
Chris@1517 154 assert_select 'input[name=tracker_id][value=2]'
Chris@1517 155
Chris@1517 156 # Required field
Chris@1517 157 assert_select 'select[name=?]', 'permissions[assigned_to_id][2]' do
Chris@1517 158 assert_select 'option[value=]'
Chris@1517 159 assert_select 'option[value=][selected=selected]', 0
Chris@1517 160 assert_select 'option[value=readonly]', :text => 'Read-only'
Chris@1517 161 assert_select 'option[value=readonly][selected=selected]', 0
Chris@1517 162 assert_select 'option[value=required]', :text => 'Required'
Chris@1517 163 assert_select 'option[value=required][selected=selected]'
Chris@1517 164 end
Chris@1517 165
Chris@1517 166 # Read-only field
Chris@1517 167 assert_select 'select[name=?]', 'permissions[fixed_version_id][3]' do
Chris@1517 168 assert_select 'option[value=]'
Chris@1517 169 assert_select 'option[value=][selected=selected]', 0
Chris@1517 170 assert_select 'option[value=readonly]', :text => 'Read-only'
Chris@1517 171 assert_select 'option[value=readonly][selected=selected]'
Chris@1517 172 assert_select 'option[value=required]', :text => 'Required'
Chris@1517 173 assert_select 'option[value=required][selected=selected]', 0
Chris@1517 174 end
Chris@1517 175
Chris@1517 176 # Other field
Chris@1517 177 assert_select 'select[name=?]', 'permissions[due_date][3]' do
Chris@1517 178 assert_select 'option[value=]'
Chris@1517 179 assert_select 'option[value=][selected=selected]', 0
Chris@1517 180 assert_select 'option[value=readonly]', :text => 'Read-only'
Chris@1517 181 assert_select 'option[value=readonly][selected=selected]', 0
Chris@1517 182 assert_select 'option[value=required]', :text => 'Required'
Chris@1517 183 assert_select 'option[value=required][selected=selected]', 0
Chris@1517 184 end
Chris@1517 185 end
Chris@1517 186
Chris@1517 187 def test_get_permissions_with_required_custom_field_should_not_show_required_option
Chris@1517 188 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :tracker_ids => [1], :is_required => true)
Chris@1517 189
Chris@1517 190 get :permissions, :role_id => 1, :tracker_id => 1
Chris@1517 191 assert_response :success
Chris@1517 192 assert_template 'permissions'
Chris@1517 193
Chris@1517 194 # Custom field that is always required
Chris@1517 195 # The default option is "(Required)"
Chris@1517 196 assert_select 'select[name=?]', "permissions[#{cf.id}][3]" do
Chris@1517 197 assert_select 'option[value=]'
Chris@1517 198 assert_select 'option[value=readonly]', :text => 'Read-only'
Chris@1517 199 assert_select 'option[value=required]', 0
Chris@1517 200 end
Chris@1517 201 end
Chris@1517 202
Chris@1517 203 def test_get_permissions_should_disable_hidden_custom_fields
Chris@1517 204 cf1 = IssueCustomField.generate!(:tracker_ids => [1], :visible => true)
Chris@1517 205 cf2 = IssueCustomField.generate!(:tracker_ids => [1], :visible => false, :role_ids => [1])
Chris@1517 206 cf3 = IssueCustomField.generate!(:tracker_ids => [1], :visible => false, :role_ids => [1, 2])
Chris@1517 207
Chris@1517 208 get :permissions, :role_id => 2, :tracker_id => 1
Chris@1517 209 assert_response :success
Chris@1517 210 assert_template 'permissions'
Chris@1517 211
Chris@1517 212 assert_select 'select[name=?]:not(.disabled)', "permissions[#{cf1.id}][1]"
Chris@1517 213 assert_select 'select[name=?]:not(.disabled)', "permissions[#{cf3.id}][1]"
Chris@1517 214
Chris@1517 215 assert_select 'select[name=?][disabled=disabled]', "permissions[#{cf2.id}][1]" do
Chris@1517 216 assert_select 'option[value=][selected=selected]', :text => 'Hidden'
Chris@1517 217 end
Chris@1517 218 end
Chris@1517 219
Chris@1517 220 def test_get_permissions_with_role_and_tracker_and_all_statuses
Chris@1517 221 WorkflowTransition.delete_all
Chris@1517 222
Chris@1517 223 get :permissions, :role_id => 1, :tracker_id => 2, :used_statuses_only => '0'
Chris@1517 224 assert_response :success
Chris@1517 225 assert_equal IssueStatus.sorted.all, assigns(:statuses)
Chris@1517 226 end
Chris@1517 227
Chris@1517 228 def test_post_permissions
Chris@1517 229 WorkflowPermission.delete_all
Chris@1517 230
Chris@1517 231 post :permissions, :role_id => 1, :tracker_id => 2, :permissions => {
Chris@1517 232 'assigned_to_id' => {'1' => '', '2' => 'readonly', '3' => ''},
Chris@1517 233 'fixed_version_id' => {'1' => 'required', '2' => 'readonly', '3' => ''},
Chris@1517 234 'due_date' => {'1' => '', '2' => '', '3' => ''},
Chris@1517 235 }
Chris@1517 236 assert_redirected_to '/workflows/permissions?role_id=1&tracker_id=2'
Chris@1517 237
Chris@1517 238 workflows = WorkflowPermission.all
Chris@1517 239 assert_equal 3, workflows.size
Chris@1517 240 workflows.each do |workflow|
Chris@1517 241 assert_equal 1, workflow.role_id
Chris@1517 242 assert_equal 2, workflow.tracker_id
Chris@1517 243 end
Chris@1517 244 assert workflows.detect {|wf| wf.old_status_id == 2 && wf.field_name == 'assigned_to_id' && wf.rule == 'readonly'}
Chris@1517 245 assert workflows.detect {|wf| wf.old_status_id == 1 && wf.field_name == 'fixed_version_id' && wf.rule == 'required'}
Chris@1517 246 assert workflows.detect {|wf| wf.old_status_id == 2 && wf.field_name == 'fixed_version_id' && wf.rule == 'readonly'}
Chris@1517 247 end
Chris@1517 248
Chris@1517 249 def test_post_permissions_should_clear_permissions
Chris@1517 250 WorkflowPermission.delete_all
Chris@1517 251 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :field_name => 'assigned_to_id', :rule => 'required')
Chris@1517 252 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :field_name => 'fixed_version_id', :rule => 'required')
Chris@1517 253 wf1 = WorkflowPermission.create!(:role_id => 1, :tracker_id => 3, :old_status_id => 2, :field_name => 'fixed_version_id', :rule => 'required')
Chris@1517 254 wf2 = WorkflowPermission.create!(:role_id => 2, :tracker_id => 2, :old_status_id => 3, :field_name => 'fixed_version_id', :rule => 'readonly')
Chris@1517 255
Chris@1517 256 post :permissions, :role_id => 1, :tracker_id => 2
Chris@1517 257 assert_redirected_to '/workflows/permissions?role_id=1&tracker_id=2'
Chris@1517 258
Chris@1517 259 workflows = WorkflowPermission.all
Chris@1517 260 assert_equal 2, workflows.size
Chris@1517 261 assert wf1.reload
Chris@1517 262 assert wf2.reload
Chris@1517 263 end
Chris@1517 264
Chris@1517 265 def test_get_copy
Chris@1517 266 get :copy
Chris@1517 267 assert_response :success
Chris@1517 268 assert_template 'copy'
Chris@1517 269 assert_select 'select[name=source_tracker_id]' do
Chris@1517 270 assert_select 'option[value=1]', :text => 'Bug'
Chris@1517 271 end
Chris@1517 272 assert_select 'select[name=source_role_id]' do
Chris@1517 273 assert_select 'option[value=2]', :text => 'Developer'
Chris@1517 274 end
Chris@1517 275 assert_select 'select[name=?]', 'target_tracker_ids[]' do
Chris@1517 276 assert_select 'option[value=3]', :text => 'Support request'
Chris@1517 277 end
Chris@1517 278 assert_select 'select[name=?]', 'target_role_ids[]' do
Chris@1517 279 assert_select 'option[value=1]', :text => 'Manager'
Chris@1517 280 end
Chris@1517 281 end
Chris@1517 282
Chris@1517 283 def test_post_copy_one_to_one
Chris@1517 284 source_transitions = status_transitions(:tracker_id => 1, :role_id => 2)
Chris@1517 285
Chris@1517 286 post :copy, :source_tracker_id => '1', :source_role_id => '2',
Chris@1517 287 :target_tracker_ids => ['3'], :target_role_ids => ['1']
Chris@1517 288 assert_response 302
Chris@1517 289 assert_equal source_transitions, status_transitions(:tracker_id => 3, :role_id => 1)
Chris@1517 290 end
Chris@1517 291
Chris@1517 292 def test_post_copy_one_to_many
Chris@1517 293 source_transitions = status_transitions(:tracker_id => 1, :role_id => 2)
Chris@1517 294
Chris@1517 295 post :copy, :source_tracker_id => '1', :source_role_id => '2',
Chris@1517 296 :target_tracker_ids => ['2', '3'], :target_role_ids => ['1', '3']
Chris@1517 297 assert_response 302
Chris@1517 298 assert_equal source_transitions, status_transitions(:tracker_id => 2, :role_id => 1)
Chris@1517 299 assert_equal source_transitions, status_transitions(:tracker_id => 3, :role_id => 1)
Chris@1517 300 assert_equal source_transitions, status_transitions(:tracker_id => 2, :role_id => 3)
Chris@1517 301 assert_equal source_transitions, status_transitions(:tracker_id => 3, :role_id => 3)
Chris@1517 302 end
Chris@1517 303
Chris@1517 304 def test_post_copy_many_to_many
Chris@1517 305 source_t2 = status_transitions(:tracker_id => 2, :role_id => 2)
Chris@1517 306 source_t3 = status_transitions(:tracker_id => 3, :role_id => 2)
Chris@1517 307
Chris@1517 308 post :copy, :source_tracker_id => 'any', :source_role_id => '2',
Chris@1517 309 :target_tracker_ids => ['2', '3'], :target_role_ids => ['1', '3']
Chris@1517 310 assert_response 302
Chris@1517 311 assert_equal source_t2, status_transitions(:tracker_id => 2, :role_id => 1)
Chris@1517 312 assert_equal source_t3, status_transitions(:tracker_id => 3, :role_id => 1)
Chris@1517 313 assert_equal source_t2, status_transitions(:tracker_id => 2, :role_id => 3)
Chris@1517 314 assert_equal source_t3, status_transitions(:tracker_id => 3, :role_id => 3)
Chris@1517 315 end
Chris@1517 316
Chris@1517 317 def test_post_copy_with_incomplete_source_specification_should_fail
Chris@1517 318 assert_no_difference 'WorkflowRule.count' do
Chris@1517 319 post :copy,
Chris@1517 320 :source_tracker_id => '', :source_role_id => '2',
Chris@1517 321 :target_tracker_ids => ['2', '3'], :target_role_ids => ['1', '3']
Chris@1517 322 assert_response 200
Chris@1517 323 assert_select 'div.flash.error', :text => 'Please select a source tracker or role'
Chris@1517 324 end
Chris@1517 325 end
Chris@1517 326
Chris@1517 327 def test_post_copy_with_incomplete_target_specification_should_fail
Chris@1517 328 assert_no_difference 'WorkflowRule.count' do
Chris@1517 329 post :copy,
Chris@1517 330 :source_tracker_id => '1', :source_role_id => '2',
Chris@1517 331 :target_tracker_ids => ['2', '3']
Chris@1517 332 assert_response 200
Chris@1517 333 assert_select 'div.flash.error', :text => 'Please select target tracker(s) and role(s)'
Chris@1517 334 end
Chris@1517 335 end
Chris@1517 336
Chris@1517 337 # Returns an array of status transitions that can be compared
Chris@1517 338 def status_transitions(conditions)
Chris@1517 339 WorkflowTransition.
Chris@1517 340 where(conditions).
Chris@1517 341 order('tracker_id, role_id, old_status_id, new_status_id').
Chris@1517 342 collect {|w| [w.old_status, w.new_status_id]}
Chris@1517 343 end
Chris@1517 344 end