annotate .svn/pristine/7c/7cc3cd618ee01978917b3155324a8d8f631cb820.svn-base @ 1524:82fac3dcf466 redmine-2.5-integration

Fix failure to interpret Javascript when autocompleting members for project
author Chris Cannam <chris.cannam@soundsoftware.ac.uk>
date Thu, 11 Sep 2014 10:24:38 +0100
parents dffacf8a6908
children
rev   line source
Chris@1517 1 # Redmine - project management software
Chris@1517 2 # Copyright (C) 2006-2014 Jean-Philippe Lang
Chris@1517 3 #
Chris@1517 4 # This program is free software; you can redistribute it and/or
Chris@1517 5 # modify it under the terms of the GNU General Public License
Chris@1517 6 # as published by the Free Software Foundation; either version 2
Chris@1517 7 # of the License, or (at your option) any later version.
Chris@1517 8 #
Chris@1517 9 # This program is distributed in the hope that it will be useful,
Chris@1517 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1517 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@1517 12 # GNU General Public License for more details.
Chris@1517 13 #
Chris@1517 14 # You should have received a copy of the GNU General Public License
Chris@1517 15 # along with this program; if not, write to the Free Software
Chris@1517 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@1517 17
Chris@1517 18 require File.expand_path('../../../test_helper', __FILE__)
Chris@1517 19
Chris@1517 20 class Redmine::ApiTest::IssuesTest < Redmine::ApiTest::Base
Chris@1517 21 fixtures :projects,
Chris@1517 22 :users,
Chris@1517 23 :roles,
Chris@1517 24 :members,
Chris@1517 25 :member_roles,
Chris@1517 26 :issues,
Chris@1517 27 :issue_statuses,
Chris@1517 28 :issue_relations,
Chris@1517 29 :versions,
Chris@1517 30 :trackers,
Chris@1517 31 :projects_trackers,
Chris@1517 32 :issue_categories,
Chris@1517 33 :enabled_modules,
Chris@1517 34 :enumerations,
Chris@1517 35 :attachments,
Chris@1517 36 :workflows,
Chris@1517 37 :custom_fields,
Chris@1517 38 :custom_values,
Chris@1517 39 :custom_fields_projects,
Chris@1517 40 :custom_fields_trackers,
Chris@1517 41 :time_entries,
Chris@1517 42 :journals,
Chris@1517 43 :journal_details,
Chris@1517 44 :queries,
Chris@1517 45 :attachments
Chris@1517 46
Chris@1517 47 def setup
Chris@1517 48 Setting.rest_api_enabled = '1'
Chris@1517 49 end
Chris@1517 50
Chris@1517 51 context "/issues" do
Chris@1517 52 # Use a private project to make sure auth is really working and not just
Chris@1517 53 # only showing public issues.
Chris@1517 54 should_allow_api_authentication(:get, "/projects/private-child/issues.xml")
Chris@1517 55
Chris@1517 56 should "contain metadata" do
Chris@1517 57 get '/issues.xml'
Chris@1517 58
Chris@1517 59 assert_tag :tag => 'issues',
Chris@1517 60 :attributes => {
Chris@1517 61 :type => 'array',
Chris@1517 62 :total_count => assigns(:issue_count),
Chris@1517 63 :limit => 25,
Chris@1517 64 :offset => 0
Chris@1517 65 }
Chris@1517 66 end
Chris@1517 67
Chris@1517 68 context "with offset and limit" do
Chris@1517 69 should "use the params" do
Chris@1517 70 get '/issues.xml?offset=2&limit=3'
Chris@1517 71
Chris@1517 72 assert_equal 3, assigns(:limit)
Chris@1517 73 assert_equal 2, assigns(:offset)
Chris@1517 74 assert_tag :tag => 'issues', :children => {:count => 3, :only => {:tag => 'issue'}}
Chris@1517 75 end
Chris@1517 76 end
Chris@1517 77
Chris@1517 78 context "with nometa param" do
Chris@1517 79 should "not contain metadata" do
Chris@1517 80 get '/issues.xml?nometa=1'
Chris@1517 81
Chris@1517 82 assert_tag :tag => 'issues',
Chris@1517 83 :attributes => {
Chris@1517 84 :type => 'array',
Chris@1517 85 :total_count => nil,
Chris@1517 86 :limit => nil,
Chris@1517 87 :offset => nil
Chris@1517 88 }
Chris@1517 89 end
Chris@1517 90 end
Chris@1517 91
Chris@1517 92 context "with nometa header" do
Chris@1517 93 should "not contain metadata" do
Chris@1517 94 get '/issues.xml', {}, {'X-Redmine-Nometa' => '1'}
Chris@1517 95
Chris@1517 96 assert_tag :tag => 'issues',
Chris@1517 97 :attributes => {
Chris@1517 98 :type => 'array',
Chris@1517 99 :total_count => nil,
Chris@1517 100 :limit => nil,
Chris@1517 101 :offset => nil
Chris@1517 102 }
Chris@1517 103 end
Chris@1517 104 end
Chris@1517 105
Chris@1517 106 context "with relations" do
Chris@1517 107 should "display relations" do
Chris@1517 108 get '/issues.xml?include=relations'
Chris@1517 109
Chris@1517 110 assert_response :success
Chris@1517 111 assert_equal 'application/xml', @response.content_type
Chris@1517 112 assert_tag 'relations',
Chris@1517 113 :parent => {:tag => 'issue', :child => {:tag => 'id', :content => '3'}},
Chris@1517 114 :children => {:count => 1},
Chris@1517 115 :child => {
Chris@1517 116 :tag => 'relation',
Chris@1517 117 :attributes => {:id => '2', :issue_id => '2', :issue_to_id => '3',
Chris@1517 118 :relation_type => 'relates'}
Chris@1517 119 }
Chris@1517 120 assert_tag 'relations',
Chris@1517 121 :parent => {:tag => 'issue', :child => {:tag => 'id', :content => '1'}},
Chris@1517 122 :children => {:count => 0}
Chris@1517 123 end
Chris@1517 124 end
Chris@1517 125
Chris@1517 126 context "with invalid query params" do
Chris@1517 127 should "return errors" do
Chris@1517 128 get '/issues.xml', {:f => ['start_date'], :op => {:start_date => '='}}
Chris@1517 129
Chris@1517 130 assert_response :unprocessable_entity
Chris@1517 131 assert_equal 'application/xml', @response.content_type
Chris@1517 132 assert_tag 'errors', :child => {:tag => 'error', :content => "Start date can't be blank"}
Chris@1517 133 end
Chris@1517 134 end
Chris@1517 135
Chris@1517 136 context "with custom field filter" do
Chris@1517 137 should "show only issues with the custom field value" do
Chris@1517 138 get '/issues.xml',
Chris@1517 139 {:set_filter => 1, :f => ['cf_1'], :op => {:cf_1 => '='},
Chris@1517 140 :v => {:cf_1 => ['MySQL']}}
Chris@1517 141 expected_ids = Issue.visible.
Chris@1517 142 joins(:custom_values).
Chris@1517 143 where(:custom_values => {:custom_field_id => 1, :value => 'MySQL'}).map(&:id)
Chris@1517 144 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
Chris@1517 145 ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
Chris@1517 146 end
Chris@1517 147 end
Chris@1517 148 end
Chris@1517 149
Chris@1517 150 context "with custom field filter (shorthand method)" do
Chris@1517 151 should "show only issues with the custom field value" do
Chris@1517 152 get '/issues.xml', { :cf_1 => 'MySQL' }
Chris@1517 153
Chris@1517 154 expected_ids = Issue.visible.
Chris@1517 155 joins(:custom_values).
Chris@1517 156 where(:custom_values => {:custom_field_id => 1, :value => 'MySQL'}).map(&:id)
Chris@1517 157
Chris@1517 158 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
Chris@1517 159 ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
Chris@1517 160 end
Chris@1517 161 end
Chris@1517 162 end
Chris@1517 163 end
Chris@1517 164
Chris@1517 165 def test_index_should_allow_timestamp_filtering
Chris@1517 166 Issue.delete_all
Chris@1517 167 Issue.generate!(:subject => '1').update_column(:updated_on, Time.parse("2014-01-02T10:25:00Z"))
Chris@1517 168 Issue.generate!(:subject => '2').update_column(:updated_on, Time.parse("2014-01-02T12:13:00Z"))
Chris@1517 169
Chris@1517 170 get '/issues.xml',
Chris@1517 171 {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '<='},
Chris@1517 172 :v => {:updated_on => ['2014-01-02T12:00:00Z']}}
Chris@1517 173 assert_select 'issues>issue', :count => 1
Chris@1517 174 assert_select 'issues>issue>subject', :text => '1'
Chris@1517 175
Chris@1517 176 get '/issues.xml',
Chris@1517 177 {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '>='},
Chris@1517 178 :v => {:updated_on => ['2014-01-02T12:00:00Z']}}
Chris@1517 179 assert_select 'issues>issue', :count => 1
Chris@1517 180 assert_select 'issues>issue>subject', :text => '2'
Chris@1517 181
Chris@1517 182 get '/issues.xml',
Chris@1517 183 {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '>='},
Chris@1517 184 :v => {:updated_on => ['2014-01-02T08:00:00Z']}}
Chris@1517 185 assert_select 'issues>issue', :count => 2
Chris@1517 186 end
Chris@1517 187
Chris@1517 188 context "/index.json" do
Chris@1517 189 should_allow_api_authentication(:get, "/projects/private-child/issues.json")
Chris@1517 190 end
Chris@1517 191
Chris@1517 192 context "/index.xml with filter" do
Chris@1517 193 should "show only issues with the status_id" do
Chris@1517 194 get '/issues.xml?status_id=5'
Chris@1517 195
Chris@1517 196 expected_ids = Issue.visible.where(:status_id => 5).map(&:id)
Chris@1517 197
Chris@1517 198 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
Chris@1517 199 ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
Chris@1517 200 end
Chris@1517 201 end
Chris@1517 202 end
Chris@1517 203
Chris@1517 204 context "/index.json with filter" do
Chris@1517 205 should "show only issues with the status_id" do
Chris@1517 206 get '/issues.json?status_id=5'
Chris@1517 207
Chris@1517 208 json = ActiveSupport::JSON.decode(response.body)
Chris@1517 209 status_ids_used = json['issues'].collect {|j| j['status']['id'] }
Chris@1517 210 assert_equal 3, status_ids_used.length
Chris@1517 211 assert status_ids_used.all? {|id| id == 5 }
Chris@1517 212 end
Chris@1517 213
Chris@1517 214 end
Chris@1517 215
Chris@1517 216 # Issue 6 is on a private project
Chris@1517 217 context "/issues/6.xml" do
Chris@1517 218 should_allow_api_authentication(:get, "/issues/6.xml")
Chris@1517 219 end
Chris@1517 220
Chris@1517 221 context "/issues/6.json" do
Chris@1517 222 should_allow_api_authentication(:get, "/issues/6.json")
Chris@1517 223 end
Chris@1517 224
Chris@1517 225 context "GET /issues/:id" do
Chris@1517 226 context "with journals" do
Chris@1517 227 context ".xml" do
Chris@1517 228 should "display journals" do
Chris@1517 229 get '/issues/1.xml?include=journals'
Chris@1517 230
Chris@1517 231 assert_tag :tag => 'issue',
Chris@1517 232 :child => {
Chris@1517 233 :tag => 'journals',
Chris@1517 234 :attributes => { :type => 'array' },
Chris@1517 235 :child => {
Chris@1517 236 :tag => 'journal',
Chris@1517 237 :attributes => { :id => '1'},
Chris@1517 238 :child => {
Chris@1517 239 :tag => 'details',
Chris@1517 240 :attributes => { :type => 'array' },
Chris@1517 241 :child => {
Chris@1517 242 :tag => 'detail',
Chris@1517 243 :attributes => { :name => 'status_id' },
Chris@1517 244 :child => {
Chris@1517 245 :tag => 'old_value',
Chris@1517 246 :content => '1',
Chris@1517 247 :sibling => {
Chris@1517 248 :tag => 'new_value',
Chris@1517 249 :content => '2'
Chris@1517 250 }
Chris@1517 251 }
Chris@1517 252 }
Chris@1517 253 }
Chris@1517 254 }
Chris@1517 255 }
Chris@1517 256 end
Chris@1517 257 end
Chris@1517 258 end
Chris@1517 259
Chris@1517 260 context "with custom fields" do
Chris@1517 261 context ".xml" do
Chris@1517 262 should "display custom fields" do
Chris@1517 263 get '/issues/3.xml'
Chris@1517 264
Chris@1517 265 assert_tag :tag => 'issue',
Chris@1517 266 :child => {
Chris@1517 267 :tag => 'custom_fields',
Chris@1517 268 :attributes => { :type => 'array' },
Chris@1517 269 :child => {
Chris@1517 270 :tag => 'custom_field',
Chris@1517 271 :attributes => { :id => '1'},
Chris@1517 272 :child => {
Chris@1517 273 :tag => 'value',
Chris@1517 274 :content => 'MySQL'
Chris@1517 275 }
Chris@1517 276 }
Chris@1517 277 }
Chris@1517 278
Chris@1517 279 assert_nothing_raised do
Chris@1517 280 Hash.from_xml(response.body).to_xml
Chris@1517 281 end
Chris@1517 282 end
Chris@1517 283 end
Chris@1517 284 end
Chris@1517 285
Chris@1517 286 context "with multi custom fields" do
Chris@1517 287 setup do
Chris@1517 288 field = CustomField.find(1)
Chris@1517 289 field.update_attribute :multiple, true
Chris@1517 290 issue = Issue.find(3)
Chris@1517 291 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
Chris@1517 292 issue.save!
Chris@1517 293 end
Chris@1517 294
Chris@1517 295 context ".xml" do
Chris@1517 296 should "display custom fields" do
Chris@1517 297 get '/issues/3.xml'
Chris@1517 298 assert_response :success
Chris@1517 299 assert_tag :tag => 'issue',
Chris@1517 300 :child => {
Chris@1517 301 :tag => 'custom_fields',
Chris@1517 302 :attributes => { :type => 'array' },
Chris@1517 303 :child => {
Chris@1517 304 :tag => 'custom_field',
Chris@1517 305 :attributes => { :id => '1'},
Chris@1517 306 :child => {
Chris@1517 307 :tag => 'value',
Chris@1517 308 :attributes => { :type => 'array' },
Chris@1517 309 :children => { :count => 2 }
Chris@1517 310 }
Chris@1517 311 }
Chris@1517 312 }
Chris@1517 313
Chris@1517 314 xml = Hash.from_xml(response.body)
Chris@1517 315 custom_fields = xml['issue']['custom_fields']
Chris@1517 316 assert_kind_of Array, custom_fields
Chris@1517 317 field = custom_fields.detect {|f| f['id'] == '1'}
Chris@1517 318 assert_kind_of Hash, field
Chris@1517 319 assert_equal ['MySQL', 'Oracle'], field['value'].sort
Chris@1517 320 end
Chris@1517 321 end
Chris@1517 322
Chris@1517 323 context ".json" do
Chris@1517 324 should "display custom fields" do
Chris@1517 325 get '/issues/3.json'
Chris@1517 326 assert_response :success
Chris@1517 327 json = ActiveSupport::JSON.decode(response.body)
Chris@1517 328 custom_fields = json['issue']['custom_fields']
Chris@1517 329 assert_kind_of Array, custom_fields
Chris@1517 330 field = custom_fields.detect {|f| f['id'] == 1}
Chris@1517 331 assert_kind_of Hash, field
Chris@1517 332 assert_equal ['MySQL', 'Oracle'], field['value'].sort
Chris@1517 333 end
Chris@1517 334 end
Chris@1517 335 end
Chris@1517 336
Chris@1517 337 context "with empty value for multi custom field" do
Chris@1517 338 setup do
Chris@1517 339 field = CustomField.find(1)
Chris@1517 340 field.update_attribute :multiple, true
Chris@1517 341 issue = Issue.find(3)
Chris@1517 342 issue.custom_field_values = {1 => ['']}
Chris@1517 343 issue.save!
Chris@1517 344 end
Chris@1517 345
Chris@1517 346 context ".xml" do
Chris@1517 347 should "display custom fields" do
Chris@1517 348 get '/issues/3.xml'
Chris@1517 349 assert_response :success
Chris@1517 350 assert_tag :tag => 'issue',
Chris@1517 351 :child => {
Chris@1517 352 :tag => 'custom_fields',
Chris@1517 353 :attributes => { :type => 'array' },
Chris@1517 354 :child => {
Chris@1517 355 :tag => 'custom_field',
Chris@1517 356 :attributes => { :id => '1'},
Chris@1517 357 :child => {
Chris@1517 358 :tag => 'value',
Chris@1517 359 :attributes => { :type => 'array' },
Chris@1517 360 :children => { :count => 0 }
Chris@1517 361 }
Chris@1517 362 }
Chris@1517 363 }
Chris@1517 364
Chris@1517 365 xml = Hash.from_xml(response.body)
Chris@1517 366 custom_fields = xml['issue']['custom_fields']
Chris@1517 367 assert_kind_of Array, custom_fields
Chris@1517 368 field = custom_fields.detect {|f| f['id'] == '1'}
Chris@1517 369 assert_kind_of Hash, field
Chris@1517 370 assert_equal [], field['value']
Chris@1517 371 end
Chris@1517 372 end
Chris@1517 373
Chris@1517 374 context ".json" do
Chris@1517 375 should "display custom fields" do
Chris@1517 376 get '/issues/3.json'
Chris@1517 377 assert_response :success
Chris@1517 378 json = ActiveSupport::JSON.decode(response.body)
Chris@1517 379 custom_fields = json['issue']['custom_fields']
Chris@1517 380 assert_kind_of Array, custom_fields
Chris@1517 381 field = custom_fields.detect {|f| f['id'] == 1}
Chris@1517 382 assert_kind_of Hash, field
Chris@1517 383 assert_equal [], field['value'].sort
Chris@1517 384 end
Chris@1517 385 end
Chris@1517 386 end
Chris@1517 387
Chris@1517 388 context "with attachments" do
Chris@1517 389 context ".xml" do
Chris@1517 390 should "display attachments" do
Chris@1517 391 get '/issues/3.xml?include=attachments'
Chris@1517 392
Chris@1517 393 assert_tag :tag => 'issue',
Chris@1517 394 :child => {
Chris@1517 395 :tag => 'attachments',
Chris@1517 396 :children => {:count => 5},
Chris@1517 397 :child => {
Chris@1517 398 :tag => 'attachment',
Chris@1517 399 :child => {
Chris@1517 400 :tag => 'filename',
Chris@1517 401 :content => 'source.rb',
Chris@1517 402 :sibling => {
Chris@1517 403 :tag => 'content_url',
Chris@1517 404 :content => 'http://www.example.com/attachments/download/4/source.rb'
Chris@1517 405 }
Chris@1517 406 }
Chris@1517 407 }
Chris@1517 408 }
Chris@1517 409 end
Chris@1517 410 end
Chris@1517 411 end
Chris@1517 412
Chris@1517 413 context "with subtasks" do
Chris@1517 414 setup do
Chris@1517 415 @c1 = Issue.create!(
Chris@1517 416 :status_id => 1, :subject => "child c1",
Chris@1517 417 :tracker_id => 1, :project_id => 1, :author_id => 1,
Chris@1517 418 :parent_issue_id => 1
Chris@1517 419 )
Chris@1517 420 @c2 = Issue.create!(
Chris@1517 421 :status_id => 1, :subject => "child c2",
Chris@1517 422 :tracker_id => 1, :project_id => 1, :author_id => 1,
Chris@1517 423 :parent_issue_id => 1
Chris@1517 424 )
Chris@1517 425 @c3 = Issue.create!(
Chris@1517 426 :status_id => 1, :subject => "child c3",
Chris@1517 427 :tracker_id => 1, :project_id => 1, :author_id => 1,
Chris@1517 428 :parent_issue_id => @c1.id
Chris@1517 429 )
Chris@1517 430 end
Chris@1517 431
Chris@1517 432 context ".xml" do
Chris@1517 433 should "display children" do
Chris@1517 434 get '/issues/1.xml?include=children'
Chris@1517 435
Chris@1517 436 assert_tag :tag => 'issue',
Chris@1517 437 :child => {
Chris@1517 438 :tag => 'children',
Chris@1517 439 :children => {:count => 2},
Chris@1517 440 :child => {
Chris@1517 441 :tag => 'issue',
Chris@1517 442 :attributes => {:id => @c1.id.to_s},
Chris@1517 443 :child => {
Chris@1517 444 :tag => 'subject',
Chris@1517 445 :content => 'child c1',
Chris@1517 446 :sibling => {
Chris@1517 447 :tag => 'children',
Chris@1517 448 :children => {:count => 1},
Chris@1517 449 :child => {
Chris@1517 450 :tag => 'issue',
Chris@1517 451 :attributes => {:id => @c3.id.to_s}
Chris@1517 452 }
Chris@1517 453 }
Chris@1517 454 }
Chris@1517 455 }
Chris@1517 456 }
Chris@1517 457 end
Chris@1517 458
Chris@1517 459 context ".json" do
Chris@1517 460 should "display children" do
Chris@1517 461 get '/issues/1.json?include=children'
Chris@1517 462
Chris@1517 463 json = ActiveSupport::JSON.decode(response.body)
Chris@1517 464 assert_equal([
Chris@1517 465 {
Chris@1517 466 'id' => @c1.id, 'subject' => 'child c1', 'tracker' => {'id' => 1, 'name' => 'Bug'},
Chris@1517 467 'children' => [{'id' => @c3.id, 'subject' => 'child c3',
Chris@1517 468 'tracker' => {'id' => 1, 'name' => 'Bug'} }]
Chris@1517 469 },
Chris@1517 470 { 'id' => @c2.id, 'subject' => 'child c2', 'tracker' => {'id' => 1, 'name' => 'Bug'} }
Chris@1517 471 ],
Chris@1517 472 json['issue']['children'])
Chris@1517 473 end
Chris@1517 474 end
Chris@1517 475 end
Chris@1517 476 end
Chris@1517 477 end
Chris@1517 478
Chris@1517 479 test "GET /issues/:id.xml?include=watchers should include watchers" do
Chris@1517 480 Watcher.create!(:user_id => 3, :watchable => Issue.find(1))
Chris@1517 481
Chris@1517 482 get '/issues/1.xml?include=watchers', {}, credentials('jsmith')
Chris@1517 483
Chris@1517 484 assert_response :ok
Chris@1517 485 assert_equal 'application/xml', response.content_type
Chris@1517 486 assert_select 'issue' do
Chris@1517 487 assert_select 'watchers', Issue.find(1).watchers.count
Chris@1517 488 assert_select 'watchers' do
Chris@1517 489 assert_select 'user[id=3]'
Chris@1517 490 end
Chris@1517 491 end
Chris@1517 492 end
Chris@1517 493
Chris@1517 494 context "POST /issues.xml" do
Chris@1517 495 should_allow_api_authentication(
Chris@1517 496 :post,
Chris@1517 497 '/issues.xml',
Chris@1517 498 {:issue => {:project_id => 1, :subject => 'API test', :tracker_id => 2, :status_id => 3}},
Chris@1517 499 {:success_code => :created}
Chris@1517 500 )
Chris@1517 501 should "create an issue with the attributes" do
Chris@1517 502 assert_difference('Issue.count') do
Chris@1517 503 post '/issues.xml',
Chris@1517 504 {:issue => {:project_id => 1, :subject => 'API test',
Chris@1517 505 :tracker_id => 2, :status_id => 3}}, credentials('jsmith')
Chris@1517 506 end
Chris@1517 507 issue = Issue.order('id DESC').first
Chris@1517 508 assert_equal 1, issue.project_id
Chris@1517 509 assert_equal 2, issue.tracker_id
Chris@1517 510 assert_equal 3, issue.status_id
Chris@1517 511 assert_equal 'API test', issue.subject
Chris@1517 512
Chris@1517 513 assert_response :created
Chris@1517 514 assert_equal 'application/xml', @response.content_type
Chris@1517 515 assert_tag 'issue', :child => {:tag => 'id', :content => issue.id.to_s}
Chris@1517 516 end
Chris@1517 517 end
Chris@1517 518
Chris@1517 519 test "POST /issues.xml with watcher_user_ids should create issue with watchers" do
Chris@1517 520 assert_difference('Issue.count') do
Chris@1517 521 post '/issues.xml',
Chris@1517 522 {:issue => {:project_id => 1, :subject => 'Watchers',
Chris@1517 523 :tracker_id => 2, :status_id => 3, :watcher_user_ids => [3, 1]}}, credentials('jsmith')
Chris@1517 524 assert_response :created
Chris@1517 525 end
Chris@1517 526 issue = Issue.order('id desc').first
Chris@1517 527 assert_equal 2, issue.watchers.size
Chris@1517 528 assert_equal [1, 3], issue.watcher_user_ids.sort
Chris@1517 529 end
Chris@1517 530
Chris@1517 531 context "POST /issues.xml with failure" do
Chris@1517 532 should "have an errors tag" do
Chris@1517 533 assert_no_difference('Issue.count') do
Chris@1517 534 post '/issues.xml', {:issue => {:project_id => 1}}, credentials('jsmith')
Chris@1517 535 end
Chris@1517 536
Chris@1517 537 assert_tag :errors, :child => {:tag => 'error', :content => "Subject can't be blank"}
Chris@1517 538 end
Chris@1517 539 end
Chris@1517 540
Chris@1517 541 context "POST /issues.json" do
Chris@1517 542 should_allow_api_authentication(:post,
Chris@1517 543 '/issues.json',
Chris@1517 544 {:issue => {:project_id => 1, :subject => 'API test',
Chris@1517 545 :tracker_id => 2, :status_id => 3}},
Chris@1517 546 {:success_code => :created})
Chris@1517 547
Chris@1517 548 should "create an issue with the attributes" do
Chris@1517 549 assert_difference('Issue.count') do
Chris@1517 550 post '/issues.json',
Chris@1517 551 {:issue => {:project_id => 1, :subject => 'API test',
Chris@1517 552 :tracker_id => 2, :status_id => 3}},
Chris@1517 553 credentials('jsmith')
Chris@1517 554 end
Chris@1517 555
Chris@1517 556 issue = Issue.order('id DESC').first
Chris@1517 557 assert_equal 1, issue.project_id
Chris@1517 558 assert_equal 2, issue.tracker_id
Chris@1517 559 assert_equal 3, issue.status_id
Chris@1517 560 assert_equal 'API test', issue.subject
Chris@1517 561 end
Chris@1517 562
Chris@1517 563 end
Chris@1517 564
Chris@1517 565 context "POST /issues.json with failure" do
Chris@1517 566 should "have an errors element" do
Chris@1517 567 assert_no_difference('Issue.count') do
Chris@1517 568 post '/issues.json', {:issue => {:project_id => 1}}, credentials('jsmith')
Chris@1517 569 end
Chris@1517 570
Chris@1517 571 json = ActiveSupport::JSON.decode(response.body)
Chris@1517 572 assert json['errors'].include?("Subject can't be blank")
Chris@1517 573 end
Chris@1517 574 end
Chris@1517 575
Chris@1517 576 # Issue 6 is on a private project
Chris@1517 577 context "PUT /issues/6.xml" do
Chris@1517 578 setup do
Chris@1517 579 @parameters = {:issue => {:subject => 'API update', :notes => 'A new note'}}
Chris@1517 580 end
Chris@1517 581
Chris@1517 582 should_allow_api_authentication(:put,
Chris@1517 583 '/issues/6.xml',
Chris@1517 584 {:issue => {:subject => 'API update', :notes => 'A new note'}},
Chris@1517 585 {:success_code => :ok})
Chris@1517 586
Chris@1517 587 should "not create a new issue" do
Chris@1517 588 assert_no_difference('Issue.count') do
Chris@1517 589 put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1517 590 end
Chris@1517 591 end
Chris@1517 592
Chris@1517 593 should "create a new journal" do
Chris@1517 594 assert_difference('Journal.count') do
Chris@1517 595 put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1517 596 end
Chris@1517 597 end
Chris@1517 598
Chris@1517 599 should "add the note to the journal" do
Chris@1517 600 put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1517 601
Chris@1517 602 journal = Journal.last
Chris@1517 603 assert_equal "A new note", journal.notes
Chris@1517 604 end
Chris@1517 605
Chris@1517 606 should "update the issue" do
Chris@1517 607 put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1517 608
Chris@1517 609 issue = Issue.find(6)
Chris@1517 610 assert_equal "API update", issue.subject
Chris@1517 611 end
Chris@1517 612
Chris@1517 613 end
Chris@1517 614
Chris@1517 615 context "PUT /issues/3.xml with custom fields" do
Chris@1517 616 setup do
Chris@1517 617 @parameters = {
Chris@1517 618 :issue => {:custom_fields => [{'id' => '1', 'value' => 'PostgreSQL' },
Chris@1517 619 {'id' => '2', 'value' => '150'}]}
Chris@1517 620 }
Chris@1517 621 end
Chris@1517 622
Chris@1517 623 should "update custom fields" do
Chris@1517 624 assert_no_difference('Issue.count') do
Chris@1517 625 put '/issues/3.xml', @parameters, credentials('jsmith')
Chris@1517 626 end
Chris@1517 627
Chris@1517 628 issue = Issue.find(3)
Chris@1517 629 assert_equal '150', issue.custom_value_for(2).value
Chris@1517 630 assert_equal 'PostgreSQL', issue.custom_value_for(1).value
Chris@1517 631 end
Chris@1517 632 end
Chris@1517 633
Chris@1517 634 context "PUT /issues/3.xml with multi custom fields" do
Chris@1517 635 setup do
Chris@1517 636 field = CustomField.find(1)
Chris@1517 637 field.update_attribute :multiple, true
Chris@1517 638 @parameters = {
Chris@1517 639 :issue => {:custom_fields => [{'id' => '1', 'value' => ['MySQL', 'PostgreSQL'] },
Chris@1517 640 {'id' => '2', 'value' => '150'}]}
Chris@1517 641 }
Chris@1517 642 end
Chris@1517 643
Chris@1517 644 should "update custom fields" do
Chris@1517 645 assert_no_difference('Issue.count') do
Chris@1517 646 put '/issues/3.xml', @parameters, credentials('jsmith')
Chris@1517 647 end
Chris@1517 648
Chris@1517 649 issue = Issue.find(3)
Chris@1517 650 assert_equal '150', issue.custom_value_for(2).value
Chris@1517 651 assert_equal ['MySQL', 'PostgreSQL'], issue.custom_field_value(1).sort
Chris@1517 652 end
Chris@1517 653 end
Chris@1517 654
Chris@1517 655 context "PUT /issues/3.xml with project change" do
Chris@1517 656 setup do
Chris@1517 657 @parameters = {:issue => {:project_id => 2, :subject => 'Project changed'}}
Chris@1517 658 end
Chris@1517 659
Chris@1517 660 should "update project" do
Chris@1517 661 assert_no_difference('Issue.count') do
Chris@1517 662 put '/issues/3.xml', @parameters, credentials('jsmith')
Chris@1517 663 end
Chris@1517 664
Chris@1517 665 issue = Issue.find(3)
Chris@1517 666 assert_equal 2, issue.project_id
Chris@1517 667 assert_equal 'Project changed', issue.subject
Chris@1517 668 end
Chris@1517 669 end
Chris@1517 670
Chris@1517 671 context "PUT /issues/6.xml with failed update" do
Chris@1517 672 setup do
Chris@1517 673 @parameters = {:issue => {:subject => ''}}
Chris@1517 674 end
Chris@1517 675
Chris@1517 676 should "not create a new issue" do
Chris@1517 677 assert_no_difference('Issue.count') do
Chris@1517 678 put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1517 679 end
Chris@1517 680 end
Chris@1517 681
Chris@1517 682 should "not create a new journal" do
Chris@1517 683 assert_no_difference('Journal.count') do
Chris@1517 684 put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1517 685 end
Chris@1517 686 end
Chris@1517 687
Chris@1517 688 should "have an errors tag" do
Chris@1517 689 put '/issues/6.xml', @parameters, credentials('jsmith')
Chris@1517 690
Chris@1517 691 assert_tag :errors, :child => {:tag => 'error', :content => "Subject can't be blank"}
Chris@1517 692 end
Chris@1517 693 end
Chris@1517 694
Chris@1517 695 context "PUT /issues/6.json" do
Chris@1517 696 setup do
Chris@1517 697 @parameters = {:issue => {:subject => 'API update', :notes => 'A new note'}}
Chris@1517 698 end
Chris@1517 699
Chris@1517 700 should_allow_api_authentication(:put,
Chris@1517 701 '/issues/6.json',
Chris@1517 702 {:issue => {:subject => 'API update', :notes => 'A new note'}},
Chris@1517 703 {:success_code => :ok})
Chris@1517 704
Chris@1517 705 should "update the issue" do
Chris@1517 706 assert_no_difference('Issue.count') do
Chris@1517 707 assert_difference('Journal.count') do
Chris@1517 708 put '/issues/6.json', @parameters, credentials('jsmith')
Chris@1517 709
Chris@1517 710 assert_response :ok
Chris@1517 711 assert_equal '', response.body
Chris@1517 712 end
Chris@1517 713 end
Chris@1517 714
Chris@1517 715 issue = Issue.find(6)
Chris@1517 716 assert_equal "API update", issue.subject
Chris@1517 717 journal = Journal.last
Chris@1517 718 assert_equal "A new note", journal.notes
Chris@1517 719 end
Chris@1517 720 end
Chris@1517 721
Chris@1517 722 context "PUT /issues/6.json with failed update" do
Chris@1517 723 should "return errors" do
Chris@1517 724 assert_no_difference('Issue.count') do
Chris@1517 725 assert_no_difference('Journal.count') do
Chris@1517 726 put '/issues/6.json', {:issue => {:subject => ''}}, credentials('jsmith')
Chris@1517 727
Chris@1517 728 assert_response :unprocessable_entity
Chris@1517 729 end
Chris@1517 730 end
Chris@1517 731
Chris@1517 732 json = ActiveSupport::JSON.decode(response.body)
Chris@1517 733 assert json['errors'].include?("Subject can't be blank")
Chris@1517 734 end
Chris@1517 735 end
Chris@1517 736
Chris@1517 737 context "DELETE /issues/1.xml" do
Chris@1517 738 should_allow_api_authentication(:delete,
Chris@1517 739 '/issues/6.xml',
Chris@1517 740 {},
Chris@1517 741 {:success_code => :ok})
Chris@1517 742
Chris@1517 743 should "delete the issue" do
Chris@1517 744 assert_difference('Issue.count', -1) do
Chris@1517 745 delete '/issues/6.xml', {}, credentials('jsmith')
Chris@1517 746
Chris@1517 747 assert_response :ok
Chris@1517 748 assert_equal '', response.body
Chris@1517 749 end
Chris@1517 750
Chris@1517 751 assert_nil Issue.find_by_id(6)
Chris@1517 752 end
Chris@1517 753 end
Chris@1517 754
Chris@1517 755 context "DELETE /issues/1.json" do
Chris@1517 756 should_allow_api_authentication(:delete,
Chris@1517 757 '/issues/6.json',
Chris@1517 758 {},
Chris@1517 759 {:success_code => :ok})
Chris@1517 760
Chris@1517 761 should "delete the issue" do
Chris@1517 762 assert_difference('Issue.count', -1) do
Chris@1517 763 delete '/issues/6.json', {}, credentials('jsmith')
Chris@1517 764
Chris@1517 765 assert_response :ok
Chris@1517 766 assert_equal '', response.body
Chris@1517 767 end
Chris@1517 768
Chris@1517 769 assert_nil Issue.find_by_id(6)
Chris@1517 770 end
Chris@1517 771 end
Chris@1517 772
Chris@1517 773 test "POST /issues/:id/watchers.xml should add watcher" do
Chris@1517 774 assert_difference 'Watcher.count' do
Chris@1517 775 post '/issues/1/watchers.xml', {:user_id => 3}, credentials('jsmith')
Chris@1517 776
Chris@1517 777 assert_response :ok
Chris@1517 778 assert_equal '', response.body
Chris@1517 779 end
Chris@1517 780 watcher = Watcher.order('id desc').first
Chris@1517 781 assert_equal Issue.find(1), watcher.watchable
Chris@1517 782 assert_equal User.find(3), watcher.user
Chris@1517 783 end
Chris@1517 784
Chris@1517 785 test "DELETE /issues/:id/watchers/:user_id.xml should remove watcher" do
Chris@1517 786 Watcher.create!(:user_id => 3, :watchable => Issue.find(1))
Chris@1517 787
Chris@1517 788 assert_difference 'Watcher.count', -1 do
Chris@1517 789 delete '/issues/1/watchers/3.xml', {}, credentials('jsmith')
Chris@1517 790
Chris@1517 791 assert_response :ok
Chris@1517 792 assert_equal '', response.body
Chris@1517 793 end
Chris@1517 794 assert_equal false, Issue.find(1).watched_by?(User.find(3))
Chris@1517 795 end
Chris@1517 796
Chris@1517 797 def test_create_issue_with_uploaded_file
Chris@1517 798 set_tmp_attachments_directory
Chris@1517 799 # upload the file
Chris@1517 800 assert_difference 'Attachment.count' do
Chris@1517 801 post '/uploads.xml', 'test_create_with_upload',
Chris@1517 802 {"CONTENT_TYPE" => 'application/octet-stream'}.merge(credentials('jsmith'))
Chris@1517 803 assert_response :created
Chris@1517 804 end
Chris@1517 805 xml = Hash.from_xml(response.body)
Chris@1517 806 token = xml['upload']['token']
Chris@1517 807 attachment = Attachment.order('id DESC').first
Chris@1517 808
Chris@1517 809 # create the issue with the upload's token
Chris@1517 810 assert_difference 'Issue.count' do
Chris@1517 811 post '/issues.xml',
Chris@1517 812 {:issue => {:project_id => 1, :subject => 'Uploaded file',
Chris@1517 813 :uploads => [{:token => token, :filename => 'test.txt',
Chris@1517 814 :content_type => 'text/plain'}]}},
Chris@1517 815 credentials('jsmith')
Chris@1517 816 assert_response :created
Chris@1517 817 end
Chris@1517 818 issue = Issue.order('id DESC').first
Chris@1517 819 assert_equal 1, issue.attachments.count
Chris@1517 820 assert_equal attachment, issue.attachments.first
Chris@1517 821
Chris@1517 822 attachment.reload
Chris@1517 823 assert_equal 'test.txt', attachment.filename
Chris@1517 824 assert_equal 'text/plain', attachment.content_type
Chris@1517 825 assert_equal 'test_create_with_upload'.size, attachment.filesize
Chris@1517 826 assert_equal 2, attachment.author_id
Chris@1517 827
Chris@1517 828 # get the issue with its attachments
Chris@1517 829 get "/issues/#{issue.id}.xml", :include => 'attachments'
Chris@1517 830 assert_response :success
Chris@1517 831 xml = Hash.from_xml(response.body)
Chris@1517 832 attachments = xml['issue']['attachments']
Chris@1517 833 assert_kind_of Array, attachments
Chris@1517 834 assert_equal 1, attachments.size
Chris@1517 835 url = attachments.first['content_url']
Chris@1517 836 assert_not_nil url
Chris@1517 837
Chris@1517 838 # download the attachment
Chris@1517 839 get url
Chris@1517 840 assert_response :success
Chris@1517 841 end
Chris@1517 842
Chris@1517 843 def test_update_issue_with_uploaded_file
Chris@1517 844 set_tmp_attachments_directory
Chris@1517 845 # upload the file
Chris@1517 846 assert_difference 'Attachment.count' do
Chris@1517 847 post '/uploads.xml', 'test_upload_with_upload',
Chris@1517 848 {"CONTENT_TYPE" => 'application/octet-stream'}.merge(credentials('jsmith'))
Chris@1517 849 assert_response :created
Chris@1517 850 end
Chris@1517 851 xml = Hash.from_xml(response.body)
Chris@1517 852 token = xml['upload']['token']
Chris@1517 853 attachment = Attachment.order('id DESC').first
Chris@1517 854
Chris@1517 855 # update the issue with the upload's token
Chris@1517 856 assert_difference 'Journal.count' do
Chris@1517 857 put '/issues/1.xml',
Chris@1517 858 {:issue => {:notes => 'Attachment added',
Chris@1517 859 :uploads => [{:token => token, :filename => 'test.txt',
Chris@1517 860 :content_type => 'text/plain'}]}},
Chris@1517 861 credentials('jsmith')
Chris@1517 862 assert_response :ok
Chris@1517 863 assert_equal '', @response.body
Chris@1517 864 end
Chris@1517 865
Chris@1517 866 issue = Issue.find(1)
Chris@1517 867 assert_include attachment, issue.attachments
Chris@1517 868 end
Chris@1517 869 end