annotate .svn/pristine/10/10cf6c62a2177b6e4b8375c93a35de2b98eadb96.svn-base @ 1524:82fac3dcf466 redmine-2.5-integration

Fix failure to interpret Javascript when autocompleting members for project
author Chris Cannam <chris.cannam@soundsoftware.ac.uk>
date Thu, 11 Sep 2014 10:24:38 +0100
parents dffacf8a6908
children
rev   line source
Chris@1517 1 # Redmine - project management software
Chris@1517 2 # Copyright (C) 2006-2014 Jean-Philippe Lang
Chris@1517 3 #
Chris@1517 4 # This program is free software; you can redistribute it and/or
Chris@1517 5 # modify it under the terms of the GNU General Public License
Chris@1517 6 # as published by the Free Software Foundation; either version 2
Chris@1517 7 # of the License, or (at your option) any later version.
Chris@1517 8 #
Chris@1517 9 # This program is distributed in the hope that it will be useful,
Chris@1517 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1517 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@1517 12 # GNU General Public License for more details.
Chris@1517 13 #
Chris@1517 14 # You should have received a copy of the GNU General Public License
Chris@1517 15 # along with this program; if not, write to the Free Software
Chris@1517 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@1517 17
Chris@1517 18 class Version < ActiveRecord::Base
Chris@1517 19 include Redmine::SafeAttributes
Chris@1517 20 after_update :update_issues_from_sharing_change
Chris@1517 21 belongs_to :project
Chris@1517 22 has_many :fixed_issues, :class_name => 'Issue', :foreign_key => 'fixed_version_id', :dependent => :nullify
Chris@1517 23 acts_as_customizable
Chris@1517 24 acts_as_attachable :view_permission => :view_files,
Chris@1517 25 :delete_permission => :manage_files
Chris@1517 26
Chris@1517 27 VERSION_STATUSES = %w(open locked closed)
Chris@1517 28 VERSION_SHARINGS = %w(none descendants hierarchy tree system)
Chris@1517 29
Chris@1517 30 validates_presence_of :name
Chris@1517 31 validates_uniqueness_of :name, :scope => [:project_id]
Chris@1517 32 validates_length_of :name, :maximum => 60
Chris@1517 33 validates :effective_date, :date => true
Chris@1517 34 validates_inclusion_of :status, :in => VERSION_STATUSES
Chris@1517 35 validates_inclusion_of :sharing, :in => VERSION_SHARINGS
Chris@1517 36
Chris@1517 37 scope :named, lambda {|arg| where("LOWER(#{table_name}.name) = LOWER(?)", arg.to_s.strip)}
Chris@1517 38 scope :open, lambda { where(:status => 'open') }
Chris@1517 39 scope :visible, lambda {|*args|
Chris@1517 40 includes(:project).where(Project.allowed_to_condition(args.first || User.current, :view_issues))
Chris@1517 41 }
Chris@1517 42
Chris@1517 43 safe_attributes 'name',
Chris@1517 44 'description',
Chris@1517 45 'effective_date',
Chris@1517 46 'due_date',
Chris@1517 47 'wiki_page_title',
Chris@1517 48 'status',
Chris@1517 49 'sharing',
Chris@1517 50 'custom_field_values',
Chris@1517 51 'custom_fields'
Chris@1517 52
Chris@1517 53 # Returns true if +user+ or current user is allowed to view the version
Chris@1517 54 def visible?(user=User.current)
Chris@1517 55 user.allowed_to?(:view_issues, self.project)
Chris@1517 56 end
Chris@1517 57
Chris@1517 58 # Version files have same visibility as project files
Chris@1517 59 def attachments_visible?(*args)
Chris@1517 60 project.present? && project.attachments_visible?(*args)
Chris@1517 61 end
Chris@1517 62
Chris@1517 63 def start_date
Chris@1517 64 @start_date ||= fixed_issues.minimum('start_date')
Chris@1517 65 end
Chris@1517 66
Chris@1517 67 def due_date
Chris@1517 68 effective_date
Chris@1517 69 end
Chris@1517 70
Chris@1517 71 def due_date=(arg)
Chris@1517 72 self.effective_date=(arg)
Chris@1517 73 end
Chris@1517 74
Chris@1517 75 # Returns the total estimated time for this version
Chris@1517 76 # (sum of leaves estimated_hours)
Chris@1517 77 def estimated_hours
Chris@1517 78 @estimated_hours ||= fixed_issues.leaves.sum(:estimated_hours).to_f
Chris@1517 79 end
Chris@1517 80
Chris@1517 81 # Returns the total reported time for this version
Chris@1517 82 def spent_hours
Chris@1517 83 @spent_hours ||= TimeEntry.joins(:issue).where("#{Issue.table_name}.fixed_version_id = ?", id).sum(:hours).to_f
Chris@1517 84 end
Chris@1517 85
Chris@1517 86 def closed?
Chris@1517 87 status == 'closed'
Chris@1517 88 end
Chris@1517 89
Chris@1517 90 def open?
Chris@1517 91 status == 'open'
Chris@1517 92 end
Chris@1517 93
Chris@1517 94 # Returns true if the version is completed: due date reached and no open issues
Chris@1517 95 def completed?
Chris@1517 96 effective_date && (effective_date < Date.today) && (open_issues_count == 0)
Chris@1517 97 end
Chris@1517 98
Chris@1517 99 def behind_schedule?
Chris@1517 100 if completed_percent == 100
Chris@1517 101 return false
Chris@1517 102 elsif due_date && start_date
Chris@1517 103 done_date = start_date + ((due_date - start_date+1)* completed_percent/100).floor
Chris@1517 104 return done_date <= Date.today
Chris@1517 105 else
Chris@1517 106 false # No issues so it's not late
Chris@1517 107 end
Chris@1517 108 end
Chris@1517 109
Chris@1517 110 # Returns the completion percentage of this version based on the amount of open/closed issues
Chris@1517 111 # and the time spent on the open issues.
Chris@1517 112 def completed_percent
Chris@1517 113 if issues_count == 0
Chris@1517 114 0
Chris@1517 115 elsif open_issues_count == 0
Chris@1517 116 100
Chris@1517 117 else
Chris@1517 118 issues_progress(false) + issues_progress(true)
Chris@1517 119 end
Chris@1517 120 end
Chris@1517 121
Chris@1517 122 # TODO: remove in Redmine 3.0
Chris@1517 123 def completed_pourcent
Chris@1517 124 ActiveSupport::Deprecation.warn "Version#completed_pourcent is deprecated and will be removed in Redmine 3.0. Please use #completed_percent instead."
Chris@1517 125 completed_percent
Chris@1517 126 end
Chris@1517 127
Chris@1517 128 # Returns the percentage of issues that have been marked as 'closed'.
Chris@1517 129 def closed_percent
Chris@1517 130 if issues_count == 0
Chris@1517 131 0
Chris@1517 132 else
Chris@1517 133 issues_progress(false)
Chris@1517 134 end
Chris@1517 135 end
Chris@1517 136
Chris@1517 137 # TODO: remove in Redmine 3.0
Chris@1517 138 def closed_pourcent
Chris@1517 139 ActiveSupport::Deprecation.warn "Version#closed_pourcent is deprecated and will be removed in Redmine 3.0. Please use #closed_percent instead."
Chris@1517 140 closed_percent
Chris@1517 141 end
Chris@1517 142
Chris@1517 143 # Returns true if the version is overdue: due date reached and some open issues
Chris@1517 144 def overdue?
Chris@1517 145 effective_date && (effective_date < Date.today) && (open_issues_count > 0)
Chris@1517 146 end
Chris@1517 147
Chris@1517 148 # Returns assigned issues count
Chris@1517 149 def issues_count
Chris@1517 150 load_issue_counts
Chris@1517 151 @issue_count
Chris@1517 152 end
Chris@1517 153
Chris@1517 154 # Returns the total amount of open issues for this version.
Chris@1517 155 def open_issues_count
Chris@1517 156 load_issue_counts
Chris@1517 157 @open_issues_count
Chris@1517 158 end
Chris@1517 159
Chris@1517 160 # Returns the total amount of closed issues for this version.
Chris@1517 161 def closed_issues_count
Chris@1517 162 load_issue_counts
Chris@1517 163 @closed_issues_count
Chris@1517 164 end
Chris@1517 165
Chris@1517 166 def wiki_page
Chris@1517 167 if project.wiki && !wiki_page_title.blank?
Chris@1517 168 @wiki_page ||= project.wiki.find_page(wiki_page_title)
Chris@1517 169 end
Chris@1517 170 @wiki_page
Chris@1517 171 end
Chris@1517 172
Chris@1517 173 def to_s; name end
Chris@1517 174
Chris@1517 175 def to_s_with_project
Chris@1517 176 "#{project} - #{name}"
Chris@1517 177 end
Chris@1517 178
Chris@1517 179 # Versions are sorted by effective_date and name
Chris@1517 180 # Those with no effective_date are at the end, sorted by name
Chris@1517 181 def <=>(version)
Chris@1517 182 if self.effective_date
Chris@1517 183 if version.effective_date
Chris@1517 184 if self.effective_date == version.effective_date
Chris@1517 185 name == version.name ? id <=> version.id : name <=> version.name
Chris@1517 186 else
Chris@1517 187 self.effective_date <=> version.effective_date
Chris@1517 188 end
Chris@1517 189 else
Chris@1517 190 -1
Chris@1517 191 end
Chris@1517 192 else
Chris@1517 193 if version.effective_date
Chris@1517 194 1
Chris@1517 195 else
Chris@1517 196 name == version.name ? id <=> version.id : name <=> version.name
Chris@1517 197 end
Chris@1517 198 end
Chris@1517 199 end
Chris@1517 200
Chris@1517 201 def self.fields_for_order_statement(table=nil)
Chris@1517 202 table ||= table_name
Chris@1517 203 ["(CASE WHEN #{table}.effective_date IS NULL THEN 1 ELSE 0 END)", "#{table}.effective_date", "#{table}.name", "#{table}.id"]
Chris@1517 204 end
Chris@1517 205
Chris@1517 206 scope :sorted, lambda { order(fields_for_order_statement) }
Chris@1517 207
Chris@1517 208 # Returns the sharings that +user+ can set the version to
Chris@1517 209 def allowed_sharings(user = User.current)
Chris@1517 210 VERSION_SHARINGS.select do |s|
Chris@1517 211 if sharing == s
Chris@1517 212 true
Chris@1517 213 else
Chris@1517 214 case s
Chris@1517 215 when 'system'
Chris@1517 216 # Only admin users can set a systemwide sharing
Chris@1517 217 user.admin?
Chris@1517 218 when 'hierarchy', 'tree'
Chris@1517 219 # Only users allowed to manage versions of the root project can
Chris@1517 220 # set sharing to hierarchy or tree
Chris@1517 221 project.nil? || user.allowed_to?(:manage_versions, project.root)
Chris@1517 222 else
Chris@1517 223 true
Chris@1517 224 end
Chris@1517 225 end
Chris@1517 226 end
Chris@1517 227 end
Chris@1517 228
Chris@1517 229 private
Chris@1517 230
Chris@1517 231 def load_issue_counts
Chris@1517 232 unless @issue_count
Chris@1517 233 @open_issues_count = 0
Chris@1517 234 @closed_issues_count = 0
Chris@1517 235 fixed_issues.group(:status).count.each do |status, count|
Chris@1517 236 if status.is_closed?
Chris@1517 237 @closed_issues_count += count
Chris@1517 238 else
Chris@1517 239 @open_issues_count += count
Chris@1517 240 end
Chris@1517 241 end
Chris@1517 242 @issue_count = @open_issues_count + @closed_issues_count
Chris@1517 243 end
Chris@1517 244 end
Chris@1517 245
Chris@1517 246 # Update the issue's fixed versions. Used if a version's sharing changes.
Chris@1517 247 def update_issues_from_sharing_change
Chris@1517 248 if sharing_changed?
Chris@1517 249 if VERSION_SHARINGS.index(sharing_was).nil? ||
Chris@1517 250 VERSION_SHARINGS.index(sharing).nil? ||
Chris@1517 251 VERSION_SHARINGS.index(sharing_was) > VERSION_SHARINGS.index(sharing)
Chris@1517 252 Issue.update_versions_from_sharing_change self
Chris@1517 253 end
Chris@1517 254 end
Chris@1517 255 end
Chris@1517 256
Chris@1517 257 # Returns the average estimated time of assigned issues
Chris@1517 258 # or 1 if no issue has an estimated time
Chris@1517 259 # Used to weigth unestimated issues in progress calculation
Chris@1517 260 def estimated_average
Chris@1517 261 if @estimated_average.nil?
Chris@1517 262 average = fixed_issues.average(:estimated_hours).to_f
Chris@1517 263 if average == 0
Chris@1517 264 average = 1
Chris@1517 265 end
Chris@1517 266 @estimated_average = average
Chris@1517 267 end
Chris@1517 268 @estimated_average
Chris@1517 269 end
Chris@1517 270
Chris@1517 271 # Returns the total progress of open or closed issues. The returned percentage takes into account
Chris@1517 272 # the amount of estimated time set for this version.
Chris@1517 273 #
Chris@1517 274 # Examples:
Chris@1517 275 # issues_progress(true) => returns the progress percentage for open issues.
Chris@1517 276 # issues_progress(false) => returns the progress percentage for closed issues.
Chris@1517 277 def issues_progress(open)
Chris@1517 278 @issues_progress ||= {}
Chris@1517 279 @issues_progress[open] ||= begin
Chris@1517 280 progress = 0
Chris@1517 281 if issues_count > 0
Chris@1517 282 ratio = open ? 'done_ratio' : 100
Chris@1517 283
Chris@1517 284 done = fixed_issues.open(open).sum("COALESCE(estimated_hours, #{estimated_average}) * #{ratio}").to_f
Chris@1517 285 progress = done / (estimated_average * issues_count)
Chris@1517 286 end
Chris@1517 287 progress
Chris@1517 288 end
Chris@1517 289 end
Chris@1517 290 end