annotate .svn/pristine/04/046d428ac69934d1d2d0ae1a160753bb78acb462.svn-base @ 1524:82fac3dcf466 redmine-2.5-integration

Fix failure to interpret Javascript when autocompleting members for project
author Chris Cannam <chris.cannam@soundsoftware.ac.uk>
date Thu, 11 Sep 2014 10:24:38 +0100
parents e248c7af89ec
children
rev   line source
Chris@1494 1 # Redmine - project management software
Chris@1494 2 # Copyright (C) 2006-2014 Jean-Philippe Lang
Chris@1494 3 #
Chris@1494 4 # This program is free software; you can redistribute it and/or
Chris@1494 5 # modify it under the terms of the GNU General Public License
Chris@1494 6 # as published by the Free Software Foundation; either version 2
Chris@1494 7 # of the License, or (at your option) any later version.
Chris@1494 8 #
Chris@1494 9 # This program is distributed in the hope that it will be useful,
Chris@1494 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1494 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@1494 12 # GNU General Public License for more details.
Chris@1494 13 #
Chris@1494 14 # You should have received a copy of the GNU General Public License
Chris@1494 15 # along with this program; if not, write to the Free Software
Chris@1494 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@1494 17
Chris@1494 18 require File.expand_path('../../test_helper', __FILE__)
Chris@1494 19
Chris@1494 20 class CustomFieldTest < ActiveSupport::TestCase
Chris@1494 21 fixtures :custom_fields
Chris@1494 22
Chris@1494 23 def test_create
Chris@1494 24 field = UserCustomField.new(:name => 'Money money money', :field_format => 'float')
Chris@1494 25 assert field.save
Chris@1494 26 end
Chris@1494 27
Chris@1494 28 def test_before_validation
Chris@1494 29 field = CustomField.new(:name => 'test_before_validation', :field_format => 'int')
Chris@1494 30 field.searchable = true
Chris@1494 31 assert field.save
Chris@1494 32 assert_equal false, field.searchable
Chris@1494 33 field.searchable = true
Chris@1494 34 assert field.save
Chris@1494 35 assert_equal false, field.searchable
Chris@1494 36 end
Chris@1494 37
Chris@1494 38 def test_regexp_validation
Chris@1494 39 field = IssueCustomField.new(:name => 'regexp', :field_format => 'text', :regexp => '[a-z0-9')
Chris@1494 40 assert !field.save
Chris@1494 41 assert_include I18n.t('activerecord.errors.messages.invalid'),
Chris@1494 42 field.errors[:regexp]
Chris@1494 43 field.regexp = '[a-z0-9]'
Chris@1494 44 assert field.save
Chris@1494 45 end
Chris@1494 46
Chris@1494 47 def test_default_value_should_be_validated
Chris@1494 48 field = CustomField.new(:name => 'Test', :field_format => 'int')
Chris@1494 49 field.default_value = 'abc'
Chris@1494 50 assert !field.valid?
Chris@1494 51 field.default_value = '6'
Chris@1494 52 assert field.valid?
Chris@1494 53 end
Chris@1494 54
Chris@1494 55 def test_default_value_should_not_be_validated_when_blank
Chris@1494 56 field = CustomField.new(:name => 'Test', :field_format => 'list', :possible_values => ['a', 'b'], :is_required => true, :default_value => '')
Chris@1494 57 assert field.valid?
Chris@1494 58 end
Chris@1494 59
Chris@1494 60 def test_field_format_should_be_validated
Chris@1494 61 field = CustomField.new(:name => 'Test', :field_format => 'foo')
Chris@1494 62 assert !field.valid?
Chris@1494 63 end
Chris@1494 64
Chris@1494 65 def test_field_format_validation_should_accept_formats_added_at_runtime
Chris@1494 66 Redmine::CustomFieldFormat.register 'foobar'
Chris@1494 67
Chris@1494 68 field = CustomField.new(:name => 'Some Custom Field', :field_format => 'foobar')
Chris@1494 69 assert field.valid?, 'field should be valid'
Chris@1494 70 ensure
Chris@1494 71 Redmine::CustomFieldFormat.delete 'foobar'
Chris@1494 72 end
Chris@1494 73
Chris@1494 74 def test_should_not_change_field_format_of_existing_custom_field
Chris@1494 75 field = CustomField.find(1)
Chris@1494 76 field.field_format = 'int'
Chris@1494 77 assert_equal 'list', field.field_format
Chris@1494 78 end
Chris@1494 79
Chris@1494 80 def test_possible_values_should_accept_an_array
Chris@1494 81 field = CustomField.new
Chris@1494 82 field.possible_values = ["One value", ""]
Chris@1494 83 assert_equal ["One value"], field.possible_values
Chris@1494 84 end
Chris@1494 85
Chris@1494 86 def test_possible_values_should_accept_a_string
Chris@1494 87 field = CustomField.new
Chris@1494 88 field.possible_values = "One value"
Chris@1494 89 assert_equal ["One value"], field.possible_values
Chris@1494 90 end
Chris@1494 91
Chris@1494 92 def test_possible_values_should_accept_a_multiline_string
Chris@1494 93 field = CustomField.new
Chris@1494 94 field.possible_values = "One value\nAnd another one \r\n \n"
Chris@1494 95 assert_equal ["One value", "And another one"], field.possible_values
Chris@1494 96 end
Chris@1494 97
Chris@1494 98 if "string".respond_to?(:encoding)
Chris@1494 99 def test_possible_values_stored_as_binary_should_be_utf8_encoded
Chris@1494 100 field = CustomField.find(11)
Chris@1494 101 assert_kind_of Array, field.possible_values
Chris@1494 102 assert field.possible_values.size > 0
Chris@1494 103 field.possible_values.each do |value|
Chris@1494 104 assert_equal "UTF-8", value.encoding.name
Chris@1494 105 end
Chris@1494 106 end
Chris@1494 107 end
Chris@1494 108
Chris@1494 109 def test_destroy
Chris@1494 110 field = CustomField.find(1)
Chris@1494 111 assert field.destroy
Chris@1494 112 end
Chris@1494 113
Chris@1494 114 def test_new_subclass_instance_should_return_an_instance
Chris@1494 115 f = CustomField.new_subclass_instance('IssueCustomField')
Chris@1494 116 assert_kind_of IssueCustomField, f
Chris@1494 117 end
Chris@1494 118
Chris@1494 119 def test_new_subclass_instance_should_set_attributes
Chris@1494 120 f = CustomField.new_subclass_instance('IssueCustomField', :name => 'Test')
Chris@1494 121 assert_kind_of IssueCustomField, f
Chris@1494 122 assert_equal 'Test', f.name
Chris@1494 123 end
Chris@1494 124
Chris@1494 125 def test_new_subclass_instance_with_invalid_class_name_should_return_nil
Chris@1494 126 assert_nil CustomField.new_subclass_instance('WrongClassName')
Chris@1494 127 end
Chris@1494 128
Chris@1494 129 def test_new_subclass_instance_with_non_subclass_name_should_return_nil
Chris@1494 130 assert_nil CustomField.new_subclass_instance('Project')
Chris@1494 131 end
Chris@1494 132
Chris@1494 133 def test_string_field_validation_with_blank_value
Chris@1494 134 f = CustomField.new(:field_format => 'string')
Chris@1494 135
Chris@1494 136 assert f.valid_field_value?(nil)
Chris@1494 137 assert f.valid_field_value?('')
Chris@1494 138
Chris@1494 139 f.is_required = true
Chris@1494 140 assert !f.valid_field_value?(nil)
Chris@1494 141 assert !f.valid_field_value?('')
Chris@1494 142 end
Chris@1494 143
Chris@1494 144 def test_string_field_validation_with_min_and_max_lengths
Chris@1494 145 f = CustomField.new(:field_format => 'string', :min_length => 2, :max_length => 5)
Chris@1494 146
Chris@1494 147 assert f.valid_field_value?(nil)
Chris@1494 148 assert f.valid_field_value?('')
Chris@1494 149 assert !f.valid_field_value?(' ')
Chris@1494 150 assert f.valid_field_value?('a' * 2)
Chris@1494 151 assert !f.valid_field_value?('a')
Chris@1494 152 assert !f.valid_field_value?('a' * 6)
Chris@1494 153 end
Chris@1494 154
Chris@1494 155 def test_string_field_validation_with_regexp
Chris@1494 156 f = CustomField.new(:field_format => 'string', :regexp => '^[A-Z0-9]*$')
Chris@1494 157
Chris@1494 158 assert f.valid_field_value?(nil)
Chris@1494 159 assert f.valid_field_value?('')
Chris@1494 160 assert !f.valid_field_value?(' ')
Chris@1494 161 assert f.valid_field_value?('ABC')
Chris@1494 162 assert !f.valid_field_value?('abc')
Chris@1494 163 end
Chris@1494 164
Chris@1494 165 def test_date_field_validation
Chris@1494 166 f = CustomField.new(:field_format => 'date')
Chris@1494 167
Chris@1494 168 assert f.valid_field_value?(nil)
Chris@1494 169 assert f.valid_field_value?('')
Chris@1494 170 assert !f.valid_field_value?(' ')
Chris@1494 171 assert f.valid_field_value?('1975-07-14')
Chris@1494 172 assert !f.valid_field_value?('1975-07-33')
Chris@1494 173 assert !f.valid_field_value?('abc')
Chris@1494 174 end
Chris@1494 175
Chris@1494 176 def test_list_field_validation
Chris@1494 177 f = CustomField.new(:field_format => 'list', :possible_values => ['value1', 'value2'])
Chris@1494 178
Chris@1494 179 assert f.valid_field_value?(nil)
Chris@1494 180 assert f.valid_field_value?('')
Chris@1494 181 assert !f.valid_field_value?(' ')
Chris@1494 182 assert f.valid_field_value?('value2')
Chris@1494 183 assert !f.valid_field_value?('abc')
Chris@1494 184 end
Chris@1494 185
Chris@1494 186 def test_int_field_validation
Chris@1494 187 f = CustomField.new(:field_format => 'int')
Chris@1494 188
Chris@1494 189 assert f.valid_field_value?(nil)
Chris@1494 190 assert f.valid_field_value?('')
Chris@1494 191 assert !f.valid_field_value?(' ')
Chris@1494 192 assert f.valid_field_value?('123')
Chris@1494 193 assert f.valid_field_value?('+123')
Chris@1494 194 assert f.valid_field_value?('-123')
Chris@1494 195 assert !f.valid_field_value?('6abc')
Chris@1494 196 end
Chris@1494 197
Chris@1494 198 def test_float_field_validation
Chris@1494 199 f = CustomField.new(:field_format => 'float')
Chris@1494 200
Chris@1494 201 assert f.valid_field_value?(nil)
Chris@1494 202 assert f.valid_field_value?('')
Chris@1494 203 assert !f.valid_field_value?(' ')
Chris@1494 204 assert f.valid_field_value?('11.2')
Chris@1494 205 assert f.valid_field_value?('-6.250')
Chris@1494 206 assert f.valid_field_value?('5')
Chris@1494 207 assert !f.valid_field_value?('6abc')
Chris@1494 208 end
Chris@1494 209
Chris@1494 210 def test_multi_field_validation
Chris@1494 211 f = CustomField.new(:field_format => 'list', :multiple => 'true', :possible_values => ['value1', 'value2'])
Chris@1494 212
Chris@1494 213 assert f.valid_field_value?(nil)
Chris@1494 214 assert f.valid_field_value?('')
Chris@1494 215 assert !f.valid_field_value?(' ')
Chris@1494 216 assert f.valid_field_value?([])
Chris@1494 217 assert f.valid_field_value?([nil])
Chris@1494 218 assert f.valid_field_value?([''])
Chris@1494 219 assert !f.valid_field_value?([' '])
Chris@1494 220
Chris@1494 221 assert f.valid_field_value?('value2')
Chris@1494 222 assert !f.valid_field_value?('abc')
Chris@1494 223
Chris@1494 224 assert f.valid_field_value?(['value2'])
Chris@1494 225 assert !f.valid_field_value?(['abc'])
Chris@1494 226
Chris@1494 227 assert f.valid_field_value?(['', 'value2'])
Chris@1494 228 assert !f.valid_field_value?(['', 'abc'])
Chris@1494 229
Chris@1494 230 assert f.valid_field_value?(['value1', 'value2'])
Chris@1494 231 assert !f.valid_field_value?(['value1', 'abc'])
Chris@1494 232 end
Chris@1494 233
Chris@1494 234 def test_changing_multiple_to_false_should_delete_multiple_values
Chris@1494 235 field = ProjectCustomField.create!(:name => 'field', :field_format => 'list', :multiple => 'true', :possible_values => ['field1', 'field2'])
Chris@1494 236 other = ProjectCustomField.create!(:name => 'other', :field_format => 'list', :multiple => 'true', :possible_values => ['other1', 'other2'])
Chris@1494 237
Chris@1494 238 item_with_multiple_values = Project.generate!(:custom_field_values => {field.id => ['field1', 'field2'], other.id => ['other1', 'other2']})
Chris@1494 239 item_with_single_values = Project.generate!(:custom_field_values => {field.id => ['field1'], other.id => ['other2']})
Chris@1494 240
Chris@1494 241 assert_difference 'CustomValue.count', -1 do
Chris@1494 242 field.multiple = false
Chris@1494 243 field.save!
Chris@1494 244 end
Chris@1494 245
Chris@1494 246 item_with_multiple_values = Project.find(item_with_multiple_values.id)
Chris@1494 247 assert_kind_of String, item_with_multiple_values.custom_field_value(field)
Chris@1494 248 assert_kind_of Array, item_with_multiple_values.custom_field_value(other)
Chris@1494 249 assert_equal 2, item_with_multiple_values.custom_field_value(other).size
Chris@1494 250 end
Chris@1494 251
Chris@1494 252 def test_value_class_should_return_the_class_used_for_fields_values
Chris@1494 253 assert_equal User, CustomField.new(:field_format => 'user').value_class
Chris@1494 254 assert_equal Version, CustomField.new(:field_format => 'version').value_class
Chris@1494 255 end
Chris@1494 256
Chris@1494 257 def test_value_class_should_return_nil_for_other_fields
Chris@1494 258 assert_nil CustomField.new(:field_format => 'text').value_class
Chris@1494 259 assert_nil CustomField.new.value_class
Chris@1494 260 end
Chris@1494 261
Chris@1494 262 def test_value_from_keyword_for_list_custom_field
Chris@1494 263 field = CustomField.find(1)
Chris@1494 264 assert_equal 'PostgreSQL', field.value_from_keyword('postgresql', Issue.find(1))
Chris@1494 265 end
Chris@1494 266
Chris@1494 267 def test_visibile_scope_with_admin_should_return_all_custom_fields
Chris@1494 268 CustomField.delete_all
Chris@1494 269 fields = [
Chris@1494 270 CustomField.generate!(:visible => true),
Chris@1494 271 CustomField.generate!(:visible => false),
Chris@1494 272 CustomField.generate!(:visible => false, :role_ids => [1, 3]),
Chris@1494 273 CustomField.generate!(:visible => false, :role_ids => [1, 2]),
Chris@1494 274 ]
Chris@1494 275
Chris@1494 276 assert_equal 4, CustomField.visible(User.find(1)).count
Chris@1494 277 end
Chris@1494 278
Chris@1494 279 def test_visibile_scope_with_non_admin_user_should_return_visible_custom_fields
Chris@1494 280 CustomField.delete_all
Chris@1494 281 fields = [
Chris@1494 282 CustomField.generate!(:visible => true),
Chris@1494 283 CustomField.generate!(:visible => false),
Chris@1494 284 CustomField.generate!(:visible => false, :role_ids => [1, 3]),
Chris@1494 285 CustomField.generate!(:visible => false, :role_ids => [1, 2]),
Chris@1494 286 ]
Chris@1494 287 user = User.generate!
Chris@1494 288 User.add_to_project(user, Project.first, Role.find(3))
Chris@1494 289
Chris@1494 290 assert_equal [fields[0], fields[2]], CustomField.visible(user).order("id").to_a
Chris@1494 291 end
Chris@1494 292
Chris@1494 293 def test_visibile_scope_with_anonymous_user_should_return_visible_custom_fields
Chris@1494 294 CustomField.delete_all
Chris@1494 295 fields = [
Chris@1494 296 CustomField.generate!(:visible => true),
Chris@1494 297 CustomField.generate!(:visible => false),
Chris@1494 298 CustomField.generate!(:visible => false, :role_ids => [1, 3]),
Chris@1494 299 CustomField.generate!(:visible => false, :role_ids => [1, 2]),
Chris@1494 300 ]
Chris@1494 301
Chris@1494 302 assert_equal [fields[0]], CustomField.visible(User.anonymous).order("id").to_a
Chris@1494 303 end
Chris@1494 304 end