annotate .svn/pristine/a5/a5c130bb9c2df01fd9aed379af31f013bd32b083.svn-base @ 1519:afce8026aaeb redmine-2.4-integration

Merge from branch "live"
author Chris Cannam
date Tue, 09 Sep 2014 09:34:53 +0100
parents cbb26bc654de
children
rev   line source
Chris@909 1 # Redmine - project management software
Chris@909 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
Chris@909 3 #
Chris@909 4 # This program is free software; you can redistribute it and/or
Chris@909 5 # modify it under the terms of the GNU General Public License
Chris@909 6 # as published by the Free Software Foundation; either version 2
Chris@909 7 # of the License, or (at your option) any later version.
Chris@909 8 #
Chris@909 9 # This program is distributed in the hope that it will be useful,
Chris@909 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@909 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@909 12 # GNU General Public License for more details.
Chris@909 13 #
Chris@909 14 # You should have received a copy of the GNU General Public License
Chris@909 15 # along with this program; if not, write to the Free Software
Chris@909 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@909 17
Chris@909 18 require File.expand_path('../../test_helper', __FILE__)
Chris@909 19 require 'users_controller'
Chris@909 20
Chris@909 21 # Re-raise errors caught by the controller.
Chris@909 22 class UsersController; def rescue_action(e) raise e end; end
Chris@909 23
Chris@909 24 class UsersControllerTest < ActionController::TestCase
Chris@909 25 include Redmine::I18n
Chris@909 26
Chris@909 27 fixtures :users, :projects, :members, :member_roles, :roles, :auth_sources, :custom_fields, :custom_values, :groups_users
Chris@909 28
Chris@909 29 def setup
Chris@909 30 @controller = UsersController.new
Chris@909 31 @request = ActionController::TestRequest.new
Chris@909 32 @response = ActionController::TestResponse.new
Chris@909 33 User.current = nil
Chris@909 34 @request.session[:user_id] = 1 # admin
Chris@909 35 end
Chris@909 36
Chris@909 37 def test_index
Chris@909 38 get :index
Chris@909 39 assert_response :success
Chris@909 40 assert_template 'index'
Chris@909 41 end
Chris@909 42
Chris@909 43 def test_index
Chris@909 44 get :index
Chris@909 45 assert_response :success
Chris@909 46 assert_template 'index'
Chris@909 47 assert_not_nil assigns(:users)
Chris@909 48 # active users only
Chris@909 49 assert_nil assigns(:users).detect {|u| !u.active?}
Chris@909 50 end
Chris@909 51
Chris@909 52 def test_index_with_name_filter
Chris@909 53 get :index, :name => 'john'
Chris@909 54 assert_response :success
Chris@909 55 assert_template 'index'
Chris@909 56 users = assigns(:users)
Chris@909 57 assert_not_nil users
Chris@909 58 assert_equal 1, users.size
Chris@909 59 assert_equal 'John', users.first.firstname
Chris@909 60 end
Chris@909 61
Chris@909 62 def test_index_with_group_filter
Chris@909 63 get :index, :group_id => '10'
Chris@909 64 assert_response :success
Chris@909 65 assert_template 'index'
Chris@909 66 users = assigns(:users)
Chris@909 67 assert users.any?
Chris@909 68 assert_equal([], (users - Group.find(10).users))
Chris@909 69 end
Chris@909 70
Chris@909 71 def test_show
Chris@909 72 @request.session[:user_id] = nil
Chris@909 73 get :show, :id => 2
Chris@909 74 assert_response :success
Chris@909 75 assert_template 'show'
Chris@909 76 assert_not_nil assigns(:user)
Chris@909 77
Chris@909 78 assert_tag 'li', :content => /Phone number/
Chris@909 79 end
Chris@909 80
Chris@909 81 def test_show_should_not_display_hidden_custom_fields
Chris@909 82 @request.session[:user_id] = nil
Chris@909 83 UserCustomField.find_by_name('Phone number').update_attribute :visible, false
Chris@909 84 get :show, :id => 2
Chris@909 85 assert_response :success
Chris@909 86 assert_template 'show'
Chris@909 87 assert_not_nil assigns(:user)
Chris@909 88
Chris@909 89 assert_no_tag 'li', :content => /Phone number/
Chris@909 90 end
Chris@909 91
Chris@909 92 def test_show_should_not_fail_when_custom_values_are_nil
Chris@909 93 user = User.find(2)
Chris@909 94
Chris@909 95 # Create a custom field to illustrate the issue
Chris@909 96 custom_field = CustomField.create!(:name => 'Testing', :field_format => 'text')
Chris@909 97 custom_value = user.custom_values.build(:custom_field => custom_field).save!
Chris@909 98
Chris@909 99 get :show, :id => 2
Chris@909 100 assert_response :success
Chris@909 101 end
Chris@909 102
Chris@909 103 def test_show_inactive
Chris@909 104 @request.session[:user_id] = nil
Chris@909 105 get :show, :id => 5
Chris@909 106 assert_response 404
Chris@909 107 end
Chris@909 108
Chris@909 109 def test_show_should_not_reveal_users_with_no_visible_activity_or_project
Chris@909 110 @request.session[:user_id] = nil
Chris@909 111 get :show, :id => 9
Chris@909 112 assert_response 404
Chris@909 113 end
Chris@909 114
Chris@909 115 def test_show_inactive_by_admin
Chris@909 116 @request.session[:user_id] = 1
Chris@909 117 get :show, :id => 5
Chris@909 118 assert_response 200
Chris@909 119 assert_not_nil assigns(:user)
Chris@909 120 end
Chris@909 121
Chris@909 122 def test_show_displays_memberships_based_on_project_visibility
Chris@909 123 @request.session[:user_id] = 1
Chris@909 124 get :show, :id => 2
Chris@909 125 assert_response :success
Chris@909 126 memberships = assigns(:memberships)
Chris@909 127 assert_not_nil memberships
Chris@909 128 project_ids = memberships.map(&:project_id)
Chris@909 129 assert project_ids.include?(2) #private project admin can see
Chris@909 130 end
Chris@909 131
Chris@909 132 def test_show_current_should_require_authentication
Chris@909 133 @request.session[:user_id] = nil
Chris@909 134 get :show, :id => 'current'
Chris@909 135 assert_response 302
Chris@909 136 end
Chris@909 137
Chris@909 138 def test_show_current
Chris@909 139 @request.session[:user_id] = 2
Chris@909 140 get :show, :id => 'current'
Chris@909 141 assert_response :success
Chris@909 142 assert_template 'show'
Chris@909 143 assert_equal User.find(2), assigns(:user)
Chris@909 144 end
Chris@909 145
Chris@909 146 def test_new
Chris@909 147 get :new
Chris@909 148
Chris@909 149 assert_response :success
Chris@909 150 assert_template :new
Chris@909 151 assert assigns(:user)
Chris@909 152 end
Chris@909 153
Chris@909 154 def test_create
Chris@909 155 Setting.bcc_recipients = '1'
Chris@909 156
Chris@909 157 assert_difference 'User.count' do
Chris@909 158 assert_difference 'ActionMailer::Base.deliveries.size' do
Chris@909 159 post :create,
Chris@909 160 :user => {
Chris@909 161 :firstname => 'John',
Chris@909 162 :lastname => 'Doe',
Chris@909 163 :login => 'jdoe',
Chris@909 164 :password => 'secret',
Chris@909 165 :password_confirmation => 'secret',
Chris@909 166 :mail => 'jdoe@gmail.com',
Chris@909 167 :mail_notification => 'none'
Chris@909 168 },
Chris@909 169 :send_information => '1'
Chris@909 170 end
Chris@909 171 end
Chris@909 172
Chris@909 173 user = User.first(:order => 'id DESC')
Chris@909 174 assert_redirected_to :controller => 'users', :action => 'edit', :id => user.id
Chris@909 175
Chris@909 176 assert_equal 'John', user.firstname
Chris@909 177 assert_equal 'Doe', user.lastname
Chris@909 178 assert_equal 'jdoe', user.login
Chris@909 179 assert_equal 'jdoe@gmail.com', user.mail
Chris@909 180 assert_equal 'none', user.mail_notification
Chris@909 181 assert user.check_password?('secret')
Chris@909 182
Chris@909 183 mail = ActionMailer::Base.deliveries.last
Chris@909 184 assert_not_nil mail
Chris@909 185 assert_equal [user.mail], mail.bcc
Chris@909 186 assert mail.body.include?('secret')
Chris@909 187 end
Chris@909 188
Chris@909 189 def test_create_with_failure
Chris@909 190 assert_no_difference 'User.count' do
Chris@909 191 post :create, :user => {}
Chris@909 192 end
Chris@909 193
Chris@909 194 assert_response :success
Chris@909 195 assert_template 'new'
Chris@909 196 end
Chris@909 197
Chris@909 198 def test_edit
Chris@909 199 get :edit, :id => 2
Chris@909 200
Chris@909 201 assert_response :success
Chris@909 202 assert_template 'edit'
Chris@909 203 assert_equal User.find(2), assigns(:user)
Chris@909 204 end
Chris@909 205
Chris@909 206 def test_update
Chris@909 207 ActionMailer::Base.deliveries.clear
Chris@909 208 put :update, :id => 2, :user => {:firstname => 'Changed', :mail_notification => 'only_assigned'}, :pref => {:hide_mail => '1', :comments_sorting => 'desc'}
Chris@909 209
Chris@909 210 user = User.find(2)
Chris@909 211 assert_equal 'Changed', user.firstname
Chris@909 212 assert_equal 'only_assigned', user.mail_notification
Chris@909 213 assert_equal true, user.pref[:hide_mail]
Chris@909 214 assert_equal 'desc', user.pref[:comments_sorting]
Chris@909 215 assert ActionMailer::Base.deliveries.empty?
Chris@909 216 end
Chris@909 217
Chris@909 218 def test_update_with_failure
Chris@909 219 assert_no_difference 'User.count' do
Chris@909 220 put :update, :id => 2, :user => {:firstname => ''}
Chris@909 221 end
Chris@909 222
Chris@909 223 assert_response :success
Chris@909 224 assert_template 'edit'
Chris@909 225 end
Chris@909 226
Chris@909 227 def test_update_with_group_ids_should_assign_groups
Chris@909 228 put :update, :id => 2, :user => {:group_ids => ['10']}
Chris@909 229
Chris@909 230 user = User.find(2)
Chris@909 231 assert_equal [10], user.group_ids
Chris@909 232 end
Chris@909 233
Chris@909 234 def test_update_with_activation_should_send_a_notification
Chris@909 235 u = User.new(:firstname => 'Foo', :lastname => 'Bar', :mail => 'foo.bar@somenet.foo', :language => 'fr')
Chris@909 236 u.login = 'foo'
Chris@909 237 u.status = User::STATUS_REGISTERED
Chris@909 238 u.save!
Chris@909 239 ActionMailer::Base.deliveries.clear
Chris@909 240 Setting.bcc_recipients = '1'
Chris@909 241
Chris@909 242 put :update, :id => u.id, :user => {:status => User::STATUS_ACTIVE}
Chris@909 243 assert u.reload.active?
Chris@909 244 mail = ActionMailer::Base.deliveries.last
Chris@909 245 assert_not_nil mail
Chris@909 246 assert_equal ['foo.bar@somenet.foo'], mail.bcc
Chris@909 247 assert mail.body.include?(ll('fr', :notice_account_activated))
Chris@909 248 end
Chris@909 249
Chris@909 250 def test_update_with_password_change_should_send_a_notification
Chris@909 251 ActionMailer::Base.deliveries.clear
Chris@909 252 Setting.bcc_recipients = '1'
Chris@909 253
Chris@909 254 put :update, :id => 2, :user => {:password => 'newpass', :password_confirmation => 'newpass'}, :send_information => '1'
Chris@909 255 u = User.find(2)
Chris@909 256 assert u.check_password?('newpass')
Chris@909 257
Chris@909 258 mail = ActionMailer::Base.deliveries.last
Chris@909 259 assert_not_nil mail
Chris@909 260 assert_equal [u.mail], mail.bcc
Chris@909 261 assert mail.body.include?('newpass')
Chris@909 262 end
Chris@909 263
Chris@909 264 test "put :update with a password change to an AuthSource user switching to Internal authentication" do
Chris@909 265 # Configure as auth source
Chris@909 266 u = User.find(2)
Chris@909 267 u.auth_source = AuthSource.find(1)
Chris@909 268 u.save!
Chris@909 269
Chris@909 270 put :update, :id => u.id, :user => {:auth_source_id => '', :password => 'newpass'}, :password_confirmation => 'newpass'
Chris@909 271
Chris@909 272 assert_equal nil, u.reload.auth_source
Chris@909 273 assert u.check_password?('newpass')
Chris@909 274 end
Chris@909 275
Chris@909 276 def test_destroy
Chris@909 277 assert_difference 'User.count', -1 do
Chris@909 278 delete :destroy, :id => 2
Chris@909 279 end
Chris@909 280 assert_redirected_to '/users'
Chris@909 281 assert_nil User.find_by_id(2)
Chris@909 282 end
Chris@909 283
Chris@909 284 def test_destroy_should_not_accept_get_requests
Chris@909 285 assert_no_difference 'User.count' do
Chris@909 286 get :destroy, :id => 2
Chris@909 287 end
Chris@909 288 assert_response 405
Chris@909 289 end
Chris@909 290
Chris@909 291 def test_destroy_should_be_denied_for_non_admin_users
Chris@909 292 @request.session[:user_id] = 3
Chris@909 293
Chris@909 294 assert_no_difference 'User.count' do
Chris@909 295 get :destroy, :id => 2
Chris@909 296 end
Chris@909 297 assert_response 403
Chris@909 298 end
Chris@909 299
Chris@909 300 def test_edit_membership
Chris@909 301 post :edit_membership, :id => 2, :membership_id => 1,
Chris@909 302 :membership => { :role_ids => [2]}
Chris@909 303 assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships'
Chris@909 304 assert_equal [2], Member.find(1).role_ids
Chris@909 305 end
Chris@909 306
Chris@909 307 def test_destroy_membership
Chris@909 308 post :destroy_membership, :id => 2, :membership_id => 1
Chris@909 309 assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships'
Chris@909 310 assert_nil Member.find_by_id(1)
Chris@909 311 end
Chris@909 312 end