annotate .svn/pristine/9a/9ad68a15a2fee2d3d924e8d95cd74e2461955b96.svn-base @ 1519:afce8026aaeb redmine-2.4-integration

Merge from branch "live"
author Chris Cannam
date Tue, 09 Sep 2014 09:34:53 +0100
parents e248c7af89ec
children
rev   line source
Chris@1494 1 # Redmine - project management software
Chris@1494 2 # Copyright (C) 2006-2014 Jean-Philippe Lang
Chris@1494 3 #
Chris@1494 4 # This program is free software; you can redistribute it and/or
Chris@1494 5 # modify it under the terms of the GNU General Public License
Chris@1494 6 # as published by the Free Software Foundation; either version 2
Chris@1494 7 # of the License, or (at your option) any later version.
Chris@1494 8 #
Chris@1494 9 # This program is distributed in the hope that it will be useful,
Chris@1494 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1494 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@1494 12 # GNU General Public License for more details.
Chris@1494 13 #
Chris@1494 14 # You should have received a copy of the GNU General Public License
Chris@1494 15 # along with this program; if not, write to the Free Software
Chris@1494 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@1494 17
Chris@1494 18 require File.expand_path('../../test_helper', __FILE__)
Chris@1494 19
Chris@1494 20 class IssueTest < ActiveSupport::TestCase
Chris@1494 21 fixtures :projects, :users, :members, :member_roles, :roles,
Chris@1494 22 :groups_users,
Chris@1494 23 :trackers, :projects_trackers,
Chris@1494 24 :enabled_modules,
Chris@1494 25 :versions,
Chris@1494 26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
Chris@1494 27 :enumerations,
Chris@1494 28 :issues, :journals, :journal_details,
Chris@1494 29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
Chris@1494 30 :time_entries
Chris@1494 31
Chris@1494 32 include Redmine::I18n
Chris@1494 33
Chris@1494 34 def teardown
Chris@1494 35 User.current = nil
Chris@1494 36 end
Chris@1494 37
Chris@1494 38 def test_initialize
Chris@1494 39 issue = Issue.new
Chris@1494 40
Chris@1494 41 assert_nil issue.project_id
Chris@1494 42 assert_nil issue.tracker_id
Chris@1494 43 assert_nil issue.author_id
Chris@1494 44 assert_nil issue.assigned_to_id
Chris@1494 45 assert_nil issue.category_id
Chris@1494 46
Chris@1494 47 assert_equal IssueStatus.default, issue.status
Chris@1494 48 assert_equal IssuePriority.default, issue.priority
Chris@1494 49 end
Chris@1494 50
Chris@1494 51 def test_create
Chris@1494 52 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1494 53 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1494 54 :subject => 'test_create',
Chris@1494 55 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
Chris@1494 56 assert issue.save
Chris@1494 57 issue.reload
Chris@1494 58 assert_equal 1.5, issue.estimated_hours
Chris@1494 59 end
Chris@1494 60
Chris@1494 61 def test_create_minimal
Chris@1494 62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1494 63 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1494 64 :subject => 'test_create')
Chris@1494 65 assert issue.save
Chris@1494 66 assert issue.description.nil?
Chris@1494 67 assert_nil issue.estimated_hours
Chris@1494 68 end
Chris@1494 69
Chris@1494 70 def test_start_date_format_should_be_validated
Chris@1494 71 set_language_if_valid 'en'
Chris@1494 72 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
Chris@1494 73 issue = Issue.new(:start_date => invalid_date)
Chris@1494 74 assert !issue.valid?
Chris@1494 75 assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
Chris@1494 76 end
Chris@1494 77 end
Chris@1494 78
Chris@1494 79 def test_due_date_format_should_be_validated
Chris@1494 80 set_language_if_valid 'en'
Chris@1494 81 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
Chris@1494 82 issue = Issue.new(:due_date => invalid_date)
Chris@1494 83 assert !issue.valid?
Chris@1494 84 assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
Chris@1494 85 end
Chris@1494 86 end
Chris@1494 87
Chris@1494 88 def test_due_date_lesser_than_start_date_should_not_validate
Chris@1494 89 set_language_if_valid 'en'
Chris@1494 90 issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
Chris@1494 91 assert !issue.valid?
Chris@1494 92 assert_include 'Due date must be greater than start date', issue.errors.full_messages
Chris@1494 93 end
Chris@1494 94
Chris@1494 95 def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
Chris@1494 96 issue = Issue.generate(:start_date => '2013-06-04')
Chris@1494 97 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
Chris@1494 98 assert !issue.valid?
Chris@1494 99 assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
Chris@1494 100 end
Chris@1494 101
Chris@1494 102 def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
Chris@1494 103 issue = Issue.generate!(:start_date => '2013-06-04')
Chris@1494 104 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
Chris@1494 105 issue.start_date = '2013-06-07'
Chris@1494 106 assert !issue.valid?
Chris@1494 107 assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
Chris@1494 108 end
Chris@1494 109
Chris@1494 110 def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
Chris@1494 111 issue = Issue.generate!(:start_date => '2013-06-04')
Chris@1494 112 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
Chris@1494 113 assert issue.valid?
Chris@1494 114 end
Chris@1494 115
Chris@1494 116 def test_estimated_hours_should_be_validated
Chris@1494 117 set_language_if_valid 'en'
Chris@1494 118 ['-2'].each do |invalid|
Chris@1494 119 issue = Issue.new(:estimated_hours => invalid)
Chris@1494 120 assert !issue.valid?
Chris@1494 121 assert_include 'Estimated time is invalid', issue.errors.full_messages
Chris@1494 122 end
Chris@1494 123 end
Chris@1494 124
Chris@1494 125 def test_create_with_required_custom_field
Chris@1494 126 set_language_if_valid 'en'
Chris@1494 127 field = IssueCustomField.find_by_name('Database')
Chris@1494 128 field.update_attribute(:is_required, true)
Chris@1494 129
Chris@1494 130 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1494 131 :status_id => 1, :subject => 'test_create',
Chris@1494 132 :description => 'IssueTest#test_create_with_required_custom_field')
Chris@1494 133 assert issue.available_custom_fields.include?(field)
Chris@1494 134 # No value for the custom field
Chris@1494 135 assert !issue.save
Chris@1494 136 assert_equal ["Database can't be blank"], issue.errors.full_messages
Chris@1494 137 # Blank value
Chris@1494 138 issue.custom_field_values = { field.id => '' }
Chris@1494 139 assert !issue.save
Chris@1494 140 assert_equal ["Database can't be blank"], issue.errors.full_messages
Chris@1494 141 # Invalid value
Chris@1494 142 issue.custom_field_values = { field.id => 'SQLServer' }
Chris@1494 143 assert !issue.save
Chris@1494 144 assert_equal ["Database is not included in the list"], issue.errors.full_messages
Chris@1494 145 # Valid value
Chris@1494 146 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1494 147 assert issue.save
Chris@1494 148 issue.reload
Chris@1494 149 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
Chris@1494 150 end
Chris@1494 151
Chris@1494 152 def test_create_with_group_assignment
Chris@1494 153 with_settings :issue_group_assignment => '1' do
Chris@1494 154 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
Chris@1494 155 :subject => 'Group assignment',
Chris@1494 156 :assigned_to_id => 11).save
Chris@1494 157 issue = Issue.first(:order => 'id DESC')
Chris@1494 158 assert_kind_of Group, issue.assigned_to
Chris@1494 159 assert_equal Group.find(11), issue.assigned_to
Chris@1494 160 end
Chris@1494 161 end
Chris@1494 162
Chris@1494 163 def test_create_with_parent_issue_id
Chris@1494 164 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1494 165 :author_id => 1, :subject => 'Group assignment',
Chris@1494 166 :parent_issue_id => 1)
Chris@1494 167 assert_save issue
Chris@1494 168 assert_equal 1, issue.parent_issue_id
Chris@1494 169 assert_equal Issue.find(1), issue.parent
Chris@1494 170 end
Chris@1494 171
Chris@1494 172 def test_create_with_sharp_parent_issue_id
Chris@1494 173 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1494 174 :author_id => 1, :subject => 'Group assignment',
Chris@1494 175 :parent_issue_id => "#1")
Chris@1494 176 assert_save issue
Chris@1494 177 assert_equal 1, issue.parent_issue_id
Chris@1494 178 assert_equal Issue.find(1), issue.parent
Chris@1494 179 end
Chris@1494 180
Chris@1494 181 def test_create_with_invalid_parent_issue_id
Chris@1494 182 set_language_if_valid 'en'
Chris@1494 183 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1494 184 :author_id => 1, :subject => 'Group assignment',
Chris@1494 185 :parent_issue_id => '01ABC')
Chris@1494 186 assert !issue.save
Chris@1494 187 assert_equal '01ABC', issue.parent_issue_id
Chris@1494 188 assert_include 'Parent task is invalid', issue.errors.full_messages
Chris@1494 189 end
Chris@1494 190
Chris@1494 191 def test_create_with_invalid_sharp_parent_issue_id
Chris@1494 192 set_language_if_valid 'en'
Chris@1494 193 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1494 194 :author_id => 1, :subject => 'Group assignment',
Chris@1494 195 :parent_issue_id => '#01ABC')
Chris@1494 196 assert !issue.save
Chris@1494 197 assert_equal '#01ABC', issue.parent_issue_id
Chris@1494 198 assert_include 'Parent task is invalid', issue.errors.full_messages
Chris@1494 199 end
Chris@1494 200
Chris@1494 201 def assert_visibility_match(user, issues)
Chris@1494 202 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
Chris@1494 203 end
Chris@1494 204
Chris@1494 205 def test_visible_scope_for_anonymous
Chris@1494 206 # Anonymous user should see issues of public projects only
Chris@1494 207 issues = Issue.visible(User.anonymous).all
Chris@1494 208 assert issues.any?
Chris@1494 209 assert_nil issues.detect {|issue| !issue.project.is_public?}
Chris@1494 210 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1494 211 assert_visibility_match User.anonymous, issues
Chris@1494 212 end
Chris@1494 213
Chris@1494 214 def test_visible_scope_for_anonymous_without_view_issues_permissions
Chris@1494 215 # Anonymous user should not see issues without permission
Chris@1494 216 Role.anonymous.remove_permission!(:view_issues)
Chris@1494 217 issues = Issue.visible(User.anonymous).all
Chris@1494 218 assert issues.empty?
Chris@1494 219 assert_visibility_match User.anonymous, issues
Chris@1494 220 end
Chris@1494 221
Chris@1494 222 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
Chris@1494 223 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
Chris@1494 224 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
Chris@1494 225 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
Chris@1494 226 assert !issue.visible?(User.anonymous)
Chris@1494 227 end
Chris@1494 228
Chris@1494 229 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
Chris@1494 230 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
Chris@1494 231 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
Chris@1494 232 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
Chris@1494 233 assert !issue.visible?(User.anonymous)
Chris@1494 234 end
Chris@1494 235
Chris@1494 236 def test_visible_scope_for_non_member
Chris@1494 237 user = User.find(9)
Chris@1494 238 assert user.projects.empty?
Chris@1494 239 # Non member user should see issues of public projects only
Chris@1494 240 issues = Issue.visible(user).all
Chris@1494 241 assert issues.any?
Chris@1494 242 assert_nil issues.detect {|issue| !issue.project.is_public?}
Chris@1494 243 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1494 244 assert_visibility_match user, issues
Chris@1494 245 end
Chris@1494 246
Chris@1494 247 def test_visible_scope_for_non_member_with_own_issues_visibility
Chris@1494 248 Role.non_member.update_attribute :issues_visibility, 'own'
Chris@1494 249 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
Chris@1494 250 user = User.find(9)
Chris@1494 251
Chris@1494 252 issues = Issue.visible(user).all
Chris@1494 253 assert issues.any?
Chris@1494 254 assert_nil issues.detect {|issue| issue.author != user}
Chris@1494 255 assert_visibility_match user, issues
Chris@1494 256 end
Chris@1494 257
Chris@1494 258 def test_visible_scope_for_non_member_without_view_issues_permissions
Chris@1494 259 # Non member user should not see issues without permission
Chris@1494 260 Role.non_member.remove_permission!(:view_issues)
Chris@1494 261 user = User.find(9)
Chris@1494 262 assert user.projects.empty?
Chris@1494 263 issues = Issue.visible(user).all
Chris@1494 264 assert issues.empty?
Chris@1494 265 assert_visibility_match user, issues
Chris@1494 266 end
Chris@1494 267
Chris@1494 268 def test_visible_scope_for_member
Chris@1494 269 user = User.find(9)
Chris@1494 270 # User should see issues of projects for which user has view_issues permissions only
Chris@1494 271 Role.non_member.remove_permission!(:view_issues)
Chris@1494 272 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
Chris@1494 273 issues = Issue.visible(user).all
Chris@1494 274 assert issues.any?
Chris@1494 275 assert_nil issues.detect {|issue| issue.project_id != 3}
Chris@1494 276 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1494 277 assert_visibility_match user, issues
Chris@1494 278 end
Chris@1494 279
Chris@1494 280 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
Chris@1494 281 user = User.find(8)
Chris@1494 282 assert user.groups.any?
Chris@1494 283 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
Chris@1494 284 Role.non_member.remove_permission!(:view_issues)
Chris@1494 285
Chris@1494 286 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1494 287 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1494 288 :subject => 'Assignment test',
Chris@1494 289 :assigned_to => user.groups.first,
Chris@1494 290 :is_private => true)
Chris@1494 291
Chris@1494 292 Role.find(2).update_attribute :issues_visibility, 'default'
Chris@1494 293 issues = Issue.visible(User.find(8)).all
Chris@1494 294 assert issues.any?
Chris@1494 295 assert issues.include?(issue)
Chris@1494 296
Chris@1494 297 Role.find(2).update_attribute :issues_visibility, 'own'
Chris@1494 298 issues = Issue.visible(User.find(8)).all
Chris@1494 299 assert issues.any?
Chris@1494 300 assert issues.include?(issue)
Chris@1494 301 end
Chris@1494 302
Chris@1494 303 def test_visible_scope_for_admin
Chris@1494 304 user = User.find(1)
Chris@1494 305 user.members.each(&:destroy)
Chris@1494 306 assert user.projects.empty?
Chris@1494 307 issues = Issue.visible(user).all
Chris@1494 308 assert issues.any?
Chris@1494 309 # Admin should see issues on private projects that admin does not belong to
Chris@1494 310 assert issues.detect {|issue| !issue.project.is_public?}
Chris@1494 311 # Admin should see private issues of other users
Chris@1494 312 assert issues.detect {|issue| issue.is_private? && issue.author != user}
Chris@1494 313 assert_visibility_match user, issues
Chris@1494 314 end
Chris@1494 315
Chris@1494 316 def test_visible_scope_with_project
Chris@1494 317 project = Project.find(1)
Chris@1494 318 issues = Issue.visible(User.find(2), :project => project).all
Chris@1494 319 projects = issues.collect(&:project).uniq
Chris@1494 320 assert_equal 1, projects.size
Chris@1494 321 assert_equal project, projects.first
Chris@1494 322 end
Chris@1494 323
Chris@1494 324 def test_visible_scope_with_project_and_subprojects
Chris@1494 325 project = Project.find(1)
Chris@1494 326 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
Chris@1494 327 projects = issues.collect(&:project).uniq
Chris@1494 328 assert projects.size > 1
Chris@1494 329 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
Chris@1494 330 end
Chris@1494 331
Chris@1494 332 def test_visible_and_nested_set_scopes
Chris@1494 333 assert_equal 0, Issue.find(1).descendants.visible.all.size
Chris@1494 334 end
Chris@1494 335
Chris@1494 336 def test_open_scope
Chris@1494 337 issues = Issue.open.all
Chris@1494 338 assert_nil issues.detect(&:closed?)
Chris@1494 339 end
Chris@1494 340
Chris@1494 341 def test_open_scope_with_arg
Chris@1494 342 issues = Issue.open(false).all
Chris@1494 343 assert_equal issues, issues.select(&:closed?)
Chris@1494 344 end
Chris@1494 345
Chris@1494 346 def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
Chris@1494 347 version = Version.find(2)
Chris@1494 348 assert version.fixed_issues.any?
Chris@1494 349 assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
Chris@1494 350 end
Chris@1494 351
Chris@1494 352 def test_fixed_version_scope_with_empty_array_should_return_no_result
Chris@1494 353 assert_equal 0, Issue.fixed_version([]).count
Chris@1494 354 end
Chris@1494 355
Chris@1494 356 def test_errors_full_messages_should_include_custom_fields_errors
Chris@1494 357 field = IssueCustomField.find_by_name('Database')
Chris@1494 358
Chris@1494 359 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1494 360 :status_id => 1, :subject => 'test_create',
Chris@1494 361 :description => 'IssueTest#test_create_with_required_custom_field')
Chris@1494 362 assert issue.available_custom_fields.include?(field)
Chris@1494 363 # Invalid value
Chris@1494 364 issue.custom_field_values = { field.id => 'SQLServer' }
Chris@1494 365
Chris@1494 366 assert !issue.valid?
Chris@1494 367 assert_equal 1, issue.errors.full_messages.size
Chris@1494 368 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
Chris@1494 369 issue.errors.full_messages.first
Chris@1494 370 end
Chris@1494 371
Chris@1494 372 def test_update_issue_with_required_custom_field
Chris@1494 373 field = IssueCustomField.find_by_name('Database')
Chris@1494 374 field.update_attribute(:is_required, true)
Chris@1494 375
Chris@1494 376 issue = Issue.find(1)
Chris@1494 377 assert_nil issue.custom_value_for(field)
Chris@1494 378 assert issue.available_custom_fields.include?(field)
Chris@1494 379 # No change to custom values, issue can be saved
Chris@1494 380 assert issue.save
Chris@1494 381 # Blank value
Chris@1494 382 issue.custom_field_values = { field.id => '' }
Chris@1494 383 assert !issue.save
Chris@1494 384 # Valid value
Chris@1494 385 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1494 386 assert issue.save
Chris@1494 387 issue.reload
Chris@1494 388 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
Chris@1494 389 end
Chris@1494 390
Chris@1494 391 def test_should_not_update_attributes_if_custom_fields_validation_fails
Chris@1494 392 issue = Issue.find(1)
Chris@1494 393 field = IssueCustomField.find_by_name('Database')
Chris@1494 394 assert issue.available_custom_fields.include?(field)
Chris@1494 395
Chris@1494 396 issue.custom_field_values = { field.id => 'Invalid' }
Chris@1494 397 issue.subject = 'Should be not be saved'
Chris@1494 398 assert !issue.save
Chris@1494 399
Chris@1494 400 issue.reload
Chris@1494 401 assert_equal "Can't print recipes", issue.subject
Chris@1494 402 end
Chris@1494 403
Chris@1494 404 def test_should_not_recreate_custom_values_objects_on_update
Chris@1494 405 field = IssueCustomField.find_by_name('Database')
Chris@1494 406
Chris@1494 407 issue = Issue.find(1)
Chris@1494 408 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1494 409 assert issue.save
Chris@1494 410 custom_value = issue.custom_value_for(field)
Chris@1494 411 issue.reload
Chris@1494 412 issue.custom_field_values = { field.id => 'MySQL' }
Chris@1494 413 assert issue.save
Chris@1494 414 issue.reload
Chris@1494 415 assert_equal custom_value.id, issue.custom_value_for(field).id
Chris@1494 416 end
Chris@1494 417
Chris@1494 418 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
Chris@1494 419 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1494 420 :status_id => 1, :subject => 'Test',
Chris@1494 421 :custom_field_values => {'2' => 'Test'})
Chris@1494 422 assert !Tracker.find(2).custom_field_ids.include?(2)
Chris@1494 423
Chris@1494 424 issue = Issue.find(issue.id)
Chris@1494 425 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
Chris@1494 426
Chris@1494 427 issue = Issue.find(issue.id)
Chris@1494 428 custom_value = issue.custom_value_for(2)
Chris@1494 429 assert_not_nil custom_value
Chris@1494 430 assert_equal 'Test', custom_value.value
Chris@1494 431 end
Chris@1494 432
Chris@1494 433 def test_assigning_tracker_id_should_reload_custom_fields_values
Chris@1494 434 issue = Issue.new(:project => Project.find(1))
Chris@1494 435 assert issue.custom_field_values.empty?
Chris@1494 436 issue.tracker_id = 1
Chris@1494 437 assert issue.custom_field_values.any?
Chris@1494 438 end
Chris@1494 439
Chris@1494 440 def test_assigning_attributes_should_assign_project_and_tracker_first
Chris@1494 441 seq = sequence('seq')
Chris@1494 442 issue = Issue.new
Chris@1494 443 issue.expects(:project_id=).in_sequence(seq)
Chris@1494 444 issue.expects(:tracker_id=).in_sequence(seq)
Chris@1494 445 issue.expects(:subject=).in_sequence(seq)
Chris@1494 446 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
Chris@1494 447 end
Chris@1494 448
Chris@1494 449 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
Chris@1494 450 attributes = ActiveSupport::OrderedHash.new
Chris@1494 451 attributes['custom_field_values'] = { '1' => 'MySQL' }
Chris@1494 452 attributes['tracker_id'] = '1'
Chris@1494 453 issue = Issue.new(:project => Project.find(1))
Chris@1494 454 issue.attributes = attributes
Chris@1494 455 assert_equal 'MySQL', issue.custom_field_value(1)
Chris@1494 456 end
Chris@1494 457
Chris@1494 458 def test_reload_should_reload_custom_field_values
Chris@1494 459 issue = Issue.generate!
Chris@1494 460 issue.custom_field_values = {'2' => 'Foo'}
Chris@1494 461 issue.save!
Chris@1494 462
Chris@1494 463 issue = Issue.order('id desc').first
Chris@1494 464 assert_equal 'Foo', issue.custom_field_value(2)
Chris@1494 465
Chris@1494 466 issue.custom_field_values = {'2' => 'Bar'}
Chris@1494 467 assert_equal 'Bar', issue.custom_field_value(2)
Chris@1494 468
Chris@1494 469 issue.reload
Chris@1494 470 assert_equal 'Foo', issue.custom_field_value(2)
Chris@1494 471 end
Chris@1494 472
Chris@1494 473 def test_should_update_issue_with_disabled_tracker
Chris@1494 474 p = Project.find(1)
Chris@1494 475 issue = Issue.find(1)
Chris@1494 476
Chris@1494 477 p.trackers.delete(issue.tracker)
Chris@1494 478 assert !p.trackers.include?(issue.tracker)
Chris@1494 479
Chris@1494 480 issue.reload
Chris@1494 481 issue.subject = 'New subject'
Chris@1494 482 assert issue.save
Chris@1494 483 end
Chris@1494 484
Chris@1494 485 def test_should_not_set_a_disabled_tracker
Chris@1494 486 p = Project.find(1)
Chris@1494 487 p.trackers.delete(Tracker.find(2))
Chris@1494 488
Chris@1494 489 issue = Issue.find(1)
Chris@1494 490 issue.tracker_id = 2
Chris@1494 491 issue.subject = 'New subject'
Chris@1494 492 assert !issue.save
Chris@1494 493 assert_not_equal [], issue.errors[:tracker_id]
Chris@1494 494 end
Chris@1494 495
Chris@1494 496 def test_category_based_assignment
Chris@1494 497 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1494 498 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1494 499 :subject => 'Assignment test',
Chris@1494 500 :description => 'Assignment test', :category_id => 1)
Chris@1494 501 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
Chris@1494 502 end
Chris@1494 503
Chris@1494 504 def test_new_statuses_allowed_to
Chris@1494 505 WorkflowTransition.delete_all
Chris@1494 506 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1494 507 :old_status_id => 1, :new_status_id => 2,
Chris@1494 508 :author => false, :assignee => false)
Chris@1494 509 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1494 510 :old_status_id => 1, :new_status_id => 3,
Chris@1494 511 :author => true, :assignee => false)
Chris@1494 512 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1494 513 :old_status_id => 1, :new_status_id => 4,
Chris@1494 514 :author => false, :assignee => true)
Chris@1494 515 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1494 516 :old_status_id => 1, :new_status_id => 5,
Chris@1494 517 :author => true, :assignee => true)
Chris@1494 518 status = IssueStatus.find(1)
Chris@1494 519 role = Role.find(1)
Chris@1494 520 tracker = Tracker.find(1)
Chris@1494 521 user = User.find(2)
Chris@1494 522
Chris@1494 523 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1494 524 :project_id => 1, :author_id => 1)
Chris@1494 525 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1494 526
Chris@1494 527 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1494 528 :project_id => 1, :author => user)
Chris@1494 529 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1494 530
Chris@1494 531 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1494 532 :project_id => 1, :author_id => 1,
Chris@1494 533 :assigned_to => user)
Chris@1494 534 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1494 535
Chris@1494 536 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1494 537 :project_id => 1, :author => user,
Chris@1494 538 :assigned_to => user)
Chris@1494 539 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1494 540
Chris@1494 541 group = Group.generate!
Chris@1494 542 group.users << user
Chris@1494 543 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1494 544 :project_id => 1, :author => user,
Chris@1494 545 :assigned_to => group)
Chris@1494 546 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1494 547 end
Chris@1494 548
Chris@1494 549 def test_new_statuses_allowed_to_should_consider_group_assignment
Chris@1494 550 WorkflowTransition.delete_all
Chris@1494 551 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1494 552 :old_status_id => 1, :new_status_id => 4,
Chris@1494 553 :author => false, :assignee => true)
Chris@1494 554 user = User.find(2)
Chris@1494 555 group = Group.generate!
Chris@1494 556 group.users << user
Chris@1494 557
Chris@1494 558 issue = Issue.generate!(:author_id => 1, :assigned_to => group)
Chris@1494 559 assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
Chris@1494 560 end
Chris@1494 561
Chris@1494 562 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
Chris@1494 563 admin = User.find(1)
Chris@1494 564 issue = Issue.find(1)
Chris@1494 565 assert !admin.member_of?(issue.project)
Chris@1494 566 expected_statuses = [issue.status] +
Chris@1494 567 WorkflowTransition.find_all_by_old_status_id(
Chris@1494 568 issue.status_id).map(&:new_status).uniq.sort
Chris@1494 569 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
Chris@1494 570 end
Chris@1494 571
Chris@1494 572 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
Chris@1494 573 issue = Issue.find(1).copy
Chris@1494 574 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
Chris@1494 575
Chris@1494 576 issue = Issue.find(2).copy
Chris@1494 577 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
Chris@1494 578 end
Chris@1494 579
Chris@1494 580 def test_safe_attributes_names_should_not_include_disabled_field
Chris@1494 581 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
Chris@1494 582
Chris@1494 583 issue = Issue.new(:tracker => tracker)
Chris@1494 584 assert_include 'tracker_id', issue.safe_attribute_names
Chris@1494 585 assert_include 'status_id', issue.safe_attribute_names
Chris@1494 586 assert_include 'subject', issue.safe_attribute_names
Chris@1494 587 assert_include 'description', issue.safe_attribute_names
Chris@1494 588 assert_include 'custom_field_values', issue.safe_attribute_names
Chris@1494 589 assert_include 'custom_fields', issue.safe_attribute_names
Chris@1494 590 assert_include 'lock_version', issue.safe_attribute_names
Chris@1494 591
Chris@1494 592 tracker.core_fields.each do |field|
Chris@1494 593 assert_include field, issue.safe_attribute_names
Chris@1494 594 end
Chris@1494 595
Chris@1494 596 tracker.disabled_core_fields.each do |field|
Chris@1494 597 assert_not_include field, issue.safe_attribute_names
Chris@1494 598 end
Chris@1494 599 end
Chris@1494 600
Chris@1494 601 def test_safe_attributes_should_ignore_disabled_fields
Chris@1494 602 tracker = Tracker.find(1)
Chris@1494 603 tracker.core_fields = %w(assigned_to_id due_date)
Chris@1494 604 tracker.save!
Chris@1494 605
Chris@1494 606 issue = Issue.new(:tracker => tracker)
Chris@1494 607 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
Chris@1494 608 assert_nil issue.start_date
Chris@1494 609 assert_equal Date.parse('2012-07-14'), issue.due_date
Chris@1494 610 end
Chris@1494 611
Chris@1494 612 def test_safe_attributes_should_accept_target_tracker_enabled_fields
Chris@1494 613 source = Tracker.find(1)
Chris@1494 614 source.core_fields = []
Chris@1494 615 source.save!
Chris@1494 616 target = Tracker.find(2)
Chris@1494 617 target.core_fields = %w(assigned_to_id due_date)
Chris@1494 618 target.save!
Chris@1494 619
Chris@1494 620 issue = Issue.new(:tracker => source)
Chris@1494 621 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
Chris@1494 622 assert_equal target, issue.tracker
Chris@1494 623 assert_equal Date.parse('2012-07-14'), issue.due_date
Chris@1494 624 end
Chris@1494 625
Chris@1494 626 def test_safe_attributes_should_not_include_readonly_fields
Chris@1494 627 WorkflowPermission.delete_all
Chris@1494 628 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 629 :role_id => 1, :field_name => 'due_date',
Chris@1494 630 :rule => 'readonly')
Chris@1494 631 user = User.find(2)
Chris@1494 632
Chris@1494 633 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1494 634 assert_equal %w(due_date), issue.read_only_attribute_names(user)
Chris@1494 635 assert_not_include 'due_date', issue.safe_attribute_names(user)
Chris@1494 636
Chris@1494 637 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
Chris@1494 638 assert_equal Date.parse('2012-07-14'), issue.start_date
Chris@1494 639 assert_nil issue.due_date
Chris@1494 640 end
Chris@1494 641
Chris@1494 642 def test_safe_attributes_should_not_include_readonly_custom_fields
Chris@1494 643 cf1 = IssueCustomField.create!(:name => 'Writable field',
Chris@1494 644 :field_format => 'string',
Chris@1494 645 :is_for_all => true, :tracker_ids => [1])
Chris@1494 646 cf2 = IssueCustomField.create!(:name => 'Readonly field',
Chris@1494 647 :field_format => 'string',
Chris@1494 648 :is_for_all => true, :tracker_ids => [1])
Chris@1494 649 WorkflowPermission.delete_all
Chris@1494 650 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 651 :role_id => 1, :field_name => cf2.id.to_s,
Chris@1494 652 :rule => 'readonly')
Chris@1494 653 user = User.find(2)
Chris@1494 654 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1494 655 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
Chris@1494 656 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
Chris@1494 657
Chris@1494 658 issue.send :safe_attributes=, {'custom_field_values' => {
Chris@1494 659 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
Chris@1494 660 }}, user
Chris@1494 661 assert_equal 'value1', issue.custom_field_value(cf1)
Chris@1494 662 assert_nil issue.custom_field_value(cf2)
Chris@1494 663
Chris@1494 664 issue.send :safe_attributes=, {'custom_fields' => [
Chris@1494 665 {'id' => cf1.id.to_s, 'value' => 'valuea'},
Chris@1494 666 {'id' => cf2.id.to_s, 'value' => 'valueb'}
Chris@1494 667 ]}, user
Chris@1494 668 assert_equal 'valuea', issue.custom_field_value(cf1)
Chris@1494 669 assert_nil issue.custom_field_value(cf2)
Chris@1494 670 end
Chris@1494 671
Chris@1494 672 def test_editable_custom_field_values_should_return_non_readonly_custom_values
Chris@1494 673 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
Chris@1494 674 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1494 675 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
Chris@1494 676 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1494 677 WorkflowPermission.delete_all
Chris@1494 678 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
Chris@1494 679 :field_name => cf2.id.to_s, :rule => 'readonly')
Chris@1494 680 user = User.find(2)
Chris@1494 681
Chris@1494 682 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1494 683 values = issue.editable_custom_field_values(user)
Chris@1494 684 assert values.detect {|value| value.custom_field == cf1}
Chris@1494 685 assert_nil values.detect {|value| value.custom_field == cf2}
Chris@1494 686
Chris@1494 687 issue.tracker_id = 2
Chris@1494 688 values = issue.editable_custom_field_values(user)
Chris@1494 689 assert values.detect {|value| value.custom_field == cf1}
Chris@1494 690 assert values.detect {|value| value.custom_field == cf2}
Chris@1494 691 end
Chris@1494 692
Chris@1494 693 def test_safe_attributes_should_accept_target_tracker_writable_fields
Chris@1494 694 WorkflowPermission.delete_all
Chris@1494 695 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 696 :role_id => 1, :field_name => 'due_date',
Chris@1494 697 :rule => 'readonly')
Chris@1494 698 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1494 699 :role_id => 1, :field_name => 'start_date',
Chris@1494 700 :rule => 'readonly')
Chris@1494 701 user = User.find(2)
Chris@1494 702
Chris@1494 703 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1494 704
Chris@1494 705 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
Chris@1494 706 'due_date' => '2012-07-14'}, user
Chris@1494 707 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1494 708 assert_nil issue.due_date
Chris@1494 709
Chris@1494 710 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
Chris@1494 711 'due_date' => '2012-07-16',
Chris@1494 712 'tracker_id' => 2}, user
Chris@1494 713 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1494 714 assert_equal Date.parse('2012-07-16'), issue.due_date
Chris@1494 715 end
Chris@1494 716
Chris@1494 717 def test_safe_attributes_should_accept_target_status_writable_fields
Chris@1494 718 WorkflowPermission.delete_all
Chris@1494 719 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 720 :role_id => 1, :field_name => 'due_date',
Chris@1494 721 :rule => 'readonly')
Chris@1494 722 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
Chris@1494 723 :role_id => 1, :field_name => 'start_date',
Chris@1494 724 :rule => 'readonly')
Chris@1494 725 user = User.find(2)
Chris@1494 726
Chris@1494 727 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1494 728
Chris@1494 729 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
Chris@1494 730 'due_date' => '2012-07-14'},
Chris@1494 731 user
Chris@1494 732 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1494 733 assert_nil issue.due_date
Chris@1494 734
Chris@1494 735 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
Chris@1494 736 'due_date' => '2012-07-16',
Chris@1494 737 'status_id' => 2},
Chris@1494 738 user
Chris@1494 739 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1494 740 assert_equal Date.parse('2012-07-16'), issue.due_date
Chris@1494 741 end
Chris@1494 742
Chris@1494 743 def test_required_attributes_should_be_validated
Chris@1494 744 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
Chris@1494 745 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1494 746
Chris@1494 747 WorkflowPermission.delete_all
Chris@1494 748 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 749 :role_id => 1, :field_name => 'due_date',
Chris@1494 750 :rule => 'required')
Chris@1494 751 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 752 :role_id => 1, :field_name => 'category_id',
Chris@1494 753 :rule => 'required')
Chris@1494 754 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 755 :role_id => 1, :field_name => cf.id.to_s,
Chris@1494 756 :rule => 'required')
Chris@1494 757
Chris@1494 758 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1494 759 :role_id => 1, :field_name => 'start_date',
Chris@1494 760 :rule => 'required')
Chris@1494 761 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1494 762 :role_id => 1, :field_name => cf.id.to_s,
Chris@1494 763 :rule => 'required')
Chris@1494 764 user = User.find(2)
Chris@1494 765
Chris@1494 766 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1494 767 :status_id => 1, :subject => 'Required fields',
Chris@1494 768 :author => user)
Chris@1494 769 assert_equal [cf.id.to_s, "category_id", "due_date"],
Chris@1494 770 issue.required_attribute_names(user).sort
Chris@1494 771 assert !issue.save, "Issue was saved"
Chris@1494 772 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
Chris@1494 773 issue.errors.full_messages.sort
Chris@1494 774
Chris@1494 775 issue.tracker_id = 2
Chris@1494 776 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
Chris@1494 777 assert !issue.save, "Issue was saved"
Chris@1494 778 assert_equal ["Foo can't be blank", "Start date can't be blank"],
Chris@1494 779 issue.errors.full_messages.sort
Chris@1494 780
Chris@1494 781 issue.start_date = Date.today
Chris@1494 782 issue.custom_field_values = {cf.id.to_s => 'bar'}
Chris@1494 783 assert issue.save
Chris@1494 784 end
Chris@1494 785
Chris@1494 786 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
Chris@1494 787 WorkflowPermission.delete_all
Chris@1494 788 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 789 :role_id => 1, :field_name => 'due_date',
Chris@1494 790 :rule => 'required')
Chris@1494 791 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 792 :role_id => 1, :field_name => 'start_date',
Chris@1494 793 :rule => 'required')
Chris@1494 794 user = User.find(2)
Chris@1494 795 member = Member.find(1)
Chris@1494 796 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1494 797
Chris@1494 798 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
Chris@1494 799
Chris@1494 800 member.role_ids = [1, 2]
Chris@1494 801 member.save!
Chris@1494 802 assert_equal [], issue.required_attribute_names(user.reload)
Chris@1494 803
Chris@1494 804 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 805 :role_id => 2, :field_name => 'due_date',
Chris@1494 806 :rule => 'required')
Chris@1494 807 assert_equal %w(due_date), issue.required_attribute_names(user)
Chris@1494 808
Chris@1494 809 member.role_ids = [1, 2, 3]
Chris@1494 810 member.save!
Chris@1494 811 assert_equal [], issue.required_attribute_names(user.reload)
Chris@1494 812
Chris@1494 813 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 814 :role_id => 2, :field_name => 'due_date',
Chris@1494 815 :rule => 'readonly')
Chris@1494 816 # required + readonly => required
Chris@1494 817 assert_equal %w(due_date), issue.required_attribute_names(user)
Chris@1494 818 end
Chris@1494 819
Chris@1494 820 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
Chris@1494 821 WorkflowPermission.delete_all
Chris@1494 822 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 823 :role_id => 1, :field_name => 'due_date',
Chris@1494 824 :rule => 'readonly')
Chris@1494 825 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 826 :role_id => 1, :field_name => 'start_date',
Chris@1494 827 :rule => 'readonly')
Chris@1494 828 user = User.find(2)
Chris@1494 829 member = Member.find(1)
Chris@1494 830 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1494 831
Chris@1494 832 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
Chris@1494 833
Chris@1494 834 member.role_ids = [1, 2]
Chris@1494 835 member.save!
Chris@1494 836 assert_equal [], issue.read_only_attribute_names(user.reload)
Chris@1494 837
Chris@1494 838 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1494 839 :role_id => 2, :field_name => 'due_date',
Chris@1494 840 :rule => 'readonly')
Chris@1494 841 assert_equal %w(due_date), issue.read_only_attribute_names(user)
Chris@1494 842 end
Chris@1494 843
Chris@1494 844 def test_copy
Chris@1494 845 issue = Issue.new.copy_from(1)
Chris@1494 846 assert issue.copy?
Chris@1494 847 assert issue.save
Chris@1494 848 issue.reload
Chris@1494 849 orig = Issue.find(1)
Chris@1494 850 assert_equal orig.subject, issue.subject
Chris@1494 851 assert_equal orig.tracker, issue.tracker
Chris@1494 852 assert_equal "125", issue.custom_value_for(2).value
Chris@1494 853 end
Chris@1494 854
Chris@1494 855 def test_copy_should_copy_status
Chris@1494 856 orig = Issue.find(8)
Chris@1494 857 assert orig.status != IssueStatus.default
Chris@1494 858
Chris@1494 859 issue = Issue.new.copy_from(orig)
Chris@1494 860 assert issue.save
Chris@1494 861 issue.reload
Chris@1494 862 assert_equal orig.status, issue.status
Chris@1494 863 end
Chris@1494 864
Chris@1494 865 def test_copy_should_add_relation_with_copied_issue
Chris@1494 866 copied = Issue.find(1)
Chris@1494 867 issue = Issue.new.copy_from(copied)
Chris@1494 868 assert issue.save
Chris@1494 869 issue.reload
Chris@1494 870
Chris@1494 871 assert_equal 1, issue.relations.size
Chris@1494 872 relation = issue.relations.first
Chris@1494 873 assert_equal 'copied_to', relation.relation_type
Chris@1494 874 assert_equal copied, relation.issue_from
Chris@1494 875 assert_equal issue, relation.issue_to
Chris@1494 876 end
Chris@1494 877
Chris@1494 878 def test_copy_should_copy_subtasks
Chris@1494 879 issue = Issue.generate_with_descendants!
Chris@1494 880
Chris@1494 881 copy = issue.reload.copy
Chris@1494 882 copy.author = User.find(7)
Chris@1494 883 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1494 884 assert copy.save
Chris@1494 885 end
Chris@1494 886 copy.reload
Chris@1494 887 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
Chris@1494 888 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
Chris@1494 889 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
Chris@1494 890 assert_equal copy.author, child_copy.author
Chris@1494 891 end
Chris@1494 892
Chris@1494 893 def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
Chris@1494 894 parent = Issue.generate!
Chris@1494 895 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
Chris@1494 896 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
Chris@1494 897
Chris@1494 898 copy = parent.reload.copy
Chris@1494 899 copy.parent_issue_id = parent.id
Chris@1494 900 copy.author = User.find(7)
Chris@1494 901 assert_difference 'Issue.count', 3 do
Chris@1494 902 assert copy.save
Chris@1494 903 end
Chris@1494 904 parent.reload
Chris@1494 905 copy.reload
Chris@1494 906 assert_equal parent, copy.parent
Chris@1494 907 assert_equal 3, parent.children.count
Chris@1494 908 assert_equal 5, parent.descendants.count
Chris@1494 909 assert_equal 2, copy.children.count
Chris@1494 910 assert_equal 2, copy.descendants.count
Chris@1494 911 end
Chris@1494 912
Chris@1494 913 def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
Chris@1494 914 parent = Issue.generate!
Chris@1494 915 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
Chris@1494 916 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
Chris@1494 917
Chris@1494 918 copy = parent.reload.copy
Chris@1494 919 copy.parent_issue_id = child1.id
Chris@1494 920 copy.author = User.find(7)
Chris@1494 921 assert_difference 'Issue.count', 3 do
Chris@1494 922 assert copy.save
Chris@1494 923 end
Chris@1494 924 parent.reload
Chris@1494 925 child1.reload
Chris@1494 926 copy.reload
Chris@1494 927 assert_equal child1, copy.parent
Chris@1494 928 assert_equal 2, parent.children.count
Chris@1494 929 assert_equal 5, parent.descendants.count
Chris@1494 930 assert_equal 1, child1.children.count
Chris@1494 931 assert_equal 3, child1.descendants.count
Chris@1494 932 assert_equal 2, copy.children.count
Chris@1494 933 assert_equal 2, copy.descendants.count
Chris@1494 934 end
Chris@1494 935
Chris@1494 936 def test_copy_should_copy_subtasks_to_target_project
Chris@1494 937 issue = Issue.generate_with_descendants!
Chris@1494 938
Chris@1494 939 copy = issue.copy(:project_id => 3)
Chris@1494 940 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1494 941 assert copy.save
Chris@1494 942 end
Chris@1494 943 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
Chris@1494 944 end
Chris@1494 945
Chris@1494 946 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
Chris@1494 947 issue = Issue.generate_with_descendants!
Chris@1494 948
Chris@1494 949 copy = issue.reload.copy
Chris@1494 950 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1494 951 assert copy.save
Chris@1494 952 assert copy.save
Chris@1494 953 end
Chris@1494 954 end
Chris@1494 955
Chris@1494 956 def test_should_not_call_after_project_change_on_creation
Chris@1494 957 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
Chris@1494 958 :subject => 'Test', :author_id => 1)
Chris@1494 959 issue.expects(:after_project_change).never
Chris@1494 960 issue.save!
Chris@1494 961 end
Chris@1494 962
Chris@1494 963 def test_should_not_call_after_project_change_on_update
Chris@1494 964 issue = Issue.find(1)
Chris@1494 965 issue.project = Project.find(1)
Chris@1494 966 issue.subject = 'No project change'
Chris@1494 967 issue.expects(:after_project_change).never
Chris@1494 968 issue.save!
Chris@1494 969 end
Chris@1494 970
Chris@1494 971 def test_should_call_after_project_change_on_project_change
Chris@1494 972 issue = Issue.find(1)
Chris@1494 973 issue.project = Project.find(2)
Chris@1494 974 issue.expects(:after_project_change).once
Chris@1494 975 issue.save!
Chris@1494 976 end
Chris@1494 977
Chris@1494 978 def test_adding_journal_should_update_timestamp
Chris@1494 979 issue = Issue.find(1)
Chris@1494 980 updated_on_was = issue.updated_on
Chris@1494 981
Chris@1494 982 issue.init_journal(User.first, "Adding notes")
Chris@1494 983 assert_difference 'Journal.count' do
Chris@1494 984 assert issue.save
Chris@1494 985 end
Chris@1494 986 issue.reload
Chris@1494 987
Chris@1494 988 assert_not_equal updated_on_was, issue.updated_on
Chris@1494 989 end
Chris@1494 990
Chris@1494 991 def test_should_close_duplicates
Chris@1494 992 # Create 3 issues
Chris@1494 993 issue1 = Issue.generate!
Chris@1494 994 issue2 = Issue.generate!
Chris@1494 995 issue3 = Issue.generate!
Chris@1494 996
Chris@1494 997 # 2 is a dupe of 1
Chris@1494 998 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
Chris@1494 999 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1494 1000 # And 3 is a dupe of 2
Chris@1494 1001 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
Chris@1494 1002 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1494 1003 # And 3 is a dupe of 1 (circular duplicates)
Chris@1494 1004 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
Chris@1494 1005 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1494 1006
Chris@1494 1007 assert issue1.reload.duplicates.include?(issue2)
Chris@1494 1008
Chris@1494 1009 # Closing issue 1
Chris@1494 1010 issue1.init_journal(User.first, "Closing issue1")
Chris@1494 1011 issue1.status = IssueStatus.where(:is_closed => true).first
Chris@1494 1012 assert issue1.save
Chris@1494 1013 # 2 and 3 should be also closed
Chris@1494 1014 assert issue2.reload.closed?
Chris@1494 1015 assert issue3.reload.closed?
Chris@1494 1016 end
Chris@1494 1017
Chris@1494 1018 def test_should_not_close_duplicated_issue
Chris@1494 1019 issue1 = Issue.generate!
Chris@1494 1020 issue2 = Issue.generate!
Chris@1494 1021
Chris@1494 1022 # 2 is a dupe of 1
Chris@1494 1023 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
Chris@1494 1024 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1494 1025 # 2 is a dup of 1 but 1 is not a duplicate of 2
Chris@1494 1026 assert !issue2.reload.duplicates.include?(issue1)
Chris@1494 1027
Chris@1494 1028 # Closing issue 2
Chris@1494 1029 issue2.init_journal(User.first, "Closing issue2")
Chris@1494 1030 issue2.status = IssueStatus.where(:is_closed => true).first
Chris@1494 1031 assert issue2.save
Chris@1494 1032 # 1 should not be also closed
Chris@1494 1033 assert !issue1.reload.closed?
Chris@1494 1034 end
Chris@1494 1035
Chris@1494 1036 def test_assignable_versions
Chris@1494 1037 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1494 1038 :status_id => 1, :fixed_version_id => 1,
Chris@1494 1039 :subject => 'New issue')
Chris@1494 1040 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
Chris@1494 1041 end
Chris@1494 1042
Chris@1494 1043 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
Chris@1494 1044 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1494 1045 :status_id => 1, :fixed_version_id => 1,
Chris@1494 1046 :subject => 'New issue')
Chris@1494 1047 assert !issue.save
Chris@1494 1048 assert_not_equal [], issue.errors[:fixed_version_id]
Chris@1494 1049 end
Chris@1494 1050
Chris@1494 1051 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
Chris@1494 1052 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1494 1053 :status_id => 1, :fixed_version_id => 2,
Chris@1494 1054 :subject => 'New issue')
Chris@1494 1055 assert !issue.save
Chris@1494 1056 assert_not_equal [], issue.errors[:fixed_version_id]
Chris@1494 1057 end
Chris@1494 1058
Chris@1494 1059 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
Chris@1494 1060 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1494 1061 :status_id => 1, :fixed_version_id => 3,
Chris@1494 1062 :subject => 'New issue')
Chris@1494 1063 assert issue.save
Chris@1494 1064 end
Chris@1494 1065
Chris@1494 1066 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
Chris@1494 1067 issue = Issue.find(11)
Chris@1494 1068 assert_equal 'closed', issue.fixed_version.status
Chris@1494 1069 issue.subject = 'Subject changed'
Chris@1494 1070 assert issue.save
Chris@1494 1071 end
Chris@1494 1072
Chris@1494 1073 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
Chris@1494 1074 issue = Issue.find(11)
Chris@1494 1075 issue.status_id = 1
Chris@1494 1076 assert !issue.save
Chris@1494 1077 assert_not_equal [], issue.errors[:base]
Chris@1494 1078 end
Chris@1494 1079
Chris@1494 1080 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
Chris@1494 1081 issue = Issue.find(11)
Chris@1494 1082 issue.status_id = 1
Chris@1494 1083 issue.fixed_version_id = 3
Chris@1494 1084 assert issue.save
Chris@1494 1085 end
Chris@1494 1086
Chris@1494 1087 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
Chris@1494 1088 issue = Issue.find(12)
Chris@1494 1089 assert_equal 'locked', issue.fixed_version.status
Chris@1494 1090 issue.status_id = 1
Chris@1494 1091 assert issue.save
Chris@1494 1092 end
Chris@1494 1093
Chris@1494 1094 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
Chris@1494 1095 issue = Issue.find(2)
Chris@1494 1096 assert_equal 2, issue.fixed_version_id
Chris@1494 1097 issue.project_id = 3
Chris@1494 1098 assert_nil issue.fixed_version_id
Chris@1494 1099 issue.fixed_version_id = 2
Chris@1494 1100 assert !issue.save
Chris@1494 1101 assert_include 'Target version is not included in the list', issue.errors.full_messages
Chris@1494 1102 end
Chris@1494 1103
Chris@1494 1104 def test_should_keep_shared_version_when_changing_project
Chris@1494 1105 Version.find(2).update_attribute :sharing, 'tree'
Chris@1494 1106
Chris@1494 1107 issue = Issue.find(2)
Chris@1494 1108 assert_equal 2, issue.fixed_version_id
Chris@1494 1109 issue.project_id = 3
Chris@1494 1110 assert_equal 2, issue.fixed_version_id
Chris@1494 1111 assert issue.save
Chris@1494 1112 end
Chris@1494 1113
Chris@1494 1114 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
Chris@1494 1115 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
Chris@1494 1116 end
Chris@1494 1117
Chris@1494 1118 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
Chris@1494 1119 Project.find(2).disable_module! :issue_tracking
Chris@1494 1120 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
Chris@1494 1121 end
Chris@1494 1122
Chris@1494 1123 def test_move_to_another_project_with_same_category
Chris@1494 1124 issue = Issue.find(1)
Chris@1494 1125 issue.project = Project.find(2)
Chris@1494 1126 assert issue.save
Chris@1494 1127 issue.reload
Chris@1494 1128 assert_equal 2, issue.project_id
Chris@1494 1129 # Category changes
Chris@1494 1130 assert_equal 4, issue.category_id
Chris@1494 1131 # Make sure time entries were move to the target project
Chris@1494 1132 assert_equal 2, issue.time_entries.first.project_id
Chris@1494 1133 end
Chris@1494 1134
Chris@1494 1135 def test_move_to_another_project_without_same_category
Chris@1494 1136 issue = Issue.find(2)
Chris@1494 1137 issue.project = Project.find(2)
Chris@1494 1138 assert issue.save
Chris@1494 1139 issue.reload
Chris@1494 1140 assert_equal 2, issue.project_id
Chris@1494 1141 # Category cleared
Chris@1494 1142 assert_nil issue.category_id
Chris@1494 1143 end
Chris@1494 1144
Chris@1494 1145 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
Chris@1494 1146 issue = Issue.find(1)
Chris@1494 1147 issue.update_attribute(:fixed_version_id, 1)
Chris@1494 1148 issue.project = Project.find(2)
Chris@1494 1149 assert issue.save
Chris@1494 1150 issue.reload
Chris@1494 1151 assert_equal 2, issue.project_id
Chris@1494 1152 # Cleared fixed_version
Chris@1494 1153 assert_equal nil, issue.fixed_version
Chris@1494 1154 end
Chris@1494 1155
Chris@1494 1156 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
Chris@1494 1157 issue = Issue.find(1)
Chris@1494 1158 issue.update_attribute(:fixed_version_id, 4)
Chris@1494 1159 issue.project = Project.find(5)
Chris@1494 1160 assert issue.save
Chris@1494 1161 issue.reload
Chris@1494 1162 assert_equal 5, issue.project_id
Chris@1494 1163 # Keep fixed_version
Chris@1494 1164 assert_equal 4, issue.fixed_version_id
Chris@1494 1165 end
Chris@1494 1166
Chris@1494 1167 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
Chris@1494 1168 issue = Issue.find(1)
Chris@1494 1169 issue.update_attribute(:fixed_version_id, 1)
Chris@1494 1170 issue.project = Project.find(5)
Chris@1494 1171 assert issue.save
Chris@1494 1172 issue.reload
Chris@1494 1173 assert_equal 5, issue.project_id
Chris@1494 1174 # Cleared fixed_version
Chris@1494 1175 assert_equal nil, issue.fixed_version
Chris@1494 1176 end
Chris@1494 1177
Chris@1494 1178 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
Chris@1494 1179 issue = Issue.find(1)
Chris@1494 1180 issue.update_attribute(:fixed_version_id, 7)
Chris@1494 1181 issue.project = Project.find(2)
Chris@1494 1182 assert issue.save
Chris@1494 1183 issue.reload
Chris@1494 1184 assert_equal 2, issue.project_id
Chris@1494 1185 # Keep fixed_version
Chris@1494 1186 assert_equal 7, issue.fixed_version_id
Chris@1494 1187 end
Chris@1494 1188
Chris@1494 1189 def test_move_to_another_project_should_keep_parent_if_valid
Chris@1494 1190 issue = Issue.find(1)
Chris@1494 1191 issue.update_attribute(:parent_issue_id, 2)
Chris@1494 1192 issue.project = Project.find(3)
Chris@1494 1193 assert issue.save
Chris@1494 1194 issue.reload
Chris@1494 1195 assert_equal 2, issue.parent_id
Chris@1494 1196 end
Chris@1494 1197
Chris@1494 1198 def test_move_to_another_project_should_clear_parent_if_not_valid
Chris@1494 1199 issue = Issue.find(1)
Chris@1494 1200 issue.update_attribute(:parent_issue_id, 2)
Chris@1494 1201 issue.project = Project.find(2)
Chris@1494 1202 assert issue.save
Chris@1494 1203 issue.reload
Chris@1494 1204 assert_nil issue.parent_id
Chris@1494 1205 end
Chris@1494 1206
Chris@1494 1207 def test_move_to_another_project_with_disabled_tracker
Chris@1494 1208 issue = Issue.find(1)
Chris@1494 1209 target = Project.find(2)
Chris@1494 1210 target.tracker_ids = [3]
Chris@1494 1211 target.save
Chris@1494 1212 issue.project = target
Chris@1494 1213 assert issue.save
Chris@1494 1214 issue.reload
Chris@1494 1215 assert_equal 2, issue.project_id
Chris@1494 1216 assert_equal 3, issue.tracker_id
Chris@1494 1217 end
Chris@1494 1218
Chris@1494 1219 def test_copy_to_the_same_project
Chris@1494 1220 issue = Issue.find(1)
Chris@1494 1221 copy = issue.copy
Chris@1494 1222 assert_difference 'Issue.count' do
Chris@1494 1223 copy.save!
Chris@1494 1224 end
Chris@1494 1225 assert_kind_of Issue, copy
Chris@1494 1226 assert_equal issue.project, copy.project
Chris@1494 1227 assert_equal "125", copy.custom_value_for(2).value
Chris@1494 1228 end
Chris@1494 1229
Chris@1494 1230 def test_copy_to_another_project_and_tracker
Chris@1494 1231 issue = Issue.find(1)
Chris@1494 1232 copy = issue.copy(:project_id => 3, :tracker_id => 2)
Chris@1494 1233 assert_difference 'Issue.count' do
Chris@1494 1234 copy.save!
Chris@1494 1235 end
Chris@1494 1236 copy.reload
Chris@1494 1237 assert_kind_of Issue, copy
Chris@1494 1238 assert_equal Project.find(3), copy.project
Chris@1494 1239 assert_equal Tracker.find(2), copy.tracker
Chris@1494 1240 # Custom field #2 is not associated with target tracker
Chris@1494 1241 assert_nil copy.custom_value_for(2)
Chris@1494 1242 end
Chris@1494 1243
Chris@1494 1244 test "#copy should not create a journal" do
Chris@1494 1245 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
Chris@1494 1246 copy.save!
Chris@1494 1247 assert_equal 0, copy.reload.journals.size
Chris@1494 1248 end
Chris@1494 1249
Chris@1494 1250 test "#copy should allow assigned_to changes" do
Chris@1494 1251 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
Chris@1494 1252 assert_equal 3, copy.assigned_to_id
Chris@1494 1253 end
Chris@1494 1254
Chris@1494 1255 test "#copy should allow status changes" do
Chris@1494 1256 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
Chris@1494 1257 assert_equal 2, copy.status_id
Chris@1494 1258 end
Chris@1494 1259
Chris@1494 1260 test "#copy should allow start date changes" do
Chris@1494 1261 date = Date.today
Chris@1494 1262 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
Chris@1494 1263 assert_equal date, copy.start_date
Chris@1494 1264 end
Chris@1494 1265
Chris@1494 1266 test "#copy should allow due date changes" do
Chris@1494 1267 date = Date.today
Chris@1494 1268 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
Chris@1494 1269 assert_equal date, copy.due_date
Chris@1494 1270 end
Chris@1494 1271
Chris@1494 1272 test "#copy should set current user as author" do
Chris@1494 1273 User.current = User.find(9)
Chris@1494 1274 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
Chris@1494 1275 assert_equal User.current, copy.author
Chris@1494 1276 end
Chris@1494 1277
Chris@1494 1278 test "#copy should create a journal with notes" do
Chris@1494 1279 date = Date.today
Chris@1494 1280 notes = "Notes added when copying"
Chris@1494 1281 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
Chris@1494 1282 copy.init_journal(User.current, notes)
Chris@1494 1283 copy.save!
Chris@1494 1284
Chris@1494 1285 assert_equal 1, copy.journals.size
Chris@1494 1286 journal = copy.journals.first
Chris@1494 1287 assert_equal 0, journal.details.size
Chris@1494 1288 assert_equal notes, journal.notes
Chris@1494 1289 end
Chris@1494 1290
Chris@1494 1291 def test_valid_parent_project
Chris@1494 1292 issue = Issue.find(1)
Chris@1494 1293 issue_in_same_project = Issue.find(2)
Chris@1494 1294 issue_in_child_project = Issue.find(5)
Chris@1494 1295 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
Chris@1494 1296 issue_in_other_child_project = Issue.find(6)
Chris@1494 1297 issue_in_different_tree = Issue.find(4)
Chris@1494 1298
Chris@1494 1299 with_settings :cross_project_subtasks => '' do
Chris@1494 1300 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1494 1301 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
Chris@1494 1302 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1494 1303 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1494 1304 end
Chris@1494 1305
Chris@1494 1306 with_settings :cross_project_subtasks => 'system' do
Chris@1494 1307 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1494 1308 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
Chris@1494 1309 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
Chris@1494 1310 end
Chris@1494 1311
Chris@1494 1312 with_settings :cross_project_subtasks => 'tree' do
Chris@1494 1313 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1494 1314 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
Chris@1494 1315 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1494 1316 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1494 1317
Chris@1494 1318 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
Chris@1494 1319 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
Chris@1494 1320 end
Chris@1494 1321
Chris@1494 1322 with_settings :cross_project_subtasks => 'descendants' do
Chris@1494 1323 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1494 1324 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
Chris@1494 1325 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1494 1326 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1494 1327
Chris@1494 1328 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
Chris@1494 1329 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
Chris@1494 1330 end
Chris@1494 1331 end
Chris@1494 1332
Chris@1494 1333 def test_recipients_should_include_previous_assignee
Chris@1494 1334 user = User.find(3)
Chris@1494 1335 user.members.update_all ["mail_notification = ?", false]
Chris@1494 1336 user.update_attribute :mail_notification, 'only_assigned'
Chris@1494 1337
Chris@1494 1338 issue = Issue.find(2)
Chris@1494 1339 issue.assigned_to = nil
Chris@1494 1340 assert_include user.mail, issue.recipients
Chris@1494 1341 issue.save!
Chris@1494 1342 assert !issue.recipients.include?(user.mail)
Chris@1494 1343 end
Chris@1494 1344
Chris@1494 1345 def test_recipients_should_not_include_users_that_cannot_view_the_issue
Chris@1494 1346 issue = Issue.find(12)
Chris@1494 1347 assert issue.recipients.include?(issue.author.mail)
Chris@1494 1348 # copy the issue to a private project
Chris@1494 1349 copy = issue.copy(:project_id => 5, :tracker_id => 2)
Chris@1494 1350 # author is not a member of project anymore
Chris@1494 1351 assert !copy.recipients.include?(copy.author.mail)
Chris@1494 1352 end
Chris@1494 1353
Chris@1494 1354 def test_recipients_should_include_the_assigned_group_members
Chris@1494 1355 group_member = User.generate!
Chris@1494 1356 group = Group.generate!
Chris@1494 1357 group.users << group_member
Chris@1494 1358
Chris@1494 1359 issue = Issue.find(12)
Chris@1494 1360 issue.assigned_to = group
Chris@1494 1361 assert issue.recipients.include?(group_member.mail)
Chris@1494 1362 end
Chris@1494 1363
Chris@1494 1364 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
Chris@1494 1365 user = User.find(3)
Chris@1494 1366 issue = Issue.find(9)
Chris@1494 1367 Watcher.create!(:user => user, :watchable => issue)
Chris@1494 1368 assert issue.watched_by?(user)
Chris@1494 1369 assert !issue.watcher_recipients.include?(user.mail)
Chris@1494 1370 end
Chris@1494 1371
Chris@1494 1372 def test_issue_destroy
Chris@1494 1373 Issue.find(1).destroy
Chris@1494 1374 assert_nil Issue.find_by_id(1)
Chris@1494 1375 assert_nil TimeEntry.find_by_issue_id(1)
Chris@1494 1376 end
Chris@1494 1377
Chris@1494 1378 def test_destroying_a_deleted_issue_should_not_raise_an_error
Chris@1494 1379 issue = Issue.find(1)
Chris@1494 1380 Issue.find(1).destroy
Chris@1494 1381
Chris@1494 1382 assert_nothing_raised do
Chris@1494 1383 assert_no_difference 'Issue.count' do
Chris@1494 1384 issue.destroy
Chris@1494 1385 end
Chris@1494 1386 assert issue.destroyed?
Chris@1494 1387 end
Chris@1494 1388 end
Chris@1494 1389
Chris@1494 1390 def test_destroying_a_stale_issue_should_not_raise_an_error
Chris@1494 1391 issue = Issue.find(1)
Chris@1494 1392 Issue.find(1).update_attribute :subject, "Updated"
Chris@1494 1393
Chris@1494 1394 assert_nothing_raised do
Chris@1494 1395 assert_difference 'Issue.count', -1 do
Chris@1494 1396 issue.destroy
Chris@1494 1397 end
Chris@1494 1398 assert issue.destroyed?
Chris@1494 1399 end
Chris@1494 1400 end
Chris@1494 1401
Chris@1494 1402 def test_blocked
Chris@1494 1403 blocked_issue = Issue.find(9)
Chris@1494 1404 blocking_issue = Issue.find(10)
Chris@1494 1405
Chris@1494 1406 assert blocked_issue.blocked?
Chris@1494 1407 assert !blocking_issue.blocked?
Chris@1494 1408 end
Chris@1494 1409
Chris@1494 1410 def test_blocked_issues_dont_allow_closed_statuses
Chris@1494 1411 blocked_issue = Issue.find(9)
Chris@1494 1412
Chris@1494 1413 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
Chris@1494 1414 assert !allowed_statuses.empty?
Chris@1494 1415 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
Chris@1494 1416 assert closed_statuses.empty?
Chris@1494 1417 end
Chris@1494 1418
Chris@1494 1419 def test_unblocked_issues_allow_closed_statuses
Chris@1494 1420 blocking_issue = Issue.find(10)
Chris@1494 1421
Chris@1494 1422 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
Chris@1494 1423 assert !allowed_statuses.empty?
Chris@1494 1424 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
Chris@1494 1425 assert !closed_statuses.empty?
Chris@1494 1426 end
Chris@1494 1427
Chris@1494 1428 def test_reschedule_an_issue_without_dates
Chris@1494 1429 with_settings :non_working_week_days => [] do
Chris@1494 1430 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1494 1431 issue.reschedule_on '2012-10-09'.to_date
Chris@1494 1432 assert_equal '2012-10-09'.to_date, issue.start_date
Chris@1494 1433 assert_equal '2012-10-09'.to_date, issue.due_date
Chris@1494 1434 end
Chris@1494 1435
Chris@1494 1436 with_settings :non_working_week_days => %w(6 7) do
Chris@1494 1437 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1494 1438 issue.reschedule_on '2012-10-09'.to_date
Chris@1494 1439 assert_equal '2012-10-09'.to_date, issue.start_date
Chris@1494 1440 assert_equal '2012-10-09'.to_date, issue.due_date
Chris@1494 1441
Chris@1494 1442 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1494 1443 issue.reschedule_on '2012-10-13'.to_date
Chris@1494 1444 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1494 1445 assert_equal '2012-10-15'.to_date, issue.due_date
Chris@1494 1446 end
Chris@1494 1447 end
Chris@1494 1448
Chris@1494 1449 def test_reschedule_an_issue_with_start_date
Chris@1494 1450 with_settings :non_working_week_days => [] do
Chris@1494 1451 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1494 1452 issue.reschedule_on '2012-10-13'.to_date
Chris@1494 1453 assert_equal '2012-10-13'.to_date, issue.start_date
Chris@1494 1454 assert_equal '2012-10-13'.to_date, issue.due_date
Chris@1494 1455 end
Chris@1494 1456
Chris@1494 1457 with_settings :non_working_week_days => %w(6 7) do
Chris@1494 1458 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1494 1459 issue.reschedule_on '2012-10-11'.to_date
Chris@1494 1460 assert_equal '2012-10-11'.to_date, issue.start_date
Chris@1494 1461 assert_equal '2012-10-11'.to_date, issue.due_date
Chris@1494 1462
Chris@1494 1463 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1494 1464 issue.reschedule_on '2012-10-13'.to_date
Chris@1494 1465 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1494 1466 assert_equal '2012-10-15'.to_date, issue.due_date
Chris@1494 1467 end
Chris@1494 1468 end
Chris@1494 1469
Chris@1494 1470 def test_reschedule_an_issue_with_start_and_due_dates
Chris@1494 1471 with_settings :non_working_week_days => [] do
Chris@1494 1472 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
Chris@1494 1473 issue.reschedule_on '2012-10-13'.to_date
Chris@1494 1474 assert_equal '2012-10-13'.to_date, issue.start_date
Chris@1494 1475 assert_equal '2012-10-19'.to_date, issue.due_date
Chris@1494 1476 end
Chris@1494 1477
Chris@1494 1478 with_settings :non_working_week_days => %w(6 7) do
Chris@1494 1479 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
Chris@1494 1480 issue.reschedule_on '2012-10-11'.to_date
Chris@1494 1481 assert_equal '2012-10-11'.to_date, issue.start_date
Chris@1494 1482 assert_equal '2012-10-23'.to_date, issue.due_date
Chris@1494 1483
Chris@1494 1484 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
Chris@1494 1485 issue.reschedule_on '2012-10-13'.to_date
Chris@1494 1486 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1494 1487 assert_equal '2012-10-25'.to_date, issue.due_date
Chris@1494 1488 end
Chris@1494 1489 end
Chris@1494 1490
Chris@1494 1491 def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
Chris@1494 1492 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1494 1493 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1494 1494 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1494 1495 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1496 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1494 1497
Chris@1494 1498 issue1.reload
Chris@1494 1499 issue1.due_date = '2012-10-23'
Chris@1494 1500 issue1.save!
Chris@1494 1501 issue2.reload
Chris@1494 1502 assert_equal Date.parse('2012-10-24'), issue2.start_date
Chris@1494 1503 assert_equal Date.parse('2012-10-26'), issue2.due_date
Chris@1494 1504 end
Chris@1494 1505
Chris@1494 1506 def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
Chris@1494 1507 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1494 1508 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1494 1509 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1494 1510 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1511 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1494 1512
Chris@1494 1513 issue1.reload
Chris@1494 1514 issue1.start_date = '2012-09-17'
Chris@1494 1515 issue1.due_date = '2012-09-18'
Chris@1494 1516 issue1.save!
Chris@1494 1517 issue2.reload
Chris@1494 1518 assert_equal Date.parse('2012-09-19'), issue2.start_date
Chris@1494 1519 assert_equal Date.parse('2012-09-21'), issue2.due_date
Chris@1494 1520 end
Chris@1494 1521
Chris@1494 1522 def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
Chris@1494 1523 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1494 1524 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1494 1525 issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
Chris@1494 1526 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1494 1527 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1528 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
Chris@1494 1529 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1530 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1494 1531
Chris@1494 1532 issue1.reload
Chris@1494 1533 issue1.start_date = '2012-09-17'
Chris@1494 1534 issue1.due_date = '2012-09-18'
Chris@1494 1535 issue1.save!
Chris@1494 1536 issue2.reload
Chris@1494 1537 # Issue 2 must start after Issue 3
Chris@1494 1538 assert_equal Date.parse('2012-10-03'), issue2.start_date
Chris@1494 1539 assert_equal Date.parse('2012-10-05'), issue2.due_date
Chris@1494 1540 end
Chris@1494 1541
Chris@1494 1542 def test_rescheduling_a_stale_issue_should_not_raise_an_error
Chris@1494 1543 with_settings :non_working_week_days => [] do
Chris@1494 1544 stale = Issue.find(1)
Chris@1494 1545 issue = Issue.find(1)
Chris@1494 1546 issue.subject = "Updated"
Chris@1494 1547 issue.save!
Chris@1494 1548 date = 10.days.from_now.to_date
Chris@1494 1549 assert_nothing_raised do
Chris@1494 1550 stale.reschedule_on!(date)
Chris@1494 1551 end
Chris@1494 1552 assert_equal date, stale.reload.start_date
Chris@1494 1553 end
Chris@1494 1554 end
Chris@1494 1555
Chris@1494 1556 def test_child_issue_should_consider_parent_soonest_start_on_create
Chris@1494 1557 set_language_if_valid 'en'
Chris@1494 1558 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1494 1559 issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
Chris@1494 1560 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1494 1561 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1562 issue1.reload
Chris@1494 1563 issue2.reload
Chris@1494 1564 assert_equal Date.parse('2012-10-18'), issue2.start_date
Chris@1494 1565
Chris@1494 1566 child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
Chris@1494 1567 :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
Chris@1494 1568 assert !child.valid?
Chris@1494 1569 assert_include 'Start date cannot be earlier than 10/18/2012 because of preceding issues', child.errors.full_messages
Chris@1494 1570 assert_equal Date.parse('2012-10-18'), child.soonest_start
Chris@1494 1571 child.start_date = '2012-10-18'
Chris@1494 1572 assert child.save
Chris@1494 1573 end
Chris@1494 1574
Chris@1494 1575 def test_setting_parent_to_a_dependent_issue_should_not_validate
Chris@1494 1576 set_language_if_valid 'en'
Chris@1494 1577 issue1 = Issue.generate!
Chris@1494 1578 issue2 = Issue.generate!
Chris@1494 1579 issue3 = Issue.generate!
Chris@1494 1580 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1581 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1582 issue3.reload
Chris@1494 1583 issue3.parent_issue_id = issue2.id
Chris@1494 1584 assert !issue3.valid?
Chris@1494 1585 assert_include 'Parent task is invalid', issue3.errors.full_messages
Chris@1494 1586 end
Chris@1494 1587
Chris@1494 1588 def test_setting_parent_should_not_allow_circular_dependency
Chris@1494 1589 set_language_if_valid 'en'
Chris@1494 1590 issue1 = Issue.generate!
Chris@1494 1591 issue2 = Issue.generate!
Chris@1494 1592 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1593 issue3 = Issue.generate!
Chris@1494 1594 issue2.reload
Chris@1494 1595 issue2.parent_issue_id = issue3.id
Chris@1494 1596 issue2.save!
Chris@1494 1597 issue4 = Issue.generate!
Chris@1494 1598 IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1599 issue4.reload
Chris@1494 1600 issue4.parent_issue_id = issue1.id
Chris@1494 1601 assert !issue4.valid?
Chris@1494 1602 assert_include 'Parent task is invalid', issue4.errors.full_messages
Chris@1494 1603 end
Chris@1494 1604
Chris@1494 1605 def test_overdue
Chris@1494 1606 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
Chris@1494 1607 assert !Issue.new(:due_date => Date.today).overdue?
Chris@1494 1608 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
Chris@1494 1609 assert !Issue.new(:due_date => nil).overdue?
Chris@1494 1610 assert !Issue.new(:due_date => 1.day.ago.to_date,
Chris@1494 1611 :status => IssueStatus.where(:is_closed => true).first
Chris@1494 1612 ).overdue?
Chris@1494 1613 end
Chris@1494 1614
Chris@1494 1615 test "#behind_schedule? should be false if the issue has no start_date" do
Chris@1494 1616 assert !Issue.new(:start_date => nil,
Chris@1494 1617 :due_date => 1.day.from_now.to_date,
Chris@1494 1618 :done_ratio => 0).behind_schedule?
Chris@1494 1619 end
Chris@1494 1620
Chris@1494 1621 test "#behind_schedule? should be false if the issue has no end_date" do
Chris@1494 1622 assert !Issue.new(:start_date => 1.day.from_now.to_date,
Chris@1494 1623 :due_date => nil,
Chris@1494 1624 :done_ratio => 0).behind_schedule?
Chris@1494 1625 end
Chris@1494 1626
Chris@1494 1627 test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
Chris@1494 1628 assert !Issue.new(:start_date => 50.days.ago.to_date,
Chris@1494 1629 :due_date => 50.days.from_now.to_date,
Chris@1494 1630 :done_ratio => 90).behind_schedule?
Chris@1494 1631 end
Chris@1494 1632
Chris@1494 1633 test "#behind_schedule? should be true if the issue hasn't been started at all" do
Chris@1494 1634 assert Issue.new(:start_date => 1.day.ago.to_date,
Chris@1494 1635 :due_date => 1.day.from_now.to_date,
Chris@1494 1636 :done_ratio => 0).behind_schedule?
Chris@1494 1637 end
Chris@1494 1638
Chris@1494 1639 test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
Chris@1494 1640 assert Issue.new(:start_date => 100.days.ago.to_date,
Chris@1494 1641 :due_date => Date.today,
Chris@1494 1642 :done_ratio => 90).behind_schedule?
Chris@1494 1643 end
Chris@1494 1644
Chris@1494 1645 test "#assignable_users should be Users" do
Chris@1494 1646 assert_kind_of User, Issue.find(1).assignable_users.first
Chris@1494 1647 end
Chris@1494 1648
Chris@1494 1649 test "#assignable_users should include the issue author" do
Chris@1494 1650 non_project_member = User.generate!
Chris@1494 1651 issue = Issue.generate!(:author => non_project_member)
Chris@1494 1652
Chris@1494 1653 assert issue.assignable_users.include?(non_project_member)
Chris@1494 1654 end
Chris@1494 1655
Chris@1494 1656 test "#assignable_users should include the current assignee" do
Chris@1494 1657 user = User.generate!
Chris@1494 1658 issue = Issue.generate!(:assigned_to => user)
Chris@1494 1659 user.lock!
Chris@1494 1660
Chris@1494 1661 assert Issue.find(issue.id).assignable_users.include?(user)
Chris@1494 1662 end
Chris@1494 1663
Chris@1494 1664 test "#assignable_users should not show the issue author twice" do
Chris@1494 1665 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
Chris@1494 1666 assert_equal 2, assignable_user_ids.length
Chris@1494 1667
Chris@1494 1668 assignable_user_ids.each do |user_id|
Chris@1494 1669 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
Chris@1494 1670 "User #{user_id} appears more or less than once"
Chris@1494 1671 end
Chris@1494 1672 end
Chris@1494 1673
Chris@1494 1674 test "#assignable_users with issue_group_assignment should include groups" do
Chris@1494 1675 issue = Issue.new(:project => Project.find(2))
Chris@1494 1676
Chris@1494 1677 with_settings :issue_group_assignment => '1' do
Chris@1494 1678 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
Chris@1494 1679 assert issue.assignable_users.include?(Group.find(11))
Chris@1494 1680 end
Chris@1494 1681 end
Chris@1494 1682
Chris@1494 1683 test "#assignable_users without issue_group_assignment should not include groups" do
Chris@1494 1684 issue = Issue.new(:project => Project.find(2))
Chris@1494 1685
Chris@1494 1686 with_settings :issue_group_assignment => '0' do
Chris@1494 1687 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
Chris@1494 1688 assert !issue.assignable_users.include?(Group.find(11))
Chris@1494 1689 end
Chris@1494 1690 end
Chris@1494 1691
Chris@1494 1692 def test_create_should_send_email_notification
Chris@1494 1693 ActionMailer::Base.deliveries.clear
Chris@1494 1694 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1494 1695 :author_id => 3, :status_id => 1,
Chris@1494 1696 :priority => IssuePriority.all.first,
Chris@1494 1697 :subject => 'test_create', :estimated_hours => '1:30')
Chris@1494 1698
Chris@1494 1699 assert issue.save
Chris@1494 1700 assert_equal 1, ActionMailer::Base.deliveries.size
Chris@1494 1701 end
Chris@1494 1702
Chris@1494 1703 def test_update_should_notify_previous_assignee
Chris@1494 1704 ActionMailer::Base.deliveries.clear
Chris@1494 1705 user = User.find(3)
Chris@1494 1706 user.members.update_all ["mail_notification = ?", false]
Chris@1494 1707 user.update_attribute :mail_notification, 'only_assigned'
Chris@1494 1708
Chris@1494 1709 issue = Issue.find(2)
Chris@1494 1710 issue.init_journal User.find(1)
Chris@1494 1711 issue.assigned_to = nil
Chris@1494 1712 issue.save!
Chris@1494 1713 assert_include user.mail, ActionMailer::Base.deliveries.last.bcc
Chris@1494 1714 end
Chris@1494 1715
Chris@1494 1716 def test_stale_issue_should_not_send_email_notification
Chris@1494 1717 ActionMailer::Base.deliveries.clear
Chris@1494 1718 issue = Issue.find(1)
Chris@1494 1719 stale = Issue.find(1)
Chris@1494 1720
Chris@1494 1721 issue.init_journal(User.find(1))
Chris@1494 1722 issue.subject = 'Subjet update'
Chris@1494 1723 assert issue.save
Chris@1494 1724 assert_equal 1, ActionMailer::Base.deliveries.size
Chris@1494 1725 ActionMailer::Base.deliveries.clear
Chris@1494 1726
Chris@1494 1727 stale.init_journal(User.find(1))
Chris@1494 1728 stale.subject = 'Another subjet update'
Chris@1494 1729 assert_raise ActiveRecord::StaleObjectError do
Chris@1494 1730 stale.save
Chris@1494 1731 end
Chris@1494 1732 assert ActionMailer::Base.deliveries.empty?
Chris@1494 1733 end
Chris@1494 1734
Chris@1494 1735 def test_journalized_description
Chris@1494 1736 IssueCustomField.delete_all
Chris@1494 1737
Chris@1494 1738 i = Issue.first
Chris@1494 1739 old_description = i.description
Chris@1494 1740 new_description = "This is the new description"
Chris@1494 1741
Chris@1494 1742 i.init_journal(User.find(2))
Chris@1494 1743 i.description = new_description
Chris@1494 1744 assert_difference 'Journal.count', 1 do
Chris@1494 1745 assert_difference 'JournalDetail.count', 1 do
Chris@1494 1746 i.save!
Chris@1494 1747 end
Chris@1494 1748 end
Chris@1494 1749
Chris@1494 1750 detail = JournalDetail.first(:order => 'id DESC')
Chris@1494 1751 assert_equal i, detail.journal.journalized
Chris@1494 1752 assert_equal 'attr', detail.property
Chris@1494 1753 assert_equal 'description', detail.prop_key
Chris@1494 1754 assert_equal old_description, detail.old_value
Chris@1494 1755 assert_equal new_description, detail.value
Chris@1494 1756 end
Chris@1494 1757
Chris@1494 1758 def test_blank_descriptions_should_not_be_journalized
Chris@1494 1759 IssueCustomField.delete_all
Chris@1494 1760 Issue.update_all("description = NULL", "id=1")
Chris@1494 1761
Chris@1494 1762 i = Issue.find(1)
Chris@1494 1763 i.init_journal(User.find(2))
Chris@1494 1764 i.subject = "blank description"
Chris@1494 1765 i.description = "\r\n"
Chris@1494 1766
Chris@1494 1767 assert_difference 'Journal.count', 1 do
Chris@1494 1768 assert_difference 'JournalDetail.count', 1 do
Chris@1494 1769 i.save!
Chris@1494 1770 end
Chris@1494 1771 end
Chris@1494 1772 end
Chris@1494 1773
Chris@1494 1774 def test_journalized_multi_custom_field
Chris@1494 1775 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
Chris@1494 1776 :is_filter => true, :is_for_all => true,
Chris@1494 1777 :tracker_ids => [1],
Chris@1494 1778 :possible_values => ['value1', 'value2', 'value3'],
Chris@1494 1779 :multiple => true)
Chris@1494 1780
Chris@1494 1781 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
Chris@1494 1782 :subject => 'Test', :author_id => 1)
Chris@1494 1783
Chris@1494 1784 assert_difference 'Journal.count' do
Chris@1494 1785 assert_difference 'JournalDetail.count' do
Chris@1494 1786 issue.init_journal(User.first)
Chris@1494 1787 issue.custom_field_values = {field.id => ['value1']}
Chris@1494 1788 issue.save!
Chris@1494 1789 end
Chris@1494 1790 assert_difference 'JournalDetail.count' do
Chris@1494 1791 issue.init_journal(User.first)
Chris@1494 1792 issue.custom_field_values = {field.id => ['value1', 'value2']}
Chris@1494 1793 issue.save!
Chris@1494 1794 end
Chris@1494 1795 assert_difference 'JournalDetail.count', 2 do
Chris@1494 1796 issue.init_journal(User.first)
Chris@1494 1797 issue.custom_field_values = {field.id => ['value3', 'value2']}
Chris@1494 1798 issue.save!
Chris@1494 1799 end
Chris@1494 1800 assert_difference 'JournalDetail.count', 2 do
Chris@1494 1801 issue.init_journal(User.first)
Chris@1494 1802 issue.custom_field_values = {field.id => nil}
Chris@1494 1803 issue.save!
Chris@1494 1804 end
Chris@1494 1805 end
Chris@1494 1806 end
Chris@1494 1807
Chris@1494 1808 def test_description_eol_should_be_normalized
Chris@1494 1809 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
Chris@1494 1810 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
Chris@1494 1811 end
Chris@1494 1812
Chris@1494 1813 def test_saving_twice_should_not_duplicate_journal_details
Chris@1494 1814 i = Issue.first
Chris@1494 1815 i.init_journal(User.find(2), 'Some notes')
Chris@1494 1816 # initial changes
Chris@1494 1817 i.subject = 'New subject'
Chris@1494 1818 i.done_ratio = i.done_ratio + 10
Chris@1494 1819 assert_difference 'Journal.count' do
Chris@1494 1820 assert i.save
Chris@1494 1821 end
Chris@1494 1822 # 1 more change
Chris@1494 1823 i.priority = IssuePriority.where("id <> ?", i.priority_id).first
Chris@1494 1824 assert_no_difference 'Journal.count' do
Chris@1494 1825 assert_difference 'JournalDetail.count', 1 do
Chris@1494 1826 i.save
Chris@1494 1827 end
Chris@1494 1828 end
Chris@1494 1829 # no more change
Chris@1494 1830 assert_no_difference 'Journal.count' do
Chris@1494 1831 assert_no_difference 'JournalDetail.count' do
Chris@1494 1832 i.save
Chris@1494 1833 end
Chris@1494 1834 end
Chris@1494 1835 end
Chris@1494 1836
Chris@1494 1837 def test_all_dependent_issues
Chris@1494 1838 IssueRelation.delete_all
Chris@1494 1839 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1494 1840 :issue_to => Issue.find(2),
Chris@1494 1841 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1842 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1494 1843 :issue_to => Issue.find(3),
Chris@1494 1844 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1845 assert IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1494 1846 :issue_to => Issue.find(8),
Chris@1494 1847 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1848
Chris@1494 1849 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1494 1850 end
Chris@1494 1851
Chris@1494 1852 def test_all_dependent_issues_with_subtask
Chris@1494 1853 IssueRelation.delete_all
Chris@1494 1854
Chris@1494 1855 project = Project.generate!(:name => "testproject")
Chris@1494 1856
Chris@1494 1857 parentIssue = Issue.generate!(:project => project)
Chris@1494 1858 childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1494 1859 childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1494 1860
Chris@1494 1861 assert_equal [childIssue1.id, childIssue2.id].sort, parentIssue.all_dependent_issues.collect(&:id).uniq.sort
Chris@1494 1862 end
Chris@1494 1863
Chris@1494 1864 def test_all_dependent_issues_does_not_include_self
Chris@1494 1865 IssueRelation.delete_all
Chris@1494 1866
Chris@1494 1867 project = Project.generate!(:name => "testproject")
Chris@1494 1868
Chris@1494 1869 parentIssue = Issue.generate!(:project => project)
Chris@1494 1870 childIssue = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1494 1871
Chris@1494 1872 assert_equal [childIssue.id], parentIssue.all_dependent_issues.collect(&:id)
Chris@1494 1873 end
Chris@1494 1874
Chris@1494 1875 def test_all_dependent_issues_with_parenttask_and_sibling
Chris@1494 1876 IssueRelation.delete_all
Chris@1494 1877
Chris@1494 1878 project = Project.generate!(:name => "testproject")
Chris@1494 1879
Chris@1494 1880 parentIssue = Issue.generate!(:project => project)
Chris@1494 1881 childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1494 1882 childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1494 1883
Chris@1494 1884 assert_equal [parentIssue.id].sort, childIssue1.all_dependent_issues.collect(&:id)
Chris@1494 1885 end
Chris@1494 1886
Chris@1494 1887 def test_all_dependent_issues_with_relation_to_leaf_in_other_tree
Chris@1494 1888 IssueRelation.delete_all
Chris@1494 1889
Chris@1494 1890 project = Project.generate!(:name => "testproject")
Chris@1494 1891
Chris@1494 1892 parentIssue1 = Issue.generate!(:project => project)
Chris@1494 1893 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1494 1894 childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1494 1895
Chris@1494 1896 parentIssue2 = Issue.generate!(:project => project)
Chris@1494 1897 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1494 1898 childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1494 1899
Chris@1494 1900
Chris@1494 1901 assert IssueRelation.create(:issue_from => parentIssue1,
Chris@1494 1902 :issue_to => childIssue2_2,
Chris@1494 1903 :relation_type => IssueRelation::TYPE_BLOCKS)
Chris@1494 1904
Chris@1494 1905 assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_2.id].sort,
Chris@1494 1906 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
Chris@1494 1907 end
Chris@1494 1908
Chris@1494 1909 def test_all_dependent_issues_with_relation_to_parent_in_other_tree
Chris@1494 1910 IssueRelation.delete_all
Chris@1494 1911
Chris@1494 1912 project = Project.generate!(:name => "testproject")
Chris@1494 1913
Chris@1494 1914 parentIssue1 = Issue.generate!(:project => project)
Chris@1494 1915 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1494 1916 childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1494 1917
Chris@1494 1918 parentIssue2 = Issue.generate!(:project => project)
Chris@1494 1919 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1494 1920 childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1494 1921
Chris@1494 1922
Chris@1494 1923 assert IssueRelation.create(:issue_from => parentIssue1,
Chris@1494 1924 :issue_to => parentIssue2,
Chris@1494 1925 :relation_type => IssueRelation::TYPE_BLOCKS)
Chris@1494 1926
Chris@1494 1927 assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_1.id, childIssue2_2.id].sort,
Chris@1494 1928 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
Chris@1494 1929 end
Chris@1494 1930
Chris@1494 1931 def test_all_dependent_issues_with_transitive_relation
Chris@1494 1932 IssueRelation.delete_all
Chris@1494 1933
Chris@1494 1934 project = Project.generate!(:name => "testproject")
Chris@1494 1935
Chris@1494 1936 parentIssue1 = Issue.generate!(:project => project)
Chris@1494 1937 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1494 1938
Chris@1494 1939 parentIssue2 = Issue.generate!(:project => project)
Chris@1494 1940 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1494 1941
Chris@1494 1942 independentIssue = Issue.generate!(:project => project)
Chris@1494 1943
Chris@1494 1944 assert IssueRelation.create(:issue_from => parentIssue1,
Chris@1494 1945 :issue_to => childIssue2_1,
Chris@1494 1946 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1494 1947
Chris@1494 1948 assert IssueRelation.create(:issue_from => childIssue2_1,
Chris@1494 1949 :issue_to => independentIssue,
Chris@1494 1950 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1494 1951
Chris@1494 1952 assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
Chris@1494 1953 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
Chris@1494 1954 end
Chris@1494 1955
Chris@1494 1956 def test_all_dependent_issues_with_transitive_relation2
Chris@1494 1957 IssueRelation.delete_all
Chris@1494 1958
Chris@1494 1959 project = Project.generate!(:name => "testproject")
Chris@1494 1960
Chris@1494 1961 parentIssue1 = Issue.generate!(:project => project)
Chris@1494 1962 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1494 1963
Chris@1494 1964 parentIssue2 = Issue.generate!(:project => project)
Chris@1494 1965 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1494 1966
Chris@1494 1967 independentIssue = Issue.generate!(:project => project)
Chris@1494 1968
Chris@1494 1969 assert IssueRelation.create(:issue_from => parentIssue1,
Chris@1494 1970 :issue_to => independentIssue,
Chris@1494 1971 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1494 1972
Chris@1494 1973 assert IssueRelation.create(:issue_from => independentIssue,
Chris@1494 1974 :issue_to => childIssue2_1,
Chris@1494 1975 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1494 1976
Chris@1494 1977 assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
Chris@1494 1978 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
Chris@1494 1979
Chris@1494 1980 end
Chris@1494 1981
Chris@1494 1982 def test_all_dependent_issues_with_persistent_circular_dependency
Chris@1494 1983 IssueRelation.delete_all
Chris@1494 1984 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1494 1985 :issue_to => Issue.find(2),
Chris@1494 1986 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1987 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1494 1988 :issue_to => Issue.find(3),
Chris@1494 1989 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1990
Chris@1494 1991 r = IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1494 1992 :issue_to => Issue.find(7),
Chris@1494 1993 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1494 1994 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
Chris@1494 1995
Chris@1494 1996 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1494 1997 end
Chris@1494 1998
Chris@1494 1999 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
Chris@1494 2000 IssueRelation.delete_all
Chris@1494 2001 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1494 2002 :issue_to => Issue.find(2),
Chris@1494 2003 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1494 2004 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1494 2005 :issue_to => Issue.find(3),
Chris@1494 2006 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1494 2007 assert IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1494 2008 :issue_to => Issue.find(8),
Chris@1494 2009 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1494 2010
Chris@1494 2011 r = IssueRelation.create!(:issue_from => Issue.find(8),
Chris@1494 2012 :issue_to => Issue.find(7),
Chris@1494 2013 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1494 2014 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
Chris@1494 2015
Chris@1494 2016 r = IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1494 2017 :issue_to => Issue.find(7),
Chris@1494 2018 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1494 2019 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
Chris@1494 2020
Chris@1494 2021 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1494 2022 end
Chris@1494 2023
Chris@1494 2024 test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
Chris@1494 2025 @issue = Issue.find(1)
Chris@1494 2026 @issue_status = IssueStatus.find(1)
Chris@1494 2027 @issue_status.update_attribute(:default_done_ratio, 50)
Chris@1494 2028 @issue2 = Issue.find(2)
Chris@1494 2029 @issue_status2 = IssueStatus.find(2)
Chris@1494 2030 @issue_status2.update_attribute(:default_done_ratio, 0)
Chris@1494 2031
Chris@1494 2032 with_settings :issue_done_ratio => 'issue_field' do
Chris@1494 2033 assert_equal 0, @issue.done_ratio
Chris@1494 2034 assert_equal 30, @issue2.done_ratio
Chris@1494 2035 end
Chris@1494 2036
Chris@1494 2037 with_settings :issue_done_ratio => 'issue_status' do
Chris@1494 2038 assert_equal 50, @issue.done_ratio
Chris@1494 2039 assert_equal 0, @issue2.done_ratio
Chris@1494 2040 end
Chris@1494 2041 end
Chris@1494 2042
Chris@1494 2043 test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
Chris@1494 2044 @issue = Issue.find(1)
Chris@1494 2045 @issue_status = IssueStatus.find(1)
Chris@1494 2046 @issue_status.update_attribute(:default_done_ratio, 50)
Chris@1494 2047 @issue2 = Issue.find(2)
Chris@1494 2048 @issue_status2 = IssueStatus.find(2)
Chris@1494 2049 @issue_status2.update_attribute(:default_done_ratio, 0)
Chris@1494 2050
Chris@1494 2051 with_settings :issue_done_ratio => 'issue_field' do
Chris@1494 2052 @issue.update_done_ratio_from_issue_status
Chris@1494 2053 @issue2.update_done_ratio_from_issue_status
Chris@1494 2054
Chris@1494 2055 assert_equal 0, @issue.read_attribute(:done_ratio)
Chris@1494 2056 assert_equal 30, @issue2.read_attribute(:done_ratio)
Chris@1494 2057 end
Chris@1494 2058
Chris@1494 2059 with_settings :issue_done_ratio => 'issue_status' do
Chris@1494 2060 @issue.update_done_ratio_from_issue_status
Chris@1494 2061 @issue2.update_done_ratio_from_issue_status
Chris@1494 2062
Chris@1494 2063 assert_equal 50, @issue.read_attribute(:done_ratio)
Chris@1494 2064 assert_equal 0, @issue2.read_attribute(:done_ratio)
Chris@1494 2065 end
Chris@1494 2066 end
Chris@1494 2067
Chris@1494 2068 test "#by_tracker" do
Chris@1494 2069 User.current = User.anonymous
Chris@1494 2070 groups = Issue.by_tracker(Project.find(1))
Chris@1494 2071 assert_equal 3, groups.count
Chris@1494 2072 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1494 2073 end
Chris@1494 2074
Chris@1494 2075 test "#by_version" do
Chris@1494 2076 User.current = User.anonymous
Chris@1494 2077 groups = Issue.by_version(Project.find(1))
Chris@1494 2078 assert_equal 3, groups.count
Chris@1494 2079 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1494 2080 end
Chris@1494 2081
Chris@1494 2082 test "#by_priority" do
Chris@1494 2083 User.current = User.anonymous
Chris@1494 2084 groups = Issue.by_priority(Project.find(1))
Chris@1494 2085 assert_equal 4, groups.count
Chris@1494 2086 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1494 2087 end
Chris@1494 2088
Chris@1494 2089 test "#by_category" do
Chris@1494 2090 User.current = User.anonymous
Chris@1494 2091 groups = Issue.by_category(Project.find(1))
Chris@1494 2092 assert_equal 2, groups.count
Chris@1494 2093 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1494 2094 end
Chris@1494 2095
Chris@1494 2096 test "#by_assigned_to" do
Chris@1494 2097 User.current = User.anonymous
Chris@1494 2098 groups = Issue.by_assigned_to(Project.find(1))
Chris@1494 2099 assert_equal 2, groups.count
Chris@1494 2100 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1494 2101 end
Chris@1494 2102
Chris@1494 2103 test "#by_author" do
Chris@1494 2104 User.current = User.anonymous
Chris@1494 2105 groups = Issue.by_author(Project.find(1))
Chris@1494 2106 assert_equal 4, groups.count
Chris@1494 2107 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1494 2108 end
Chris@1494 2109
Chris@1494 2110 test "#by_subproject" do
Chris@1494 2111 User.current = User.anonymous
Chris@1494 2112 groups = Issue.by_subproject(Project.find(1))
Chris@1494 2113 # Private descendant not visible
Chris@1494 2114 assert_equal 1, groups.count
Chris@1494 2115 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1494 2116 end
Chris@1494 2117
Chris@1494 2118 def test_recently_updated_scope
Chris@1494 2119 #should return the last updated issue
Chris@1494 2120 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
Chris@1494 2121 end
Chris@1494 2122
Chris@1494 2123 def test_on_active_projects_scope
Chris@1494 2124 assert Project.find(2).archive
Chris@1494 2125
Chris@1494 2126 before = Issue.on_active_project.length
Chris@1494 2127 # test inclusion to results
Chris@1494 2128 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
Chris@1494 2129 assert_equal before + 1, Issue.on_active_project.length
Chris@1494 2130
Chris@1494 2131 # Move to an archived project
Chris@1494 2132 issue.project = Project.find(2)
Chris@1494 2133 assert issue.save
Chris@1494 2134 assert_equal before, Issue.on_active_project.length
Chris@1494 2135 end
Chris@1494 2136
Chris@1494 2137 test "Issue#recipients should include project recipients" do
Chris@1494 2138 issue = Issue.generate!
Chris@1494 2139 assert issue.project.recipients.present?
Chris@1494 2140 issue.project.recipients.each do |project_recipient|
Chris@1494 2141 assert issue.recipients.include?(project_recipient)
Chris@1494 2142 end
Chris@1494 2143 end
Chris@1494 2144
Chris@1494 2145 test "Issue#recipients should include the author if the author is active" do
Chris@1494 2146 issue = Issue.generate!(:author => User.generate!)
Chris@1494 2147 assert issue.author, "No author set for Issue"
Chris@1494 2148 assert issue.recipients.include?(issue.author.mail)
Chris@1494 2149 end
Chris@1494 2150
Chris@1494 2151 test "Issue#recipients should include the assigned to user if the assigned to user is active" do
Chris@1494 2152 issue = Issue.generate!(:assigned_to => User.generate!)
Chris@1494 2153 assert issue.assigned_to, "No assigned_to set for Issue"
Chris@1494 2154 assert issue.recipients.include?(issue.assigned_to.mail)
Chris@1494 2155 end
Chris@1494 2156
Chris@1494 2157 test "Issue#recipients should not include users who opt out of all email" do
Chris@1494 2158 issue = Issue.generate!(:author => User.generate!)
Chris@1494 2159 issue.author.update_attribute(:mail_notification, :none)
Chris@1494 2160 assert !issue.recipients.include?(issue.author.mail)
Chris@1494 2161 end
Chris@1494 2162
Chris@1494 2163 test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
Chris@1494 2164 issue = Issue.generate!(:author => User.generate!)
Chris@1494 2165 issue.author.update_attribute(:mail_notification, :only_assigned)
Chris@1494 2166 assert !issue.recipients.include?(issue.author.mail)
Chris@1494 2167 end
Chris@1494 2168
Chris@1494 2169 test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
Chris@1494 2170 issue = Issue.generate!(:assigned_to => User.generate!)
Chris@1494 2171 issue.assigned_to.update_attribute(:mail_notification, :only_owner)
Chris@1494 2172 assert !issue.recipients.include?(issue.assigned_to.mail)
Chris@1494 2173 end
Chris@1494 2174
Chris@1494 2175 def test_last_journal_id_with_journals_should_return_the_journal_id
Chris@1494 2176 assert_equal 2, Issue.find(1).last_journal_id
Chris@1494 2177 end
Chris@1494 2178
Chris@1494 2179 def test_last_journal_id_without_journals_should_return_nil
Chris@1494 2180 assert_nil Issue.find(3).last_journal_id
Chris@1494 2181 end
Chris@1494 2182
Chris@1494 2183 def test_journals_after_should_return_journals_with_greater_id
Chris@1494 2184 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
Chris@1494 2185 assert_equal [], Issue.find(1).journals_after('2')
Chris@1494 2186 end
Chris@1494 2187
Chris@1494 2188 def test_journals_after_with_blank_arg_should_return_all_journals
Chris@1494 2189 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
Chris@1494 2190 end
Chris@1494 2191
Chris@1494 2192 def test_css_classes_should_include_tracker
Chris@1494 2193 issue = Issue.new(:tracker => Tracker.find(2))
Chris@1494 2194 classes = issue.css_classes.split(' ')
Chris@1494 2195 assert_include 'tracker-2', classes
Chris@1494 2196 end
Chris@1494 2197
Chris@1494 2198 def test_css_classes_should_include_priority
Chris@1494 2199 issue = Issue.new(:priority => IssuePriority.find(8))
Chris@1494 2200 classes = issue.css_classes.split(' ')
Chris@1494 2201 assert_include 'priority-8', classes
Chris@1494 2202 assert_include 'priority-highest', classes
Chris@1494 2203 end
Chris@1494 2204
Chris@1494 2205 def test_css_classes_should_include_user_and_group_assignment
Chris@1494 2206 project = Project.first
Chris@1494 2207 user = User.generate!
Chris@1494 2208 group = Group.generate!
Chris@1494 2209 Member.create!(:principal => group, :project => project, :role_ids => [1, 2])
Chris@1494 2210 group.users << user
Chris@1494 2211 assert user.member_of?(project)
Chris@1494 2212 issue1 = Issue.generate(:assigned_to_id => group.id)
Chris@1494 2213 assert_include 'assigned-to-my-group', issue1.css_classes(user)
Chris@1494 2214 assert_not_include 'assigned-to-me', issue1.css_classes(user)
Chris@1494 2215 issue2 = Issue.generate(:assigned_to_id => user.id)
Chris@1494 2216 assert_not_include 'assigned-to-my-group', issue2.css_classes(user)
Chris@1494 2217 assert_include 'assigned-to-me', issue2.css_classes(user)
Chris@1494 2218 end
Chris@1494 2219
Chris@1494 2220 def test_save_attachments_with_hash_should_save_attachments_in_keys_order
Chris@1494 2221 set_tmp_attachments_directory
Chris@1494 2222 issue = Issue.generate!
Chris@1494 2223 issue.save_attachments({
Chris@1494 2224 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
Chris@1494 2225 '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
Chris@1494 2226 '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
Chris@1494 2227 })
Chris@1494 2228 issue.attach_saved_attachments
Chris@1494 2229
Chris@1494 2230 assert_equal 3, issue.reload.attachments.count
Chris@1494 2231 assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
Chris@1494 2232 end
Chris@1494 2233
Chris@1494 2234 def test_closed_on_should_be_nil_when_creating_an_open_issue
Chris@1494 2235 issue = Issue.generate!(:status_id => 1).reload
Chris@1494 2236 assert !issue.closed?
Chris@1494 2237 assert_nil issue.closed_on
Chris@1494 2238 end
Chris@1494 2239
Chris@1494 2240 def test_closed_on_should_be_set_when_creating_a_closed_issue
Chris@1494 2241 issue = Issue.generate!(:status_id => 5).reload
Chris@1494 2242 assert issue.closed?
Chris@1494 2243 assert_not_nil issue.closed_on
Chris@1494 2244 assert_equal issue.updated_on, issue.closed_on
Chris@1494 2245 assert_equal issue.created_on, issue.closed_on
Chris@1494 2246 end
Chris@1494 2247
Chris@1494 2248 def test_closed_on_should_be_nil_when_updating_an_open_issue
Chris@1494 2249 issue = Issue.find(1)
Chris@1494 2250 issue.subject = 'Not closed yet'
Chris@1494 2251 issue.save!
Chris@1494 2252 issue.reload
Chris@1494 2253 assert_nil issue.closed_on
Chris@1494 2254 end
Chris@1494 2255
Chris@1494 2256 def test_closed_on_should_be_set_when_closing_an_open_issue
Chris@1494 2257 issue = Issue.find(1)
Chris@1494 2258 issue.subject = 'Now closed'
Chris@1494 2259 issue.status_id = 5
Chris@1494 2260 issue.save!
Chris@1494 2261 issue.reload
Chris@1494 2262 assert_not_nil issue.closed_on
Chris@1494 2263 assert_equal issue.updated_on, issue.closed_on
Chris@1494 2264 end
Chris@1494 2265
Chris@1494 2266 def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
Chris@1494 2267 issue = Issue.open(false).first
Chris@1494 2268 was_closed_on = issue.closed_on
Chris@1494 2269 assert_not_nil was_closed_on
Chris@1494 2270 issue.subject = 'Updating a closed issue'
Chris@1494 2271 issue.save!
Chris@1494 2272 issue.reload
Chris@1494 2273 assert_equal was_closed_on, issue.closed_on
Chris@1494 2274 end
Chris@1494 2275
Chris@1494 2276 def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
Chris@1494 2277 issue = Issue.open(false).first
Chris@1494 2278 was_closed_on = issue.closed_on
Chris@1494 2279 assert_not_nil was_closed_on
Chris@1494 2280 issue.subject = 'Reopening a closed issue'
Chris@1494 2281 issue.status_id = 1
Chris@1494 2282 issue.save!
Chris@1494 2283 issue.reload
Chris@1494 2284 assert !issue.closed?
Chris@1494 2285 assert_equal was_closed_on, issue.closed_on
Chris@1494 2286 end
Chris@1494 2287
Chris@1494 2288 def test_status_was_should_return_nil_for_new_issue
Chris@1494 2289 issue = Issue.new
Chris@1494 2290 assert_nil issue.status_was
Chris@1494 2291 end
Chris@1494 2292
Chris@1494 2293 def test_status_was_should_return_status_before_change
Chris@1494 2294 issue = Issue.find(1)
Chris@1494 2295 issue.status = IssueStatus.find(2)
Chris@1494 2296 assert_equal IssueStatus.find(1), issue.status_was
Chris@1494 2297 end
Chris@1494 2298
Chris@1494 2299 def test_status_was_should_be_reset_on_save
Chris@1494 2300 issue = Issue.find(1)
Chris@1494 2301 issue.status = IssueStatus.find(2)
Chris@1494 2302 assert_equal IssueStatus.find(1), issue.status_was
Chris@1494 2303 assert issue.save!
Chris@1494 2304 assert_equal IssueStatus.find(2), issue.status_was
Chris@1494 2305 end
Chris@1494 2306 end