annotate .svn/pristine/8b/8b34b320f3a3448ad5019fb625383697dc8a3c95.svn-base @ 1519:afce8026aaeb redmine-2.4-integration

Merge from branch "live"
author Chris Cannam
date Tue, 09 Sep 2014 09:34:53 +0100
parents cbb26bc654de
children
rev   line source
Chris@909 1 # Redmine - project management software
Chris@909 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
Chris@909 3 #
Chris@909 4 # This program is free software; you can redistribute it and/or
Chris@909 5 # modify it under the terms of the GNU General Public License
Chris@909 6 # as published by the Free Software Foundation; either version 2
Chris@909 7 # of the License, or (at your option) any later version.
Chris@909 8 #
Chris@909 9 # This program is distributed in the hope that it will be useful,
Chris@909 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@909 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@909 12 # GNU General Public License for more details.
Chris@909 13 #
Chris@909 14 # You should have received a copy of the GNU General Public License
Chris@909 15 # along with this program; if not, write to the Free Software
Chris@909 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@909 17
Chris@909 18 require File.expand_path('../../test_helper', __FILE__)
Chris@909 19
Chris@909 20 class IssueNestedSetTest < ActiveSupport::TestCase
Chris@909 21 fixtures :projects, :users, :members, :member_roles, :roles,
Chris@909 22 :trackers, :projects_trackers,
Chris@909 23 :versions,
Chris@909 24 :issue_statuses, :issue_categories, :issue_relations, :workflows,
Chris@909 25 :enumerations,
Chris@909 26 :issues,
Chris@909 27 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
Chris@909 28 :time_entries
Chris@909 29
Chris@909 30 self.use_transactional_fixtures = false
Chris@909 31
Chris@909 32 def test_create_root_issue
Chris@909 33 issue1 = create_issue!
Chris@909 34 issue2 = create_issue!
Chris@909 35 issue1.reload
Chris@909 36 issue2.reload
Chris@909 37
Chris@909 38 assert_equal [issue1.id, nil, 1, 2], [issue1.root_id, issue1.parent_id, issue1.lft, issue1.rgt]
Chris@909 39 assert_equal [issue2.id, nil, 1, 2], [issue2.root_id, issue2.parent_id, issue2.lft, issue2.rgt]
Chris@909 40 end
Chris@909 41
Chris@909 42 def test_create_child_issue
Chris@909 43 parent = create_issue!
Chris@909 44 child = create_issue!(:parent_issue_id => parent.id)
Chris@909 45 parent.reload
Chris@909 46 child.reload
Chris@909 47
Chris@909 48 assert_equal [parent.id, nil, 1, 4], [parent.root_id, parent.parent_id, parent.lft, parent.rgt]
Chris@909 49 assert_equal [parent.id, parent.id, 2, 3], [child.root_id, child.parent_id, child.lft, child.rgt]
Chris@909 50 end
Chris@909 51
Chris@909 52 def test_creating_a_child_in_different_project_should_not_validate
Chris@909 53 issue = create_issue!
Chris@909 54 child = Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
Chris@909 55 :subject => 'child', :parent_issue_id => issue.id)
Chris@909 56 assert !child.save
Chris@909 57 assert_not_nil child.errors[:parent_issue_id]
Chris@909 58 end
Chris@909 59
Chris@909 60 def test_move_a_root_to_child
Chris@909 61 parent1 = create_issue!
Chris@909 62 parent2 = create_issue!
Chris@909 63 child = create_issue!(:parent_issue_id => parent1.id)
Chris@909 64
Chris@909 65 parent2.parent_issue_id = parent1.id
Chris@909 66 parent2.save!
Chris@909 67 child.reload
Chris@909 68 parent1.reload
Chris@909 69 parent2.reload
Chris@909 70
Chris@909 71 assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
Chris@909 72 assert_equal [parent1.id, 4, 5], [parent2.root_id, parent2.lft, parent2.rgt]
Chris@909 73 assert_equal [parent1.id, 2, 3], [child.root_id, child.lft, child.rgt]
Chris@909 74 end
Chris@909 75
Chris@909 76 def test_move_a_child_to_root
Chris@909 77 parent1 = create_issue!
Chris@909 78 parent2 = create_issue!
Chris@909 79 child = create_issue!(:parent_issue_id => parent1.id)
Chris@909 80
Chris@909 81 child.parent_issue_id = nil
Chris@909 82 child.save!
Chris@909 83 child.reload
Chris@909 84 parent1.reload
Chris@909 85 parent2.reload
Chris@909 86
Chris@909 87 assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
Chris@909 88 assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
Chris@909 89 assert_equal [child.id, 1, 2], [child.root_id, child.lft, child.rgt]
Chris@909 90 end
Chris@909 91
Chris@909 92 def test_move_a_child_to_another_issue
Chris@909 93 parent1 = create_issue!
Chris@909 94 parent2 = create_issue!
Chris@909 95 child = create_issue!(:parent_issue_id => parent1.id)
Chris@909 96
Chris@909 97 child.parent_issue_id = parent2.id
Chris@909 98 child.save!
Chris@909 99 child.reload
Chris@909 100 parent1.reload
Chris@909 101 parent2.reload
Chris@909 102
Chris@909 103 assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
Chris@909 104 assert_equal [parent2.id, 1, 4], [parent2.root_id, parent2.lft, parent2.rgt]
Chris@909 105 assert_equal [parent2.id, 2, 3], [child.root_id, child.lft, child.rgt]
Chris@909 106 end
Chris@909 107
Chris@909 108 def test_move_a_child_with_descendants_to_another_issue
Chris@909 109 parent1 = create_issue!
Chris@909 110 parent2 = create_issue!
Chris@909 111 child = create_issue!(:parent_issue_id => parent1.id)
Chris@909 112 grandchild = create_issue!(:parent_issue_id => child.id)
Chris@909 113
Chris@909 114 parent1.reload
Chris@909 115 parent2.reload
Chris@909 116 child.reload
Chris@909 117 grandchild.reload
Chris@909 118
Chris@909 119 assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
Chris@909 120 assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
Chris@909 121 assert_equal [parent1.id, 2, 5], [child.root_id, child.lft, child.rgt]
Chris@909 122 assert_equal [parent1.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
Chris@909 123
Chris@909 124 child.reload.parent_issue_id = parent2.id
Chris@909 125 child.save!
Chris@909 126 child.reload
Chris@909 127 grandchild.reload
Chris@909 128 parent1.reload
Chris@909 129 parent2.reload
Chris@909 130
Chris@909 131 assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
Chris@909 132 assert_equal [parent2.id, 1, 6], [parent2.root_id, parent2.lft, parent2.rgt]
Chris@909 133 assert_equal [parent2.id, 2, 5], [child.root_id, child.lft, child.rgt]
Chris@909 134 assert_equal [parent2.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
Chris@909 135 end
Chris@909 136
Chris@909 137 def test_move_a_child_with_descendants_to_another_project
Chris@909 138 parent1 = create_issue!
Chris@909 139 child = create_issue!(:parent_issue_id => parent1.id)
Chris@909 140 grandchild = create_issue!(:parent_issue_id => child.id)
Chris@909 141
Chris@909 142 assert child.reload.move_to_project(Project.find(2))
Chris@909 143 child.reload
Chris@909 144 grandchild.reload
Chris@909 145 parent1.reload
Chris@909 146
Chris@909 147 assert_equal [1, parent1.id, 1, 2], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
Chris@909 148 assert_equal [2, child.id, 1, 4], [child.project_id, child.root_id, child.lft, child.rgt]
Chris@909 149 assert_equal [2, child.id, 2, 3], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
Chris@909 150 end
Chris@909 151
Chris@909 152 def test_invalid_move_to_another_project
Chris@909 153 parent1 = create_issue!
Chris@909 154 child = create_issue!(:parent_issue_id => parent1.id)
Chris@909 155 grandchild = create_issue!(:parent_issue_id => child.id, :tracker_id => 2)
Chris@909 156 Project.find(2).tracker_ids = [1]
Chris@909 157
Chris@909 158 parent1.reload
Chris@909 159 assert_equal [1, parent1.id, 1, 6], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
Chris@909 160
Chris@909 161 # child can not be moved to Project 2 because its child is on a disabled tracker
Chris@909 162 assert_equal false, Issue.find(child.id).move_to_project(Project.find(2))
Chris@909 163 child.reload
Chris@909 164 grandchild.reload
Chris@909 165 parent1.reload
Chris@909 166
Chris@909 167 # no change
Chris@909 168 assert_equal [1, parent1.id, 1, 6], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
Chris@909 169 assert_equal [1, parent1.id, 2, 5], [child.project_id, child.root_id, child.lft, child.rgt]
Chris@909 170 assert_equal [1, parent1.id, 3, 4], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
Chris@909 171 end
Chris@909 172
Chris@909 173 def test_moving_an_issue_to_a_descendant_should_not_validate
Chris@909 174 parent1 = create_issue!
Chris@909 175 parent2 = create_issue!
Chris@909 176 child = create_issue!(:parent_issue_id => parent1.id)
Chris@909 177 grandchild = create_issue!(:parent_issue_id => child.id)
Chris@909 178
Chris@909 179 child.reload
Chris@909 180 child.parent_issue_id = grandchild.id
Chris@909 181 assert !child.save
Chris@909 182 assert_not_nil child.errors[:parent_issue_id]
Chris@909 183 end
Chris@909 184
Chris@909 185 def test_moving_an_issue_should_keep_valid_relations_only
Chris@909 186 issue1 = create_issue!
Chris@909 187 issue2 = create_issue!
Chris@909 188 issue3 = create_issue!(:parent_issue_id => issue2.id)
Chris@909 189 issue4 = create_issue!
Chris@909 190 r1 = IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@909 191 r2 = IssueRelation.create!(:issue_from => issue1, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@909 192 r3 = IssueRelation.create!(:issue_from => issue2, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@909 193 issue2.reload
Chris@909 194 issue2.parent_issue_id = issue1.id
Chris@909 195 issue2.save!
Chris@909 196 assert !IssueRelation.exists?(r1.id)
Chris@909 197 assert !IssueRelation.exists?(r2.id)
Chris@909 198 assert IssueRelation.exists?(r3.id)
Chris@909 199 end
Chris@909 200
Chris@909 201 def test_destroy_should_destroy_children
Chris@909 202 issue1 = create_issue!
Chris@909 203 issue2 = create_issue!
Chris@909 204 issue3 = create_issue!(:parent_issue_id => issue2.id)
Chris@909 205 issue4 = create_issue!(:parent_issue_id => issue1.id)
Chris@909 206
Chris@909 207 issue3.init_journal(User.find(2))
Chris@909 208 issue3.subject = 'child with journal'
Chris@909 209 issue3.save!
Chris@909 210
Chris@909 211 assert_difference 'Issue.count', -2 do
Chris@909 212 assert_difference 'Journal.count', -1 do
Chris@909 213 assert_difference 'JournalDetail.count', -1 do
Chris@909 214 Issue.find(issue2.id).destroy
Chris@909 215 end
Chris@909 216 end
Chris@909 217 end
Chris@909 218
Chris@909 219 issue1.reload
Chris@909 220 issue4.reload
Chris@909 221 assert !Issue.exists?(issue2.id)
Chris@909 222 assert !Issue.exists?(issue3.id)
Chris@909 223 assert_equal [issue1.id, 1, 4], [issue1.root_id, issue1.lft, issue1.rgt]
Chris@909 224 assert_equal [issue1.id, 2, 3], [issue4.root_id, issue4.lft, issue4.rgt]
Chris@909 225 end
Chris@909 226
Chris@909 227 def test_destroy_child_should_update_parent
Chris@909 228 issue = create_issue!
Chris@909 229 child1 = create_issue!(:parent_issue_id => issue.id)
Chris@909 230 child2 = create_issue!(:parent_issue_id => issue.id)
Chris@909 231
Chris@909 232 issue.reload
Chris@909 233 assert_equal [issue.id, 1, 6], [issue.root_id, issue.lft, issue.rgt]
Chris@909 234
Chris@909 235 child2.reload.destroy
Chris@909 236
Chris@909 237 issue.reload
Chris@909 238 assert_equal [issue.id, 1, 4], [issue.root_id, issue.lft, issue.rgt]
Chris@909 239 end
Chris@909 240
Chris@909 241 def test_destroy_parent_issue_updated_during_children_destroy
Chris@909 242 parent = create_issue!
Chris@909 243 create_issue!(:start_date => Date.today, :parent_issue_id => parent.id)
Chris@909 244 create_issue!(:start_date => 2.days.from_now, :parent_issue_id => parent.id)
Chris@909 245
Chris@909 246 assert_difference 'Issue.count', -3 do
Chris@909 247 Issue.find(parent.id).destroy
Chris@909 248 end
Chris@909 249 end
Chris@909 250
Chris@909 251 def test_destroy_child_issue_with_children
Chris@909 252 root = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'root')
Chris@909 253 child = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => root.id)
Chris@909 254 leaf = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'leaf', :parent_issue_id => child.id)
Chris@909 255 leaf.init_journal(User.find(2))
Chris@909 256 leaf.subject = 'leaf with journal'
Chris@909 257 leaf.save!
Chris@909 258
Chris@909 259 assert_difference 'Issue.count', -2 do
Chris@909 260 assert_difference 'Journal.count', -1 do
Chris@909 261 assert_difference 'JournalDetail.count', -1 do
Chris@909 262 Issue.find(child.id).destroy
Chris@909 263 end
Chris@909 264 end
Chris@909 265 end
Chris@909 266
Chris@909 267 root = Issue.find(root.id)
Chris@909 268 assert root.leaf?, "Root issue is not a leaf (lft: #{root.lft}, rgt: #{root.rgt})"
Chris@909 269 end
Chris@909 270
Chris@909 271 def test_destroy_issue_with_grand_child
Chris@909 272 parent = create_issue!
Chris@909 273 issue = create_issue!(:parent_issue_id => parent.id)
Chris@909 274 child = create_issue!(:parent_issue_id => issue.id)
Chris@909 275 grandchild1 = create_issue!(:parent_issue_id => child.id)
Chris@909 276 grandchild2 = create_issue!(:parent_issue_id => child.id)
Chris@909 277
Chris@909 278 assert_difference 'Issue.count', -4 do
Chris@909 279 Issue.find(issue.id).destroy
Chris@909 280 parent.reload
Chris@909 281 assert_equal [1, 2], [parent.lft, parent.rgt]
Chris@909 282 end
Chris@909 283 end
Chris@909 284
Chris@909 285 def test_parent_priority_should_be_the_highest_child_priority
Chris@909 286 parent = create_issue!(:priority => IssuePriority.find_by_name('Normal'))
Chris@909 287 # Create children
Chris@909 288 child1 = create_issue!(:priority => IssuePriority.find_by_name('High'), :parent_issue_id => parent.id)
Chris@909 289 assert_equal 'High', parent.reload.priority.name
Chris@909 290 child2 = create_issue!(:priority => IssuePriority.find_by_name('Immediate'), :parent_issue_id => child1.id)
Chris@909 291 assert_equal 'Immediate', child1.reload.priority.name
Chris@909 292 assert_equal 'Immediate', parent.reload.priority.name
Chris@909 293 child3 = create_issue!(:priority => IssuePriority.find_by_name('Low'), :parent_issue_id => parent.id)
Chris@909 294 assert_equal 'Immediate', parent.reload.priority.name
Chris@909 295 # Destroy a child
Chris@909 296 child1.destroy
Chris@909 297 assert_equal 'Low', parent.reload.priority.name
Chris@909 298 # Update a child
Chris@909 299 child3.reload.priority = IssuePriority.find_by_name('Normal')
Chris@909 300 child3.save!
Chris@909 301 assert_equal 'Normal', parent.reload.priority.name
Chris@909 302 end
Chris@909 303
Chris@909 304 def test_parent_dates_should_be_lowest_start_and_highest_due_dates
Chris@909 305 parent = create_issue!
Chris@909 306 create_issue!(:start_date => '2010-01-25', :due_date => '2010-02-15', :parent_issue_id => parent.id)
Chris@909 307 create_issue!( :due_date => '2010-02-13', :parent_issue_id => parent.id)
Chris@909 308 create_issue!(:start_date => '2010-02-01', :due_date => '2010-02-22', :parent_issue_id => parent.id)
Chris@909 309 parent.reload
Chris@909 310 assert_equal Date.parse('2010-01-25'), parent.start_date
Chris@909 311 assert_equal Date.parse('2010-02-22'), parent.due_date
Chris@909 312 end
Chris@909 313
Chris@909 314 def test_parent_done_ratio_should_be_average_done_ratio_of_leaves
Chris@909 315 parent = create_issue!
Chris@909 316 create_issue!(:done_ratio => 20, :parent_issue_id => parent.id)
Chris@909 317 assert_equal 20, parent.reload.done_ratio
Chris@909 318 create_issue!(:done_ratio => 70, :parent_issue_id => parent.id)
Chris@909 319 assert_equal 45, parent.reload.done_ratio
Chris@909 320
Chris@909 321 child = create_issue!(:done_ratio => 0, :parent_issue_id => parent.id)
Chris@909 322 assert_equal 30, parent.reload.done_ratio
Chris@909 323
Chris@909 324 create_issue!(:done_ratio => 30, :parent_issue_id => child.id)
Chris@909 325 assert_equal 30, child.reload.done_ratio
Chris@909 326 assert_equal 40, parent.reload.done_ratio
Chris@909 327 end
Chris@909 328
Chris@909 329 def test_parent_done_ratio_should_be_weighted_by_estimated_times_if_any
Chris@909 330 parent = create_issue!
Chris@909 331 create_issue!(:estimated_hours => 10, :done_ratio => 20, :parent_issue_id => parent.id)
Chris@909 332 assert_equal 20, parent.reload.done_ratio
Chris@909 333 create_issue!(:estimated_hours => 20, :done_ratio => 50, :parent_issue_id => parent.id)
Chris@909 334 assert_equal (50 * 20 + 20 * 10) / 30, parent.reload.done_ratio
Chris@909 335 end
Chris@909 336
Chris@909 337 def test_parent_estimate_should_be_sum_of_leaves
Chris@909 338 parent = create_issue!
Chris@909 339 create_issue!(:estimated_hours => nil, :parent_issue_id => parent.id)
Chris@909 340 assert_equal nil, parent.reload.estimated_hours
Chris@909 341 create_issue!(:estimated_hours => 5, :parent_issue_id => parent.id)
Chris@909 342 assert_equal 5, parent.reload.estimated_hours
Chris@909 343 create_issue!(:estimated_hours => 7, :parent_issue_id => parent.id)
Chris@909 344 assert_equal 12, parent.reload.estimated_hours
Chris@909 345 end
Chris@909 346
Chris@909 347 def test_move_parent_updates_old_parent_attributes
Chris@909 348 first_parent = create_issue!
Chris@909 349 second_parent = create_issue!
Chris@909 350 child = create_issue!(:estimated_hours => 5, :parent_issue_id => first_parent.id)
Chris@909 351 assert_equal 5, first_parent.reload.estimated_hours
Chris@909 352 child.update_attributes(:estimated_hours => 7, :parent_issue_id => second_parent.id)
Chris@909 353 assert_equal 7, second_parent.reload.estimated_hours
Chris@909 354 assert_nil first_parent.reload.estimated_hours
Chris@909 355 end
Chris@909 356
Chris@909 357 def test_reschuling_a_parent_should_reschedule_subtasks
Chris@909 358 parent = create_issue!
Chris@909 359 c1 = create_issue!(:start_date => '2010-05-12', :due_date => '2010-05-18', :parent_issue_id => parent.id)
Chris@909 360 c2 = create_issue!(:start_date => '2010-06-03', :due_date => '2010-06-10', :parent_issue_id => parent.id)
Chris@909 361 parent.reload
Chris@909 362 parent.reschedule_after(Date.parse('2010-06-02'))
Chris@909 363 c1.reload
Chris@909 364 assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-08')], [c1.start_date, c1.due_date]
Chris@909 365 c2.reload
Chris@909 366 assert_equal [Date.parse('2010-06-03'), Date.parse('2010-06-10')], [c2.start_date, c2.due_date] # no change
Chris@909 367 parent.reload
Chris@909 368 assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-10')], [parent.start_date, parent.due_date]
Chris@909 369 end
Chris@909 370
Chris@909 371 def test_project_copy_should_copy_issue_tree
Chris@909 372 p = Project.create!(:name => 'Tree copy', :identifier => 'tree-copy', :tracker_ids => [1, 2])
Chris@909 373 i1 = create_issue!(:project_id => p.id, :subject => 'i1')
Chris@909 374 i2 = create_issue!(:project_id => p.id, :subject => 'i2', :parent_issue_id => i1.id)
Chris@909 375 i3 = create_issue!(:project_id => p.id, :subject => 'i3', :parent_issue_id => i1.id)
Chris@909 376 i4 = create_issue!(:project_id => p.id, :subject => 'i4', :parent_issue_id => i2.id)
Chris@909 377 i5 = create_issue!(:project_id => p.id, :subject => 'i5')
Chris@909 378 c = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1, 2])
Chris@909 379 c.copy(p, :only => 'issues')
Chris@909 380 c.reload
Chris@909 381
Chris@909 382 assert_equal 5, c.issues.count
Chris@909 383 ic1, ic2, ic3, ic4, ic5 = c.issues.find(:all, :order => 'subject')
Chris@909 384 assert ic1.root?
Chris@909 385 assert_equal ic1, ic2.parent
Chris@909 386 assert_equal ic1, ic3.parent
Chris@909 387 assert_equal ic2, ic4.parent
Chris@909 388 assert ic5.root?
Chris@909 389 end
Chris@909 390
Chris@909 391 # Helper that creates an issue with default attributes
Chris@909 392 def create_issue!(attributes={})
Chris@909 393 Issue.create!({:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'test'}.merge(attributes))
Chris@909 394 end
Chris@909 395 end