annotate app/controllers/issues_controller.rb @ 1296:038ba2d95de8 redmine-2.2

Fix redmine-2.2 branch update (add missing svn files)
author Chris Cannam
date Fri, 14 Jun 2013 09:05:06 +0100
parents 433d4f72a19b
children bb32da3bea34 622f24f53b42 261b3d9a4903
rev   line source
Chris@0 1 # Redmine - project management software
Chris@1115 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
Chris@0 3 #
Chris@0 4 # This program is free software; you can redistribute it and/or
Chris@0 5 # modify it under the terms of the GNU General Public License
Chris@0 6 # as published by the Free Software Foundation; either version 2
Chris@0 7 # of the License, or (at your option) any later version.
Chris@441 8 #
Chris@0 9 # This program is distributed in the hope that it will be useful,
Chris@0 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@0 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@0 12 # GNU General Public License for more details.
Chris@441 13 #
Chris@0 14 # You should have received a copy of the GNU General Public License
Chris@0 15 # along with this program; if not, write to the Free Software
Chris@0 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@0 17
Chris@0 18 class IssuesController < ApplicationController
Chris@0 19 menu_item :new_issue, :only => [:new, :create]
Chris@0 20 default_search_scope :issues
Chris@441 21
Chris@14 22 before_filter :find_issue, :only => [:show, :edit, :update]
Chris@1115 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :destroy]
Chris@14 24 before_filter :find_project, :only => [:new, :create]
Chris@14 25 before_filter :authorize, :except => [:index]
Chris@14 26 before_filter :find_optional_project, :only => [:index]
Chris@0 27 before_filter :check_for_default_issue_status, :only => [:new, :create]
Chris@0 28 before_filter :build_new_issue_from_params, :only => [:new, :create]
Chris@507 29 accept_rss_auth :index, :show
Chris@507 30 accept_api_auth :index, :show, :create, :update, :destroy
Chris@0 31
Chris@0 32 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
Chris@441 33
Chris@0 34 helper :journals
Chris@0 35 helper :projects
Chris@441 36 include ProjectsHelper
Chris@0 37 helper :custom_fields
Chris@0 38 include CustomFieldsHelper
Chris@0 39 helper :issue_relations
Chris@0 40 include IssueRelationsHelper
Chris@0 41 helper :watchers
Chris@0 42 include WatchersHelper
Chris@0 43 helper :attachments
Chris@0 44 include AttachmentsHelper
Chris@0 45 helper :queries
Chris@0 46 include QueriesHelper
Chris@119 47 helper :repositories
Chris@119 48 include RepositoriesHelper
Chris@0 49 helper :sort
Chris@0 50 include SortHelper
Chris@0 51 include IssuesHelper
Chris@0 52 helper :timelog
Chris@0 53 include Redmine::Export::PDF
Chris@0 54
Chris@0 55 def index
Chris@0 56 retrieve_query
Chris@0 57 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
Chris@0 58 sort_update(@query.sortable_columns)
Chris@1115 59 @query.sort_criteria = sort_criteria.to_a
Chris@441 60
Chris@0 61 if @query.valid?
Chris@119 62 case params[:format]
Chris@0 63 when 'csv', 'pdf'
Chris@119 64 @limit = Setting.issues_export_limit.to_i
Chris@0 65 when 'atom'
Chris@119 66 @limit = Setting.feeds_limit.to_i
Chris@119 67 when 'xml', 'json'
Chris@119 68 @offset, @limit = api_offset_and_limit
Chris@0 69 else
Chris@119 70 @limit = per_page_option
Chris@0 71 end
Chris@441 72
Chris@0 73 @issue_count = @query.issue_count
Chris@119 74 @issue_pages = Paginator.new self, @issue_count, @limit, params['page']
Chris@119 75 @offset ||= @issue_pages.current.offset
Chris@0 76 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
Chris@441 77 :order => sort_clause,
Chris@441 78 :offset => @offset,
Chris@119 79 :limit => @limit)
Chris@0 80 @issue_count_by_group = @query.issue_count_by_group
Chris@441 81
Chris@0 82 respond_to do |format|
Chris@909 83 format.html { render :template => 'issues/index', :layout => !request.xhr? }
Chris@909 84 format.api {
Chris@1115 85 Issue.load_visible_relations(@issues) if include_in_api_response?('relations')
Chris@909 86 }
Chris@0 87 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
Chris@909 88 format.csv { send_data(issues_to_csv(@issues, @project, @query, params), :type => 'text/csv; header=present', :filename => 'export.csv') }
Chris@0 89 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
Chris@0 90 end
Chris@0 91 else
Chris@909 92 respond_to do |format|
Chris@909 93 format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
Chris@909 94 format.any(:atom, :csv, :pdf) { render(:nothing => true) }
Chris@909 95 format.api { render_validation_errors(@query) }
Chris@909 96 end
Chris@0 97 end
Chris@0 98 rescue ActiveRecord::RecordNotFound
Chris@0 99 render_404
Chris@0 100 end
Chris@441 101
Chris@0 102 def show
Chris@1115 103 @journals = @issue.journals.includes(:user, :details).reorder("#{Journal.table_name}.id ASC").all
Chris@0 104 @journals.each_with_index {|j,i| j.indice = i+1}
Chris@1115 105 @journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
Chris@0 106 @journals.reverse! if User.current.wants_comments_in_reverse_order?
Chris@441 107
Chris@1115 108 @changesets = @issue.changesets.visible.all
Chris@1115 109 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
Chris@441 110
Chris@210 111 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
Chris@0 112 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
Chris@0 113 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
Chris@909 114 @priorities = IssuePriority.active
Chris@441 115 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
Chris@0 116 respond_to do |format|
Chris@1115 117 format.html {
Chris@1115 118 retrieve_previous_and_next_issue_ids
Chris@1115 119 render :template => 'issues/show'
Chris@1115 120 }
Chris@119 121 format.api
Chris@14 122 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
Chris@1115 123 format.pdf {
Chris@1115 124 pdf = issue_to_pdf(@issue, :journals => @journals)
Chris@1115 125 send_data(pdf, :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf")
Chris@1115 126 }
Chris@0 127 end
Chris@0 128 end
Chris@0 129
Chris@0 130 # Add a new issue
Chris@0 131 # The new issue will be created from an existing one if copy_from parameter is given
Chris@0 132 def new
Chris@14 133 respond_to do |format|
Chris@14 134 format.html { render :action => 'new', :layout => !request.xhr? }
Chris@1115 135 format.js { render :partial => 'update_form' }
Chris@14 136 end
Chris@0 137 end
Chris@0 138
Chris@0 139 def create
Chris@0 140 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
Chris@1115 141 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
Chris@0 142 if @issue.save
Chris@0 143 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
Chris@0 144 respond_to do |format|
Chris@0 145 format.html {
Chris@909 146 render_attachment_warning_if_needed(@issue)
Chris@1115 147 flash[:notice] = l(:notice_issue_successful_create, :id => view_context.link_to("##{@issue.id}", issue_path(@issue), :title => @issue.subject))
Chris@1115 148 redirect_to(params[:continue] ? { :action => 'new', :project_id => @issue.project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
Chris@0 149 { :action => 'show', :id => @issue })
Chris@0 150 }
Chris@119 151 format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }
Chris@0 152 end
Chris@0 153 return
Chris@0 154 else
Chris@0 155 respond_to do |format|
Chris@0 156 format.html { render :action => 'new' }
Chris@119 157 format.api { render_validation_errors(@issue) }
Chris@0 158 end
Chris@0 159 end
Chris@0 160 end
Chris@441 161
Chris@0 162 def edit
Chris@1115 163 return unless update_issue_from_params
Chris@0 164
Chris@0 165 respond_to do |format|
Chris@0 166 format.html { }
Chris@0 167 format.xml { }
Chris@0 168 end
Chris@0 169 end
Chris@0 170
Chris@0 171 def update
Chris@1115 172 return unless update_issue_from_params
Chris@1115 173 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
Chris@1115 174 saved = false
Chris@1115 175 begin
Chris@1115 176 saved = @issue.save_issue_with_child_records(params, @time_entry)
Chris@1115 177 rescue ActiveRecord::StaleObjectError
Chris@1115 178 @conflict = true
Chris@1115 179 if params[:last_journal_id]
Chris@1115 180 @conflict_journals = @issue.journals_after(params[:last_journal_id]).all
Chris@1115 181 @conflict_journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
Chris@1115 182 end
Chris@1115 183 end
Chris@0 184
Chris@1115 185 if saved
Chris@0 186 render_attachment_warning_if_needed(@issue)
Chris@0 187 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
Chris@0 188
Chris@0 189 respond_to do |format|
Chris@0 190 format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
Chris@1115 191 format.api { render_api_ok }
Chris@0 192 end
Chris@0 193 else
Chris@0 194 respond_to do |format|
Chris@0 195 format.html { render :action => 'edit' }
Chris@119 196 format.api { render_validation_errors(@issue) }
Chris@0 197 end
Chris@0 198 end
Chris@0 199 end
Chris@0 200
Chris@1115 201 # Bulk edit/copy a set of issues
Chris@0 202 def bulk_edit
Chris@0 203 @issues.sort!
Chris@1115 204 @copy = params[:copy].present?
Chris@1115 205 @notes = params[:notes]
Chris@1115 206
Chris@1115 207 if User.current.allowed_to?(:move_issues, @projects)
Chris@1115 208 @allowed_projects = Issue.allowed_target_projects_on_move
Chris@1115 209 if params[:issue]
Chris@1115 210 @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id].to_s}
Chris@1115 211 if @target_project
Chris@1115 212 target_projects = [@target_project]
Chris@1115 213 end
Chris@1115 214 end
Chris@1115 215 end
Chris@1115 216 target_projects ||= @projects
Chris@1115 217
Chris@1115 218 if @copy
Chris@1115 219 @available_statuses = [IssueStatus.default]
Chris@1115 220 else
Chris@1115 221 @available_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
Chris@1115 222 end
Chris@1115 223 @custom_fields = target_projects.map{|p|p.all_issue_custom_fields}.reduce(:&)
Chris@1115 224 @assignables = target_projects.map(&:assignable_users).reduce(:&)
Chris@1115 225 @trackers = target_projects.map(&:trackers).reduce(:&)
Chris@1115 226 @versions = target_projects.map {|p| p.shared_versions.open}.reduce(:&)
Chris@1115 227 @categories = target_projects.map {|p| p.issue_categories}.reduce(:&)
Chris@1115 228 if @copy
Chris@1115 229 @attachments_present = @issues.detect {|i| i.attachments.any?}.present?
Chris@1115 230 @subtasks_present = @issues.detect {|i| !i.leaf?}.present?
Chris@1115 231 end
Chris@1115 232
Chris@1115 233 @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
Chris@1115 234 render :layout => false if request.xhr?
Chris@0 235 end
Chris@0 236
Chris@14 237 def bulk_update
Chris@0 238 @issues.sort!
Chris@1115 239 @copy = params[:copy].present?
Chris@14 240 attributes = parse_params_for_bulk_issue_attributes(params)
Chris@14 241
Chris@14 242 unsaved_issue_ids = []
Chris@1115 243 moved_issues = []
Chris@1115 244
Chris@1115 245 if @copy && params[:copy_subtasks].present?
Chris@1115 246 # Descendant issues will be copied with the parent task
Chris@1115 247 # Don't copy them twice
Chris@1115 248 @issues.reject! {|issue| @issues.detect {|other| issue.is_descendant_of?(other)}}
Chris@1115 249 end
Chris@1115 250
Chris@14 251 @issues.each do |issue|
Chris@14 252 issue.reload
Chris@1115 253 if @copy
Chris@1115 254 issue = issue.copy({},
Chris@1115 255 :attachments => params[:copy_attachments].present?,
Chris@1115 256 :subtasks => params[:copy_subtasks].present?
Chris@1115 257 )
Chris@1115 258 end
Chris@14 259 journal = issue.init_journal(User.current, params[:notes])
Chris@14 260 issue.safe_attributes = attributes
Chris@14 261 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
Chris@1115 262 if issue.save
Chris@1115 263 moved_issues << issue
Chris@1115 264 else
Chris@14 265 # Keep unsaved issue ids to display them in flash error
Chris@14 266 unsaved_issue_ids << issue.id
Chris@0 267 end
Chris@0 268 end
Chris@14 269 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
Chris@1115 270
Chris@1115 271 if params[:follow]
Chris@1115 272 if @issues.size == 1 && moved_issues.size == 1
Chris@1115 273 redirect_to :controller => 'issues', :action => 'show', :id => moved_issues.first
Chris@1115 274 elsif moved_issues.map(&:project).uniq.size == 1
Chris@1115 275 redirect_to :controller => 'issues', :action => 'index', :project_id => moved_issues.map(&:project).first
Chris@1115 276 end
Chris@1115 277 else
Chris@1115 278 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
Chris@1115 279 end
Chris@0 280 end
Chris@441 281
Chris@0 282 def destroy
Chris@0 283 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
Chris@0 284 if @hours > 0
Chris@0 285 case params[:todo]
Chris@0 286 when 'destroy'
Chris@0 287 # nothing to do
Chris@0 288 when 'nullify'
Chris@0 289 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
Chris@0 290 when 'reassign'
Chris@0 291 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
Chris@0 292 if reassign_to.nil?
Chris@0 293 flash.now[:error] = l(:error_issue_not_found_in_project)
Chris@0 294 return
Chris@0 295 else
Chris@0 296 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
Chris@0 297 end
Chris@0 298 else
Chris@119 299 # display the destroy form if it's a user request
Chris@119 300 return unless api_request?
Chris@0 301 end
Chris@0 302 end
Chris@441 303 @issues.each do |issue|
Chris@441 304 begin
Chris@441 305 issue.reload.destroy
Chris@441 306 rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
Chris@441 307 # nothing to do, issue was already deleted (eg. by a parent)
Chris@441 308 end
Chris@441 309 end
Chris@0 310 respond_to do |format|
chris@37 311 format.html { redirect_back_or_default(:action => 'index', :project_id => @project) }
Chris@1115 312 format.api { render_api_ok }
Chris@0 313 end
Chris@0 314 end
Chris@0 315
Chris@1115 316 private
Chris@1115 317
Chris@1115 318 def find_project
Chris@1115 319 project_id = params[:project_id] || (params[:issue] && params[:issue][:project_id])
Chris@1115 320 @project = Project.find(project_id)
Chris@0 321 rescue ActiveRecord::RecordNotFound
Chris@0 322 render_404
Chris@0 323 end
Chris@441 324
Chris@1115 325 def retrieve_previous_and_next_issue_ids
Chris@1115 326 retrieve_query_from_session
Chris@1115 327 if @query
Chris@1115 328 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
Chris@1115 329 sort_update(@query.sortable_columns, 'issues_index_sort')
Chris@1115 330 limit = 500
Chris@1115 331 issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])
Chris@1115 332 if (idx = issue_ids.index(@issue.id)) && idx < limit
Chris@1115 333 if issue_ids.size < 500
Chris@1115 334 @issue_position = idx + 1
Chris@1115 335 @issue_count = issue_ids.size
Chris@1115 336 end
Chris@1115 337 @prev_issue_id = issue_ids[idx - 1] if idx > 0
Chris@1115 338 @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
Chris@1115 339 end
Chris@1115 340 end
Chris@0 341 end
Chris@441 342
Chris@0 343 # Used by #edit and #update to set some common instance variables
Chris@0 344 # from the params
Chris@0 345 # TODO: Refactor, not everything in here is needed by #edit
Chris@0 346 def update_issue_from_params
Chris@0 347 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
Chris@441 348 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
chris@37 349 @time_entry.attributes = params[:time_entry]
Chris@441 350
Chris@1115 351 @issue.init_journal(User.current)
Chris@1115 352
Chris@1115 353 issue_attributes = params[:issue]
Chris@1115 354 if issue_attributes && params[:conflict_resolution]
Chris@1115 355 case params[:conflict_resolution]
Chris@1115 356 when 'overwrite'
Chris@1115 357 issue_attributes = issue_attributes.dup
Chris@1115 358 issue_attributes.delete(:lock_version)
Chris@1115 359 when 'add_notes'
Chris@1115 360 issue_attributes = issue_attributes.slice(:notes)
Chris@1115 361 when 'cancel'
Chris@1115 362 redirect_to issue_path(@issue)
Chris@1115 363 return false
Chris@1115 364 end
Chris@1115 365 end
Chris@1115 366 @issue.safe_attributes = issue_attributes
Chris@1115 367 @priorities = IssuePriority.active
Chris@1115 368 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
Chris@1115 369 true
Chris@0 370 end
Chris@0 371
Chris@0 372 # TODO: Refactor, lots of extra code in here
chris@37 373 # TODO: Changing tracker on an existing issue should not trigger this
Chris@0 374 def build_new_issue_from_params
Chris@14 375 if params[:id].blank?
Chris@14 376 @issue = Issue.new
Chris@1115 377 if params[:copy_from]
Chris@1115 378 begin
Chris@1115 379 @copy_from = Issue.visible.find(params[:copy_from])
Chris@1115 380 @copy_attachments = params[:copy_attachments].present? || request.get?
Chris@1115 381 @copy_subtasks = params[:copy_subtasks].present? || request.get?
Chris@1115 382 @issue.copy_from(@copy_from, :attachments => @copy_attachments, :subtasks => @copy_subtasks)
Chris@1115 383 rescue ActiveRecord::RecordNotFound
Chris@1115 384 render_404
Chris@1115 385 return
Chris@1115 386 end
Chris@1115 387 end
Chris@14 388 @issue.project = @project
Chris@14 389 else
Chris@14 390 @issue = @project.issues.visible.find(params[:id])
Chris@14 391 end
Chris@441 392
Chris@0 393 @issue.project = @project
Chris@1115 394 @issue.author ||= User.current
Chris@0 395 # Tracker must be set before custom field values
Chris@0 396 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
Chris@0 397 if @issue.tracker.nil?
Chris@0 398 render_error l(:error_no_tracker_in_project)
Chris@0 399 return false
Chris@0 400 end
Chris@909 401 @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
Chris@1115 402 @issue.safe_attributes = params[:issue]
Chris@1115 403
Chris@909 404 @priorities = IssuePriority.active
Chris@0 405 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
Chris@1115 406 @available_watchers = (@issue.project.users.sort + @issue.watcher_users).uniq
Chris@0 407 end
Chris@0 408
Chris@0 409 def check_for_default_issue_status
Chris@0 410 if IssueStatus.default.nil?
Chris@0 411 render_error l(:error_no_default_issue_status)
Chris@0 412 return false
Chris@0 413 end
Chris@0 414 end
Chris@14 415
Chris@14 416 def parse_params_for_bulk_issue_attributes(params)
Chris@14 417 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
Chris@14 418 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
Chris@1115 419 if custom = attributes[:custom_field_values]
Chris@1115 420 custom.reject! {|k,v| v.blank?}
Chris@1115 421 custom.keys.each do |k|
Chris@1115 422 if custom[k].is_a?(Array)
Chris@1115 423 custom[k] << '' if custom[k].delete('__none__')
Chris@1115 424 else
Chris@1115 425 custom[k] = '' if custom[k] == '__none__'
Chris@1115 426 end
Chris@1115 427 end
Chris@1115 428 end
Chris@14 429 attributes
Chris@14 430 end
Chris@0 431 end