Chris@0
|
1 # Redmine - project management software
|
Chris@1115
|
2 # Copyright (C) 2006-2012 Jean-Philippe Lang
|
Chris@0
|
3 #
|
Chris@0
|
4 # This program is free software; you can redistribute it and/or
|
Chris@0
|
5 # modify it under the terms of the GNU General Public License
|
Chris@0
|
6 # as published by the Free Software Foundation; either version 2
|
Chris@0
|
7 # of the License, or (at your option) any later version.
|
Chris@909
|
8 #
|
Chris@0
|
9 # This program is distributed in the hope that it will be useful,
|
Chris@0
|
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
|
Chris@0
|
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
Chris@0
|
12 # GNU General Public License for more details.
|
Chris@909
|
13 #
|
Chris@0
|
14 # You should have received a copy of the GNU General Public License
|
Chris@0
|
15 # along with this program; if not, write to the Free Software
|
Chris@0
|
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
Chris@0
|
17
|
Chris@119
|
18 require File.expand_path('../../test_helper', __FILE__)
|
Chris@0
|
19 require 'issues_controller'
|
Chris@0
|
20
|
Chris@0
|
21 class IssuesControllerTransactionTest < ActionController::TestCase
|
Chris@0
|
22 fixtures :projects,
|
Chris@0
|
23 :users,
|
Chris@0
|
24 :roles,
|
Chris@0
|
25 :members,
|
Chris@0
|
26 :member_roles,
|
Chris@0
|
27 :issues,
|
Chris@0
|
28 :issue_statuses,
|
Chris@0
|
29 :versions,
|
Chris@0
|
30 :trackers,
|
Chris@0
|
31 :projects_trackers,
|
Chris@0
|
32 :issue_categories,
|
Chris@0
|
33 :enabled_modules,
|
Chris@0
|
34 :enumerations,
|
Chris@0
|
35 :attachments,
|
Chris@0
|
36 :workflows,
|
Chris@0
|
37 :custom_fields,
|
Chris@0
|
38 :custom_values,
|
Chris@0
|
39 :custom_fields_projects,
|
Chris@0
|
40 :custom_fields_trackers,
|
Chris@0
|
41 :time_entries,
|
Chris@0
|
42 :journals,
|
Chris@0
|
43 :journal_details,
|
Chris@0
|
44 :queries
|
Chris@0
|
45
|
Chris@0
|
46 self.use_transactional_fixtures = false
|
Chris@909
|
47
|
Chris@0
|
48 def setup
|
Chris@0
|
49 @controller = IssuesController.new
|
Chris@0
|
50 @request = ActionController::TestRequest.new
|
Chris@0
|
51 @response = ActionController::TestResponse.new
|
Chris@0
|
52 User.current = nil
|
Chris@0
|
53 end
|
Chris@909
|
54
|
Chris@1115
|
55 def test_update_stale_issue_should_not_update_the_issue
|
Chris@0
|
56 issue = Issue.find(2)
|
Chris@0
|
57 @request.session[:user_id] = 2
|
Chris@0
|
58
|
Chris@0
|
59 assert_no_difference 'Journal.count' do
|
Chris@0
|
60 assert_no_difference 'TimeEntry.count' do
|
Chris@1115
|
61 put :update,
|
Chris@1115
|
62 :id => issue.id,
|
Chris@1115
|
63 :issue => {
|
Chris@1115
|
64 :fixed_version_id => 4,
|
Chris@1115
|
65 :notes => 'My notes',
|
Chris@1115
|
66 :lock_version => (issue.lock_version - 1)
|
Chris@1115
|
67 },
|
Chris@1115
|
68 :time_entry => { :hours => '2.5', :comments => '', :activity_id => TimeEntryActivity.first.id }
|
Chris@1115
|
69 end
|
Chris@1115
|
70 end
|
Chris@1115
|
71
|
Chris@1115
|
72 assert_response :success
|
Chris@1115
|
73 assert_template 'edit'
|
Chris@1115
|
74
|
Chris@1115
|
75 assert_select 'div.conflict'
|
Chris@1115
|
76 assert_select 'input[name=?][value=?]', 'conflict_resolution', 'overwrite'
|
Chris@1115
|
77 assert_select 'input[name=?][value=?]', 'conflict_resolution', 'add_notes'
|
Chris@1115
|
78 assert_select 'label' do
|
Chris@1115
|
79 assert_select 'input[name=?][value=?]', 'conflict_resolution', 'cancel'
|
Chris@1115
|
80 assert_select 'a[href=/issues/2]'
|
Chris@1115
|
81 end
|
Chris@1115
|
82 end
|
Chris@1115
|
83
|
Chris@1115
|
84 def test_update_stale_issue_should_save_attachments
|
Chris@1115
|
85 set_tmp_attachments_directory
|
Chris@1115
|
86 issue = Issue.find(2)
|
Chris@1115
|
87 @request.session[:user_id] = 2
|
Chris@1115
|
88
|
Chris@1115
|
89 assert_no_difference 'Journal.count' do
|
Chris@1115
|
90 assert_no_difference 'TimeEntry.count' do
|
Chris@1115
|
91 assert_difference 'Attachment.count' do
|
Chris@0
|
92 put :update,
|
Chris@0
|
93 :id => issue.id,
|
Chris@0
|
94 :issue => {
|
Chris@0
|
95 :fixed_version_id => 4,
|
Chris@1115
|
96 :notes => 'My notes',
|
Chris@0
|
97 :lock_version => (issue.lock_version - 1)
|
Chris@0
|
98 },
|
Chris@0
|
99 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}},
|
Chris@0
|
100 :time_entry => { :hours => '2.5', :comments => '', :activity_id => TimeEntryActivity.first.id }
|
Chris@0
|
101 end
|
Chris@0
|
102 end
|
Chris@0
|
103 end
|
Chris@909
|
104
|
Chris@0
|
105 assert_response :success
|
Chris@0
|
106 assert_template 'edit'
|
Chris@1115
|
107 attachment = Attachment.first(:order => 'id DESC')
|
Chris@1115
|
108 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
|
Chris@1115
|
109 assert_tag 'span', :content => /testfile.txt/
|
Chris@1115
|
110 end
|
Chris@1115
|
111
|
Chris@1115
|
112 def test_update_stale_issue_without_notes_should_not_show_add_notes_option
|
Chris@1115
|
113 issue = Issue.find(2)
|
Chris@1115
|
114 @request.session[:user_id] = 2
|
Chris@1115
|
115
|
Chris@1115
|
116 put :update, :id => issue.id,
|
Chris@1115
|
117 :issue => {
|
Chris@1115
|
118 :fixed_version_id => 4,
|
Chris@1115
|
119 :notes => '',
|
Chris@1115
|
120 :lock_version => (issue.lock_version - 1)
|
Chris@1115
|
121 }
|
Chris@1115
|
122
|
Chris@1115
|
123 assert_tag 'div', :attributes => {:class => 'conflict'}
|
Chris@1115
|
124 assert_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'overwrite'}
|
Chris@1115
|
125 assert_no_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'add_notes'}
|
Chris@1115
|
126 assert_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'cancel'}
|
Chris@1115
|
127 end
|
Chris@1115
|
128
|
Chris@1115
|
129 def test_update_stale_issue_should_show_conflicting_journals
|
Chris@1115
|
130 @request.session[:user_id] = 2
|
Chris@1115
|
131
|
Chris@1115
|
132 put :update, :id => 1,
|
Chris@1115
|
133 :issue => {
|
Chris@1115
|
134 :fixed_version_id => 4,
|
Chris@1115
|
135 :notes => '',
|
Chris@1115
|
136 :lock_version => 2
|
Chris@1115
|
137 },
|
Chris@1115
|
138 :last_journal_id => 1
|
Chris@1115
|
139
|
Chris@1115
|
140 assert_not_nil assigns(:conflict_journals)
|
Chris@1115
|
141 assert_equal 1, assigns(:conflict_journals).size
|
Chris@1115
|
142 assert_equal 2, assigns(:conflict_journals).first.id
|
Chris@1115
|
143 assert_tag 'div', :attributes => {:class => 'conflict'},
|
Chris@1115
|
144 :descendant => {:content => /Some notes with Redmine links/}
|
Chris@1115
|
145 end
|
Chris@1115
|
146
|
Chris@1115
|
147 def test_update_stale_issue_without_previous_journal_should_show_all_journals
|
Chris@1115
|
148 @request.session[:user_id] = 2
|
Chris@1115
|
149
|
Chris@1115
|
150 put :update, :id => 1,
|
Chris@1115
|
151 :issue => {
|
Chris@1115
|
152 :fixed_version_id => 4,
|
Chris@1115
|
153 :notes => '',
|
Chris@1115
|
154 :lock_version => 2
|
Chris@1115
|
155 },
|
Chris@1115
|
156 :last_journal_id => ''
|
Chris@1115
|
157
|
Chris@1115
|
158 assert_not_nil assigns(:conflict_journals)
|
Chris@1115
|
159 assert_equal 2, assigns(:conflict_journals).size
|
Chris@1115
|
160 assert_tag 'div', :attributes => {:class => 'conflict'},
|
Chris@1115
|
161 :descendant => {:content => /Some notes with Redmine links/}
|
Chris@1115
|
162 assert_tag 'div', :attributes => {:class => 'conflict'},
|
Chris@1115
|
163 :descendant => {:content => /Journal notes/}
|
Chris@1115
|
164 end
|
Chris@1115
|
165
|
Chris@1115
|
166 def test_update_stale_issue_should_show_private_journals_with_permission_only
|
Chris@1115
|
167 journal = Journal.create!(:journalized => Issue.find(1), :notes => 'Privates notes', :private_notes => true, :user_id => 1)
|
Chris@1115
|
168
|
Chris@1115
|
169 @request.session[:user_id] = 2
|
Chris@1115
|
170 put :update, :id => 1, :issue => {:fixed_version_id => 4, :lock_version => 2}, :last_journal_id => ''
|
Chris@1115
|
171 assert_include journal, assigns(:conflict_journals)
|
Chris@1115
|
172
|
Chris@1115
|
173 Role.find(1).remove_permission! :view_private_notes
|
Chris@1115
|
174 put :update, :id => 1, :issue => {:fixed_version_id => 4, :lock_version => 2}, :last_journal_id => ''
|
Chris@1115
|
175 assert_not_include journal, assigns(:conflict_journals)
|
Chris@1115
|
176 end
|
Chris@1115
|
177
|
Chris@1115
|
178 def test_update_stale_issue_with_overwrite_conflict_resolution_should_update
|
Chris@1115
|
179 @request.session[:user_id] = 2
|
Chris@1115
|
180
|
Chris@1115
|
181 assert_difference 'Journal.count' do
|
Chris@1115
|
182 put :update, :id => 1,
|
Chris@1115
|
183 :issue => {
|
Chris@1115
|
184 :fixed_version_id => 4,
|
Chris@1115
|
185 :notes => 'overwrite_conflict_resolution',
|
Chris@1115
|
186 :lock_version => 2
|
Chris@1115
|
187 },
|
Chris@1115
|
188 :conflict_resolution => 'overwrite'
|
Chris@1115
|
189 end
|
Chris@1115
|
190
|
Chris@1115
|
191 assert_response 302
|
Chris@1115
|
192 issue = Issue.find(1)
|
Chris@1115
|
193 assert_equal 4, issue.fixed_version_id
|
Chris@1115
|
194 journal = Journal.first(:order => 'id DESC')
|
Chris@1115
|
195 assert_equal 'overwrite_conflict_resolution', journal.notes
|
Chris@1115
|
196 assert journal.details.any?
|
Chris@1115
|
197 end
|
Chris@1115
|
198
|
Chris@1115
|
199 def test_update_stale_issue_with_add_notes_conflict_resolution_should_update
|
Chris@1115
|
200 @request.session[:user_id] = 2
|
Chris@1115
|
201
|
Chris@1115
|
202 assert_difference 'Journal.count' do
|
Chris@1115
|
203 put :update, :id => 1,
|
Chris@1115
|
204 :issue => {
|
Chris@1115
|
205 :fixed_version_id => 4,
|
Chris@1115
|
206 :notes => 'add_notes_conflict_resolution',
|
Chris@1115
|
207 :lock_version => 2
|
Chris@1115
|
208 },
|
Chris@1115
|
209 :conflict_resolution => 'add_notes'
|
Chris@1115
|
210 end
|
Chris@1115
|
211
|
Chris@1115
|
212 assert_response 302
|
Chris@1115
|
213 issue = Issue.find(1)
|
Chris@1115
|
214 assert_nil issue.fixed_version_id
|
Chris@1115
|
215 journal = Journal.first(:order => 'id DESC')
|
Chris@1115
|
216 assert_equal 'add_notes_conflict_resolution', journal.notes
|
Chris@1115
|
217 assert journal.details.empty?
|
Chris@1115
|
218 end
|
Chris@1115
|
219
|
Chris@1115
|
220 def test_update_stale_issue_with_cancel_conflict_resolution_should_redirect_without_updating
|
Chris@1115
|
221 @request.session[:user_id] = 2
|
Chris@1115
|
222
|
Chris@1115
|
223 assert_no_difference 'Journal.count' do
|
Chris@1115
|
224 put :update, :id => 1,
|
Chris@1115
|
225 :issue => {
|
Chris@1115
|
226 :fixed_version_id => 4,
|
Chris@1115
|
227 :notes => 'add_notes_conflict_resolution',
|
Chris@1115
|
228 :lock_version => 2
|
Chris@1115
|
229 },
|
Chris@1115
|
230 :conflict_resolution => 'cancel'
|
Chris@1115
|
231 end
|
Chris@1115
|
232
|
Chris@1115
|
233 assert_redirected_to '/issues/1'
|
Chris@1115
|
234 issue = Issue.find(1)
|
Chris@1115
|
235 assert_nil issue.fixed_version_id
|
Chris@1115
|
236 end
|
Chris@1115
|
237
|
Chris@1115
|
238 def test_put_update_with_spent_time_and_failure_should_not_add_spent_time
|
Chris@1115
|
239 @request.session[:user_id] = 2
|
Chris@1115
|
240
|
Chris@1115
|
241 assert_no_difference('TimeEntry.count') do
|
Chris@1115
|
242 put :update,
|
Chris@1115
|
243 :id => 1,
|
Chris@1115
|
244 :issue => { :subject => '' },
|
Chris@1115
|
245 :time_entry => { :hours => '2.5', :comments => 'should not be added', :activity_id => TimeEntryActivity.first.id }
|
Chris@1115
|
246 assert_response :success
|
Chris@1115
|
247 end
|
Chris@1115
|
248
|
Chris@1115
|
249 assert_select 'input[name=?][value=?]', 'time_entry[hours]', '2.5'
|
Chris@1115
|
250 assert_select 'input[name=?][value=?]', 'time_entry[comments]', 'should not be added'
|
Chris@1115
|
251 assert_select 'select[name=?]', 'time_entry[activity_id]' do
|
Chris@1115
|
252 assert_select 'option[value=?][selected=selected]', TimeEntryActivity.first.id
|
Chris@1115
|
253 end
|
Chris@1115
|
254 end
|
Chris@1115
|
255
|
Chris@1115
|
256 def test_index_should_rescue_invalid_sql_query
|
Chris@1115
|
257 Query.any_instance.stubs(:statement).returns("INVALID STATEMENT")
|
Chris@1115
|
258
|
Chris@1115
|
259 get :index
|
Chris@1115
|
260 assert_response 500
|
Chris@1115
|
261 assert_tag 'p', :content => /An error occurred/
|
Chris@1115
|
262 assert_nil session[:query]
|
Chris@1115
|
263 assert_nil session[:issues_index_sort]
|
Chris@0
|
264 end
|
Chris@0
|
265 end
|