annotate app/controllers/issues_controller.rb @ 929:5f33065ddc4b redmine-1.3

Update to Redmine SVN rev 9414 on 1.3-stable branch
author Chris Cannam
date Wed, 27 Jun 2012 14:54:18 +0100
parents cbb26bc654de
children 5e80956cc792 433d4f72a19b
rev   line source
Chris@0 1 # Redmine - project management software
Chris@441 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
Chris@0 3 #
Chris@0 4 # This program is free software; you can redistribute it and/or
Chris@0 5 # modify it under the terms of the GNU General Public License
Chris@0 6 # as published by the Free Software Foundation; either version 2
Chris@0 7 # of the License, or (at your option) any later version.
Chris@441 8 #
Chris@0 9 # This program is distributed in the hope that it will be useful,
Chris@0 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@0 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@0 12 # GNU General Public License for more details.
Chris@441 13 #
Chris@0 14 # You should have received a copy of the GNU General Public License
Chris@0 15 # along with this program; if not, write to the Free Software
Chris@0 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@0 17
Chris@0 18 class IssuesController < ApplicationController
Chris@0 19 menu_item :new_issue, :only => [:new, :create]
Chris@0 20 default_search_scope :issues
Chris@441 21
Chris@14 22 before_filter :find_issue, :only => [:show, :edit, :update]
Chris@14 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]
chris@37 24 before_filter :check_project_uniqueness, :only => [:move, :perform_move]
Chris@14 25 before_filter :find_project, :only => [:new, :create]
Chris@14 26 before_filter :authorize, :except => [:index]
Chris@14 27 before_filter :find_optional_project, :only => [:index]
Chris@0 28 before_filter :check_for_default_issue_status, :only => [:new, :create]
Chris@0 29 before_filter :build_new_issue_from_params, :only => [:new, :create]
Chris@507 30 accept_rss_auth :index, :show
Chris@507 31 accept_api_auth :index, :show, :create, :update, :destroy
Chris@0 32
Chris@0 33 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
Chris@441 34
Chris@0 35 helper :journals
Chris@0 36 helper :projects
Chris@441 37 include ProjectsHelper
Chris@0 38 helper :custom_fields
Chris@0 39 include CustomFieldsHelper
Chris@0 40 helper :issue_relations
Chris@0 41 include IssueRelationsHelper
Chris@0 42 helper :watchers
Chris@0 43 include WatchersHelper
Chris@0 44 helper :attachments
Chris@0 45 include AttachmentsHelper
Chris@0 46 helper :queries
Chris@0 47 include QueriesHelper
Chris@119 48 helper :repositories
Chris@119 49 include RepositoriesHelper
Chris@0 50 helper :sort
Chris@0 51 include SortHelper
Chris@0 52 include IssuesHelper
Chris@0 53 helper :timelog
chris@22 54 helper :gantt
Chris@0 55 include Redmine::Export::PDF
Chris@0 56
Chris@0 57 verify :method => [:post, :delete],
Chris@0 58 :only => :destroy,
Chris@0 59 :render => { :nothing => true, :status => :method_not_allowed }
Chris@0 60
Chris@0 61 verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }
Chris@14 62 verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }
Chris@0 63 verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
Chris@441 64
Chris@0 65 def index
Chris@0 66 retrieve_query
Chris@0 67 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
Chris@0 68 sort_update(@query.sortable_columns)
Chris@441 69
Chris@0 70 if @query.valid?
Chris@119 71 case params[:format]
Chris@0 72 when 'csv', 'pdf'
Chris@119 73 @limit = Setting.issues_export_limit.to_i
Chris@0 74 when 'atom'
Chris@119 75 @limit = Setting.feeds_limit.to_i
Chris@119 76 when 'xml', 'json'
Chris@119 77 @offset, @limit = api_offset_and_limit
Chris@0 78 else
Chris@119 79 @limit = per_page_option
Chris@0 80 end
Chris@441 81
Chris@0 82 @issue_count = @query.issue_count
Chris@119 83 @issue_pages = Paginator.new self, @issue_count, @limit, params['page']
Chris@119 84 @offset ||= @issue_pages.current.offset
Chris@0 85 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
Chris@441 86 :order => sort_clause,
Chris@441 87 :offset => @offset,
Chris@119 88 :limit => @limit)
Chris@0 89 @issue_count_by_group = @query.issue_count_by_group
Chris@441 90
Chris@0 91 respond_to do |format|
Chris@909 92 format.html { render :template => 'issues/index', :layout => !request.xhr? }
Chris@909 93 format.api {
Chris@909 94 Issue.load_relations(@issues) if include_in_api_response?('relations')
Chris@909 95 }
Chris@0 96 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
Chris@909 97 format.csv { send_data(issues_to_csv(@issues, @project, @query, params), :type => 'text/csv; header=present', :filename => 'export.csv') }
Chris@0 98 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
Chris@0 99 end
Chris@0 100 else
Chris@909 101 respond_to do |format|
Chris@909 102 format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
Chris@909 103 format.any(:atom, :csv, :pdf) { render(:nothing => true) }
Chris@909 104 format.api { render_validation_errors(@query) }
Chris@909 105 end
Chris@0 106 end
Chris@0 107 rescue ActiveRecord::RecordNotFound
Chris@0 108 render_404
Chris@0 109 end
Chris@441 110
Chris@0 111 def show
Chris@0 112 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
Chris@0 113 @journals.each_with_index {|j,i| j.indice = i+1}
Chris@0 114 @journals.reverse! if User.current.wants_comments_in_reverse_order?
Chris@441 115
Chris@441 116 if User.current.allowed_to?(:view_changesets, @project)
Chris@441 117 @changesets = @issue.changesets.visible.all
Chris@441 118 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
Chris@441 119 end
Chris@441 120
Chris@210 121 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
Chris@0 122 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
Chris@0 123 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
Chris@909 124 @priorities = IssuePriority.active
Chris@441 125 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
Chris@0 126 respond_to do |format|
Chris@909 127 format.html { render :template => 'issues/show' }
Chris@119 128 format.api
Chris@14 129 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
Chris@0 130 format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
Chris@0 131 end
Chris@0 132 end
Chris@0 133
Chris@0 134 # Add a new issue
Chris@0 135 # The new issue will be created from an existing one if copy_from parameter is given
Chris@0 136 def new
Chris@14 137 respond_to do |format|
Chris@14 138 format.html { render :action => 'new', :layout => !request.xhr? }
Chris@14 139 format.js { render :partial => 'attributes' }
Chris@14 140 end
Chris@0 141 end
Chris@0 142
Chris@0 143 def create
Chris@0 144 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
Chris@0 145 if @issue.save
Chris@0 146 attachments = Attachment.attach_files(@issue, params[:attachments])
Chris@0 147 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
Chris@0 148 respond_to do |format|
Chris@0 149 format.html {
Chris@909 150 render_attachment_warning_if_needed(@issue)
Chris@909 151 flash[:notice] = l(:notice_issue_successful_create, :id => "<a href='#{issue_path(@issue)}'>##{@issue.id}</a>")
chris@22 152 redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
Chris@0 153 { :action => 'show', :id => @issue })
Chris@0 154 }
Chris@119 155 format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }
Chris@0 156 end
Chris@0 157 return
Chris@0 158 else
Chris@0 159 respond_to do |format|
Chris@0 160 format.html { render :action => 'new' }
Chris@119 161 format.api { render_validation_errors(@issue) }
Chris@0 162 end
Chris@0 163 end
Chris@0 164 end
Chris@441 165
Chris@0 166 def edit
Chris@0 167 update_issue_from_params
Chris@0 168
Chris@0 169 @journal = @issue.current_journal
Chris@0 170
Chris@0 171 respond_to do |format|
Chris@0 172 format.html { }
Chris@0 173 format.xml { }
Chris@0 174 end
Chris@0 175 end
Chris@0 176
Chris@0 177 def update
Chris@0 178 update_issue_from_params
Chris@0 179
Chris@0 180 if @issue.save_issue_with_child_records(params, @time_entry)
Chris@0 181 render_attachment_warning_if_needed(@issue)
Chris@0 182 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
Chris@0 183
Chris@0 184 respond_to do |format|
Chris@0 185 format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
Chris@119 186 format.api { head :ok }
Chris@0 187 end
Chris@0 188 else
Chris@0 189 render_attachment_warning_if_needed(@issue)
Chris@0 190 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
Chris@0 191 @journal = @issue.current_journal
Chris@0 192
Chris@0 193 respond_to do |format|
Chris@0 194 format.html { render :action => 'edit' }
Chris@119 195 format.api { render_validation_errors(@issue) }
Chris@0 196 end
Chris@0 197 end
Chris@0 198 end
Chris@0 199
Chris@0 200 # Bulk edit a set of issues
Chris@0 201 def bulk_edit
Chris@0 202 @issues.sort!
chris@37 203 @available_statuses = @projects.map{|p|Workflow.available_statuses(p)}.inject{|memo,w|memo & w}
chris@37 204 @custom_fields = @projects.map{|p|p.all_issue_custom_fields}.inject{|memo,c|memo & c}
chris@37 205 @assignables = @projects.map(&:assignable_users).inject{|memo,a| memo & a}
chris@37 206 @trackers = @projects.map(&:trackers).inject{|memo,t| memo & t}
Chris@0 207 end
Chris@0 208
Chris@14 209 def bulk_update
Chris@0 210 @issues.sort!
Chris@14 211 attributes = parse_params_for_bulk_issue_attributes(params)
Chris@14 212
Chris@14 213 unsaved_issue_ids = []
Chris@14 214 @issues.each do |issue|
Chris@14 215 issue.reload
Chris@14 216 journal = issue.init_journal(User.current, params[:notes])
Chris@14 217 issue.safe_attributes = attributes
Chris@14 218 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
Chris@14 219 unless issue.save
Chris@14 220 # Keep unsaved issue ids to display them in flash error
Chris@14 221 unsaved_issue_ids << issue.id
Chris@0 222 end
Chris@0 223 end
Chris@14 224 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
Chris@14 225 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
Chris@0 226 end
Chris@441 227
Chris@0 228 def destroy
Chris@0 229 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
Chris@0 230 if @hours > 0
Chris@0 231 case params[:todo]
Chris@0 232 when 'destroy'
Chris@0 233 # nothing to do
Chris@0 234 when 'nullify'
Chris@0 235 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
Chris@0 236 when 'reassign'
Chris@0 237 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
Chris@0 238 if reassign_to.nil?
Chris@0 239 flash.now[:error] = l(:error_issue_not_found_in_project)
Chris@0 240 return
Chris@0 241 else
Chris@0 242 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
Chris@0 243 end
Chris@0 244 else
Chris@119 245 # display the destroy form if it's a user request
Chris@119 246 return unless api_request?
Chris@0 247 end
Chris@0 248 end
Chris@441 249 @issues.each do |issue|
Chris@441 250 begin
Chris@441 251 issue.reload.destroy
Chris@441 252 rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
Chris@441 253 # nothing to do, issue was already deleted (eg. by a parent)
Chris@441 254 end
Chris@441 255 end
Chris@0 256 respond_to do |format|
chris@37 257 format.html { redirect_back_or_default(:action => 'index', :project_id => @project) }
Chris@119 258 format.api { head :ok }
Chris@0 259 end
Chris@0 260 end
Chris@0 261
Chris@0 262 private
Chris@0 263 def find_issue
Chris@441 264 # Issue.visible.find(...) can not be used to redirect user to the login form
Chris@441 265 # if the issue actually exists but requires authentication
Chris@0 266 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
Chris@441 267 unless @issue.visible?
Chris@441 268 deny_access
Chris@441 269 return
Chris@441 270 end
Chris@0 271 @project = @issue.project
Chris@0 272 rescue ActiveRecord::RecordNotFound
Chris@0 273 render_404
Chris@0 274 end
Chris@441 275
Chris@0 276 def find_project
Chris@0 277 project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]
Chris@0 278 @project = Project.find(project_id)
Chris@0 279 rescue ActiveRecord::RecordNotFound
Chris@0 280 render_404
Chris@0 281 end
Chris@441 282
Chris@0 283 # Used by #edit and #update to set some common instance variables
Chris@0 284 # from the params
Chris@0 285 # TODO: Refactor, not everything in here is needed by #edit
Chris@0 286 def update_issue_from_params
Chris@0 287 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
Chris@909 288 @priorities = IssuePriority.active
Chris@0 289 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
Chris@441 290 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
chris@37 291 @time_entry.attributes = params[:time_entry]
Chris@441 292
chris@22 293 @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)
Chris@0 294 @issue.init_journal(User.current, @notes)
chris@37 295 @issue.safe_attributes = params[:issue]
Chris@0 296 end
Chris@0 297
Chris@0 298 # TODO: Refactor, lots of extra code in here
chris@37 299 # TODO: Changing tracker on an existing issue should not trigger this
Chris@0 300 def build_new_issue_from_params
Chris@14 301 if params[:id].blank?
Chris@14 302 @issue = Issue.new
Chris@14 303 @issue.copy_from(params[:copy_from]) if params[:copy_from]
Chris@14 304 @issue.project = @project
Chris@14 305 else
Chris@14 306 @issue = @project.issues.visible.find(params[:id])
Chris@14 307 end
Chris@441 308
Chris@0 309 @issue.project = @project
Chris@507 310 @issue.author = User.current
Chris@0 311 # Tracker must be set before custom field values
Chris@0 312 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
Chris@0 313 if @issue.tracker.nil?
Chris@0 314 render_error l(:error_no_tracker_in_project)
Chris@0 315 return false
Chris@0 316 end
Chris@909 317 @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
Chris@0 318 if params[:issue].is_a?(Hash)
Chris@0 319 @issue.safe_attributes = params[:issue]
chris@37 320 if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record?
chris@37 321 @issue.watcher_user_ids = params[:issue]['watcher_user_ids']
chris@37 322 end
Chris@0 323 end
Chris@909 324 @priorities = IssuePriority.active
Chris@0 325 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
Chris@0 326 end
Chris@0 327
Chris@0 328 def check_for_default_issue_status
Chris@0 329 if IssueStatus.default.nil?
Chris@0 330 render_error l(:error_no_default_issue_status)
Chris@0 331 return false
Chris@0 332 end
Chris@0 333 end
Chris@14 334
Chris@14 335 def parse_params_for_bulk_issue_attributes(params)
Chris@14 336 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
Chris@14 337 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
Chris@14 338 attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
Chris@14 339 attributes
Chris@14 340 end
Chris@0 341 end