annotate test/functional/workflows_controller_test.rb @ 1480:75fd8eace091 issue_556

Close obsolete branch issue_556
author Chris Cannam
date Sat, 13 Jul 2013 15:26:30 +0100
parents 433d4f72a19b
children 622f24f53b42 261b3d9a4903
rev   line source
Chris@0 1 # Redmine - project management software
Chris@1115 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
Chris@0 3 #
Chris@0 4 # This program is free software; you can redistribute it and/or
Chris@0 5 # modify it under the terms of the GNU General Public License
Chris@0 6 # as published by the Free Software Foundation; either version 2
Chris@0 7 # of the License, or (at your option) any later version.
Chris@909 8 #
Chris@0 9 # This program is distributed in the hope that it will be useful,
Chris@0 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@0 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@0 12 # GNU General Public License for more details.
Chris@909 13 #
Chris@0 14 # You should have received a copy of the GNU General Public License
Chris@0 15 # along with this program; if not, write to the Free Software
Chris@0 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@0 17
Chris@119 18 require File.expand_path('../../test_helper', __FILE__)
Chris@0 19 require 'workflows_controller'
Chris@0 20
Chris@0 21 # Re-raise errors caught by the controller.
Chris@0 22 class WorkflowsController; def rescue_action(e) raise e end; end
Chris@0 23
Chris@0 24 class WorkflowsControllerTest < ActionController::TestCase
Chris@0 25 fixtures :roles, :trackers, :workflows, :users, :issue_statuses
Chris@909 26
Chris@0 27 def setup
Chris@0 28 @controller = WorkflowsController.new
Chris@0 29 @request = ActionController::TestRequest.new
Chris@0 30 @response = ActionController::TestResponse.new
Chris@0 31 User.current = nil
Chris@0 32 @request.session[:user_id] = 1 # admin
Chris@0 33 end
Chris@909 34
Chris@0 35 def test_index
Chris@0 36 get :index
Chris@0 37 assert_response :success
Chris@0 38 assert_template 'index'
Chris@909 39
Chris@1115 40 count = WorkflowTransition.count(:all, :conditions => 'role_id = 1 AND tracker_id = 2')
Chris@0 41 assert_tag :tag => 'a', :content => count.to_s,
Chris@0 42 :attributes => { :href => '/workflows/edit?role_id=1&amp;tracker_id=2' }
Chris@0 43 end
Chris@909 44
Chris@0 45 def test_get_edit
Chris@0 46 get :edit
Chris@0 47 assert_response :success
Chris@0 48 assert_template 'edit'
Chris@0 49 assert_not_nil assigns(:roles)
Chris@0 50 assert_not_nil assigns(:trackers)
Chris@0 51 end
Chris@909 52
Chris@0 53 def test_get_edit_with_role_and_tracker
Chris@1115 54 WorkflowTransition.delete_all
Chris@1115 55 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 2, :new_status_id => 3)
Chris@1115 56 WorkflowTransition.create!(:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 5)
Chris@909 57
Chris@0 58 get :edit, :role_id => 2, :tracker_id => 1
Chris@0 59 assert_response :success
Chris@0 60 assert_template 'edit'
Chris@909 61
Chris@0 62 # used status only
Chris@0 63 assert_not_nil assigns(:statuses)
Chris@0 64 assert_equal [2, 3, 5], assigns(:statuses).collect(&:id)
Chris@909 65
Chris@0 66 # allowed transitions
Chris@0 67 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
Chris@245 68 :name => 'issue_status[3][5][]',
Chris@245 69 :value => 'always',
Chris@0 70 :checked => 'checked' }
Chris@0 71 # not allowed
Chris@0 72 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
Chris@245 73 :name => 'issue_status[3][2][]',
Chris@245 74 :value => 'always',
Chris@0 75 :checked => nil }
Chris@0 76 # unused
Chris@0 77 assert_no_tag :tag => 'input', :attributes => { :type => 'checkbox',
Chris@245 78 :name => 'issue_status[1][1][]' }
Chris@0 79 end
Chris@909 80
Chris@0 81 def test_get_edit_with_role_and_tracker_and_all_statuses
Chris@1115 82 WorkflowTransition.delete_all
Chris@909 83
Chris@0 84 get :edit, :role_id => 2, :tracker_id => 1, :used_statuses_only => '0'
Chris@0 85 assert_response :success
Chris@0 86 assert_template 'edit'
Chris@909 87
Chris@0 88 assert_not_nil assigns(:statuses)
Chris@0 89 assert_equal IssueStatus.count, assigns(:statuses).size
Chris@909 90
Chris@0 91 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
Chris@245 92 :name => 'issue_status[1][1][]',
Chris@245 93 :value => 'always',
Chris@0 94 :checked => nil }
Chris@0 95 end
Chris@909 96
Chris@0 97 def test_post_edit
Chris@245 98 post :edit, :role_id => 2, :tracker_id => 1,
Chris@245 99 :issue_status => {
Chris@245 100 '4' => {'5' => ['always']},
Chris@245 101 '3' => {'1' => ['always'], '2' => ['always']}
Chris@245 102 }
Chris@0 103 assert_redirected_to '/workflows/edit?role_id=2&tracker_id=1'
Chris@909 104
Chris@1115 105 assert_equal 3, WorkflowTransition.count(:conditions => {:tracker_id => 1, :role_id => 2})
Chris@1115 106 assert_not_nil WorkflowTransition.find(:first, :conditions => {:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 2})
Chris@1115 107 assert_nil WorkflowTransition.find(:first, :conditions => {:role_id => 2, :tracker_id => 1, :old_status_id => 5, :new_status_id => 4})
Chris@0 108 end
Chris@909 109
Chris@245 110 def test_post_edit_with_additional_transitions
Chris@245 111 post :edit, :role_id => 2, :tracker_id => 1,
Chris@245 112 :issue_status => {
Chris@245 113 '4' => {'5' => ['always']},
Chris@245 114 '3' => {'1' => ['author'], '2' => ['assignee'], '4' => ['author', 'assignee']}
Chris@245 115 }
Chris@245 116 assert_redirected_to '/workflows/edit?role_id=2&tracker_id=1'
Chris@909 117
Chris@1115 118 assert_equal 4, WorkflowTransition.count(:conditions => {:tracker_id => 1, :role_id => 2})
Chris@909 119
Chris@1115 120 w = WorkflowTransition.find(:first, :conditions => {:role_id => 2, :tracker_id => 1, :old_status_id => 4, :new_status_id => 5})
Chris@245 121 assert ! w.author
Chris@245 122 assert ! w.assignee
Chris@1115 123 w = WorkflowTransition.find(:first, :conditions => {:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 1})
Chris@245 124 assert w.author
Chris@245 125 assert ! w.assignee
Chris@1115 126 w = WorkflowTransition.find(:first, :conditions => {:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 2})
Chris@245 127 assert ! w.author
Chris@245 128 assert w.assignee
Chris@1115 129 w = WorkflowTransition.find(:first, :conditions => {:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 4})
Chris@245 130 assert w.author
Chris@245 131 assert w.assignee
Chris@245 132 end
Chris@909 133
Chris@0 134 def test_clear_workflow
Chris@1115 135 assert WorkflowTransition.count(:conditions => {:tracker_id => 1, :role_id => 2}) > 0
Chris@0 136
Chris@0 137 post :edit, :role_id => 2, :tracker_id => 1
Chris@1115 138 assert_equal 0, WorkflowTransition.count(:conditions => {:tracker_id => 1, :role_id => 2})
Chris@1115 139 end
Chris@1115 140
Chris@1115 141 def test_get_permissions
Chris@1115 142 get :permissions
Chris@1115 143
Chris@1115 144 assert_response :success
Chris@1115 145 assert_template 'permissions'
Chris@1115 146 assert_not_nil assigns(:roles)
Chris@1115 147 assert_not_nil assigns(:trackers)
Chris@1115 148 end
Chris@1115 149
Chris@1115 150 def test_get_permissions_with_role_and_tracker
Chris@1115 151 WorkflowPermission.delete_all
Chris@1115 152 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :field_name => 'assigned_to_id', :rule => 'required')
Chris@1115 153 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :field_name => 'fixed_version_id', :rule => 'required')
Chris@1115 154 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 3, :field_name => 'fixed_version_id', :rule => 'readonly')
Chris@1115 155
Chris@1115 156 get :permissions, :role_id => 1, :tracker_id => 2
Chris@1115 157 assert_response :success
Chris@1115 158 assert_template 'permissions'
Chris@1115 159
Chris@1115 160 assert_select 'input[name=role_id][value=1]'
Chris@1115 161 assert_select 'input[name=tracker_id][value=2]'
Chris@1115 162
Chris@1115 163 # Required field
Chris@1115 164 assert_select 'select[name=?]', 'permissions[assigned_to_id][2]' do
Chris@1115 165 assert_select 'option[value=]'
Chris@1115 166 assert_select 'option[value=][selected=selected]', 0
Chris@1115 167 assert_select 'option[value=readonly]', :text => 'Read-only'
Chris@1115 168 assert_select 'option[value=readonly][selected=selected]', 0
Chris@1115 169 assert_select 'option[value=required]', :text => 'Required'
Chris@1115 170 assert_select 'option[value=required][selected=selected]'
Chris@1115 171 end
Chris@1115 172
Chris@1115 173 # Read-only field
Chris@1115 174 assert_select 'select[name=?]', 'permissions[fixed_version_id][3]' do
Chris@1115 175 assert_select 'option[value=]'
Chris@1115 176 assert_select 'option[value=][selected=selected]', 0
Chris@1115 177 assert_select 'option[value=readonly]', :text => 'Read-only'
Chris@1115 178 assert_select 'option[value=readonly][selected=selected]'
Chris@1115 179 assert_select 'option[value=required]', :text => 'Required'
Chris@1115 180 assert_select 'option[value=required][selected=selected]', 0
Chris@1115 181 end
Chris@1115 182
Chris@1115 183 # Other field
Chris@1115 184 assert_select 'select[name=?]', 'permissions[due_date][3]' do
Chris@1115 185 assert_select 'option[value=]'
Chris@1115 186 assert_select 'option[value=][selected=selected]', 0
Chris@1115 187 assert_select 'option[value=readonly]', :text => 'Read-only'
Chris@1115 188 assert_select 'option[value=readonly][selected=selected]', 0
Chris@1115 189 assert_select 'option[value=required]', :text => 'Required'
Chris@1115 190 assert_select 'option[value=required][selected=selected]', 0
Chris@1115 191 end
Chris@1115 192 end
Chris@1115 193
Chris@1115 194 def test_get_permissions_with_required_custom_field_should_not_show_required_option
Chris@1115 195 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :tracker_ids => [1], :is_required => true)
Chris@1115 196
Chris@1115 197 get :permissions, :role_id => 1, :tracker_id => 1
Chris@1115 198 assert_response :success
Chris@1115 199 assert_template 'permissions'
Chris@1115 200
Chris@1115 201 # Custom field that is always required
Chris@1115 202 # The default option is "(Required)"
Chris@1115 203 assert_select 'select[name=?]', "permissions[#{cf.id}][3]" do
Chris@1115 204 assert_select 'option[value=]'
Chris@1115 205 assert_select 'option[value=readonly]', :text => 'Read-only'
Chris@1115 206 assert_select 'option[value=required]', 0
Chris@1115 207 end
Chris@1115 208 end
Chris@1115 209
Chris@1115 210 def test_get_permissions_with_role_and_tracker_and_all_statuses
Chris@1115 211 WorkflowTransition.delete_all
Chris@1115 212
Chris@1115 213 get :permissions, :role_id => 1, :tracker_id => 2, :used_statuses_only => '0'
Chris@1115 214 assert_response :success
Chris@1115 215 assert_equal IssueStatus.sorted.all, assigns(:statuses)
Chris@1115 216 end
Chris@1115 217
Chris@1115 218 def test_post_permissions
Chris@1115 219 WorkflowPermission.delete_all
Chris@1115 220
Chris@1115 221 post :permissions, :role_id => 1, :tracker_id => 2, :permissions => {
Chris@1115 222 'assigned_to_id' => {'1' => '', '2' => 'readonly', '3' => ''},
Chris@1115 223 'fixed_version_id' => {'1' => 'required', '2' => 'readonly', '3' => ''},
Chris@1115 224 'due_date' => {'1' => '', '2' => '', '3' => ''},
Chris@1115 225 }
Chris@1115 226 assert_redirected_to '/workflows/permissions?role_id=1&tracker_id=2'
Chris@1115 227
Chris@1115 228 workflows = WorkflowPermission.all
Chris@1115 229 assert_equal 3, workflows.size
Chris@1115 230 workflows.each do |workflow|
Chris@1115 231 assert_equal 1, workflow.role_id
Chris@1115 232 assert_equal 2, workflow.tracker_id
Chris@1115 233 end
Chris@1115 234 assert workflows.detect {|wf| wf.old_status_id == 2 && wf.field_name == 'assigned_to_id' && wf.rule == 'readonly'}
Chris@1115 235 assert workflows.detect {|wf| wf.old_status_id == 1 && wf.field_name == 'fixed_version_id' && wf.rule == 'required'}
Chris@1115 236 assert workflows.detect {|wf| wf.old_status_id == 2 && wf.field_name == 'fixed_version_id' && wf.rule == 'readonly'}
Chris@1115 237 end
Chris@1115 238
Chris@1115 239 def test_post_permissions_should_clear_permissions
Chris@1115 240 WorkflowPermission.delete_all
Chris@1115 241 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :field_name => 'assigned_to_id', :rule => 'required')
Chris@1115 242 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :field_name => 'fixed_version_id', :rule => 'required')
Chris@1115 243 wf1 = WorkflowPermission.create!(:role_id => 1, :tracker_id => 3, :old_status_id => 2, :field_name => 'fixed_version_id', :rule => 'required')
Chris@1115 244 wf2 = WorkflowPermission.create!(:role_id => 2, :tracker_id => 2, :old_status_id => 3, :field_name => 'fixed_version_id', :rule => 'readonly')
Chris@1115 245
Chris@1115 246 post :permissions, :role_id => 1, :tracker_id => 2
Chris@1115 247 assert_redirected_to '/workflows/permissions?role_id=1&tracker_id=2'
Chris@1115 248
Chris@1115 249 workflows = WorkflowPermission.all
Chris@1115 250 assert_equal 2, workflows.size
Chris@1115 251 assert wf1.reload
Chris@1115 252 assert wf2.reload
Chris@0 253 end
Chris@909 254
Chris@0 255 def test_get_copy
Chris@0 256 get :copy
Chris@0 257 assert_response :success
Chris@0 258 assert_template 'copy'
Chris@1115 259 assert_select 'select[name=source_tracker_id]' do
Chris@1115 260 assert_select 'option[value=1]', :text => 'Bug'
Chris@1115 261 end
Chris@1115 262 assert_select 'select[name=source_role_id]' do
Chris@1115 263 assert_select 'option[value=2]', :text => 'Developer'
Chris@1115 264 end
Chris@1115 265 assert_select 'select[name=?]', 'target_tracker_ids[]' do
Chris@1115 266 assert_select 'option[value=3]', :text => 'Support request'
Chris@1115 267 end
Chris@1115 268 assert_select 'select[name=?]', 'target_role_ids[]' do
Chris@1115 269 assert_select 'option[value=1]', :text => 'Manager'
Chris@1115 270 end
Chris@0 271 end
Chris@909 272
Chris@0 273 def test_post_copy_one_to_one
Chris@0 274 source_transitions = status_transitions(:tracker_id => 1, :role_id => 2)
Chris@909 275
Chris@0 276 post :copy, :source_tracker_id => '1', :source_role_id => '2',
Chris@0 277 :target_tracker_ids => ['3'], :target_role_ids => ['1']
Chris@0 278 assert_response 302
Chris@0 279 assert_equal source_transitions, status_transitions(:tracker_id => 3, :role_id => 1)
Chris@0 280 end
Chris@909 281
Chris@0 282 def test_post_copy_one_to_many
Chris@0 283 source_transitions = status_transitions(:tracker_id => 1, :role_id => 2)
Chris@909 284
Chris@0 285 post :copy, :source_tracker_id => '1', :source_role_id => '2',
Chris@0 286 :target_tracker_ids => ['2', '3'], :target_role_ids => ['1', '3']
Chris@0 287 assert_response 302
Chris@0 288 assert_equal source_transitions, status_transitions(:tracker_id => 2, :role_id => 1)
Chris@0 289 assert_equal source_transitions, status_transitions(:tracker_id => 3, :role_id => 1)
Chris@0 290 assert_equal source_transitions, status_transitions(:tracker_id => 2, :role_id => 3)
Chris@0 291 assert_equal source_transitions, status_transitions(:tracker_id => 3, :role_id => 3)
Chris@0 292 end
Chris@909 293
Chris@0 294 def test_post_copy_many_to_many
Chris@0 295 source_t2 = status_transitions(:tracker_id => 2, :role_id => 2)
Chris@0 296 source_t3 = status_transitions(:tracker_id => 3, :role_id => 2)
Chris@909 297
Chris@0 298 post :copy, :source_tracker_id => 'any', :source_role_id => '2',
Chris@0 299 :target_tracker_ids => ['2', '3'], :target_role_ids => ['1', '3']
Chris@0 300 assert_response 302
Chris@0 301 assert_equal source_t2, status_transitions(:tracker_id => 2, :role_id => 1)
Chris@0 302 assert_equal source_t3, status_transitions(:tracker_id => 3, :role_id => 1)
Chris@0 303 assert_equal source_t2, status_transitions(:tracker_id => 2, :role_id => 3)
Chris@0 304 assert_equal source_t3, status_transitions(:tracker_id => 3, :role_id => 3)
Chris@0 305 end
Chris@909 306
Chris@0 307 # Returns an array of status transitions that can be compared
Chris@0 308 def status_transitions(conditions)
Chris@1115 309 WorkflowTransition.find(:all, :conditions => conditions,
Chris@0 310 :order => 'tracker_id, role_id, old_status_id, new_status_id').collect {|w| [w.old_status, w.new_status_id]}
Chris@0 311 end
Chris@0 312 end