annotate app/controllers/issues_controller.rb @ 853:969bb872d4bf feature_142

Close obsolete branch feature_142
author Chris Cannam
date Thu, 14 Jul 2011 14:26:44 +0100
parents 753f1380d6bc
children eef2e2ed53c9
rev   line source
Chris@0 1 # Redmine - project management software
Chris@441 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
Chris@0 3 #
Chris@0 4 # This program is free software; you can redistribute it and/or
Chris@0 5 # modify it under the terms of the GNU General Public License
Chris@0 6 # as published by the Free Software Foundation; either version 2
Chris@0 7 # of the License, or (at your option) any later version.
Chris@441 8 #
Chris@0 9 # This program is distributed in the hope that it will be useful,
Chris@0 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@0 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@0 12 # GNU General Public License for more details.
Chris@441 13 #
Chris@0 14 # You should have received a copy of the GNU General Public License
Chris@0 15 # along with this program; if not, write to the Free Software
Chris@0 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@0 17
Chris@0 18 class IssuesController < ApplicationController
Chris@0 19 menu_item :new_issue, :only => [:new, :create]
Chris@0 20 default_search_scope :issues
Chris@441 21
Chris@14 22 before_filter :find_issue, :only => [:show, :edit, :update]
Chris@14 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]
chris@37 24 before_filter :check_project_uniqueness, :only => [:move, :perform_move]
Chris@14 25 before_filter :find_project, :only => [:new, :create]
Chris@14 26 before_filter :authorize, :except => [:index]
Chris@14 27 before_filter :find_optional_project, :only => [:index]
Chris@0 28 before_filter :check_for_default_issue_status, :only => [:new, :create]
Chris@0 29 before_filter :build_new_issue_from_params, :only => [:new, :create]
chris@37 30 accept_key_auth :index, :show, :create, :update, :destroy
Chris@0 31
Chris@0 32 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
Chris@441 33
Chris@0 34 helper :journals
Chris@0 35 helper :projects
Chris@441 36 include ProjectsHelper
Chris@0 37 helper :custom_fields
Chris@0 38 include CustomFieldsHelper
Chris@0 39 helper :issue_relations
Chris@0 40 include IssueRelationsHelper
Chris@0 41 helper :watchers
Chris@0 42 include WatchersHelper
Chris@0 43 helper :attachments
Chris@0 44 include AttachmentsHelper
Chris@0 45 helper :queries
Chris@0 46 include QueriesHelper
Chris@117 47 helper :repositories
Chris@117 48 include RepositoriesHelper
Chris@0 49 helper :sort
Chris@0 50 include SortHelper
Chris@0 51 include IssuesHelper
Chris@0 52 helper :timelog
chris@22 53 helper :gantt
Chris@0 54 include Redmine::Export::PDF
Chris@0 55
Chris@0 56 verify :method => [:post, :delete],
Chris@0 57 :only => :destroy,
Chris@0 58 :render => { :nothing => true, :status => :method_not_allowed }
Chris@0 59
Chris@0 60 verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }
Chris@14 61 verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }
Chris@0 62 verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
Chris@441 63
Chris@0 64 def index
Chris@0 65 retrieve_query
Chris@0 66 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
Chris@0 67 sort_update(@query.sortable_columns)
Chris@441 68
Chris@0 69 if @query.valid?
Chris@117 70 case params[:format]
Chris@0 71 when 'csv', 'pdf'
Chris@117 72 @limit = Setting.issues_export_limit.to_i
Chris@0 73 when 'atom'
Chris@117 74 @limit = Setting.feeds_limit.to_i
Chris@117 75 when 'xml', 'json'
Chris@117 76 @offset, @limit = api_offset_and_limit
Chris@0 77 else
Chris@117 78 @limit = per_page_option
Chris@0 79 end
Chris@441 80
Chris@0 81 @issue_count = @query.issue_count
Chris@117 82 @issue_pages = Paginator.new self, @issue_count, @limit, params['page']
Chris@117 83 @offset ||= @issue_pages.current.offset
Chris@0 84 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
Chris@441 85 :order => sort_clause,
Chris@441 86 :offset => @offset,
Chris@117 87 :limit => @limit)
Chris@0 88 @issue_count_by_group = @query.issue_count_by_group
Chris@441 89
Chris@0 90 respond_to do |format|
Chris@0 91 format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }
Chris@117 92 format.api
Chris@0 93 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
Chris@0 94 format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }
Chris@0 95 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
Chris@0 96 end
Chris@0 97 else
Chris@0 98 # Send html if the query is not valid
Chris@0 99 render(:template => 'issues/index.rhtml', :layout => !request.xhr?)
Chris@0 100 end
Chris@0 101 rescue ActiveRecord::RecordNotFound
Chris@0 102 render_404
Chris@0 103 end
Chris@441 104
Chris@0 105 def show
Chris@0 106 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
Chris@0 107 @journals.each_with_index {|j,i| j.indice = i+1}
Chris@0 108 @journals.reverse! if User.current.wants_comments_in_reverse_order?
Chris@441 109
Chris@441 110 if User.current.allowed_to?(:view_changesets, @project)
Chris@441 111 @changesets = @issue.changesets.visible.all
Chris@441 112 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
Chris@441 113 end
Chris@441 114
Chris@210 115 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
Chris@0 116 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
Chris@0 117 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
Chris@0 118 @priorities = IssuePriority.all
Chris@441 119 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
Chris@0 120 respond_to do |format|
Chris@0 121 format.html { render :template => 'issues/show.rhtml' }
Chris@117 122 format.api
Chris@14 123 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
Chris@0 124 format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
Chris@0 125 end
Chris@0 126 end
Chris@0 127
Chris@0 128 # Add a new issue
Chris@0 129 # The new issue will be created from an existing one if copy_from parameter is given
Chris@0 130 def new
Chris@14 131 respond_to do |format|
Chris@14 132 format.html { render :action => 'new', :layout => !request.xhr? }
Chris@14 133 format.js { render :partial => 'attributes' }
Chris@14 134 end
Chris@0 135 end
Chris@0 136
Chris@0 137 def create
Chris@0 138 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
Chris@0 139 if @issue.save
Chris@0 140 attachments = Attachment.attach_files(@issue, params[:attachments])
Chris@0 141 render_attachment_warning_if_needed(@issue)
Chris@0 142 flash[:notice] = l(:notice_successful_create)
luisf@70 143
Chris@0 144 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
luisf@70 145
luisf@71 146 # Also adds the assignee to the watcher's list
luisf@141 147 if params[:issue][:assigned_to_id] && !params[:issue][:assigned_to_id].empty?:
luisf@141 148 unless @issue.watcher_ids.include?(params[:issue][:assigned_to_id]):
luisf@141 149 @issue.add_watcher(User.find(params[:issue][:assigned_to_id]))
luisf@141 150 end
luisf@141 151 end
luisf@71 152
Chris@0 153 respond_to do |format|
Chris@0 154 format.html {
chris@22 155 redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
Chris@0 156 { :action => 'show', :id => @issue })
Chris@0 157 }
Chris@117 158 format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }
Chris@0 159 end
Chris@0 160 return
Chris@0 161 else
Chris@0 162 respond_to do |format|
Chris@0 163 format.html { render :action => 'new' }
Chris@117 164 format.api { render_validation_errors(@issue) }
Chris@0 165 end
Chris@0 166 end
Chris@0 167 end
Chris@441 168
Chris@0 169 def edit
Chris@0 170 update_issue_from_params
Chris@0 171
Chris@0 172 @journal = @issue.current_journal
Chris@0 173
Chris@0 174 respond_to do |format|
Chris@0 175 format.html { }
Chris@0 176 format.xml { }
Chris@0 177 end
Chris@0 178 end
Chris@0 179
Chris@0 180 def update
Chris@0 181 update_issue_from_params
Chris@0 182
Chris@0 183 if @issue.save_issue_with_child_records(params, @time_entry)
Chris@0 184 render_attachment_warning_if_needed(@issue)
Chris@0 185 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
Chris@0 186
Chris@0 187 respond_to do |format|
Chris@0 188 format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
Chris@117 189 format.api { head :ok }
Chris@0 190 end
Chris@0 191 else
Chris@0 192 render_attachment_warning_if_needed(@issue)
Chris@0 193 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
Chris@0 194 @journal = @issue.current_journal
Chris@0 195
Chris@0 196 respond_to do |format|
Chris@0 197 format.html { render :action => 'edit' }
Chris@117 198 format.api { render_validation_errors(@issue) }
Chris@0 199 end
Chris@0 200 end
Chris@0 201 end
Chris@0 202
Chris@0 203 # Bulk edit a set of issues
Chris@0 204 def bulk_edit
Chris@0 205 @issues.sort!
chris@37 206 @available_statuses = @projects.map{|p|Workflow.available_statuses(p)}.inject{|memo,w|memo & w}
chris@37 207 @custom_fields = @projects.map{|p|p.all_issue_custom_fields}.inject{|memo,c|memo & c}
chris@37 208 @assignables = @projects.map(&:assignable_users).inject{|memo,a| memo & a}
chris@37 209 @trackers = @projects.map(&:trackers).inject{|memo,t| memo & t}
Chris@0 210 end
Chris@0 211
Chris@14 212 def bulk_update
Chris@0 213 @issues.sort!
Chris@14 214 attributes = parse_params_for_bulk_issue_attributes(params)
Chris@14 215
Chris@14 216 unsaved_issue_ids = []
Chris@14 217 @issues.each do |issue|
Chris@14 218 issue.reload
Chris@14 219 journal = issue.init_journal(User.current, params[:notes])
Chris@14 220 issue.safe_attributes = attributes
Chris@14 221 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
Chris@14 222 unless issue.save
Chris@14 223 # Keep unsaved issue ids to display them in flash error
Chris@14 224 unsaved_issue_ids << issue.id
Chris@0 225 end
Chris@0 226 end
Chris@14 227 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
Chris@14 228 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
Chris@0 229 end
Chris@441 230
Chris@0 231 def destroy
Chris@0 232 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
Chris@0 233 if @hours > 0
Chris@0 234 case params[:todo]
Chris@0 235 when 'destroy'
Chris@0 236 # nothing to do
Chris@0 237 when 'nullify'
Chris@0 238 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
Chris@0 239 when 'reassign'
Chris@0 240 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
Chris@0 241 if reassign_to.nil?
Chris@0 242 flash.now[:error] = l(:error_issue_not_found_in_project)
Chris@0 243 return
Chris@0 244 else
Chris@0 245 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
Chris@0 246 end
Chris@0 247 else
Chris@117 248 # display the destroy form if it's a user request
Chris@117 249 return unless api_request?
Chris@0 250 end
Chris@0 251 end
Chris@441 252 @issues.each do |issue|
Chris@441 253 begin
Chris@441 254 issue.reload.destroy
Chris@441 255 rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
Chris@441 256 # nothing to do, issue was already deleted (eg. by a parent)
Chris@441 257 end
Chris@441 258 end
Chris@0 259 respond_to do |format|
chris@37 260 format.html { redirect_back_or_default(:action => 'index', :project_id => @project) }
Chris@117 261 format.api { head :ok }
Chris@0 262 end
Chris@0 263 end
Chris@0 264
Chris@0 265 private
Chris@0 266 def find_issue
Chris@441 267 # Issue.visible.find(...) can not be used to redirect user to the login form
Chris@441 268 # if the issue actually exists but requires authentication
Chris@0 269 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
Chris@441 270 unless @issue.visible?
Chris@441 271 deny_access
Chris@441 272 return
Chris@441 273 end
Chris@0 274 @project = @issue.project
Chris@0 275 rescue ActiveRecord::RecordNotFound
Chris@0 276 render_404
Chris@0 277 end
Chris@441 278
Chris@0 279 def find_project
Chris@0 280 project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]
Chris@0 281 @project = Project.find(project_id)
Chris@0 282 rescue ActiveRecord::RecordNotFound
Chris@0 283 render_404
Chris@0 284 end
Chris@441 285
Chris@0 286 # Used by #edit and #update to set some common instance variables
Chris@0 287 # from the params
Chris@0 288 # TODO: Refactor, not everything in here is needed by #edit
Chris@0 289 def update_issue_from_params
Chris@0 290 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
Chris@0 291 @priorities = IssuePriority.all
Chris@0 292 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
Chris@441 293 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
chris@37 294 @time_entry.attributes = params[:time_entry]
Chris@441 295
chris@22 296 @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)
Chris@0 297 @issue.init_journal(User.current, @notes)
chris@37 298 @issue.safe_attributes = params[:issue]
luisf@71 299
luisf@71 300 # tests if the the user assigned_to_id
luisf@71 301 # is in this issues watcher's list
luisf@71 302 # if not, adds it.
luisf@71 303
luisf@141 304 if params[:issue][:assigned_to_id] && !params[:issue][:assigned_to_id].empty?:
luisf@141 305 unless @issue.watched_by?(User.find(params[:issue][:assigned_to_id])):
luisf@141 306 @issue.add_watcher(User.find(params[:issue][:assigned_to_id]))
luisf@141 307 end
luisf@141 308 end
luisf@71 309
luisf@71 310
Chris@0 311 end
Chris@0 312
Chris@0 313 # TODO: Refactor, lots of extra code in here
chris@37 314 # TODO: Changing tracker on an existing issue should not trigger this
Chris@0 315 def build_new_issue_from_params
Chris@14 316 if params[:id].blank?
Chris@14 317 @issue = Issue.new
Chris@14 318 @issue.copy_from(params[:copy_from]) if params[:copy_from]
Chris@14 319 @issue.project = @project
Chris@14 320 else
Chris@14 321 @issue = @project.issues.visible.find(params[:id])
Chris@14 322 end
Chris@441 323
Chris@0 324 @issue.project = @project
Chris@0 325 # Tracker must be set before custom field values
Chris@0 326 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
Chris@0 327 if @issue.tracker.nil?
Chris@0 328 render_error l(:error_no_tracker_in_project)
Chris@0 329 return false
Chris@0 330 end
chris@37 331 @issue.start_date ||= Date.today
Chris@0 332 if params[:issue].is_a?(Hash)
Chris@0 333 @issue.safe_attributes = params[:issue]
chris@37 334 if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record?
chris@37 335 @issue.watcher_user_ids = params[:issue]['watcher_user_ids']
chris@37 336 end
Chris@0 337 end
Chris@0 338 @issue.author = User.current
Chris@0 339 @priorities = IssuePriority.all
Chris@0 340 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
Chris@0 341 end
Chris@0 342
Chris@0 343 def check_for_default_issue_status
Chris@0 344 if IssueStatus.default.nil?
Chris@0 345 render_error l(:error_no_default_issue_status)
Chris@0 346 return false
Chris@0 347 end
Chris@0 348 end
Chris@14 349
Chris@14 350 def parse_params_for_bulk_issue_attributes(params)
Chris@14 351 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
Chris@14 352 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
Chris@14 353 attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
Chris@14 354 attributes
Chris@14 355 end
Chris@0 356 end