annotate test/functional/users_controller_test.rb @ 1600:ed9c467ef922 dockerise

Add hggit extension
author Chris Cannam
date Wed, 23 Aug 2017 11:32:50 +0100
parents dffacf8a6908
children
rev   line source
Chris@441 1 # Redmine - project management software
Chris@1494 2 # Copyright (C) 2006-2014 Jean-Philippe Lang
Chris@0 3 #
Chris@0 4 # This program is free software; you can redistribute it and/or
Chris@0 5 # modify it under the terms of the GNU General Public License
Chris@0 6 # as published by the Free Software Foundation; either version 2
Chris@0 7 # of the License, or (at your option) any later version.
Chris@909 8 #
Chris@0 9 # This program is distributed in the hope that it will be useful,
Chris@0 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@0 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@0 12 # GNU General Public License for more details.
Chris@909 13 #
Chris@0 14 # You should have received a copy of the GNU General Public License
Chris@0 15 # along with this program; if not, write to the Free Software
Chris@0 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@0 17
Chris@119 18 require File.expand_path('../../test_helper', __FILE__)
Chris@0 19
Chris@0 20 class UsersControllerTest < ActionController::TestCase
Chris@0 21 include Redmine::I18n
Chris@909 22
Chris@1115 23 fixtures :users, :projects, :members, :member_roles, :roles,
Chris@1115 24 :custom_fields, :custom_values, :groups_users,
Chris@1115 25 :auth_sources
Chris@909 26
Chris@0 27 def setup
Chris@0 28 User.current = nil
Chris@0 29 @request.session[:user_id] = 1 # admin
Chris@0 30 end
Chris@909 31
Chris@0 32 def test_index
Chris@0 33 get :index
Chris@0 34 assert_response :success
Chris@0 35 assert_template 'index'
Chris@0 36 assert_not_nil assigns(:users)
Chris@0 37 # active users only
Chris@0 38 assert_nil assigns(:users).detect {|u| !u.active?}
Chris@0 39 end
Chris@909 40
Chris@1115 41 def test_index_with_status_filter
Chris@1115 42 get :index, :status => 3
Chris@1115 43 assert_response :success
Chris@1115 44 assert_template 'index'
Chris@1115 45 assert_not_nil assigns(:users)
Chris@1115 46 assert_equal [3], assigns(:users).map(&:status).uniq
Chris@1115 47 end
Chris@1115 48
Chris@0 49 def test_index_with_name_filter
Chris@0 50 get :index, :name => 'john'
Chris@0 51 assert_response :success
Chris@0 52 assert_template 'index'
Chris@0 53 users = assigns(:users)
Chris@0 54 assert_not_nil users
Chris@0 55 assert_equal 1, users.size
Chris@0 56 assert_equal 'John', users.first.firstname
Chris@0 57 end
Chris@909 58
Chris@441 59 def test_index_with_group_filter
Chris@441 60 get :index, :group_id => '10'
Chris@441 61 assert_response :success
Chris@441 62 assert_template 'index'
Chris@441 63 users = assigns(:users)
Chris@441 64 assert users.any?
Chris@441 65 assert_equal([], (users - Group.find(10).users))
Chris@1115 66 assert_select 'select[name=group_id]' do
Chris@1115 67 assert_select 'option[value=10][selected=selected]'
Chris@1115 68 end
Chris@441 69 end
Chris@909 70
Chris@0 71 def test_show
Chris@0 72 @request.session[:user_id] = nil
Chris@0 73 get :show, :id => 2
Chris@0 74 assert_response :success
Chris@0 75 assert_template 'show'
Chris@0 76 assert_not_nil assigns(:user)
Chris@909 77
chris@37 78 assert_tag 'li', :content => /Phone number/
chris@37 79 end
Chris@909 80
chris@37 81 def test_show_should_not_display_hidden_custom_fields
chris@37 82 @request.session[:user_id] = nil
chris@37 83 UserCustomField.find_by_name('Phone number').update_attribute :visible, false
chris@37 84 get :show, :id => 2
chris@37 85 assert_response :success
chris@37 86 assert_template 'show'
chris@37 87 assert_not_nil assigns(:user)
Chris@909 88
chris@37 89 assert_no_tag 'li', :content => /Phone number/
Chris@0 90 end
Chris@0 91
Chris@0 92 def test_show_should_not_fail_when_custom_values_are_nil
Chris@0 93 user = User.find(2)
Chris@0 94
Chris@0 95 # Create a custom field to illustrate the issue
Chris@0 96 custom_field = CustomField.create!(:name => 'Testing', :field_format => 'text')
Chris@0 97 custom_value = user.custom_values.build(:custom_field => custom_field).save!
Chris@0 98
Chris@0 99 get :show, :id => 2
Chris@0 100 assert_response :success
Chris@0 101 end
Chris@0 102
Chris@0 103 def test_show_inactive
Chris@0 104 @request.session[:user_id] = nil
Chris@0 105 get :show, :id => 5
Chris@0 106 assert_response 404
Chris@0 107 end
Chris@909 108
Chris@0 109 def test_show_should_not_reveal_users_with_no_visible_activity_or_project
Chris@0 110 @request.session[:user_id] = nil
Chris@0 111 get :show, :id => 9
Chris@0 112 assert_response 404
Chris@0 113 end
Chris@909 114
Chris@0 115 def test_show_inactive_by_admin
Chris@0 116 @request.session[:user_id] = 1
Chris@0 117 get :show, :id => 5
Chris@0 118 assert_response 200
Chris@0 119 assert_not_nil assigns(:user)
Chris@0 120 end
Chris@909 121
Chris@14 122 def test_show_displays_memberships_based_on_project_visibility
Chris@14 123 @request.session[:user_id] = 1
Chris@14 124 get :show, :id => 2
Chris@14 125 assert_response :success
Chris@14 126 memberships = assigns(:memberships)
Chris@14 127 assert_not_nil memberships
Chris@14 128 project_ids = memberships.map(&:project_id)
Chris@14 129 assert project_ids.include?(2) #private project admin can see
Chris@14 130 end
Chris@909 131
Chris@119 132 def test_show_current_should_require_authentication
Chris@119 133 @request.session[:user_id] = nil
Chris@119 134 get :show, :id => 'current'
Chris@119 135 assert_response 302
Chris@119 136 end
Chris@909 137
Chris@119 138 def test_show_current
Chris@119 139 @request.session[:user_id] = 2
Chris@119 140 get :show, :id => 'current'
Chris@119 141 assert_response :success
Chris@119 142 assert_template 'show'
Chris@119 143 assert_equal User.find(2), assigns(:user)
Chris@119 144 end
Chris@909 145
Chris@119 146 def test_new
Chris@119 147 get :new
Chris@119 148 assert_response :success
Chris@119 149 assert_template :new
Chris@119 150 assert assigns(:user)
Chris@119 151 end
Chris@909 152
Chris@119 153 def test_create
Chris@119 154 Setting.bcc_recipients = '1'
Chris@909 155
Chris@119 156 assert_difference 'User.count' do
Chris@119 157 assert_difference 'ActionMailer::Base.deliveries.size' do
Chris@119 158 post :create,
Chris@119 159 :user => {
Chris@119 160 :firstname => 'John',
Chris@119 161 :lastname => 'Doe',
Chris@119 162 :login => 'jdoe',
Chris@1115 163 :password => 'secret123',
Chris@1115 164 :password_confirmation => 'secret123',
Chris@119 165 :mail => 'jdoe@gmail.com',
Chris@119 166 :mail_notification => 'none'
Chris@119 167 },
Chris@119 168 :send_information => '1'
Chris@119 169 end
chris@37 170 end
Chris@909 171
Chris@1517 172 user = User.order('id DESC').first
Chris@119 173 assert_redirected_to :controller => 'users', :action => 'edit', :id => user.id
Chris@909 174
Chris@119 175 assert_equal 'John', user.firstname
Chris@119 176 assert_equal 'Doe', user.lastname
Chris@119 177 assert_equal 'jdoe', user.login
Chris@119 178 assert_equal 'jdoe@gmail.com', user.mail
Chris@119 179 assert_equal 'none', user.mail_notification
Chris@1115 180 assert user.check_password?('secret123')
Chris@909 181
Chris@119 182 mail = ActionMailer::Base.deliveries.last
Chris@119 183 assert_not_nil mail
Chris@119 184 assert_equal [user.mail], mail.bcc
Chris@1115 185 assert_mail_body_match 'secret', mail
Chris@1115 186 end
Chris@1115 187
Chris@1115 188 def test_create_with_preferences
Chris@1115 189 assert_difference 'User.count' do
Chris@1115 190 post :create,
Chris@1115 191 :user => {
Chris@1115 192 :firstname => 'John',
Chris@1115 193 :lastname => 'Doe',
Chris@1115 194 :login => 'jdoe',
Chris@1115 195 :password => 'secret123',
Chris@1115 196 :password_confirmation => 'secret123',
Chris@1115 197 :mail => 'jdoe@gmail.com',
Chris@1115 198 :mail_notification => 'none'
Chris@1115 199 },
Chris@1115 200 :pref => {
Chris@1115 201 'hide_mail' => '1',
Chris@1115 202 'time_zone' => 'Paris',
Chris@1115 203 'comments_sorting' => 'desc',
Chris@1115 204 'warn_on_leaving_unsaved' => '0'
Chris@1115 205 }
Chris@1115 206 end
Chris@1517 207 user = User.order('id DESC').first
Chris@1115 208 assert_equal 'jdoe', user.login
Chris@1115 209 assert_equal true, user.pref.hide_mail
Chris@1115 210 assert_equal 'Paris', user.pref.time_zone
Chris@1115 211 assert_equal 'desc', user.pref[:comments_sorting]
Chris@1115 212 assert_equal '0', user.pref[:warn_on_leaving_unsaved]
Chris@119 213 end
Chris@909 214
Chris@1464 215 def test_create_with_generate_password_should_email_the_password
Chris@1464 216 assert_difference 'User.count' do
Chris@1464 217 post :create, :user => {
Chris@1464 218 :login => 'randompass',
Chris@1464 219 :firstname => 'Random',
Chris@1464 220 :lastname => 'Pass',
Chris@1464 221 :mail => 'randompass@example.net',
Chris@1464 222 :language => 'en',
Chris@1464 223 :generate_password => '1',
Chris@1464 224 :password => '',
Chris@1464 225 :password_confirmation => ''
Chris@1464 226 }, :send_information => 1
Chris@1464 227 end
Chris@1464 228 user = User.order('id DESC').first
Chris@1464 229 assert_equal 'randompass', user.login
Chris@1464 230
Chris@1464 231 mail = ActionMailer::Base.deliveries.last
Chris@1464 232 assert_not_nil mail
Chris@1464 233 m = mail_body(mail).match(/Password: ([a-zA-Z0-9]+)/)
Chris@1464 234 assert m
Chris@1464 235 password = m[1]
Chris@1464 236 assert user.check_password?(password)
Chris@1464 237 end
Chris@1464 238
Chris@119 239 def test_create_with_failure
Chris@119 240 assert_no_difference 'User.count' do
Chris@119 241 post :create, :user => {}
Chris@119 242 end
Chris@119 243 assert_response :success
Chris@119 244 assert_template 'new'
chris@37 245 end
chris@37 246
Chris@1517 247 def test_create_with_failure_sould_preserve_preference
Chris@1517 248 assert_no_difference 'User.count' do
Chris@1517 249 post :create,
Chris@1517 250 :user => {},
Chris@1517 251 :pref => {
Chris@1517 252 'no_self_notified' => '1',
Chris@1517 253 'hide_mail' => '1',
Chris@1517 254 'time_zone' => 'Paris',
Chris@1517 255 'comments_sorting' => 'desc',
Chris@1517 256 'warn_on_leaving_unsaved' => '0'
Chris@1517 257 }
Chris@1517 258 end
Chris@1517 259 assert_response :success
Chris@1517 260 assert_template 'new'
Chris@1517 261
Chris@1517 262 assert_select 'select#pref_time_zone option[selected=selected]', :text => /Paris/
Chris@1517 263 assert_select 'input#pref_no_self_notified[value=1][checked=checked]'
Chris@1517 264 end
Chris@1517 265
Chris@119 266 def test_edit
Chris@119 267 get :edit, :id => 2
Chris@119 268 assert_response :success
Chris@119 269 assert_template 'edit'
Chris@119 270 assert_equal User.find(2), assigns(:user)
chris@37 271 end
chris@37 272
chris@37 273 def test_update
Chris@0 274 ActionMailer::Base.deliveries.clear
Chris@1115 275 put :update, :id => 2,
Chris@1115 276 :user => {:firstname => 'Changed', :mail_notification => 'only_assigned'},
Chris@1115 277 :pref => {:hide_mail => '1', :comments_sorting => 'desc'}
chris@37 278 user = User.find(2)
chris@37 279 assert_equal 'Changed', user.firstname
Chris@119 280 assert_equal 'only_assigned', user.mail_notification
chris@37 281 assert_equal true, user.pref[:hide_mail]
chris@37 282 assert_equal 'desc', user.pref[:comments_sorting]
Chris@0 283 assert ActionMailer::Base.deliveries.empty?
Chris@0 284 end
Chris@119 285
Chris@119 286 def test_update_with_failure
Chris@119 287 assert_no_difference 'User.count' do
Chris@119 288 put :update, :id => 2, :user => {:firstname => ''}
Chris@119 289 end
Chris@119 290 assert_response :success
Chris@119 291 assert_template 'edit'
Chris@119 292 end
Chris@909 293
Chris@119 294 def test_update_with_group_ids_should_assign_groups
Chris@119 295 put :update, :id => 2, :user => {:group_ids => ['10']}
Chris@119 296 user = User.find(2)
Chris@119 297 assert_equal [10], user.group_ids
Chris@119 298 end
Chris@909 299
chris@37 300 def test_update_with_activation_should_send_a_notification
Chris@0 301 u = User.new(:firstname => 'Foo', :lastname => 'Bar', :mail => 'foo.bar@somenet.foo', :language => 'fr')
Chris@0 302 u.login = 'foo'
Chris@0 303 u.status = User::STATUS_REGISTERED
Chris@0 304 u.save!
Chris@0 305 ActionMailer::Base.deliveries.clear
Chris@0 306 Setting.bcc_recipients = '1'
Chris@909 307
chris@37 308 put :update, :id => u.id, :user => {:status => User::STATUS_ACTIVE}
Chris@0 309 assert u.reload.active?
Chris@0 310 mail = ActionMailer::Base.deliveries.last
Chris@0 311 assert_not_nil mail
Chris@0 312 assert_equal ['foo.bar@somenet.foo'], mail.bcc
Chris@1115 313 assert_mail_body_match ll('fr', :notice_account_activated), mail
Chris@0 314 end
Chris@909 315
Chris@119 316 def test_update_with_password_change_should_send_a_notification
Chris@0 317 ActionMailer::Base.deliveries.clear
Chris@0 318 Setting.bcc_recipients = '1'
Chris@909 319
Chris@1115 320 put :update, :id => 2, :user => {:password => 'newpass123', :password_confirmation => 'newpass123'}, :send_information => '1'
Chris@0 321 u = User.find(2)
Chris@1115 322 assert u.check_password?('newpass123')
Chris@909 323
Chris@0 324 mail = ActionMailer::Base.deliveries.last
Chris@0 325 assert_not_nil mail
Chris@0 326 assert_equal [u.mail], mail.bcc
Chris@1115 327 assert_mail_body_match 'newpass123', mail
Chris@0 328 end
chris@22 329
Chris@1464 330 def test_update_with_generate_password_should_email_the_password
Chris@1464 331 ActionMailer::Base.deliveries.clear
Chris@1464 332 Setting.bcc_recipients = '1'
Chris@1464 333
Chris@1464 334 put :update, :id => 2, :user => {
Chris@1464 335 :generate_password => '1',
Chris@1464 336 :password => '',
Chris@1464 337 :password_confirmation => ''
Chris@1464 338 }, :send_information => '1'
Chris@1464 339
Chris@1464 340 mail = ActionMailer::Base.deliveries.last
Chris@1464 341 assert_not_nil mail
Chris@1464 342 m = mail_body(mail).match(/Password: ([a-zA-Z0-9]+)/)
Chris@1464 343 assert m
Chris@1464 344 password = m[1]
Chris@1464 345 assert User.find(2).check_password?(password)
Chris@1464 346 end
Chris@1464 347
Chris@1464 348 def test_update_without_generate_password_should_not_change_password
Chris@1464 349 put :update, :id => 2, :user => {
Chris@1464 350 :firstname => 'changed',
Chris@1464 351 :generate_password => '0',
Chris@1464 352 :password => '',
Chris@1464 353 :password_confirmation => ''
Chris@1464 354 }, :send_information => '1'
Chris@1464 355
Chris@1464 356 user = User.find(2)
Chris@1464 357 assert_equal 'changed', user.firstname
Chris@1464 358 assert user.check_password?('jsmith')
Chris@1464 359 end
Chris@1464 360
Chris@1115 361 def test_update_user_switchin_from_auth_source_to_password_authentication
chris@22 362 # Configure as auth source
chris@22 363 u = User.find(2)
chris@22 364 u.auth_source = AuthSource.find(1)
chris@22 365 u.save!
chris@22 366
Chris@1115 367 put :update, :id => u.id, :user => {:auth_source_id => '', :password => 'newpass123', :password_confirmation => 'newpass123'}
chris@22 368
chris@22 369 assert_equal nil, u.reload.auth_source
Chris@1115 370 assert u.check_password?('newpass123')
Chris@1115 371 end
Chris@1115 372
Chris@1115 373 def test_update_notified_project
Chris@1115 374 get :edit, :id => 2
Chris@1115 375 assert_response :success
Chris@1115 376 assert_template 'edit'
Chris@1115 377 u = User.find(2)
Chris@1115 378 assert_equal [1, 2, 5], u.projects.collect{|p| p.id}.sort
Chris@1115 379 assert_equal [1, 2, 5], u.notified_projects_ids.sort
Chris@1464 380 assert_select 'input[name=?][value=?]', 'user[notified_project_ids][]', '1'
Chris@1115 381 assert_equal 'all', u.mail_notification
Chris@1115 382 put :update, :id => 2,
Chris@1115 383 :user => {
Chris@1464 384 :mail_notification => 'selected',
Chris@1464 385 :notified_project_ids => [1, 2]
Chris@1464 386 }
Chris@1115 387 u = User.find(2)
Chris@1115 388 assert_equal 'selected', u.mail_notification
Chris@1115 389 assert_equal [1, 2], u.notified_projects_ids.sort
chris@22 390 end
Chris@909 391
Chris@1464 392 def test_update_status_should_not_update_attributes
Chris@1464 393 user = User.find(2)
Chris@1464 394 user.pref[:no_self_notified] = '1'
Chris@1464 395 user.pref.save
Chris@1464 396
Chris@1464 397 put :update, :id => 2, :user => {:status => 3}
Chris@1464 398 assert_response 302
Chris@1464 399 user = User.find(2)
Chris@1464 400 assert_equal 3, user.status
Chris@1464 401 assert_equal '1', user.pref[:no_self_notified]
Chris@1464 402 end
Chris@1464 403
Chris@128 404 def test_destroy
Chris@128 405 assert_difference 'User.count', -1 do
Chris@128 406 delete :destroy, :id => 2
Chris@128 407 end
Chris@128 408 assert_redirected_to '/users'
Chris@128 409 assert_nil User.find_by_id(2)
Chris@128 410 end
Chris@128 411
Chris@128 412 def test_destroy_should_be_denied_for_non_admin_users
Chris@128 413 @request.session[:user_id] = 3
Chris@909 414
Chris@128 415 assert_no_difference 'User.count' do
Chris@128 416 get :destroy, :id => 2
Chris@128 417 end
Chris@128 418 assert_response 403
Chris@128 419 end
Chris@909 420
Chris@1115 421 def test_destroy_should_redirect_to_back_url_param
Chris@1115 422 assert_difference 'User.count', -1 do
Chris@1115 423 delete :destroy, :id => 2, :back_url => '/users?name=foo'
Chris@1115 424 end
Chris@1115 425 assert_redirected_to '/users?name=foo'
Chris@1115 426 end
Chris@1115 427
Chris@1115 428 def test_create_membership
Chris@1115 429 assert_difference 'Member.count' do
Chris@1115 430 post :edit_membership, :id => 7, :membership => { :project_id => 3, :role_ids => [2]}
Chris@1115 431 end
Chris@1115 432 assert_redirected_to :action => 'edit', :id => '7', :tab => 'memberships'
Chris@1517 433 member = Member.order('id DESC').first
Chris@1115 434 assert_equal User.find(7), member.principal
Chris@1115 435 assert_equal [2], member.role_ids
Chris@1115 436 assert_equal 3, member.project_id
Chris@1115 437 end
Chris@1115 438
Chris@1115 439 def test_create_membership_js_format
Chris@1115 440 assert_difference 'Member.count' do
Chris@1115 441 post :edit_membership, :id => 7, :membership => {:project_id => 3, :role_ids => [2]}, :format => 'js'
Chris@1115 442 assert_response :success
Chris@1115 443 assert_template 'edit_membership'
Chris@1115 444 assert_equal 'text/javascript', response.content_type
Chris@1115 445 end
Chris@1517 446 member = Member.order('id DESC').first
Chris@1115 447 assert_equal User.find(7), member.principal
Chris@1115 448 assert_equal [2], member.role_ids
Chris@1115 449 assert_equal 3, member.project_id
Chris@1115 450 assert_include 'tab-content-memberships', response.body
Chris@1115 451 end
Chris@1115 452
Chris@1115 453 def test_create_membership_js_format_with_failure
Chris@1115 454 assert_no_difference 'Member.count' do
Chris@1115 455 post :edit_membership, :id => 7, :membership => {:project_id => 3}, :format => 'js'
Chris@1115 456 assert_response :success
Chris@1115 457 assert_template 'edit_membership'
Chris@1115 458 assert_equal 'text/javascript', response.content_type
Chris@1115 459 end
Chris@1115 460 assert_include 'alert', response.body, "Alert message not sent"
Chris@1115 461 assert_include 'Role can\\\'t be empty', response.body, "Error message not sent"
Chris@1115 462 end
Chris@1115 463
Chris@1115 464 def test_update_membership
Chris@1115 465 assert_no_difference 'Member.count' do
Chris@1115 466 put :edit_membership, :id => 2, :membership_id => 1, :membership => { :role_ids => [2]}
Chris@1115 467 assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships'
Chris@1115 468 end
Chris@0 469 assert_equal [2], Member.find(1).role_ids
Chris@0 470 end
Chris@909 471
Chris@1115 472 def test_update_membership_js_format
Chris@1115 473 assert_no_difference 'Member.count' do
Chris@1115 474 put :edit_membership, :id => 2, :membership_id => 1, :membership => {:role_ids => [2]}, :format => 'js'
Chris@1115 475 assert_response :success
Chris@1115 476 assert_template 'edit_membership'
Chris@1115 477 assert_equal 'text/javascript', response.content_type
Chris@1115 478 end
Chris@1115 479 assert_equal [2], Member.find(1).role_ids
Chris@1115 480 assert_include 'tab-content-memberships', response.body
Chris@1115 481 end
Chris@1115 482
Chris@0 483 def test_destroy_membership
Chris@1115 484 assert_difference 'Member.count', -1 do
Chris@1115 485 delete :destroy_membership, :id => 2, :membership_id => 1
Chris@1115 486 end
Chris@0 487 assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships'
Chris@0 488 assert_nil Member.find_by_id(1)
Chris@0 489 end
Chris@1115 490
Chris@1115 491 def test_destroy_membership_js_format
Chris@1115 492 assert_difference 'Member.count', -1 do
Chris@1115 493 delete :destroy_membership, :id => 2, :membership_id => 1, :format => 'js'
Chris@1115 494 assert_response :success
Chris@1115 495 assert_template 'destroy_membership'
Chris@1115 496 assert_equal 'text/javascript', response.content_type
Chris@1115 497 end
Chris@1115 498 assert_nil Member.find_by_id(1)
Chris@1115 499 assert_include 'tab-content-memberships', response.body
Chris@1115 500 end
Chris@0 501 end