annotate test/unit/issue_test.rb @ 854:be557d78a11b bug_94

Close obsolete branch bug_94
author Chris Cannam
date Thu, 14 Jul 2011 12:45:24 +0100
parents 94944d00e43c
children af80e5618e9b
rev   line source
Chris@0 1 # redMine - project management software
Chris@0 2 # Copyright (C) 2006-2007 Jean-Philippe Lang
Chris@0 3 #
Chris@0 4 # This program is free software; you can redistribute it and/or
Chris@0 5 # modify it under the terms of the GNU General Public License
Chris@0 6 # as published by the Free Software Foundation; either version 2
Chris@0 7 # of the License, or (at your option) any later version.
Chris@0 8 #
Chris@0 9 # This program is distributed in the hope that it will be useful,
Chris@0 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@0 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@0 12 # GNU General Public License for more details.
Chris@0 13 #
Chris@0 14 # You should have received a copy of the GNU General Public License
Chris@0 15 # along with this program; if not, write to the Free Software
Chris@0 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@0 17
Chris@0 18 require File.dirname(__FILE__) + '/../test_helper'
Chris@0 19
Chris@0 20 class IssueTest < ActiveSupport::TestCase
Chris@0 21 fixtures :projects, :users, :members, :member_roles, :roles,
Chris@0 22 :trackers, :projects_trackers,
Chris@0 23 :enabled_modules,
Chris@0 24 :versions,
Chris@0 25 :issue_statuses, :issue_categories, :issue_relations, :workflows,
Chris@0 26 :enumerations,
Chris@0 27 :issues,
Chris@0 28 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
Chris@0 29 :time_entries
Chris@0 30
Chris@0 31 def test_create
Chris@0 32 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :description => 'IssueTest#test_create', :estimated_hours => '1:30')
Chris@0 33 assert issue.save
Chris@0 34 issue.reload
Chris@0 35 assert_equal 1.5, issue.estimated_hours
Chris@0 36 end
Chris@0 37
Chris@0 38 def test_create_minimal
Chris@0 39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create')
Chris@0 40 assert issue.save
Chris@0 41 assert issue.description.nil?
Chris@0 42 end
Chris@0 43
Chris@0 44 def test_create_with_required_custom_field
Chris@0 45 field = IssueCustomField.find_by_name('Database')
Chris@0 46 field.update_attribute(:is_required, true)
Chris@0 47
Chris@0 48 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'test_create', :description => 'IssueTest#test_create_with_required_custom_field')
Chris@0 49 assert issue.available_custom_fields.include?(field)
Chris@0 50 # No value for the custom field
Chris@0 51 assert !issue.save
Chris@0 52 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
Chris@0 53 # Blank value
Chris@0 54 issue.custom_field_values = { field.id => '' }
Chris@0 55 assert !issue.save
Chris@0 56 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
Chris@0 57 # Invalid value
Chris@0 58 issue.custom_field_values = { field.id => 'SQLServer' }
Chris@0 59 assert !issue.save
Chris@0 60 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
Chris@0 61 # Valid value
Chris@0 62 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@0 63 assert issue.save
Chris@0 64 issue.reload
Chris@0 65 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
Chris@0 66 end
Chris@0 67
Chris@0 68 def test_visible_scope_for_anonymous
Chris@0 69 # Anonymous user should see issues of public projects only
Chris@0 70 issues = Issue.visible(User.anonymous).all
Chris@0 71 assert issues.any?
Chris@0 72 assert_nil issues.detect {|issue| !issue.project.is_public?}
Chris@0 73 # Anonymous user should not see issues without permission
Chris@0 74 Role.anonymous.remove_permission!(:view_issues)
Chris@0 75 issues = Issue.visible(User.anonymous).all
Chris@0 76 assert issues.empty?
Chris@0 77 end
Chris@0 78
Chris@0 79 def test_visible_scope_for_user
Chris@0 80 user = User.find(9)
Chris@0 81 assert user.projects.empty?
Chris@0 82 # Non member user should see issues of public projects only
Chris@0 83 issues = Issue.visible(user).all
Chris@0 84 assert issues.any?
Chris@0 85 assert_nil issues.detect {|issue| !issue.project.is_public?}
Chris@0 86 # Non member user should not see issues without permission
Chris@0 87 Role.non_member.remove_permission!(:view_issues)
Chris@0 88 user.reload
Chris@0 89 issues = Issue.visible(user).all
Chris@0 90 assert issues.empty?
Chris@0 91 # User should see issues of projects for which he has view_issues permissions only
Chris@0 92 Member.create!(:principal => user, :project_id => 2, :role_ids => [1])
Chris@0 93 user.reload
Chris@0 94 issues = Issue.visible(user).all
Chris@0 95 assert issues.any?
Chris@0 96 assert_nil issues.detect {|issue| issue.project_id != 2}
Chris@0 97 end
Chris@0 98
Chris@0 99 def test_visible_scope_for_admin
Chris@0 100 user = User.find(1)
Chris@0 101 user.members.each(&:destroy)
Chris@0 102 assert user.projects.empty?
Chris@0 103 issues = Issue.visible(user).all
Chris@0 104 assert issues.any?
Chris@0 105 # Admin should see issues on private projects that he does not belong to
Chris@0 106 assert issues.detect {|issue| !issue.project.is_public?}
Chris@0 107 end
Chris@0 108
Chris@0 109 def test_errors_full_messages_should_include_custom_fields_errors
Chris@0 110 field = IssueCustomField.find_by_name('Database')
Chris@0 111
Chris@0 112 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'test_create', :description => 'IssueTest#test_create_with_required_custom_field')
Chris@0 113 assert issue.available_custom_fields.include?(field)
Chris@0 114 # Invalid value
Chris@0 115 issue.custom_field_values = { field.id => 'SQLServer' }
Chris@0 116
Chris@0 117 assert !issue.valid?
Chris@0 118 assert_equal 1, issue.errors.full_messages.size
Chris@0 119 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
Chris@0 120 end
Chris@0 121
Chris@0 122 def test_update_issue_with_required_custom_field
Chris@0 123 field = IssueCustomField.find_by_name('Database')
Chris@0 124 field.update_attribute(:is_required, true)
Chris@0 125
Chris@0 126 issue = Issue.find(1)
Chris@0 127 assert_nil issue.custom_value_for(field)
Chris@0 128 assert issue.available_custom_fields.include?(field)
Chris@0 129 # No change to custom values, issue can be saved
Chris@0 130 assert issue.save
Chris@0 131 # Blank value
Chris@0 132 issue.custom_field_values = { field.id => '' }
Chris@0 133 assert !issue.save
Chris@0 134 # Valid value
Chris@0 135 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@0 136 assert issue.save
Chris@0 137 issue.reload
Chris@0 138 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
Chris@0 139 end
Chris@0 140
Chris@0 141 def test_should_not_update_attributes_if_custom_fields_validation_fails
Chris@0 142 issue = Issue.find(1)
Chris@0 143 field = IssueCustomField.find_by_name('Database')
Chris@0 144 assert issue.available_custom_fields.include?(field)
Chris@0 145
Chris@0 146 issue.custom_field_values = { field.id => 'Invalid' }
Chris@0 147 issue.subject = 'Should be not be saved'
Chris@0 148 assert !issue.save
Chris@0 149
Chris@0 150 issue.reload
Chris@0 151 assert_equal "Can't print recipes", issue.subject
Chris@0 152 end
Chris@0 153
Chris@0 154 def test_should_not_recreate_custom_values_objects_on_update
Chris@0 155 field = IssueCustomField.find_by_name('Database')
Chris@0 156
Chris@0 157 issue = Issue.find(1)
Chris@0 158 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@0 159 assert issue.save
Chris@0 160 custom_value = issue.custom_value_for(field)
Chris@0 161 issue.reload
Chris@0 162 issue.custom_field_values = { field.id => 'MySQL' }
Chris@0 163 assert issue.save
Chris@0 164 issue.reload
Chris@0 165 assert_equal custom_value.id, issue.custom_value_for(field).id
Chris@0 166 end
Chris@0 167
Chris@0 168 def test_assigning_tracker_id_should_reload_custom_fields_values
Chris@0 169 issue = Issue.new(:project => Project.find(1))
Chris@0 170 assert issue.custom_field_values.empty?
Chris@0 171 issue.tracker_id = 1
Chris@0 172 assert issue.custom_field_values.any?
Chris@0 173 end
Chris@0 174
Chris@0 175 def test_assigning_attributes_should_assign_tracker_id_first
Chris@0 176 attributes = ActiveSupport::OrderedHash.new
Chris@0 177 attributes['custom_field_values'] = { '1' => 'MySQL' }
Chris@0 178 attributes['tracker_id'] = '1'
Chris@0 179 issue = Issue.new(:project => Project.find(1))
Chris@0 180 issue.attributes = attributes
Chris@0 181 assert_not_nil issue.custom_value_for(1)
Chris@0 182 assert_equal 'MySQL', issue.custom_value_for(1).value
Chris@0 183 end
Chris@0 184
Chris@0 185 def test_should_update_issue_with_disabled_tracker
Chris@0 186 p = Project.find(1)
Chris@0 187 issue = Issue.find(1)
Chris@0 188
Chris@0 189 p.trackers.delete(issue.tracker)
Chris@0 190 assert !p.trackers.include?(issue.tracker)
Chris@0 191
Chris@0 192 issue.reload
Chris@0 193 issue.subject = 'New subject'
Chris@0 194 assert issue.save
Chris@0 195 end
Chris@0 196
Chris@0 197 def test_should_not_set_a_disabled_tracker
Chris@0 198 p = Project.find(1)
Chris@0 199 p.trackers.delete(Tracker.find(2))
Chris@0 200
Chris@0 201 issue = Issue.find(1)
Chris@0 202 issue.tracker_id = 2
Chris@0 203 issue.subject = 'New subject'
Chris@0 204 assert !issue.save
Chris@0 205 assert_not_nil issue.errors.on(:tracker_id)
Chris@0 206 end
Chris@0 207
Chris@0 208 def test_category_based_assignment
Chris@0 209 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Assignment test', :description => 'Assignment test', :category_id => 1)
Chris@0 210 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
Chris@0 211 end
Chris@0 212
Chris@0 213 def test_copy
Chris@0 214 issue = Issue.new.copy_from(1)
Chris@0 215 assert issue.save
Chris@0 216 issue.reload
Chris@0 217 orig = Issue.find(1)
Chris@0 218 assert_equal orig.subject, issue.subject
Chris@0 219 assert_equal orig.tracker, issue.tracker
Chris@0 220 assert_equal "125", issue.custom_value_for(2).value
Chris@0 221 end
Chris@0 222
Chris@0 223 def test_copy_should_copy_status
Chris@0 224 orig = Issue.find(8)
Chris@0 225 assert orig.status != IssueStatus.default
Chris@0 226
Chris@0 227 issue = Issue.new.copy_from(orig)
Chris@0 228 assert issue.save
Chris@0 229 issue.reload
Chris@0 230 assert_equal orig.status, issue.status
Chris@0 231 end
Chris@0 232
Chris@0 233 def test_should_close_duplicates
Chris@0 234 # Create 3 issues
Chris@0 235 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
Chris@0 236 assert issue1.save
Chris@0 237 issue2 = issue1.clone
Chris@0 238 assert issue2.save
Chris@0 239 issue3 = issue1.clone
Chris@0 240 assert issue3.save
Chris@0 241
Chris@0 242 # 2 is a dupe of 1
Chris@0 243 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@0 244 # And 3 is a dupe of 2
Chris@0 245 IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@0 246 # And 3 is a dupe of 1 (circular duplicates)
Chris@0 247 IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@0 248
Chris@0 249 assert issue1.reload.duplicates.include?(issue2)
Chris@0 250
Chris@0 251 # Closing issue 1
Chris@0 252 issue1.init_journal(User.find(:first), "Closing issue1")
Chris@0 253 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
Chris@0 254 assert issue1.save
Chris@0 255 # 2 and 3 should be also closed
Chris@0 256 assert issue2.reload.closed?
Chris@0 257 assert issue3.reload.closed?
Chris@0 258 end
Chris@0 259
Chris@0 260 def test_should_not_close_duplicated_issue
Chris@0 261 # Create 3 issues
Chris@0 262 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
Chris@0 263 assert issue1.save
Chris@0 264 issue2 = issue1.clone
Chris@0 265 assert issue2.save
Chris@0 266
Chris@0 267 # 2 is a dupe of 1
Chris@0 268 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@0 269 # 2 is a dup of 1 but 1 is not a duplicate of 2
Chris@0 270 assert !issue2.reload.duplicates.include?(issue1)
Chris@0 271
Chris@0 272 # Closing issue 2
Chris@0 273 issue2.init_journal(User.find(:first), "Closing issue2")
Chris@0 274 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
Chris@0 275 assert issue2.save
Chris@0 276 # 1 should not be also closed
Chris@0 277 assert !issue1.reload.closed?
Chris@0 278 end
Chris@0 279
Chris@0 280 def test_assignable_versions
Chris@0 281 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
Chris@0 282 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
Chris@0 283 end
Chris@0 284
Chris@0 285 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
Chris@0 286 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
Chris@0 287 assert !issue.save
Chris@0 288 assert_not_nil issue.errors.on(:fixed_version_id)
Chris@0 289 end
Chris@0 290
Chris@0 291 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
Chris@0 292 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
Chris@0 293 assert !issue.save
Chris@0 294 assert_not_nil issue.errors.on(:fixed_version_id)
Chris@0 295 end
Chris@0 296
Chris@0 297 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
Chris@0 298 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
Chris@0 299 assert issue.save
Chris@0 300 end
Chris@0 301
Chris@0 302 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
Chris@0 303 issue = Issue.find(11)
Chris@0 304 assert_equal 'closed', issue.fixed_version.status
Chris@0 305 issue.subject = 'Subject changed'
Chris@0 306 assert issue.save
Chris@0 307 end
Chris@0 308
Chris@0 309 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
Chris@0 310 issue = Issue.find(11)
Chris@0 311 issue.status_id = 1
Chris@0 312 assert !issue.save
Chris@0 313 assert_not_nil issue.errors.on_base
Chris@0 314 end
Chris@0 315
Chris@0 316 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
Chris@0 317 issue = Issue.find(11)
Chris@0 318 issue.status_id = 1
Chris@0 319 issue.fixed_version_id = 3
Chris@0 320 assert issue.save
Chris@0 321 end
Chris@0 322
Chris@0 323 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
Chris@0 324 issue = Issue.find(12)
Chris@0 325 assert_equal 'locked', issue.fixed_version.status
Chris@0 326 issue.status_id = 1
Chris@0 327 assert issue.save
Chris@0 328 end
Chris@0 329
Chris@0 330 def test_move_to_another_project_with_same_category
Chris@0 331 issue = Issue.find(1)
Chris@0 332 assert issue.move_to_project(Project.find(2))
Chris@0 333 issue.reload
Chris@0 334 assert_equal 2, issue.project_id
Chris@0 335 # Category changes
Chris@0 336 assert_equal 4, issue.category_id
Chris@0 337 # Make sure time entries were move to the target project
Chris@0 338 assert_equal 2, issue.time_entries.first.project_id
Chris@0 339 end
Chris@0 340
Chris@0 341 def test_move_to_another_project_without_same_category
Chris@0 342 issue = Issue.find(2)
Chris@0 343 assert issue.move_to_project(Project.find(2))
Chris@0 344 issue.reload
Chris@0 345 assert_equal 2, issue.project_id
Chris@0 346 # Category cleared
Chris@0 347 assert_nil issue.category_id
Chris@0 348 end
Chris@0 349
Chris@0 350 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
Chris@0 351 issue = Issue.find(1)
Chris@0 352 issue.update_attribute(:fixed_version_id, 1)
Chris@0 353 assert issue.move_to_project(Project.find(2))
Chris@0 354 issue.reload
Chris@0 355 assert_equal 2, issue.project_id
Chris@0 356 # Cleared fixed_version
Chris@0 357 assert_equal nil, issue.fixed_version
Chris@0 358 end
Chris@0 359
Chris@0 360 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
Chris@0 361 issue = Issue.find(1)
Chris@0 362 issue.update_attribute(:fixed_version_id, 4)
Chris@0 363 assert issue.move_to_project(Project.find(5))
Chris@0 364 issue.reload
Chris@0 365 assert_equal 5, issue.project_id
Chris@0 366 # Keep fixed_version
Chris@0 367 assert_equal 4, issue.fixed_version_id
Chris@0 368 end
Chris@0 369
Chris@0 370 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
Chris@0 371 issue = Issue.find(1)
Chris@0 372 issue.update_attribute(:fixed_version_id, 1)
Chris@0 373 assert issue.move_to_project(Project.find(5))
Chris@0 374 issue.reload
Chris@0 375 assert_equal 5, issue.project_id
Chris@0 376 # Cleared fixed_version
Chris@0 377 assert_equal nil, issue.fixed_version
Chris@0 378 end
Chris@0 379
Chris@0 380 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
Chris@0 381 issue = Issue.find(1)
Chris@0 382 issue.update_attribute(:fixed_version_id, 7)
Chris@0 383 assert issue.move_to_project(Project.find(2))
Chris@0 384 issue.reload
Chris@0 385 assert_equal 2, issue.project_id
Chris@0 386 # Keep fixed_version
Chris@0 387 assert_equal 7, issue.fixed_version_id
Chris@0 388 end
Chris@0 389
Chris@0 390 def test_move_to_another_project_with_disabled_tracker
Chris@0 391 issue = Issue.find(1)
Chris@0 392 target = Project.find(2)
Chris@0 393 target.tracker_ids = [3]
Chris@0 394 target.save
Chris@0 395 assert_equal false, issue.move_to_project(target)
Chris@0 396 issue.reload
Chris@0 397 assert_equal 1, issue.project_id
Chris@0 398 end
Chris@0 399
Chris@0 400 def test_copy_to_the_same_project
Chris@0 401 issue = Issue.find(1)
Chris@0 402 copy = nil
Chris@0 403 assert_difference 'Issue.count' do
Chris@0 404 copy = issue.move_to_project(issue.project, nil, :copy => true)
Chris@0 405 end
Chris@0 406 assert_kind_of Issue, copy
Chris@0 407 assert_equal issue.project, copy.project
Chris@0 408 assert_equal "125", copy.custom_value_for(2).value
Chris@0 409 end
Chris@0 410
Chris@0 411 def test_copy_to_another_project_and_tracker
Chris@0 412 issue = Issue.find(1)
Chris@0 413 copy = nil
Chris@0 414 assert_difference 'Issue.count' do
Chris@0 415 copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
Chris@0 416 end
Chris@0 417 copy.reload
Chris@0 418 assert_kind_of Issue, copy
Chris@0 419 assert_equal Project.find(3), copy.project
Chris@0 420 assert_equal Tracker.find(2), copy.tracker
Chris@0 421 # Custom field #2 is not associated with target tracker
Chris@0 422 assert_nil copy.custom_value_for(2)
Chris@0 423 end
Chris@0 424
Chris@0 425 context "#move_to_project" do
Chris@0 426 context "as a copy" do
Chris@0 427 setup do
Chris@0 428 @issue = Issue.find(1)
Chris@0 429 @copy = nil
Chris@0 430 end
Chris@0 431
Chris@0 432 should "allow assigned_to changes" do
Chris@0 433 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
Chris@0 434 assert_equal 3, @copy.assigned_to_id
Chris@0 435 end
Chris@0 436
Chris@0 437 should "allow status changes" do
Chris@0 438 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
Chris@0 439 assert_equal 2, @copy.status_id
Chris@0 440 end
Chris@0 441
Chris@0 442 should "allow start date changes" do
Chris@0 443 date = Date.today
Chris@0 444 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
Chris@0 445 assert_equal date, @copy.start_date
Chris@0 446 end
Chris@0 447
Chris@0 448 should "allow due date changes" do
Chris@0 449 date = Date.today
Chris@0 450 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
Chris@0 451
Chris@0 452 assert_equal date, @copy.due_date
Chris@0 453 end
Chris@0 454 end
Chris@0 455 end
Chris@0 456
Chris@0 457 def test_recipients_should_not_include_users_that_cannot_view_the_issue
Chris@0 458 issue = Issue.find(12)
Chris@0 459 assert issue.recipients.include?(issue.author.mail)
Chris@0 460 # move the issue to a private project
Chris@0 461 copy = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
Chris@0 462 # author is not a member of project anymore
Chris@0 463 assert !copy.recipients.include?(copy.author.mail)
Chris@0 464 end
Chris@0 465
Chris@0 466 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
Chris@0 467 user = User.find(3)
Chris@0 468 issue = Issue.find(9)
Chris@0 469 Watcher.create!(:user => user, :watchable => issue)
Chris@0 470 assert issue.watched_by?(user)
Chris@0 471 assert !issue.watcher_recipients.include?(user.mail)
Chris@0 472 end
Chris@0 473
Chris@0 474 def test_issue_destroy
Chris@0 475 Issue.find(1).destroy
Chris@0 476 assert_nil Issue.find_by_id(1)
Chris@0 477 assert_nil TimeEntry.find_by_issue_id(1)
Chris@0 478 end
Chris@0 479
Chris@0 480 def test_blocked
Chris@0 481 blocked_issue = Issue.find(9)
Chris@0 482 blocking_issue = Issue.find(10)
Chris@0 483
Chris@0 484 assert blocked_issue.blocked?
Chris@0 485 assert !blocking_issue.blocked?
Chris@0 486 end
Chris@0 487
Chris@0 488 def test_blocked_issues_dont_allow_closed_statuses
Chris@0 489 blocked_issue = Issue.find(9)
Chris@0 490
Chris@0 491 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
Chris@0 492 assert !allowed_statuses.empty?
Chris@0 493 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
Chris@0 494 assert closed_statuses.empty?
Chris@0 495 end
Chris@0 496
Chris@0 497 def test_unblocked_issues_allow_closed_statuses
Chris@0 498 blocking_issue = Issue.find(10)
Chris@0 499
Chris@0 500 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
Chris@0 501 assert !allowed_statuses.empty?
Chris@0 502 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
Chris@0 503 assert !closed_statuses.empty?
Chris@0 504 end
Chris@0 505
chris@37 506 def test_rescheduling_an_issue_should_reschedule_following_issue
chris@37 507 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
chris@37 508 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
chris@37 509 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
chris@37 510 assert_equal issue1.due_date + 1, issue2.reload.start_date
chris@37 511
chris@37 512 issue1.due_date = Date.today + 5
chris@37 513 issue1.save!
chris@37 514 assert_equal issue1.due_date + 1, issue2.reload.start_date
chris@37 515 end
chris@37 516
Chris@0 517 def test_overdue
Chris@0 518 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
Chris@0 519 assert !Issue.new(:due_date => Date.today).overdue?
Chris@0 520 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
Chris@0 521 assert !Issue.new(:due_date => nil).overdue?
Chris@0 522 assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
Chris@0 523 end
chris@22 524
chris@22 525 context "#behind_schedule?" do
chris@22 526 should "be false if the issue has no start_date" do
chris@22 527 assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
chris@22 528 end
chris@22 529
chris@22 530 should "be false if the issue has no end_date" do
chris@22 531 assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
chris@22 532 end
chris@22 533
chris@22 534 should "be false if the issue has more done than it's calendar time" do
chris@22 535 assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
chris@22 536 end
chris@22 537
chris@22 538 should "be true if the issue hasn't been started at all" do
chris@22 539 assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
chris@22 540 end
chris@22 541
chris@22 542 should "be true if the issue has used more calendar time than it's done ratio" do
chris@22 543 assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
chris@22 544 end
chris@22 545 end
chris@37 546
chris@37 547 context "#assignable_users" do
chris@37 548 should "be Users" do
chris@37 549 assert_kind_of User, Issue.find(1).assignable_users.first
chris@37 550 end
chris@37 551
chris@37 552 should "include the issue author" do
chris@37 553 project = Project.find(1)
chris@37 554 non_project_member = User.generate!
chris@37 555 issue = Issue.generate_for_project!(project, :author => non_project_member)
chris@37 556
chris@37 557 assert issue.assignable_users.include?(non_project_member)
chris@37 558 end
chris@37 559
chris@37 560 should "not show the issue author twice" do
chris@37 561 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
chris@37 562 assert_equal 2, assignable_user_ids.length
chris@37 563
chris@37 564 assignable_user_ids.each do |user_id|
chris@37 565 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
chris@37 566 end
chris@37 567 end
Chris@0 568 end
Chris@0 569
Chris@0 570 def test_create_should_send_email_notification
Chris@0 571 ActionMailer::Base.deliveries.clear
Chris@0 572 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :estimated_hours => '1:30')
Chris@0 573
Chris@0 574 assert issue.save
Chris@0 575 assert_equal 1, ActionMailer::Base.deliveries.size
Chris@0 576 end
chris@37 577
Chris@0 578 def test_stale_issue_should_not_send_email_notification
Chris@0 579 ActionMailer::Base.deliveries.clear
Chris@0 580 issue = Issue.find(1)
Chris@0 581 stale = Issue.find(1)
Chris@0 582
Chris@0 583 issue.init_journal(User.find(1))
Chris@0 584 issue.subject = 'Subjet update'
Chris@0 585 assert issue.save
Chris@0 586 assert_equal 1, ActionMailer::Base.deliveries.size
Chris@0 587 ActionMailer::Base.deliveries.clear
Chris@0 588
Chris@0 589 stale.init_journal(User.find(1))
Chris@0 590 stale.subject = 'Another subjet update'
Chris@0 591 assert_raise ActiveRecord::StaleObjectError do
Chris@0 592 stale.save
Chris@0 593 end
Chris@0 594 assert ActionMailer::Base.deliveries.empty?
Chris@0 595 end
Chris@0 596
Chris@0 597 def test_saving_twice_should_not_duplicate_journal_details
Chris@0 598 i = Issue.find(:first)
Chris@0 599 i.init_journal(User.find(2), 'Some notes')
Chris@0 600 # initial changes
Chris@0 601 i.subject = 'New subject'
Chris@0 602 i.done_ratio = i.done_ratio + 10
Chris@0 603 assert_difference 'Journal.count' do
Chris@0 604 assert i.save
Chris@0 605 end
Chris@0 606 # 1 more change
Chris@0 607 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
Chris@0 608 assert_no_difference 'Journal.count' do
Chris@0 609 assert_difference 'JournalDetail.count', 1 do
Chris@0 610 i.save
Chris@0 611 end
Chris@0 612 end
Chris@0 613 # no more change
Chris@0 614 assert_no_difference 'Journal.count' do
Chris@0 615 assert_no_difference 'JournalDetail.count' do
Chris@0 616 i.save
Chris@0 617 end
Chris@0 618 end
Chris@0 619 end
Chris@0 620
Chris@0 621 context "#done_ratio" do
Chris@0 622 setup do
Chris@0 623 @issue = Issue.find(1)
Chris@0 624 @issue_status = IssueStatus.find(1)
Chris@0 625 @issue_status.update_attribute(:default_done_ratio, 50)
chris@37 626 @issue2 = Issue.find(2)
chris@37 627 @issue_status2 = IssueStatus.find(2)
chris@37 628 @issue_status2.update_attribute(:default_done_ratio, 0)
Chris@0 629 end
Chris@0 630
Chris@0 631 context "with Setting.issue_done_ratio using the issue_field" do
Chris@0 632 setup do
Chris@0 633 Setting.issue_done_ratio = 'issue_field'
Chris@0 634 end
Chris@0 635
Chris@0 636 should "read the issue's field" do
Chris@0 637 assert_equal 0, @issue.done_ratio
chris@37 638 assert_equal 30, @issue2.done_ratio
Chris@0 639 end
Chris@0 640 end
Chris@0 641
Chris@0 642 context "with Setting.issue_done_ratio using the issue_status" do
Chris@0 643 setup do
Chris@0 644 Setting.issue_done_ratio = 'issue_status'
Chris@0 645 end
Chris@0 646
Chris@0 647 should "read the Issue Status's default done ratio" do
Chris@0 648 assert_equal 50, @issue.done_ratio
chris@37 649 assert_equal 0, @issue2.done_ratio
Chris@0 650 end
Chris@0 651 end
Chris@0 652 end
Chris@0 653
Chris@0 654 context "#update_done_ratio_from_issue_status" do
Chris@0 655 setup do
Chris@0 656 @issue = Issue.find(1)
Chris@0 657 @issue_status = IssueStatus.find(1)
Chris@0 658 @issue_status.update_attribute(:default_done_ratio, 50)
chris@37 659 @issue2 = Issue.find(2)
chris@37 660 @issue_status2 = IssueStatus.find(2)
chris@37 661 @issue_status2.update_attribute(:default_done_ratio, 0)
Chris@0 662 end
Chris@0 663
Chris@0 664 context "with Setting.issue_done_ratio using the issue_field" do
Chris@0 665 setup do
Chris@0 666 Setting.issue_done_ratio = 'issue_field'
Chris@0 667 end
Chris@0 668
Chris@0 669 should "not change the issue" do
Chris@0 670 @issue.update_done_ratio_from_issue_status
chris@37 671 @issue2.update_done_ratio_from_issue_status
Chris@0 672
chris@37 673 assert_equal 0, @issue.read_attribute(:done_ratio)
chris@37 674 assert_equal 30, @issue2.read_attribute(:done_ratio)
Chris@0 675 end
Chris@0 676 end
Chris@0 677
Chris@0 678 context "with Setting.issue_done_ratio using the issue_status" do
Chris@0 679 setup do
Chris@0 680 Setting.issue_done_ratio = 'issue_status'
Chris@0 681 end
Chris@0 682
chris@37 683 should "change the issue's done ratio" do
Chris@0 684 @issue.update_done_ratio_from_issue_status
chris@37 685 @issue2.update_done_ratio_from_issue_status
Chris@0 686
chris@37 687 assert_equal 50, @issue.read_attribute(:done_ratio)
chris@37 688 assert_equal 0, @issue2.read_attribute(:done_ratio)
Chris@0 689 end
Chris@0 690 end
Chris@0 691 end
Chris@0 692
Chris@0 693 test "#by_tracker" do
Chris@0 694 groups = Issue.by_tracker(Project.find(1))
Chris@0 695 assert_equal 3, groups.size
Chris@0 696 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@0 697 end
Chris@0 698
Chris@0 699 test "#by_version" do
Chris@0 700 groups = Issue.by_version(Project.find(1))
Chris@0 701 assert_equal 3, groups.size
Chris@0 702 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@0 703 end
Chris@0 704
Chris@0 705 test "#by_priority" do
Chris@0 706 groups = Issue.by_priority(Project.find(1))
Chris@0 707 assert_equal 4, groups.size
Chris@0 708 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@0 709 end
Chris@0 710
Chris@0 711 test "#by_category" do
Chris@0 712 groups = Issue.by_category(Project.find(1))
Chris@0 713 assert_equal 2, groups.size
Chris@0 714 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@0 715 end
Chris@0 716
Chris@0 717 test "#by_assigned_to" do
Chris@0 718 groups = Issue.by_assigned_to(Project.find(1))
Chris@0 719 assert_equal 2, groups.size
Chris@0 720 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@0 721 end
Chris@0 722
Chris@0 723 test "#by_author" do
Chris@0 724 groups = Issue.by_author(Project.find(1))
Chris@0 725 assert_equal 4, groups.size
Chris@0 726 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@0 727 end
Chris@0 728
Chris@0 729 test "#by_subproject" do
Chris@0 730 groups = Issue.by_subproject(Project.find(1))
Chris@0 731 assert_equal 2, groups.size
Chris@0 732 assert_equal 5, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@0 733 end
Chris@0 734
Chris@0 735
Chris@0 736 context ".allowed_target_projects_on_move" do
Chris@0 737 should "return all active projects for admin users" do
Chris@0 738 User.current = User.find(1)
Chris@0 739 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
Chris@0 740 end
Chris@0 741
Chris@0 742 should "return allowed projects for non admin users" do
Chris@0 743 User.current = User.find(2)
Chris@0 744 Role.non_member.remove_permission! :move_issues
Chris@0 745 assert_equal 3, Issue.allowed_target_projects_on_move.size
Chris@0 746
Chris@0 747 Role.non_member.add_permission! :move_issues
Chris@0 748 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
Chris@0 749 end
Chris@0 750 end
Chris@0 751
Chris@0 752 def test_recently_updated_with_limit_scopes
Chris@0 753 #should return the last updated issue
Chris@0 754 assert_equal 1, Issue.recently_updated.with_limit(1).length
Chris@0 755 assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
Chris@0 756 end
Chris@0 757
Chris@0 758 def test_on_active_projects_scope
Chris@0 759 assert Project.find(2).archive
Chris@0 760
Chris@0 761 before = Issue.on_active_project.length
Chris@0 762 # test inclusion to results
Chris@0 763 issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
Chris@0 764 assert_equal before + 1, Issue.on_active_project.length
Chris@0 765
Chris@0 766 # Move to an archived project
Chris@0 767 issue.project = Project.find(2)
Chris@0 768 assert issue.save
Chris@0 769 assert_equal before, Issue.on_active_project.length
Chris@0 770 end
chris@37 771
chris@37 772 context "Issue#recipients" do
chris@37 773 setup do
chris@37 774 @project = Project.find(1)
chris@37 775 @author = User.generate_with_protected!
chris@37 776 @assignee = User.generate_with_protected!
chris@37 777 @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
chris@37 778 end
chris@37 779
chris@37 780 should "include project recipients" do
chris@37 781 assert @project.recipients.present?
chris@37 782 @project.recipients.each do |project_recipient|
chris@37 783 assert @issue.recipients.include?(project_recipient)
chris@37 784 end
chris@37 785 end
chris@37 786
chris@37 787 should "include the author if the author is active" do
chris@37 788 assert @issue.author, "No author set for Issue"
chris@37 789 assert @issue.recipients.include?(@issue.author.mail)
chris@37 790 end
chris@37 791
chris@37 792 should "include the assigned to user if the assigned to user is active" do
chris@37 793 assert @issue.assigned_to, "No assigned_to set for Issue"
chris@37 794 assert @issue.recipients.include?(@issue.assigned_to.mail)
chris@37 795 end
chris@37 796
chris@37 797 should "not include users who opt out of all email" do
chris@37 798 @author.update_attribute(:mail_notification, :none)
chris@37 799
chris@37 800 assert !@issue.recipients.include?(@issue.author.mail)
chris@37 801 end
chris@37 802
chris@37 803 should "not include the issue author if they are only notified of assigned issues" do
chris@37 804 @author.update_attribute(:mail_notification, :only_assigned)
chris@37 805
chris@37 806 assert !@issue.recipients.include?(@issue.author.mail)
chris@37 807 end
chris@37 808
chris@37 809 should "not include the assigned user if they are only notified of owned issues" do
chris@37 810 @assignee.update_attribute(:mail_notification, :only_owner)
chris@37 811
chris@37 812 assert !@issue.recipients.include?(@issue.assigned_to.mail)
chris@37 813 end
chris@37 814
chris@37 815 end
Chris@0 816 end