annotate app/models/issue.rb @ 1181:27b6f53331d5 bug_320

Close obsolete branch bug_320
author Chris Cannam
date Wed, 09 Nov 2011 14:19:49 +0000
parents 851510f1b535
children 5e80956cc792
rev   line source
Chris@245 1 # Redmine - project management software
Chris@245 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
Chris@0 3 #
Chris@0 4 # This program is free software; you can redistribute it and/or
Chris@0 5 # modify it under the terms of the GNU General Public License
Chris@0 6 # as published by the Free Software Foundation; either version 2
Chris@0 7 # of the License, or (at your option) any later version.
Chris@441 8 #
Chris@0 9 # This program is distributed in the hope that it will be useful,
Chris@0 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@0 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@0 12 # GNU General Public License for more details.
Chris@441 13 #
Chris@0 14 # You should have received a copy of the GNU General Public License
Chris@0 15 # along with this program; if not, write to the Free Software
Chris@0 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@0 17
Chris@0 18 class Issue < ActiveRecord::Base
Chris@117 19 include Redmine::SafeAttributes
Chris@441 20
Chris@0 21 belongs_to :project
Chris@0 22 belongs_to :tracker
Chris@0 23 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
Chris@0 24 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
Chris@0 25 belongs_to :assigned_to, :class_name => 'User', :foreign_key => 'assigned_to_id'
Chris@0 26 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
Chris@0 27 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
Chris@0 28 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
Chris@0 29
Chris@0 30 has_many :journals, :as => :journalized, :dependent => :destroy
Chris@0 31 has_many :time_entries, :dependent => :delete_all
Chris@0 32 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
Chris@441 33
Chris@0 34 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
Chris@0 35 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
Chris@441 36
Chris@210 37 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
Chris@0 38 acts_as_attachable :after_remove => :attachment_removed
Chris@0 39 acts_as_customizable
Chris@0 40 acts_as_watchable
Chris@0 41 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
Chris@0 42 :include => [:project, :journals],
Chris@0 43 # sort by id so that limited eager loading doesn't break with postgresql
Chris@0 44 :order_column => "#{table_name}.id"
Chris@0 45 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
Chris@0 46 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
Chris@0 47 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
Chris@441 48
Chris@0 49 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
Chris@0 50 :author_key => :author_id
Chris@0 51
Chris@0 52 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
Chris@0 53
Chris@0 54 attr_reader :current_journal
Chris@0 55
Chris@0 56 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
Chris@0 57
Chris@0 58 validates_length_of :subject, :maximum => 255
Chris@0 59 validates_inclusion_of :done_ratio, :in => 0..100
Chris@0 60 validates_numericality_of :estimated_hours, :allow_nil => true
Chris@0 61
Chris@0 62 named_scope :visible, lambda {|*args| { :include => :project,
Chris@441 63 :conditions => Issue.visible_condition(args.shift || User.current, *args) } }
Chris@441 64
Chris@0 65 named_scope :open, :conditions => ["#{IssueStatus.table_name}.is_closed = ?", false], :include => :status
Chris@0 66
chris@22 67 named_scope :recently_updated, :order => "#{Issue.table_name}.updated_on DESC"
Chris@0 68 named_scope :with_limit, lambda { |limit| { :limit => limit} }
Chris@0 69 named_scope :on_active_project, :include => [:status, :project, :tracker],
Chris@0 70 :conditions => ["#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"]
chris@22 71
chris@22 72 named_scope :without_version, lambda {
chris@22 73 {
chris@22 74 :conditions => { :fixed_version_id => nil}
chris@22 75 }
chris@22 76 }
chris@22 77
chris@22 78 named_scope :with_query, lambda {|query|
chris@22 79 {
chris@22 80 :conditions => Query.merge_conditions(query.statement)
chris@22 81 }
chris@22 82 }
Chris@0 83
Chris@0 84 before_create :default_assign
chris@37 85 before_save :close_duplicates, :update_done_ratio_from_issue_status
chris@37 86 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
Chris@0 87 after_destroy :update_parent_attributes
Chris@441 88
Chris@441 89 # Returns a SQL conditions string used to find all issues visible by the specified user
Chris@441 90 def self.visible_condition(user, options={})
Chris@441 91 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
Chris@441 92 case role.issues_visibility
Chris@441 93 when 'all'
Chris@441 94 nil
Chris@441 95 when 'default'
Chris@441 96 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id = #{user.id})"
Chris@441 97 when 'own'
Chris@441 98 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id = #{user.id})"
Chris@441 99 else
Chris@441 100 '1=0'
Chris@441 101 end
Chris@441 102 end
Chris@441 103 end
Chris@441 104
Chris@0 105 # Returns true if usr or current user is allowed to view the issue
Chris@0 106 def visible?(usr=nil)
Chris@441 107 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
Chris@441 108 case role.issues_visibility
Chris@441 109 when 'all'
Chris@441 110 true
Chris@441 111 when 'default'
Chris@441 112 !self.is_private? || self.author == user || self.assigned_to == user
Chris@441 113 when 'own'
Chris@441 114 self.author == user || self.assigned_to == user
Chris@441 115 else
Chris@441 116 false
Chris@441 117 end
Chris@441 118 end
Chris@0 119 end
Chris@441 120
Chris@0 121 def after_initialize
Chris@0 122 if new_record?
Chris@0 123 # set default values for new records only
Chris@0 124 self.status ||= IssueStatus.default
Chris@0 125 self.priority ||= IssuePriority.default
Chris@0 126 end
Chris@0 127 end
Chris@441 128
Chris@0 129 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
Chris@0 130 def available_custom_fields
Chris@441 131 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
Chris@0 132 end
Chris@441 133
Chris@0 134 def copy_from(arg)
Chris@0 135 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
Chris@0 136 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
Chris@0 137 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
Chris@0 138 self.status = issue.status
Chris@0 139 self
Chris@0 140 end
Chris@441 141
Chris@0 142 # Moves/copies an issue to a new project and tracker
Chris@0 143 # Returns the moved/copied issue on success, false on failure
Chris@0 144 def move_to_project(*args)
Chris@0 145 ret = Issue.transaction do
Chris@0 146 move_to_project_without_transaction(*args) || raise(ActiveRecord::Rollback)
Chris@0 147 end || false
Chris@0 148 end
Chris@441 149
Chris@0 150 def move_to_project_without_transaction(new_project, new_tracker = nil, options = {})
Chris@0 151 options ||= {}
Chris@0 152 issue = options[:copy] ? self.class.new.copy_from(self) : self
Chris@441 153
Chris@0 154 if new_project && issue.project_id != new_project.id
Chris@0 155 # delete issue relations
Chris@0 156 unless Setting.cross_project_issue_relations?
Chris@0 157 issue.relations_from.clear
Chris@0 158 issue.relations_to.clear
Chris@0 159 end
Chris@0 160 # issue is moved to another project
Chris@0 161 # reassign to the category with same name if any
Chris@0 162 new_category = issue.category.nil? ? nil : new_project.issue_categories.find_by_name(issue.category.name)
Chris@0 163 issue.category = new_category
Chris@0 164 # Keep the fixed_version if it's still valid in the new_project
Chris@0 165 unless new_project.shared_versions.include?(issue.fixed_version)
Chris@0 166 issue.fixed_version = nil
Chris@0 167 end
Chris@0 168 issue.project = new_project
Chris@0 169 if issue.parent && issue.parent.project_id != issue.project_id
Chris@0 170 issue.parent_issue_id = nil
Chris@0 171 end
Chris@0 172 end
Chris@0 173 if new_tracker
Chris@0 174 issue.tracker = new_tracker
Chris@0 175 issue.reset_custom_values!
Chris@0 176 end
Chris@0 177 if options[:copy]
Chris@441 178 issue.author = User.current
Chris@0 179 issue.custom_field_values = self.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
Chris@0 180 issue.status = if options[:attributes] && options[:attributes][:status_id]
Chris@0 181 IssueStatus.find_by_id(options[:attributes][:status_id])
Chris@0 182 else
Chris@0 183 self.status
Chris@0 184 end
Chris@0 185 end
Chris@0 186 # Allow bulk setting of attributes on the issue
Chris@0 187 if options[:attributes]
Chris@0 188 issue.attributes = options[:attributes]
Chris@0 189 end
Chris@0 190 if issue.save
Chris@441 191 if options[:copy]
Chris@441 192 if current_journal && current_journal.notes.present?
Chris@441 193 issue.init_journal(current_journal.user, current_journal.notes)
Chris@441 194 issue.current_journal.notify = false
Chris@441 195 issue.save
Chris@441 196 end
Chris@441 197 else
Chris@0 198 # Manually update project_id on related time entries
Chris@0 199 TimeEntry.update_all("project_id = #{new_project.id}", {:issue_id => id})
Chris@441 200
Chris@0 201 issue.children.each do |child|
Chris@0 202 unless child.move_to_project_without_transaction(new_project)
Chris@0 203 # Move failed and transaction was rollback'd
Chris@0 204 return false
Chris@0 205 end
Chris@0 206 end
Chris@0 207 end
Chris@0 208 else
Chris@0 209 return false
Chris@0 210 end
Chris@0 211 issue
Chris@0 212 end
Chris@0 213
Chris@0 214 def status_id=(sid)
Chris@0 215 self.status = nil
Chris@0 216 write_attribute(:status_id, sid)
Chris@0 217 end
Chris@441 218
Chris@0 219 def priority_id=(pid)
Chris@0 220 self.priority = nil
Chris@0 221 write_attribute(:priority_id, pid)
Chris@0 222 end
Chris@0 223
Chris@0 224 def tracker_id=(tid)
Chris@0 225 self.tracker = nil
Chris@0 226 result = write_attribute(:tracker_id, tid)
Chris@0 227 @custom_field_values = nil
Chris@0 228 result
Chris@0 229 end
Chris@507 230
Chris@507 231 def description=(arg)
Chris@507 232 if arg.is_a?(String)
Chris@507 233 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
Chris@507 234 end
Chris@507 235 write_attribute(:description, arg)
Chris@507 236 end
Chris@441 237
Chris@0 238 # Overrides attributes= so that tracker_id gets assigned first
Chris@0 239 def attributes_with_tracker_first=(new_attributes, *args)
Chris@0 240 return if new_attributes.nil?
Chris@0 241 new_tracker_id = new_attributes['tracker_id'] || new_attributes[:tracker_id]
Chris@0 242 if new_tracker_id
Chris@0 243 self.tracker_id = new_tracker_id
Chris@0 244 end
Chris@0 245 send :attributes_without_tracker_first=, new_attributes, *args
Chris@0 246 end
Chris@0 247 # Do not redefine alias chain on reload (see #4838)
Chris@0 248 alias_method_chain(:attributes=, :tracker_first) unless method_defined?(:attributes_without_tracker_first=)
Chris@441 249
Chris@0 250 def estimated_hours=(h)
Chris@0 251 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
Chris@0 252 end
Chris@441 253
Chris@117 254 safe_attributes 'tracker_id',
Chris@117 255 'status_id',
Chris@117 256 'parent_issue_id',
Chris@117 257 'category_id',
Chris@117 258 'assigned_to_id',
Chris@117 259 'priority_id',
Chris@117 260 'fixed_version_id',
Chris@117 261 'subject',
Chris@117 262 'description',
Chris@117 263 'start_date',
Chris@117 264 'due_date',
Chris@117 265 'done_ratio',
Chris@117 266 'estimated_hours',
Chris@117 267 'custom_field_values',
Chris@117 268 'custom_fields',
Chris@117 269 'lock_version',
Chris@117 270 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
Chris@441 271
Chris@117 272 safe_attributes 'status_id',
Chris@117 273 'assigned_to_id',
Chris@117 274 'fixed_version_id',
Chris@117 275 'done_ratio',
Chris@117 276 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
chris@37 277
Chris@441 278 safe_attributes 'is_private',
Chris@441 279 :if => lambda {|issue, user|
Chris@441 280 user.allowed_to?(:set_issues_private, issue.project) ||
Chris@441 281 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
Chris@441 282 }
Chris@441 283
Chris@0 284 # Safely sets attributes
Chris@0 285 # Should be called from controllers instead of #attributes=
Chris@0 286 # attr_accessible is too rough because we still want things like
Chris@0 287 # Issue.new(:project => foo) to work
Chris@0 288 # TODO: move workflow/permission checks from controllers to here
Chris@0 289 def safe_attributes=(attrs, user=User.current)
chris@37 290 return unless attrs.is_a?(Hash)
Chris@441 291
chris@37 292 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
Chris@117 293 attrs = delete_unsafe_attributes(attrs, user)
Chris@441 294 return if attrs.empty?
Chris@441 295
chris@37 296 # Tracker must be set before since new_statuses_allowed_to depends on it.
chris@37 297 if t = attrs.delete('tracker_id')
chris@37 298 self.tracker_id = t
chris@37 299 end
Chris@441 300
Chris@0 301 if attrs['status_id']
Chris@0 302 unless new_statuses_allowed_to(user).collect(&:id).include?(attrs['status_id'].to_i)
Chris@0 303 attrs.delete('status_id')
Chris@0 304 end
Chris@0 305 end
Chris@441 306
Chris@0 307 unless leaf?
Chris@0 308 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
Chris@0 309 end
Chris@441 310
Chris@0 311 if attrs.has_key?('parent_issue_id')
Chris@0 312 if !user.allowed_to?(:manage_subtasks, project)
Chris@0 313 attrs.delete('parent_issue_id')
Chris@0 314 elsif !attrs['parent_issue_id'].blank?
Chris@117 315 attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'].to_i)
Chris@0 316 end
Chris@0 317 end
Chris@441 318
Chris@0 319 self.attributes = attrs
Chris@0 320 end
Chris@441 321
Chris@0 322 def done_ratio
chris@37 323 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
Chris@0 324 status.default_done_ratio
Chris@0 325 else
Chris@0 326 read_attribute(:done_ratio)
Chris@0 327 end
Chris@0 328 end
Chris@0 329
Chris@0 330 def self.use_status_for_done_ratio?
Chris@0 331 Setting.issue_done_ratio == 'issue_status'
Chris@0 332 end
Chris@0 333
Chris@0 334 def self.use_field_for_done_ratio?
Chris@0 335 Setting.issue_done_ratio == 'issue_field'
Chris@0 336 end
Chris@441 337
Chris@0 338 def validate
Chris@0 339 if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty?
Chris@0 340 errors.add :due_date, :not_a_date
Chris@0 341 end
Chris@441 342
Chris@0 343 if self.due_date and self.start_date and self.due_date < self.start_date
Chris@0 344 errors.add :due_date, :greater_than_start_date
Chris@0 345 end
Chris@441 346
Chris@0 347 if start_date && soonest_start && start_date < soonest_start
Chris@0 348 errors.add :start_date, :invalid
Chris@0 349 end
Chris@441 350
Chris@0 351 if fixed_version
Chris@0 352 if !assignable_versions.include?(fixed_version)
Chris@0 353 errors.add :fixed_version_id, :inclusion
Chris@0 354 elsif reopened? && fixed_version.closed?
Chris@0 355 errors.add_to_base I18n.t(:error_can_not_reopen_issue_on_closed_version)
Chris@0 356 end
Chris@0 357 end
Chris@441 358
Chris@0 359 # Checks that the issue can not be added/moved to a disabled tracker
Chris@0 360 if project && (tracker_id_changed? || project_id_changed?)
Chris@0 361 unless project.trackers.include?(tracker)
Chris@0 362 errors.add :tracker_id, :inclusion
Chris@0 363 end
Chris@0 364 end
Chris@441 365
Chris@0 366 # Checks parent issue assignment
Chris@0 367 if @parent_issue
Chris@0 368 if @parent_issue.project_id != project_id
Chris@0 369 errors.add :parent_issue_id, :not_same_project
Chris@0 370 elsif !new_record?
Chris@0 371 # moving an existing issue
Chris@0 372 if @parent_issue.root_id != root_id
Chris@0 373 # we can always move to another tree
Chris@0 374 elsif move_possible?(@parent_issue)
Chris@0 375 # move accepted inside tree
Chris@0 376 else
Chris@0 377 errors.add :parent_issue_id, :not_a_valid_parent
Chris@0 378 end
Chris@0 379 end
Chris@0 380 end
Chris@0 381 end
Chris@441 382
Chris@0 383 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
Chris@0 384 # even if the user turns off the setting later
Chris@0 385 def update_done_ratio_from_issue_status
chris@37 386 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
Chris@0 387 self.done_ratio = status.default_done_ratio
Chris@0 388 end
Chris@0 389 end
Chris@441 390
Chris@0 391 def init_journal(user, notes = "")
Chris@0 392 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
Chris@0 393 @issue_before_change = self.clone
Chris@0 394 @issue_before_change.status = self.status
Chris@0 395 @custom_values_before_change = {}
Chris@0 396 self.custom_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
Chris@0 397 # Make sure updated_on is updated when adding a note.
Chris@0 398 updated_on_will_change!
Chris@0 399 @current_journal
Chris@0 400 end
Chris@441 401
Chris@0 402 # Return true if the issue is closed, otherwise false
Chris@0 403 def closed?
Chris@0 404 self.status.is_closed?
Chris@0 405 end
Chris@441 406
Chris@0 407 # Return true if the issue is being reopened
Chris@0 408 def reopened?
Chris@0 409 if !new_record? && status_id_changed?
Chris@0 410 status_was = IssueStatus.find_by_id(status_id_was)
Chris@0 411 status_new = IssueStatus.find_by_id(status_id)
Chris@0 412 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
Chris@0 413 return true
Chris@0 414 end
Chris@0 415 end
Chris@0 416 false
Chris@0 417 end
Chris@0 418
Chris@0 419 # Return true if the issue is being closed
Chris@0 420 def closing?
Chris@0 421 if !new_record? && status_id_changed?
Chris@0 422 status_was = IssueStatus.find_by_id(status_id_was)
Chris@0 423 status_new = IssueStatus.find_by_id(status_id)
Chris@0 424 if status_was && status_new && !status_was.is_closed? && status_new.is_closed?
Chris@0 425 return true
Chris@0 426 end
Chris@0 427 end
Chris@0 428 false
Chris@0 429 end
Chris@441 430
Chris@0 431 # Returns true if the issue is overdue
Chris@0 432 def overdue?
Chris@0 433 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
Chris@0 434 end
chris@22 435
chris@22 436 # Is the amount of work done less than it should for the due date
chris@22 437 def behind_schedule?
chris@22 438 return false if start_date.nil? || due_date.nil?
chris@22 439 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
chris@22 440 return done_date <= Date.today
chris@22 441 end
chris@22 442
chris@22 443 # Does this issue have children?
chris@22 444 def children?
chris@22 445 !leaf?
chris@22 446 end
Chris@441 447
Chris@0 448 # Users the issue can be assigned to
Chris@0 449 def assignable_users
chris@37 450 users = project.assignable_users
chris@37 451 users << author if author
chris@37 452 users.uniq.sort
Chris@0 453 end
Chris@441 454
Chris@0 455 # Versions that the issue can be assigned to
Chris@0 456 def assignable_versions
Chris@0 457 @assignable_versions ||= (project.shared_versions.open + [Version.find_by_id(fixed_version_id_was)]).compact.uniq.sort
Chris@0 458 end
Chris@441 459
Chris@0 460 # Returns true if this issue is blocked by another issue that is still open
Chris@0 461 def blocked?
Chris@0 462 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
Chris@0 463 end
Chris@441 464
Chris@0 465 # Returns an array of status that user is able to apply
Chris@0 466 def new_statuses_allowed_to(user, include_default=false)
Chris@245 467 statuses = status.find_new_statuses_allowed_to(
Chris@245 468 user.roles_for_project(project),
Chris@245 469 tracker,
Chris@245 470 author == user,
Chris@245 471 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
Chris@245 472 )
Chris@0 473 statuses << status unless statuses.empty?
Chris@0 474 statuses << IssueStatus.default if include_default
Chris@0 475 statuses = statuses.uniq.sort
Chris@0 476 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
Chris@0 477 end
Chris@441 478
Chris@0 479 # Returns the mail adresses of users that should be notified
Chris@0 480 def recipients
Chris@0 481 notified = project.notified_users
chris@37 482 # Author and assignee are always notified unless they have been
chris@37 483 # locked or don't want to be notified
chris@37 484 notified << author if author && author.active? && author.notify_about?(self)
chris@37 485 notified << assigned_to if assigned_to && assigned_to.active? && assigned_to.notify_about?(self)
Chris@0 486 notified.uniq!
Chris@0 487 # Remove users that can not view the issue
Chris@0 488 notified.reject! {|user| !visible?(user)}
Chris@0 489 notified.collect(&:mail)
Chris@0 490 end
Chris@441 491
Chris@0 492 # Returns the total number of hours spent on this issue and its descendants
Chris@0 493 #
Chris@0 494 # Example:
Chris@0 495 # spent_hours => 0.0
Chris@0 496 # spent_hours => 50.2
Chris@0 497 def spent_hours
Chris@0 498 @spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours", :include => :time_entries).to_f || 0.0
Chris@0 499 end
Chris@441 500
Chris@0 501 def relations
Chris@0 502 (relations_from + relations_to).sort
Chris@0 503 end
Chris@441 504
Chris@441 505 def all_dependent_issues(except=[])
Chris@441 506 except << self
Chris@0 507 dependencies = []
Chris@0 508 relations_from.each do |relation|
Chris@441 509 if relation.issue_to && !except.include?(relation.issue_to)
Chris@128 510 dependencies << relation.issue_to
Chris@128 511 dependencies += relation.issue_to.all_dependent_issues(except)
Chris@128 512 end
Chris@0 513 end
Chris@0 514 dependencies
Chris@0 515 end
Chris@441 516
Chris@0 517 # Returns an array of issues that duplicate this one
Chris@0 518 def duplicates
Chris@0 519 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
Chris@0 520 end
Chris@441 521
Chris@0 522 # Returns the due date or the target due date if any
Chris@0 523 # Used on gantt chart
Chris@0 524 def due_before
Chris@0 525 due_date || (fixed_version ? fixed_version.effective_date : nil)
Chris@0 526 end
Chris@441 527
Chris@0 528 # Returns the time scheduled for this issue.
Chris@441 529 #
Chris@0 530 # Example:
Chris@0 531 # Start Date: 2/26/09, End Date: 3/04/09
Chris@0 532 # duration => 6
Chris@0 533 def duration
Chris@0 534 (start_date && due_date) ? due_date - start_date : 0
Chris@0 535 end
Chris@441 536
Chris@0 537 def soonest_start
Chris@0 538 @soonest_start ||= (
Chris@0 539 relations_to.collect{|relation| relation.successor_soonest_start} +
Chris@0 540 ancestors.collect(&:soonest_start)
Chris@0 541 ).compact.max
Chris@0 542 end
Chris@441 543
Chris@0 544 def reschedule_after(date)
Chris@0 545 return if date.nil?
Chris@0 546 if leaf?
Chris@0 547 if start_date.nil? || start_date < date
Chris@0 548 self.start_date, self.due_date = date, date + duration
Chris@0 549 save
Chris@0 550 end
Chris@0 551 else
Chris@0 552 leaves.each do |leaf|
Chris@0 553 leaf.reschedule_after(date)
Chris@0 554 end
Chris@0 555 end
Chris@0 556 end
Chris@441 557
Chris@0 558 def <=>(issue)
Chris@0 559 if issue.nil?
Chris@0 560 -1
Chris@0 561 elsif root_id != issue.root_id
Chris@0 562 (root_id || 0) <=> (issue.root_id || 0)
Chris@0 563 else
Chris@0 564 (lft || 0) <=> (issue.lft || 0)
Chris@0 565 end
Chris@0 566 end
Chris@441 567
Chris@0 568 def to_s
Chris@0 569 "#{tracker} ##{id}: #{subject}"
Chris@0 570 end
Chris@441 571
Chris@0 572 # Returns a string of css classes that apply to the issue
Chris@0 573 def css_classes
Chris@112 574 s = "issue status-#{status.position} "
Chris@112 575 s << "priority-#{priority.position}"
Chris@0 576 s << ' closed' if closed?
Chris@0 577 s << ' overdue' if overdue?
Chris@441 578 s << ' child' if child?
Chris@441 579 s << ' parent' unless leaf?
Chris@441 580 s << ' private' if is_private?
Chris@0 581 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
Chris@0 582 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
Chris@0 583 s
Chris@0 584 end
Chris@0 585
Chris@0 586 # Saves an issue, time_entry, attachments, and a journal from the parameters
Chris@0 587 # Returns false if save fails
Chris@0 588 def save_issue_with_child_records(params, existing_time_entry=nil)
Chris@0 589 Issue.transaction do
Chris@441 590 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
Chris@0 591 @time_entry = existing_time_entry || TimeEntry.new
Chris@0 592 @time_entry.project = project
Chris@0 593 @time_entry.issue = self
Chris@0 594 @time_entry.user = User.current
Chris@0 595 @time_entry.spent_on = Date.today
Chris@0 596 @time_entry.attributes = params[:time_entry]
Chris@0 597 self.time_entries << @time_entry
Chris@0 598 end
Chris@441 599
Chris@0 600 if valid?
Chris@0 601 attachments = Attachment.attach_files(self, params[:attachments])
Chris@441 602
Chris@0 603 attachments[:files].each {|a| @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => a.id, :value => a.filename)}
Chris@0 604 # TODO: Rename hook
Chris@0 605 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
Chris@0 606 begin
Chris@0 607 if save
Chris@0 608 # TODO: Rename hook
Chris@0 609 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
Chris@0 610 else
Chris@0 611 raise ActiveRecord::Rollback
Chris@0 612 end
Chris@0 613 rescue ActiveRecord::StaleObjectError
Chris@0 614 attachments[:files].each(&:destroy)
Chris@0 615 errors.add_to_base l(:notice_locking_conflict)
Chris@0 616 raise ActiveRecord::Rollback
Chris@0 617 end
Chris@0 618 end
Chris@0 619 end
Chris@0 620 end
Chris@0 621
Chris@0 622 # Unassigns issues from +version+ if it's no longer shared with issue's project
Chris@0 623 def self.update_versions_from_sharing_change(version)
Chris@0 624 # Update issues assigned to the version
Chris@0 625 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
Chris@0 626 end
Chris@441 627
Chris@0 628 # Unassigns issues from versions that are no longer shared
Chris@0 629 # after +project+ was moved
Chris@0 630 def self.update_versions_from_hierarchy_change(project)
Chris@0 631 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
Chris@0 632 # Update issues of the moved projects and issues assigned to a version of a moved project
Chris@0 633 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
Chris@0 634 end
Chris@0 635
Chris@0 636 def parent_issue_id=(arg)
Chris@0 637 parent_issue_id = arg.blank? ? nil : arg.to_i
Chris@0 638 if parent_issue_id && @parent_issue = Issue.find_by_id(parent_issue_id)
Chris@0 639 @parent_issue.id
Chris@0 640 else
Chris@0 641 @parent_issue = nil
Chris@0 642 nil
Chris@0 643 end
Chris@0 644 end
Chris@441 645
Chris@0 646 def parent_issue_id
Chris@0 647 if instance_variable_defined? :@parent_issue
Chris@0 648 @parent_issue.nil? ? nil : @parent_issue.id
Chris@0 649 else
Chris@0 650 parent_id
Chris@0 651 end
Chris@0 652 end
Chris@0 653
Chris@0 654 # Extracted from the ReportsController.
Chris@0 655 def self.by_tracker(project)
Chris@0 656 count_and_group_by(:project => project,
Chris@0 657 :field => 'tracker_id',
Chris@0 658 :joins => Tracker.table_name)
Chris@0 659 end
Chris@0 660
Chris@0 661 def self.by_version(project)
Chris@0 662 count_and_group_by(:project => project,
Chris@0 663 :field => 'fixed_version_id',
Chris@0 664 :joins => Version.table_name)
Chris@0 665 end
Chris@0 666
Chris@0 667 def self.by_priority(project)
Chris@0 668 count_and_group_by(:project => project,
Chris@0 669 :field => 'priority_id',
Chris@0 670 :joins => IssuePriority.table_name)
Chris@0 671 end
Chris@0 672
Chris@0 673 def self.by_category(project)
Chris@0 674 count_and_group_by(:project => project,
Chris@0 675 :field => 'category_id',
Chris@0 676 :joins => IssueCategory.table_name)
Chris@0 677 end
Chris@0 678
Chris@0 679 def self.by_assigned_to(project)
Chris@0 680 count_and_group_by(:project => project,
Chris@0 681 :field => 'assigned_to_id',
Chris@0 682 :joins => User.table_name)
Chris@0 683 end
Chris@0 684
Chris@0 685 def self.by_author(project)
Chris@0 686 count_and_group_by(:project => project,
Chris@0 687 :field => 'author_id',
Chris@0 688 :joins => User.table_name)
Chris@0 689 end
Chris@0 690
Chris@0 691 def self.by_subproject(project)
Chris@0 692 ActiveRecord::Base.connection.select_all("select s.id as status_id,
Chris@0 693 s.is_closed as closed,
Chris@441 694 #{Issue.table_name}.project_id as project_id,
Chris@441 695 count(#{Issue.table_name}.id) as total
Chris@0 696 from
Chris@441 697 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
Chris@0 698 where
Chris@441 699 #{Issue.table_name}.status_id=s.id
Chris@441 700 and #{Issue.table_name}.project_id = #{Project.table_name}.id
Chris@441 701 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
Chris@441 702 and #{Issue.table_name}.project_id <> #{project.id}
Chris@441 703 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
Chris@0 704 end
Chris@0 705 # End ReportsController extraction
Chris@441 706
Chris@0 707 # Returns an array of projects that current user can move issues to
Chris@0 708 def self.allowed_target_projects_on_move
Chris@0 709 projects = []
Chris@0 710 if User.current.admin?
Chris@0 711 # admin is allowed to move issues to any active (visible) project
Chris@0 712 projects = Project.visible.all
Chris@0 713 elsif User.current.logged?
Chris@0 714 if Role.non_member.allowed_to?(:move_issues)
Chris@0 715 projects = Project.visible.all
Chris@0 716 else
Chris@0 717 User.current.memberships.each {|m| projects << m.project if m.roles.detect {|r| r.allowed_to?(:move_issues)}}
Chris@0 718 end
Chris@0 719 end
Chris@0 720 projects
Chris@0 721 end
Chris@441 722
Chris@0 723 private
Chris@441 724
Chris@0 725 def update_nested_set_attributes
Chris@0 726 if root_id.nil?
Chris@0 727 # issue was just created
Chris@0 728 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
Chris@0 729 set_default_left_and_right
Chris@0 730 Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
Chris@0 731 if @parent_issue
Chris@0 732 move_to_child_of(@parent_issue)
Chris@0 733 end
Chris@0 734 reload
Chris@0 735 elsif parent_issue_id != parent_id
Chris@0 736 former_parent_id = parent_id
Chris@0 737 # moving an existing issue
Chris@0 738 if @parent_issue && @parent_issue.root_id == root_id
Chris@0 739 # inside the same tree
Chris@0 740 move_to_child_of(@parent_issue)
Chris@0 741 else
Chris@0 742 # to another tree
Chris@0 743 unless root?
Chris@0 744 move_to_right_of(root)
Chris@0 745 reload
Chris@0 746 end
Chris@0 747 old_root_id = root_id
Chris@0 748 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
Chris@0 749 target_maxright = nested_set_scope.maximum(right_column_name) || 0
Chris@0 750 offset = target_maxright + 1 - lft
Chris@0 751 Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
Chris@0 752 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
Chris@0 753 self[left_column_name] = lft + offset
Chris@0 754 self[right_column_name] = rgt + offset
Chris@0 755 if @parent_issue
Chris@0 756 move_to_child_of(@parent_issue)
Chris@0 757 end
Chris@0 758 end
Chris@0 759 reload
Chris@0 760 # delete invalid relations of all descendants
Chris@0 761 self_and_descendants.each do |issue|
Chris@0 762 issue.relations.each do |relation|
Chris@0 763 relation.destroy unless relation.valid?
Chris@0 764 end
Chris@0 765 end
Chris@0 766 # update former parent
Chris@0 767 recalculate_attributes_for(former_parent_id) if former_parent_id
Chris@0 768 end
Chris@0 769 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
Chris@0 770 end
Chris@441 771
Chris@0 772 def update_parent_attributes
Chris@0 773 recalculate_attributes_for(parent_id) if parent_id
Chris@0 774 end
Chris@0 775
Chris@0 776 def recalculate_attributes_for(issue_id)
Chris@0 777 if issue_id && p = Issue.find_by_id(issue_id)
Chris@0 778 # priority = highest priority of children
Chris@0 779 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :include => :priority)
Chris@0 780 p.priority = IssuePriority.find_by_position(priority_position)
Chris@0 781 end
Chris@441 782
Chris@0 783 # start/due dates = lowest/highest dates of children
Chris@0 784 p.start_date = p.children.minimum(:start_date)
Chris@0 785 p.due_date = p.children.maximum(:due_date)
Chris@0 786 if p.start_date && p.due_date && p.due_date < p.start_date
Chris@0 787 p.start_date, p.due_date = p.due_date, p.start_date
Chris@0 788 end
Chris@441 789
Chris@0 790 # done ratio = weighted average ratio of leaves
chris@37 791 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
Chris@0 792 leaves_count = p.leaves.count
Chris@0 793 if leaves_count > 0
Chris@0 794 average = p.leaves.average(:estimated_hours).to_f
Chris@0 795 if average == 0
Chris@0 796 average = 1
Chris@0 797 end
Chris@0 798 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :include => :status).to_f
Chris@0 799 progress = done / (average * leaves_count)
Chris@0 800 p.done_ratio = progress.round
Chris@0 801 end
Chris@0 802 end
Chris@441 803
Chris@0 804 # estimate = sum of leaves estimates
Chris@0 805 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
Chris@0 806 p.estimated_hours = nil if p.estimated_hours == 0.0
Chris@441 807
Chris@0 808 # ancestors will be recursively updated
Chris@0 809 p.save(false)
Chris@0 810 end
Chris@0 811 end
Chris@441 812
Chris@0 813 # Update issues so their versions are not pointing to a
Chris@0 814 # fixed_version that is not shared with the issue's project
Chris@0 815 def self.update_versions(conditions=nil)
Chris@0 816 # Only need to update issues with a fixed_version from
Chris@0 817 # a different project and that is not systemwide shared
Chris@0 818 Issue.all(:conditions => merge_conditions("#{Issue.table_name}.fixed_version_id IS NOT NULL" +
Chris@0 819 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
Chris@0 820 " AND #{Version.table_name}.sharing <> 'system'",
Chris@0 821 conditions),
Chris@0 822 :include => [:project, :fixed_version]
Chris@0 823 ).each do |issue|
Chris@0 824 next if issue.project.nil? || issue.fixed_version.nil?
Chris@0 825 unless issue.project.shared_versions.include?(issue.fixed_version)
Chris@0 826 issue.init_journal(User.current)
Chris@0 827 issue.fixed_version = nil
Chris@0 828 issue.save
Chris@0 829 end
Chris@0 830 end
Chris@0 831 end
Chris@441 832
Chris@0 833 # Callback on attachment deletion
Chris@0 834 def attachment_removed(obj)
Chris@0 835 journal = init_journal(User.current)
Chris@0 836 journal.details << JournalDetail.new(:property => 'attachment',
Chris@0 837 :prop_key => obj.id,
Chris@0 838 :old_value => obj.filename)
Chris@0 839 journal.save
Chris@0 840 end
Chris@441 841
Chris@0 842 # Default assignment based on category
Chris@0 843 def default_assign
Chris@0 844 if assigned_to.nil? && category && category.assigned_to
Chris@0 845 self.assigned_to = category.assigned_to
Chris@0 846 end
Chris@0 847 end
Chris@0 848
Chris@0 849 # Updates start/due dates of following issues
Chris@0 850 def reschedule_following_issues
Chris@0 851 if start_date_changed? || due_date_changed?
Chris@0 852 relations_from.each do |relation|
Chris@0 853 relation.set_issue_to_dates
Chris@0 854 end
Chris@0 855 end
Chris@0 856 end
Chris@0 857
Chris@0 858 # Closes duplicates if the issue is being closed
Chris@0 859 def close_duplicates
Chris@0 860 if closing?
Chris@0 861 duplicates.each do |duplicate|
Chris@0 862 # Reload is need in case the duplicate was updated by a previous duplicate
Chris@0 863 duplicate.reload
Chris@0 864 # Don't re-close it if it's already closed
Chris@0 865 next if duplicate.closed?
Chris@0 866 # Same user and notes
Chris@0 867 if @current_journal
Chris@0 868 duplicate.init_journal(@current_journal.user, @current_journal.notes)
Chris@0 869 end
Chris@0 870 duplicate.update_attribute :status, self.status
Chris@0 871 end
Chris@0 872 end
Chris@0 873 end
Chris@441 874
Chris@0 875 # Saves the changes in a Journal
Chris@0 876 # Called after_save
Chris@0 877 def create_journal
Chris@0 878 if @current_journal
Chris@0 879 # attributes changes
Chris@245 880 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on)).each {|c|
Chris@507 881 before = @issue_before_change.send(c)
Chris@507 882 after = send(c)
Chris@507 883 next if before == after || (before.blank? && after.blank?)
Chris@0 884 @current_journal.details << JournalDetail.new(:property => 'attr',
Chris@0 885 :prop_key => c,
Chris@0 886 :old_value => @issue_before_change.send(c),
Chris@507 887 :value => send(c))
Chris@0 888 }
Chris@0 889 # custom fields changes
Chris@0 890 custom_values.each {|c|
Chris@0 891 next if (@custom_values_before_change[c.custom_field_id]==c.value ||
Chris@0 892 (@custom_values_before_change[c.custom_field_id].blank? && c.value.blank?))
Chris@441 893 @current_journal.details << JournalDetail.new(:property => 'cf',
Chris@0 894 :prop_key => c.custom_field_id,
Chris@0 895 :old_value => @custom_values_before_change[c.custom_field_id],
Chris@0 896 :value => c.value)
Chris@441 897 }
Chris@0 898 @current_journal.save
Chris@0 899 # reset current journal
Chris@0 900 init_journal @current_journal.user, @current_journal.notes
Chris@0 901 end
Chris@0 902 end
Chris@0 903
Chris@0 904 # Query generator for selecting groups of issue counts for a project
Chris@0 905 # based on specific criteria
Chris@0 906 #
Chris@0 907 # Options
Chris@0 908 # * project - Project to search in.
Chris@0 909 # * field - String. Issue field to key off of in the grouping.
Chris@0 910 # * joins - String. The table name to join against.
Chris@0 911 def self.count_and_group_by(options)
Chris@0 912 project = options.delete(:project)
Chris@0 913 select_field = options.delete(:field)
Chris@0 914 joins = options.delete(:joins)
Chris@0 915
Chris@441 916 where = "#{Issue.table_name}.#{select_field}=j.id"
Chris@441 917
Chris@0 918 ActiveRecord::Base.connection.select_all("select s.id as status_id,
Chris@0 919 s.is_closed as closed,
Chris@0 920 j.id as #{select_field},
Chris@441 921 count(#{Issue.table_name}.id) as total
Chris@0 922 from
Chris@441 923 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
Chris@0 924 where
Chris@441 925 #{Issue.table_name}.status_id=s.id
Chris@0 926 and #{where}
Chris@441 927 and #{Issue.table_name}.project_id=#{Project.table_name}.id
Chris@441 928 and #{visible_condition(User.current, :project => project)}
Chris@0 929 group by s.id, s.is_closed, j.id")
Chris@0 930 end
Chris@0 931 end