comparison main/PreferencesDialog.cpp @ 163:652b22dcd4ed

* Add mouse actions to key and mouse reference dialog
* Use QDialogButtonBox in all dialogs, for proper button ordering across
  platforms (requires Qt 4.2)
* Fix #1733610 program does not exit if preferences dialog visible on close

 #include <QDoubleSpinBox>
 #include <QLabel>
 #include <QPushButton>
 #include <QHBoxLayout>
 #include <QString>
+#include <QDialogButtonBox>
+#include <QMessageBox>
 
 #include "widgets/WindowTypeSelector.h"
 #include "base/Preferences.h"
 
 PreferencesDialog::PreferencesDialog(QWidget *parent, Qt::WFlags flags) :
     QDialog(parent, flags)
 {
-    setWindowTitle(tr("Application Preferences"));
+    setWindowTitle(tr("Sonic Visualiser: Application Preferences"));
 
     Preferences *prefs = Preferences::getInstance();
 
     QGridLayout *grid = new QGridLayout;
     setLayout(grid);
     
     QGroupBox *groupBox = new QGroupBox;
-    groupBox->setTitle(tr("Sonic Visualiser Application Preferences"));
+    groupBox->setTitle(tr("Application Preferences"));
     grid->addWidget(groupBox, 0, 0);
     
     QGridLayout *subgrid = new QGridLayout;
     groupBox->setLayout(subgrid);
 

                        row, 0);
     subgrid->addWidget(m_windowTypeSelector, row++, 1, 2, 2);
     subgrid->setRowStretch(row, 10);
     row++;
     
-    QHBoxLayout *hbox = new QHBoxLayout;
-    grid->addLayout(hbox, 1, 0);
+    QDialogButtonBox *bb = new QDialogButtonBox(Qt::Horizontal);
+    grid->addWidget(bb, 1, 0);
     
     QPushButton *ok = new QPushButton(tr("OK"));
     QPushButton *cancel = new QPushButton(tr("Cancel"));
-    hbox->addStretch(10);
-    hbox->addWidget(ok);
-    hbox->addWidget(m_applyButton);
-    hbox->addWidget(cancel);
+    bb->addButton(ok, QDialogButtonBox::AcceptRole);
+    bb->addButton(m_applyButton, QDialogButtonBox::ApplyRole);
+    bb->addButton(cancel, QDialogButtonBox::RejectRole);
     connect(ok, SIGNAL(clicked()), this, SLOT(okClicked()));
     connect(m_applyButton, SIGNAL(clicked()), this, SLOT(applyClicked()));
     connect(cancel, SIGNAL(clicked()), this, SLOT(cancelClicked()));
 
     m_applyButton->setEnabled(false);

 PreferencesDialog::cancelClicked()
 {
     reject();
 }
 
+void
+PreferencesDialog::applicationClosing(bool quickly)
+{
+    if (quickly) {
+        reject();
+        return;
+    }
+
+    if (m_applyButton->isEnabled()) {
+        int rv = QMessageBox::warning
+            (this, tr("Preferences Changed"),
+             tr("Some preferences have been changed but not applied.\n"
+                "Apply them before closing?"),
+             QMessageBox::Apply | QMessageBox::Discard,
+             QMessageBox::Discard);
+        if (rv == QMessageBox::Apply) {
+            applyClicked();
+            accept();
+        } else {
+            reject();
+        }
+    } else {
+        accept();
+    }
+}
+