comparison transform/TransformFactory.cpp @ 27:61259228d029

* More to do with passing around step/blocksize etc from plugin dialog to
  plugins.  Still some puzzling unresolved details.

 }
 
 bool
 TransformFactory::getConfigurationForTransform(TransformName name,
                                                Model *inputModel,
-                                               int &channel,
+                                               PluginTransform::ExecutionContext &context,
                                                QString &configurationXml)
 {
     QString id = name.section(':', 0, 2);
     QString output = name.section(':', 3);
     

         plugin = RealTimePluginFactory::instanceFor(id)->instantiatePlugin
             (id, 0, 0, inputModel->getSampleRate(), 1024, 1);
     }
 
     if (plugin) {
+
+        context = PluginTransform::ExecutionContext(context.channel, plugin);
+
         if (configurationXml != "") {
             PluginXml(plugin).setParametersFromXml(configurationXml);
         }
 
         int sourceChannels = 1;

 
         int targetChannels = sourceChannels;
         if (sourceChannels < minChannels) targetChannels = minChannels;
         if (sourceChannels > maxChannels) targetChannels = maxChannels;
 
-        int defaultChannel = channel;
+        int defaultChannel = context.channel;
 
         PluginParameterDialog *dialog = new PluginParameterDialog(plugin,
                                                                   sourceChannels,
                                                                   targetChannels,
                                                                   defaultChannel,

                                                                   frequency);
         if (dialog->exec() == QDialog::Accepted) {
             ok = true;
         }
         configurationXml = PluginXml(plugin).toXmlString();
-        channel = dialog->getChannel();
-
-        //!!! where now for step size, block size, etc?
-//        dialog->getProcessingParameters(stepSize, blockSize, windowType);
+        context.channel = dialog->getChannel();
+
+        dialog->getProcessingParameters(context.stepSize,
+                                        context.blockSize,
+                                        context.windowType);
+
+        context.makeConsistentWithPlugin(plugin);
 
         delete dialog;
         delete plugin;
     }
 

     return ok;
 }
 
 Transform *
 TransformFactory::createTransform(TransformName name, Model *inputModel,
-                                  int channel, QString configurationXml, bool start)
+                                  const PluginTransform::ExecutionContext &context,
+                                  QString configurationXml, bool start)
 {
     Transform *transform = 0;
 
-    //!!! use channel
-    
     QString id = name.section(':', 0, 2);
     QString output = name.section(':', 3);
 
     if (FeatureExtractionPluginFactory::instanceFor(id)) {
         transform = new FeatureExtractionPluginTransform(inputModel,
                                                          id,
-                                                         channel,
+                                                         context,
                                                          configurationXml,
                                                          output);
     } else if (RealTimePluginFactory::instanceFor(id)) {
         transform = new RealTimePluginTransform(inputModel,
                                                 id,
-                                                channel,
+                                                context,
                                                 configurationXml,
                                                 getTransformUnits(name),
                                                 output.toInt());
     } else {
         std::cerr << "TransformFactory::createTransform: Unknown transform \""

     return transform;
 }
 
 Model *
 TransformFactory::transform(TransformName name, Model *inputModel,
-                            int channel, QString configurationXml)
-{
-    Transform *t = createTransform(name, inputModel, channel,
+                            const PluginTransform::ExecutionContext &context,
+                            QString configurationXml)
+{
+    Transform *t = createTransform(name, inputModel, context,
                                    configurationXml, false);
 
     if (!t) return 0;
 
     connect(t, SIGNAL(finished()), this, SLOT(transformFinished()));