changeset 24:18c42fbc1335

* Various fixes: ensure CSV feature writer closes files when finished with (rather than at end of run) to avoid running out of fds; bail properly with an exception with CSV writer can't write to output file; and other minor things
author Chris Cannam
date Tue, 08 Sep 2009 16:51:24 +0000
parents 1a9ad8f3a98f
children af5e469ac654
files INSTALL runner/AudioDBFeatureWriter.h runner/DefaultFeatureWriter.h runner/main.cpp
diffstat 4 files changed, 8 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/INSTALL	Tue Jul 07 11:49:56 2009 +0000
+++ b/INSTALL	Tue Sep 08 16:51:24 2009 +0000
@@ -27,9 +27,9 @@
 1.0.8 or newer.
 
 If you happen to be using a Debian-based Linux, you probably want to
-apt-get install the following packages: libqt4-dev libsndfile1-dev
-libsamplerate0-dev fftw3-dev libmad0-dev liboggz1-dev
-libfishsound1-dev liblrdf0-dev librdf0-dev .
+apt-get install the following packages: libqt4-dev libsndfile1-dev \
+libsamplerate0-dev fftw3-dev libmad0-dev liboggz1-dev \
+libfishsound1-dev liblrdf0-dev librdf0-dev libbz2-dev libasound2-dev .
 
 If you are building on a Unix-like system that supports pkg-config and
 uses it for all appropriate libraries (such as a modern Linux
--- a/runner/AudioDBFeatureWriter.h	Tue Jul 07 11:49:56 2009 +0000
+++ b/runner/AudioDBFeatureWriter.h	Tue Sep 08 16:51:24 2009 +0000
@@ -44,6 +44,8 @@
     
     virtual void finish() { }
 
+    virtual QString getWriterTag() const { return "audiodb"; }
+
 private:
     string catalogueId;
     string baseDir;
--- a/runner/DefaultFeatureWriter.h	Tue Jul 07 11:49:56 2009 +0000
+++ b/runner/DefaultFeatureWriter.h	Tue Sep 08 16:51:24 2009 +0000
@@ -29,6 +29,7 @@
                        const Vamp::Plugin::FeatureList &features,
                        std::string summaryType = "");
     virtual void finish() { }
+    virtual QString getWriterTag() const { return "default"; }
 };
 
 #endif
--- a/runner/main.cpp	Tue Jul 07 11:49:56 2009 +0000
+++ b/runner/main.cpp	Tue Sep 08 16:51:24 2009 +0000
@@ -728,6 +728,8 @@
         } catch (const std::exception &e) {
             cerr << "ERROR: Failed to process file \"" << i->toStdString()
                  << "\": " << e.what() << endl;
+            cerr << "NOTE: If you want to continue with processing any further files after an" << endl
+                 << "error like this, use the --force option" << endl;
             if (force) {
                 // print a note only if we have more files to process
                 QStringList::const_iterator j = i;