comparison runner/FeatureExtractionManager.cpp @ 31:8b20521fc40f

* Commit old fix (which I hope was correct!) to avoid leaking fds on
  exceptions
* Remove dependency on audioio library

 
 void FeatureExtractionManager::extractFeatures(QString audioSource)
 {
     if (m_plugins.empty()) return;
 
+    testOutputFiles(audioSource);
+
     ProgressPrinter retrievalProgress("Retrieving audio data...");
 
     FileSource source(audioSource, &retrievalProgress);
     if (!source.isAvailable()) {
         cerr << "ERROR: File or URL \"" << audioSource.toStdString()

 
     cerr << "Opened " << channels << "-channel file or URL \"" << audioSource.toStdString() << "\"" << endl;
 
     // reject file if it has too few channels, plugin will handle if it has too many
     if ((int)channels < m_channels) {
+        delete reader;
         throw FileOperationFailed
             (audioSource,
              QString("read sufficient channels (found %1, require %2)")
              .arg(channels).arg(m_channels));
     }

     // allocate audio buffers
     float **data = new float *[m_channels];
     for (int c = 0; c < m_channels; ++c) {
         data[c] = new float[m_blockSize];
     }
+    
+    struct LifespanMgr { // unintrusive hack introduced to ensure
+                         // destruction on exceptions
+        AudioFileReader *m_r;
+        int m_c;
+        float **m_d;
+        LifespanMgr(AudioFileReader *r, int c, float **d) :
+            m_r(r), m_c(c), m_d(d) { }
+        ~LifespanMgr() { destroy(); }
+        void destroy() {
+            if (!m_r) return;
+            delete m_r;
+            for (int i = 0; i < m_c; ++i) delete[] m_d[i];
+            delete[] m_d;
+            m_r = 0;
+        }
+    };
+    LifespanMgr lifemgr(reader, m_channels, data);
 
     size_t frameCount = reader->getFrameCount();
     
 //    cerr << "file has " << frameCount << " frames" << endl;
 

         if (progress > pp) extractionProgress.setProgress(progress);
     }
 
 //    std::cerr << "FeatureExtractionManager: deleting audio file reader" << std::endl;
 
-    delete reader;
+    lifemgr.destroy(); // deletes reader, data
     
     for (PluginMap::iterator pi = m_plugins.begin();
          pi != m_plugins.end(); ++pi) { 
 
         Plugin *plugin = pi->first;

                  Transform::summaryTypeToString(summaryType).toStdString());
         }
     }
 }
 
+void FeatureExtractionManager::testOutputFiles(QString audioSource)
+{
+    for (PluginMap::iterator pi = m_plugins.begin();
+         pi != m_plugins.end(); ++pi) {
+
+        for (TransformWriterMap::iterator ti = pi->second.begin();
+             ti != pi->second.end(); ++ti) {
+        
+            vector<FeatureWriter *> &writers = ti->second;
+
+            for (int i = 0; i < (int)writers.size(); ++i) {
+                writers[i]->testOutputFile(audioSource, ti->first.getIdentifier());
+            }
+        }
+    }
+}
+
 void FeatureExtractionManager::finish()
 {
     for (PluginMap::iterator pi = m_plugins.begin();
          pi != m_plugins.end(); ++pi) {