# HG changeset patch
# User Chris Cannam
# Date 1406366281 -3600
# Node ID 10d8bd634a7715a40cc790d2eef5d838d1231a58
# Parent  62b92d9b566ad375297f763bbf3407a3546c7f06
Docs, fix to temporary file removal in test script

diff -r 62b92d9b566a -r 10d8bd634a77 src/Silvet.cpp
--- a/src/Silvet.cpp	Wed Jul 23 18:36:41 2014 +0100
+++ b/src/Silvet.cpp	Sat Jul 26 10:18:01 2014 +0100
@@ -133,7 +133,7 @@
     desc.identifier = "mode";
     desc.name = "Processing mode";
     desc.unit = "";
-    desc.description = "Determines the tradeoff of processing speed against transcription quality";
+    desc.description = "Sets the tradeoff of processing speed against transcription quality. Draft mode modifies a number of internal parameters in favour of speed. Intensive mode (the default) will almost always produce better results.";
     desc.minValue = 0;
     desc.maxValue = 1;
     desc.defaultValue = 1;
@@ -146,7 +146,7 @@
     desc.identifier = "instrument";
     desc.name = "Instrument";
     desc.unit = "";
-    desc.description = "The instrument known to be present in the recording, if there is only one";
+    desc.description = "The instrument or instruments known to be present in the recording. This affects the set of instrument templates used, as well as the expected level of polyphony in the output. Using a more limited set of instruments than the default will also make the plugin run faster.\nNote that this plugin cannot isolate instruments: you can't use this setting to request notes from only one instrument in a recording with several. Instead, use this as a hint to the plugin about which instruments are actually present.";
     desc.minValue = 0;
     desc.maxValue = m_instruments.size()-1;
     desc.defaultValue = 0;
@@ -161,7 +161,7 @@
     desc.identifier = "finetune";
     desc.name = "Return fine pitch estimates";
     desc.unit = "";
-    desc.description = "Return pitch estimates at finer than semitone resolution (works only in Intensive mode)";
+    desc.description = "Return pitch estimates at finer than semitone resolution. This works only in Intensive mode. Notes that appear to drift in pitch will be split up into shorter notes with individually finer pitches.";
     desc.minValue = 0;
     desc.maxValue = 1;
     desc.defaultValue = 0;
@@ -224,7 +224,7 @@
     OutputDescriptor d;
     d.identifier = "notes";
     d.name = "Note transcription";
-    d.description = "Overall note transcription across selected instruments";
+    d.description = "Overall note transcription. Each note has time, duration, estimated pitch, and a synthetic MIDI velocity (1-127) estimated from the strength of the pitch in the mixture.";
     d.unit = "Hz";
     d.hasFixedBinCount = true;
     d.binCount = 2;
@@ -240,7 +240,7 @@
 
     d.identifier = "timefreq";
     d.name = "Time-frequency distribution";
-    d.description = "Filtered constant-Q time-frequency distribution used as input to the expectation-maximisation algorithm";
+    d.description = "Filtered constant-Q time-frequency distribution as used as input to the expectation-maximisation algorithm.";
     d.unit = "";
     d.hasFixedBinCount = true;
     d.binCount = m_instruments[0].templateHeight;
diff -r 62b92d9b566a -r 10d8bd634a77 testdata/evaluation/run-piano.sh
--- a/testdata/evaluation/run-piano.sh	Wed Jul 23 18:36:41 2014 +0100
+++ b/testdata/evaluation/run-piano.sh	Sat Jul 26 10:18:01 2014 +0100
@@ -42,7 +42,7 @@
 
 transfile="/tmp/$$transform.ttl"
 
-trap 'rm -f "$outfile" "$tmpwav" "$instfile" "$transfile" "$outfile.lab"' 0
+trap 'rm -f "$outfile" "$tmpwav" "$transfile" "$reference.lab" "$outfile.lab"' 0
 
 infiles=$(find "$piano_path" -name \*.wav | sort)
 
@@ -114,8 +114,6 @@
 		    echo "Validating against ground truth at $ms ms:"
 		    egrep '(^[0-9]\.)|(^[012][0-9]\.)' "../piano-groundtruth/$filename.lab" > "$reference.lab"
 		    "$yc" ../scripts/evaluate_lab.yeti "$ms" "$reference.lab" "$outfile.lab" | sed 's,$,'"$mark"','
-		    cp "$reference.lab" /tmp/reference.lab
-		    cp "$outfile.lab" /tmp/detected.lab
 		done;
 		echo
 	    done