# HG changeset patch
# User Chris Cannam <c.cannam@qmul.ac.uk>
# Date 1244464268 0
# Node ID 2416ef0e931965fdd105db0af77afd57b5987371
# Parent  4a354c18e688782669317850d6dba202ee3a9ae2
* Some fixes prompted by vamp-plugin-tester

diff -r 4a354c18e688 -r 2416ef0e9319 plugins/BeatTrack.cpp
--- a/plugins/BeatTrack.cpp	Fri Jun 05 15:22:04 2009 +0000
+++ b/plugins/BeatTrack.cpp	Mon Jun 08 12:31:08 2009 +0000
@@ -106,7 +106,7 @@
 
     desc.identifier = "method";
     desc.name = "Beat Tracking Method";
-    desc.description = ""; //!!!
+    desc.description = "Basic method to use ";
     desc.minValue = 0;
     desc.maxValue = 1;
     desc.defaultValue = METHOD_NEW;
diff -r 4a354c18e688 -r 2416ef0e9319 plugins/DWT.cpp
--- a/plugins/DWT.cpp	Fri Jun 05 15:22:04 2009 +0000
+++ b/plugins/DWT.cpp	Mon Jun 08 12:31:08 2009 +0000
@@ -151,7 +151,7 @@
  
     d.identifier = "wavelet";
     d.name = "Wavelet";
-    d.description = "";
+    d.description = "Wavelet type to use";
     d.unit = "";
     d.minValue = 0.f;
     d.maxValue = int(Wavelet::LastType);
diff -r 4a354c18e688 -r 2416ef0e9319 plugins/TonalChangeDetect.cpp
--- a/plugins/TonalChangeDetect.cpp	Fri Jun 05 15:22:04 2009 +0000
+++ b/plugins/TonalChangeDetect.cpp	Mon Jun 08 12:31:08 2009 +0000
@@ -68,8 +68,8 @@
     //    m_stepDelay = m_stepDelay / stepSize;
     m_stepDelay = (blockSize - stepSize) / stepSize; //!!! why? seems about right to look at, but...
 	
-    std::cerr << "TonalChangeDetect::initialise: step " << stepSize << ", block "
-              << blockSize << ", delay " << m_stepDelay << std::endl;
+//    std::cerr << "TonalChangeDetect::initialise: step " << stepSize << ", block "
+//              << blockSize << ", delay " << m_stepDelay << std::endl;
 	
     m_vaCurrentVector.resize(12, 0.0);
 	
@@ -99,7 +99,7 @@
 
 int TonalChangeDetect::getPluginVersion() const
 {
-    return 1;
+    return 2;
 }
 
 std::string TonalChangeDetect::getCopyright() const
@@ -114,6 +114,7 @@
     ParameterDescriptor desc;
     desc.identifier = "smoothingwidth";
     desc.name = "Gaussian smoothing";
+    desc.description = "Window length for the internal smoothing operation, in chroma analysis frames";
     desc.unit = "frames";
     desc.minValue = 0;
     desc.maxValue = 20;
@@ -125,6 +126,7 @@
     desc.identifier = "minpitch";
     desc.name = "Chromagram minimum pitch";
     desc.unit = "MIDI units";
+    desc.description = "Lowest pitch in MIDI units to be included in the chroma analysis";
     desc.minValue = 0;
     desc.maxValue = 127;
     desc.defaultValue = 32;
@@ -135,6 +137,7 @@
     desc.identifier = "maxpitch";
     desc.name = "Chromagram maximum pitch";
     desc.unit = "MIDI units";
+    desc.description = "Highest pitch in MIDI units to be included in the chroma analysis";
     desc.minValue = 0;
     desc.maxValue = 127;
     desc.defaultValue = 108;
@@ -145,6 +148,7 @@
     desc.identifier = "tuning";
     desc.name = "Chromagram tuning frequency";
     desc.unit = "Hz";
+    desc.description = "Frequency of concert A in the music under analysis";
     desc.minValue = 420;
     desc.maxValue = 460;
     desc.defaultValue = 440;
@@ -222,7 +226,7 @@
     }
     while (!m_pending.empty()) m_pending.pop();
 	
-    m_vaCurrentVector.resize(12, 0.0);
+    m_vaCurrentVector.clear();
 
     m_origin = Vamp::RealTime::zeroTime;
     m_haveOrigin = false;
@@ -260,6 +264,7 @@
     hc.identifier = "tcstransform";
     hc.name = "Transform to 6D Tonal Content Space";
     hc.unit = "";
+    hc.description = "Representation of content in a six-dimensional tonal space";
     hc.hasFixedBinCount = true;
     hc.binCount = 6;
     hc.hasKnownExtents = true;
@@ -272,6 +277,7 @@
     d.identifier = "tcfunction";
     d.name = "Tonal Change Detection Function";
     d.unit = "";
+    d.description = "Estimate of the likelihood of a tonal change occurring within each spectral frame";
     d.minValue = 0;
     d.minValue = 2;
     d.hasFixedBinCount = true;
@@ -286,6 +292,7 @@
     changes.identifier = "changepositions";
     changes.name = "Tonal Change Positions";
     changes.unit = "";
+    changes.description = "Estimated locations of tonal changes";
     changes.hasFixedBinCount = true;
     changes.binCount = 0;
     changes.hasKnownExtents = false;