comparison bits/PreservingPluginOutputIdMapper.h @ 60:8a4bcb3dc3a6

Replace exceptions throughout the JSON-handling and adapter code with string-arg error handling. No longer need exception handling enabled in Emscripten (with its consequent runtime overhead - though we still need to check whether this error handling regime is actually faster).

 class PreservingPluginOutputIdMapper : public PluginOutputIdMapper
 {
 public:
     PreservingPluginOutputIdMapper() { }
 
-    virtual int idToIndex(std::string outputId) const {
+    virtual int idToIndex(std::string outputId) const noexcept {
 	int n = int(m_ids.size());
 	int i = 0;
 	while (i < n) {
 	    if (outputId == m_ids[i]) {
 		return i;

 	}
 	m_ids.push_back(outputId);
 	return i;
     }
 
-    virtual std::string indexToId(int index) const {
-	//!!! todo: this should in fact throw, or otherwise return an error
+    virtual std::string indexToId(int index) const noexcept {
+        if (index < 0 || size_t(index) >= m_ids.size()) return "";
 	return m_ids[index];
     }
 
 private:
     mutable std::vector<std::string> m_ids;