comparison vamp-server/convert.cpp @ 176:60dc013bd69c

Fix handling of parsing json error responses from a server, and allow for re-writing them without changing the error message further.

          VampJson::BufferSerialisation::Array);
 
     Json id = writeJsonId(rr.id);
 
     if (!rr.success) {
-
-        j = VampJson::fromError(rr.errorText, rr.type, id);
-
-    } else {
-    
+         // errorText here likely contains a full message produced by simple-server
+         // setting writeVerbatimError to true avoids doubling error descriptions 
+        j = VampJson::fromError(rr.errorText, rr.type, id, true);
+
+    } else {
         switch (rr.type) {
 
         case RRType::List:
             j = VampJson::fromRpcResponse_List(rr.listResponse, id);
             break;

     eof = false;
     
     if (format == "json") {
         string err;
         auto result = readInputJson(direction, err, eof);
-        if (err != "") throw runtime_error(err);
-        else return result;
+        const bool isRecognisedError = !result.success && result.errorText != "";
+        
+        // if the RequestOrResponse (result) has been populated with success=false and an error message
+        // then the server returned a well formed error, it is safe to return it for conversion 
+        // -- but if err is populated, something else has gone wrong
+        if (isRecognisedError || err == "") 
+            return result;
+        else 
+            throw runtime_error(err);
     } else if (format == "capnp") {
         return readInputCapnp(direction, eof);
     } else {
         throw runtime_error("unknown input format \"" + format + "\"");
     }

             if (eof) break;
 
             writeOutput(outformat, rr);
 
         } catch (std::exception &e) {
-
             cerr << "Error: " << e.what() << endl;
             exit(1);
         }
     }